[GitHub] vedulasantosh commented on a change in pull request #2240: CLOUDSTACK-10051 Mouse Scrolling is not working in instance VM console

2017-10-17 Thread git
@@ +/* Review comment: @rhtyd can you please review these changes. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment

[GitHub] blueorangutan commented on issue #2226: CLOUDSTACK-10012: Towards CloudStack fat jar

2017-10-17 Thread git
This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services

[GitHub] rhtyd commented on issue #2226: CLOUDSTACK-10012: Towards CloudStack fat jar

2017-10-17 Thread git
, UI edits etc - WIP SSL keystore/cert management This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about

[GitHub] rhtyd commented on issue #2226: CLOUDSTACK-10012: Towards CloudStack fat jar

2017-10-17 Thread git
This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org

[GitHub] marcaurele commented on issue #2226: CLOUDSTACK-10012: Towards CloudStack fat jar

2017-10-17 Thread git
. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards

[GitHub] blueorangutan commented on issue #2226: CLOUDSTACK-10012: Towards CloudStack fat jar

2017-10-17 Thread git
. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards

[GitHub] rhtyd commented on issue #2226: CLOUDSTACK-10012: Towards CloudStack fat jar

2017-10-17 Thread git
rhtyd commented on issue #2226: CLOUDSTACK-10012: Towards CloudStack fat jar URL: https://github.com/apache/cloudstack/pull/2226#issuecomment-337169794 @blueorangutan package This is an automated message from the Apache Git

[GitHub] blueorangutan commented on issue #2226: CLOUDSTACK-10012: Towards CloudStack fat jar

2017-10-17 Thread git
. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards

[GitHub] blueorangutan commented on issue #2226: CLOUDSTACK-10012: Towards CloudStack fat jar

2017-10-17 Thread git
This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services

[GitHub] blueorangutan commented on issue #2226: CLOUDSTACK-10012: Towards CloudStack fat jar

2017-10-17 Thread git
. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards

[GitHub] rhtyd commented on issue #2226: CLOUDSTACK-10012: Towards CloudStack fat jar

2017-10-17 Thread git
rhtyd commented on issue #2226: CLOUDSTACK-10012: Towards CloudStack fat jar URL: https://github.com/apache/cloudstack/pull/2226#issuecomment-337148159 @blueorangutan package This is an automated message from the Apache Git

[GitHub] rhtyd commented on issue #2226: CLOUDSTACK-10012: Towards CloudStack fat jar

2017-10-17 Thread git
? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git

[GitHub] marcaurele commented on issue #2226: CLOUDSTACK-10012: Towards CloudStack fat jar

2017-10-17 Thread git
jar afterwards. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact

[GitHub] blueorangutan commented on issue #2291: [CLOUDSTACK-10111] Fix validation for parameter "vm.password.length"

2017-10-16 Thread git
mulator.py test_deploy_vgpu_enabled_vm | Skipped | 0.03 | test_deploy_vgpu_enabled_vm.py test_3d_gpu_support | Skipped | 0.04 | test_deploy_vgpu_enabled_vm.py This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] blueorangutan commented on issue #2226: CLOUDSTACK-10012: Towards CloudStack fat jar

2017-10-16 Thread git
| test_deploy_vgpu_enabled_vm.py This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] krissterckx commented on a change in pull request #2250: CLOUDSTACK-10057: listNetworkOfferings now returns the correct number of offerings.

2017-10-16 Thread git
edOfferings.size()); Review comment: LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries abou

[GitHub] blueorangutan commented on issue #2226: CLOUDSTACK-10012: Towards CloudStack fat jar

2017-10-16 Thread git
This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services

[GitHub] mike-tutkowski commented on issue #2298: CLOUDSTACK-9620: Enhancements for managed storage

2017-10-16 Thread git
message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services

[GitHub] mike-tutkowski opened a new pull request #2298: CLOUDSTACK-9620: Enhancements for managed storage

2017-10-16 Thread git
This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards

[GitHub] rhtyd commented on issue #2226: CLOUDSTACK-10012: Towards CloudStack fat jar

2017-10-16 Thread git
or exceptions, can you suggest a way to reproduce the error? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about

[GitHub] marcaurele commented on issue #2226: CLOUDSTACK-10012: Towards CloudStack fat jar

2017-10-16 Thread git
those. Otherwise you'll get an exception when reaching the code that uses bouncycastle lib `JCE cannot authenticate the provider BC` This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] blueorangutan commented on issue #2226: CLOUDSTACK-10012: Towards CloudStack fat jar

2017-10-16 Thread git
. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards

[GitHub] rhtyd commented on issue #2226: CLOUDSTACK-10012: Towards CloudStack fat jar

2017-10-16 Thread git
rhtyd commented on issue #2226: CLOUDSTACK-10012: Towards CloudStack fat jar URL: https://github.com/apache/cloudstack/pull/2226#issuecomment-336984459 @blueorangutan package This is an automated message from the Apache Git

[GitHub] blueorangutan commented on issue #2226: CLOUDSTACK-10012: Towards CloudStack fat jar

2017-10-16 Thread git
This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services

[GitHub] blueorangutan commented on issue #2226: CLOUDSTACK-10012: Towards CloudStack fat jar

2017-10-16 Thread git
. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards

[GitHub] rhtyd commented on issue #2226: CLOUDSTACK-10012: Towards CloudStack fat jar

2017-10-16 Thread git
rhtyd commented on issue #2226: CLOUDSTACK-10012: Towards CloudStack fat jar URL: https://github.com/apache/cloudstack/pull/2226#issuecomment-336959222 @blueorangutan package This is an automated message from the Apache Git

[GitHub] borisstoyanov commented on issue #2291: [CLOUDSTACK-10111] Fix validation for parameter "vm.password.length"

2017-10-16 Thread git
gutan test This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services

[GitHub] blueorangutan commented on issue #2291: [CLOUDSTACK-10111] Fix validation for parameter "vm.password.length"

2017-10-16 Thread git
. JID-1165 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services

[GitHub] blueorangutan commented on issue #2291: [CLOUDSTACK-10111] Fix validation for parameter "vm.password.length"

2017-10-16 Thread git
e progress. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastruct

[GitHub] borisstoyanov commented on issue #2291: [CLOUDSTACK-10111] Fix validation for parameter "vm.password.length"

2017-10-16 Thread git
an package This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services

[GitHub] blueorangutan commented on issue #2226: CLOUDSTACK-10012: Towards CloudStack fat jar

2017-10-16 Thread git
This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org

[GitHub] blueorangutan commented on issue #2226: CLOUDSTACK-10012: Towards CloudStack fat jar

2017-10-16 Thread git
This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services

[GitHub] rafaelweingartner commented on issue #2291: [CLOUDSTACK-10111] Fix validation for parameter "vm.password.length"

2017-10-16 Thread git
yanov done This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services

[GitHub] blueorangutan commented on issue #2226: CLOUDSTACK-10012: Towards CloudStack fat jar

2017-10-16 Thread git
. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards

[GitHub] rhtyd commented on issue #2226: CLOUDSTACK-10012: Towards CloudStack fat jar

2017-10-16 Thread git
Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services

[GitHub] blueorangutan commented on issue #2226: CLOUDSTACK-10012: Towards CloudStack fat jar

2017-10-16 Thread git
This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services

[GitHub] blueorangutan commented on issue #2226: CLOUDSTACK-10012: Towards CloudStack fat jar

2017-10-16 Thread git
. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards

[GitHub] rhtyd commented on issue #2226: CLOUDSTACK-10012: Towards CloudStack fat jar

2017-10-16 Thread git
rhtyd commented on issue #2226: CLOUDSTACK-10012: Towards CloudStack fat jar URL: https://github.com/apache/cloudstack/pull/2226#issuecomment-336875482 @blueorangutan package This is an automated message from the Apache Git

[GitHub] blueorangutan commented on issue #2226: CLOUDSTACK-10012: Towards CloudStack fat jar

2017-10-16 Thread git
This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services

[GitHub] rhtyd commented on issue #2226: CLOUDSTACK-10012: Towards CloudStack fat jar

2017-10-16 Thread git
the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services

[GitHub] rhtyd commented on issue #2226: CLOUDSTACK-10012: Towards CloudStack fat jar

2017-10-16 Thread git
properties or yml file that can be used as a single point to configure ports, listening interfaces, https, keystore etc. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use

[GitHub] DaanHoogland closed pull request #2296: CLOUDSTACK-10007 no isolationmethod check for basic zone

2017-10-15 Thread git
DaanHoogland closed pull request #2296: CLOUDSTACK-10007 no isolationmethod check for basic zone URL: https://github.com/apache/cloudstack/pull/2296 This is an automated message from the Apache Git Service. To respond

[GitHub] blueorangutan commented on issue #2276: WIP: CLOUDSTACK-10089 log4j update to version 2

2017-10-14 Thread git
This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org

[GitHub] DaanHoogland commented on issue #2276: WIP: CLOUDSTACK-10089 log4j update to version 2

2017-10-14 Thread git
the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services

[GitHub] DaanHoogland commented on issue #2276: WIP: CLOUDSTACK-10089 log4j update to version 2

2017-10-14 Thread git
the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services

[GitHub] blueorangutan commented on issue #2276: WIP: CLOUDSTACK-10089 log4j update to version 2

2017-10-14 Thread git
This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services

[GitHub] DaanHoogland commented on issue #2276: WIP: CLOUDSTACK-10089 log4j update to version 2

2017-10-14 Thread git
the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services

[GitHub] DaanHoogland commented on issue #2276: WIP: CLOUDSTACK-10089 log4j update to version 2

2017-10-14 Thread git
the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services

[GitHub] mike-tutkowski commented on issue #2296: CLOUDSTACK-10007 no isolationmethod check for basic zone

2017-10-14 Thread git
/2081 and this PR. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact

[GitHub] mike-tutkowski commented on issue #2081: CLOUDSTACK-9894 Separate creation and backup operations for a volume snapshot

2017-10-14 Thread git
. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org

[GitHub] mike-tutkowski commented on issue #2081: CLOUDSTACK-9894 Separate creation and backup operations for a volume snapshot

2017-10-14 Thread git
| Status : SUCCESS === ok -- Ran 4 tests in 2847.135s OK This is an automated message from the Apache Git Service. To respond to the message

[GitHub] mike-tutkowski commented on issue #2296: CLOUDSTACK-10007 no isolationmethod check for basic zone

2017-10-14 Thread git
=== ok -- Ran 4 tests in 2847.135s OK This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub

[GitHub] mike-tutkowski commented on issue #2296: CLOUDSTACK-10007 no isolationmethod check for basic zone

2017-10-14 Thread git
This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services

[GitHub] mike-tutkowski commented on issue #2081: CLOUDSTACK-9894 Separate creation and backup operations for a volume snapshot

2017-10-14 Thread git
This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache

[GitHub] mike-tutkowski commented on issue #2296: CLOUDSTACK-10007 no isolationmethod check for basic zone

2017-10-14 Thread git
This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git

[GitHub] mike-tutkowski commented on issue #2081: CLOUDSTACK-9894 Separate creation and backup operations for a volume snapshot

2017-10-14 Thread git
This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org

[GitHub] mike-tutkowski commented on issue #2081: CLOUDSTACK-9894 Separate creation and backup operations for a volume snapshot

2017-10-14 Thread git
from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services

[GitHub] mike-tutkowski commented on issue #2296: CLOUDSTACK-10007 no isolationmethod check for basic zone

2017-10-14 Thread git
: test_13_resize_volume_on_stopped_vm | Status : SUCCESS === ok -- Ran 14 tests in 1365.057s OK This is an automated message from the Apache Git

[GitHub] mike-tutkowski commented on issue #2296: CLOUDSTACK-10007 no isolationmethod check for basic zone

2017-10-14 Thread git
This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us

[GitHub] mike-tutkowski commented on issue #2081: CLOUDSTACK-9894 Separate creation and backup operations for a volume snapshot

2017-10-14 Thread git
in 547.525s OK This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact

[GitHub] mike-tutkowski commented on issue #2296: CLOUDSTACK-10007 no isolationmethod check for basic zone

2017-10-14 Thread git
-- Ran 5 tests in 2589.177s OK This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment

[GitHub] mike-tutkowski commented on issue #2081: CLOUDSTACK-9894 Separate creation and backup operations for a volume snapshot

2017-10-14 Thread git
-- Ran 5 tests in 2589.177s OK This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go

[GitHub] mike-tutkowski commented on issue #2296: CLOUDSTACK-10007 no isolationmethod check for basic zone

2017-10-14 Thread git
-- Ran 2 tests in 2041.553s OK This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL

[GitHub] mike-tutkowski commented on issue #2081: CLOUDSTACK-9894 Separate creation and backup operations for a volume snapshot

2017-10-14 Thread git
: SUCCESS === ok -- Ran 2 tests in 2041.553s OK This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub

[GitHub] blueorangutan commented on issue #2296: CLOUDSTACK-10007 no isolationmethod check for basic zone

2017-10-13 Thread git
| test_deploy_vgpu_enabled_vm.py This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure

[GitHub] resmo commented on issue #2267: CLOUDSTACK-10077: allow to have different VPN customer gateway configs for same gateway IP

2017-10-13 Thread git
This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services

[GitHub] blueorangutan commented on issue #2297: CLOUDSTACK-9957 tyopos in test

2017-10-13 Thread git
_vm.py test_3d_gpu_support | Skipped | 0.04 | test_deploy_vgpu_enabled_vm.py This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific c

[GitHub] blueorangutan commented on issue #2295: CLOUDSTACK-10109: Enable dedication of public IPs to SSVM and CPVM

2017-10-13 Thread git
This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us

[GitHub] mike-tutkowski commented on issue #2081: CLOUDSTACK-9894 Separate creation and backup operations for a volume snapshot

2017-10-13 Thread git
: https://github.com/apache/cloudstack/pull/2296 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about

[GitHub] mike-tutkowski commented on issue #2296: CLOUDSTACK-10007 no isolationmethod check for basic zone

2017-10-13 Thread git
! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us

[GitHub] nvazquez commented on a change in pull request #2295: CLOUDSTACK-10109: Enable dedication of public IPs to SSVM and CPVM

2017-10-13 Thread git
on `VlanDaoImpl.listZoneWideNonDedicatedVlans` does not consider vlans which are mapped on `domain_vlan_map` only returning range for vlan id = 1. Can you check my last comment on this PR as well? This is an automated message from the Apache Git Service

[GitHub] nvazquez commented on a change in pull request #2295: CLOUDSTACK-10109: Enable dedication of public IPs to SSVM and CPVM

2017-10-13 Thread git
not consider vlans which are mapped on `domain_vlan_map` only returning range for vlan id = 1. Can you check my last comment on this PR as well? This is an automated message from the Apache Git Service. To respond to the message

[GitHub] sgoeminn commented on a change in pull request #2293: CLOUDSTACK-10047: DVSwitch fixes and improvements

2017-10-13 Thread git
--- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services

[GitHub] sgoeminn commented on a change in pull request #2293: CLOUDSTACK-10047: DVSwitch fixes and improvements

2017-10-13 Thread git
; (vlanId.contains(",") || vlanId.contains("-"))) { Review comment: could be replaced by StringUtils.containsAny(vlanId, ",-")? Maybe also extract it to a separate boolean because it's checked multiple times? ------

[GitHub] sgoeminn commented on a change in pull request #2293: CLOUDSTACK-10047: DVSwitch fixes and improvements

2017-10-13 Thread git
ot;,") && !vlanId.contains("-") could be replaced by !StringUtils.containsAny(vlanId, ",-")? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services

[GitHub] sgoeminn commented on a change in pull request #2293: CLOUDSTACK-10047: DVSwitch fixes and improvements

2017-10-13 Thread git
) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache

[GitHub] nitin-maharana commented on issue #2048: CLOUDSTACK-9880: Expansion of Management IP Range.

2017-10-13 Thread git
this. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git

[GitHub] blueorangutan commented on issue #2290: WIP: add track id to async api calls

2017-10-13 Thread git
This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services

[GitHub] blueorangutan commented on issue #2290: WIP: add track id to async api calls

2017-10-13 Thread git
. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards

[GitHub] DaanHoogland commented on issue #2290: WIP: add track id to async api calls

2017-10-13 Thread git
DaanHoogland commented on issue #2290: WIP: add track id to async api calls URL: https://github.com/apache/cloudstack/pull/2290#issuecomment-335484114 @blueorangutan package This is an automated message from the Apache Git

[GitHub] nitin-maharana commented on issue #2297: CLOUDSTACK-9957 tyopos in test

2017-10-13 Thread git
nitin-maharana commented on issue #2297: CLOUDSTACK-9957 tyopos in test URL: https://github.com/apache/cloudstack/pull/2297#issuecomment-336432514 LGTM. Thanks @DaanHoogland This is an automated message from the Apache Git

[GitHub] DaanHoogland commented on issue #2297: CLOUDSTACK-9957 tyopos in test

2017-10-13 Thread git
DaanHoogland commented on issue #2297: CLOUDSTACK-9957 tyopos in test URL: https://github.com/apache/cloudstack/pull/2297#issuecomment-336426786 @blueorangutan test This is an automated message from the Apache Git Service

[GitHub] blueorangutan commented on issue #2297: CLOUDSTACK-9957 tyopos in test

2017-10-13 Thread git
This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards

[GitHub] blueorangutan commented on issue #2296: CLOUDSTACK-10007 no isolationmethod check for basic zone

2017-10-13 Thread git
This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us

[GitHub] DaanHoogland commented on issue #2296: CLOUDSTACK-10007 no isolationmethod check for basic zone

2017-10-13 Thread git
This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services

[GitHub] DaanHoogland commented on issue #2296: CLOUDSTACK-10007 no isolationmethod check for basic zone

2017-10-13 Thread git
from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services

[GitHub] blueorangutan commented on issue #2296: CLOUDSTACK-10007 no isolationmethod check for basic zone

2017-10-13 Thread git
` command. Blessed contributors for kicking Trillian test jobs: ['rhtyd', 'nvazquez', 'PaulAngus', 'borisstoyanov', 'DaanHoogland'] ---- This is an automated message from the Apache Git Service. To respond to the message

[GitHub] blueorangutan commented on issue #2297: CLOUDSTACK-9957 tyopos in test

2017-10-13 Thread git
message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services

[GitHub] blueorangutan commented on issue #2297: CLOUDSTACK-9957 tyopos in test

2017-10-13 Thread git
. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache

[GitHub] DaanHoogland commented on issue #2297: CLOUDSTACK-9957 tyopos in test

2017-10-13 Thread git
DaanHoogland commented on issue #2297: CLOUDSTACK-9957 tyopos in test URL: https://github.com/apache/cloudstack/pull/2297#issuecomment-336415583 @blueorangutan package This is an automated message from the Apache Git Service

[GitHub] DaanHoogland opened a new pull request #2297: CLOUDSTACK-9957 tyopos in test

2017-10-13 Thread git
DaanHoogland opened a new pull request #2297: CLOUDSTACK-9957 tyopos in test URL: https://github.com/apache/cloudstack/pull/2297 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] blueorangutan commented on issue #2296: CLOUDSTACK-10007 no isolationmethod check for basic zone

2017-10-13 Thread git
This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services

[GitHub] DaanHoogland closed pull request #2181: CLOUDSTACK-9957 Annotations

2017-10-13 Thread git
DaanHoogland closed pull request #2181: CLOUDSTACK-9957 Annotations URL: https://github.com/apache/cloudstack/pull/2181 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] blueorangutan commented on issue #2296: CLOUDSTACK-10007 no isolationmethod check for basic zone

2017-10-13 Thread git
. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us

[GitHub] DaanHoogland commented on issue #2296: CLOUDSTACK-10007 no isolationmethod check for basic zone

2017-10-13 Thread git
from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services

[GitHub] blueorangutan commented on issue #2295: CLOUDSTACK-10109: Enable dedication of public IPs to SSVM and CPVM

2017-10-13 Thread git
This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us

[GitHub] DaanHoogland opened a new pull request #2296: CLOUDSTACK-10007 no isolationmethod check for basic zone

2017-10-13 Thread git
from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services

[GitHub] blueorangutan commented on issue #2204: [CLOUDSTACK-10025] Adding Support for NoVNC Console for KVM and XENSERVER

2017-10-13 Thread git
tests This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure

[GitHub] borisstoyanov commented on issue #2204: [CLOUDSTACK-10025] Adding Support for NoVNC Console for KVM and XENSERVER

2017-10-13 Thread git
This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services

[GitHub] blueorangutan commented on issue #2295: CLOUDSTACK-10109: Enable dedication of public IPs to SSVM and CPVM

2017-10-13 Thread git
This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us

  1   2   3   4   5   6   7   8   9   10   >