DaanHoogland commented on PR #6550:
URL: https://github.com/apache/cloudstack/pull/6550#issuecomment-1376824261
@fermosan you can delete the branch, we can create new PRs or issues if we
need to and we also have d...@cloudstack.apache.org
--
This is an automated message from the
DaanHoogland commented on PR #6550:
URL: https://github.com/apache/cloudstack/pull/6550#issuecomment-1375730617
As I saw the error on the jacoco build in another PR on the apache jenkins
as well, I am going to merge.
--
This is an automated message from the Apache Git Service.
To respond
DaanHoogland commented on PR #6550:
URL: https://github.com/apache/cloudstack/pull/6550#issuecomment-1370963760
@blueorangutan test matrix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
DaanHoogland commented on PR #6550:
URL: https://github.com/apache/cloudstack/pull/6550#issuecomment-1370765913
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
DaanHoogland commented on PR #6550:
URL: https://github.com/apache/cloudstack/pull/6550#issuecomment-1367189182
@blueorangutan test matrix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
DaanHoogland commented on PR #6550:
URL: https://github.com/apache/cloudstack/pull/6550#issuecomment-1367144470
one last time
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
DaanHoogland commented on PR #6550:
URL: https://github.com/apache/cloudstack/pull/6550#issuecomment-1365707474
@blueorangutan test matrix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
DaanHoogland commented on PR #6550:
URL: https://github.com/apache/cloudstack/pull/6550#issuecomment-1364070134
@blueorangutan test matrix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
DaanHoogland commented on PR #6550:
URL: https://github.com/apache/cloudstack/pull/6550#issuecomment-1363997623
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
DaanHoogland commented on PR #6550:
URL: https://github.com/apache/cloudstack/pull/6550#issuecomment-1363970935
@blueorangutan test matrix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
DaanHoogland commented on PR #6550:
URL: https://github.com/apache/cloudstack/pull/6550#issuecomment-1363956836
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
DaanHoogland commented on PR #6550:
URL: https://github.com/apache/cloudstack/pull/6550#issuecomment-1363956730
@fermosan sorry to be bugging you. I don´t think the package-lock is
intended to be deleted, just to remain unchanged.
--
This is an automated message from the Apache Git
DaanHoogland commented on PR #6550:
URL: https://github.com/apache/cloudstack/pull/6550#issuecomment-1363810951
> > > @rohityadavcloud @fermosan do we reset the package-lock.json on this?
I think we can merge as soon as we have.
> >
> >
> > re-ping, before this gets rained down
DaanHoogland commented on PR #6550:
URL: https://github.com/apache/cloudstack/pull/6550#issuecomment-1362715609
> @rohityadavcloud @fermosan do we reset the package-lock.json on this? I
think we can merge as soon as we have.
re-ping, before this gets rained down by BO messages,
DaanHoogland commented on PR #6550:
URL: https://github.com/apache/cloudstack/pull/6550#issuecomment-1362698148
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
DaanHoogland commented on PR #6550:
URL: https://github.com/apache/cloudstack/pull/6550#issuecomment-1362682613
@rohityadavcloud @fermosan do we reset the package-lock.json on this? I
think we can merge as soon as we have.
--
This is an automated message from the Apache Git Service.
To
DaanHoogland commented on PR #6550:
URL: https://github.com/apache/cloudstack/pull/6550#issuecomment-1359236796
> Trillian test result (tid-5567) Environment: vmware-65u2 (x2), Advanced
Networking with Mgmt server 7 Total time taken: 53426 seconds Marvin logs:
DaanHoogland commented on PR #6550:
URL: https://github.com/apache/cloudstack/pull/6550#issuecomment-1359235605
> > @rohityadavcloud @weizhouapache @shwstppr @fermosan is there anything
left to discuss here?
>
> @DaanHoogland i think that there are some questions to be answered. What
DaanHoogland commented on PR #6550:
URL: https://github.com/apache/cloudstack/pull/6550#issuecomment-1357488321
@blueorangutan test matrix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
DaanHoogland commented on PR #6550:
URL: https://github.com/apache/cloudstack/pull/6550#issuecomment-1348028306
@rohityadavcloud @weizhouapache @shwstppr @fermosan is there anything left
to discuss here?
--
This is an automated message from the Apache Git Service.
To respond to the
DaanHoogland commented on PR #6550:
URL: https://github.com/apache/cloudstack/pull/6550#issuecomment-1348015638
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
DaanHoogland commented on PR #6550:
URL: https://github.com/apache/cloudstack/pull/6550#issuecomment-1299986299
ping @fermosan you see any chance to address @rohityadavcloud 's remaining
comments?
--
This is an automated message from the Apache Git Service.
To respond to the message,
DaanHoogland commented on PR #6550:
URL: https://github.com/apache/cloudstack/pull/6550#issuecomment-1287117203
@rohityadavcloud awaiting your final words ;)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
DaanHoogland commented on PR #6550:
URL: https://github.com/apache/cloudstack/pull/6550#issuecomment-1285468407
insanity:
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
DaanHoogland commented on PR #6550:
URL: https://github.com/apache/cloudstack/pull/6550#issuecomment-1283902326
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
DaanHoogland commented on PR #6550:
URL: https://github.com/apache/cloudstack/pull/6550#issuecomment-1283774959
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
DaanHoogland commented on PR #6550:
URL: https://github.com/apache/cloudstack/pull/6550#issuecomment-1283545360
@fermosan did you answer all @rohityadavcloud 's comments? (i.e. do you guys
agree this is ready or not?)
--
This is an automated message from the Apache Git Service.
To
DaanHoogland commented on PR #6550:
URL: https://github.com/apache/cloudstack/pull/6550#issuecomment-1260935302
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
DaanHoogland commented on PR #6550:
URL: https://github.com/apache/cloudstack/pull/6550#issuecomment-1260863914
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
DaanHoogland commented on PR #6550:
URL: https://github.com/apache/cloudstack/pull/6550#issuecomment-1260454449
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
DaanHoogland commented on PR #6550:
URL: https://github.com/apache/cloudstack/pull/6550#issuecomment-1257616508
@rohityadavcloud can you have a second look in terms of the B framework
architecture, please?
--
This is an automated message from the Apache Git Service.
To respond to the
DaanHoogland commented on PR #6550:
URL: https://github.com/apache/cloudstack/pull/6550#issuecomment-1257602135
Yes @fermosan, all looks good, I'll re-run the regression tests.
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the
DaanHoogland commented on PR #6550:
URL: https://github.com/apache/cloudstack/pull/6550#issuecomment-1252050514
> @DaanHoogland @rohityadavcloud Hello, how we can kick in sonar ?
@fermosan , maybe do as @rohityadavcloud suggested and rebase your code on
latest, then force push it to
DaanHoogland commented on PR #6550:
URL: https://github.com/apache/cloudstack/pull/6550#issuecomment-1243503499
> @DaanHoogland @rohityadavcloud Hello, how we can kick in sonar ?
@fermosan you can run it from your IDE, it should run automatically on PRs.
There are free plugins for
DaanHoogland commented on PR #6550:
URL: https://github.com/apache/cloudstack/pull/6550#issuecomment-1228305292
We'll have to do without sonar output on this one I guess. It wasn't
triggered, even after re-opening.
--
This is an automated message from the Apache Git Service.
To respond
DaanHoogland commented on PR #6550:
URL: https://github.com/apache/cloudstack/pull/6550#issuecomment-1222043866
@harikrishna-patnala I'm going to close/open to see if we can get some
sonarcube output. Other than that I am counting two LGTM and testing performed
and will merge. Do you want
DaanHoogland commented on PR #6550:
URL: https://github.com/apache/cloudstack/pull/6550#issuecomment-1218239720
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
DaanHoogland commented on PR #6550:
URL: https://github.com/apache/cloudstack/pull/6550#issuecomment-1207849866
> @DaanHoogland @slavkap Thank you for your review and approvals. Of course
we are going to maintain it since it will be actively used. It will be moved to
4.17.1.0 milestone or
DaanHoogland commented on PR #6550:
URL: https://github.com/apache/cloudstack/pull/6550#issuecomment-1207846820
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
DaanHoogland commented on PR #6550:
URL: https://github.com/apache/cloudstack/pull/6550#issuecomment-1206258639
@slavkap are your concerns met?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
DaanHoogland commented on PR #6550:
URL: https://github.com/apache/cloudstack/pull/6550#issuecomment-1206256526
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
DaanHoogland commented on PR #6550:
URL: https://github.com/apache/cloudstack/pull/6550#issuecomment-1204871477
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
DaanHoogland commented on PR #6550:
URL: https://github.com/apache/cloudstack/pull/6550#issuecomment-1203971173
@rohityadavcloud @harikrishna-patnala @slavkap CLGTM i don´t think we have
anybody other than @fermosan and colleagues to test this. Can you agree we can
merge?
--
This is an
DaanHoogland commented on PR #6550:
URL: https://github.com/apache/cloudstack/pull/6550#issuecomment-1202073025
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
DaanHoogland commented on PR #6550:
URL: https://github.com/apache/cloudstack/pull/6550#issuecomment-1201197581
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
DaanHoogland commented on PR #6550:
URL: https://github.com/apache/cloudstack/pull/6550#issuecomment-1185409402
you have a small conflict @fermosan . can you resolve it? (will happen more
often the coming time, I'm sure)
--
This is an automated message from the Apache Git Service.
To
DaanHoogland commented on PR #6550:
URL: https://github.com/apache/cloudstack/pull/6550#issuecomment-1185407107
> @DaanHoogland This commit concludes all the designed functionality for the
plugin. Backups are registered / removed properly from/to Cloudstack. We will
keep testing in
DaanHoogland commented on PR #6550:
URL: https://github.com/apache/cloudstack/pull/6550#issuecomment-1185223448
@rohityadavcloud , what is the status of the jacoco validator? I've seen
unexplained failures in other PRs too.
--
This is an automated message from the Apache Git Service.
To
DaanHoogland commented on PR #6550:
URL: https://github.com/apache/cloudstack/pull/6550#issuecomment-1184234252
> @DaanHoogland @rohityadavcloud @harikrishna-patnala Is JaCoCo failing for
some particular reason ?
are you fully ready yet, @fermosan ? let's not worry about jococo
DaanHoogland commented on PR #6550:
URL: https://github.com/apache/cloudstack/pull/6550#issuecomment-1183236294
nice work @fermosan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
50 matches
Mail list logo
