[GitHub] [cloudstack] DaanHoogland commented on pull request #6808: Allow privateips on console proxy

2022-12-22 Thread GitBox
DaanHoogland commented on PR #6808: URL: https://github.com/apache/cloudstack/pull/6808#issuecomment-1362988635 > @DaanHoogland > > `Do you plan to document this? ` Initially I did not plan on documenting since it is not a major change, but I can do it. > > `And do you plan to

[GitHub] [cloudstack] DaanHoogland commented on pull request #6808: Allow privateips on console proxy

2022-12-22 Thread GitBox
DaanHoogland commented on PR #6808: URL: https://github.com/apache/cloudstack/pull/6808#issuecomment-1362807735 @GaOrtiga, Do you plan to document this? (in https://github.com/apache/cloudstack-documentation)? And do you plan to apply @RodrigoDLopez 'extra space suggestion? -- This

[GitHub] [cloudstack] DaanHoogland commented on pull request #6808: Allow privateips on console proxy

2022-12-21 Thread GitBox
DaanHoogland commented on PR #6808: URL: https://github.com/apache/cloudstack/pull/6808#issuecomment-1361010774 @blueorangutan test keepEnv -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [cloudstack] DaanHoogland commented on pull request #6808: Allow privateips on console proxy

2022-12-20 Thread GitBox
DaanHoogland commented on PR #6808: URL: https://github.com/apache/cloudstack/pull/6808#issuecomment-1359271505 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [cloudstack] DaanHoogland commented on pull request #6808: Allow privateips on console proxy

2022-12-20 Thread GitBox
DaanHoogland commented on PR #6808: URL: https://github.com/apache/cloudstack/pull/6808#issuecomment-1358991374 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [cloudstack] DaanHoogland commented on pull request #6808: Allow privateips on console proxy

2022-12-19 Thread GitBox
DaanHoogland commented on PR #6808: URL: https://github.com/apache/cloudstack/pull/6808#issuecomment-1357524868 @GaOrtiga as this is still in draft, should it be pushed to a later milestone? i.e. 4.19? -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [cloudstack] DaanHoogland commented on pull request #6808: Allow privateips on console proxy

2022-12-13 Thread GitBox
DaanHoogland commented on PR #6808: URL: https://github.com/apache/cloudstack/pull/6808#issuecomment-1347995071 > SonarCloud Quality Gate failed.[![Quality Gate

[GitHub] [cloudstack] DaanHoogland commented on pull request #6808: Allow privateips on console proxy

2022-10-11 Thread GitBox
DaanHoogland commented on PR #6808: URL: https://github.com/apache/cloudstack/pull/6808#issuecomment-1274350300 @GaOrtiga dio you expect to have this finished/ready for review in the coming weeks? -- This is an automated message from the Apache Git Service. To respond to the message,