[GitHub] [cloudstack] DaanHoogland commented on pull request #6809: Reserve memory for host

2023-05-30 Thread via GitHub
DaanHoogland commented on PR #6809: URL: https://github.com/apache/cloudstack/pull/6809#issuecomment-1567944751 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [cloudstack] DaanHoogland commented on pull request #6809: Reserve memory for host

2023-05-26 Thread via GitHub
DaanHoogland commented on PR #6809: URL: https://github.com/apache/cloudstack/pull/6809#issuecomment-1563938876 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [cloudstack] DaanHoogland commented on pull request #6809: Reserve memory for host

2023-02-03 Thread via GitHub
DaanHoogland commented on PR #6809: URL: https://github.com/apache/cloudstack/pull/6809#issuecomment-1415364729 > @DaanHoogland Yes, I'm working on this PR. If nothing goes wrong, I can manage to fix it crossed_fingers > Due to the VM reinstall issue last week, I couldn't work on this.

[GitHub] [cloudstack] DaanHoogland commented on pull request #6809: Reserve memory for host

2023-02-03 Thread via GitHub
DaanHoogland commented on PR #6809: URL: https://github.com/apache/cloudstack/pull/6809#issuecomment-1415329515 @soreana , will you work on this before RC cutting? (I might postpone another week, but really want to more forward) -- This is an automated message from the Apache Git

[GitHub] [cloudstack] DaanHoogland commented on pull request #6809: Reserve memory for host

2023-01-24 Thread via GitHub
DaanHoogland commented on PR #6809: URL: https://github.com/apache/cloudstack/pull/6809#issuecomment-1401544520 > Trillian test result (tid-5952) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 43104 seconds Marvin logs:

[GitHub] [cloudstack] DaanHoogland commented on pull request #6809: Reserve memory for host

2023-01-23 Thread via GitHub
DaanHoogland commented on PR #6809: URL: https://github.com/apache/cloudstack/pull/6809#issuecomment-1400629956 > Manual setting of values works fine but the reset functionality doesn't change the value in database: > > ``` > (localcloud)  > update configuration

[GitHub] [cloudstack] DaanHoogland commented on pull request #6809: Reserve memory for host

2023-01-23 Thread via GitHub
DaanHoogland commented on PR #6809: URL: https://github.com/apache/cloudstack/pull/6809#issuecomment-1400018432 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [cloudstack] DaanHoogland commented on pull request #6809: Reserve memory for host

2023-01-20 Thread GitBox
DaanHoogland commented on PR #6809: URL: https://github.com/apache/cloudstack/pull/6809#issuecomment-1398358906 > @wido That in my view > > > Overall it is looking good. > > What I am missing is a validation that nobody can set a value <0 or maybe a super large like 1TB or

[GitHub] [cloudstack] DaanHoogland commented on pull request #6809: Reserve memory for host

2023-01-20 Thread GitBox
DaanHoogland commented on PR #6809: URL: https://github.com/apache/cloudstack/pull/6809#issuecomment-1398224805 @weizhouapache @wido @GutoVeronezi is this ready?/are you satisfied?/ did any of you test? -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [cloudstack] DaanHoogland commented on pull request #6809: Reserve memory for host

2023-01-18 Thread GitBox
DaanHoogland commented on PR #6809: URL: https://github.com/apache/cloudstack/pull/6809#issuecomment-1386977827 @soreana will you still change the new setting to be cluste scoped? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [cloudstack] DaanHoogland commented on pull request #6809: Reserve memory for host

2023-01-10 Thread GitBox
DaanHoogland commented on PR #6809: URL: https://github.com/apache/cloudstack/pull/6809#issuecomment-1376871901 @soreana can you fix the conflicts and address @GutoVeronezi 's comments please? -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [cloudstack] DaanHoogland commented on pull request #6809: Reserve memory for host

2022-12-28 Thread GitBox
DaanHoogland commented on PR #6809: URL: https://github.com/apache/cloudstack/pull/6809#issuecomment-136453 > > @wido @soreana , we don´t have true granularity, but we can, if the scope is cluster, edit at global level a vaule that will then function as a default on cluster level. No

[GitHub] [cloudstack] DaanHoogland commented on pull request #6809: Reserve memory for host

2022-12-27 Thread GitBox
DaanHoogland commented on PR #6809: URL: https://github.com/apache/cloudstack/pull/6809#issuecomment-1365801988 > > @wido That is a good point. What would be the best? Should I make it cluster-level or add another cluster-level setting and keep the global one? > > We can add

[GitHub] [cloudstack] DaanHoogland commented on pull request #6809: Reserve memory for host

2022-12-22 Thread GitBox
DaanHoogland commented on PR #6809: URL: https://github.com/apache/cloudstack/pull/6809#issuecomment-1362836204 @soreana can you look at the conflicts, please? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [cloudstack] DaanHoogland commented on pull request #6809: Reserve memory for host

2022-12-19 Thread GitBox
DaanHoogland commented on PR #6809: URL: https://github.com/apache/cloudstack/pull/6809#issuecomment-1357416083 @nvazquez @weizhouapache @GutoVeronezi @wido we need more reviews here, please -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [cloudstack] DaanHoogland commented on pull request #6809: Reserve memory for host

2022-12-16 Thread GitBox
DaanHoogland commented on PR #6809: URL: https://github.com/apache/cloudstack/pull/6809#issuecomment-1354715876 @blueorangutan test matrix -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [cloudstack] DaanHoogland commented on pull request #6809: Reserve memory for host

2022-12-13 Thread GitBox
DaanHoogland commented on PR #6809: URL: https://github.com/apache/cloudstack/pull/6809#issuecomment-1347995958 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [cloudstack] DaanHoogland commented on pull request #6809: Reserve memory for host

2022-10-17 Thread GitBox
DaanHoogland commented on PR #6809: URL: https://github.com/apache/cloudstack/pull/6809#issuecomment-1280581620 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [cloudstack] DaanHoogland commented on pull request #6809: Reserve memory for host

2022-10-17 Thread GitBox
DaanHoogland commented on PR #6809: URL: https://github.com/apache/cloudstack/pull/6809#issuecomment-1280465856 @soreana I think nothing serious left. Can you answer the outstanding comments. I'll re-run the packaging/tests afterwards. -- This is an automated message from the Apache Git

[GitHub] [cloudstack] DaanHoogland commented on pull request #6809: Reserve memory for host

2022-10-14 Thread GitBox
DaanHoogland commented on PR #6809: URL: https://github.com/apache/cloudstack/pull/6809#issuecomment-1279092217 @blueorangutan test matrix -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [cloudstack] DaanHoogland commented on pull request #6809: Reserve memory for host

2022-10-14 Thread GitBox
DaanHoogland commented on PR #6809: URL: https://github.com/apache/cloudstack/pull/6809#issuecomment-1278748701 @soreana i see an error during build: ``` [ERROR]

[GitHub] [cloudstack] DaanHoogland commented on pull request #6809: Reserve memory for host

2022-10-11 Thread GitBox
DaanHoogland commented on PR #6809: URL: https://github.com/apache/cloudstack/pull/6809#issuecomment-1274795353 > @DaanHoogland Can I also have this one on 4.18, please ? :) marked for 4.18 @soreana -- This is an automated message from the Apache Git Service. To respond to the