[GitHub] [cloudstack] DaanHoogland commented on pull request #6960: create parameter to determine whether roles are public or private

DaanHoogland commented on PR #6960: URL: https://github.com/apache/cloudstack/pull/6960#issuecomment-1571890521 Note how the smoke tests passed and didn't warn me about my error. An upgrade test would have caught this :| -- This is an automated message from the Apache Git Service. To

[GitHub] [cloudstack] DaanHoogland commented on pull request #6960: create parameter to determine whether roles are public or private

DaanHoogland commented on PR #6960: URL: https://github.com/apache/cloudstack/pull/6960#issuecomment-1571886669 > @DaanHoogland this has been merged in `main` branch but the schema changes are in 4.18.0 to 4.18.1 upgrade path thanks @shwstppr , I missed that. I can revert, but I see

[GitHub] [cloudstack] DaanHoogland commented on pull request #6960: create parameter to determine whether roles are public or private

DaanHoogland commented on PR #6960: URL: https://github.com/apache/cloudstack/pull/6960#issuecomment-1527335806 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [cloudstack] DaanHoogland commented on pull request #6960: create parameter to determine whether roles are public or private

DaanHoogland commented on PR #6960: URL: https://github.com/apache/cloudstack/pull/6960#issuecomment-1527221810 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [cloudstack] DaanHoogland commented on pull request #6960: create parameter to determine whether roles are public or private

DaanHoogland commented on PR #6960: URL: https://github.com/apache/cloudstack/pull/6960#issuecomment-1527221423 > @DaanHoogland Can we proceed with this PR or is there any other concern regarding it? no concerns -- This is an automated message from the Apache Git Service. To

[GitHub] [cloudstack] DaanHoogland commented on pull request #6960: create parameter to determine whether roles are public or private

DaanHoogland commented on PR #6960: URL: https://github.com/apache/cloudstack/pull/6960#issuecomment-1415942299 ok @GaOrtiga , it seems we have two items (2fa and tungsten) that are posponing the release anyway, but I'll keep it in mind. -- This is an automated message from the Apache

[GitHub] [cloudstack] DaanHoogland commented on pull request #6960: create parameter to determine whether roles are public or private

DaanHoogland commented on PR #6960: URL: https://github.com/apache/cloudstack/pull/6960#issuecomment-1413375780 @GaOrtiga , i plan to cut the RC this weekend, will you be ready by today? (we need a day to run the tests as well. -- This is an automated message from the Apache Git Service.

[GitHub] [cloudstack] DaanHoogland commented on pull request #6960: create parameter to determine whether roles are public or private

DaanHoogland commented on PR #6960: URL: https://github.com/apache/cloudstack/pull/6960#issuecomment-1398160750 @GaOrtiga new conflicts. as we are closing in on release this will happen more often :( -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [cloudstack] DaanHoogland commented on pull request #6960: create parameter to determine whether roles are public or private

DaanHoogland commented on PR #6960: URL: https://github.com/apache/cloudstack/pull/6960#issuecomment-1384092853 @rohityadavcloud @weizhouapache Can you guys give this a look? tnx -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [cloudstack] DaanHoogland commented on pull request #6960: create parameter to determine whether roles are public or private

DaanHoogland commented on PR #6960: URL: https://github.com/apache/cloudstack/pull/6960#issuecomment-1384054214 test_affinity_groups_projects failing, see #7098 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [cloudstack] DaanHoogland commented on pull request #6960: create parameter to determine whether roles are public or private

DaanHoogland commented on PR #6960: URL: https://github.com/apache/cloudstack/pull/6960#issuecomment-1357695116 No, I meant for the functionality in this PR in general. And I mean in an automated fashion so they can serve as regression tests in the future. I.e. automate the scenario you

[GitHub] [cloudstack] DaanHoogland commented on pull request #6960: create parameter to determine whether roles are public or private

DaanHoogland commented on PR #6960: URL: https://github.com/apache/cloudstack/pull/6960#issuecomment-1357504759 @GaOrtiga do you think regression/integration tests as sensible for this change? -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [cloudstack] DaanHoogland commented on pull request #6960: create parameter to determine whether roles are public or private

DaanHoogland commented on PR #6960: URL: https://github.com/apache/cloudstack/pull/6960#issuecomment-1357504238 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [cloudstack] DaanHoogland commented on pull request #6960: create parameter to determine whether roles are public or private

DaanHoogland commented on PR #6960: URL: https://github.com/apache/cloudstack/pull/6960#issuecomment-1357367044 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [cloudstack] DaanHoogland commented on pull request #6960: create parameter to determine whether roles are public or private

DaanHoogland commented on PR #6960: URL: https://github.com/apache/cloudstack/pull/6960#issuecomment-1354381724 Sorry @GaOrtiga , conflicts again. This happens a lot as we get close to release :( -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [cloudstack] DaanHoogland commented on pull request #6960: create parameter to determine whether roles are public or private

DaanHoogland commented on PR #6960: URL: https://github.com/apache/cloudstack/pull/6960#issuecomment-1346537797 @GaOrtiga , can you look at the conflicts? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above