[GitHub] [cloudstack] DaanHoogland commented on pull request #7313: server: improve storage GC to skip expunging possible duplicate volumes

2023-06-05 Thread via GitHub
DaanHoogland commented on PR #7313: URL: https://github.com/apache/cloudstack/pull/7313#issuecomment-1576287555 > This is just a defensive check and I don't think it would be simple to reproduce. At most, we can test that there is no regression in the GC logic. I've also tried to add

[GitHub] [cloudstack] DaanHoogland commented on pull request #7313: server: improve storage GC to skip expunging possible duplicate volumes

2023-06-05 Thread via GitHub
DaanHoogland commented on PR #7313: URL: https://github.com/apache/cloudstack/pull/7313#issuecomment-1576232378 This seems ready to merge, I am just missing some validation and given the description it seems hard to reproduce/test. -- This is an automated message from the Apache Git

[GitHub] [cloudstack] DaanHoogland commented on pull request #7313: server: improve storage GC to skip expunging possible duplicate volumes

2023-06-02 Thread via GitHub
DaanHoogland commented on PR #7313: URL: https://github.com/apache/cloudstack/pull/7313#issuecomment-1573522840 @blueorangutan test matrix -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [cloudstack] DaanHoogland commented on pull request #7313: server: improve storage GC to skip expunging possible duplicate volumes

2023-05-30 Thread via GitHub
DaanHoogland commented on PR #7313: URL: https://github.com/apache/cloudstack/pull/7313#issuecomment-1567956728 @blueorangutan test matrix -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [cloudstack] DaanHoogland commented on pull request #7313: server: improve storage GC to skip expunging possible duplicate volumes

2023-05-26 Thread via GitHub
DaanHoogland commented on PR #7313: URL: https://github.com/apache/cloudstack/pull/7313#issuecomment-1564023174 @blueorangutan LLtest -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [cloudstack] DaanHoogland commented on pull request #7313: server: improve storage GC to skip expunging possible duplicate volumes

2023-05-26 Thread via GitHub
DaanHoogland commented on PR #7313: URL: https://github.com/apache/cloudstack/pull/7313#issuecomment-1563985395 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [cloudstack] DaanHoogland commented on pull request #7313: server: improve storage GC to skip expunging possible duplicate volumes

2023-05-25 Thread via GitHub
DaanHoogland commented on PR #7313: URL: https://github.com/apache/cloudstack/pull/7313#issuecomment-1563050541 @blueorangutan LLtest -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [cloudstack] DaanHoogland commented on pull request #7313: server: improve storage GC to skip expunging possible duplicate volumes

2023-03-06 Thread via GitHub
DaanHoogland commented on PR #7313: URL: https://github.com/apache/cloudstack/pull/7313#issuecomment-1456318875 @blueorangutan test matrix -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the