GaOrtiga commented on PR #6960:
URL: https://github.com/apache/cloudstack/pull/6960#issuecomment-1522258896
@DaanHoogland Can we proceed with this PR or is there any other concern
regarding it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please
GaOrtiga commented on PR #6960:
URL: https://github.com/apache/cloudstack/pull/6960#issuecomment-1415930233
@DaanHoogland I think its better if we push it to a future release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
GaOrtiga commented on PR #6960:
URL: https://github.com/apache/cloudstack/pull/6960#issuecomment-1398251714
> @GaOrtiga new conflicts. as we are closing in on release this will happen
more often :(
Okay, I will look into it.
I am currently working on the integration tests, took
GaOrtiga commented on PR #6960:
URL: https://github.com/apache/cloudstack/pull/6960#issuecomment-1357831572
@DaanHoogland Oh, I see.
Okay, I will look into it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
GaOrtiga commented on PR #6960:
URL: https://github.com/apache/cloudstack/pull/6960#issuecomment-1357545862
> @GaOrtiga do you think regression/integration tests as sensible for this
change?
Do you mean for the PR as a whole or for this last change submitted?
If it is for the
GaOrtiga commented on PR #6960:
URL: https://github.com/apache/cloudstack/pull/6960#issuecomment-1355296274
> Sorry @GaOrtiga , conflicts again. This happens a lot as we get close to
release :(
Yes, I resolved them, thanks!
--
This is an automated message from the Apache Git
GaOrtiga commented on PR #6960:
URL: https://github.com/apache/cloudstack/pull/6960#issuecomment-1346732324
> @GaOrtiga , can you look at the conflicts?
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
