[GitHub] [cloudstack] itsayushpandey commented on pull request #7712: [WIP] Extend import/export unmanaged instances to KVM

2023-09-02 Thread via GitHub
itsayushpandey commented on PR #7712: URL: https://github.com/apache/cloudstack/pull/7712#issuecomment-1704004869 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [cloudstack] itsayushpandey commented on pull request #7712: [WIP] Extend import/export unmanaged instances to KVM

2023-09-02 Thread via GitHub
itsayushpandey commented on PR #7712: URL: https://github.com/apache/cloudstack/pull/7712#issuecomment-1703981028 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [cloudstack] itsayushpandey commented on pull request #7712: [WIP] Extend import/export unmanaged instances to KVM

2023-09-02 Thread via GitHub
itsayushpandey commented on PR #7712: URL: https://github.com/apache/cloudstack/pull/7712#issuecomment-1703981009 Thanks so much for finding these issues @nvazquez , I have been investigating and have fixed locally. The UI Changes weren't trivial and I think they might be partially broken

[GitHub] [cloudstack] itsayushpandey commented on pull request #7712: [WIP] Extend import/export unmanaged instances to KVM

2023-08-30 Thread via GitHub
itsayushpandey commented on PR #7712: URL: https://github.com/apache/cloudstack/pull/7712#issuecomment-1699437475 Hi @nvazquez , can you please share the custom offering details with me? I can perhaps try to reproduce and debug locally. I am able to reproduce the first error now and

[GitHub] [cloudstack] itsayushpandey commented on pull request #7712: [WIP] Extend import/export unmanaged instances to KVM

2023-08-30 Thread via GitHub
itsayushpandey commented on PR #7712: URL: https://github.com/apache/cloudstack/pull/7712#issuecomment-1699286878 @nvazquez I think this might be an intended error even in the case of vmware ? Basically either the service offering spec should match or the VM should be in powered off state

[GitHub] [cloudstack] itsayushpandey commented on pull request #7712: [WIP] Extend import/export unmanaged instances to KVM

2023-08-28 Thread via GitHub
itsayushpandey commented on PR #7712: URL: https://github.com/apache/cloudstack/pull/7712#issuecomment-1696779498 Hi @nvazquez I've fixed the merge conflicts and build failure you pointed out and verified the build locally. However I'm unable to see if it succeded or failed. Can you please

[GitHub] [cloudstack] itsayushpandey commented on pull request #7712: [WIP] Extend import/export unmanaged instances to KVM

2023-08-28 Thread via GitHub
itsayushpandey commented on PR #7712: URL: https://github.com/apache/cloudstack/pull/7712#issuecomment-1696742614 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [cloudstack] itsayushpandey commented on pull request #7712: [WIP] Extend import/export unmanaged instances to KVM

2023-08-06 Thread via GitHub
itsayushpandey commented on PR #7712: URL: https://github.com/apache/cloudstack/pull/7712#issuecomment-1666919656 @rohityadavcloud I have implemented listUnmanagedInstances API and unmanageVirtualMachine API and I'm currently working on implementing importUnmanagedInstance API. It is

[GitHub] [cloudstack] itsayushpandey commented on pull request #7712: [WIP] Extend import/export unmanaged instances to KVM

2023-07-08 Thread via GitHub
itsayushpandey commented on PR #7712: URL: https://github.com/apache/cloudstack/pull/7712#issuecomment-1627579332 @nvazquez I have added support to list all domains in a cluster if name is not given. ![Screenshot from 2023-07-08

[GitHub] [cloudstack] itsayushpandey commented on pull request #7712: [WIP] Extend import/export unmanaged instances to KVM

2023-07-06 Thread via GitHub
itsayushpandey commented on PR #7712: URL: https://github.com/apache/cloudstack/pull/7712#issuecomment-162264 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [cloudstack] itsayushpandey commented on pull request #7712: [WIP] Extend import/export unmanaged instances to KVM

2023-07-06 Thread via GitHub
itsayushpandey commented on PR #7712: URL: https://github.com/apache/cloudstack/pull/7712#issuecomment-1624404821 > @itsayushpandey looks like the unit tests on `UnmanagedVMsManagerImplTest` are failing after the changes, can you check them? @nvazquez - can you please help me kick

[GitHub] [cloudstack] itsayushpandey commented on pull request #7712: [WIP] Extend import/export unmanaged instances to KVM

2023-07-06 Thread via GitHub
itsayushpandey commented on PR #7712: URL: https://github.com/apache/cloudstack/pull/7712#issuecomment-1624326511 @DaanHoogland I've implemented the changes you've suggested in the latest pull request. -- This is an automated message from the Apache Git Service. To respond to the