[GitHub] [cloudstack] ustcweizhou commented on issue #3194: Suspending a VM before snapshot deletion (see PR #3193)

ustcweizhou commented on issue #3194: Suspending a VM before snapshot deletion (see PR #3193) URL: https://github.com/apache/cloudstack/pull/3194#issuecomment-498616755 @rhtyd good lgtm now. This is an automated message

[GitHub] [cloudstack] ustcweizhou commented on issue #3194: Suspending a VM before snapshot deletion (see PR #3193)

ustcweizhou commented on issue #3194: Suspending a VM before snapshot deletion (see PR #3193) URL: https://github.com/apache/cloudstack/pull/3194#issuecomment-498222616 @melnik13 Beside what @rhtyd said, you can change the description in CreateVMSnapshotCmd.java and

[GitHub] [cloudstack] ustcweizhou commented on issue #3194: Suspending a VM before snapshot deletion (see PR #3193)

ustcweizhou commented on issue #3194: Suspending a VM before snapshot deletion (see PR #3193) URL: https://github.com/apache/cloudstack/pull/3194#issuecomment-497472821 code lgtm, tested ok. can you also add some information as part of this change to inform cloudstack/kvm users in api

[GitHub] [cloudstack] ustcweizhou commented on issue #3194: Suspending a VM before snapshot deletion (see PR #3193)

ustcweizhou commented on issue #3194: Suspending a VM before snapshot deletion (see PR #3193) URL: https://github.com/apache/cloudstack/pull/3194#issuecomment-469454159 @melnik13 by the way ,could you please add another commit to suspend vm when delete a vm snapshot ?

[GitHub] [cloudstack] ustcweizhou commented on issue #3194: Suspending a VM before snapshot deletion (see PR #3193)

ustcweizhou commented on issue #3194: Suspending a VM before snapshot deletion (see PR #3193) URL: https://github.com/apache/cloudstack/pull/3194#issuecomment-469453669 @melnik13 good, thanks for your reply. this PR is good for me now