[GitHub] [cloudstack] weizhouapache commented on a diff in pull request #7515: Feature: Add unmanaged kubernetes cluster

2023-05-25 Thread via GitHub
weizhouapache commented on code in PR #7515: URL: https://github.com/apache/cloudstack/pull/7515#discussion_r1205950709 ## ui/src/views/compute/KubernetesServiceTab.vue: ## @@ -25,17 +25,14 @@ - + Review Comment: you can rollback the

[GitHub] [cloudstack] weizhouapache commented on a diff in pull request #7515: Feature: Add unmanaged kubernetes cluster

2023-05-25 Thread via GitHub
weizhouapache commented on code in PR #7515: URL: https://github.com/apache/cloudstack/pull/7515#discussion_r1205223919 ## engine/schema/src/main/resources/META-INF/db/schema-41810to41900.sql: ## @@ -135,3 +135,7 @@ CREATE VIEW `cloud`.`async_job_view` AS UPDATE

[GitHub] [cloudstack] weizhouapache commented on a diff in pull request #7515: Feature: Add unmanaged kubernetes cluster

2023-05-24 Thread via GitHub
weizhouapache commented on code in PR #7515: URL: https://github.com/apache/cloudstack/pull/7515#discussion_r1203700906 ## plugins/integrations/kubernetes-service/src/main/java/org/apache/cloudstack/api/command/user/kubernetes/cluster/StartKubernetesClusterCmd.java: ## @@ -99,6

[GitHub] [cloudstack] weizhouapache commented on a diff in pull request #7515: Feature: Add unmanaged kubernetes cluster

2023-05-24 Thread via GitHub
weizhouapache commented on code in PR #7515: URL: https://github.com/apache/cloudstack/pull/7515#discussion_r1203698220 ## plugins/integrations/kubernetes-service/src/main/java/org/apache/cloudstack/api/command/user/kubernetes/cluster/StartKubernetesClusterCmd.java: ## @@ -99,6

[GitHub] [cloudstack] weizhouapache commented on a diff in pull request #7515: Feature: Add unmanaged kubernetes cluster

2023-05-23 Thread via GitHub
weizhouapache commented on code in PR #7515: URL: https://github.com/apache/cloudstack/pull/7515#discussion_r1191321686 ## plugins/integrations/kubernetes-service/src/main/java/org/apache/cloudstack/api/command/user/kubernetes/cluster/CreateKubernetesClusterCmd.java: ## @@

[GitHub] [cloudstack] weizhouapache commented on a diff in pull request #7515: Feature: Add unmanaged kubernetes cluster

2023-05-11 Thread via GitHub
weizhouapache commented on code in PR #7515: URL: https://github.com/apache/cloudstack/pull/7515#discussion_r1191318997 ## plugins/integrations/kubernetes-service/src/main/java/org/apache/cloudstack/api/command/user/kubernetes/cluster/AddVmsToKubernetesClusterCmd.java: ## @@