weizhouapache commented on code in PR #7746:
URL: https://github.com/apache/cloudstack/pull/7746#discussion_r1309923306
##########
engine/components-api/src/main/java/com/cloud/configuration/ConfigurationManager.java:
##########
@@ -54,10 +55,40 @@
*/
public interface ConfigurationManager {
- public static final String MESSAGE_CREATE_POD_IP_RANGE_EVENT =
"Message.CreatePodIpRange.Event";
- public static final String MESSAGE_DELETE_POD_IP_RANGE_EVENT =
"Message.DeletePodIpRange.Event";
- public static final String MESSAGE_CREATE_VLAN_IP_RANGE_EVENT =
"Message.CreateVlanIpRange.Event";
- public static final String MESSAGE_DELETE_VLAN_IP_RANGE_EVENT =
"Message.DeleteVlanIpRange.Event";
+ String MESSAGE_CREATE_POD_IP_RANGE_EVENT =
"Message.CreatePodIpRange.Event";
+ String MESSAGE_DELETE_POD_IP_RANGE_EVENT =
"Message.DeletePodIpRange.Event";
+ String MESSAGE_CREATE_VLAN_IP_RANGE_EVENT =
"Message.CreateVlanIpRange.Event";
+ String MESSAGE_DELETE_VLAN_IP_RANGE_EVENT =
"Message.DeleteVlanIpRange.Event";
+
+ ConfigKey<Boolean> SystemVMUseLocalStorage = new ConfigKey<>(
+ Boolean.class,
+ "system.vm.use.local.storage",
+ "Advanced",
+ "false",
+ "Indicates whether to use local storage pools or shared storage
pools for system VMs.",
+ false,
+ ConfigKey.Scope.Zone,
+ null);
+
+ ConfigKey<String> ControlCidr = new ConfigKey<>(
+ String.class,
+ "control.cidr",
+ "Advanced",
+ "169.254.0.0/16",
Review Comment:
@DaanHoogland
as I understand, Wido wants /20 to be the default in new environments.
It would be good to update the config description to emphasize that the new
value only applies on new pods.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
