[GitHub] DaanHoogland commented on issue #2674: Create unit test cases for 'ConfigDriveBuilder' class

2018-05-29 Thread GitBox
DaanHoogland commented on issue #2674: Create unit test cases for 'ConfigDriveBuilder' class URL: https://github.com/apache/cloudstack/pull/2674#issuecomment-392700888 I will discuss with @PaulAngus before merging any more things in 4.11 while we have an RC out.

[GitHub] DaanHoogland commented on issue #2674: Create unit test cases for 'ConfigDriveBuilder' class

2018-05-29 Thread GitBox
DaanHoogland commented on issue #2674: Create unit test cases for 'ConfigDriveBuilder' class URL: https://github.com/apache/cloudstack/pull/2674#issuecomment-392700888 I will discuss with @PaulAngus before merging any more things in 4.11 while we an RC out.

[GitHub] DaanHoogland commented on issue #2674: Create unit test cases for 'ConfigDriveBuilder' class

2018-05-25 Thread GitBox
DaanHoogland commented on issue #2674: Create unit test cases for 'ConfigDriveBuilder' class URL: https://github.com/apache/cloudstack/pull/2674#issuecomment-391997996 jenkins is still red but I don't see this as config drive related. We should remove the infamous timeout test.