[GitHub] agx commented on issue #2083: Iptables speedup

2017-10-12 Thread git
agx commented on issue #2083: Iptables speedup URL: https://github.com/apache/cloudstack/pull/2083#issuecomment-336047386 @DaanHoogland from what I can see to use iptables-conv verbatim we'd mostly need to - [x] not sys.exit(1) from the module - [ ] move to using logger instead

[GitHub] agx commented on issue #2083: Iptables speedup

2017-10-12 Thread git
agx commented on issue #2083: Iptables speedup URL: https://github.com/apache/cloudstack/pull/2083#issuecomment-336047386 @DaanHoogland from what I can see to use iptables-conv verbatim we'd mostly need to - [x] not sys.exit(1) from the module - [x] move to using logger instead

[GitHub] agx commented on issue #2083: Iptables speedup

2017-10-12 Thread git
agx commented on issue #2083: Iptables speedup URL: https://github.com/apache/cloudstack/pull/2083#issuecomment-336047386 @DaanHoogland from what I can see to use iptables-conv verbatim we'd mostly need to - [x] not sys.exit(1) from the module - [ ] move to using logger instead

[GitHub] agx commented on issue #2083: Iptables speedup

2017-10-12 Thread git
agx commented on issue #2083: Iptables speedup URL: https://github.com/apache/cloudstack/pull/2083#issuecomment-336047386 @DaanHoogland from what I can see to use iptables-conv verbatim we'd mostly need to * not sys.exit(1) from the module (done) * move to using logger instead

[GitHub] agx commented on issue #2083: Iptables speedup

2017-10-06 Thread git
agx commented on issue #2083: Iptables speedup URL: https://github.com/apache/cloudstack/pull/2083#issuecomment-331392272 @kiwiflyer if you're fine with adding iptables-converter to your python requirements.txt I can work with @sl0 to turn this into a pypi'able module (if that's o.k. for

[GitHub] agx commented on issue #2083: Iptables speedup

2017-09-22 Thread git
agx commented on issue #2083: Iptables speedup URL: https://github.com/apache/cloudstack/pull/2083#issuecomment-331392272 @kiwiflyer if you're fine with adding iptables-opti to your python requirements.txt I can work with @sl0 to turn this into a pypi'able module (if that's o.k. for him)

[GitHub] agx commented on issue #2083: Iptables speedup

2017-08-22 Thread git
agx commented on issue #2083: Iptables speedup URL: https://github.com/apache/cloudstack/pull/2083#issuecomment-324108720 @DaanHoogland Wouldn't it be nicer if cloudstack would pull this in via either pypi or as a git submodule? This way diverging of the codebases would be less likely