mike-tutkowski commented on issue #2402: [CLOUDSTACK-10128] Simplify the search
for host to execute command
URL: https://github.com/apache/cloudstack/pull/2402#issuecomment-366800222
Sounds good - we should all get used to marking that field.
On Feb 19, 2018, at 12:46 PM, Rafael
mike-tutkowski commented on issue #2402: [CLOUDSTACK-10128] Simplify the search
for host to execute command
URL: https://github.com/apache/cloudstack/pull/2402#issuecomment-366797995
Yes, per my prior comments, the code LGTM and the two tests that previously
failed now pass.
mike-tutkowski commented on issue #2402: [CLOUDSTACK-10128] Simplify the search
for host to execute command
URL: https://github.com/apache/cloudstack/pull/2402#issuecomment-359588825
The code LGTM. Also, as noted above, I tested both failed use cases that led
to this PR and they both work
mike-tutkowski commented on issue #2402: [CLOUDSTACK-10128] Simplify the search
for host to execute command
URL: https://github.com/apache/cloudstack/pull/2402#issuecomment-359588567
I have also tested the other failed use case that led to this PR: Take a
volume snapshot of a volume.
mike-tutkowski commented on issue #2402: [CLOUDSTACK-10128] Simplify the search
for host to execute command
URL: https://github.com/apache/cloudstack/pull/2402#issuecomment-359587811
The managed-storage test for 4.11 RC1 that failed and led to the creation of
the JIRA ticket that this PR
mike-tutkowski commented on issue #2402: [CLOUDSTACK-10128] Simplify the search
for host to execute command
URL: https://github.com/apache/cloudstack/pull/2402#issuecomment-357557644
@rhtyd @rafaelweingartner @DaanHoogland If we are OK with waiting until the
first 4.11 maintenance release
mike-tutkowski commented on issue #2402: [CLOUDSTACK-10128] Simplify the search
for host to execute command
URL: https://github.com/apache/cloudstack/pull/2402#issuecomment-357557367
@rhtyd @rafaelweingartner @DaanHoogland I don't think it's really a blocker.
Perhaps we can get it into
mike-tutkowski commented on issue #2402: [CLOUDSTACK-10128] Simplify the search
for host to execute command
URL: https://github.com/apache/cloudstack/pull/2402#issuecomment-357557367
@rhtyd @rafaelweingartner @DaanHoogland I don't think it's really a blocker.
Perhaps we can get it into
mike-tutkowski commented on issue #2402: [CLOUDSTACK-10128] Simplify the search
for host to execute command
URL: https://github.com/apache/cloudstack/pull/2402#issuecomment-357557367
@rhtyd @rafaelweingartner @DaanHoogland I don't think it's really a blocker.
Perhaps we can get it into
mike-tutkowski commented on issue #2402: [CLOUDSTACK-10128] Simplify the search
for host to execute command
URL: https://github.com/apache/cloudstack/pull/2402#issuecomment-357005067
@rafaelweingartner I have the same problem with Travis on my PR.
mike-tutkowski commented on issue #2402: [CLOUDSTACK-10128] Simplify the search
for host to execute command
URL: https://github.com/apache/cloudstack/pull/2402#issuecomment-357002394
This should definitely at least go into a maintenance release for 4.11.
I can test this out soon.
11 matches
Mail list logo
