[GitHub] rhtyd commented on issue #2638: agent: Fixes #2633 don't wait for pending tasks on reconnection

2018-05-16 Thread GitBox
rhtyd commented on issue #2638: agent: Fixes #2633 don't wait for pending tasks on reconnection URL: https://github.com/apache/cloudstack/pull/2638#issuecomment-389465922 Tests LGTM, based on reviews/discussions and test results I'll merge this. If there are any objections, we'll revert th

[GitHub] rhtyd commented on issue #2638: agent: Fixes #2633 don't wait for pending tasks on reconnection

2018-05-15 Thread GitBox
rhtyd commented on issue #2638: agent: Fixes #2633 don't wait for pending tasks on reconnection URL: https://github.com/apache/cloudstack/pull/2638#issuecomment-389385984 @blueorangutan test centos7 xenserver-71 This is an au

[GitHub] rhtyd commented on issue #2638: agent: Fixes #2633 don't wait for pending tasks on reconnection

2018-05-15 Thread GitBox
rhtyd commented on issue #2638: agent: Fixes #2633 don't wait for pending tasks on reconnection URL: https://github.com/apache/cloudstack/pull/2638#issuecomment-389233769 All, if there are no objections based on the discussion on dev@ and code investigation and experimentation/testing, I'l

[GitHub] rhtyd commented on issue #2638: agent: Fixes #2633 don't wait for pending tasks on reconnection

2018-05-15 Thread GitBox
rhtyd commented on issue #2638: agent: Fixes #2633 don't wait for pending tasks on reconnection URL: https://github.com/apache/cloudstack/pull/2638#issuecomment-389210385 Tests LGTM, but I'll kick another round. @blueorangutan test matrix

[GitHub] rhtyd commented on issue #2638: agent: Fixes #2633 don't wait for pending tasks on reconnection

2018-05-15 Thread GitBox
rhtyd commented on issue #2638: agent: Fixes #2633 don't wait for pending tasks on reconnection URL: https://github.com/apache/cloudstack/pull/2638#issuecomment-389086522 @sureshanaparti The pending tasks fail before reconnecting to the management server. I tried a while-wait approach for

[GitHub] rhtyd commented on issue #2638: agent: Fixes #2633 don't wait for pending tasks on reconnection

2018-05-14 Thread GitBox
rhtyd commented on issue #2638: agent: Fixes #2633 don't wait for pending tasks on reconnection URL: https://github.com/apache/cloudstack/pull/2638#issuecomment-388776479 @wido good point. I'm thinking we may need additional time to test the side-effects if any, however theoretically readi

[GitHub] rhtyd commented on issue #2638: agent: Fixes #2633 don't wait for pending tasks on reconnection

2018-05-11 Thread GitBox
rhtyd commented on issue #2638: agent: Fixes #2633 don't wait for pending tasks on reconnection URL: https://github.com/apache/cloudstack/pull/2638#issuecomment-388328726 @blueoragutan package This is an automated message fro