[GitHub] wido commented on issue #2795: kvm: Properly report available memory to Management Server

2019-01-16 Thread GitBox
wido commented on issue #2795: kvm: Properly report available memory to Management Server URL: https://github.com/apache/cloudstack/pull/2795#issuecomment-454965236 I just rebased against master and everything seems fine to me. Are there any objections on this PR?

[GitHub] wido commented on issue #2795: kvm: Properly report available memory to Management Server

2019-01-08 Thread GitBox
wido commented on issue #2795: kvm: Properly report available memory to Management Server URL: https://github.com/apache/cloudstack/pull/2795#issuecomment-452351867 I just force pushed. This seems to be a thing (Unit Test) which fails on Travis, but works on my local system. Could

[GitHub] wido commented on issue #2795: kvm: Properly report available memory to Management Server

2019-01-08 Thread GitBox
wido commented on issue #2795: kvm: Properly report available memory to Management Server URL: https://github.com/apache/cloudstack/pull/2795#issuecomment-452284356 Jenkins is happy now. How are we with this PR? Can we merge it? All comments seem to be adressed

[GitHub] wido commented on issue #2795: kvm: Properly report available memory to Management Server

2018-12-17 Thread GitBox
wido commented on issue #2795: kvm: Properly report available memory to Management Server URL: https://github.com/apache/cloudstack/pull/2795#issuecomment-447812360 Jekins should start again now :) This is an automated

[GitHub] wido commented on issue #2795: kvm: Properly report available memory to Management Server

2018-12-10 Thread GitBox
wido commented on issue #2795: kvm: Properly report available memory to Management Server URL: https://github.com/apache/cloudstack/pull/2795#issuecomment-445747389 I just fixed a conflict. This should merge properly now.

[GitHub] wido commented on issue #2795: kvm: Properly report available memory to Management Server

2018-12-05 Thread GitBox
wido commented on issue #2795: kvm: Properly report available memory to Management Server URL: https://github.com/apache/cloudstack/pull/2795#issuecomment-444546151 @rafaelweingartner I think I addressed your comments. I left the 'hvm' code in there as it does serve a purpose. If

[GitHub] wido commented on issue #2795: kvm: Properly report available memory to Management Server

2018-11-28 Thread GitBox
wido commented on issue #2795: kvm: Properly report available memory to Management Server URL: https://github.com/apache/cloudstack/pull/2795#issuecomment-442482678 I will @rhtyd Currently in the middle of VXLAN testing, so postponing this one for a moment. Need to pick it up soon

[GitHub] wido commented on issue #2795: kvm: Properly report available memory to Management Server

2018-11-09 Thread GitBox
wido commented on issue #2795: kvm: Properly report available memory to Management Server URL: https://github.com/apache/cloudstack/pull/2795#issuecomment-437339425 I see @rafaelweingartner ! Missed those, I will look at them.

[GitHub] wido commented on issue #2795: kvm: Properly report available memory to Management Server

2018-11-09 Thread GitBox
wido commented on issue #2795: kvm: Properly report available memory to Management Server URL: https://github.com/apache/cloudstack/pull/2795#issuecomment-437293809 It seems we are ready to merge this one? This is an

[GitHub] wido commented on issue #2795: kvm: Properly report available memory to Management Server

2018-09-27 Thread GitBox
wido commented on issue #2795: kvm: Properly report available memory to Management Server URL: https://github.com/apache/cloudstack/pull/2795#issuecomment-425203824 The tests which were failing here do not seem related to the change. Is this one ready to merge?

[GitHub] wido commented on issue #2795: kvm: Properly report available memory to Management Server

2018-08-16 Thread GitBox
wido commented on issue #2795: kvm: Properly report available memory to Management Server URL: https://github.com/apache/cloudstack/pull/2795#issuecomment-413559975 @dhlaluku I've rebased against master This is an automated

[GitHub] wido commented on issue #2795: kvm: Properly report available memory to Management Server

2018-08-09 Thread GitBox
wido commented on issue #2795: kvm: Properly report available memory to Management Server URL: https://github.com/apache/cloudstack/pull/2795#issuecomment-411777937 Ping @RPDiep This is an automated message from the Apache

[GitHub] wido commented on issue #2795: kvm: Properly report available memory to Management Server

2018-08-09 Thread GitBox
wido commented on issue #2795: kvm: Properly report available memory to Management Server URL: https://github.com/apache/cloudstack/pull/2795#issuecomment-41193 @rhtyd Done, I've renamed the class and the logger variable. How does this look like?