DaanHoogland commented on PR #11285:
URL: https://github.com/apache/cloudstack/pull/11285#issuecomment-3179084743
@weizhouapache I agree with
https://github.com/apache/cloudstack/pull/11285#discussion_r2262809271 but
would like to leave it out of scope here…?
--
This is an automated mess
jbampton commented on PR #11285:
URL: https://github.com/apache/cloudstack/pull/11285#issuecomment-3178651780
> @jbampton , if you are alright with the suggested changes, we can apply
those and test??
Done now @DaanHoogland thanks
--
This is an automated message from the Apache Git
DaanHoogland commented on PR #11285:
URL: https://github.com/apache/cloudstack/pull/11285#issuecomment-3173661657
ping @jbampton ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific com
weizhouapache commented on code in PR #11285:
URL: https://github.com/apache/cloudstack/pull/11285#discussion_r2262809271
##
.github/linters/codespell.txt:
##
@@ -190,7 +190,6 @@ erro
erronous
everthing
everytime
-excetion
excption
Review Comment:
Actually I think more w
JoaoJandre commented on PR #11285:
URL: https://github.com/apache/cloudstack/pull/11285#issuecomment-3167636199
> @weizhouapache @JoaoJandre @sureshanaparti (and others) what do you think;
>
> > I like the change, but would like to take the chance to also change
> >
> > 1. the u
DaanHoogland commented on PR #11285:
URL: https://github.com/apache/cloudstack/pull/11285#issuecomment-3167212769
@jbampton , if you are alright with the suggested changes, we can apply
those and test??
--
This is an automated message from the Apache Git Service.
To respond to the message
DaanHoogland commented on code in PR #11285:
URL: https://github.com/apache/cloudstack/pull/11285#discussion_r2262445590
##
.github/linters/codespell.txt:
##
@@ -190,7 +190,6 @@ erro
erronous
everthing
everytime
-excetion
excption
Review Comment:
```suggestion
```
weizhouapache commented on code in PR #11285:
URL: https://github.com/apache/cloudstack/pull/11285#discussion_r2262079474
##
.github/linters/codespell.txt:
##
@@ -190,7 +190,6 @@ erro
erronous
everthing
everytime
-excetion
excption
Review Comment:
and remove this ?
--
DaanHoogland commented on PR #11285:
URL: https://github.com/apache/cloudstack/pull/11285#issuecomment-3116761499
@weizhouapache @JoaoJandre @sureshanaparti (and others) what do you think;
> I like the change, but would like to take the chance to also change
>
> 1. the use of th
DaanHoogland commented on code in PR #11285:
URL: https://github.com/apache/cloudstack/pull/11285#discussion_r2230380987
##
server/src/main/java/com/cloud/storage/VolumeApiServiceImpl.java:
##
@@ -3105,7 +3105,7 @@ public Volume detachVolumeFromVM(DetachVolumeCmd cmmd) {
blueorangutan commented on PR #11285:
URL: https://github.com/apache/cloudstack/pull/11285#issuecomment-3113662704
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14350
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
blueorangutan commented on PR #11285:
URL: https://github.com/apache/cloudstack/pull/11285#issuecomment-3113286301
@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It
will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep
you posted as I make prog
sureshanaparti commented on PR #11285:
URL: https://github.com/apache/cloudstack/pull/11285#issuecomment-3113281874
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
codecov[bot] commented on PR #11285:
URL: https://github.com/apache/cloudstack/pull/11285#issuecomment-3113177943
##
[Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/11285?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comme
jbampton opened a new pull request, #11285:
URL: https://github.com/apache/cloudstack/pull/11285
Update codespell.txt remove `excetion`
### Description
This PR fixes a simple typo in the exception messages.
Hoping simple fixes can be merged quickly. Let us move faster :r
15 matches
Mail list logo
