shwstppr merged PR #8435:
URL: https://github.com/apache/cloudstack/pull/8435
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
shwstppr commented on code in PR #8435:
URL: https://github.com/apache/cloudstack/pull/8435#discussion_r1441672253
##
ui/src/views/iam/AddAccount.vue:
##
@@ -303,7 +303,6 @@ export default {
} else {
this.loadMore(apiToCall, page + 1, sema)
}
-
rohityadavcloud commented on code in PR #8435:
URL: https://github.com/apache/cloudstack/pull/8435#discussion_r1441668829
##
ui/src/views/iam/AddAccount.vue:
##
@@ -303,7 +303,6 @@ export default {
} else {
this.loadMore(apiToCall, page + 1, sema)
}
shwstppr commented on PR #8435:
URL: https://github.com/apache/cloudstack/pull/8435#issuecomment-1876948205
@DaanHoogland it is working for me. For you is the page to opening or login
not working or the fix not working? Incognito window may help
--
This is an automated message from the
blueorangutan commented on PR #8435:
URL: https://github.com/apache/cloudstack/pull/8435#issuecomment-1876434223
UI build: :heavy_check_mark:
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/8435 (QA-JID-252)
--
This is an automated message from the Apache Git Service.
To respond
blueorangutan commented on PR #8435:
URL: https://github.com/apache/cloudstack/pull/8435#issuecomment-1876404248
@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you
posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to
shwstppr commented on PR #8435:
URL: https://github.com/apache/cloudstack/pull/8435#issuecomment-1876403378
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
codecov[bot] commented on PR #8435:
URL: https://github.com/apache/cloudstack/pull/8435#issuecomment-1875354044
##
[Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/8435?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)
Report
All
shwstppr opened a new pull request, #8435:
URL: https://github.com/apache/cloudstack/pull/8435
### Description
Fixes setting domainid param default value which was being set to 0.
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing
