Re: [PR] Update `vpc.max.networks` setting & settings to limit the number of NICs for each hypervisor [cloudstack]

blueorangutan commented on PR #8654: URL: https://github.com/apache/cloudstack/pull/8654#issuecomment-2142838026 Packaging result [SF]: ✖️ el7 ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 9751 -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] Update `vpc.max.networks` setting & settings to limit the number of NICs for each hypervisor [cloudstack]

blueorangutan commented on PR #8654: URL: https://github.com/apache/cloudstack/pull/8654#issuecomment-2142814572 @hsato03 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Re: [PR] Update `vpc.max.networks` setting & settings to limit the number of NICs for each hypervisor [cloudstack]

hsato03 commented on PR #8654: URL: https://github.com/apache/cloudstack/pull/8654#issuecomment-2142812069 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Update `vpc.max.networks` setting & settings to limit the number of NICs for each hypervisor [cloudstack]

blueorangutan commented on PR #8654: URL: https://github.com/apache/cloudstack/pull/8654#issuecomment-2099394275 Packaging result [SF]: ✖️ el7 ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 9570 -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] Update `vpc.max.networks` setting & settings to limit the number of NICs for each hypervisor [cloudstack]

blueorangutan commented on PR #8654: URL: https://github.com/apache/cloudstack/pull/8654#issuecomment-2099329239 @hsato03 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Re: [PR] Update `vpc.max.networks` setting & settings to limit the number of NICs for each hypervisor [cloudstack]

hsato03 commented on PR #8654: URL: https://github.com/apache/cloudstack/pull/8654#issuecomment-2099326245 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Update `vpc.max.networks` setting & settings to limit the number of NICs for each hypervisor [cloudstack]

blueorangutan commented on PR #8654: URL: https://github.com/apache/cloudstack/pull/8654#issuecomment-2092526410 Packaging result [SF]: ✖️ el7 ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 9524 -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] Update `vpc.max.networks` setting & settings to limit the number of NICs for each hypervisor [cloudstack]

blueorangutan commented on PR #8654: URL: https://github.com/apache/cloudstack/pull/8654#issuecomment-2092420552 @DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make

Re: [PR] Update `vpc.max.networks` setting & settings to limit the number of NICs for each hypervisor [cloudstack]

DaanHoogland commented on PR #8654: URL: https://github.com/apache/cloudstack/pull/8654#issuecomment-2092418078 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Update `vpc.max.networks` setting & settings to limit the number of NICs for each hypervisor [cloudstack]

DaanHoogland closed pull request #8654: Update `vpc.max.networks` setting & settings to limit the number of NICs for each hypervisor URL: https://github.com/apache/cloudstack/pull/8654 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] Update `vpc.max.networks` setting & settings to limit the number of NICs for each hypervisor [cloudstack]

hsato03 commented on PR #8654: URL: https://github.com/apache/cloudstack/pull/8654#issuecomment-2091529787 > > @DaanHoogland I don't think so, as the tests file is already declared in [github actions](https://github.com/apache/cloudstack/blob/main/.github/workflows/ci.yml#L195C1-L195C45).

Re: [PR] Update `vpc.max.networks` setting & settings to limit the number of NICs for each hypervisor [cloudstack]

DaanHoogland commented on PR #8654: URL: https://github.com/apache/cloudstack/pull/8654#issuecomment-2074238856 > @DaanHoogland I don't think so, as the tests file is already declared in [github

Re: [PR] Update `vpc.max.networks` setting & settings to limit the number of NICs for each hypervisor [cloudstack]

hsato03 commented on PR #8654: URL: https://github.com/apache/cloudstack/pull/8654#issuecomment-2073371725 @DaanHoogland I don't think so, as the tests file is already declared in [github actions](https://github.com/apache/cloudstack/blob/main/.github/workflows/ci.yml#L195C1-L195C45). --

Re: [PR] Update `vpc.max.networks` setting & settings to limit the number of NICs for each hypervisor [cloudstack]

DaanHoogland commented on PR #8654: URL: https://github.com/apache/cloudstack/pull/8654#issuecomment-2071910166 @hsato03 , should those extra integration tests be configured in github actions ? (or be added/moved to smoke tests) -- This is an automated message from the Apache Git

Re: [PR] Update `vpc.max.networks` setting & settings to limit the number of NICs for each hypervisor [cloudstack]

DaanHoogland closed pull request #8654: Update `vpc.max.networks` setting & settings to limit the number of NICs for each hypervisor URL: https://github.com/apache/cloudstack/pull/8654 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] Update `vpc.max.networks` setting & settings to limit the number of NICs for each hypervisor [cloudstack]

DaanHoogland commented on code in PR #8654: URL: https://github.com/apache/cloudstack/pull/8654#discussion_r1565321833 ## engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java: ## @@ -1090,6 +1098,77 @@ public Pair

Re: [PR] Update `vpc.max.networks` setting & settings to limit the number of NICs for each hypervisor [cloudstack]

weizhouapache commented on PR #8654: URL: https://github.com/apache/cloudstack/pull/8654#issuecomment-2051664956 overall code lgtm @hsato03 could you add a integration test for it ? the component test `test_vpc_vms_deployment.py` contains the tests on 'vpc.max.networks' but it

Re: [PR] Update `vpc.max.networks` setting & settings to limit the number of NICs for each hypervisor [cloudstack]

DaanHoogland closed pull request #8654: Update `vpc.max.networks` setting & settings to limit the number of NICs for each hypervisor URL: https://github.com/apache/cloudstack/pull/8654 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] Update `vpc.max.networks` setting & settings to limit the number of NICs for each hypervisor [cloudstack]

DaanHoogland commented on PR #8654: URL: https://github.com/apache/cloudstack/pull/8654#issuecomment-2047014711 @hsato03 it is a bit hidden in the output but please check https://github.com/apache/cloudstack/actions/runs/8622615987/job/23634113585?pr=8654#step:7:8601 . -- This is an

Re: [PR] Update `vpc.max.networks` setting & settings to limit the number of NICs for each hypervisor [cloudstack]

codecov-commenter commented on PR #8654: URL: https://github.com/apache/cloudstack/pull/8654#issuecomment-2046093011 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/8654?dropdown=coverage=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)

Re: [PR] Update `vpc.max.networks` setting & settings to limit the number of NICs for each hypervisor [cloudstack]

hsato03 commented on code in PR #8654: URL: https://github.com/apache/cloudstack/pull/8654#discussion_r1558153714 ## engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java: ## @@ -1090,6 +1098,77 @@ public Pair allocateNic(final

Re: [PR] Update `vpc.max.networks` setting & settings to limit the number of NICs for each hypervisor [cloudstack]

weizhouapache commented on code in PR #8654: URL: https://github.com/apache/cloudstack/pull/8654#discussion_r1551147308 ## engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java: ## @@ -1090,6 +1098,77 @@ public Pair

Re: [PR] Update `vpc.max.networks` setting & settings to limit the number of NICs for each hypervisor [cloudstack]

DaanHoogland commented on PR #8654: URL: https://github.com/apache/cloudstack/pull/8654#issuecomment-2036422132 @weizhouapache is this good for your sake now? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] Update `vpc.max.networks` setting & settings to limit the number of NICs for each hypervisor [cloudstack]

DaanHoogland commented on code in PR #8654: URL: https://github.com/apache/cloudstack/pull/8654#discussion_r1551087739 ## engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java: ## @@ -1090,6 +1098,77 @@ public Pair

Re: [PR] Update `vpc.max.networks` setting & settings to limit the number of NICs for each hypervisor [cloudstack]

blueorangutan commented on PR #8654: URL: https://github.com/apache/cloudstack/pull/8654#issuecomment-2035654084 [SF] Trillian test result (tid-9680) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 46504 seconds Marvin logs:

Re: [PR] Update `vpc.max.networks` setting & settings to limit the number of NICs for each hypervisor [cloudstack]

blueorangutan commented on PR #8654: URL: https://github.com/apache/cloudstack/pull/8654#issuecomment-2033882694 @DaanHoogland a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To

Re: [PR] Update `vpc.max.networks` setting & settings to limit the number of NICs for each hypervisor [cloudstack]

DaanHoogland commented on PR #8654: URL: https://github.com/apache/cloudstack/pull/8654#issuecomment-2033878686 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Update `vpc.max.networks` setting & settings to limit the number of NICs for each hypervisor [cloudstack]

blueorangutan commented on PR #8654: URL: https://github.com/apache/cloudstack/pull/8654#issuecomment-2033393239 [SF] Trillian test result (tid-9654) Environment: kvm-alma9 (x2), Advanced Networking with Mgmt server a9 Total time taken: 56484 seconds Marvin logs:

Re: [PR] Update `vpc.max.networks` setting & settings to limit the number of NICs for each hypervisor [cloudstack]

blueorangutan commented on PR #8654: URL: https://github.com/apache/cloudstack/pull/8654#issuecomment-2031521960 @DaanHoogland a [SL] Trillian-Jenkins test job (alma9 mgmt + kvm-alma9) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To

Re: [PR] Update `vpc.max.networks` setting & settings to limit the number of NICs for each hypervisor [cloudstack]

DaanHoogland commented on PR #8654: URL: https://github.com/apache/cloudstack/pull/8654#issuecomment-2031519718 @blueorangutan test alma9 kvm-alma9 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] Update `vpc.max.networks` setting & settings to limit the number of NICs for each hypervisor [cloudstack]

blueorangutan commented on PR #8654: URL: https://github.com/apache/cloudstack/pull/8654#issuecomment-2027489832 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9096 -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] Update `vpc.max.networks` setting & settings to limit the number of NICs for each hypervisor [cloudstack]

blueorangutan commented on PR #8654: URL: https://github.com/apache/cloudstack/pull/8654#issuecomment-2027403457 @DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make

Re: [PR] Update `vpc.max.networks` setting & settings to limit the number of NICs for each hypervisor [cloudstack]

DaanHoogland commented on PR #8654: URL: https://github.com/apache/cloudstack/pull/8654#issuecomment-2027402791 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Update `vpc.max.networks` setting & settings to limit the number of NICs for each hypervisor [cloudstack]

hsato03 commented on code in PR #8654: URL: https://github.com/apache/cloudstack/pull/8654#discussion_r1536169318 ## server/src/main/java/com/cloud/network/vpc/VpcManagerImpl.java: ## @@ -1983,6 +1995,19 @@ public void doInTransactionWithoutResult(final TransactionStatus

Re: [PR] Update `vpc.max.networks` setting & settings to limit the number of NICs for each hypervisor [cloudstack]

weizhouapache commented on code in PR #8654: URL: https://github.com/apache/cloudstack/pull/8654#discussion_r1534788366 ## server/src/main/java/com/cloud/network/vpc/VpcManagerImpl.java: ## @@ -1983,6 +1995,19 @@ public void doInTransactionWithoutResult(final TransactionStatus