Re: [PR] import unmanaged instance issues adressed [cloudstack]

2024-01-10 Thread via GitHub
DaanHoogland commented on code in PR #8488: URL: https://github.com/apache/cloudstack/pull/8488#discussion_r1447506058 ## server/src/main/java/org/apache/cloudstack/vm/UnmanagedVMsManagerImpl.java: ## @@ -695,9 +695,16 @@ private void

Re: [PR] import unmanaged instance issues adressed [cloudstack]

2024-01-10 Thread via GitHub
blueorangutan commented on PR #8488: URL: https://github.com/apache/cloudstack/pull/8488#issuecomment-1884933554 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8273 -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] import unmanaged instance issues adressed [cloudstack]

2024-01-10 Thread via GitHub
DaanHoogland commented on code in PR #8488: URL: https://github.com/apache/cloudstack/pull/8488#discussion_r1447347329 ## server/src/main/java/org/apache/cloudstack/vm/UnmanagedVMsManagerImpl.java: ## @@ -695,9 +695,16 @@ private void

Re: [PR] import unmanaged instance issues adressed [cloudstack]

2024-01-10 Thread via GitHub
shwstppr commented on code in PR #8488: URL: https://github.com/apache/cloudstack/pull/8488#discussion_r1447327186 ## server/src/main/java/org/apache/cloudstack/vm/UnmanagedVMsManagerImpl.java: ## @@ -695,9 +695,16 @@ private void checkUnmanagedNicIpAndNetworkForImport(String

Re: [PR] import unmanaged instance issues adressed [cloudstack]

2024-01-10 Thread via GitHub
DaanHoogland commented on code in PR #8488: URL: https://github.com/apache/cloudstack/pull/8488#discussion_r1447255122 ## server/src/main/java/org/apache/cloudstack/vm/UnmanagedVMsManagerImpl.java: ## @@ -695,9 +695,16 @@ private void

Re: [PR] import unmanaged instance issues adressed [cloudstack]

2024-01-10 Thread via GitHub
shwstppr commented on code in PR #8488: URL: https://github.com/apache/cloudstack/pull/8488#discussion_r1447254293 ## server/src/main/java/org/apache/cloudstack/vm/UnmanagedVMsManagerImpl.java: ## @@ -695,9 +695,16 @@ private void checkUnmanagedNicIpAndNetworkForImport(String

Re: [PR] import unmanaged instance issues adressed [cloudstack]

2024-01-10 Thread via GitHub
DaanHoogland commented on code in PR #8488: URL: https://github.com/apache/cloudstack/pull/8488#discussion_r1447256623 ## server/src/main/java/org/apache/cloudstack/vm/UnmanagedVMsManagerImpl.java: ## @@ -695,9 +695,16 @@ private void

Re: [PR] import unmanaged instance issues adressed [cloudstack]

2024-01-10 Thread via GitHub
blueorangutan commented on PR #8488: URL: https://github.com/apache/cloudstack/pull/8488#issuecomment-1884671791 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8270 -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] import unmanaged instance issues adressed [cloudstack]

2024-01-10 Thread via GitHub
shwstppr commented on code in PR #8488: URL: https://github.com/apache/cloudstack/pull/8488#discussion_r1447253702 ## server/src/main/java/org/apache/cloudstack/vm/UnmanagedVMsManagerImpl.java: ## @@ -695,9 +695,16 @@ private void checkUnmanagedNicIpAndNetworkForImport(String

Re: [PR] import unmanaged instance issues adressed [cloudstack]

2024-01-10 Thread via GitHub
DaanHoogland commented on PR #8488: URL: https://github.com/apache/cloudstack/pull/8488#issuecomment-1884507214 the rootsize issue seems solved (tested) the available ips for the network return as an empty list however, so that part needs work As it is fixing some issue I am adding it

Re: [PR] import unmanaged instance issues adressed [cloudstack]

2024-01-10 Thread via GitHub
blueorangutan commented on PR #8488: URL: https://github.com/apache/cloudstack/pull/8488#issuecomment-1884471801 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8265 -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] import unmanaged instance issues adressed [cloudstack]

2024-01-10 Thread via GitHub
codecov[bot] commented on PR #8488: URL: https://github.com/apache/cloudstack/pull/8488#issuecomment-1884377849 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/8488?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report All

Re: [PR] import unmanaged instance issues adressed [cloudstack]

2024-01-10 Thread via GitHub
blueorangutan commented on PR #8488: URL: https://github.com/apache/cloudstack/pull/8488#issuecomment-1884368796 @DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make

Re: [PR] import unmanaged instance issues adressed [cloudstack]

2024-01-10 Thread via GitHub
DaanHoogland commented on PR #8488: URL: https://github.com/apache/cloudstack/pull/8488#issuecomment-1884366807 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the