Re: [PR] server: fix fail to list public ips of shared networks sometimes [cloudstack]

2024-06-04 Thread via GitHub
DaanHoogland merged PR #8624: URL: https://github.com/apache/cloudstack/pull/8624 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] server: fix fail to list public ips of shared networks sometimes [cloudstack]

2024-06-03 Thread via GitHub
DaanHoogland closed pull request #8624: server: fix fail to list public ips of shared networks sometimes URL: https://github.com/apache/cloudstack/pull/8624 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] server: fix fail to list public ips of shared networks sometimes [cloudstack]

2024-05-28 Thread via GitHub
blueorangutan commented on PR #8624: URL: https://github.com/apache/cloudstack/pull/8624#issuecomment-2136349321 [SF] Trillian test result (tid-10308) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 44310 seconds Marvin logs:

Re: [PR] server: fix fail to list public ips of shared networks sometimes [cloudstack]

2024-05-28 Thread via GitHub
blueorangutan commented on PR #8624: URL: https://github.com/apache/cloudstack/pull/8624#issuecomment-2135112362 @weizhouapache a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To

Re: [PR] server: fix fail to list public ips of shared networks sometimes [cloudstack]

2024-05-28 Thread via GitHub
weizhouapache commented on PR #8624: URL: https://github.com/apache/cloudstack/pull/8624#issuecomment-2135108181 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] server: fix fail to list public ips of shared networks sometimes [cloudstack]

2024-05-28 Thread via GitHub
blueorangutan commented on PR #8624: URL: https://github.com/apache/cloudstack/pull/8624#issuecomment-2134902652 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9721 -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] server: fix fail to list public ips of shared networks sometimes [cloudstack]

2024-05-28 Thread via GitHub
blueorangutan commented on PR #8624: URL: https://github.com/apache/cloudstack/pull/8624#issuecomment-2134757894 @weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make

Re: [PR] server: fix fail to list public ips of shared networks sometimes [cloudstack]

2024-05-28 Thread via GitHub
weizhouapache commented on PR #8624: URL: https://github.com/apache/cloudstack/pull/8624#issuecomment-2134756299 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] server: fix fail to list public ips of shared networks sometimes [cloudstack]

2024-05-28 Thread via GitHub
DaanHoogland closed pull request #8624: server: fix fail to list public ips of shared networks sometimes URL: https://github.com/apache/cloudstack/pull/8624 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] server: fix fail to list public ips of shared networks sometimes [cloudstack]

2024-05-28 Thread via GitHub
blueorangutan commented on PR #8624: URL: https://github.com/apache/cloudstack/pull/8624#issuecomment-2134593270 Packaging result [SF]: ✖️ el7 ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 9719 -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] server: fix fail to list public ips of shared networks sometimes [cloudstack]

2024-05-28 Thread via GitHub
blueorangutan commented on PR #8624: URL: https://github.com/apache/cloudstack/pull/8624#issuecomment-2134532489 @DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make

Re: [PR] server: fix fail to list public ips of shared networks sometimes [cloudstack]

2024-05-28 Thread via GitHub
DaanHoogland commented on PR #8624: URL: https://github.com/apache/cloudstack/pull/8624#issuecomment-2134529596 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] server: fix fail to list public ips of shared networks sometimes [cloudstack]

2024-05-28 Thread via GitHub
DaanHoogland commented on PR #8624: URL: https://github.com/apache/cloudstack/pull/8624#issuecomment-2134529386 let's make sure it doesn't cause the integration test failures -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] server: fix fail to list public ips of shared networks sometimes [cloudstack]

2024-05-28 Thread via GitHub
shwstppr commented on PR #8624: URL: https://github.com/apache/cloudstack/pull/8624#issuecomment-2134491105 @DaanHoogland @weizhouapache is this good to merge? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] server: fix fail to list public ips of shared networks sometimes [cloudstack]

2024-05-22 Thread via GitHub
blueorangutan commented on PR #8624: URL: https://github.com/apache/cloudstack/pull/8624#issuecomment-2125783783 [SF] Trillian test result (tid-10239) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 46013 seconds Marvin logs:

Re: [PR] server: fix fail to list public ips of shared networks sometimes [cloudstack]

2024-05-22 Thread via GitHub
blueorangutan commented on PR #8624: URL: https://github.com/apache/cloudstack/pull/8624#issuecomment-2124626871 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9668 -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] server: fix fail to list public ips of shared networks sometimes [cloudstack]

2024-05-22 Thread via GitHub
blueorangutan commented on PR #8624: URL: https://github.com/apache/cloudstack/pull/8624#issuecomment-2124504417 @weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make

Re: [PR] server: fix fail to list public ips of shared networks sometimes [cloudstack]

2024-05-22 Thread via GitHub
weizhouapache commented on PR #8624: URL: https://github.com/apache/cloudstack/pull/8624#issuecomment-2124503140 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] server: fix fail to list public ips of shared networks sometimes [cloudstack]

2024-05-22 Thread via GitHub
weizhouapache commented on PR #8624: URL: https://github.com/apache/cloudstack/pull/8624#issuecomment-2124496644 > @weizhouapache unless I'm missing the point, even if we decide on wrapping nic.getInstanceId() in a try-catch for NPE it would still need changes in many more places if

Re: [PR] server: fix fail to list public ips of shared networks sometimes [cloudstack]

2024-05-22 Thread via GitHub
shwstppr commented on PR #8624: URL: https://github.com/apache/cloudstack/pull/8624#issuecomment-2124448826 @weizhouapache unless I'm missing the point, even if we decide on wrapping nic.getInstanceId() in a try-catch for NPE it would still need changes in many more places -- This is an

Re: [PR] server: fix fail to list public ips of shared networks sometimes [cloudstack]

2024-05-22 Thread via GitHub
weizhouapache commented on PR #8624: URL: https://github.com/apache/cloudstack/pull/8624#issuecomment-2124336886 > @weizhouapache I see some other usages of `Nic.getinstanceId()` in code, do we need to fix/address them?

Re: [PR] server: fix fail to list public ips of shared networks sometimes [cloudstack]

2024-05-22 Thread via GitHub
vishesh92 commented on code in PR #8624: URL: https://github.com/apache/cloudstack/pull/8624#discussion_r1609613379 ## server/src/main/java/com/cloud/vm/UserVmManagerImpl.java: ## @@ -1566,7 +1566,7 @@ public UserVm removeNicFromVirtualMachine(RemoveNicFromVMCmd cmd) throws

Re: [PR] server: fix fail to list public ips of shared networks sometimes [cloudstack]

2024-05-22 Thread via GitHub
vishesh92 commented on code in PR #8624: URL: https://github.com/apache/cloudstack/pull/8624#discussion_r1609613801 ## server/src/main/java/com/cloud/vm/UserVmManagerImpl.java: ## @@ -1637,7 +1637,7 @@ public UserVm updateDefaultNicForVirtualMachine(UpdateDefaultNicForVMCmd

Re: [PR] server: fix fail to list public ips of shared networks sometimes [cloudstack]

2024-05-22 Thread via GitHub
vishesh92 commented on code in PR #8624: URL: https://github.com/apache/cloudstack/pull/8624#discussion_r1609613379 ## server/src/main/java/com/cloud/vm/UserVmManagerImpl.java: ## @@ -1566,7 +1566,7 @@ public UserVm removeNicFromVirtualMachine(RemoveNicFromVMCmd cmd) throws

Re: [PR] server: fix fail to list public ips of shared networks sometimes [cloudstack]

2024-05-22 Thread via GitHub
shwstppr commented on PR #8624: URL: https://github.com/apache/cloudstack/pull/8624#issuecomment-2124215982 @weizhouapache I see some other usages of `Nic.getinstanceId()` in code, do we need to fix/address them?

Re: [PR] server: fix fail to list public ips of shared networks sometimes [cloudstack]

2024-05-22 Thread via GitHub
blueorangutan commented on PR #8624: URL: https://github.com/apache/cloudstack/pull/8624#issuecomment-2124146288 @DaanHoogland a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To

Re: [PR] server: fix fail to list public ips of shared networks sometimes [cloudstack]

2024-05-22 Thread via GitHub
DaanHoogland commented on PR #8624: URL: https://github.com/apache/cloudstack/pull/8624#issuecomment-2124144597 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] server: fix fail to list public ips of shared networks sometimes [cloudstack]

2024-05-14 Thread via GitHub
blueorangutan commented on PR #8624: URL: https://github.com/apache/cloudstack/pull/8624#issuecomment-2110637038 [SF] Trillian Build Failed (tid-10204) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] server: fix fail to list public ips of shared networks sometimes [cloudstack]

2024-05-14 Thread via GitHub
blueorangutan commented on PR #8624: URL: https://github.com/apache/cloudstack/pull/8624#issuecomment-2110590438 @weizhouapache a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To

Re: [PR] server: fix fail to list public ips of shared networks sometimes [cloudstack]

2024-05-14 Thread via GitHub
weizhouapache commented on PR #8624: URL: https://github.com/apache/cloudstack/pull/8624#issuecomment-2110586612 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] server: fix fail to list public ips of shared networks sometimes [cloudstack]

2024-05-14 Thread via GitHub
blueorangutan commented on PR #8624: URL: https://github.com/apache/cloudstack/pull/8624#issuecomment-2110353901 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9609 -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] server: fix fail to list public ips of shared networks sometimes [cloudstack]

2024-05-14 Thread via GitHub
blueorangutan commented on PR #8624: URL: https://github.com/apache/cloudstack/pull/8624#issuecomment-2110174666 @weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make

Re: [PR] server: fix fail to list public ips of shared networks sometimes [cloudstack]

2024-05-14 Thread via GitHub
weizhouapache commented on PR #8624: URL: https://github.com/apache/cloudstack/pull/8624#issuecomment-2110172289 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] server: fix fail to list public ips of shared networks sometimes [cloudstack]

2024-05-14 Thread via GitHub
weizhouapache commented on code in PR #8624: URL: https://github.com/apache/cloudstack/pull/8624#discussion_r1599985741 ## server/src/main/java/com/cloud/vm/UserVmManagerImpl.java: ## @@ -1566,7 +1566,7 @@ public UserVm removeNicFromVirtualMachine(RemoveNicFromVMCmd cmd)

Re: [PR] server: fix fail to list public ips of shared networks sometimes [cloudstack]

2024-05-09 Thread via GitHub
vishesh92 commented on code in PR #8624: URL: https://github.com/apache/cloudstack/pull/8624#discussion_r1595216992 ## server/src/main/java/com/cloud/vm/UserVmManagerImpl.java: ## @@ -1566,7 +1566,7 @@ public UserVm removeNicFromVirtualMachine(RemoveNicFromVMCmd cmd) throws

Re: [PR] server: fix fail to list public ips of shared networks sometimes [cloudstack]

2024-04-26 Thread via GitHub
blueorangutan commented on PR #8624: URL: https://github.com/apache/cloudstack/pull/8624#issuecomment-2080207600 [SF] Trillian test result (tid-10045) Environment: kvm-rocky8 (x2), Advanced Networking with Mgmt server r8 Total time taken: 48172 seconds Marvin logs:

Re: [PR] server: fix fail to list public ips of shared networks sometimes [cloudstack]

2024-04-26 Thread via GitHub
blueorangutan commented on PR #8624: URL: https://github.com/apache/cloudstack/pull/8624#issuecomment-2078930378 @weizhouapache a [SL] Trillian-Jenkins test job (rocky8 mgmt + kvm-rocky8) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To

Re: [PR] server: fix fail to list public ips of shared networks sometimes [cloudstack]

2024-04-26 Thread via GitHub
weizhouapache commented on PR #8624: URL: https://github.com/apache/cloudstack/pull/8624#issuecomment-2078929178 @blueorangutan test rocky8 kvm-rocky8 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] server: fix fail to list public ips of shared networks sometimes [cloudstack]

2024-04-26 Thread via GitHub
blueorangutan commented on PR #8624: URL: https://github.com/apache/cloudstack/pull/8624#issuecomment-2078872542 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9434 -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] server: fix fail to list public ips of shared networks sometimes [cloudstack]

2024-04-26 Thread via GitHub
blueorangutan commented on PR #8624: URL: https://github.com/apache/cloudstack/pull/8624#issuecomment-2078753996 @DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make

Re: [PR] server: fix fail to list public ips of shared networks sometimes [cloudstack]

2024-04-26 Thread via GitHub
DaanHoogland commented on PR #8624: URL: https://github.com/apache/cloudstack/pull/8624#issuecomment-2078751354 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] server: fix fail to list public ips of shared networks sometimes [cloudstack]

2024-04-25 Thread via GitHub
weizhouapache commented on PR #8624: URL: https://github.com/apache/cloudstack/pull/8624#issuecomment-2077478988 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] server: fix fail to list public ips of shared networks sometimes [cloudstack]

2024-04-25 Thread via GitHub
codecov-commenter commented on PR #8624: URL: https://github.com/apache/cloudstack/pull/8624#issuecomment-2077170484 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/8624?dropdown=coverage=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)

Re: [PR] server: fix fail to list public ips of shared networks sometimes [cloudstack]

2024-04-25 Thread via GitHub
weizhouapache commented on PR #8624: URL: https://github.com/apache/cloudstack/pull/8624#issuecomment-2077170022 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] server: fix fail to list public ips of shared networks sometimes [cloudstack]

2024-04-25 Thread via GitHub
blueorangutan commented on PR #8624: URL: https://github.com/apache/cloudstack/pull/8624#issuecomment-2076608733 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9422 -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] server: fix fail to list public ips of shared networks sometimes [cloudstack]

2024-04-25 Thread via GitHub
weizhouapache commented on PR #8624: URL: https://github.com/apache/cloudstack/pull/8624#issuecomment-2076485633 there are consistent test failures, need check -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] server: fix fail to list public ips of shared networks sometimes [cloudstack]

2024-04-25 Thread via GitHub
blueorangutan commented on PR #8624: URL: https://github.com/apache/cloudstack/pull/8624#issuecomment-2076473368 @weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make

Re: [PR] server: fix fail to list public ips of shared networks sometimes [cloudstack]

2024-04-25 Thread via GitHub
weizhouapache commented on PR #8624: URL: https://github.com/apache/cloudstack/pull/8624#issuecomment-2076471325 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] server: fix fail to list public ips of shared networks sometimes [cloudstack]

2024-04-25 Thread via GitHub
weizhouapache commented on PR #8624: URL: https://github.com/apache/cloudstack/pull/8624#issuecomment-2076468431 merging based on approvals and manual/CI tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] server: fix fail to list public ips of shared networks sometimes [cloudstack]

2024-04-24 Thread via GitHub
blueorangutan commented on PR #8624: URL: https://github.com/apache/cloudstack/pull/8624#issuecomment-2076088875 [SF] Trillian test result (tid-9979) Environment: kvm-rocky8 (x2), Advanced Networking with Mgmt server r8 Total time taken: 52035 seconds Marvin logs:

Re: [PR] server: fix fail to list public ips of shared networks sometimes [cloudstack]

2024-04-24 Thread via GitHub
blueorangutan commented on PR #8624: URL: https://github.com/apache/cloudstack/pull/8624#issuecomment-2074496110 @weizhouapache a [SL] Trillian-Jenkins test job (rocky8 mgmt + kvm-rocky8) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To

Re: [PR] server: fix fail to list public ips of shared networks sometimes [cloudstack]

2024-04-24 Thread via GitHub
weizhouapache commented on PR #8624: URL: https://github.com/apache/cloudstack/pull/8624#issuecomment-2074492096 @blueorangutan test rocky8 kvm-rocky8 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] server: fix fail to list public ips of shared networks sometimes [cloudstack]

2024-04-24 Thread via GitHub
blueorangutan commented on PR #8624: URL: https://github.com/apache/cloudstack/pull/8624#issuecomment-2074476474 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9389 -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] server: fix fail to list public ips of shared networks sometimes [cloudstack]

2024-04-24 Thread via GitHub
blueorangutan commented on PR #8624: URL: https://github.com/apache/cloudstack/pull/8624#issuecomment-2074227727 @weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make

Re: [PR] server: fix fail to list public ips of shared networks sometimes [cloudstack]

2024-04-24 Thread via GitHub
weizhouapache commented on PR #8624: URL: https://github.com/apache/cloudstack/pull/8624#issuecomment-2074224439 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] server: fix fail to list public ips of shared networks sometimes [cloudstack]

2024-04-10 Thread via GitHub
blueorangutan commented on PR #8624: URL: https://github.com/apache/cloudstack/pull/8624#issuecomment-2046983551 [SF] Trillian Build Failed (tid-9779) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] server: fix fail to list public ips of shared networks sometimes [cloudstack]

2024-04-10 Thread via GitHub
blueorangutan commented on PR #8624: URL: https://github.com/apache/cloudstack/pull/8624#issuecomment-2046921860 @weizhouapache a [SL] Trillian-Jenkins test job (rocky8 mgmt + kvm-rocky8) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To

Re: [PR] server: fix fail to list public ips of shared networks sometimes [cloudstack]

2024-04-10 Thread via GitHub
weizhouapache commented on PR #8624: URL: https://github.com/apache/cloudstack/pull/8624#issuecomment-2046919948 @blueorangutan test rocky8 kvm-rocky8 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] server: fix fail to list public ips of shared networks sometimes [cloudstack]

2024-04-10 Thread via GitHub
blueorangutan commented on PR #8624: URL: https://github.com/apache/cloudstack/pull/8624#issuecomment-2046869003 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9210 -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] server: fix fail to list public ips of shared networks sometimes [cloudstack]

2024-04-10 Thread via GitHub
blueorangutan commented on PR #8624: URL: https://github.com/apache/cloudstack/pull/8624#issuecomment-2046693041 @weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make

Re: [PR] server: fix fail to list public ips of shared networks sometimes [cloudstack]

2024-04-10 Thread via GitHub
weizhouapache commented on PR #8624: URL: https://github.com/apache/cloudstack/pull/8624#issuecomment-2046691042 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] server: fix fail to list public ips of shared networks sometimes [cloudstack]

2024-04-10 Thread via GitHub
weizhouapache commented on PR #8624: URL: https://github.com/apache/cloudstack/pull/8624#issuecomment-2046655539 > LGTM, tested manually, the ips are listed > > ![Screenshot 2024-04-10 at 11 29 16 

Re: [PR] server: fix fail to list public ips of shared networks sometimes [cloudstack]

2024-04-10 Thread via GitHub
weizhouapache commented on PR #8624: URL: https://github.com/apache/cloudstack/pull/8624#issuecomment-2046654793 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] server: fix fail to list public ips of shared networks sometimes [cloudstack]

2024-03-28 Thread via GitHub
blueorangutan commented on PR #8624: URL: https://github.com/apache/cloudstack/pull/8624#issuecomment-2026298737 [SF] Trillian test result (tid-9612) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 49629 seconds Marvin logs:

Re: [PR] server: fix fail to list public ips of shared networks sometimes [cloudstack]

2024-03-28 Thread via GitHub
blueorangutan commented on PR #8624: URL: https://github.com/apache/cloudstack/pull/8624#issuecomment-2024709948 @weizhouapache a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To

Re: [PR] server: fix fail to list public ips of shared networks sometimes [cloudstack]

2024-03-28 Thread via GitHub
weizhouapache commented on PR #8624: URL: https://github.com/apache/cloudstack/pull/8624#issuecomment-2024708599 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] server: fix fail to list public ips of shared networks sometimes [cloudstack]

2024-03-28 Thread via GitHub
blueorangutan commented on PR #8624: URL: https://github.com/apache/cloudstack/pull/8624#issuecomment-2024674610 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9071 -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] server: fix fail to list public ips of shared networks sometimes [cloudstack]

2024-03-28 Thread via GitHub
blueorangutan commented on PR #8624: URL: https://github.com/apache/cloudstack/pull/8624#issuecomment-2024583939 @weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make

Re: [PR] server: fix fail to list public ips of shared networks sometimes [cloudstack]

2024-03-28 Thread via GitHub
weizhouapache commented on PR #8624: URL: https://github.com/apache/cloudstack/pull/8624#issuecomment-2024582303 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] server: fix fail to list public ips of shared networks sometimes [cloudstack]

2024-03-15 Thread via GitHub
blueorangutan commented on PR #8624: URL: https://github.com/apache/cloudstack/pull/8624#issuecomment-169848 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8951 -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] server: fix fail to list public ips of shared networks sometimes [cloudstack]

2024-03-15 Thread via GitHub
blueorangutan commented on PR #8624: URL: https://github.com/apache/cloudstack/pull/8624#issuecomment-1999839666 @weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make

Re: [PR] server: fix fail to list public ips of shared networks sometimes [cloudstack]

2024-03-15 Thread via GitHub
weizhouapache commented on PR #8624: URL: https://github.com/apache/cloudstack/pull/8624#issuecomment-1999835065 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] server: fix fail to list public ips of shared networks sometimes [cloudstack]

2024-03-08 Thread via GitHub
blueorangutan commented on PR #8624: URL: https://github.com/apache/cloudstack/pull/8624#issuecomment-1986567492 [SF] Trillian test result (tid-9429) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 53035 seconds Marvin logs:

Re: [PR] server: fix fail to list public ips of shared networks sometimes [cloudstack]

2024-03-08 Thread via GitHub
blueorangutan commented on PR #8624: URL: https://github.com/apache/cloudstack/pull/8624#issuecomment-1985255225 @rohityadavcloud a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service.

Re: [PR] server: fix fail to list public ips of shared networks sometimes [cloudstack]

2024-03-08 Thread via GitHub
rohityadavcloud commented on PR #8624: URL: https://github.com/apache/cloudstack/pull/8624#issuecomment-1985252700 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] server: fix fail to list public ips of shared networks sometimes [cloudstack]

2024-02-13 Thread via GitHub
blueorangutan commented on PR #8624: URL: https://github.com/apache/cloudstack/pull/8624#issuecomment-1942124721 [SF] Trillian test result (tid-9185) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 43343 seconds Marvin logs:

Re: [PR] server: fix fail to list public ips of shared networks sometimes [cloudstack]

2024-02-12 Thread via GitHub
blueorangutan commented on PR #8624: URL: https://github.com/apache/cloudstack/pull/8624#issuecomment-1940461169 @rohityadavcloud a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service.

Re: [PR] server: fix fail to list public ips of shared networks sometimes [cloudstack]

2024-02-12 Thread via GitHub
rohityadavcloud commented on PR #8624: URL: https://github.com/apache/cloudstack/pull/8624#issuecomment-1940460183 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] server: fix fail to list public ips of shared networks sometimes [cloudstack]

2024-02-12 Thread via GitHub
blueorangutan commented on PR #8624: URL: https://github.com/apache/cloudstack/pull/8624#issuecomment-1938988655 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8633 -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] server: fix fail to list public ips of shared networks sometimes [cloudstack]

2024-02-12 Thread via GitHub
blueorangutan commented on PR #8624: URL: https://github.com/apache/cloudstack/pull/8624#issuecomment-1938841637 @weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make

Re: [PR] server: fix fail to list public ips of shared networks sometimes [cloudstack]

2024-02-12 Thread via GitHub
weizhouapache commented on PR #8624: URL: https://github.com/apache/cloudstack/pull/8624#issuecomment-1938838202 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] server: fix fail to list public ips of shared networks sometimes [cloudstack]

2024-02-12 Thread via GitHub
blueorangutan commented on PR #8624: URL: https://github.com/apache/cloudstack/pull/8624#issuecomment-1938817667 Packaging result [SF]: ✔️ el7 ✖️ el8 ✖️ el9 ✔️ debian ✖️ suse15. SL-JID 8631 -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] server: fix fail to list public ips of shared networks sometimes [cloudstack]

2024-02-12 Thread via GitHub
blueorangutan commented on PR #8624: URL: https://github.com/apache/cloudstack/pull/8624#issuecomment-1938713110 @weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make

Re: [PR] server: fix fail to list public ips of shared networks sometimes [cloudstack]

2024-02-12 Thread via GitHub
weizhouapache commented on PR #8624: URL: https://github.com/apache/cloudstack/pull/8624#issuecomment-1938709747 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] server: fix fail to list public ips of shared networks sometimes [cloudstack]

2024-02-09 Thread via GitHub
blueorangutan commented on PR #8624: URL: https://github.com/apache/cloudstack/pull/8624#issuecomment-1936378728 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8613 -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] server: fix fail to list public ips of shared networks sometimes [cloudstack]

2024-02-09 Thread via GitHub
blueorangutan commented on PR #8624: URL: https://github.com/apache/cloudstack/pull/8624#issuecomment-1936280329 @weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make

Re: [PR] server: fix fail to list public ips of shared networks sometimes [cloudstack]

2024-02-09 Thread via GitHub
weizhouapache commented on PR #8624: URL: https://github.com/apache/cloudstack/pull/8624#issuecomment-1936277370 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] server: fix fail to list public ips of shared networks sometimes [cloudstack]

2024-02-09 Thread via GitHub
weizhouapache commented on code in PR #8624: URL: https://github.com/apache/cloudstack/pull/8624#discussion_r1484584275 ## server/src/main/java/com/cloud/api/ApiResponseHelper.java: ## @@ -992,6 +992,9 @@ private void addSystemVmInfoToIpResponse(NicVO nic, IPAddressResponse

Re: [PR] server: fix fail to list public ips of shared networks sometimes [cloudstack]

2024-02-09 Thread via GitHub
weizhouapache commented on code in PR #8624: URL: https://github.com/apache/cloudstack/pull/8624#discussion_r1484582846 ## server/src/main/java/com/cloud/api/ApiResponseHelper.java: ## @@ -992,6 +992,9 @@ private void addSystemVmInfoToIpResponse(NicVO nic, IPAddressResponse

Re: [PR] server: fix fail to list public ips of shared networks sometimes [cloudstack]

2024-02-09 Thread via GitHub
blueorangutan commented on PR #8624: URL: https://github.com/apache/cloudstack/pull/8624#issuecomment-1936101696 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8612 -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] server: fix fail to list public ips of shared networks sometimes [cloudstack]

2024-02-09 Thread via GitHub
blueorangutan commented on PR #8624: URL: https://github.com/apache/cloudstack/pull/8624#issuecomment-1935999101 @DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make

Re: [PR] server: fix fail to list public ips of shared networks sometimes [cloudstack]

2024-02-09 Thread via GitHub
DaanHoogland commented on PR #8624: URL: https://github.com/apache/cloudstack/pull/8624#issuecomment-1935995927 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] server: fix fail to list public ips of shared networks sometimes [cloudstack]

2024-02-09 Thread via GitHub
DaanHoogland commented on code in PR #8624: URL: https://github.com/apache/cloudstack/pull/8624#discussion_r1484366052 ## server/src/main/java/com/cloud/api/ApiResponseHelper.java: ## @@ -992,6 +992,9 @@ private void addSystemVmInfoToIpResponse(NicVO nic, IPAddressResponse

Re: [PR] server: fix fail to list public ips of shared networks sometimes [cloudstack]

2024-02-07 Thread via GitHub
weizhouapache commented on code in PR #8624: URL: https://github.com/apache/cloudstack/pull/8624#discussion_r1481813890 ## server/src/main/java/com/cloud/api/ApiResponseHelper.java: ## @@ -992,6 +992,9 @@ private void addSystemVmInfoToIpResponse(NicVO nic, IPAddressResponse

Re: [PR] server: fix fail to list public ips of shared networks sometimes [cloudstack]

2024-02-07 Thread via GitHub
weizhouapache commented on code in PR #8624: URL: https://github.com/apache/cloudstack/pull/8624#discussion_r1481812367 ## server/src/main/java/com/cloud/api/ApiResponseHelper.java: ## @@ -992,6 +992,9 @@ private void addSystemVmInfoToIpResponse(NicVO nic, IPAddressResponse

Re: [PR] server: fix fail to list public ips of shared networks sometimes [cloudstack]

2024-02-07 Thread via GitHub
DaanHoogland commented on code in PR #8624: URL: https://github.com/apache/cloudstack/pull/8624#discussion_r1481806524 ## server/src/main/java/com/cloud/api/ApiResponseHelper.java: ## @@ -992,6 +992,9 @@ private void addSystemVmInfoToIpResponse(NicVO nic, IPAddressResponse

Re: [PR] server: fix fail to list public ips of shared networks sometimes [cloudstack]

2024-02-07 Thread via GitHub
weizhouapache commented on code in PR #8624: URL: https://github.com/apache/cloudstack/pull/8624#discussion_r1481787518 ## server/src/main/java/com/cloud/api/ApiResponseHelper.java: ## @@ -992,6 +992,9 @@ private void addSystemVmInfoToIpResponse(NicVO nic, IPAddressResponse

Re: [PR] server: fix fail to list public ips of shared networks sometimes [cloudstack]

2024-02-07 Thread via GitHub
DaanHoogland commented on code in PR #8624: URL: https://github.com/apache/cloudstack/pull/8624#discussion_r1481764751 ## server/src/main/java/com/cloud/api/ApiResponseHelper.java: ## @@ -992,6 +992,9 @@ private void addSystemVmInfoToIpResponse(NicVO nic, IPAddressResponse

Re: [PR] server: fix fail to list public ips of shared networks sometimes [cloudstack]

2024-02-07 Thread via GitHub
codecov[bot] commented on PR #8624: URL: https://github.com/apache/cloudstack/pull/8624#issuecomment-1932093115 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/8624?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report All