Re: [PR] zone wizard: allow only one untagged physical network with guest traffic type [cloudstack]

2024-02-20 Thread via GitHub
andrijapanicsb commented on PR #8625: URL: https://github.com/apache/cloudstack/pull/8625#issuecomment-1955115729 I don't know if the first part of the message comes from some work from before or not, but the wording is not the best. Trafic labels are completely optional and the wording is

Re: [PR] zone wizard: allow only one untagged physical network with guest traffic type [cloudstack]

2024-02-09 Thread via GitHub
DaanHoogland merged PR #8625: URL: https://github.com/apache/cloudstack/pull/8625 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] zone wizard: allow only one untagged physical network with guest traffic type [cloudstack]

2024-02-08 Thread via GitHub
weizhouapache commented on PR #8625: URL: https://github.com/apache/cloudstack/pull/8625#issuecomment-1933946690 > > @vishesh92 create two physical networks (both have Guest traffic) without tags ? > > I have added a validation forcing the user to add tags to physical networks. So,

Re: [PR] zone wizard: allow only one untagged physical network with guest traffic type [cloudstack]

2024-02-08 Thread via GitHub
vishesh92 commented on PR #8625: URL: https://github.com/apache/cloudstack/pull/8625#issuecomment-1933916502 > @vishesh92 create two physical networks (both have Guest traffic) without tags ? I have added a validation forcing the user to add tags to physical networks. So, can't

Re: [PR] zone wizard: allow only one untagged physical network with guest traffic type [cloudstack]

2024-02-08 Thread via GitHub
weizhouapache commented on PR #8625: URL: https://github.com/apache/cloudstack/pull/8625#issuecomment-1933796575 > > if the error happens, will the "Fix errors" button appear and go to the step (in the screenshot) if click the button ? > > I am not able to reproduce an issue in which

Re: [PR] zone wizard: allow only one untagged physical network with guest traffic type [cloudstack]

2024-02-08 Thread via GitHub
vishesh92 commented on PR #8625: URL: https://github.com/apache/cloudstack/pull/8625#issuecomment-1933778356 > if the error happens, will the "Fix errors" button appear and go to the step (in the screenshot) if click the button ? I am not able to reproduce an issue in which it has to

Re: [PR] zone wizard: allow only one untagged physical network with guest traffic type [cloudstack]

2024-02-08 Thread via GitHub
weizhouapache commented on PR #8625: URL: https://github.com/apache/cloudstack/pull/8625#issuecomment-1933730708 @vishesh92 screenshots looks good. if the error happens, will the "Fix errors" button appear and go to the step (in the screenshot) if click the button ? -- This is

Re: [PR] zone wizard: allow only one untagged physical network with guest traffic type [cloudstack]

2024-02-08 Thread via GitHub
weizhouapache commented on PR #8625: URL: https://github.com/apache/cloudstack/pull/8625#issuecomment-1933538753 > > > @vishesh92 can we add a new field in the wizard to specify the tag ? the API supports tags: https://cloudstack.apache.org/api/apidocs-4.19/apis/createPhysicalNetwork.html

Re: [PR] zone wizard: allow only one untagged physical network with guest traffic type [cloudstack]

2024-02-07 Thread via GitHub
weizhouapache commented on PR #8625: URL: https://github.com/apache/cloudstack/pull/8625#issuecomment-1933536938 > > @vishesh92 can we add a new field in the wizard to specify the tag ? the API supports tags:

Re: [PR] zone wizard: allow only one untagged physical network with guest traffic type [cloudstack]

2024-02-07 Thread via GitHub
vishesh92 commented on PR #8625: URL: https://github.com/apache/cloudstack/pull/8625#issuecomment-1933526855 > > @vishesh92 can we add a new field in the wizard to specify the tag ? the API supports tags: https://cloudstack.apache.org/api/apidocs-4.19/apis/createPhysicalNetwork.html >

Re: [PR] zone wizard: allow only one untagged physical network with guest traffic type [cloudstack]

2024-02-07 Thread via GitHub
vishesh92 commented on PR #8625: URL: https://github.com/apache/cloudstack/pull/8625#issuecomment-1933525868 > @vishesh92 can we add a new field in the wizard to specify the tag ? the API supports tags: https://cloudstack.apache.org/api/apidocs-4.19/apis/createPhysicalNetwork.html

Re: [PR] zone wizard: allow only one untagged physical network with guest traffic type [cloudstack]

2024-02-07 Thread via GitHub
weizhouapache commented on PR #8625: URL: https://github.com/apache/cloudstack/pull/8625#issuecomment-1933506696 @vishesh92 can we add a new field in the wizard to specify the tag ? the API supports tags: https://cloudstack.apache.org/api/apidocs-4.19/apis/createPhysicalNetwork.html

Re: [PR] zone wizard: allow only one untagged physical network with guest traffic type [cloudstack]

2024-02-07 Thread via GitHub
blueorangutan commented on PR #8625: URL: https://github.com/apache/cloudstack/pull/8625#issuecomment-1933437774 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8582 -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] zone wizard: allow only one untagged physical network with guest traffic type [cloudstack]

2024-02-07 Thread via GitHub
blueorangutan commented on PR #8625: URL: https://github.com/apache/cloudstack/pull/8625#issuecomment-1933389580 @vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Re: [PR] zone wizard: allow only one untagged physical network with guest traffic type [cloudstack]

2024-02-07 Thread via GitHub
vishesh92 commented on PR #8625: URL: https://github.com/apache/cloudstack/pull/8625#issuecomment-1933388183 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific