[GitHub] rhtyd commented on issue #2028: CLOUDSTACK-9853: Add support for Secondary IPv6 Addresses and Subnets

[git]

rhtyd commented on issue #2028: CLOUDSTACK-9853: Add support for Secondary IPv6 
Addresses and Subnets
URL: https://github.com/apache/cloudstack/pull/2028#issuecomment-321554248
 
 
   @wido looks like the test run job failed, I'll rekick
   @blueorangutan package
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2028: CLOUDSTACK-9853: Add support for Secondary IPv6 Addresses and Subnets

[git]

blueorangutan commented on issue #2028: CLOUDSTACK-9853: Add support for 
Secondary IPv6 Addresses and Subnets
URL: https://github.com/apache/cloudstack/pull/2028#issuecomment-321560926
 
 
   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been 
kicked to run smoke tests
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2236: CLOUDSTACK-10044: Update role permission

[git]

rhtyd commented on issue #2236: CLOUDSTACK-10044: Update role permission
URL: https://github.com/apache/cloudstack/pull/2236#issuecomment-321568893
 
 
   @blueorangutan hi
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] nvazquez commented on issue #2236: CLOUDSTACK-10044: Update role permission

[git]

nvazquez commented on issue #2236: CLOUDSTACK-10044: Update role permission
URL: https://github.com/apache/cloudstack/pull/2236#issuecomment-321568954
 
 
   @blueorangutan hi
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wido commented on issue #2170: Corrected Apache Git URL, was git-wip-us

[git]

wido commented on issue #2170: Corrected Apache Git URL, was git-wip-us
URL: https://github.com/apache/cloudstack/pull/2170#issuecomment-321586753
 
 
   Could you fix the URL as it's not the right one?
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wido commented on issue #2074: CLOUDSTACK-9899 Url validation disabling

[git]

wido commented on issue #2074: CLOUDSTACK-9899 Url validation disabling
URL: https://github.com/apache/cloudstack/pull/2074#issuecomment-321590631
 
 
   Could you take a look at @rhtyd his comment @DaanHoogland ? We can then give 
this one a LGTM
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on a change in pull request #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9

[git]

rhtyd commented on a change in pull request #2211: CLOUDSTACK-10013: Migrate 
systemvmtemplate to Debian9
URL: https://github.com/apache/cloudstack/pull/2211#discussion_r132454476
 
 

 ##
 File path: 
tools/appliance/definitions/systemvmtemplate/configure_systemvm_services.sh
 ##
 @@ -107,8 +107,8 @@ EOF
 
   systemctl daemon-reload
   systemctl enable cloud-early-config
-  systemctl disable cloud-passwd-srvr
-  systemctl disable cloud
+  systemctl enable cloud-passwd-srvr
+  systemctl enable cloud
 
 Review comment:
   @wido We may not want to enable the services by default, but only through 
cloud-early-config's patching?
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2236: CLOUDSTACK-10044: Update role permission

[git]

blueorangutan commented on issue #2236: CLOUDSTACK-10044: Update role permission
URL: https://github.com/apache/cloudstack/pull/2236#issuecomment-321574448
 
 
   Packaging result: ?centos6 ?centos7 ?debian. JID-946
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #1593: CLOUDSTACK-9417: Usage module refactoring

[git]

blueorangutan commented on issue #1593: CLOUDSTACK-9417: Usage module 
refactoring
URL: https://github.com/apache/cloudstack/pull/1593#issuecomment-321576388
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #1593: CLOUDSTACK-9417: Usage module refactoring

[git]

rhtyd commented on issue #1593: CLOUDSTACK-9417: Usage module refactoring
URL: https://github.com/apache/cloudstack/pull/1593#issuecomment-321576170
 
 
   @blueorangutan package
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wido commented on issue #2214: Speed-up VR initialisation/configuration

[git]

wido commented on issue #2214: Speed-up VR initialisation/configuration
URL: https://github.com/apache/cloudstack/pull/2214#issuecomment-321585865
 
 
   This will conflict with #2211, how do we address that?
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wido commented on issue #2097: [4.11] CLOUDSTACK-9813: Extending Config Drive support

[git]

wido commented on issue #2097: [4.11] CLOUDSTACK-9813: Extending Config Drive 
support
URL: https://github.com/apache/cloudstack/pull/2097#issuecomment-321588959
 
 
   There are merge conflicts with this PR. Would be great to get it in, could 
you take a look at them?
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2223: CLOUDSTACK-10031: change default configuration for router.aggregation?

[git]

rhtyd commented on issue #2223: CLOUDSTACK-10031: change default configuration 
for router.aggregation?
URL: https://github.com/apache/cloudstack/pull/2223#issuecomment-321589139
 
 
   LGTM.
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wido commented on issue #2068: systemvm: fix pep8 errors

[git]

wido commented on issue #2068: systemvm: fix pep8 errors
URL: https://github.com/apache/cloudstack/pull/2068#issuecomment-321590853
 
 
   Merge conflicts :(
   
   Otherwise a LGTM from me, but can you fix these?
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wido commented on a change in pull request #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9

[git]

wido commented on a change in pull request #2211: CLOUDSTACK-10013: Migrate 
systemvmtemplate to Debian9
URL: https://github.com/apache/cloudstack/pull/2211#discussion_r132473212
 
 

 ##
 File path: 
utils/src/main/java/org/apache/cloudstack/utils/imagestore/ImageStoreUtil.java
 ##
 @@ -81,7 +81,7 @@ public static String checkTemplateFormat(String path, String 
uripath) {
 return "";
 }
 
-if (output.contains("ISO 9660") && isCorrectExtension(uripath, "iso")) 
{
+if ((output.startsWith("ISO 9660") || output.startsWith("DOS/MBR")) && 
isCorrectExtension(uripath, "iso")) {
 
 Review comment:
   Well, the *file* command simply behaves differently under Debian 9 then it 
does under Debian 7.
   
   See my commit for this change.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wido commented on issue #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9

[git]

wido commented on issue #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to 
Debian9
URL: https://github.com/apache/cloudstack/pull/2211#issuecomment-321583527
 
 
   Yes, I saw them. I pushed a commit again.
   
   It's kind of confusing how we provision the SSVM with all the Bash script 
everywhere... Wow
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2028: CLOUDSTACK-9853: Add support for Secondary IPv6 Addresses and Subnets

[git]

rhtyd commented on issue #2028: CLOUDSTACK-9853: Add support for Secondary IPv6 
Addresses and Subnets
URL: https://github.com/apache/cloudstack/pull/2028#issuecomment-321560752
 
 
   @blueorangutan test
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2028: CLOUDSTACK-9853: Add support for Secondary IPv6 Addresses and Subnets

[git]

blueorangutan commented on issue #2028: CLOUDSTACK-9853: Add support for 
Secondary IPv6 Addresses and Subnets
URL: https://github.com/apache/cloudstack/pull/2028#issuecomment-321560495
 
 
   Packaging result: ?centos6 ?centos7 ?debian. JID-945
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on a change in pull request #2236: CLOUDSTACK-10044: Update role permission

[git]

rhtyd commented on a change in pull request #2236: CLOUDSTACK-10044: Update 
role permission
URL: https://github.com/apache/cloudstack/pull/2236#discussion_r132470387
 
 

 ##
 File path: 
api/src/org/apache/cloudstack/api/command/admin/acl/UpdateRolePermissionCmd.java
 ##
 @@ -51,10 +52,16 @@
 description = "ID of the role", validations = 
{ApiArgValidator.PositiveNumber})
 private Long roleId;
 
-@Parameter(name = ApiConstants.RULE_ORDER, type = CommandType.LIST, 
collectionType = CommandType.UUID, required = true, entityType = 
RolePermissionResponse.class,
+@Parameter(name = ApiConstants.RULE_ORDER, type = CommandType.LIST, 
collectionType = CommandType.UUID, entityType = RolePermissionResponse.class,
 description = "The parent role permission uuid, use 0 to move this 
rule at the top of the list")
 private List rulePermissionOrder;
 
+@Parameter(name = ApiConstants.RULE_ID, type = CommandType.UUID, 
entityType = RolePermissionResponse.class, description = "Role permission rule 
id")
+private Long ruleId;
+
+@Parameter(name = ApiConstants.PERMISSION, type = CommandType.STRING, 
description = "Rule permission, can be: allow or deny")
 
 Review comment:
   @nvazquez please add a `since` to 4.11 here as well
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on a change in pull request #2236: CLOUDSTACK-10044: Update role permission

[git]

rhtyd commented on a change in pull request #2236: CLOUDSTACK-10044: Update 
role permission
URL: https://github.com/apache/cloudstack/pull/2236#discussion_r132470327
 
 

 ##
 File path: 
api/src/org/apache/cloudstack/api/command/admin/acl/UpdateRolePermissionCmd.java
 ##
 @@ -51,10 +52,16 @@
 description = "ID of the role", validations = 
{ApiArgValidator.PositiveNumber})
 private Long roleId;
 
-@Parameter(name = ApiConstants.RULE_ORDER, type = CommandType.LIST, 
collectionType = CommandType.UUID, required = true, entityType = 
RolePermissionResponse.class,
+@Parameter(name = ApiConstants.RULE_ORDER, type = CommandType.LIST, 
collectionType = CommandType.UUID, entityType = RolePermissionResponse.class,
 description = "The parent role permission uuid, use 0 to move this 
rule at the top of the list")
 private List rulePermissionOrder;
 
+@Parameter(name = ApiConstants.RULE_ID, type = CommandType.UUID, 
entityType = RolePermissionResponse.class, description = "Role permission rule 
id")
 
 Review comment:
   @nvazquez This is a new arg, can you add a since field to say '4.11'?
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wido commented on issue #2140: CLOUDSTACK-9951: Add support for batch/bulk VM deployment option in CS

[git]

wido commented on issue #2140: CLOUDSTACK-9951: Add support for batch/bulk VM 
deployment option in CS
URL: https://github.com/apache/cloudstack/pull/2140#issuecomment-321588264
 
 
   Could you check the conflict @koushik-das ?
   
   Awesome feature though!
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wido commented on a change in pull request #2109: CLOUDSTACK-9922 Unable to use 8081 port for Load balancing

[git]

wido commented on a change in pull request #2109: CLOUDSTACK-9922 Unable to use 
8081 port for Load balancing
URL: https://github.com/apache/cloudstack/pull/2109#discussion_r132490211
 
 

 ##
 File path: server/src/com/cloud/configuration/ConfigurationManagerImpl.java
 ##
 @@ -2054,7 +2054,7 @@ public ServiceOffering createServiceOffering(final 
CreateServiceOfferingCmd cmd)
 if(!allowNetworkRate) {
 throw new InvalidParameterValueException("Network rate can be 
specified only for non-System offering and system offerings having 
\"domainrouter\" systemvmtype");
 }
-if(cmd.getNetworkRate().intValue() < 1) {
+if(cmd.getNetworkRate().intValue() < 0) {
 throw new InvalidParameterValueException("Failed to create 
service offering " + name + ": specify the network rate value more than 0");
 
 Review comment:
   The error message below says something different then the if statement
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[cloudstack] branch debian9-systemvmtemplate updated: Disable most services by default and enable in cloud-early-config

[widodh]

This is an automated email from the ASF dual-hosted git repository.

widodh pushed a commit to branch debian9-systemvmtemplate
in repository https://gitbox.apache.org/repos/asf/cloudstack.git


The following commit(s) were added to refs/heads/debian9-systemvmtemplate by 
this push:
 new d333603  Disable most services by default and enable in 
cloud-early-config
d333603 is described below

commit d3336030b9d727117058acc2d4f4d66d747d0e96
Author: Wido den Hollander 
AuthorDate: Thu Aug 10 16:40:22 2017 +0200

Disable most services by default and enable in cloud-early-config

Not sure though if enabling them is enough for systemd to still start them
on first boot

Signed-off-by: Wido den Hollander 
---
 .../debian/config/etc/init.d/cloud-early-config| 35 +-
 .../configure_systemvm_services.sh |  6 ++--
 2 files changed, 11 insertions(+), 30 deletions(-)

diff --git a/systemvm/patches/debian/config/etc/init.d/cloud-early-config 
b/systemvm/patches/debian/config/etc/init.d/cloud-early-config
index 1d3a890..655266c 100755
--- a/systemvm/patches/debian/config/etc/init.d/cloud-early-config
+++ b/systemvm/patches/debian/config/etc/init.d/cloud-early-config
@@ -935,11 +935,8 @@ setup_router() {
   echo "$ETH0_IP $NAME" >> /etc/hosts
 
 
-  enable_svc dnsmasq 1
-  enable_svc haproxy 1
+  systemctl enable dnsmasq haproxy cloud-passwd-srvr
   enable_irqbalance 1
-  enable_svc cloud-passwd-srvr 1
-  enable_svc cloud 0
   disable_rpfilter_domR
   enable_fwding 1
   enable_rpsrfs 1
@@ -1028,12 +1025,9 @@ EOF
 
   setup_vpc_apache2
 
-  enable_svc dnsmasq 1
-  enable_svc haproxy 1
+  systemctl enable dnsmasq haproxy cloud-passwd-srvr
   enable_irqbalance 1
   enable_vpc_rpsrfs 1
-  enable_svc cloud 0
-  enable_svc cloud-passwd-srvr 1
   disable_rpfilter
   enable_fwding 1
   cp /etc/iptables/iptables-vpcrouter /etc/iptables/rules.v4
@@ -1078,11 +1072,8 @@ setup_dhcpsrvr() {
   [ $ETH0_IP ] && echo "$ETH0_IP $NAME" >> /etc/hosts
   [ $ETH0_IP6 ] && echo "$ETH0_IP6 $NAME" >> /etc/hosts
 
-  enable_svc dnsmasq 1
-  enable_svc haproxy 0
+  systemctl enable dnsmasq cloud-passwd-srvr
   enable_irqbalance 0
-  enable_svc cloud-passwd-srvr 1
-  enable_svc cloud 0
   enable_fwding 0
   systemctl disable nfs-common
 
@@ -1208,11 +1199,9 @@ CORS
 
   disable_rpfilter
   enable_fwding 0
-  enable_svc haproxy 0
+  systemctl disable haproxy dnsmasq cloud-passwd-srvr
+  systemctl enable cloud
   enable_irqbalance 0
-  enable_svc dnsmasq 0
-  enable_svc cloud-passwd-srvr 0
-  enable_svc cloud 1
   rm /etc/logrotate.d/cloud
   setup_ntp
 }
@@ -1233,13 +1222,10 @@ setup_console_proxy() {
 setup_sshd $ETH0_IP "eth0"
   fi
 
+  systemctl enable cloud
   disable_rpfilter
   enable_fwding 0
-  enable_svc haproxy 0
   enable_irqbalance 0
-  enable_svc dnsmasq 0
-  enable_svc cloud-passwd-srvr 0
-  enable_svc cloud 1
   systemctl disable nfs-common
   rm /etc/logrotate.d/cloud
 }
@@ -1263,11 +1249,7 @@ setup_elbvm() {
   fi
   
   enable_fwding 0
-  enable_svc haproxy 0
   enable_irqbalance 0
-  enable_svc dnsmasq 0
-  enable_svc cloud-passwd-srvr 0
-  enable_svc cloud 0
   systemctl disable nfs-common
   systemctl disable portmap
 }
@@ -1286,11 +1268,8 @@ setup_ilbvm() {
   setup_sshd $ETH1_IP "eth1"
   
   enable_fwding 0
-  enable_svc haproxy 1
+  systemctl enable haproxy
   enable_irqbalance 1
-  enable_svc dnsmasq 0
-  enable_svc cloud-passwd-srvr 0
-  enable_svc cloud 0
   systemctl disable nfs-common
   systemctl disable portmap
 }
diff --git 
a/tools/appliance/definitions/systemvmtemplate/configure_systemvm_services.sh 
b/tools/appliance/definitions/systemvmtemplate/configure_systemvm_services.sh
index 171c4b0..1386465 100644
--- 
a/tools/appliance/definitions/systemvmtemplate/configure_systemvm_services.sh
+++ 
b/tools/appliance/definitions/systemvmtemplate/configure_systemvm_services.sh
@@ -107,8 +107,8 @@ EOF
 
   systemctl daemon-reload
   systemctl enable cloud-early-config
-  systemctl enable cloud-passwd-srvr
-  systemctl enable cloud
+  systemctl disable cloud-passwd-srvr
+  systemctl disable cloud
 }
 
 function do_signature() {
@@ -143,6 +143,8 @@ function configure_services() {
   systemctl disable x11-common
   systemctl disable console-setup
   systemctl disable haproxy
+  systemctl disable apache2
+  systemctl disable dnsmasq
 
   # Hyperv kvp daemon - 64bit only
   local arch=`dpkg --print-architecture`

-- 
To stop receiving notification emails like this one, please contact
['"commits@cloudstack.apache.org" '].

[GitHub] blueorangutan commented on issue #2190: CLOUDSTACK-10010: Fixed the negotiation of S2S VPN connections

[git]

blueorangutan commented on issue #2190: CLOUDSTACK-10010: Fixed the negotiation 
of S2S VPN connections
URL: https://github.com/apache/cloudstack/pull/2190#issuecomment-321554466
 
 
   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been 
kicked to run smoke tests
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2028: CLOUDSTACK-9853: Add support for Secondary IPv6 Addresses and Subnets

[git]

blueorangutan commented on issue #2028: CLOUDSTACK-9853: Add support for 
Secondary IPv6 Addresses and Subnets
URL: https://github.com/apache/cloudstack/pull/2028#issuecomment-321554476
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2190: CLOUDSTACK-10010: Fixed the negotiation of S2S VPN connections

[git]

rhtyd commented on issue #2190: CLOUDSTACK-10010: Fixed the negotiation of S2S 
VPN connections
URL: https://github.com/apache/cloudstack/pull/2190#issuecomment-321554328
 
 
   @blueorangutan test
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2236: CLOUDSTACK-10044: Update role permission

[git]

blueorangutan commented on issue #2236: CLOUDSTACK-10044: Update role permission
URL: https://github.com/apache/cloudstack/pull/2236#issuecomment-321567618
 
 
   @borisstoyanov a Jenkins job has been kicked to build packages. I'll keep 
you posted as I make progress.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #1593: CLOUDSTACK-9417: Usage module refactoring

[git]

blueorangutan commented on issue #1593: CLOUDSTACK-9417: Usage module 
refactoring
URL: https://github.com/apache/cloudstack/pull/1593#issuecomment-321584726
 
 
   Packaging result: ?centos6 ?centos7 ?debian. JID-947
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wido commented on issue #2223: CLOUDSTACK-10031: change default configuration for router.aggregation?

[git]

wido commented on issue #2223: CLOUDSTACK-10031: change default configuration 
for router.aggregation?
URL: https://github.com/apache/cloudstack/pull/2223#issuecomment-321586211
 
 
   LGTM
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] borisstoyanov commented on issue #2236: CLOUDSTACK-10044: Update role permission

[git]

borisstoyanov commented on issue #2236: CLOUDSTACK-10044: Update role permission
URL: https://github.com/apache/cloudstack/pull/2236#issuecomment-321586278
 
 
   @blueorangutan test
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9

[git]

rhtyd commented on issue #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to 
Debian9
URL: https://github.com/apache/cloudstack/pull/2211#issuecomment-321553952
 
 
   Thanks @wido for fixing them :) I've left few comments, I can test this 
weekend, or early next week
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on a change in pull request #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9

[git]

rhtyd commented on a change in pull request #2211: CLOUDSTACK-10013: Migrate 
systemvmtemplate to Debian9
URL: https://github.com/apache/cloudstack/pull/2211#discussion_r132454805
 
 

 ##
 File path: 
utils/src/main/java/org/apache/cloudstack/utils/imagestore/ImageStoreUtil.java
 ##
 @@ -81,7 +81,7 @@ public static String checkTemplateFormat(String path, String 
uripath) {
 return "";
 }
 
-if (output.contains("ISO 9660") && isCorrectExtension(uripath, "iso")) 
{
+if ((output.startsWith("ISO 9660") || output.startsWith("DOS/MBR")) && 
isCorrectExtension(uripath, "iso")) {
 
 Review comment:
   We might need to revisit this, this should not happen. 
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2236: CLOUDSTACK-10044: Update role permission

[git]

blueorangutan commented on issue #2236: CLOUDSTACK-10044: Update role permission
URL: https://github.com/apache/cloudstack/pull/2236#issuecomment-321569238
 
 
   hello @nvazquez
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] nvazquez commented on issue #1593: CLOUDSTACK-9417: Usage module refactoring

[git]

nvazquez commented on issue #1593: CLOUDSTACK-9417: Usage module refactoring
URL: https://github.com/apache/cloudstack/pull/1593#issuecomment-321569315
 
 
   @blueorangutan hi
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2236: CLOUDSTACK-10044: Update role permission

[git]

rhtyd commented on issue #2236: CLOUDSTACK-10044: Update role permission
URL: https://github.com/apache/cloudstack/pull/2236#issuecomment-321568893
 
 
   @blueorangutan hi
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] nvazquez commented on issue #2236: CLOUDSTACK-10044: Update role permission

[git]

nvazquez commented on issue #2236: CLOUDSTACK-10044: Update role permission
URL: https://github.com/apache/cloudstack/pull/2236#issuecomment-321567364
 
 
   @blueorangutan hi
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2236: CLOUDSTACK-10044: Update role permission

[git]

blueorangutan commented on issue #2236: CLOUDSTACK-10044: Update role permission
URL: https://github.com/apache/cloudstack/pull/2236#issuecomment-321568929
 
 
   hello @rhtyd
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2236: CLOUDSTACK-10044: Update role permission

[git]

blueorangutan commented on issue #2236: CLOUDSTACK-10044: Update role permission
URL: https://github.com/apache/cloudstack/pull/2236#issuecomment-321569238
 
 
   hello @nvazquez
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] nvazquez commented on issue #2236: CLOUDSTACK-10044: Update role permission

[git]

nvazquez commented on issue #2236: CLOUDSTACK-10044: Update role permission
URL: https://github.com/apache/cloudstack/pull/2236#issuecomment-321577241
 
 
   @blueorangutan package
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2236: CLOUDSTACK-10044: Update role permission

[git]

blueorangutan commented on issue #2236: CLOUDSTACK-10044: Update role permission
URL: https://github.com/apache/cloudstack/pull/2236#issuecomment-321585691
 
 
   Packaging result: ?centos6 ?centos7 ?debian. JID-948
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wido commented on issue #2222: CLOUDSTACK-10022: Allow domain admin to create and delete subdomains

[git]

wido commented on issue #: CLOUDSTACK-10022: Allow domain admin to create 
and delete subdomains
URL: https://github.com/apache/cloudstack/pull/#issuecomment-321585354
 
 
   "the domain admin cannot delete its own domain."
   
   Where is that done? The Java code doesn't allow that?
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2229: CLOUDSTACK-8945: Enable rp_filter for non-public VPC VR interfaces

[git]

blueorangutan commented on issue #2229: CLOUDSTACK-8945: Enable rp_filter for 
non-public VPC VR interfaces
URL: https://github.com/apache/cloudstack/pull/2229#issuecomment-321461094
 
 
   Trillian test result (tid-1346)
   Environment: xenserver-65sp1 (x2), Advanced Networking with Mgmt server 6
   Total time taken: 43251 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2229-t1346-xenserver-65sp1.zip
   Intermitten failure detected: /marvin/tests/smoke/test_network.py
   Intermitten failure detected: /marvin/tests/smoke/test_nic.py
   Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
   Intermitten failure detected: /marvin/tests/smoke/test_routers_network_ops.py
   Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Intermitten failure detected: /marvin/tests/smoke/test_vpc_vpn.py
   Test completed. 48 look OK, 6 have error(s)
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_05_rvpc_multi_tiers | `Failure` | 438.67 | test_vpc_redundant.py
   test_04_rvpc_network_garbage_collector_nics | `Failure` | 1331.02 | 
test_vpc_redundant.py
   test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 446.80 | 
test_vpc_redundant.py
   test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | `Failure` | 
402.32 | test_routers_network_ops.py
   test_04_rvpc_privategw_static_routes | `Failure` | 603.73 | 
test_privategw_acl.py
   ContextSuite context=TestRVPCSite2SiteVpn>:setup | `Error` | 0.00 | 
test_vpc_vpn.py
   test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | 
`Error` | 407.81 | test_vpc_redundant.py
   test_03_vpc_privategw_restart_vpc_cleanup | `Error` | 482.07 | 
test_privategw_acl.py
   test_01_nic | `Error` | 304.01 | test_nic.py
   test_reboot_router | `Error` | 419.25 | test_network.py
   test_09_copy_delete_template | Skipped | 0.03 | test_templates.py
   test_06_copy_template | Skipped | 0.00 | test_templates.py
   test_static_role_account_acls | Skipped | 0.02 | test_staticroles.py
   test_vm_nic_adapter_vmxnet3 | Skipped | 0.00 | test_nic_adapter_type.py
   test_06_copy_iso | Skipped | 0.00 | test_iso.py
   test_deploy_vgpu_enabled_vm | Skipped | 0.00 | test_deploy_vgpu_enabled_vm.py
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] DaanHoogland opened a new pull request #2235: repo has moved

[git]

DaanHoogland opened a new pull request #2235: repo has moved
URL: https://github.com/apache/cloudstack/pull/2235
 
 
from git-wip-us to gitbox
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[cloudstack] branch new-location created (now 7d97a07)

[dahn]

This is an automated email from the ASF dual-hosted git repository.

dahn pushed a change to branch new-location
in repository https://gitbox.apache.org/repos/asf/cloudstack.git.


  at 7d97a07  repo has moved

This branch includes the following new commits:

 new 7d97a07  repo has moved

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


-- 
To stop receiving notification emails like this one, please contact
['"commits@cloudstack.apache.org" '].

[GitHub] blueorangutan commented on issue #2229: CLOUDSTACK-8945: Enable rp_filter for non-public VPC VR interfaces

[git]

blueorangutan commented on issue #2229: CLOUDSTACK-8945: Enable rp_filter for 
non-public VPC VR interfaces
URL: https://github.com/apache/cloudstack/pull/2229#issuecomment-321471540
 
 
   Trillian test result (tid-1349)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 33838 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2229-t1349-kvm-centos7.zip
   Intermitten failure detected: 
/marvin/tests/smoke/test_affinity_groups_projects.py
   Intermitten failure detected: /marvin/tests/smoke/test_loadbalance.py
   Intermitten failure detected: /marvin/tests/smoke/test_nic.py
   Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
   Test completed. 51 look OK, 3 have error(s)
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_04_rvpc_privategw_static_routes | `Failure` | 426.74 | 
test_privategw_acl.py
   test_01_nic | `Error` | 172.83 | test_nic.py
   test_DeployVmAntiAffinityGroup_in_project | `Error` | 91.32 | 
test_affinity_groups_projects.py
   test_03_delete_vm_snapshots | Skipped | 0.00 | test_vm_snapshots.py
   test_02_revert_vm_snapshots | Skipped | 0.00 | test_vm_snapshots.py
   test_01_create_vm_snapshots | Skipped | 0.00 | test_vm_snapshots.py
   test_09_copy_delete_template | Skipped | 0.02 | test_templates.py
   test_06_copy_template | Skipped | 0.00 | test_templates.py
   test_static_role_account_acls | Skipped | 0.02 | test_staticroles.py
   test_01_scale_vm | Skipped | 0.00 | test_scale_vm.py
   test_01_primary_storage_iscsi | Skipped | 0.04 | test_primary_storage.py
   test_vm_nic_adapter_vmxnet3 | Skipped | 0.00 | test_nic_adapter_type.py
   test_06_copy_iso | Skipped | 0.00 | test_iso.py
   test_deploy_vgpu_enabled_vm | Skipped | 0.01 | test_deploy_vgpu_enabled_vm.py
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[cloudstack] 01/01: repo has moved

[dahn]

This is an automated email from the ASF dual-hosted git repository.

dahn pushed a commit to branch new-location
in repository https://gitbox.apache.org/repos/asf/cloudstack.git

commit 7d97a073334c256a38a2916a9535866532030d45
Author: dahn 
AuthorDate: Thu Aug 10 09:16:52 2017 +0200

repo has moved

 from git-wip-us to gitbox
---
 tools/cli/README | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/cli/README b/tools/cli/README
index f8bfebe..0508d0b 100644
--- a/tools/cli/README
+++ b/tools/cli/README
@@ -1 +1 @@
-Moved to https://git-wip-us.apache.org/repos/asf?p=cloudstack-cloudmonkey.git
+Moved to https://gitbox.apache.org/repos/asf?p=cloudstack-cloudmonkey.git

-- 
To stop receiving notification emails like this one, please contact
"commits@cloudstack.apache.org" .

[GitHub] blueorangutan commented on issue #2224: CLOUDSTACK-10032 : Database entries for templates created from snapshots disappear after management-server service restart

[git]

blueorangutan commented on issue #2224: CLOUDSTACK-10032 : Database entries for 
templates created from snapshots disappear after management-server service 
restart
URL: https://github.com/apache/cloudstack/pull/2224#issuecomment-321501738
 
 
   Trillian test result (tid-1351)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 37515 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2224-t1351-kvm-centos7.zip
   Intermitten failure detected: /marvin/tests/smoke/test_network.py
   Intermitten failure detected: /marvin/tests/smoke/test_nic.py
   Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
   Intermitten failure detected: /marvin/tests/smoke/test_routers.py
   Intermitten failure detected: /marvin/tests/smoke/test_templates.py
   Intermitten failure detected: /marvin/tests/smoke/test_vpc_router_nics.py
   Test completed. 51 look OK, 6 have error(s)
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_01_VPC_nics_after_destroy | `Failure` | 378.14 | test_vpc_router_nics.py
   test_06_router_advanced | `Failure` | 0.02 | test_routers.py
   test_05_router_basic | `Failure` | 0.03 | test_routers.py
   test_04_rvpc_privategw_static_routes | `Failure` | 391.25 | 
test_privategw_acl.py
   test_04_extract_template | `Error` | 5.10 | test_templates.py
   test_03_delete_template | `Error` | 5.08 | test_templates.py
   test_01_create_template | `Error` | 50.49 | test_templates.py
   test_09_reboot_router | `Error` | 5.11 | test_routers.py
   test_08_start_router | `Error` | 45.41 | test_routers.py
   test_04_restart_network_wo_cleanup | `Error` | 40.37 | test_routers.py
   test_03_restart_network_cleanup | `Error` | 65.53 | test_routers.py
   test_03_vpc_privategw_restart_vpc_cleanup | `Error` | 320.17 | 
test_privategw_acl.py
   test_01_nic | `Error` | 167.41 | test_nic.py
   test_reboot_router | `Error` | 257.56 | test_network.py
   test_change_service_offering_for_vm_with_snapshots | Skipped | 0.00 | 
test_vm_snapshots.py
   test_09_copy_delete_template | Skipped | 0.02 | test_templates.py
   test_06_copy_template | Skipped | 0.00 | test_templates.py
   test_static_role_account_acls | Skipped | 0.05 | test_staticroles.py
   test_11_ss_nfs_version_on_ssvm | Skipped | 0.02 | test_ssvm.py
   test_01_scale_vm | Skipped | 0.00 | test_scale_vm.py
   test_01_primary_storage_iscsi | Skipped | 0.04 | test_primary_storage.py
   test_vm_nic_adapter_vmxnet3 | Skipped | 0.00 | test_nic_adapter_type.py
   test_nested_virtualization_vmware | Skipped | 0.00 | 
test_nested_virtualization.py
   test_06_copy_iso | Skipped | 0.00 | test_iso.py
   test_deploy_vgpu_enabled_vm | Skipped | 0.03 | test_deploy_vgpu_enabled_vm.py
   test_3d_gpu_support | Skipped | 0.04 | test_deploy_vgpu_enabled_vm.py
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] DaanHoogland commented on issue #2083: Iptables speedup

[git]

DaanHoogland commented on issue #2083: Iptables speedup
URL: https://github.com/apache/cloudstack/pull/2083#issuecomment-321472077
 
 
   I have no idea nor time to look at those errors. we'll have to rebase and 
target this for master
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wido commented on issue #2231: [CLOUDSTACK-10039] Adding IOPS/GB offering

[git]

wido commented on issue #2231: [CLOUDSTACK-10039] Adding IOPS/GB offering
URL: https://github.com/apache/cloudstack/pull/2231#issuecomment-321503549
 
 
   Could you resolve the conflict @syed ?
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wido commented on issue #2235: repo has moved

[git]

wido commented on issue #2235: repo has moved
URL: https://github.com/apache/cloudstack/pull/2235#issuecomment-321503436
 
 
   LGTM
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wido commented on issue #2028: CLOUDSTACK-9853: Add support for Secondary IPv6 Addresses and Subnets

[git]

wido commented on issue #2028: CLOUDSTACK-9853: Add support for Secondary IPv6 
Addresses and Subnets
URL: https://github.com/apache/cloudstack/pull/2028#issuecomment-321547431
 
 
   Is this one now ready to merge?
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2236: CLOUDSTACK-10044: Update role permission

[git]

blueorangutan commented on issue #2236: CLOUDSTACK-10044: Update role permission
URL: https://github.com/apache/cloudstack/pull/2236#issuecomment-321569249
 
 
   hello @nvazquez
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2236: CLOUDSTACK-10044: Update role permission

[git]

blueorangutan commented on issue #2236: CLOUDSTACK-10044: Update role permission
URL: https://github.com/apache/cloudstack/pull/2236#issuecomment-321568929
 
 
   hello @rhtyd
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] nvazquez commented on issue #2236: CLOUDSTACK-10044: Update role permission

[git]

nvazquez commented on issue #2236: CLOUDSTACK-10044: Update role permission
URL: https://github.com/apache/cloudstack/pull/2236#issuecomment-321576097
 
 
   Pushed changes @rhtyd. Thanks @borisstoyanov and @rhtyd. 
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wido commented on issue #2223: CLOUDSTACK-10031: change default configuration for router.aggregation?

[git]

wido commented on issue #2223: CLOUDSTACK-10031: change default configuration 
for router.aggregation?
URL: https://github.com/apache/cloudstack/pull/2223#issuecomment-321586211
 
 
   LGTM
   
   Based on the fact that this hurt me in production as well
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2236: CLOUDSTACK-10044: Update role permission

[git]

blueorangutan commented on issue #2236: CLOUDSTACK-10044: Update role permission
URL: https://github.com/apache/cloudstack/pull/2236#issuecomment-321586442
 
 
   @borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has 
been kicked to run smoke tests
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wido commented on issue #2088: CLOUDSTACK-9892: Primary storage resource check is broken when using ?

[git]

wido commented on issue #2088: CLOUDSTACK-9892: Primary storage resource check 
is broken when using ?
URL: https://github.com/apache/cloudstack/pull/2088#issuecomment-321590072
 
 
   Could you look at the merge conflict?
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wido commented on issue #2101: CLOUDSTACK-9915 ListSnapshots API does not provide virtual size information of the snapshots

[git]

wido commented on issue #2101: CLOUDSTACK-9915  ListSnapshots API does not 
provide virtual size information of the snapshots
URL: https://github.com/apache/cloudstack/pull/2101#issuecomment-321589670
 
 
   LGTM based on the code
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] GabrielBrascher commented on issue #2222: CLOUDSTACK-10022: Allow domain admin to create and delete subdomains

[git]

GabrielBrascher commented on issue #: CLOUDSTACK-10022: Allow domain admin 
to create and delete subdomains
URL: https://github.com/apache/cloudstack/pull/#issuecomment-321603878
 
 
   Hi @wido 
   It was added the permission to execute the api commands that delete domains 
to the domain admin role; thus, it can delete its own domain with the API 
command "deteDomain". However, the following code does allow the domain admin 
to use the UI buttons to edit and delete only its subdomains.
   ```
if (args.context.domains[0].id != g_domainid) {
   allowedActions.push("edit"); //merge updateResourceLimit into edit
allowedActions.push("delete");
}
   ```
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2236: CLOUDSTACK-10044: Update role permission

[git]

blueorangutan commented on issue #2236: CLOUDSTACK-10044: Update role permission
URL: https://github.com/apache/cloudstack/pull/2236#issuecomment-321569884
 
 
   @nvazquez I understand these words: "help", "hello", "thanks", "package", 
"test"
   Test command usage: test [mgmt os] [hypervisor] [additional tests]
   Mgmt OS options: ['centos6', 'centos7', 'ubuntu']
   Hypervisor options: ['kvm-centos6', 'kvm-centos7', 'kvm-ubuntu', 
'xenserver-65sp1', 'xenserver-62sp1', 'vmware-60u2', 'vmware-55u3', 
'vmware-51u1', 'vmware-50u1']
   Additional tests: list of comma separated tests with paths relative to the 
`test/integration` directory, for example: component/test_acl_listvm.py, 
component/test_volumes.py
   Note: when additional tests are passed, you need to specify mgmt server os 
and hypervisor or use the `matrix` command.
   
   Blessed contributors for kicking Trillian test jobs: ['rhtyd', 'nvazquez', 
'PaulAngus', 'borisstoyanov', 'DaanHoogland']
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2236: CLOUDSTACK-10044: Update role permission

[git]

blueorangutan commented on issue #2236: CLOUDSTACK-10044: Update role permission
URL: https://github.com/apache/cloudstack/pull/2236#issuecomment-321577554
 
 
   @nvazquez a Jenkins job has been kicked to build packages. I'll keep you 
posted as I make progress.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] nvazquez opened a new pull request #2236: CLOUDSTACK-10044: Update role permission

[git]

nvazquez opened a new pull request #2236: CLOUDSTACK-10044: Update role 
permission
URL: https://github.com/apache/cloudstack/pull/2236
 
 
   JIRA TICKET: https://issues.apache.org/jira/browse/CLOUDSTACK-10044
   
   ### Introduction
   This feature allows to change permission for existing role permissions, as 
those were static and could not be changed once created. It also provides the 
ability to change these permissions in the UI using a drop down menu for each 
permission rule, in which admin can select ?Allow? or ?Deny? permission.
   
   ### Changes in the API:
   This feature modifies behaviour of `updateRolePermission` API method: 
   - New optional parameters ?ruleid? and ?permission? are introduced, they are 
mutual exclusive to ?ruleorder? parameter. This defines two use cases:
  - Update role permission: ?ruleid? and ?permission? parameters needed
  - Update rules order: ?ruleorder? parameter needed
   - Parameter ?ruleorder? is now optional
   - updateRolePermission providing ?ruleorder? parameter should be sent via 
POST
   
   ### Changes in the UI:
   Drop down menu added for role rule-permissions as seen in attached picture
   
![](https://issues.apache.org/jira/secure/attachment/12881210/UpdateRolePermissionUI.jpg
 "UI")
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] borisstoyanov commented on issue #2236: CLOUDSTACK-10044: Update role permission

[git]

borisstoyanov commented on issue #2236: CLOUDSTACK-10044: Update role permission
URL: https://github.com/apache/cloudstack/pull/2236#issuecomment-321567417
 
 
   Thanks @nvazquez 
   @blueorangutan package
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] nvazquez commented on issue #2236: CLOUDSTACK-10044: Update role permission

[git]

nvazquez commented on issue #2236: CLOUDSTACK-10044: Update role permission
URL: https://github.com/apache/cloudstack/pull/2236#issuecomment-321567364
 
 
   @blueorangutan hi
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] nvazquez commented on issue #2236: CLOUDSTACK-10044: Update role permission

[git]

nvazquez commented on issue #2236: CLOUDSTACK-10044: Update role permission
URL: https://github.com/apache/cloudstack/pull/2236#issuecomment-321569599
 
 
   @blueorangutan help
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #1593: CLOUDSTACK-9417: Usage module refactoring

[git]

blueorangutan commented on issue #1593: CLOUDSTACK-9417: Usage module 
refactoring
URL: https://github.com/apache/cloudstack/pull/1593#issuecomment-321569571
 
 
   hello @nvazquez
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] pdion891 commented on issue #2235: repo has moved

[git]

pdion891 commented on issue #2235: repo has moved
URL: https://github.com/apache/cloudstack/pull/2235#issuecomment-321519202
 
 
   LGTM
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2190: CLOUDSTACK-10010: Fixed the negotiation of S2S VPN connections

[git]

rhtyd commented on issue #2190: CLOUDSTACK-10010: Fixed the negotiation of S2S 
VPN connections
URL: https://github.com/apache/cloudstack/pull/2190#issuecomment-321533958
 
 
   @swill yeah right, that failed. Let me do that again.
   @blueorangutan package
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on a change in pull request #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9

[git]

rhtyd commented on a change in pull request #2211: CLOUDSTACK-10013: Migrate 
systemvmtemplate to Debian9
URL: https://github.com/apache/cloudstack/pull/2211#discussion_r132436288
 
 

 ##
 File path: 
tools/appliance/definitions/systemvmtemplate/configure_systemvm_services.sh
 ##
 @@ -39,12 +39,76 @@ function install_cloud_scripts() {
 /etc/init.d/{cloud,cloud-early-config,cloud-passwd-srvr,postinit} \
 /etc/profile.d/cloud.sh
 
-  chkconfig --add cloud-early-config
-  chkconfig cloud-early-config on
-  chkconfig --add cloud-passwd-srvr
-  chkconfig cloud-passwd-srvr off
-  chkconfig --add cloud
-  chkconfig cloud off
+  cat > /lib/systemd/system/cloud-early-config.service << EOF
 
 Review comment:
   @wido thanks, please feel free to do so.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2190: CLOUDSTACK-10010: Fixed the negotiation of S2S VPN connections

[git]

blueorangutan commented on issue #2190: CLOUDSTACK-10010: Fixed the negotiation 
of S2S VPN connections
URL: https://github.com/apache/cloudstack/pull/2190#issuecomment-321534109
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on a change in pull request #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9

[git]

rhtyd commented on a change in pull request #2211: CLOUDSTACK-10013: Migrate 
systemvmtemplate to Debian9
URL: https://github.com/apache/cloudstack/pull/2211#discussion_r132431563
 
 

 ##
 File path: 
tools/appliance/definitions/systemvmtemplate/configure_systemvm_services.sh
 ##
 @@ -39,12 +39,76 @@ function install_cloud_scripts() {
 /etc/init.d/{cloud,cloud-early-config,cloud-passwd-srvr,postinit} \
 /etc/profile.d/cloud.sh
 
-  chkconfig --add cloud-early-config
-  chkconfig cloud-early-config on
-  chkconfig --add cloud-passwd-srvr
-  chkconfig cloud-passwd-srvr off
-  chkconfig --add cloud
-  chkconfig cloud off
+  cat > /lib/systemd/system/cloud-early-config.service << EOF
 
 Review comment:
   We can do that, but isn't the files in 
/etc/systemd/system/multi-user.target.wants symlinked to /lib/systemd? I'm open 
to changes as long as the stuff works.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on a change in pull request #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9

[git]

rhtyd commented on a change in pull request #2211: CLOUDSTACK-10013: Migrate 
systemvmtemplate to Debian9
URL: https://github.com/apache/cloudstack/pull/2211#discussion_r132431725
 
 

 ##
 File path: tools/appliance/definitions/systemvmtemplate/configure_networking.sh
 ##
 @@ -52,8 +45,24 @@ function configure_hostname() {
   hostname $HOSTNAME
 }
 
+function configure_interfaces() {
+  cat > /etc/network/interfaces << EOF
+source /etc/network/interfaces.d/*
+
+# The loopback network interface
+auto lo
+iface lo inet loopback
+
+# The primary network interface
+auto eth0
+iface eth0 inet dhcp
+pre-up sleep 2
 
 Review comment:
   Historic reasons, I've no idea. I simply moved the code from here: 
https://github.com/apache/cloudstack/blob/master/tools/appliance/definitions/systemvmtemplate/configure_networking.sh#L28
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on a change in pull request #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9

[git]

rhtyd commented on a change in pull request #2211: CLOUDSTACK-10013: Migrate 
systemvmtemplate to Debian9
URL: https://github.com/apache/cloudstack/pull/2211#discussion_r132432437
 
 

 ##
 File path: tools/appliance/definitions/systemvmtemplate/configure_login.sh
 ##
 @@ -23,11 +23,12 @@ function add_admin_group() {
   groupadd -f -r admin
 }
 
-function configure_cloud_user() {
+function configure_user() {
   usermod -a -G admin cloud
   mkdir -p /home/cloud/.ssh
   chmod 700 /home/cloud/.ssh
   echo "cloud:`openssl rand -base64 32`" | chpasswd
+  echo "root:password" | chpasswd
 
 Review comment:
   Yes, this is ensure all systemvmtemplates have this default credentials 
(this is what the current systemvmtemplates use as well). In production env, 
you can set `system.vm.random.password` to true which then uses 
`system.vm.password` to get the password randomly set when mgmt server is 
initialized.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9

[git]

rhtyd commented on issue #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to 
Debian9
URL: https://github.com/apache/cloudstack/pull/2211#issuecomment-321530070
 
 
   @wido yes, I got it so far as to get serial console (`virsh console 
` works) and ssh work. However, when you restart the systemvm 
(ssvm/cpvm/vr etc) or stop+start the systemvm, it fails ssh login.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9

[git]

rhtyd commented on issue #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to 
Debian9
URL: https://github.com/apache/cloudstack/pull/2211#issuecomment-321530070
 
 
   @wido yes, I got it so far as to get serial console (`virsh console 
` works) and ssh work. However, when you restart the systemvm 
(ssvm/cpvm/vr etc) or stop+start the systemvm, it fails ssh login. You're 
right, something's not right with patching and/or systemd.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[cloudstack] branch master updated: README: Repo has moved (#2235)

[bhaisaab]

This is an automated email from the ASF dual-hosted git repository.

bhaisaab pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git


The following commit(s) were added to refs/heads/master by this push:
 new c13af1e  README: Repo has moved (#2235)
c13af1e is described below

commit c13af1e85ad0c524e59772b055159e2899ce9a92
Author: dahn 
AuthorDate: Thu Aug 10 13:54:26 2017 +0200

README: Repo has moved (#2235)

Move from git-wip-us to gitbox
---
 tools/cli/README | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/cli/README b/tools/cli/README
index f8bfebe..0508d0b 100644
--- a/tools/cli/README
+++ b/tools/cli/README
@@ -1 +1 @@
-Moved to https://git-wip-us.apache.org/repos/asf?p=cloudstack-cloudmonkey.git
+Moved to https://gitbox.apache.org/repos/asf?p=cloudstack-cloudmonkey.git

-- 
To stop receiving notification emails like this one, please contact
['"commits@cloudstack.apache.org" '].

[GitHub] rhtyd closed pull request #2235: repo has moved

[git]

rhtyd closed pull request #2235: repo has moved
URL: https://github.com/apache/cloudstack/pull/2235
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2235: repo has moved

[git]

rhtyd commented on issue #2235: repo has moved
URL: https://github.com/apache/cloudstack/pull/2235#issuecomment-321530318
 
 
   LGTM :smile: 
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wido commented on a change in pull request #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9

[git]

wido commented on a change in pull request #2211: CLOUDSTACK-10013: Migrate 
systemvmtemplate to Debian9
URL: https://github.com/apache/cloudstack/pull/2211#discussion_r132433628
 
 

 ##
 File path: 
tools/appliance/definitions/systemvmtemplate/configure_systemvm_services.sh
 ##
 @@ -39,12 +39,76 @@ function install_cloud_scripts() {
 /etc/init.d/{cloud,cloud-early-config,cloud-passwd-srvr,postinit} \
 /etc/profile.d/cloud.sh
 
-  chkconfig --add cloud-early-config
-  chkconfig cloud-early-config on
-  chkconfig --add cloud-passwd-srvr
-  chkconfig cloud-passwd-srvr off
-  chkconfig --add cloud
-  chkconfig cloud off
+  cat > /lib/systemd/system/cloud-early-config.service << EOF
 
 Review comment:
   No, it isn't. But we'd have to look into that. I'll debug a bit further and 
push a few commits to the branch without squashing anything
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] swill commented on issue #2190: CLOUDSTACK-10010: Fixed the negotiation of S2S VPN connections

[git]

swill commented on issue #2190: CLOUDSTACK-10010: Fixed the negotiation of S2S 
VPN connections
URL: https://github.com/apache/cloudstack/pull/2190#issuecomment-321532383
 
 
   @rhtyd it doesn't look like the tests actually kicked off on this one. 
Thanks...
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2236: CLOUDSTACK-10044: Update role permission

[git]

blueorangutan commented on issue #2236: CLOUDSTACK-10044: Update role permission
URL: https://github.com/apache/cloudstack/pull/2236#issuecomment-321717570
 
 
   Trillian test result (tid-1354)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 38032 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2236-t1354-kvm-centos7.zip
   Intermitten failure detected: /marvin/tests/smoke/test_internal_lb.py
   Intermitten failure detected: /marvin/tests/smoke/test_network.py
   Intermitten failure detected: /marvin/tests/smoke/test_nic.py
   Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
   Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Intermitten failure detected: /marvin/tests/smoke/test_vpc_router_nics.py
   Intermitten failure detected: /marvin/tests/smoke/test_vpc_vpn.py
   Test completed. 50 look OK, 7 have error(s)
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_01_vpc_remote_access_vpn | `Failure` | 60.69 | test_vpc_vpn.py
   test_01_VPC_nics_after_destroy | `Failure` | 343.77 | test_vpc_router_nics.py
   test_05_rvpc_multi_tiers | `Failure` | 180.28 | test_vpc_redundant.py
   test_04_rvpc_privategw_static_routes | `Failure` | 349.72 | 
test_privategw_acl.py
   test_03_vpc_privategw_restart_vpc_cleanup | `Error` | 298.33 | 
test_privategw_acl.py
   test_01_nic | `Error` | 141.63 | test_nic.py
   test_reboot_router | `Error` | 312.09 | test_network.py
   test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 | `Error` | 526.05 | 
test_internal_lb.py
   test_change_service_offering_for_vm_with_snapshots | Skipped | 0.00 | 
test_vm_snapshots.py
   test_09_copy_delete_template | Skipped | 0.01 | test_templates.py
   test_06_copy_template | Skipped | 0.00 | test_templates.py
   test_static_role_account_acls | Skipped | 0.02 | test_staticroles.py
   test_11_ss_nfs_version_on_ssvm | Skipped | 0.02 | test_ssvm.py
   test_01_scale_vm | Skipped | 0.00 | test_scale_vm.py
   test_01_primary_storage_iscsi | Skipped | 0.03 | test_primary_storage.py
   test_vm_nic_adapter_vmxnet3 | Skipped | 0.00 | test_nic_adapter_type.py
   test_nested_virtualization_vmware | Skipped | 0.00 | 
test_nested_virtualization.py
   test_06_copy_iso | Skipped | 0.00 | test_iso.py
   test_deploy_vgpu_enabled_vm | Skipped | 0.04 | test_deploy_vgpu_enabled_vm.py
   test_3d_gpu_support | Skipped | 0.04 | test_deploy_vgpu_enabled_vm.py
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2028: CLOUDSTACK-9853: Add support for Secondary IPv6 Addresses and Subnets

[git]

blueorangutan commented on issue #2028: CLOUDSTACK-9853: Add support for 
Secondary IPv6 Addresses and Subnets
URL: https://github.com/apache/cloudstack/pull/2028#issuecomment-321717575
 
 
   Trillian test result (tid-1353)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 43073 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2028-t1353-kvm-centos7.zip
   Intermitten failure detected: /marvin/tests/smoke/test_internal_lb.py
   Intermitten failure detected: /marvin/tests/smoke/test_network.py
   Intermitten failure detected: /marvin/tests/smoke/test_nic.py
   Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
   Intermitten failure detected: /marvin/tests/smoke/test_routers.py
   Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Intermitten failure detected: /marvin/tests/smoke/test_vpc_router_nics.py
   Intermitten failure detected: /marvin/tests/smoke/test_vpc_vpn.py
   Test completed. 49 look OK, 8 have error(s)
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_01_vpc_remote_access_vpn | `Failure` | 71.07 | test_vpc_vpn.py
   test_01_VPC_nics_after_destroy | `Failure` | 508.95 | test_vpc_router_nics.py
   test_05_rvpc_multi_tiers | `Failure` | 183.11 | test_vpc_redundant.py
   test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 414.66 | 
test_vpc_redundant.py
   test_06_router_advanced | `Failure` | 0.02 | test_routers.py
   test_05_router_basic | `Failure` | 0.03 | test_routers.py
   test_04_rvpc_privategw_static_routes | `Failure` | 421.93 | 
test_privategw_acl.py
   test_05_rvpc_multi_tiers | `Error` | 218.66 | test_vpc_redundant.py
   test_09_reboot_router | `Error` | 5.15 | test_routers.py
   test_08_start_router | `Error` | 45.38 | test_routers.py
   test_04_restart_network_wo_cleanup | `Error` | 40.34 | test_routers.py
   test_03_restart_network_cleanup | `Error` | 75.66 | test_routers.py
   test_03_vpc_privategw_restart_vpc_cleanup | `Error` | 365.56 | 
test_privategw_acl.py
   test_01_nic | `Error` | 222.96 | test_nic.py
   test_reboot_router | `Error` | 317.99 | test_network.py
   test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 | `Error` | 96.83 | 
test_internal_lb.py
   test_change_service_offering_for_vm_with_snapshots | Skipped | 0.00 | 
test_vm_snapshots.py
   test_09_copy_delete_template | Skipped | 0.02 | test_templates.py
   test_06_copy_template | Skipped | 0.00 | test_templates.py
   test_static_role_account_acls | Skipped | 0.02 | test_staticroles.py
   test_11_ss_nfs_version_on_ssvm | Skipped | 0.02 | test_ssvm.py
   test_01_scale_vm | Skipped | 0.00 | test_scale_vm.py
   test_01_primary_storage_iscsi | Skipped | 0.04 | test_primary_storage.py
   test_vm_nic_adapter_vmxnet3 | Skipped | 0.00 | test_nic_adapter_type.py
   test_nested_virtualization_vmware | Skipped | 0.00 | 
test_nested_virtualization.py
   test_06_copy_iso | Skipped | 0.00 | test_iso.py
   test_deploy_vgpu_enabled_vm | Skipped | 0.03 | test_deploy_vgpu_enabled_vm.py
   test_3d_gpu_support | Skipped | 0.03 | test_deploy_vgpu_enabled_vm.py
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2190: CLOUDSTACK-10010: Fixed the negotiation of S2S VPN connections

[git]

blueorangutan commented on issue #2190: CLOUDSTACK-10010: Fixed the negotiation 
of S2S VPN connections
URL: https://github.com/apache/cloudstack/pull/2190#issuecomment-321720533
 
 
   Trillian test result (tid-1352)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 46324 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2190-t1352-kvm-centos7.zip
   Intermitten failure detected: 
/marvin/tests/smoke/test_deploy_virtio_scsi_vm.py
   Intermitten failure detected: /marvin/tests/smoke/test_deploy_vm_iso.py
   Intermitten failure detected: /marvin/tests/smoke/test_internal_lb.py
   Intermitten failure detected: /marvin/tests/smoke/test_network.py
   Intermitten failure detected: /marvin/tests/smoke/test_nic.py
   Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
   Intermitten failure detected: /marvin/tests/smoke/test_routers.py
   Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Intermitten failure detected: /marvin/tests/smoke/test_vpc_router_nics.py
   Intermitten failure detected: /marvin/tests/smoke/test_vpc_vpn.py
   Test completed. 49 look OK, 8 have error(s)
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_01_vpc_remote_access_vpn | `Failure` | 61.06 | test_vpc_vpn.py
   test_01_VPC_nics_after_destroy | `Failure` | 454.08 | test_vpc_router_nics.py
   test_06_router_advanced | `Failure` | 0.02 | test_routers.py
   test_05_router_basic | `Failure` | 0.03 | test_routers.py
   test_04_rvpc_privategw_static_routes | `Failure` | 437.46 | 
test_privategw_acl.py
   test_01_vpc_site2site_vpn_multiple_options | `Error` | 112.12 | 
test_vpc_vpn.py
   test_09_reboot_router | `Error` | 5.11 | test_routers.py
   test_08_start_router | `Error` | 40.33 | test_routers.py
   test_04_restart_network_wo_cleanup | `Error` | 40.39 | test_routers.py
   test_03_restart_network_cleanup | `Error` | 70.61 | test_routers.py
   test_03_vpc_privategw_restart_vpc_cleanup | `Error` | 299.86 | 
test_privategw_acl.py
   test_01_nic | `Error` | 167.53 | test_nic.py
   test_reboot_router | `Error` | 257.77 | test_network.py
   ContextSuite context=TestInternalLb>:setup | `Error` | 0.00 | 
test_internal_lb.py
   ContextSuite context=TestDeployVirtioSCSIVM>:setup | `Error` | 0.00 | 
test_deploy_virtio_scsi_vm.py
   test_change_service_offering_for_vm_with_snapshots | Skipped | 0.00 | 
test_vm_snapshots.py
   test_09_copy_delete_template | Skipped | 0.02 | test_templates.py
   test_06_copy_template | Skipped | 0.00 | test_templates.py
   test_static_role_account_acls | Skipped | 0.02 | test_staticroles.py
   test_11_ss_nfs_version_on_ssvm | Skipped | 0.02 | test_ssvm.py
   test_01_scale_vm | Skipped | 0.00 | test_scale_vm.py
   test_01_primary_storage_iscsi | Skipped | 0.04 | test_primary_storage.py
   test_vm_nic_adapter_vmxnet3 | Skipped | 0.00 | test_nic_adapter_type.py
   test_nested_virtualization_vmware | Skipped | 0.00 | 
test_nested_virtualization.py
   test_06_copy_iso | Skipped | 0.00 | test_iso.py
   test_deploy_vgpu_enabled_vm | Skipped | 0.04 | test_deploy_vgpu_enabled_vm.py
   test_3d_gpu_support | Skipped | 0.04 | test_deploy_vgpu_enabled_vm.py
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wido commented on issue #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9

[git]

wido commented on issue #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to 
Debian9
URL: https://github.com/apache/cloudstack/pull/2211#issuecomment-321525581
 
 
   I eventually used the *build.sh* script in tools/appliance and got a img.raw
   
   On my existing test cluster I manually overwrite the QCOW2 template on SS 
and then re-deployed the Secondary Storage VM.
   
   It's 'running' now but the Agent isn't starting yet, which is a systemd 
thing. Looking into that.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wido commented on a change in pull request #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9

[git]

wido commented on a change in pull request #2211: CLOUDSTACK-10013: Migrate 
systemvmtemplate to Debian9
URL: https://github.com/apache/cloudstack/pull/2211#discussion_r132430475
 
 

 ##
 File path: tools/appliance/definitions/systemvmtemplate/configure_networking.sh
 ##
 @@ -52,8 +45,24 @@ function configure_hostname() {
   hostname $HOSTNAME
 }
 
+function configure_interfaces() {
+  cat > /etc/network/interfaces << EOF
+source /etc/network/interfaces.d/*
+
+# The loopback network interface
+auto lo
+iface lo inet loopback
+
+# The primary network interface
+auto eth0
+iface eth0 inet dhcp
+pre-up sleep 2
 
 Review comment:
   Why do we sleep here? Is that really needed?
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wido commented on a change in pull request #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9

[git]

wido commented on a change in pull request #2211: CLOUDSTACK-10013: Migrate 
systemvmtemplate to Debian9
URL: https://github.com/apache/cloudstack/pull/2211#discussion_r132430610
 
 

 ##
 File path: tools/appliance/definitions/systemvmtemplate/configure_login.sh
 ##
 @@ -23,11 +23,12 @@ function add_admin_group() {
   groupadd -f -r admin
 }
 
-function configure_cloud_user() {
+function configure_user() {
   usermod -a -G admin cloud
   mkdir -p /home/cloud/.ssh
   chmod 700 /home/cloud/.ssh
   echo "cloud:`openssl rand -base64 32`" | chpasswd
+  echo "root:password" | chpasswd
 
 Review comment:
   Does this force the password for root to 'password'? It seems it does
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wido commented on a change in pull request #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9

[git]

wido commented on a change in pull request #2211: CLOUDSTACK-10013: Migrate 
systemvmtemplate to Debian9
URL: https://github.com/apache/cloudstack/pull/2211#discussion_r132430071
 
 

 ##
 File path: 
tools/appliance/definitions/systemvmtemplate/configure_systemvm_services.sh
 ##
 @@ -39,12 +39,76 @@ function install_cloud_scripts() {
 /etc/init.d/{cloud,cloud-early-config,cloud-passwd-srvr,postinit} \
 /etc/profile.d/cloud.sh
 
-  chkconfig --add cloud-early-config
-  chkconfig cloud-early-config on
-  chkconfig --add cloud-passwd-srvr
-  chkconfig cloud-passwd-srvr off
-  chkconfig --add cloud
-  chkconfig cloud off
+  cat > /lib/systemd/system/cloud-early-config.service << EOF
 
 Review comment:
   Shouldn't we put these in */etc/systemd/system* as they are kind of custom?
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2190: CLOUDSTACK-10010: Fixed the negotiation of S2S VPN connections

[git]

blueorangutan commented on issue #2190: CLOUDSTACK-10010: Fixed the negotiation 
of S2S VPN connections
URL: https://github.com/apache/cloudstack/pull/2190#issuecomment-321538603
 
 
   Packaging result: ?centos6 ?centos7 ?debian. JID-944
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[cloudstack] 02/02: Move systemd services to /etc and enable services after they have been installed

[widodh]

This is an automated email from the ASF dual-hosted git repository.

widodh pushed a commit to branch debian9-systemvmtemplate
in repository https://gitbox.apache.org/repos/asf/cloudstack.git

commit 538f2865bd264d772bc77cd5893d29fa805cab72
Author: Wido den Hollander 
AuthorDate: Thu Aug 10 14:36:52 2017 +0200

Move systemd services to /etc and enable services after they have been 
installed

Signed-off-by: Wido den Hollander 
---
 .../configure_systemvm_services.sh | 24 +++---
 1 file changed, 12 insertions(+), 12 deletions(-)

diff --git 
a/tools/appliance/definitions/systemvmtemplate/configure_systemvm_services.sh 
b/tools/appliance/definitions/systemvmtemplate/configure_systemvm_services.sh
index f3bd52a..171c4b0 100644
--- 
a/tools/appliance/definitions/systemvmtemplate/configure_systemvm_services.sh
+++ 
b/tools/appliance/definitions/systemvmtemplate/configure_systemvm_services.sh
@@ -36,10 +36,10 @@ function install_cloud_scripts() {
   rsync -av ./cloud_scripts/ /
   chmod +x /opt/cloud/bin/* \
 /root/{clearUsageRules.sh,reconfigLB.sh,monitorServices.py} \
-/etc/init.d/{cloud,cloud-early-config,cloud-passwd-srvr,postinit} \
+/etc/init.d/{cloud-early-config,cloud-passwd-srvr,postinit} \
 /etc/profile.d/cloud.sh
 
-  cat > /lib/systemd/system/cloud-early-config.service << EOF
+  cat > /etc/systemd/system/cloud-early-config.service << EOF
 [Unit]
 Description=cloud-early-config: configure according to cmdline
 DefaultDependencies=no
@@ -57,7 +57,7 @@ TimeoutStartSec=5min
 
 EOF
 
-  cat > /lib/systemd/system/cloud.service << EOF
+  cat > /etc/systemd/system/cloud.service << EOF
 [Unit]
 Description=cloud: startup cloud service
 After=cloud-early-config.service network.target local-fs.target
@@ -66,14 +66,14 @@ After=cloud-early-config.service network.target 
local-fs.target
 WantedBy=multi-user.target
 
 [Service]
-Type=forking
-ExecStart=/etc/init.d/cloud start
-ExecStop=/etc/init.d/cloud stop
-RemainAfterExit=true
-TimeoutStartSec=5min
+Type=simple
+WorkingDirectory=/usr/local/cloud/systemvm
+ExecStart=/usr/local/cloud/systemvm/_run.sh
+Restart=always
+RestartSec=5
 EOF
 
-  cat > /lib/systemd/system/cloud-passwd-srvr.service << EOF
+  cat > /etc/systemd/system/cloud-passwd-srvr.service << EOF
 [Unit]
 Description=cloud-passwd-srvr: cloud password server
 After=network.target local-fs.target
@@ -89,7 +89,7 @@ RemainAfterExit=true
 TimeoutStartSec=5min
 EOF
 
-  cat > /lib/systemd/system/postinit.service << EOF
+  cat > /etc/systemd/system/postinit.service << EOF
 [Unit]
 Description=cloud post-init service
 After=cloud-early-config.service network.target local-fs.target
@@ -107,8 +107,8 @@ EOF
 
   systemctl daemon-reload
   systemctl enable cloud-early-config
-  systemctl disable cloud-passwd-srvr
-  systemctl disable cloud
+  systemctl enable cloud-passwd-srvr
+  systemctl enable cloud
 }
 
 function do_signature() {

-- 
To stop receiving notification emails like this one, please contact
"commits@cloudstack.apache.org" .

[cloudstack] branch debian9-systemvmtemplate updated (6c8fbc9 -> 538f286)

[widodh]

This is an automated email from the ASF dual-hosted git repository.

widodh pushed a change to branch debian9-systemvmtemplate
in repository https://gitbox.apache.org/repos/asf/cloudstack.git.


from 6c8fbc9  CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9
 new 18f725c  Load the nf_conntrack_ipv6 module for IPv6 connection 
tracking on SSVM
 new 538f286  Move systemd services to /etc and enable services after they 
have been installed

The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 .../systemvmtemplate/configure_conntrack.sh|  1 +
 .../configure_systemvm_services.sh | 24 +++---
 2 files changed, 13 insertions(+), 12 deletions(-)

-- 
To stop receiving notification emails like this one, please contact
['"commits@cloudstack.apache.org" '].

[cloudstack] 01/02: Load the nf_conntrack_ipv6 module for IPv6 connection tracking on SSVM

[widodh]

This is an automated email from the ASF dual-hosted git repository.

widodh pushed a commit to branch debian9-systemvmtemplate
in repository https://gitbox.apache.org/repos/asf/cloudstack.git

commit 18f725ca6c363619439ad20f79d3cf04986a596d
Author: Wido den Hollander 
AuthorDate: Thu Aug 10 13:51:11 2017 +0200

Load the nf_conntrack_ipv6 module for IPv6 connection tracking on SSVM

Signed-off-by: Wido den Hollander 
---
 tools/appliance/definitions/systemvmtemplate/configure_conntrack.sh | 1 +
 1 file changed, 1 insertion(+)

diff --git 
a/tools/appliance/definitions/systemvmtemplate/configure_conntrack.sh 
b/tools/appliance/definitions/systemvmtemplate/configure_conntrack.sh
index 54ec41b..c898afc 100644
--- a/tools/appliance/definitions/systemvmtemplate/configure_conntrack.sh
+++ b/tools/appliance/definitions/systemvmtemplate/configure_conntrack.sh
@@ -35,6 +35,7 @@ function load_conntrack_modules() {
 
   cat >> /etc/modules << EOF
 nf_conntrack_ipv4
+nf_conntrack_ipv6
 nf_conntrack
 nf_conntrack_ftp
 nf_nat_ftp

-- 
To stop receiving notification emails like this one, please contact
"commits@cloudstack.apache.org" .

[GitHub] wido commented on issue #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9

[git]

wido commented on issue #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to 
Debian9
URL: https://github.com/apache/cloudstack/pull/2211#issuecomment-321539321
 
 
   Ok, good! I got the Agent to run as well inside the SSVM.
   
   I pushed two commits which work for me.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[cloudstack] branch debian9-systemvmtemplate updated: Accept DOS/MBR as file format for ISO images as well

[widodh]

This is an automated email from the ASF dual-hosted git repository.

widodh pushed a commit to branch debian9-systemvmtemplate
in repository https://gitbox.apache.org/repos/asf/cloudstack.git


The following commit(s) were added to refs/heads/debian9-systemvmtemplate by 
this push:
 new 325b083  Accept DOS/MBR as file format for ISO images as well
325b083 is described below

commit 325b083f133d5023bd3b399d92c2af5ad34da7da
Author: Wido den Hollander 
AuthorDate: Thu Aug 10 14:57:40 2017 +0200

Accept DOS/MBR as file format for ISO images as well

Under Debian 7 the 'file' command would return:

  debian-9.1.0-amd64-netinst.iso: ISO 9660 CD-ROM filesystem data UDF 
filesystem data

Under Debian 9 however it will return

  debian-9.1.0-amd64-netinst.iso: DOS/MBR boot sector

This would make the HTTPTemplateDownloader in the Secondary Storage VM 
refuse the ISO as
a valid template because it's not a correct format.

Changes this behavior so that it accepts both.

This allows us to use Debian 9 as a System VM template.

Signed-off-by: Wido den Hollander 
---
 .../java/org/apache/cloudstack/utils/imagestore/ImageStoreUtil.java | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git 
a/utils/src/main/java/org/apache/cloudstack/utils/imagestore/ImageStoreUtil.java
 
b/utils/src/main/java/org/apache/cloudstack/utils/imagestore/ImageStoreUtil.java
index ed13360..e754a8e 100644
--- 
a/utils/src/main/java/org/apache/cloudstack/utils/imagestore/ImageStoreUtil.java
+++ 
b/utils/src/main/java/org/apache/cloudstack/utils/imagestore/ImageStoreUtil.java
@@ -81,7 +81,7 @@ public class ImageStoreUtil {
 return "";
 }
 
-if (output.contains("ISO 9660") && isCorrectExtension(uripath, "iso")) 
{
+if ((output.startsWith("ISO 9660") || output.startsWith("DOS/MBR")) && 
isCorrectExtension(uripath, "iso")) {
 s_logger.debug("File at path " + path + " looks like an iso : " + 
output);
 return "";
 }

-- 
To stop receiving notification emails like this one, please contact
['"commits@cloudstack.apache.org" '].