[cloudstack] 01/01: [Merge 4.11] CLOUDSTACK-10341: Reduce systemvmtemplate size (#2506)

[rohit]

This is an automated email from the ASF dual-hosted git repository.

rohit pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git

commit ba61b512b2b1006d7164e039a3cb57db9ba64fab
Merge: 95d10c2 986ecfa
Author: Rohit Yadav 
AuthorDate: Wed Mar 28 13:18:12 2018 +0530

[Merge 4.11] CLOUDSTACK-10341: Reduce systemvmtemplate size (#2506)

Signed-off-by: Rohit Yadav 

 test/integration/smoke/test_vpc_redundant.py   |  7 ---
 tools/appliance/build.sh   |  8 
 tools/appliance/systemvmtemplate/http/preseed.cfg  | 10 +-
 tools/appliance/systemvmtemplate/scripts/apt_upgrade.sh|  3 +--
 tools/appliance/systemvmtemplate/scripts/cleanup.sh|  2 ++
 .../systemvmtemplate/scripts/install_systemvm_packages.sh  |  4 +++-
 tools/appliance/systemvmtemplate/template.json |  2 +-
 7 files changed, 20 insertions(+), 16 deletions(-)

diff --cc tools/appliance/build.sh
index 893404d,ba6fe4d..edbe11f
--- a/tools/appliance/build.sh
+++ b/tools/appliance/build.sh
@@@ -198,10 -194,8 +198,10 @@@ function create_definition() 
  cp -r "${appliance}" "${appliance_build_name}"
  set +e
  if [ ! -z "${version}" ]; then
- if [ -f "${appliance_build_name}/scripts/configure_systemvm_services.sh" 
]; then
- sed ${sed_regex_option} -i -e 
"s/^CLOUDSTACK_RELEASE=.+/CLOUDSTACK_RELEASE=${version}/" \
- "${appliance_build_name}/scripts/configure_systemvm_services.sh"
- fi
 -sed ${sed_regex_option} -i -e 
"s/^CLOUDSTACK_RELEASE=.+/CLOUDSTACK_RELEASE=${version}/" \
 -"${appliance_build_name}/scripts/configure_systemvm_services.sh"
++  if [ -f 
"${appliance_build_name}/scripts/configure_systemvm_services.sh" ]; then
++  sed ${sed_regex_option} -i -e 
"s/^CLOUDSTACK_RELEASE=.+/CLOUDSTACK_RELEASE=${version}/" \
++  "${appliance_build_name}/scripts/configure_systemvm_services.sh"
++  fi
  fi
  set -e
  add_on_exit rm -rf "${appliance_build_name}"

-- 
To stop receiving notification emails like this one, please contact
ro...@apache.org.

[cloudstack] branch master updated (95d10c2 -> ba61b51)

[rohit]

This is an automated email from the ASF dual-hosted git repository.

rohit pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git.


from 95d10c2  [Merge 4.11] CLOUDSTACK-10227: Fix mkdir path for centos rpms 
(#2513)
 add 986ecfa  CLOUDSTACK-10341: Reduce systemvmtemplate size, install 
nftables (#2506)
 new ba61b51  [Merge 4.11] CLOUDSTACK-10341: Reduce systemvmtemplate size 
(#2506)

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 test/integration/smoke/test_vpc_redundant.py   |  7 ---
 tools/appliance/build.sh   |  8 
 tools/appliance/systemvmtemplate/http/preseed.cfg  | 10 +-
 tools/appliance/systemvmtemplate/scripts/apt_upgrade.sh|  3 +--
 tools/appliance/systemvmtemplate/scripts/cleanup.sh|  2 ++
 .../systemvmtemplate/scripts/install_systemvm_packages.sh  |  4 +++-
 tools/appliance/systemvmtemplate/template.json |  2 +-
 7 files changed, 20 insertions(+), 16 deletions(-)

-- 
To stop receiving notification emails like this one, please contact
ro...@apache.org.

[GitHub] rhtyd commented on issue #2514: Problem with NAT configuration and VMs not accessing each other via public IPs

[GitBox]

rhtyd commented on issue #2514: Problem with NAT configuration and VMs not 
accessing each other via public IPs
URL: https://github.com/apache/cloudstack/pull/2514#issuecomment-376795363
 
 
   @rafaelweingartner since it's a useful bugfix, can you change the base 
branch and rebase the PR against 4.11 branch?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2506: CLOUDSTACK-10341: Reduce systemvmtemplate size, install nftables

[GitBox]

rhtyd commented on issue #2506: CLOUDSTACK-10341: Reduce systemvmtemplate size, 
install nftables
URL: https://github.com/apache/cloudstack/pull/2506#issuecomment-376792059
 
 
   Test LGTM, failures are due to environment issues or not related to this PR. 
Merging this based on results and two review LGTMs.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[cloudstack] branch 4.11 updated: CLOUDSTACK-10341: Reduce systemvmtemplate size, install nftables (#2506)

[rohit]

This is an automated email from the ASF dual-hosted git repository.

rohit pushed a commit to branch 4.11
in repository https://gitbox.apache.org/repos/asf/cloudstack.git


The following commit(s) were added to refs/heads/4.11 by this push:
 new 986ecfa  CLOUDSTACK-10341: Reduce systemvmtemplate size, install 
nftables (#2506)
986ecfa is described below

commit 986ecfa7e99d0f29b4d7b3cd8065da31695ec00b
Author: Rohit Yadav 
AuthorDate: Wed Mar 28 13:11:51 2018 +0530

CLOUDSTACK-10341: Reduce systemvmtemplate size, install nftables (#2506)

This reduces systemvmtemplate size by 600MB and installs nftables,
updates iptables. This also fixes a failing smoke test.

Signed-off-by: Rohit Yadav 
---
 test/integration/smoke/test_vpc_redundant.py   |  7 ---
 tools/appliance/build.sh   |  2 +-
 tools/appliance/systemvmtemplate/http/preseed.cfg  | 10 +-
 tools/appliance/systemvmtemplate/scripts/apt_upgrade.sh|  3 +--
 tools/appliance/systemvmtemplate/scripts/cleanup.sh|  2 ++
 .../systemvmtemplate/scripts/install_systemvm_packages.sh  |  4 +++-
 tools/appliance/systemvmtemplate/template.json |  2 +-
 7 files changed, 17 insertions(+), 13 deletions(-)

diff --git a/test/integration/smoke/test_vpc_redundant.py 
b/test/integration/smoke/test_vpc_redundant.py
index 2fde8d9..64b1fa6 100644
--- a/test/integration/smoke/test_vpc_redundant.py
+++ b/test/integration/smoke/test_vpc_redundant.py
@@ -304,8 +304,8 @@ class TestVPCRedundancy(cloudstackTestCase):
 time.sleep(3 * self.advert_int + 5)
 
 def check_routers_state(self,count=2, status_to_check="MASTER", 
expected_count=1, showall=False):
-vals = ["MASTER", "BACKUP", "UNKNOWN"]
-cnts = [0, 0, 0]
+vals = ["MASTER", "BACKUP", "UNKNOWN", "FAULT"]
+cnts = [0, 0, 0, 0]
 
 self.wait_for_vrrp()
 
@@ -612,7 +612,8 @@ class TestVPCRedundancy(cloudstackTestCase):
 
 time.sleep(total_sleep * 3)
 
-self.check_routers_state(status_to_check="BACKUP", expected_count=2)
+# Router will be in FAULT state, i.e. keepalived is stopped
+self.check_routers_state(status_to_check="FAULT", expected_count=2)
 self.start_vm()
 self.check_routers_state(status_to_check="MASTER")
 
diff --git a/tools/appliance/build.sh b/tools/appliance/build.sh
index 8b1032e..ba6fe4d 100755
--- a/tools/appliance/build.sh
+++ b/tools/appliance/build.sh
@@ -195,7 +195,7 @@ function create_definition() {
 set +e
 if [ ! -z "${version}" ]; then
 sed ${sed_regex_option} -i -e 
"s/^CLOUDSTACK_RELEASE=.+/CLOUDSTACK_RELEASE=${version}/" \
-"${appliance_build_name}/configure_systemvm_services.sh"
+"${appliance_build_name}/scripts/configure_systemvm_services.sh"
 fi
 set -e
 add_on_exit rm -rf "${appliance_build_name}"
diff --git a/tools/appliance/systemvmtemplate/http/preseed.cfg 
b/tools/appliance/systemvmtemplate/http/preseed.cfg
index cdb649a..65a5733 100644
--- a/tools/appliance/systemvmtemplate/http/preseed.cfg
+++ b/tools/appliance/systemvmtemplate/http/preseed.cfg
@@ -54,28 +54,28 @@ d-i partman-auto/disk string /dev/vda
 d-i partman-auto/method string regular
 d-i partman-auto/expert_recipe string \
   boot-root ::\
-  80 50 160 ext2  \
+  60 60 60 ext2   \
   $primary{ } $bootable{ }\
   method{ format } format{ }  \
   use_filesystem{ } filesystem{ ext2 }\
   mountpoint{ /boot } \
   .   \
-  1200 40 1600 ext4   \
+  975 40 1000 ext4\
   method{ format } format{ }  \
   use_filesystem{ } filesystem{ ext4 }\
   mountpoint{ / } \
   .   \
-  800 60 800 ext4 \
+  480 50 700 ext4 \
   method{ format } format{ }  \
   use_filesystem{ } filesystem{ ext4 }\
   mountpoint{ /var }  \
   .   \
-  100 90 200 ext4 \
+  80 90 100 ext4  \
   method{ format } format{ }  \
   use_filesystem{ } filesystem{ ext4 }\
   mountpoint{ /tmp }

[GitHub] rhtyd closed pull request #2506: CLOUDSTACK-10341: Reduce systemvmtemplate size, install nftables

[GitBox]

rhtyd closed pull request #2506: CLOUDSTACK-10341: Reduce systemvmtemplate 
size, install nftables
URL: https://github.com/apache/cloudstack/pull/2506
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/test/integration/smoke/test_vpc_redundant.py 
b/test/integration/smoke/test_vpc_redundant.py
index 2fde8d99207..64b1fa67771 100644
--- a/test/integration/smoke/test_vpc_redundant.py
+++ b/test/integration/smoke/test_vpc_redundant.py
@@ -304,8 +304,8 @@ def wait_for_vrrp(self):
 time.sleep(3 * self.advert_int + 5)
 
 def check_routers_state(self,count=2, status_to_check="MASTER", 
expected_count=1, showall=False):
-vals = ["MASTER", "BACKUP", "UNKNOWN"]
-cnts = [0, 0, 0]
+vals = ["MASTER", "BACKUP", "UNKNOWN", "FAULT"]
+cnts = [0, 0, 0, 0]
 
 self.wait_for_vrrp()
 
@@ -612,7 +612,8 @@ def test_04_rvpc_network_garbage_collector_nics(self):
 
 time.sleep(total_sleep * 3)
 
-self.check_routers_state(status_to_check="BACKUP", expected_count=2)
+# Router will be in FAULT state, i.e. keepalived is stopped
+self.check_routers_state(status_to_check="FAULT", expected_count=2)
 self.start_vm()
 self.check_routers_state(status_to_check="MASTER")
 
diff --git a/tools/appliance/build.sh b/tools/appliance/build.sh
index 8b1032ecc8b..ba6fe4dda1a 100755
--- a/tools/appliance/build.sh
+++ b/tools/appliance/build.sh
@@ -195,7 +195,7 @@ function create_definition() {
 set +e
 if [ ! -z "${version}" ]; then
 sed ${sed_regex_option} -i -e 
"s/^CLOUDSTACK_RELEASE=.+/CLOUDSTACK_RELEASE=${version}/" \
-"${appliance_build_name}/configure_systemvm_services.sh"
+"${appliance_build_name}/scripts/configure_systemvm_services.sh"
 fi
 set -e
 add_on_exit rm -rf "${appliance_build_name}"
diff --git a/tools/appliance/systemvmtemplate/http/preseed.cfg 
b/tools/appliance/systemvmtemplate/http/preseed.cfg
index cdb649a8f5d..65a573374a9 100644
--- a/tools/appliance/systemvmtemplate/http/preseed.cfg
+++ b/tools/appliance/systemvmtemplate/http/preseed.cfg
@@ -54,28 +54,28 @@ d-i partman-auto/disk string /dev/vda
 d-i partman-auto/method string regular
 d-i partman-auto/expert_recipe string \
   boot-root ::\
-  80 50 160 ext2  \
+  60 60 60 ext2   \
   $primary{ } $bootable{ }\
   method{ format } format{ }  \
   use_filesystem{ } filesystem{ ext2 }\
   mountpoint{ /boot } \
   .   \
-  1200 40 1600 ext4   \
+  975 40 1000 ext4\
   method{ format } format{ }  \
   use_filesystem{ } filesystem{ ext4 }\
   mountpoint{ / } \
   .   \
-  800 60 800 ext4 \
+  480 50 700 ext4 \
   method{ format } format{ }  \
   use_filesystem{ } filesystem{ ext4 }\
   mountpoint{ /var }  \
   .   \
-  100 90 200 ext4 \
+  80 90 100 ext4  \
   method{ format } format{ }  \
   use_filesystem{ } filesystem{ ext4 }\
   mountpoint{ /tmp }  \
   .   \
-  256 100 1024 linux-swap \
+  256 1000 256 linux-swap \
   method{ swap } format{ }\
   .
 
diff --git a/tools/appliance/systemvmtemplate/scripts/apt_upgrade.sh 
b/tools/appliance/systemvmtemplate/scripts/apt_upgrade.sh
index ac48b6b8249..b6de480c4e2 100644
--- a/tools/appliance/systemvmtemplate/scripts/apt_upgrade.sh
+++ b/tools/appliance/systemvmtemplate/scripts/apt_upgrade.sh
@@ -23,7 +23,7 @@ set -x
 function fix_tune2fs() {
   for partition in $(blkid -o list | grep ext | awk '{print $1}')
   do
-tune2fs -m 1 $partition
+tune2fs -m 0 $partition
 tune2fs -c 3 $partition
   done
   fdisk -l
@@ -55,7 +55,6 @@ function apt_upgrade() {
   apt-get -q -y update
   apt-get -q -y 

[GitHub] blueorangutan commented on issue #2510: CLOUDSTACK-10334: Fix inadequate information for handling catch clauses

[GitBox]

blueorangutan commented on issue #2510: CLOUDSTACK-10334: Fix inadequate 
information for handling catch clauses
URL: https://github.com/apache/cloudstack/pull/2510#issuecomment-376804849
 
 
   @DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you 
posted as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[cloudstack] branch master updated: CLOUDSTACK-10334: Fix inadequate information for handling catch clauses (#2510)

[rafael]

This is an automated email from the ASF dual-hosted git repository.

rafael pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git


The following commit(s) were added to refs/heads/master by this push:
 new c1c587f  CLOUDSTACK-10334: Fix inadequate information for handling 
catch clauses (#2510)
c1c587f is described below

commit c1c587fffe0dc3cc703829a4a4501afb1fee1a45
Author: lzh3636 
AuthorDate: Wed Mar 28 06:02:16 2018 -0400

CLOUDSTACK-10334: Fix inadequate information for handling catch clauses 
(#2510)

* Add log stack traces

* Change log stack traces

Add original stack trace to the new throw and delete the error logs
---
 server/src/main/java/com/cloud/api/dispatch/ParamProcessWorker.java | 6 ++
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git 
a/server/src/main/java/com/cloud/api/dispatch/ParamProcessWorker.java 
b/server/src/main/java/com/cloud/api/dispatch/ParamProcessWorker.java
index feefaab..f030209 100644
--- a/server/src/main/java/com/cloud/api/dispatch/ParamProcessWorker.java
+++ b/server/src/main/java/com/cloud/api/dispatch/ParamProcessWorker.java
@@ -258,13 +258,11 @@ public class ParamProcessWorker implements DispatchWorker 
{
 }
 
 } catch (final IllegalArgumentException e) {
-s_logger.error("Error initializing command " + 
cmd.getCommandName() + ", field " + field.getName() + " is not accessible.");
 throw new CloudRuntimeException("Internal error initializing 
parameters for command " + cmd.getCommandName() + " [field " + field.getName() +
-" is not accessible]");
+" is not accessible]", e);
 } catch (final IllegalAccessException e) {
-s_logger.error("Error initializing command " + 
cmd.getCommandName() + ", field " + field.getName() + " is not accessible.");
 throw new CloudRuntimeException("Internal error initializing 
parameters for command " + cmd.getCommandName() + " [field " + field.getName() +
-" is not accessible]");
+" is not accessible]", e);
 }
 
 }

-- 
To stop receiving notification emails like this one, please contact
raf...@apache.org.

[GitHub] rafaelweingartner closed pull request #2510: CLOUDSTACK-10334: Fix inadequate information for handling catch clauses

[GitBox]

rafaelweingartner closed pull request #2510: CLOUDSTACK-10334: Fix inadequate 
information for handling catch clauses
URL: https://github.com/apache/cloudstack/pull/2510
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/server/src/main/java/com/cloud/api/dispatch/ParamProcessWorker.java 
b/server/src/main/java/com/cloud/api/dispatch/ParamProcessWorker.java
index feefaabc551..f030209c9a5 100644
--- a/server/src/main/java/com/cloud/api/dispatch/ParamProcessWorker.java
+++ b/server/src/main/java/com/cloud/api/dispatch/ParamProcessWorker.java
@@ -258,13 +258,11 @@ public void processParameters(final BaseCmd cmd, final 
Map params) {
 }
 
 } catch (final IllegalArgumentException e) {
-s_logger.error("Error initializing command " + 
cmd.getCommandName() + ", field " + field.getName() + " is not accessible.");
 throw new CloudRuntimeException("Internal error initializing 
parameters for command " + cmd.getCommandName() + " [field " + field.getName() +
-" is not accessible]");
+" is not accessible]", e);
 } catch (final IllegalAccessException e) {
-s_logger.error("Error initializing command " + 
cmd.getCommandName() + ", field " + field.getName() + " is not accessible.");
 throw new CloudRuntimeException("Internal error initializing 
parameters for command " + cmd.getCommandName() + " [field " + field.getName() +
-" is not accessible]");
+" is not accessible]", e);
 }
 
 }


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rafaelweingartner commented on issue #2510: CLOUDSTACK-10334: Fix inadequate information for handling catch clauses

[GitBox]

rafaelweingartner commented on issue #2510: CLOUDSTACK-10334: Fix inadequate 
information for handling catch clauses
URL: https://github.com/apache/cloudstack/pull/2510#issuecomment-376831626
 
 
   @DaanHoogland I am ok too. I will merge then  


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rafaelweingartner commented on issue #2510: CLOUDSTACK-10334: Fix inadequate information for handling catch clauses

[GitBox]

rafaelweingartner commented on issue #2510: CLOUDSTACK-10334: Fix inadequate 
information for handling catch clauses
URL: https://github.com/apache/cloudstack/pull/2510#issuecomment-376831626
 
 
   @rhtyd I am ok too. I will merge then  


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rafaelweingartner commented on issue #2514: Problem with NAT configuration and VMs not accessing each other via public IPs

[GitBox]

rafaelweingartner commented on issue #2514: Problem with NAT configuration and 
VMs not accessing each other via public IPs
URL: https://github.com/apache/cloudstack/pull/2514#issuecomment-376837801
 
 
   To tell you the truth I do not understand how you solve this in the routing 
table. I was your PR, and it is merged in 4.9.3.0, 4.11, and master, and still 
the problem persists.
   
   I am solving in the `iptables`, making it consistent with other 
configurations that we already have for different scenarios. This (like the one 
I am introducing here) solution was already used when we "attach"/direct link a 
public IP to a VM. Check `configure.py` at lines 816-836.
   
   The packet is coming from ETH2 (internal interface) to one of our public 
IPs, we need to execute NAT as well from packets from ETH2 if we want VMs 
accessing each other via their public IPs.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rafaelweingartner commented on issue #2514: Problem with NAT configuration and VMs not accessing each other via public IPs

[GitBox]

rafaelweingartner commented on issue #2514: Problem with NAT configuration and 
VMs not accessing each other via public IPs
URL: https://github.com/apache/cloudstack/pull/2514#issuecomment-376837801
 
 
   To tell you the truth, I do not understand how you solve this in the routing 
table. I saw your PR, and it is merged in 4.9.3.0, 4.11, and master, and still 
the problem persists.
   
   I am solving in the `iptables`, making it consistent with other 
configurations that we already have for different scenarios. This (like the one 
I am introducing here) solution was already used when we "attach"/direct link a 
public IP to a VM. Check `configure.py` at lines 816-836.
   
   The packet is coming from ETH2 (internal interface) to one of our public 
IPs, we need to execute NAT as well from packets from ETH2 if we want VMs 
accessing each other via their public IPs.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rafaelweingartner commented on issue #2514: Problem with NAT configuration and VMs not accessing each other via public IPs

[GitBox]

rafaelweingartner commented on issue #2514: Problem with NAT configuration and 
VMs not accessing each other via public IPs
URL: https://github.com/apache/cloudstack/pull/2514#issuecomment-376837801
 
 
   To tell you the truth, I do not understand how you solve this in the routing 
table. I was your PR, and it is merged in 4.9.3.0, 4.11, and master, and still 
the problem persists.
   
   I am solving in the `iptables`, making it consistent with other 
configurations that we already have for different scenarios. This (like the one 
I am introducing here) solution was already used when we "attach"/direct link a 
public IP to a VM. Check `configure.py` at lines 816-836.
   
   The packet is coming from ETH2 (internal interface) to one of our public 
IPs, we need to execute NAT as well from packets from ETH2 if we want VMs 
accessing each other via their public IPs.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] ernjvr commented on issue #2449: CLOUDSTACK-10278 idempotent column addition

[GitBox]

ernjvr commented on issue #2449: CLOUDSTACK-10278 idempotent column addition
URL: https://github.com/apache/cloudstack/pull/2449#issuecomment-376842088
 
 
   Upgrade Test Result: I installed a version 4.6 environment with some of the 
DB changes that were already in 4.11, created a few networks: isolated, shared, 
vpc and created vms on each. I proceeded with the upgrade to 4.11 using this PR 
code. After the upgrade i had to add missing braces to some environment 
variables in the /usr/lib/systemd/system/cloudstack-management.service file and 
also had to configure the /etc/default/cloudstack-management file with the 
correct 4.11 environment variables. After starting the management server and 
running the migrate-dynamicroles.py I was able to log in to the UI and observe 
that the vms were back up and running. A successful upgrade without any DB 
issues.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2512: Only use the host if its Resource State is Enabled.

[GitBox]

blueorangutan commented on issue #2512: Only use the host if its Resource State 
is Enabled.
URL: https://github.com/apache/cloudstack/pull/2512#issuecomment-376849406
 
 
   @DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you 
posted as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] DaanHoogland commented on issue #2512: Only use the host if its Resource State is Enabled.

[GitBox]

DaanHoogland commented on issue #2512: Only use the host if its Resource State 
is Enabled.
URL: https://github.com/apache/cloudstack/pull/2512#issuecomment-376849160
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] DaanHoogland commented on issue #2510: CLOUDSTACK-10334: Fix inadequate information for handling catch clauses

[GitBox]

DaanHoogland commented on issue #2510: CLOUDSTACK-10334: Fix inadequate 
information for handling catch clauses
URL: https://github.com/apache/cloudstack/pull/2510#issuecomment-376804536
 
 
   not sure @rafaelweingartner , should we?
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2510: CLOUDSTACK-10334: Fix inadequate information for handling catch clauses

[GitBox]

blueorangutan commented on issue #2510: CLOUDSTACK-10334: Fix inadequate 
information for handling catch clauses
URL: https://github.com/apache/cloudstack/pull/2510#issuecomment-376812696
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1846


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2436: Enable restart of redundant VPCs implementing Rolling Restart

[GitBox]

rhtyd commented on issue #2436: Enable restart of redundant VPCs implementing 
Rolling Restart
URL: https://github.com/apache/cloudstack/pull/2436#issuecomment-376819867
 
 
   I'll move the changes to https://github.com/apache/cloudstack/pull/2508. 
Closing this.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd closed pull request #2436: Enable restart of redundant VPCs implementing Rolling Restart

[GitBox]

rhtyd closed pull request #2436: Enable restart of redundant VPCs implementing 
Rolling Restart
URL: https://github.com/apache/cloudstack/pull/2436
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/server/src/com/cloud/network/NetworkServiceImpl.java 
b/server/src/com/cloud/network/NetworkServiceImpl.java
index 93f73d20a5f..49e86892f7c 100644
--- a/server/src/com/cloud/network/NetworkServiceImpl.java
+++ b/server/src/com/cloud/network/NetworkServiceImpl.java
@@ -1861,15 +1861,6 @@ public boolean restartNetwork(RestartNetworkCmd cmd, 
boolean cleanup) throws Con
 + Network.State.Setup);
 }
 
-if (network.getBroadcastDomainType() == BroadcastDomainType.Lswitch) {
-/**
- * Unable to restart these networks now.
- * TODO Restarting a SDN based network requires updating the nics 
and the configuration
- * in the controller. This requires a non-trivial rewrite of the 
restart procedure.
- */
-throw new InvalidParameterException("Unable to restart a running 
SDN network.");
-}
-
 _accountMgr.checkAccess(callerAccount, null, true, network);
 
 boolean success = _networkMgr.restartNetwork(networkId, callerAccount, 
callerUser, cleanup);
diff --git a/server/src/com/cloud/network/vpc/VpcManagerImpl.java 
b/server/src/com/cloud/network/vpc/VpcManagerImpl.java
index ab6441ac5b7..be9ad5a0ba8 100644
--- a/server/src/com/cloud/network/vpc/VpcManagerImpl.java
+++ b/server/src/com/cloud/network/vpc/VpcManagerImpl.java
@@ -37,6 +37,7 @@
 import javax.inject.Inject;
 import javax.naming.ConfigurationException;
 
+import com.cloud.vm.dao.DomainRouterDao;
 import org.apache.commons.collections.CollectionUtils;
 import org.apache.log4j.Logger;
 
@@ -88,6 +89,8 @@
 import com.cloud.network.element.NetworkElement;
 import com.cloud.network.element.StaticNatServiceProvider;
 import com.cloud.network.element.VpcProvider;
+import com.cloud.network.router.VirtualRouter;
+import com.cloud.network.router.VpcVirtualNetworkApplianceManager;
 import com.cloud.network.vpc.VpcOffering.State;
 import com.cloud.network.vpc.dao.NetworkACLDao;
 import com.cloud.network.vpc.dao.PrivateIpDao;
@@ -132,8 +135,10 @@
 import com.cloud.utils.exception.CloudRuntimeException;
 import com.cloud.utils.exception.ExceptionUtil;
 import com.cloud.utils.net.NetUtils;
+import com.cloud.vm.DomainRouterVO;
 import com.cloud.vm.ReservationContext;
 import com.cloud.vm.ReservationContextImpl;
+import com.cloud.vm.VirtualMachine;
 
 public class VpcManagerImpl extends ManagerBase implements VpcManager, 
VpcProvisioningService, VpcService {
 private static final Logger s_logger = 
Logger.getLogger(VpcManagerImpl.class);
@@ -196,6 +201,10 @@
 NetworkACLManager _networkAclMgr;
 @Inject
 IpAddressManager _ipAddrMgr;
+@Inject
+VpcVirtualNetworkApplianceManager _routerMgr;
+@Inject
+DomainRouterDao _routerDao;
 
 @Inject
 private VpcPrivateGatewayTransactionCallable vpcTxCallable;
@@ -1482,7 +1491,9 @@ public boolean cleanupVpcResources(final long vpcId, 
final Account caller, final
 public boolean restartVpc(final long vpcId, final boolean cleanUp, final 
boolean makeRedundant) throws ConcurrentOperationException, 
ResourceUnavailableException,
 InsufficientCapacityException {
 
-final Account caller = CallContext.current().getCallingAccount();
+final Account callerAccount = 
CallContext.current().getCallingAccount();
+final User callerUser = 
_accountMgr.getActiveUser(CallContext.current().getCallingUserId());
+final ReservationContext context = new ReservationContextImpl(null, 
null, callerUser, callerAccount);
 
 // Verify input parameters
 final Vpc vpc = getActiveVpc(vpcId);
@@ -1492,7 +1503,7 @@ public boolean restartVpc(final long vpcId, final boolean 
cleanUp, final boolean
 throw ex;
 }
 
-_accountMgr.checkAccess(caller, null, false, vpc);
+_accountMgr.checkAccess(callerAccount, null, false, vpc);
 
 s_logger.debug("Restarting VPC " + vpc);
 boolean restartRequired = false;
@@ -1516,11 +1527,25 @@ public boolean restartVpc(final long vpcId, final 
boolean cleanUp, final boolean
 }
 
 if (forceCleanup) {
-s_logger.debug("Shutting down VPC " + vpc + " as a part of VPC 
restart process");
-if (!shutdownVpc(vpcId)) {
-s_logger.warn("Failed to shutdown vpc as a part of VPC " + 
vpc + " restart process");
-restartRequired = true;
-return false;
+List routers = 
_routerDao.listByVpcId(vpc.getId());
+if (routers != 

[GitHub] rhtyd commented on issue #2412: CLOUDSTACK-9677: Adding storage policy support for swift as secondary…

[GitBox]

rhtyd commented on issue #2412: CLOUDSTACK-9677: Adding storage policy support 
for swift as secondary…
URL: https://github.com/apache/cloudstack/pull/2412#issuecomment-376848209
 
 
   Ping @khos2ow can you advise on testing of this PR against swift? This is 
ready to merge based on 2+lgtms and smoke test results.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2510: CLOUDSTACK-10334: Fix inadequate information for handling catch clauses

[GitBox]

rhtyd commented on issue #2510: CLOUDSTACK-10334: Fix inadequate information 
for handling catch clauses
URL: https://github.com/apache/cloudstack/pull/2510#issuecomment-376806301
 
 
   @DaanHoogland @rafaelweingartner  this is simply a logging change, Travis is 
green. I'm okay merging based on 2+ lgtms and test run by Travis.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2512: Only use the host if its Resource State is Enabled.

[GitBox]

blueorangutan commented on issue #2512: Only use the host if its Resource State 
is Enabled.
URL: https://github.com/apache/cloudstack/pull/2512#issuecomment-376856138
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1847


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] ustcweizhou commented on issue #2514: Problem with NAT configuration and VMs not accessing each other via public IPs

[GitBox]

ustcweizhou commented on issue #2514: Problem with NAT configuration and VMs 
not accessing each other via public IPs
URL: https://github.com/apache/cloudstack/pull/2514#issuecomment-376835719
 
 
   @rafaelweingartner  We faced the same issue before.
   it is fixed by adding some rules in ip route tables.
   
   ```
   $ ip route show table Table_eth1
   throw 10.10.1.0/24  proto static
   throw 10.10.2.0/24  proto static
   ```
   eth1 is public interface
   10.10.1.0/24 and 10.10.2.0/24 are cidr of vpc tiers.
   
   The idea came from the code before 4.7 (systemvm refactoring)
   
https://github.com/apache/cloudstack/blob/4.5/systemvm/patches/debian/config/opt/cloud/bin/ipassoc.sh
   copy_routes_from_main in line 122


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rafaelweingartner commented on issue #2514: Problem with NAT configuration and VMs not accessing each other via public IPs

[GitBox]

rafaelweingartner commented on issue #2514: Problem with NAT configuration and 
VMs not accessing each other via public IPs
URL: https://github.com/apache/cloudstack/pull/2514#issuecomment-376837801
 
 
   To tell you the truth, I do not understand how you solve this in the routing 
table. I saw your PR, and it is merged in 4.9.3.0, 4.11, and master, and still 
the problem persists.
   
   I am solving in the `iptables`, making it consistent with other 
configurations that we already have, but for different scenarios. This solution 
(the one I am introducing here) was already used when we "attach"/"direct 
connect" a public IP to a VM. Check `configure.py` at lines 816-836.
   
   The packet is coming from ETH2 (internal interface) to one of our public 
IPs, we need to execute NAT as well from packets from ETH2 if we want VMs 
accessing each other via their public IPs.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2449: CLOUDSTACK-10278 idempotent column addition

[GitBox]

rhtyd commented on issue #2449: CLOUDSTACK-10278 idempotent column addition
URL: https://github.com/apache/cloudstack/pull/2449#issuecomment-376805263
 
 
   Will re-kick test.
   @blueorangutan test


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] nitin-maharana commented on a change in pull request #2512: Only use the host if its Resource State is Enabled.

[GitBox]

nitin-maharana commented on a change in pull request #2512: Only use the host 
if its Resource State is Enabled.
URL: https://github.com/apache/cloudstack/pull/2512#discussion_r177693341
 
 

 ##
 File path: 
engine/storage/snapshot/src/main/java/org/apache/cloudstack/storage/snapshot/StorageSystemSnapshotStrategy.java
 ##
 @@ -484,7 +483,7 @@ else if (volumeInfo.getFormat() == ImageFormat.OVA || 
volumeInfo.getFormat() ==
 }
 
 SnapshotResult result = null;
-SnapshotInfo snapshotOnPrimary = null;
+SnapshotInfo snapshotOnPrimary;
 
 Review comment:
   @DaanHoogland, My bad, wrong interpretation!! As @mike-tutkowski explained, 
that's redundant.  Thanks!!


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] ernjvr commented on issue #2449: CLOUDSTACK-10278 idempotent column addition

[GitBox]

ernjvr commented on issue #2449: CLOUDSTACK-10278 idempotent column addition
URL: https://github.com/apache/cloudstack/pull/2449#issuecomment-376842088
 
 
   Upgrade Test Result: I installed a version 4.6 environment, created a few 
networks: isolated, shared, vpc and created vms on each. I proceeded with the 
upgrade to 4.11 using this PR code. After the upgrade i had to add missing 
braces to some environment variables in the 
/usr/lib/systemd/system/cloudstack-management.service file and also had to 
configure the /etc/default/cloudstack-management file with the correct 4.11 
environment variables. After starting the management server and running the 
migrate-dynamicroles.py I was able to log in to the UI and observe that the vms 
were back up and running. A successful upgrade.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] DaanHoogland closed pull request #2449: CLOUDSTACK-10278 idempotent column addition

[GitBox]

DaanHoogland closed pull request #2449: CLOUDSTACK-10278 idempotent column 
addition
URL: https://github.com/apache/cloudstack/pull/2449
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/engine/schema/resources/META-INF/db/schema-41000to41100.sql 
b/engine/schema/resources/META-INF/db/schema-41000to41100.sql
index 2e7f9e9fe9c..4dc11d448fc 100644
--- a/engine/schema/resources/META-INF/db/schema-41000to41100.sql
+++ b/engine/schema/resources/META-INF/db/schema-41000to41100.sql
@@ -19,8 +19,54 @@
 -- Schema upgrade from 4.10.0.0 to 4.11.0.0
 --;
 
+--;
+-- Stored procedure to do idempotent column add;
+--;
+DROP PROCEDURE IF EXISTS `cloud`.`IDEMPOTENT_ADD_COLUMN`;
+
+CREATE PROCEDURE `cloud`.`IDEMPOTENT_ADD_COLUMN` (
+   IN in_table_name VARCHAR(200)
+, IN in_column_name VARCHAR(200)
+, IN in_column_definition VARCHAR(1000)
+)
+BEGIN
+
+DECLARE CONTINUE HANDLER FOR 1060 BEGIN END; SET @ddl = CONCAT('ALTER 
TABLE ', in_table_name); SET @ddl = CONCAT(@ddl, ' ', 'ADD COLUMN') ; SET @ddl 
= CONCAT(@ddl, ' ', in_column_name); SET @ddl = CONCAT(@ddl, ' ', 
in_column_definition); PREPARE stmt FROM @ddl; EXECUTE stmt; DEALLOCATE PREPARE 
stmt; END;
+
+DROP PROCEDURE IF EXISTS `cloud`.`IDEMPOTENT_DROP_FOREIGN_KEY`;
+
+CREATE PROCEDURE `cloud`.`IDEMPOTENT_DROP_FOREIGN_KEY` (
+   IN in_table_name VARCHAR(200)
+, IN in_foreign_key_name VARCHAR(200)
+)
+BEGIN
+
+DECLARE CONTINUE HANDLER FOR 1091 BEGIN END; SET @ddl = CONCAT('ALTER 
TABLE ', in_table_name); SET @ddl = CONCAT(@ddl, ' ', ' DROP FOREIGN KEY '); 
SET @ddl = CONCAT(@ddl, ' ', in_foreign_key_name); PREPARE stmt FROM @ddl; 
EXECUTE stmt; DEALLOCATE PREPARE stmt; END;
+
+DROP PROCEDURE IF EXISTS `cloud`.`IDEMPOTENT_DROP_INDEX`;
+
+CREATE PROCEDURE `cloud`.`IDEMPOTENT_DROP_INDEX` (
+   IN in_index_name VARCHAR(200)
+, IN in_table_name VARCHAR(200)
+)
+BEGIN
+
+DECLARE CONTINUE HANDLER FOR 1091 BEGIN END; SET @ddl = CONCAT('DROP INDEX 
', in_index_name); SET @ddl = CONCAT(@ddl, ' ', ' ON ') ; SET @ddl = 
CONCAT(@ddl, ' ', in_table_name); PREPARE stmt FROM @ddl; EXECUTE stmt; 
DEALLOCATE PREPARE stmt; END;
+
+DROP PROCEDURE IF EXISTS `cloud`.`IDEMPOTENT_CREATE_UNIQUE_INDEX`;
+
+CREATE PROCEDURE `cloud`.`IDEMPOTENT_CREATE_UNIQUE_INDEX` (
+   IN in_index_name VARCHAR(200)
+, IN in_table_name VARCHAR(200)
+, IN in_index_definition VARCHAR(1000)
+)
+BEGIN
+
+DECLARE CONTINUE HANDLER FOR 1061 BEGIN END; SET @ddl = CONCAT('CREATE 
UNIQUE INDEX ', in_index_name); SET @ddl = CONCAT(@ddl, ' ', ' ON ') ; SET @ddl 
= CONCAT(@ddl, ' ', in_table_name); SET @ddl = CONCAT(@ddl, ' ', 
in_index_definition); PREPARE stmt FROM @ddl; EXECUTE stmt; DEALLOCATE PREPARE 
stmt; END;
+
 -- Add For VPC flag
-ALTER TABLE cloud.network_offerings ADD COLUMN for_vpc INT(1) NOT NULL DEFAULT 
0;
+CALL `cloud`.`IDEMPOTENT_ADD_COLUMN`('cloud.network_offerings','for_vpc', 
'INT(1) NOT NULL DEFAULT 0');
+
 UPDATE cloud.network_offerings o
 SET for_vpc = 1
 where
@@ -88,7 +134,7 @@ CREATE TABLE IF NOT EXISTS `cloud`.`annotations` (
 ) ENGINE=InnoDB DEFAULT CHARSET=utf8;
 
 DROP VIEW IF EXISTS `cloud`.`last_annotation_view`;
-CREATE VIEW `last_annotation_view` AS
+CREATE VIEW `cloud`.`last_annotation_view` AS
 SELECT
 `annotations`.`uuid` AS `uuid`,
 `annotations`.`annotation` AS `annotation`,
@@ -405,21 +451,18 @@ UPDATE `cloud`.`monitoring_services` SET 
pidfile="/var/run/apache2/apache2.pid"
 UPDATE `cloud`.`vm_template` SET guest_os_id=99 WHERE id=8;
 
 -- Network External Ids
-ALTER TABLE `cloud`.`networks` ADD `external_id` varchar(255);
+CALL `cloud`.`IDEMPOTENT_ADD_COLUMN`('cloud.networks','external_id', 
'varchar(255)');
 
 -- Separate Subnet for CPVM and SSVM (system vms)
-ALTER TABLE `cloud`.`op_dc_ip_address_alloc`
-ADD COLUMN `forsystemvms` TINYINT(1) NOT NULL DEFAULT '0' COMMENT 'Indicates 
if IP is dedicated for CPVM or SSVM';
+CALL 
`cloud`.`IDEMPOTENT_ADD_COLUMN`('cloud.op_dc_ip_address_alloc','forsystemvms', 
'TINYINT(1) NOT NULL DEFAULT 0 COMMENT ''Indicates if IP is dedicated for CPVM 
or SSVM'' ');
 
-ALTER TABLE `cloud`.`op_dc_ip_address_alloc`
-ADD COLUMN `vlan` INT(10) UNSIGNED NULL COMMENT 'Vlan the management network 
range is on';
+CALL `cloud`.`IDEMPOTENT_ADD_COLUMN`('cloud.op_dc_ip_address_alloc','vlan', 
'INT(10) UNSIGNED NULL COMMENT ''Vlan the management network range is on'' ');
 
 -- CLOUDSTACK-4757: Support multidisk OVA
-ALTER TABLE `cloud`.`vm_template` ADD COLUMN `parent_template_id` bigint(20) 
unsigned DEFAULT NULL COMMENT 'If datadisk template, then id of the root 
template this template belongs to';
+CALL `cloud`.`IDEMPOTENT_ADD_COLUMN`('cloud.vm_template','parent_template_id', 
'bigint(20) unsigned DEFAULT NULL COMMENT 

[cloudstack] branch 4.11 updated: CLOUDSTACK-10278 idempotent column addition (#2449)

[dahn]

This is an automated email from the ASF dual-hosted git repository.

dahn pushed a commit to branch 4.11
in repository https://gitbox.apache.org/repos/asf/cloudstack.git


The following commit(s) were added to refs/heads/4.11 by this push:
 new 7647e10  CLOUDSTACK-10278 idempotent column addition (#2449)
7647e10 is described below

commit 7647e104b28a9fd0ee3dbdc7b2fa2db8bd29fb73
Author: ernjvr 
AuthorDate: Wed Mar 28 13:19:08 2018 +0200

CLOUDSTACK-10278 idempotent column addition (#2449)

* CLOUDSTACK-10278 - WIP: need to test this script before create a pull 
request

* CLOUDSTACK-10278 - added more idempotent stored procs and moved all 
lines, that end with a semicolon in existing proc, onto one line because 
com/cloud/utils/db/ScriptRunner.java executes the sql as soon as it reads in 
line with a semicolon delimeter at the end.

* CLOUDSTACK-10278 - changed more sql statements to call idempotent stored 
procs

* CLOUDSTACK-10278 - WIP: need to test this script before create a pull 
request

* CLOUDSTACK-10278 - added more idempotent stored procs and moved all 
lines, that end with a semicolon in existing proc, onto one line because 
com/cloud/utils/db/ScriptRunner.java executes the sql as soon as it reads in 
line with a semicolon delimeter at the end.

* CLOUDSTACK-10278 - changed more sql statements to call idempotent stored 
procs
---
 .../resources/META-INF/db/schema-41000to41100.sql  | 80 +-
 1 file changed, 61 insertions(+), 19 deletions(-)

diff --git a/engine/schema/resources/META-INF/db/schema-41000to41100.sql 
b/engine/schema/resources/META-INF/db/schema-41000to41100.sql
index 2e7f9e9..4dc11d4 100644
--- a/engine/schema/resources/META-INF/db/schema-41000to41100.sql
+++ b/engine/schema/resources/META-INF/db/schema-41000to41100.sql
@@ -19,8 +19,54 @@
 -- Schema upgrade from 4.10.0.0 to 4.11.0.0
 --;
 
+--;
+-- Stored procedure to do idempotent column add;
+--;
+DROP PROCEDURE IF EXISTS `cloud`.`IDEMPOTENT_ADD_COLUMN`;
+
+CREATE PROCEDURE `cloud`.`IDEMPOTENT_ADD_COLUMN` (
+   IN in_table_name VARCHAR(200)
+, IN in_column_name VARCHAR(200)
+, IN in_column_definition VARCHAR(1000)
+)
+BEGIN
+
+DECLARE CONTINUE HANDLER FOR 1060 BEGIN END; SET @ddl = CONCAT('ALTER 
TABLE ', in_table_name); SET @ddl = CONCAT(@ddl, ' ', 'ADD COLUMN') ; SET @ddl 
= CONCAT(@ddl, ' ', in_column_name); SET @ddl = CONCAT(@ddl, ' ', 
in_column_definition); PREPARE stmt FROM @ddl; EXECUTE stmt; DEALLOCATE PREPARE 
stmt; END;
+
+DROP PROCEDURE IF EXISTS `cloud`.`IDEMPOTENT_DROP_FOREIGN_KEY`;
+
+CREATE PROCEDURE `cloud`.`IDEMPOTENT_DROP_FOREIGN_KEY` (
+   IN in_table_name VARCHAR(200)
+, IN in_foreign_key_name VARCHAR(200)
+)
+BEGIN
+
+DECLARE CONTINUE HANDLER FOR 1091 BEGIN END; SET @ddl = CONCAT('ALTER 
TABLE ', in_table_name); SET @ddl = CONCAT(@ddl, ' ', ' DROP FOREIGN KEY '); 
SET @ddl = CONCAT(@ddl, ' ', in_foreign_key_name); PREPARE stmt FROM @ddl; 
EXECUTE stmt; DEALLOCATE PREPARE stmt; END;
+
+DROP PROCEDURE IF EXISTS `cloud`.`IDEMPOTENT_DROP_INDEX`;
+
+CREATE PROCEDURE `cloud`.`IDEMPOTENT_DROP_INDEX` (
+   IN in_index_name VARCHAR(200)
+, IN in_table_name VARCHAR(200)
+)
+BEGIN
+
+DECLARE CONTINUE HANDLER FOR 1091 BEGIN END; SET @ddl = CONCAT('DROP INDEX 
', in_index_name); SET @ddl = CONCAT(@ddl, ' ', ' ON ') ; SET @ddl = 
CONCAT(@ddl, ' ', in_table_name); PREPARE stmt FROM @ddl; EXECUTE stmt; 
DEALLOCATE PREPARE stmt; END;
+
+DROP PROCEDURE IF EXISTS `cloud`.`IDEMPOTENT_CREATE_UNIQUE_INDEX`;
+
+CREATE PROCEDURE `cloud`.`IDEMPOTENT_CREATE_UNIQUE_INDEX` (
+   IN in_index_name VARCHAR(200)
+, IN in_table_name VARCHAR(200)
+, IN in_index_definition VARCHAR(1000)
+)
+BEGIN
+
+DECLARE CONTINUE HANDLER FOR 1061 BEGIN END; SET @ddl = CONCAT('CREATE 
UNIQUE INDEX ', in_index_name); SET @ddl = CONCAT(@ddl, ' ', ' ON ') ; SET @ddl 
= CONCAT(@ddl, ' ', in_table_name); SET @ddl = CONCAT(@ddl, ' ', 
in_index_definition); PREPARE stmt FROM @ddl; EXECUTE stmt; DEALLOCATE PREPARE 
stmt; END;
+
 -- Add For VPC flag
-ALTER TABLE cloud.network_offerings ADD COLUMN for_vpc INT(1) NOT NULL DEFAULT 
0;
+CALL `cloud`.`IDEMPOTENT_ADD_COLUMN`('cloud.network_offerings','for_vpc', 
'INT(1) NOT NULL DEFAULT 0');
+
 UPDATE cloud.network_offerings o
 SET for_vpc = 1
 where
@@ -88,7 +134,7 @@ CREATE TABLE IF NOT EXISTS `cloud`.`annotations` (
 ) ENGINE=InnoDB DEFAULT CHARSET=utf8;
 
 DROP VIEW IF EXISTS `cloud`.`last_annotation_view`;
-CREATE VIEW `last_annotation_view` AS
+CREATE VIEW `cloud`.`last_annotation_view` AS
 SELECT
 `annotations`.`uuid` AS `uuid`,
 `annotations`.`annotation` AS `annotation`,
@@ -405,21 +451,18 @@ UPDATE `cloud`.`monitoring_services` SET 
pidfile="/var/run/apache2/apache2.pid"
 UPDATE `cloud`.`vm_template` SET guest_os_id=99 WHERE id=8;
 
 -- Network External Ids
-ALTER TABLE `cloud`.`networks` ADD `external_id` 

[GitHub] DaanHoogland commented on issue #2449: CLOUDSTACK-10278 idempotent column addition

[GitBox]

DaanHoogland commented on issue #2449: CLOUDSTACK-10278 idempotent column 
addition
URL: https://github.com/apache/cloudstack/pull/2449#issuecomment-376851510
 
 
   merging based on LGTMs and test reports


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] borisstoyanov commented on issue #2505: CLOUDSTACK-10333: Secure Live VM Migration for KVM

[GitBox]

borisstoyanov commented on issue #2505: CLOUDSTACK-10333: Secure Live VM 
Migration for KVM
URL: https://github.com/apache/cloudstack/pull/2505#issuecomment-376871848
 
 
   Maybe this ^^ needs further investigation since I've provisioned the 
certificates on both the hosts and still getting the same error. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2512: Only use the host if its Resource State is Enabled.

[GitBox]

blueorangutan commented on issue #2512: Only use the host if its Resource State 
is Enabled.
URL: https://github.com/apache/cloudstack/pull/2512#issuecomment-376860368
 
 
   @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has 
been kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] borisstoyanov commented on issue #2505: CLOUDSTACK-10333: Secure Live VM Migration for KVM

[GitBox]

borisstoyanov commented on issue #2505: CLOUDSTACK-10333: Secure Live VM 
Migration for KVM
URL: https://github.com/apache/cloudstack/pull/2505#issuecomment-376870609
 
 
   @rhtyd I'm trying to migrate a VM between unsecured hosts and got the 
following exception: 
   ```
   2018-03-28 12:31:52,414 ERROR [c.c.v.VmWorkJobHandlerProxy] 
(Work-Job-Executor-6:ctx-bc927fcc job-38/job-39 ctx-441b0b18) (logid:d8b1d686) 
Invocation exception, caused by: 
com.cloud.utils.exception.CloudRuntimeException: org.libvirt.LibvirtException: 
Cannot get interface MTU on 'breth0-769': No such device
   2018-03-28 12:31:52,415 INFO  [c.c.v.VmWorkJobHandlerProxy] 
(Work-Job-Executor-6:ctx-bc927fcc job-38/job-39 ctx-441b0b18) (logid:d8b1d686) 
Rethrow exception com.cloud.utils.exception.CloudRuntimeException: 
org.libvirt.LibvirtException: Cannot get interface MTU on 'breth0-769': No such 
device
   2018-03-28 12:31:52,415 DEBUG [c.c.v.VmWorkJobDispatcher] 
(Work-Job-Executor-6:ctx-bc927fcc job-38/job-39) (logid:d8b1d686) Done with run 
of VM work job: com.cloud.vm.VmWorkMigrate for VM 3, job origin: 38
   2018-03-28 12:31:52,415 ERROR [c.c.v.VmWorkJobDispatcher] 
(Work-Job-Executor-6:ctx-bc927fcc job-38/job-39) (logid:d8b1d686) Unable to 
complete AsyncJobVO {id:39, userId: 2, accountId: 2, instanceType: null, 
instanceId: null, cmd: com.cloud.vm.VmWorkMigrate, cmdInfo: 
rO0ABXNyABpjb20uY2xvdWQudm0uVm1Xb3JrTWlncmF0ZRdxQXtPtzYqAgAGSgAJc3JjSG9zdElkTAAJY2x1c3RlcklkdAAQTGphdmEvbGFuZy9Mb25nO0wABmhvc3RJZHEAfgABTAAFcG9kSWRxAH4AAUwAB3N0b3JhZ2V0AA9MamF2YS91dGlsL01hcDtMAAZ6b25lSWRxAH4AAXhyABNjb20uY2xvdWQudm0uVm1Xb3Jrn5m2VvAlZ2sCAARKAAlhY2NvdW50SWRKAAZ1c2VySWRKAAR2bUlkTAALaGFuZGxlck5hbWV0ABJMamF2YS9sYW5nL1N0cmluZzt4cAACAAIAA3QAGVZpcnR1YWxNYWNoaW5lTWFuYWdlckltcGwAAXNyAA5qYXZhLmxhbmcuTG9uZzuL5JDMjyPfAgABSgAFdmFsdWV4cgAQamF2YS5sYW5nLk51bWJlcoaslR0LlOCLAgAAeHAAAXNxAH4ABwACcQB-AAlwcQB-AAk,
 cmdVersion: 0, status: IN_PROGRESS, processStatus: 0, resultCode: 0, result: 
null, initMsid: 6653541943041, completeMsid: null, lastUpdated: null, 
lastPolled: null, created: Wed Mar 28 12:31:50 UTC 2018}, job origin:38
   com.cloud.utils.exception.CloudRuntimeException: 
org.libvirt.LibvirtException: Cannot get interface MTU on 'breth0-769': No such 
device
   ```
   I've made the hosts unsecured by deleting the executing the 
cloudstack-setup-agent script without the -s option. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2505: CLOUDSTACK-10333: Secure Live VM Migration for KVM

[GitBox]

blueorangutan commented on issue #2505: CLOUDSTACK-10333: Secure Live VM 
Migration for KVM
URL: https://github.com/apache/cloudstack/pull/2505#issuecomment-376870877
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] ernjvr commented on issue #2490: Create database upgrade from 4.11.0.0 to 4.11.1.0 & VMWare version to OS mappings

[GitBox]

ernjvr commented on issue #2490: Create database upgrade from 4.11.0.0 to 
4.11.1.0 & VMWare version to OS mappings
URL: https://github.com/apache/cloudstack/pull/2490#issuecomment-376858228
 
 
   Upgrade Test Result: Created an environment to install a 4.11 version using 
this PR code. After the install, I verified in the   
/var/log/cloudstack/management/management-server.log file that the 
Upgrade41100to41110 script did run. Then logged into mysql and ran a SQL query 
to sample the data to verify that the VMWare version-to-OS mappings are 
correct. The sample data is correct.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2506: CLOUDSTACK-10341: Reduce systemvmtemplate size, install nftables

[GitBox]

blueorangutan commented on issue #2506: CLOUDSTACK-10341: Reduce 
systemvmtemplate size, install nftables
URL: https://github.com/apache/cloudstack/pull/2506#issuecomment-376859587
 
 
   Trillian test result (tid-2428)
   Environment: xenserver-65sp1 (x2), Advanced Networking with Mgmt server 6
   Total time taken: 92895 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2506-t2428-xenserver-65sp1.zip
   Intermitten failure detected: /marvin/tests/smoke/test_network.py
   Intermitten failure detected: /marvin/tests/smoke/test_routers.py
   Intermitten failure detected: /marvin/tests/smoke/test_service_offerings.py
   Smoke tests completed. 65 look OK, 2 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_04_restart_network_wo_cleanup | `Failure` | 5.03 | test_routers.py
   test_09_reboot_router | `Error` | 178.95 | test_routers.py
   ContextSuite context=TestCpuCapServiceOfferings>:teardown | `Error` | 0.00 | 
test_service_offerings.py
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] DaanHoogland commented on issue #2490: Create database upgrade from 4.11.0.0 to 4.11.1.0 & VMWare version to OS mappings

[GitBox]

DaanHoogland commented on issue #2490: Create database upgrade from 4.11.0.0 to 
4.11.1.0 & VMWare version to OS mappings
URL: https://github.com/apache/cloudstack/pull/2490#issuecomment-376860152
 
 
   @nitin-maharana @nvazquez @rhtyd can we merge this?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] DaanHoogland commented on issue #2512: Only use the host if its Resource State is Enabled.

[GitBox]

DaanHoogland commented on issue #2512: Only use the host if its Resource State 
is Enabled.
URL: https://github.com/apache/cloudstack/pull/2512#issuecomment-376860281
 
 
   @blueorangutan test


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] borisstoyanov commented on issue #2505: CLOUDSTACK-10333: Secure Live VM Migration for KVM

[GitBox]

borisstoyanov commented on issue #2505: CLOUDSTACK-10333: Secure Live VM 
Migration for KVM
URL: https://github.com/apache/cloudstack/pull/2505#issuecomment-376870609
 
 
   @rhtyd I'm trying to migrate a VM between unsecured hosts and got the 
following exception: 
   ```
   2018-03-28 12:31:52,414 ERROR [c.c.v.VmWorkJobHandlerProxy] 
(Work-Job-Executor-6:ctx-bc927fcc job-38/job-39 ctx-441b0b18) (logid:d8b1d686) 
Invocation exception, caused by: 
com.cloud.utils.exception.CloudRuntimeException: org.libvirt.LibvirtException: 
Cannot get interface MTU on 'breth0-769': No such device
   2018-03-28 12:31:52,415 INFO  [c.c.v.VmWorkJobHandlerProxy] 
(Work-Job-Executor-6:ctx-bc927fcc job-38/job-39 ctx-441b0b18) (logid:d8b1d686) 
Rethrow exception com.cloud.utils.exception.CloudRuntimeException: 
org.libvirt.LibvirtException: Cannot get interface MTU on 'breth0-769': No such 
device
   2018-03-28 12:31:52,415 DEBUG [c.c.v.VmWorkJobDispatcher] 
(Work-Job-Executor-6:ctx-bc927fcc job-38/job-39) (logid:d8b1d686) Done with run 
of VM work job: com.cloud.vm.VmWorkMigrate for VM 3, job origin: 38
   2018-03-28 12:31:52,415 ERROR [c.c.v.VmWorkJobDispatcher] 
(Work-Job-Executor-6:ctx-bc927fcc job-38/job-39) (logid:d8b1d686) Unable to 
complete AsyncJobVO {id:39, userId: 2, accountId: 2, instanceType: null, 
instanceId: null, cmd: com.cloud.vm.VmWorkMigrate, cmdInfo: 
rO0ABXNyABpjb20uY2xvdWQudm0uVm1Xb3JrTWlncmF0ZRdxQXtPtzYqAgAGSgAJc3JjSG9zdElkTAAJY2x1c3RlcklkdAAQTGphdmEvbGFuZy9Mb25nO0wABmhvc3RJZHEAfgABTAAFcG9kSWRxAH4AAUwAB3N0b3JhZ2V0AA9MamF2YS91dGlsL01hcDtMAAZ6b25lSWRxAH4AAXhyABNjb20uY2xvdWQudm0uVm1Xb3Jrn5m2VvAlZ2sCAARKAAlhY2NvdW50SWRKAAZ1c2VySWRKAAR2bUlkTAALaGFuZGxlck5hbWV0ABJMamF2YS9sYW5nL1N0cmluZzt4cAACAAIAA3QAGVZpcnR1YWxNYWNoaW5lTWFuYWdlckltcGwAAXNyAA5qYXZhLmxhbmcuTG9uZzuL5JDMjyPfAgABSgAFdmFsdWV4cgAQamF2YS5sYW5nLk51bWJlcoaslR0LlOCLAgAAeHAAAXNxAH4ABwACcQB-AAlwcQB-AAk,
 cmdVersion: 0, status: IN_PROGRESS, processStatus: 0, resultCode: 0, result: 
null, initMsid: 6653541943041, completeMsid: null, lastUpdated: null, 
lastPolled: null, created: Wed Mar 28 12:31:50 UTC 2018}, job origin:38
   com.cloud.utils.exception.CloudRuntimeException: 
org.libvirt.LibvirtException: Cannot get interface MTU on 'breth0-769': No such 
device
   ```
   I've made the hosts unsecured by deleting the executing the 
cloudstack-setup-agent script without the -s option. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2505: CLOUDSTACK-10333: Secure Live VM Migration for KVM

[GitBox]

blueorangutan commented on issue #2505: CLOUDSTACK-10333: Secure Live VM 
Migration for KVM
URL: https://github.com/apache/cloudstack/pull/2505#issuecomment-376878832
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1848


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2462: [CLOUDSTACK-10301] Allow updating the network ACL list name and Description

[GitBox]

blueorangutan commented on issue #2462: [CLOUDSTACK-10301] Allow updating the 
network ACL list name and Description
URL: https://github.com/apache/cloudstack/pull/2462#issuecomment-376969129
 
 
   @borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has 
been kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] nvazquez commented on issue #2490: Create database upgrade from 4.11.0.0 to 4.11.1.0 & VMWare version to OS mappings

[GitBox]

nvazquez commented on issue #2490: Create database upgrade from 4.11.0.0 to 
4.11.1.0 & VMWare version to OS mappings
URL: https://github.com/apache/cloudstack/pull/2490#issuecomment-376977574
 
 
   Sorry for the delay @ernjvr @rhtyd @DaanHoogland. I've examined CPU cap 
failure and found out that test was marked as successfull even though it ran 
for 0s, which lead to error as '_cleanup' variable wasn't set: 
   
   
   2018-03-21 15:38:27,715 - DEBUG - STARTED : TC: 
test_01_service_offering_cpu_limit_use :::
   2018-03-21 15:38:27,715 - DEBUG - TestCaseName: 
test_01_service_offering_cpu_limit_use; Time Taken: 0 Seconds; StartTime: Wed 
Mar 21 15:38:27 2018; EndTime: Wed Mar 21 15:38:27 2018; Result: SUCCESS
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] borisstoyanov commented on issue #2462: [CLOUDSTACK-10301] Allow updating the network ACL list name and Description

[GitBox]

borisstoyanov commented on issue #2462: [CLOUDSTACK-10301] Allow updating the 
network ACL list name and Description
URL: https://github.com/apache/cloudstack/pull/2462#issuecomment-376969001
 
 
   sure @rafaelweingartner 
   @blueorangutan test


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] borisstoyanov commented on issue #2492: Fix the name of the column used to hold IPv4 range in 'vlan' table.

[GitBox]

borisstoyanov commented on issue #2492: Fix the name of the column used to hold 
IPv4 range in 'vlan' table.
URL: https://github.com/apache/cloudstack/pull/2492#issuecomment-376968757
 
 
   These errors aren't reported frequently.. but I don't think they're 
related... don't see any reason to.. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2511: [CLOUDSTACK-10344] bug when moving ACL rules (change order with drag and drop)

[GitBox]

blueorangutan commented on issue #2511: [CLOUDSTACK-10344] bug when moving ACL 
rules (change order with drag and drop)
URL: https://github.com/apache/cloudstack/pull/2511#issuecomment-377005467
 
 
   Trillian test result (tid-2430)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 108750 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2511-t2430-kvm-centos7.zip
   Intermitten failure detected: /marvin/tests/smoke/test_certauthority_root.py
   Intermitten failure detected: 
/marvin/tests/smoke/test_deploy_virtio_scsi_vm.py
   Intermitten failure detected: /marvin/tests/smoke/test_primary_storage.py
   Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
   Intermitten failure detected: /marvin/tests/smoke/test_routers.py
   Intermitten failure detected: /marvin/tests/smoke/test_snapshots.py
   Intermitten failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
   Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Intermitten failure detected: /marvin/tests/smoke/test_vpc_vpn.py
   Intermitten failure detected: /marvin/tests/smoke/test_host_maintenance.py
   Intermitten failure detected: /marvin/tests/smoke/test_hostha_kvm.py
   Smoke tests completed. 59 look OK, 8 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_01_add_primary_storage_disabled_host | `Error` | 1.16 | 
test_primary_storage.py
   test_01_primary_storage_nfs | `Error` | 0.25 | test_primary_storage.py
   ContextSuite context=TestStorageTags>:setup | `Error` | 0.42 | 
test_primary_storage.py
   test_02_vpc_privategw_static_routes | `Failure` | 260.08 | 
test_privategw_acl.py
   test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 273.46 | 
test_privategw_acl.py
   test_04_restart_network_wo_cleanup | `Failure` | 4.38 | test_routers.py
   test_02_list_snapshots_with_removed_data_store | `Error` | 1.25 | 
test_snapshots.py
   test_08_migrate_vm | `Error` | 23.71 | test_vm_life_cycle.py
   test_04_rvpc_network_garbage_collector_nics | `Failure` | 613.18 | 
test_vpc_redundant.py
   test_01_cancel_host_maintenace_with_no_migration_jobs | `Failure` | 6.67 | 
test_host_maintenance.py
   test_02_cancel_host_maintenace_with_migration_jobs | `Error` | 2.66 | 
test_host_maintenance.py
   test_hostha_enable_ha_when_host_in_maintenance | `Error` | 2.88 | 
test_hostha_kvm.py
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2401: [CLOUDSTACK-10226] CloudStack is not importing Local storage properly

[GitBox]

blueorangutan commented on issue #2401: [CLOUDSTACK-10226] CloudStack is not 
importing Local storage properly
URL: https://github.com/apache/cloudstack/pull/2401#issuecomment-377066408
 
 
   Trillian test result (tid-2436)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 22786 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2401-t2436-kvm-centos7.zip
   Intermitten failure detected: /marvin/tests/smoke/test_certauthority_root.py
   Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Intermitten failure detected: /marvin/tests/smoke/test_vpc_vpn.py
   Intermitten failure detected: /marvin/tests/smoke/test_host_maintenance.py
   Intermitten failure detected: /marvin/tests/smoke/test_hostha_kvm.py
   Smoke tests completed. 66 look OK, 1 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_04_rvpc_network_garbage_collector_nics | `Failure` | 452.86 | 
test_vpc_redundant.py
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rafaelweingartner commented on issue #2401: [CLOUDSTACK-10226] CloudStack is not importing Local storage properly

[GitBox]

rafaelweingartner commented on issue #2401: [CLOUDSTACK-10226] CloudStack is 
not importing Local storage properly
URL: https://github.com/apache/cloudstack/pull/2401#issuecomment-377066722
 
 
   @DaanHoogland I checked this last log result. Can I consider that the tests 
is successful then?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2505: CLOUDSTACK-10333: Secure Live VM Migration for KVM

[GitBox]

blueorangutan commented on issue #2505: CLOUDSTACK-10333: Secure Live VM 
Migration for KVM
URL: https://github.com/apache/cloudstack/pull/2505#issuecomment-377036238
 
 
   Trillian test result (tid-2427)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 126331 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2505-t2427-kvm-centos7.zip
   Intermitten failure detected: 
/marvin/tests/smoke/test_deploy_virtio_scsi_vm.py
   Intermitten failure detected: /marvin/tests/smoke/test_internal_lb.py
   Intermitten failure detected: /marvin/tests/smoke/test_public_ip_range.py
   Intermitten failure detected: /marvin/tests/smoke/test_routers.py
   Intermitten failure detected: /marvin/tests/smoke/test_templates.py
   Intermitten failure detected: /marvin/tests/smoke/test_usage.py
   Intermitten failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
   Intermitten failure detected: /marvin/tests/smoke/test_volumes.py
   Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Intermitten failure detected: /marvin/tests/smoke/test_hostha_kvm.py
   Smoke tests completed. 60 look OK, 7 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_04_restart_network_wo_cleanup | `Failure` | 4.25 | test_routers.py
   test_04_extract_template | `Failure` | 128.35 | test_templates.py
   ContextSuite context=TestISOUsage>:setup | `Error` | 0.00 | test_usage.py
   test_01_secured_vm_migration | `Failure` | 934.74 | test_vm_life_cycle.py
   test_02_not_secured_vm_migration | `Error` | 0.22 | test_vm_life_cycle.py
   test_03_secured_to_nonsecured_vm_migration | `Error` | 1.26 | 
test_vm_life_cycle.py
   test_04_nonsecured_to_secured_vm_migration | `Error` | 1.26 | 
test_vm_life_cycle.py
   test_06_download_detached_volume | `Failure` | 143.42 | test_volumes.py
   test_04_rvpc_network_garbage_collector_nics | `Failure` | 505.57 | 
test_vpc_redundant.py
   test_hostha_enable_ha_when_host_in_maintenance | `Error` | 2.24 | 
test_hostha_kvm.py
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rafaelweingartner commented on issue #2401: [CLOUDSTACK-10226] CloudStack is not importing Local storage properly

[GitBox]

rafaelweingartner commented on issue #2401: [CLOUDSTACK-10226] CloudStack is 
not importing Local storage properly
URL: https://github.com/apache/cloudstack/pull/2401#issuecomment-376947269
 
 
   I checked the logs. The problems did not seem to be related to the PR.
   However, it is always good to have the feedback of an expert ;)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2449: CLOUDSTACK-10278 idempotent column addition

[GitBox]

blueorangutan commented on issue #2449: CLOUDSTACK-10278 idempotent column 
addition
URL: https://github.com/apache/cloudstack/pull/2449#issuecomment-376805440
 
 
   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been 
kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] DaanHoogland commented on issue #2401: [CLOUDSTACK-10226] CloudStack is not importing Local storage properly

[GitBox]

DaanHoogland commented on issue #2401: [CLOUDSTACK-10226] CloudStack is not 
importing Local storage properly
URL: https://github.com/apache/cloudstack/pull/2401#issuecomment-376946409
 
 
   I think it is @rafaelweingartner let me rekick anyway, you can download the 
logs and examine them.
   @blueorangutan test


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rafaelweingartner commented on issue #2511: [CLOUDSTACK-10344] bug when moving ACL rules (change order with drag and drop)

[GitBox]

rafaelweingartner commented on issue #2511: [CLOUDSTACK-10344] bug when moving 
ACL rules (change order with drag and drop)
URL: https://github.com/apache/cloudstack/pull/2511#issuecomment-376940534
 
 
   @nitin-maharana thanks for the review. Do you approve the PR?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rafaelweingartner commented on issue #2496: [CLOUDSTACK-10332] Users are not able to change/edit the protocol of an ACL rule

[GitBox]

rafaelweingartner commented on issue #2496: [CLOUDSTACK-10332] Users are not 
able to change/edit the protocol of an ACL rule 
URL: https://github.com/apache/cloudstack/pull/2496#issuecomment-376940834
 
 
   @borisstoyanov thanks!
   So, are you ok with this PR?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rafaelweingartner commented on issue #2492: Fix the name of the column used to hold IPv4 range in 'vlan' table.

[GitBox]

rafaelweingartner commented on issue #2492: Fix the name of the column used to 
hold IPv4 range in 'vlan' table.
URL: https://github.com/apache/cloudstack/pull/2492#issuecomment-376941144
 
 
   @borisstoyanov are these errors intermittent ones?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2449: CLOUDSTACK-10278 idempotent column addition

[GitBox]

blueorangutan commented on issue #2449: CLOUDSTACK-10278 idempotent column 
addition
URL: https://github.com/apache/cloudstack/pull/2449#issuecomment-376941687
 
 
   Trillian test result (tid-2429)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 106423 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2449-t2429-kvm-centos7.zip
   Intermitten failure detected: /marvin/tests/smoke/test_public_ip_range.py
   Intermitten failure detected: /marvin/tests/smoke/test_routers.py
   Intermitten failure detected: /marvin/tests/smoke/test_templates.py
   Intermitten failure detected: /marvin/tests/smoke/test_usage.py
   Intermitten failure detected: /marvin/tests/smoke/test_volumes.py
   Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Intermitten failure detected: /marvin/tests/smoke/test_host_maintenance.py
   Intermitten failure detected: /marvin/tests/smoke/test_hostha_kvm.py
   Smoke tests completed. 61 look OK, 6 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_04_restart_network_wo_cleanup | `Failure` | 2.78 | test_routers.py
   test_04_extract_template | `Failure` | 128.31 | test_templates.py
   ContextSuite context=TestISOUsage>:setup | `Error` | 0.00 | test_usage.py
   test_06_download_detached_volume | `Failure` | 136.58 | test_volumes.py
   test_04_rvpc_network_garbage_collector_nics | `Failure` | 481.47 | 
test_vpc_redundant.py
   test_hostha_enable_ha_when_host_in_maintenance | `Error` | 3.46 | 
test_hostha_kvm.py
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rafaelweingartner commented on issue #2449: CLOUDSTACK-10278 idempotent column addition

[GitBox]

rafaelweingartner commented on issue #2449: CLOUDSTACK-10278 idempotent column 
addition
URL: https://github.com/apache/cloudstack/pull/2449#issuecomment-376942892
 
 
   @DaanHoogland are you going to introduce the changes here in master as well?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rafaelweingartner commented on issue #2462: [CLOUDSTACK-10301] Allow updating the network ACL list name and Description

[GitBox]

rafaelweingartner commented on issue #2462: [CLOUDSTACK-10301] Allow updating 
the network ACL list name and Description
URL: https://github.com/apache/cloudstack/pull/2462#issuecomment-376944372
 
 
   @borisstoyanov can you run tests here?
   This is a simple, but useful feature in production.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rafaelweingartner commented on issue #2486: [CLOUDSTACK-10323] Allow changing disk offering during volume migration

[GitBox]

rafaelweingartner commented on issue #2486: [CLOUDSTACK-10323] Allow changing 
disk offering during volume migration 
URL: https://github.com/apache/cloudstack/pull/2486#issuecomment-376943966
 
 
   @borisstoyanov I ammended the code as you suggested.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rafaelweingartner commented on issue #2486: [CLOUDSTACK-10323] Allow changing disk offering during volume migration

[GitBox]

rafaelweingartner commented on issue #2486: [CLOUDSTACK-10323] Allow changing 
disk offering during volume migration 
URL: https://github.com/apache/cloudstack/pull/2486#issuecomment-376943966
 
 
   @borisstoyanov I amended the code as you suggested.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rafaelweingartner commented on issue #2401: [CLOUDSTACK-10226] CloudStack is not importing Local storage properly

[GitBox]

rafaelweingartner commented on issue #2401: [CLOUDSTACK-10226] CloudStack is 
not importing Local storage properly
URL: https://github.com/apache/cloudstack/pull/2401#issuecomment-376944918
 
 
   @DaanHoogland it seems that the tests you executed here were successful 
(despite the errors presented). Can you confirm it?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2401: [CLOUDSTACK-10226] CloudStack is not importing Local storage properly

[GitBox]

blueorangutan commented on issue #2401: [CLOUDSTACK-10226] CloudStack is not 
importing Local storage properly
URL: https://github.com/apache/cloudstack/pull/2401#issuecomment-376946598
 
 
   @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has 
been kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rafaelweingartner commented on issue #2414: [CLOUDSTACK-10241] Duplicated file SRs being created in XenServer pools

[GitBox]

rafaelweingartner commented on issue #2414: [CLOUDSTACK-10241] Duplicated file 
SRs being created in XenServer pools
URL: https://github.com/apache/cloudstack/pull/2414#issuecomment-376931360
 
 
   @rhtyd I will wait more 24 hours before merging this one to give you some 
extra time in cause you have objections. Tests results are green (tests 
executed by @DaanHoogland 14 days ago), and the reviews are positive.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services