[GitHub] blueorangutan commented on issue #3171: Keep iotune section in the VM's XML after live migration

2019-02-11 Thread GitBox
blueorangutan commented on issue #3171: Keep iotune section in the VM's XML after live migration URL: https://github.com/apache/cloudstack/pull/3171#issuecomment-462638457 Trillian test result (tid-3402) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time

[GitHub] falcon78921 opened a new pull request #3174: scripts/network/ping: cleaned up code in baremetal_user_data.py

2019-02-11 Thread GitBox
falcon78921 opened a new pull request #3174: scripts/network/ping: cleaned up code in baremetal_user_data.py URL: https://github.com/apache/cloudstack/pull/3174 ## Description Cleaned up code in ``baremetal_user_data.py``. Updated string formatting to ``str.format()``.

[GitHub] blueorangutan commented on issue #3166: scripts/network/exdhcp: cleaned up code in dhcpd_edithosts.py

2019-02-11 Thread GitBox
blueorangutan commented on issue #3166: scripts/network/exdhcp: cleaned up code in dhcpd_edithosts.py URL: https://github.com/apache/cloudstack/pull/3166#issuecomment-462525975 Trillian test result (tid-3401) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total

[GitHub] blueorangutan commented on issue #3171: Keep iotune section in the VM's XML after live migration

2019-02-11 Thread GitBox
blueorangutan commented on issue #3171: Keep iotune section in the VM's XML after live migration URL: https://github.com/apache/cloudstack/pull/3171#issuecomment-462523001 @GabrielBrascher a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[GitHub] GabrielBrascher commented on issue #3171: Keep iotune section in the VM's XML after live migration

2019-02-11 Thread GitBox
GabrielBrascher commented on issue #3171: Keep iotune section in the VM's XML after live migration URL: https://github.com/apache/cloudstack/pull/3171#issuecomment-462522925 @blueorangutan test This is an automated message

[GitHub] blueorangutan commented on issue #3146: RIP Nuage Cloudstack Plugin

2019-02-11 Thread GitBox
blueorangutan commented on issue #3146: RIP Nuage Cloudstack Plugin URL: https://github.com/apache/cloudstack/pull/3146#issuecomment-462519520 Trillian test result (tid-3400) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 33878 seconds

[GitHub] blueorangutan commented on issue #3171: Keep iotune section in the VM's XML after live migration

2019-02-11 Thread GitBox
blueorangutan commented on issue #3171: Keep iotune section in the VM's XML after live migration URL: https://github.com/apache/cloudstack/pull/3171#issuecomment-462515034 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2607

[GitHub] blueorangutan commented on issue #3171: Keep iotune section in the VM's XML after live migration

2019-02-11 Thread GitBox
blueorangutan commented on issue #3171: Keep iotune section in the VM's XML after live migration URL: https://github.com/apache/cloudstack/pull/3171#issuecomment-462508326 @GabrielBrascher a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] GabrielBrascher commented on issue #3171: Keep iotune section in the VM's XML after live migration

2019-02-11 Thread GitBox
GabrielBrascher commented on issue #3171: Keep iotune section in the VM's XML after live migration URL: https://github.com/apache/cloudstack/pull/3171#issuecomment-462508072 @blueorangutan package This is an automated

[GitHub] GabrielBrascher commented on issue #3161: Fix behavior of multiselect in list view

2019-02-11 Thread GitBox
GabrielBrascher commented on issue #3161: Fix behavior of multiselect in list view URL: https://github.com/apache/cloudstack/pull/3161#issuecomment-462507582 @svenvogel The master branch is in freeze state due to the 4.12 releasing process. As soon as we have master open for merging we

[GitHub] blueorangutan commented on issue #3171: Keep iotune section in the VM's XML after live migration

2019-02-11 Thread GitBox
blueorangutan commented on issue #3171: Keep iotune section in the VM's XML after live migration URL: https://github.com/apache/cloudstack/pull/3171#issuecomment-462499878 Trillian test result (tid-3398) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time

[GitHub] blueorangutan commented on issue #3170: NotImplemented as a local exception

2019-02-11 Thread GitBox
blueorangutan commented on issue #3170: NotImplemented as a local exception URL: https://github.com/apache/cloudstack/pull/3170#issuecomment-462491959 Trillian test result (tid-3399) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 28964 seconds

[GitHub] blueorangutan commented on issue #3170: NotImplemented as a local exception

2019-02-11 Thread GitBox
blueorangutan commented on issue #3170: NotImplemented as a local exception URL: https://github.com/apache/cloudstack/pull/3170#issuecomment-462486369 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2606 This is an automated

[GitHub] blueorangutan commented on issue #3170: NotImplemented as a local exception

2019-02-11 Thread GitBox
blueorangutan commented on issue #3170: NotImplemented as a local exception URL: https://github.com/apache/cloudstack/pull/3170#issuecomment-462479558 @DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] DaanHoogland commented on issue #3170: NotImplemented as a local exception

2019-02-11 Thread GitBox
DaanHoogland commented on issue #3170: NotImplemented as a local exception URL: https://github.com/apache/cloudstack/pull/3170#issuecomment-462479186 @blueorangutan package This is an automated message from the Apache Git

[GitHub] DaanHoogland removed a comment on issue #3173: Mock Scanner, instead of scan the computer running the test.

2019-02-11 Thread GitBox
DaanHoogland removed a comment on issue #3173: Mock Scanner, instead of scan the computer running the test. URL: https://github.com/apache/cloudstack/pull/3173#issuecomment-462475199 @GabrielBrascher I tried your branch and it still doesn't compile: ``` [INFO] [INFO] Results:

[GitHub] DaanHoogland commented on issue #3173: Mock Scanner, instead of scan the computer running the test.

2019-02-11 Thread GitBox
DaanHoogland commented on issue #3173: Mock Scanner, instead of scan the computer running the test. URL: https://github.com/apache/cloudstack/pull/3173#issuecomment-462475199 @GabrielBrascher I tried your branch and it still doesn't compile: ``` [INFO] [INFO] Results: [INFO]

[GitHub] svenvogel commented on issue #3161: Fix behavior of multiselect in list view

2019-02-11 Thread GitBox
svenvogel commented on issue #3161: Fix behavior of multiselect in list view URL: https://github.com/apache/cloudstack/pull/3161#issuecomment-462473528 @rhtyd can we merge it? can you have a look?  This is an automated

[GitHub] nathanejohnson commented on issue #3173: Mock Scanner, instead of scan the computer running the test.

2019-02-11 Thread GitBox
nathanejohnson commented on issue #3173: Mock Scanner, instead of scan the computer running the test. URL: https://github.com/apache/cloudstack/pull/3173#issuecomment-462439520 still getting failures, but in a new place. I've attached logs

[GitHub] GabrielBrascher commented on issue #3173: Mock Scanner, instead of scan the computer running the test.

2019-02-11 Thread GitBox
GabrielBrascher commented on issue #3173: Mock Scanner, instead of scan the computer running the test. URL: https://github.com/apache/cloudstack/pull/3173#issuecomment-462429480 Updated the code with a _setup_ method and removed a variable that I left without mocking. Thanks for testing

[GitHub] nathanejohnson edited a comment on issue #3173: Mock Scanner, instead of scan the computer running the test.

2019-02-11 Thread GitBox
nathanejohnson edited a comment on issue #3173: Mock Scanner, instead of scan the computer running the test. URL: https://github.com/apache/cloudstack/pull/3173#issuecomment-462425427 Still getting failures on mac: ``` java.lang.RuntimeException: File /proc/meminfo not

[GitHub] nathanejohnson commented on issue #3173: Mock Scanner, instead of scan the computer running the test.

2019-02-11 Thread GitBox
nathanejohnson commented on issue #3173: Mock Scanner, instead of scan the computer running the test. URL: https://github.com/apache/cloudstack/pull/3173#issuecomment-462425427 Still getting failures on mac: ``` java.lang.RuntimeException: File /proc/meminfo not

[GitHub] GabrielBrascher commented on issue #3173: Mock Scanner, instead of scan the computer running the test.

2019-02-11 Thread GitBox
GabrielBrascher commented on issue #3173: Mock Scanner, instead of scan the computer running the test. URL: https://github.com/apache/cloudstack/pull/3173#issuecomment-462420138 Ping for review @kiwiflyer @nathanejohnson @DaanHoogland and others.

[GitHub] DaanHoogland commented on a change in pull request #3170: NotImplemented as a local exception

2019-02-11 Thread GitBox
DaanHoogland commented on a change in pull request #3170: NotImplemented as a local exception URL: https://github.com/apache/cloudstack/pull/3170#discussion_r255531228 ## File path: plugins/hypervisors/kvm/src/main/java/org/apache/cloudstack/utils/qemu/QemuImg.java ## @@

[GitHub] DaanHoogland commented on issue #2992: PoC for log library surface reduction (2991)

2019-02-11 Thread GitBox
DaanHoogland commented on issue #2992: PoC for log library surface reduction (2991) URL: https://github.com/apache/cloudstack/pull/2992#issuecomment-462337097 framework/managed-context uses slf4j and is not dependend on utils. This needs to be solved by 1. isolating logging in its own

[GitHub] GabrielBrascher opened a new pull request #3173: Mock Scanner, instead of scan the computer running the test.

2019-02-11 Thread GitBox
GabrielBrascher opened a new pull request #3173: Mock Scanner, instead of scan the computer running the test. URL: https://github.com/apache/cloudstack/pull/3173 This allows computers with Windows or MacOS to run the tests without scanning for `/proc/meminfo` path. At the class

[GitHub] borisstoyanov opened a new issue #3172: java download client - unable to download/register when there's a trusted ssl connection

2019-02-11 Thread GitBox
borisstoyanov opened a new issue #3172: java download client - unable to download/register when there's a trusted ssl connection URL: https://github.com/apache/cloudstack/issues/3172 # ISSUE TYPE * Bug Report # COMPONENT NAME ~~~ SSVM ~~~

[GitHub] borisstoyanov commented on issue #3166: scripts/network/exdhcp: cleaned up code in dhcpd_edithosts.py

2019-02-11 Thread GitBox
borisstoyanov commented on issue #3166: scripts/network/exdhcp: cleaned up code in dhcpd_edithosts.py URL: https://github.com/apache/cloudstack/pull/3166#issuecomment-462327044 @blueorangutan test This is an automated

[GitHub] blueorangutan commented on issue #3166: scripts/network/exdhcp: cleaned up code in dhcpd_edithosts.py

2019-02-11 Thread GitBox
blueorangutan commented on issue #3166: scripts/network/exdhcp: cleaned up code in dhcpd_edithosts.py URL: https://github.com/apache/cloudstack/pull/3166#issuecomment-462327130 @borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[GitHub] rafaelweingartner commented on a change in pull request #3170: NotImplemented as a local exception

2019-02-11 Thread GitBox
rafaelweingartner commented on a change in pull request #3170: NotImplemented as a local exception URL: https://github.com/apache/cloudstack/pull/3170#discussion_r255496880 ## File path: plugins/hypervisors/kvm/src/main/java/org/apache/cloudstack/utils/qemu/QemuImg.java

[GitHub] DaanHoogland commented on a change in pull request #3170: NotImplemented as a local exception

2019-02-11 Thread GitBox
DaanHoogland commented on a change in pull request #3170: NotImplemented as a local exception URL: https://github.com/apache/cloudstack/pull/3170#discussion_r255496081 ## File path: plugins/hypervisors/kvm/src/main/java/org/apache/cloudstack/utils/qemu/QemuImg.java ## @@

[GitHub] blueorangutan commented on issue #3166: scripts/network/exdhcp: cleaned up code in dhcpd_edithosts.py

2019-02-11 Thread GitBox
blueorangutan commented on issue #3166: scripts/network/exdhcp: cleaned up code in dhcpd_edithosts.py URL: https://github.com/apache/cloudstack/pull/3166#issuecomment-462315777 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2605

[GitHub] nvazquez commented on a change in pull request #3170: NotImplemented as a local exception

2019-02-11 Thread GitBox
nvazquez commented on a change in pull request #3170: NotImplemented as a local exception URL: https://github.com/apache/cloudstack/pull/3170#discussion_r255490327 ## File path: plugins/hypervisors/kvm/src/main/java/org/apache/cloudstack/utils/qemu/QemuImg.java ## @@

[GitHub] nvazquez commented on a change in pull request #3170: NotImplemented as a local exception

2019-02-11 Thread GitBox
nvazquez commented on a change in pull request #3170: NotImplemented as a local exception URL: https://github.com/apache/cloudstack/pull/3170#discussion_r255489681 ## File path: plugins/hypervisors/kvm/src/main/java/org/apache/cloudstack/utils/qemu/QemuImg.java ## @@

[GitHub] DaanHoogland commented on a change in pull request #3170: NotImplemented as a local exception

2019-02-11 Thread GitBox
DaanHoogland commented on a change in pull request #3170: NotImplemented as a local exception URL: https://github.com/apache/cloudstack/pull/3170#discussion_r255488013 ## File path: plugins/hypervisors/kvm/src/main/java/org/apache/cloudstack/utils/qemu/QemuImg.java ## @@

[GitHub] blueorangutan commented on issue #3146: RIP Nuage Cloudstack Plugin

2019-02-11 Thread GitBox
blueorangutan commented on issue #3146: RIP Nuage Cloudstack Plugin URL: https://github.com/apache/cloudstack/pull/3146#issuecomment-462310748 @borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[GitHub] borisstoyanov commented on issue #3146: RIP Nuage Cloudstack Plugin

2019-02-11 Thread GitBox
borisstoyanov commented on issue #3146: RIP Nuage Cloudstack Plugin URL: https://github.com/apache/cloudstack/pull/3146#issuecomment-462310659 @blueorangutan test This is an automated message from the Apache Git Service. To

[GitHub] blueorangutan commented on issue #3170: NotImplemented as a local exception

2019-02-11 Thread GitBox
blueorangutan commented on issue #3170: NotImplemented as a local exception URL: https://github.com/apache/cloudstack/pull/3170#issuecomment-462310240 @borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[GitHub] blueorangutan commented on issue #3166: scripts/network/exdhcp: cleaned up code in dhcpd_edithosts.py

2019-02-11 Thread GitBox
blueorangutan commented on issue #3166: scripts/network/exdhcp: cleaned up code in dhcpd_edithosts.py URL: https://github.com/apache/cloudstack/pull/3166#issuecomment-462310233 @borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] borisstoyanov commented on issue #3166: scripts/network/exdhcp: cleaned up code in dhcpd_edithosts.py

2019-02-11 Thread GitBox
borisstoyanov commented on issue #3166: scripts/network/exdhcp: cleaned up code in dhcpd_edithosts.py URL: https://github.com/apache/cloudstack/pull/3166#issuecomment-462310179 @blueorangutan package This is an automated

[GitHub] borisstoyanov commented on issue #3170: NotImplemented as a local exception

2019-02-11 Thread GitBox
borisstoyanov commented on issue #3170: NotImplemented as a local exception URL: https://github.com/apache/cloudstack/pull/3170#issuecomment-462310007 @blueorangutan test This is an automated message from the Apache Git

[GitHub] rafaelweingartner commented on a change in pull request #3170: NotImplemented as a local exception

2019-02-11 Thread GitBox
rafaelweingartner commented on a change in pull request #3170: NotImplemented as a local exception URL: https://github.com/apache/cloudstack/pull/3170#discussion_r255483128 ## File path: plugins/hypervisors/kvm/src/main/java/org/apache/cloudstack/utils/qemu/QemuImg.java

[GitHub] DaanHoogland commented on a change in pull request #3170: NotImplemented as a local exception

2019-02-11 Thread GitBox
DaanHoogland commented on a change in pull request #3170: NotImplemented as a local exception URL: https://github.com/apache/cloudstack/pull/3170#discussion_r255481242 ## File path: plugins/hypervisors/kvm/src/main/java/org/apache/cloudstack/utils/qemu/QemuImg.java ## @@

[GitHub] blueorangutan commented on issue #3171: Keep iotune section in the VM's XML after live migration

2019-02-11 Thread GitBox
blueorangutan commented on issue #3171: Keep iotune section in the VM's XML after live migration URL: https://github.com/apache/cloudstack/pull/3171#issuecomment-462304132 @GabrielBrascher a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[GitHub] GabrielBrascher commented on issue #3171: Keep iotune section in the VM's XML after live migration

2019-02-11 Thread GitBox
GabrielBrascher commented on issue #3171: Keep iotune section in the VM's XML after live migration URL: https://github.com/apache/cloudstack/pull/3171#issuecomment-462304083 @blueorangutan test This is an automated message

[GitHub] blueorangutan commented on issue #3171: Keep iotune section in the VM's XML after live migration

2019-02-11 Thread GitBox
blueorangutan commented on issue #3171: Keep iotune section in the VM's XML after live migration URL: https://github.com/apache/cloudstack/pull/3171#issuecomment-462293752 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2604

[GitHub] ustcweizhou commented on issue #3048: Copy template/iso tags into VM

2019-02-11 Thread GitBox
ustcweizhou commented on issue #3048: Copy template/iso tags into VM URL: https://github.com/apache/cloudstack/issues/3048#issuecomment-462290963 @bwsw @anuragaw I do not understand what's the proposal of this request. in my opinion, templete/iso tag should be taken into

[GitHub] blueorangutan commented on issue #3171: Keep iotune section in the VM's XML after live migration

2019-02-11 Thread GitBox
blueorangutan commented on issue #3171: Keep iotune section in the VM's XML after live migration URL: https://github.com/apache/cloudstack/pull/3171#issuecomment-462288551 @GabrielBrascher a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] GabrielBrascher commented on issue #3171: Keep iotune section in the VM's XML after live migration

2019-02-11 Thread GitBox
GabrielBrascher commented on issue #3171: Keep iotune section in the VM's XML after live migration URL: https://github.com/apache/cloudstack/pull/3171#issuecomment-462288432 @blueorangutan package This is an automated

[GitHub] blueorangutan commented on issue #3171: Keep iotune section in the VM's XML after live migration

2019-02-11 Thread GitBox
blueorangutan commented on issue #3171: Keep iotune section in the VM's XML after live migration URL: https://github.com/apache/cloudstack/pull/3171#issuecomment-462281826 Trillian test result (tid-3397) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time

[GitHub] ustcweizhou commented on issue #3171: Keep iotune section in the VM's XML after live migration

2019-02-11 Thread GitBox
ustcweizhou commented on issue #3171: Keep iotune section in the VM's XML after live migration URL: https://github.com/apache/cloudstack/pull/3171#issuecomment-462279056 code LGTM This is an automated message from the Apache