[GitHub] [cloudstack] anuragaw commented on a change in pull request #3338: ui: fix enable static nat only towards first nic and not on any other interface

2019-05-20 Thread GitBox
anuragaw commented on a change in pull request #3338: ui: fix enable static nat only towards first nic and not on any other interface URL: https://github.com/apache/cloudstack/pull/3338#discussion_r285848465 ## File path: ui/scripts/network.js ## @@ -87,12 +87,21 @@

[GitHub] [cloudstack] anuragaw commented on a change in pull request #3335: kvm: disable cpu features if feature starts with '-'

2019-05-20 Thread GitBox
anuragaw commented on a change in pull request #3335: kvm: disable cpu features if feature starts with '-' URL: https://github.com/apache/cloudstack/pull/3335#discussion_r285849457 ## File path:

[GitHub] [cloudstack] blueorangutan commented on issue #3335: kvm: disable cpu features if feature starts with '-'

2019-05-20 Thread GitBox
blueorangutan commented on issue #3335: kvm: disable cpu features if feature starts with '-' URL: https://github.com/apache/cloudstack/pull/3335#issuecomment-493923786 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2742

[GitHub] [cloudstack] blueorangutan commented on issue #3333: server: ssh-keygen in PEM format and reduce main systemvm patching script

2019-05-20 Thread GitBox
blueorangutan commented on issue #: server: ssh-keygen in PEM format and reduce main systemvm patching script URL: https://github.com/apache/cloudstack/pull/#issuecomment-493946832 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2743

[GitHub] [cloudstack] rhtyd commented on issue #3333: server: ssh-keygen in PEM format and reduce main systemvm patching script

2019-05-20 Thread GitBox
rhtyd commented on issue #: server: ssh-keygen in PEM format and reduce main systemvm patching script URL: https://github.com/apache/cloudstack/pull/#issuecomment-493957265 @blueorangutan test matrix This is an

[GitHub] [cloudstack] blueorangutan commented on issue #3333: server: ssh-keygen in PEM format and reduce main systemvm patching script

2019-05-20 Thread GitBox
blueorangutan commented on issue #: server: ssh-keygen in PEM format and reduce main systemvm patching script URL: https://github.com/apache/cloudstack/pull/#issuecomment-493957694 @rhtyd a Trillian-Jenkins matrix job (centos6 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt +

[GitHub] [cloudstack] ustcweizhou removed a comment on issue #3334: Cannot enable static NAT on VM with NICs on multiple VPC tiers in UI

2019-05-20 Thread GitBox
ustcweizhou removed a comment on issue #3334: Cannot enable static NAT on VM with NICs on multiple VPC tiers in UI URL: https://github.com/apache/cloudstack/issues/3334#issuecomment-493916561 patch ``` diff --git a/ui/scripts/vpc.js b/ui/scripts/vpc.js index 8058f07..b7fac5b

[GitHub] [cloudstack] blueorangutan commented on issue #3333: server: ssh-keygen in PEM format and reduce main systemvm patching script

2019-05-20 Thread GitBox
blueorangutan commented on issue #: server: ssh-keygen in PEM format and reduce main systemvm patching script URL: https://github.com/apache/cloudstack/pull/#issuecomment-493940678 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] [cloudstack] rhtyd commented on issue #3333: [WIP] server: save SSH keypair exactly as generated by ssh-keygen

2019-05-20 Thread GitBox
rhtyd commented on issue #: [WIP] server: save SSH keypair exactly as generated by ssh-keygen URL: https://github.com/apache/cloudstack/pull/#issuecomment-493940385 The main issue with failing VR came out to be due to the ssh private key having 'OPENSS... PRIVATE KEY' instead of

[GitHub] [cloudstack] nvazquez commented on issue #3334: Cannot enable static NAT on VM with NICs on multiple VPC tiers in UI

2019-05-20 Thread GitBox
nvazquez commented on issue #3334: Cannot enable static NAT on VM with NICs on multiple VPC tiers in UI URL: https://github.com/apache/cloudstack/issues/3334#issuecomment-493958908 Done @PaulAngus thanks This is an automated

[GitHub] [cloudstack] rhtyd commented on issue #3335: kvm: disable cpu features if feature starts with '-'

2019-05-20 Thread GitBox
rhtyd commented on issue #3335: kvm: disable cpu features if feature starts with '-' URL: https://github.com/apache/cloudstack/pull/3335#issuecomment-493915939 @ustcweizhou thanks for explaining @blueorangutan package

[GitHub] [cloudstack] blueorangutan removed a comment on issue #3333: [WIP] server: save SSH keypair exactly as generated by ssh-keygen

2019-05-20 Thread GitBox
blueorangutan removed a comment on issue #: [WIP] server: save SSH keypair exactly as generated by ssh-keygen URL: https://github.com/apache/cloudstack/pull/#issuecomment-493420910 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2741

[GitHub] [cloudstack] blueorangutan removed a comment on issue #3333: [WIP] server: save SSH keypair exactly as generated by ssh-keygen

2019-05-20 Thread GitBox
blueorangutan removed a comment on issue #: [WIP] server: save SSH keypair exactly as generated by ssh-keygen URL: https://github.com/apache/cloudstack/pull/#issuecomment-493416072 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] [cloudstack] rhtyd removed a comment on issue #3333: [WIP] server: save SSH keypair exactly as generated by ssh-keygen

2019-05-20 Thread GitBox
rhtyd removed a comment on issue #: [WIP] server: save SSH keypair exactly as generated by ssh-keygen URL: https://github.com/apache/cloudstack/pull/#issuecomment-493415891 @blueorangutan package This is an automated

[GitHub] [cloudstack] rhtyd removed a comment on issue #3333: [WIP] server: save SSH keypair exactly as generated by ssh-keygen

2019-05-20 Thread GitBox
rhtyd removed a comment on issue #: [WIP] server: save SSH keypair exactly as generated by ssh-keygen URL: https://github.com/apache/cloudstack/pull/#issuecomment-493436754 @blueorangutan test This is an automated

[GitHub] [cloudstack] rhtyd removed a comment on issue #3333: [WIP] server: save SSH keypair exactly as generated by ssh-keygen

2019-05-20 Thread GitBox
rhtyd removed a comment on issue #: [WIP] server: save SSH keypair exactly as generated by ssh-keygen URL: https://github.com/apache/cloudstack/pull/#issuecomment-493436691 @blueorangutan package This is an automated

[GitHub] [cloudstack] blueorangutan removed a comment on issue #3333: [WIP] server: save SSH keypair exactly as generated by ssh-keygen

2019-05-20 Thread GitBox
blueorangutan removed a comment on issue #: [WIP] server: save SSH keypair exactly as generated by ssh-keygen URL: https://github.com/apache/cloudstack/pull/#issuecomment-493436966 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[GitHub] [cloudstack] ustcweizhou commented on issue #3335: kvm: disable cpu features if feature starts with '-'

2019-05-20 Thread GitBox
ustcweizhou commented on issue #3335: kvm: disable cpu features if feature starts with '-' URL: https://github.com/apache/cloudstack/pull/3335#issuecomment-493909611 @rhtyd these features are not supported by our CPU (a quite old CPU) so I want to disable these cpu features.

[GitHub] [cloudstack] PaulAngus commented on issue #3334: Cannot enable static NAT on VM with NICs on multiple VPC tiers

2019-05-20 Thread GitBox
PaulAngus commented on issue #3334: Cannot enable static NAT on VM with NICs on multiple VPC tiers URL: https://github.com/apache/cloudstack/issues/3334#issuecomment-493886182 @nvazquez please can you detail where in the UI you are trying to add this IP.

[GitHub] [cloudstack] rhtyd commented on issue #3335: kvm: disable cpu features if feature starts with '-'

2019-05-20 Thread GitBox
rhtyd commented on issue #3335: kvm: disable cpu features if feature starts with '-' URL: https://github.com/apache/cloudstack/pull/3335#issuecomment-493900907 @ustcweizhou why not simply configure the agent.properties without the hyphen `-`? For example: ```

[GitHub] [cloudstack] blueorangutan commented on issue #3335: kvm: disable cpu features if feature starts with '-'

2019-05-20 Thread GitBox
blueorangutan commented on issue #3335: kvm: disable cpu features if feature starts with '-' URL: https://github.com/apache/cloudstack/pull/3335#issuecomment-493916325 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] [cloudstack] ustcweizhou commented on issue #3334: Cannot enable static NAT on VM with NICs on multiple VPC tiers in UI

2019-05-20 Thread GitBox
ustcweizhou commented on issue #3334: Cannot enable static NAT on VM with NICs on multiple VPC tiers in UI URL: https://github.com/apache/cloudstack/issues/3334#issuecomment-493916561 patch ``` diff --git a/ui/scripts/vpc.js b/ui/scripts/vpc.js index 8058f07..b7fac5b 100644

[GitHub] [cloudstack] blueorangutan commented on issue #3333: server: ssh-keygen in PEM format and reduce main systemvm patching script

2019-05-20 Thread GitBox
blueorangutan commented on issue #: server: ssh-keygen in PEM format and reduce main systemvm patching script URL: https://github.com/apache/cloudstack/pull/#issuecomment-493992439 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] [cloudstack] ustcweizhou opened a new pull request #3338: ui: fix enable static nat only towards first nic and not on any other interface

2019-05-20 Thread GitBox
ustcweizhou opened a new pull request #3338: ui: fix enable static nat only towards first nic and not on any other interface URL: https://github.com/apache/cloudstack/pull/3338 ## Description When enable static nat in a vpc on UI, it only lists the primary and secondary ips of first

[GitHub] [cloudstack] rhtyd commented on issue #3333: server: ssh-keygen in PEM format and reduce main systemvm patching script

2019-05-20 Thread GitBox
rhtyd commented on issue #: server: ssh-keygen in PEM format and reduce main systemvm patching script URL: https://github.com/apache/cloudstack/pull/#issuecomment-493992130 @blueorangutan package This is an automated

[GitHub] [cloudstack] PaulAngus opened a new issue #3339: Duplicate tags cause DB constraint exceptions

2019-05-20 Thread GitBox
PaulAngus opened a new issue #3339: Duplicate tags cause DB constraint exceptions URL: https://github.com/apache/cloudstack/issues/3339 # ISSUE TYPE * Bug Report # COMPONENT NAME ~~~ API ~~~ # CLOUDSTACK VERSION ~~~

[GitHub] [cloudstack] pbankonier commented on issue #3332: Switch instance to another compute/service offering

2019-05-20 Thread GitBox
pbankonier commented on issue #3332: Switch instance to another compute/service offering URL: https://github.com/apache/cloudstack/issues/3332#issuecomment-494024906 @nathanejohnson The problem is from line 2371 in the ConfigurationManagerImpl.java. You changed the condition from

[GitHub] [cloudstack] blueorangutan commented on issue #3333: server: ssh-keygen in PEM format and reduce main systemvm patching script

2019-05-20 Thread GitBox
blueorangutan commented on issue #: server: ssh-keygen in PEM format and reduce main systemvm patching script URL: https://github.com/apache/cloudstack/pull/#issuecomment-494000429 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2744

[GitHub] [cloudstack] svenvogel commented on issue #3331: api/server: Add option 'details' to listProjects and listAccounts

2019-05-20 Thread GitBox
svenvogel commented on issue #3331: api/server: Add option 'details' to listProjects and listAccounts URL: https://github.com/apache/cloudstack/pull/3331#issuecomment-494009627 @ustcweizhou i mean ... its a extension from #3306 ? so we need to add this in the ui to get them faster?

[GitHub] [cloudstack] rhtyd commented on issue #3333: server: ssh-keygen in PEM format and reduce main systemvm patching script

2019-05-20 Thread GitBox
rhtyd commented on issue #: server: ssh-keygen in PEM format and reduce main systemvm patching script URL: https://github.com/apache/cloudstack/pull/#issuecomment-494012307 Kicked test with centos6 out of band. This

[GitHub] [cloudstack] rhtyd commented on issue #3333: server: ssh-keygen in PEM format and reduce main systemvm patching script

2019-05-20 Thread GitBox
rhtyd commented on issue #: server: ssh-keygen in PEM format and reduce main systemvm patching script URL: https://github.com/apache/cloudstack/pull/#issuecomment-494094779 @ustcweizhou This is ready for review now, the issue is affecting CloudStack with latest versions of

[GitHub] [cloudstack] nathanejohnson commented on issue #3332: Switch instance to another compute/service offering

2019-05-20 Thread GitBox
nathanejohnson commented on issue #3332: Switch instance to another compute/service offering URL: https://github.com/apache/cloudstack/issues/3332#issuecomment-494107412 @pbankonier the UI sends icsucomizediops=false every time it looks like. if you look at the previous logic, it still

[GitHub] [cloudstack] nathanejohnson edited a comment on issue #3332: Switch instance to another compute/service offering

2019-05-20 Thread GitBox
nathanejohnson edited a comment on issue #3332: Switch instance to another compute/service offering URL: https://github.com/apache/cloudstack/issues/3332#issuecomment-494107412 @pbankonier the UI sends icsucomizediops=false every time it looks like. if you look at the previous logic, it

[GitHub] [cloudstack] nathanejohnson edited a comment on issue #3332: Switch instance to another compute/service offering

2019-05-20 Thread GitBox
nathanejohnson edited a comment on issue #3332: Switch instance to another compute/service offering URL: https://github.com/apache/cloudstack/issues/3332#issuecomment-494107412 @pbankonier the UI sends icsucomizediops=false every time it looks like. if you look at the previous logic, it

[GitHub] [cloudstack] nathanejohnson commented on issue #3332: Switch instance to another compute/service offering

2019-05-20 Thread GitBox
nathanejohnson commented on issue #3332: Switch instance to another compute/service offering URL: https://github.com/apache/cloudstack/issues/3332#issuecomment-494107853 @svenvogel if you use cloudmonkey to create the service offering and omit the iscusomizediops flag, I believe it should

[GitHub] [cloudstack] nathanejohnson edited a comment on issue #3332: Switch instance to another compute/service offering

2019-05-20 Thread GitBox
nathanejohnson edited a comment on issue #3332: Switch instance to another compute/service offering URL: https://github.com/apache/cloudstack/issues/3332#issuecomment-494107412 @pbankonier the UI sends icsucomizediops=false or true every time it looks like. if you look at the previous

[GitHub] [cloudstack] ustcweizhou commented on issue #3331: api/server: Add option 'details' to listProjects and listAccounts

2019-05-20 Thread GitBox
ustcweizhou commented on issue #3331: api/server: Add option 'details' to listProjects and listAccounts URL: https://github.com/apache/cloudstack/pull/3331#issuecomment-494114076 @svenvogel both #3306 and #3331 will reduce the execution time while list projects. #3306 aims to fix the

[GitHub] [cloudstack] ustcweizhou edited a comment on issue #3331: api/server: Add option 'details' to listProjects and listAccounts

2019-05-20 Thread GitBox
ustcweizhou edited a comment on issue #3331: api/server: Add option 'details' to listProjects and listAccounts URL: https://github.com/apache/cloudstack/pull/3331#issuecomment-494114076 @svenvogel both #3306 and #3331 will reduce the execution time while list projects. #3306 aims to

[GitHub] [cloudstack] ustcweizhou commented on issue #3334: Cannot enable static NAT on VM with NICs on multiple VPC tiers in UI

2019-05-20 Thread GitBox
ustcweizhou commented on issue #3334: Cannot enable static NAT on VM with NICs on multiple VPC tiers in UI URL: https://github.com/apache/cloudstack/issues/3334#issuecomment-494120656 @nvazquez could you please test fix in #3338 ?

[GitHub] [cloudstack] ustcweizhou commented on issue #3335: kvm: disable cpu features if feature starts with '-'

2019-05-20 Thread GitBox
ustcweizhou commented on issue #3335: kvm: disable cpu features if feature starts with '-' URL: https://github.com/apache/cloudstack/pull/3335#issuecomment-494120417 @rhtyd @svenvogel added unit test This is an

[GitHub] [cloudstack] PaulAngus opened a new issue #3340: ACS tries to delete a root disk in zone wide primary storage

2019-05-20 Thread GitBox
PaulAngus opened a new issue #3340: ACS tries to delete a root disk in zone wide primary storage URL: https://github.com/apache/cloudstack/issues/3340 # ISSUE TYPE * Bug Report # COMPONENT NAME ~~~ vSphere - Zone wide storage ~~~ #

[GitHub] [cloudstack] Doni7722 opened a new issue #3341: Ability to add custom disk offer to data disk (created from multi-disk template)

2019-05-20 Thread GitBox
Doni7722 opened a new issue #3341: Ability to add custom disk offer to data disk (created from multi-disk template) URL: https://github.com/apache/cloudstack/issues/3341 # ISSUE TYPE * Improvement Request # COMPONENT NAME ~~~ API, UI ~~~

[GitHub] [cloudstack] blueorangutan commented on issue #3333: server: ssh-keygen in PEM format and reduce main systemvm patching script

2019-05-20 Thread GitBox
blueorangutan commented on issue #: server: ssh-keygen in PEM format and reduce main systemvm patching script URL: https://github.com/apache/cloudstack/pull/#issuecomment-494180310 Trillian test result (tid-3563) Environment: xenserver-71 (x2), Advanced Networking with Mgmt

[GitHub] [cloudstack] svenvogel edited a comment on issue #3332: Switch instance to another compute/service offering

2019-05-20 Thread GitBox
svenvogel edited a comment on issue #3332: Switch instance to another compute/service offering URL: https://github.com/apache/cloudstack/issues/3332#issuecomment-494133023 @nathanejohnson we dont use really cloudmonkey. you mean logic was not changed? **if you see the pictures below from

[GitHub] [cloudstack] ustcweizhou commented on a change in pull request #3333: server: ssh-keygen in PEM format and reduce main systemvm patching script

2019-05-20 Thread GitBox
ustcweizhou commented on a change in pull request #: server: ssh-keygen in PEM format and reduce main systemvm patching script URL: https://github.com/apache/cloudstack/pull/#discussion_r285744320 ## File path:

[GitHub] [cloudstack] blueorangutan removed a comment on issue #3333: server: ssh-keygen in PEM format and reduce main systemvm patching script

2019-05-20 Thread GitBox
blueorangutan removed a comment on issue #: server: ssh-keygen in PEM format and reduce main systemvm patching script URL: https://github.com/apache/cloudstack/pull/#issuecomment-494180310 Trillian test result (tid-3563) Environment: xenserver-71 (x2), Advanced Networking with

[GitHub] [cloudstack] svenvogel edited a comment on issue #3332: Switch instance to another compute/service offering

2019-05-20 Thread GitBox
svenvogel edited a comment on issue #3332: Switch instance to another compute/service offering URL: https://github.com/apache/cloudstack/issues/3332#issuecomment-494133023 @nathanejohnson we dont use really cloudmonkey. you mean logic was not changed? **if you see the pictures below from

[GitHub] [cloudstack] svenvogel edited a comment on issue #3332: Switch instance to another compute/service offering

2019-05-20 Thread GitBox
svenvogel edited a comment on issue #3332: Switch instance to another compute/service offering URL: https://github.com/apache/cloudstack/issues/3332#issuecomment-494133023 @nathanejohnson we dont use really cloudmonkey. you mean logic was not changed? **if you see the pictures below from

[GitHub] [cloudstack] blueorangutan commented on issue #3333: server: ssh-keygen in PEM format and reduce main systemvm patching script

2019-05-20 Thread GitBox
blueorangutan commented on issue #: server: ssh-keygen in PEM format and reduce main systemvm patching script URL: https://github.com/apache/cloudstack/pull/#issuecomment-494198207 Trillian test result (tid-3562) Environment: vmware-65u2 (x2), Advanced Networking with Mgmt

[GitHub] [cloudstack] nathanejohnson commented on issue #3332: Switch instance to another compute/service offering

2019-05-20 Thread GitBox
nathanejohnson commented on issue #3332: Switch instance to another compute/service offering URL: https://github.com/apache/cloudstack/issues/3332#issuecomment-494219724 @svenvogel long-term we should make sure that this works from the UI. in the short term, I believe a workaround for

[GitHub] [cloudstack] svenvogel edited a comment on issue #3332: Switch instance to another compute/service offering

2019-05-20 Thread GitBox
svenvogel edited a comment on issue #3332: Switch instance to another compute/service offering URL: https://github.com/apache/cloudstack/issues/3332#issuecomment-494133023 @nathanejohnson we dont use really cloudmonkey. you mean logic was not changed? if you see the pictures above which i

[GitHub] [cloudstack] svenvogel edited a comment on issue #3332: Switch instance to another compute/service offering

2019-05-20 Thread GitBox
svenvogel edited a comment on issue #3332: Switch instance to another compute/service offering URL: https://github.com/apache/cloudstack/issues/3332#issuecomment-494133023 @nathanejohnson we dont use really cloudmonkey. you mean logic was not changed? **if you see the pictures above which

[GitHub] [cloudstack] svenvogel commented on issue #3332: Switch instance to another compute/service offering

2019-05-20 Thread GitBox
svenvogel commented on issue #3332: Switch instance to another compute/service offering URL: https://github.com/apache/cloudstack/issues/3332#issuecomment-494133023 @nathanejohnson we dont use really cloudmonkey. you mean logic was not changed? @syed @mike-tutkowski can you take a

[GitHub] [cloudstack] blueorangutan commented on issue #3333: server: ssh-keygen in PEM format and reduce main systemvm patching script

2019-05-20 Thread GitBox
blueorangutan commented on issue #: server: ssh-keygen in PEM format and reduce main systemvm patching script URL: https://github.com/apache/cloudstack/pull/#issuecomment-494141302 Trillian test result (tid-3560) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt