[GitHub] [cloudstack] rhtyd commented on issue #3398: server: save GUID for KVM cluster
rhtyd commented on issue #3398: server: save GUID for KVM cluster URL: https://github.com/apache/cloudstack/pull/3398#issuecomment-501144977 @ustcweizhou we've missed the 4.11.3.0 milestone freeze window, RC1 is already out and this is not a blocker issue. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] NicoWohlfarth commented on issue #3382: ui: fix instance and functionality
NicoWohlfarth commented on issue #3382: ui: fix instance and functionality URL: https://github.com/apache/cloudstack/pull/3382#issuecomment-501136815 > @NicoWohlfarth Is it possible to change the behavior of showing stop confirmation/host selection dialog when selected instance(s) are already in stopped/running state. > Although the start/stop VM is not called in this case but UI shows dialog unecessarily @shwstppr Yes, one could certainly do this, but i though it would then also be strange to have a button you can click and nothing would happen. I think we should assume that no one would necessarily try to start/stop an already started/stopped machine and then be surprised that nothing happens. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3398: server: save GUID for KVM cluster
rhtyd commented on issue #3398: server: save GUID for KVM cluster URL: https://github.com/apache/cloudstack/pull/3398#issuecomment-501150773 Merging based on tests and reviews. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] ustcweizhou commented on issue #3398: server: save GUID for KVM cluster
ustcweizhou commented on issue #3398: server: save GUID for KVM cluster URL: https://github.com/apache/cloudstack/pull/3398#issuecomment-501155987 > @ustcweizhou we've missed the 4.11.3.0 milestone freeze window, RC1 is already out and this is not a blocker issue. ok. maybe we can add it to 4.11 branch after 4.11.3 release This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] pmury opened a new issue #3399: Support LZOP for templates
pmury opened a new issue #3399: Support LZOP for templates URL: https://github.com/apache/cloudstack/issues/3399 # ISSUE TYPE * Feature Idea # COMPONENT NAME ~~~ API/ Core ~~~ # CLOUDSTACK VERSION ~~~ upstream ~~~ # SUMMARY Currently, we use bzip2/gzip compression for templates. However, LZOP (Lempel–Ziv–Oberhumer) algortihm can perform much faster though somewhat worse performance. It would we great to be able to register templates in LZOP format. According to this small benchmark, LZOP can be about 10x faster than GZIP. https://serverfault.com/questions/872749/bzip2-too-slow-multiple-cores-are-avaible This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] anuragaw commented on issue #3394: cloudstack: fix forward merge issues
anuragaw commented on issue #3394: cloudstack: fix forward merge issues URL: https://github.com/apache/cloudstack/pull/3394#issuecomment-501185884 Perfect. Thanks for confirming! LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3371: Fix template size for managed storage / refactor cloud-install-sys-tmplt and createtmplt.sh
blueorangutan commented on issue #3371: Fix template size for managed storage / refactor cloud-install-sys-tmplt and createtmplt.sh URL: https://github.com/apache/cloudstack/pull/3371#issuecomment-501185980 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] anuragaw commented on issue #3394: cloudstack: fix forward merge issues
anuragaw commented on issue #3394: cloudstack: fix forward merge issues URL: https://github.com/apache/cloudstack/pull/3394#issuecomment-501183753 @rhtyd - SnapShotManagerImpl duplicate files are not 100% identical. I think we have removed the one that was not being executed by imports. Can you confirm? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3241: [WIP DO NOT MERGE] Allow users to share templates with Accounts or Projects through the
blueorangutan commented on issue #3241: [WIP DO NOT MERGE] Allow users to share templates with Accounts or Projects through the URL: https://github.com/apache/cloudstack/pull/3241#issuecomment-501135598 @borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] borisstoyanov commented on issue #3241: [WIP DO NOT MERGE] Allow users to share templates with Accounts or Projects through the
borisstoyanov commented on issue #3241: [WIP DO NOT MERGE] Allow users to share templates with Accounts or Projects through the URL: https://github.com/apache/cloudstack/pull/3241#issuecomment-501135536 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[cloudstack] branch master updated: server: save GUID for KVM cluster (#3398)
This is an automated email from the ASF dual-hosted git repository.
rohit pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git
The following commit(s) were added to refs/heads/master by this push:
new aecfe6d server: save GUID for KVM cluster (#3398)
aecfe6d is described below
commit aecfe6d500dd3fa1b6bcef53f58dae7fa87c0447
Author: Rohit Yadav
AuthorDate: Wed Jun 12 12:47:24 2019 +0530
server: save GUID for KVM cluster (#3398)
When a KVM host is added to a cluster, the cluster GUID is null. In case
the KVM host fails to be added, the GUID is not set to null and if any
other hosts are added an exception is thrown by the resource manager
that does not allow addition of hosts to a cluster with existing hosts
whose GUID is null.
In case of KVM, other hosts may be added in parallel therefore this
restriction can be safely removed.
Signed-off-by: Rohit Yadav
---
.../kvm/discoverer/LibvirtServerDiscoverer.java | 17 +
1 file changed, 9 insertions(+), 8 deletions(-)
diff --git
a/server/src/main/java/com/cloud/hypervisor/kvm/discoverer/LibvirtServerDiscoverer.java
b/server/src/main/java/com/cloud/hypervisor/kvm/discoverer/LibvirtServerDiscoverer.java
index 0b8b40b..6c9bcac 100644
---
a/server/src/main/java/com/cloud/hypervisor/kvm/discoverer/LibvirtServerDiscoverer.java
+++
b/server/src/main/java/com/cloud/hypervisor/kvm/discoverer/LibvirtServerDiscoverer.java
@@ -210,6 +210,12 @@ public abstract class LibvirtServerDiscoverer extends
DiscovererBase implements
return null;
}
+// Set cluster GUID based on cluster ID if null
+if (cluster.getGuid() == null) {
+
cluster.setGuid(UUID.nameUUIDFromBytes(String.valueOf(clusterId).getBytes()).toString());
+_clusterDao.update(clusterId, cluster);
+}
+
Map> resources = new
HashMap>();
Map details = new HashMap();
if (!uri.getScheme().equals("http")) {
@@ -230,8 +236,9 @@ public abstract class LibvirtServerDiscoverer extends
DiscovererBase implements
if (existingHosts != null) {
for (HostVO existingHost : existingHosts) {
if
(existingHost.getGuid().toLowerCase().startsWith(guid.toLowerCase())) {
-s_logger.debug("Skipping " + agentIp + " because " +
guid + " is already in the database for resource " + existingHost.getGuid());
-return null;
+final String msg = "Skipping host " + agentIp + "
because " + guid + " is already in the database for resource " +
existingHost.getGuid() + " with ID " + existingHost.getUuid();
+s_logger.debug(msg);
+throw new CloudRuntimeException(msg);
}
}
}
@@ -326,12 +333,6 @@ public abstract class LibvirtServerDiscoverer extends
DiscovererBase implements
details.put("guid", connectedHost.getGuid());
-// place a place holder guid derived from cluster ID
-if (cluster.getGuid() == null) {
-
cluster.setGuid(UUID.nameUUIDFromBytes(String.valueOf(clusterId).getBytes()).toString());
-_clusterDao.update(clusterId, cluster);
-}
-
// save user name and password
_hostDao.loadDetails(connectedHost);
Map hostDetails = connectedHost.getDetails();
[GitHub] [cloudstack] rhtyd merged pull request #3398: server: save GUID for KVM cluster
rhtyd merged pull request #3398: server: save GUID for KVM cluster URL: https://github.com/apache/cloudstack/pull/3398 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3371: Fix template size for managed storage / refactor cloud-install-sys-tmplt and createtmplt.sh
rhtyd commented on issue #3371: Fix template size for managed storage / refactor cloud-install-sys-tmplt and createtmplt.sh URL: https://github.com/apache/cloudstack/pull/3371#issuecomment-501185639 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3394: cloudstack: fix forward merge issues
rhtyd commented on issue #3394: cloudstack: fix forward merge issues URL: https://github.com/apache/cloudstack/pull/3394#issuecomment-501184961 The one we've removed is not used at all, it is outside the 'src/main/java' path. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3374: KVM: Enhancements for direct download feature
blueorangutan commented on issue #3374: KVM: Enhancements for direct download feature URL: https://github.com/apache/cloudstack/pull/3374#issuecomment-501186556 Trillian test result (tid-3687) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 33489 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3374-t3687-kvm-centos7.zip Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py Smoke tests completed. 70 look OK, 1 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_05_rvpc_multi_tiers | `Failure` | 408.25 | test_vpc_redundant.py test_05_rvpc_multi_tiers | `Error` | 434.76 | test_vpc_redundant.py This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] shwstppr commented on a change in pull request #3241: [WIP DO NOT MERGE] Allow users to share templates with Accounts or Projects through the
shwstppr commented on a change in pull request #3241: [WIP DO NOT MERGE] Allow
users to share templates with Accounts or Projects through the
URL: https://github.com/apache/cloudstack/pull/3241#discussion_r292762890
##
File path: server/src/main/java/com/cloud/template/TemplateManagerImpl.java
##
@@ -1541,14 +1539,23 @@ public boolean
updateTemplateOrIsoPermissions(BaseUpdateTemplateOrIsoPermissions
//Derive the domain id from the template owner as
updateTemplatePermissions is not cross domain operation
Account owner = _accountMgr.getAccount(ownerId);
final Domain domain = _domainDao.findById(owner.getDomainId());
+final boolean isCallerRootAdmin =
_accountMgr.isRootAdmin(caller.getAccountId());
if ("add".equalsIgnoreCase(operation)) {
final List accountNamesFinal = accountNames;
final List accountIds = new ArrayList();
Transaction.execute(new TransactionCallbackNoReturn() {
@Override
public void doInTransactionWithoutResult(TransactionStatus
status) {
for (String accountName : accountNamesFinal) {
-Account permittedAccount =
_accountDao.findActiveAccount(accountName, domain.getId());
+Account permittedAccount = null;
+if (isCallerRootAdmin) {
+List accountsWthName =
_accountDao.findAccountsLike(accountName);
Review comment:
@anuragaw nit: Is variable name `accountsWthName` without **i**
intentional? Same in block for remove
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] svenvogel commented on issue #3371: Fix template size for managed storage / refactor cloud-install-sys-tmplt and createtmplt.sh
svenvogel commented on issue #3371: Fix template size for managed storage / refactor cloud-install-sys-tmplt and createtmplt.sh URL: https://github.com/apache/cloudstack/pull/3371#issuecomment-501154240 @rhtyd can you run the blueorangutan/trillian again? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3371: Fix template size for managed storage / refactor cloud-install-sys-tmplt and createtmplt.sh
blueorangutan commented on issue #3371: Fix template size for managed storage / refactor cloud-install-sys-tmplt and createtmplt.sh URL: https://github.com/apache/cloudstack/pull/3371#issuecomment-501193674 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2884 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] nlindblo commented on issue #3321: Cannot associate a public IP to a new isolated network (4.12.0.0)
nlindblo commented on issue #3321: Cannot associate a public IP to a new isolated network (4.12.0.0) URL: https://github.com/apache/cloudstack/issues/3321#issuecomment-501208600 @svanharmelen am I right in assuming that this will be fixed at next Cloudstack release 4.13 if none of the above options will move forward ? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] svanharmelen edited a comment on issue #3321: Cannot associate a public IP to a new isolated network (4.12.0.0)
svanharmelen edited a comment on issue #3321: Cannot associate a public IP to a new isolated network (4.12.0.0) URL: https://github.com/apache/cloudstack/issues/3321#issuecomment-501217050 @nlindblo no problem! I think Packer should work as expected (it already updated to support 4.12. Terraform should work as well, except for creating certain network types. If you encounter any specific errors that seems other than mentioned here, please open an issue with the related tool. Thanks! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] nlindblo commented on issue #3321: Cannot associate a public IP to a new isolated network (4.12.0.0)
nlindblo commented on issue #3321: Cannot associate a public IP to a new isolated network (4.12.0.0) URL: https://github.com/apache/cloudstack/issues/3321#issuecomment-501225061 @svanharmelen I'm still getting "cannot unmarshal string into Go struct field DeployVirtualMachineResponse.ostypeid of type int64" when running packer 1.4.1 as per https://github.com/hashicorp/packer/issues/7557 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] ustcweizhou commented on issue #3394: cloudstack: fix forward merge issues
ustcweizhou commented on issue #3394: cloudstack: fix forward merge issues URL: https://github.com/apache/cloudstack/pull/3394#issuecomment-501205442 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] nlindblo commented on issue #3321: Cannot associate a public IP to a new isolated network (4.12.0.0)
nlindblo commented on issue #3321: Cannot associate a public IP to a new isolated network (4.12.0.0) URL: https://github.com/apache/cloudstack/issues/3321#issuecomment-501212364 @svanharmelen Sorry for being unclear, basically I mean if Packer & Terraform will work again after the 4.13 Cloudstack release or if I need to consider rolling back to 4.11 to continue using the Hashicorp tools This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd merged pull request #3394: cloudstack: fix forward merge issues
rhtyd merged pull request #3394: cloudstack: fix forward merge issues URL: https://github.com/apache/cloudstack/pull/3394 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[cloudstack] branch master updated: cloudstack: fix forward merge issues (#3394)
This is an automated email from the ASF dual-hosted git repository. rohit pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/master by this push: new f30d716 cloudstack: fix forward merge issues (#3394) f30d716 is described below commit f30d716452995f86bf4fbf09136b33bdc8548480 Author: Rohit Yadav AuthorDate: Wed Jun 12 16:38:58 2019 +0530 cloudstack: fix forward merge issues (#3394) - Fixes tests path from old layout to standard maven in src/test/java/ - Removed duplicate SnapshotManagerImpl at old path `server/src/com...` Signed-off-by: Rohit Yadav --- .../storage/configdrive/ConfigDriveTest.java |0 .../resource/XenServerStorageProcessorTest.java|0 .../cloudstack/ldap/ADLdapUserManagerImplTest.java |0 .../cloudstack/ldap/LdapAuthenticatorTest.java |0 .../storage/snapshot/SnapshotManagerImpl.java | 1444 5 files changed, 1444 deletions(-) diff --git a/engine/storage/configdrive/test/org/apache/cloudstack/storage/configdrive/ConfigDriveTest.java b/engine/storage/configdrive/src/test/java/org/apache/cloudstack/storage/configdrive/ConfigDriveTest.java similarity index 100% rename from engine/storage/configdrive/test/org/apache/cloudstack/storage/configdrive/ConfigDriveTest.java rename to engine/storage/configdrive/src/test/java/org/apache/cloudstack/storage/configdrive/ConfigDriveTest.java diff --git a/plugins/hypervisors/xenserver/test/com/cloud/hypervisor/xenserver/resource/XenServerStorageProcessorTest.java b/plugins/hypervisors/xenserver/src/test/java/com/cloud/hypervisor/xenserver/resource/XenServerStorageProcessorTest.java similarity index 100% rename from plugins/hypervisors/xenserver/test/com/cloud/hypervisor/xenserver/resource/XenServerStorageProcessorTest.java rename to plugins/hypervisors/xenserver/src/test/java/com/cloud/hypervisor/xenserver/resource/XenServerStorageProcessorTest.java diff --git a/plugins/user-authenticators/ldap/test/org/apache/cloudstack/ldap/ADLdapUserManagerImplTest.java b/plugins/user-authenticators/ldap/src/test/java/org/apache/cloudstack/ldap/ADLdapUserManagerImplTest.java similarity index 100% rename from plugins/user-authenticators/ldap/test/org/apache/cloudstack/ldap/ADLdapUserManagerImplTest.java rename to plugins/user-authenticators/ldap/src/test/java/org/apache/cloudstack/ldap/ADLdapUserManagerImplTest.java diff --git a/plugins/user-authenticators/ldap/test/org/apache/cloudstack/ldap/LdapAuthenticatorTest.java b/plugins/user-authenticators/ldap/src/test/java/org/apache/cloudstack/ldap/LdapAuthenticatorTest.java similarity index 100% rename from plugins/user-authenticators/ldap/test/org/apache/cloudstack/ldap/LdapAuthenticatorTest.java rename to plugins/user-authenticators/ldap/src/test/java/org/apache/cloudstack/ldap/LdapAuthenticatorTest.java diff --git a/server/src/com/cloud/storage/snapshot/SnapshotManagerImpl.java b/server/src/com/cloud/storage/snapshot/SnapshotManagerImpl.java deleted file mode 100755 index 07eb072..000 --- a/server/src/com/cloud/storage/snapshot/SnapshotManagerImpl.java +++ /dev/null @@ -1,1444 +0,0 @@ -// Licensed to the Apache Software Foundation (ASF) under one -// or more contributor license agreements. See the NOTICE file -// distributed with this work for additional information -// regarding copyright ownership. The ASF licenses this file -// to you under the Apache License, Version 2.0 (the -// "License"); you may not use this file except in compliance -// with the License. You may obtain a copy of the License at -// -// http://www.apache.org/licenses/LICENSE-2.0 -// -// Unless required by applicable law or agreed to in writing, -// software distributed under the License is distributed on an -// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY -// KIND, either express or implied. See the License for the -// specific language governing permissions and limitations -// under the License. -package com.cloud.storage.snapshot; - -import com.cloud.agent.api.Answer; -import com.cloud.utils.db.GlobalLock; -import com.cloud.agent.api.Command; -import com.cloud.agent.api.DeleteSnapshotsDirCommand; -import com.cloud.alert.AlertManager; -import com.cloud.api.commands.ListRecurringSnapshotScheduleCmd; -import com.cloud.api.query.MutualExclusiveIdsManagerBase; -import com.cloud.configuration.Config; -import com.cloud.configuration.Resource.ResourceType; -import com.cloud.dc.ClusterVO; -import com.cloud.dc.dao.ClusterDao; -import com.cloud.domain.dao.DomainDao; -import com.cloud.event.ActionEvent; -import com.cloud.event.ActionEventUtils; -import com.cloud.event.EventTypes; -import com.cloud.event.EventVO; -import com.cloud.event.UsageEventUtils; -import com.cloud.exception.InvalidParameterValueException; -import com.cloud.exception.PermissionDeniedException; -import com.cloud.exception.ResourceAllocationException; -import
[GitHub] [cloudstack] svanharmelen commented on issue #3321: Cannot associate a public IP to a new isolated network (4.12.0.0)
svanharmelen commented on issue #3321: Cannot associate a public IP to a new isolated network (4.12.0.0) URL: https://github.com/apache/cloudstack/issues/3321#issuecomment-501234383 If you look at the [CHANGELOG](https://github.com/hashicorp/packer/blob/master/CHANGELOG.md) you'll see that the CloudStack fix is not part of `1.4.1` but is merged into master and will be part of the `1.4.2` release. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] svanharmelen commented on issue #3321: Cannot associate a public IP to a new isolated network (4.12.0.0)
svanharmelen commented on issue #3321: Cannot associate a public IP to a new isolated network (4.12.0.0) URL: https://github.com/apache/cloudstack/issues/3321#issuecomment-501211503 @nlindblo please define `this will be fixed`? Not sure what you mean with `this` here This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] svanharmelen commented on issue #3321: Cannot associate a public IP to a new isolated network (4.12.0.0)
svanharmelen commented on issue #3321: Cannot associate a public IP to a new isolated network (4.12.0.0) URL: https://github.com/apache/cloudstack/issues/3321#issuecomment-501217050 @nlindblo no problem! I think Packer should work as expected (it already updated to support 4.12. Terraform should work as well, except for creating certain network types. If you encounter any specific errors that seems other then mentioned here, please open an issue with the related tool. Thanks! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] darkfiberiru opened a new issue #3401: Support for bhyve hypervisor on FreeBSD
darkfiberiru opened a new issue #3401: Support for bhyve hypervisor on FreeBSD URL: https://github.com/apache/cloudstack/issues/3401 # ISSUE TYPE * Enhancement Request # COMPONENT NAME ~~~ Hypervisor ~~~ # CLOUDSTACK VERSION ~~~ 4.12 All ~~~ # CONFIGURATION Bhyve as hypervisor on freebsd # OS / ENVIRONMENT N/A # SUMMARY Currrently bhyve isn't a supported hypervisor. Bhyve has some libvirt support. Need to clarify what work needs done to integrate bhyve as an option for hypervisor. Ticket has been open on jira for 5 years https://issues.apache.org/jira/projects/CLOUDSTACK/issues/CLOUDSTACK-8206 # STEPS TO REPRODUCE This would allow FreeBSD hypervisor hosts # EXPECTED RESULTS Able to spin up a bhyve hypervisor and add it to cloudstack # ACTUAL RESULTS No support This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] darkfiberiru commented on issue #3401: Support for bhyve hypervisor on FreeBSD
darkfiberiru commented on issue #3401: Support for bhyve hypervisor on FreeBSD URL: https://github.com/apache/cloudstack/issues/3401#issuecomment-501350201 I would appreciate any help with understanding the scope of work for this integration. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] richardlawley opened a new issue #3402: VPC RVR: On deleting first tier and configuring Private GW both VRs becoming MASTER
richardlawley opened a new issue #3402: VPC RVR: On deleting first tier and configuring Private GW both VRs becoming MASTER URL: https://github.com/apache/cloudstack/issues/3402 # ISSUE TYPE * Bug Report # COMPONENT NAME ~~~ VPC VR ~~~ # CLOUDSTACK VERSION ~~~ 4.11.2+ ~~~ # CONFIGURATION Redundant VPC # OS / ENVIRONMENT N/A # SUMMARY I'm creating this bug report to track [CLOUDSTACK-9885](https://issues.apache.org/jira/browse/CLOUDSTACK-9885), since there's nothing in any milestones over here for it. A PR #2128 was created, but the PR wasn't completed an alternative solution proposed. #2719 attempted to address the general situation, but missed the specifics of needing to delete a tier. Short version - VPC with Deleted Tier and Private Gateway may have keepalived configured on the private gateway, leading to both VRs in MASTER. # STEPS TO REPRODUCE 1. Create Redundant VPC, configure a Tier 1 (+deploy VM) 2. Add Private Gateway 3. Add Tier 2 (+deploy VM) 4. Delete Tier 1 # EXPECTED RESULTS Keepalived should be configured on the interface for Tier 2 # ACTUAL RESULTS Keepalived was configured on the interface for Private Gateway (first interface with traffic type = Guest) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3241: [WIP DO NOT MERGE] Allow users to share templates with Accounts or Projects through the
blueorangutan commented on issue #3241: [WIP DO NOT MERGE] Allow users to share templates with Accounts or Projects through the URL: https://github.com/apache/cloudstack/pull/3241#issuecomment-501286862 Trillian test result (tid-3688) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 26434 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3241-t3688-kvm-centos7.zip Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py Intermittent failure detected: /marvin/tests/smoke/test_iso.py Smoke tests completed. 71 look OK, 0 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd opened a new issue #3400: Allow normal users to download template when template are not extractable
rhtyd opened a new issue #3400: Allow normal users to download template when template are not extractable URL: https://github.com/apache/cloudstack/issues/3400 On VMware env, a user is unable to download the template without having the extractable option enabled. It is reported from the user that the option to enable the extractable parameter in project view is unavailable for normal users and the same is in the default view. (may need an investigation to confirm). The same options may be provided while creating a template from a volume snapshot. # ISSUE TYPE * Bug Report # COMPONENT NAME ~~~ VMware, templates ~~~ # CLOUDSTACK VERSION ~~~ 4.11.2.0 ~~~ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3394: cloudstack: fix forward merge issues
rhtyd commented on issue #3394: cloudstack: fix forward merge issues URL: https://github.com/apache/cloudstack/pull/3394#issuecomment-501171950 @shwstppr @anuragaw @ustcweizhou @DaanHoogland - please review, thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3398: server: save GUID for KVM cluster
rhtyd commented on issue #3398: server: save GUID for KVM cluster URL: https://github.com/apache/cloudstack/pull/3398#issuecomment-501171685 @ustcweizhou this is not a critical/blocker issue, and only reproducible when there is no KVM host in a cluster that gets successfully added within the default/hardcoded wait time (of 2*5 mins). Sure, feel free to backport to 4.11. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] ustcweizhou commented on issue #3400: Allow normal users to download template when template are not extractable
ustcweizhou commented on issue #3400: Allow normal users to download template when template are not extractable URL: https://github.com/apache/cloudstack/issues/3400#issuecomment-501309890 as far as I know only the owner can change the option. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] Doni7722 commented on issue #3339: Duplicate tags cause DB constraint exceptions
Doni7722 commented on issue #3339: Duplicate tags cause DB constraint exceptions URL: https://github.com/apache/cloudstack/issues/3339#issuecomment-501328330 I did install CloudStack 4.11.3 RC to test the new behaviour but saw that it is still producing an unexpected exception. In my point of view it should produce an error where it says "cannot create tag because tag already exists" or something but not an unexpected one like it does under 4.11.3 RC. Here the error I got: ``` 2019-06-12 17:11:43,910 ERROR [cloud.api.ApiAsyncJobDispatcher] (API-Job-Executor-17:ctx-26a1d782 job-820) Unexpected exception while executing org.apache.cloudstack.api.command.user.tag.CreateTagsCmd com.cloud.utils.exception.CloudRuntimeException: tag test already on UserVm with id 70f33af9-498d-464f-acda-6e57c85a61fd at com.cloud.tags.TaggedResourceManagerImpl$1.doInTransactionWithoutResult(TaggedResourceManagerImpl.java:317) at com.cloud.utils.db.TransactionCallbackNoReturn.doInTransaction(TransactionCallbackNoReturn.java:25) at com.cloud.utils.db.Transaction$2.doInTransaction(Transaction.java:50) at com.cloud.utils.db.Transaction.execute(Transaction.java:40) at com.cloud.utils.db.Transaction.execute(Transaction.java:47) at com.cloud.tags.TaggedResourceManagerImpl.createTags(TaggedResourceManagerImpl.java:288) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) at org.springframework.aop.support.AopUtils.invokeJoinpointUsingReflection(AopUtils.java:338) at org.springframework.aop.framework.ReflectiveMethodInvocation.invokeJoinpoint(ReflectiveMethodInvocation.java:197) at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:163) at org.apache.cloudstack.network.contrail.management.EventUtils$EventInterceptor.invoke(EventUtils.java:107) at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:174) at com.cloud.event.ActionEventInterceptor.invoke(ActionEventInterceptor.java:51) at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:174) at org.springframework.aop.interceptor.ExposeInvocationInterceptor.invoke(ExposeInvocationInterceptor.java:92) at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:185) at org.springframework.aop.framework.JdkDynamicAopProxy.invoke(JdkDynamicAopProxy.java:212) at com.sun.proxy.$Proxy307.createTags(Unknown Source) at org.apache.cloudstack.api.command.user.tag.CreateTagsCmd.execute(CreateTagsCmd.java:117) at com.cloud.api.ApiDispatcher.dispatch(ApiDispatcher.java:150) at com.cloud.api.ApiAsyncJobDispatcher.runJob(ApiAsyncJobDispatcher.java:108) at org.apache.cloudstack.framework.jobs.impl.AsyncJobManagerImpl$5.runInContext(AsyncJobManagerImpl.java:581) at org.apache.cloudstack.managed.context.ManagedContextRunnable$1.run(ManagedContextRunnable.java:49) at org.apache.cloudstack.managed.context.impl.DefaultManagedContext$1.call(DefaultManagedContext.java:56) at org.apache.cloudstack.managed.context.impl.DefaultManagedContext.callWithContext(DefaultManagedContext.java:103) at org.apache.cloudstack.managed.context.impl.DefaultManagedContext.runWithContext(DefaultManagedContext.java:53) at org.apache.cloudstack.managed.context.ManagedContextRunnable.run(ManagedContextRunnable.java:46) at org.apache.cloudstack.framework.jobs.impl.AsyncJobManagerImpl$5.run(AsyncJobManagerImpl.java:529) at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) at java.util.concurrent.FutureTask.run(FutureTask.java:266) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) at java.lang.Thread.run(Thread.java:748) Caused by: javax.persistence.EntityExistsException: Entity already exists: at com.cloud.utils.db.GenericDaoBase.persist(GenericDaoBase.java:1434) at sun.reflect.GeneratedMethodAccessor124.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ... 46 more Caused by: com.mysql.jdbc.exceptions.jdbc4.MySQLIntegrityConstraintViolationException: Duplicate entry '67-UserVm-test' for key 'i_tags__resource_id__resource_type__key'
[GitHub] [cloudstack] rhtyd commented on issue #3152: Refactoring to remove duplicate code.
rhtyd commented on issue #3152: Refactoring to remove duplicate code. URL: https://github.com/apache/cloudstack/pull/3152#issuecomment-501441134 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3152: Refactoring to remove duplicate code.
blueorangutan commented on issue #3152: Refactoring to remove duplicate code. URL: https://github.com/apache/cloudstack/pull/3152#issuecomment-501441503 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3152: Refactoring to remove duplicate code.
rhtyd commented on issue #3152: Refactoring to remove duplicate code. URL: https://github.com/apache/cloudstack/pull/3152#issuecomment-501449655 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd merged pull request #3382: ui: fix instance and functionality
rhtyd merged pull request #3382: ui: fix instance and functionality URL: https://github.com/apache/cloudstack/pull/3382 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[cloudstack] branch master updated: ui: fix instance selection behaviour (#3382)
This is an automated email from the ASF dual-hosted git repository.
rohit pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git
The following commit(s) were added to refs/heads/master by this push:
new d6edfdc ui: fix instance selection behaviour (#3382)
d6edfdc is described below
commit d6edfdc24cd3bb27b3c20156a409506c156033be
Author: Nico Wohlfarth
AuthorDate: Wed Jun 12 22:14:18 2019 +0200
ui: fix instance selection behaviour (#3382)
- Fixed a bug, where after sorting a column of the instance list view the
multi select action buttons wouldn't show up after selecting one ore more
entries of the table.
- Added a behavior, so that an already starting/running/stopped/stopping
instance of the instance view will (when multi selected alone or together with
other instances) not create an API request if it already has the desired state.
---
ui/scripts/instances.js | 128 +-
ui/scripts/ui/dialog.js | 4 +-
ui/scripts/ui/widgets/listView.js | 17 ++---
3 files changed, 84 insertions(+), 65 deletions(-)
diff --git a/ui/scripts/instances.js b/ui/scripts/instances.js
index 30bff8a..c0693f7 100644
--- a/ui/scripts/instances.js
+++ b/ui/scripts/instances.js
@@ -79,39 +79,47 @@
},
action: function(args) {
var instances = args.context.instances;
- $(instances).map(function(index, instance) {
-var data = {
- id: instance.id
-};
-if (args.$form.find('.form-item[rel=hostId]').css("display") !=
"none" && args.data.hostId != -1) {
- $.extend(data, {
-hostid: args.data.hostId
- });
-}
-$.ajax({
- url: createURL("startVirtualMachine"),
- data: data,
- dataType: "json",
- async: true,
- success: function(json) {
-var jid = json.startvirtualmachineresponse.jobid;
-args.response.success({
- _custom: {
-jobId: jid,
-getUpdatedItem: function(json) {
- return
json.queryasyncjobresultresponse.jobresult.virtualmachine;
-},
-getActionFilter: function() {
- return cloudStack.actionFilter.vmActionFilter;
-}
- }
+ var skippedInstances = 0;
+ $(instances).each(function(index, instance) {
+if (instance.state === 'Running' || instance.state === "Starting")
{
+ skippedInstances++;
+} else {
+ var data = {
+id: instance.id
+ };
+ if (args.$form.find('.form-item[rel=hostId]').css("display") !=
"none" && args.data.hostId != -1) {
+$.extend(data, {
+ hostid: args.data.hostId
});
- },
- error: function(json) {
-args.response.error(parseXMLHttpResponse(json));
}
-});
+ $.ajax({
+url: createURL("startVirtualMachine"),
+data: data,
+dataType: "json",
+async: true,
+success: function(json) {
+ var jid = json.startvirtualmachineresponse.jobid;
+ args.response.success({
+_custom: {
+ jobId: jid,
+ getUpdatedItem: function(json) {
+return
json.queryasyncjobresultresponse.jobresult.virtualmachine;
+ },
+ getActionFilter: function() {
+return cloudStack.actionFilter.vmActionFilter;
+ }
+}
+ });
+},
+error: function(json) {
+ args.response.error(parseXMLHttpResponse(json));
+}
+ });
+}
});
+ if (skippedInstances === instances.length) {
+args.response.error();
+ }
},
notification: {
poll: pollAsyncJobResult
@@ -155,34 +163,42 @@
},
action: function(args) {
var instances = args.context.instances;
-$(instances).map(function(index, instance) {
-var data = {
-id: instance.id,
-forced: (args.data.forced == "on")
-};
-$.ajax({
-url: createURL("stopVirtualMachine"),
-data: data,
-dataType: "json",
-success: function(json) {
-var jid = json.stopvirtualmachineresponse.jobid;
-
[GitHub] [cloudstack] blueorangutan commented on issue #3390: Add more info for creating volume snapshots
blueorangutan commented on issue #3390: Add more info for creating volume snapshots URL: https://github.com/apache/cloudstack/pull/3390#issuecomment-501439299 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3390: Add more info for creating volume snapshots
rhtyd commented on issue #3390: Add more info for creating volume snapshots URL: https://github.com/apache/cloudstack/pull/3390#issuecomment-501439042 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3152: Refactoring to remove duplicate code.
blueorangutan commented on issue #3152: Refactoring to remove duplicate code. URL: https://github.com/apache/cloudstack/pull/3152#issuecomment-501449850 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[cloudstack] branch master updated: ui: alignment fixes (#3395)
This is an automated email from the ASF dual-hosted git repository.
rohit pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git
The following commit(s) were added to refs/heads/master by this push:
new 8f9f526 ui: alignment fixes (#3395)
8f9f526 is described below
commit 8f9f526f83a66a7b5bf8bdf72bc0ef9536b57d55
Author: Nico Wohlfarth
AuthorDate: Wed Jun 12 22:17:01 2019 +0200
ui: alignment fixes (#3395)
- Moved some recently made CSS changes (46a3279 / 2020bfb) to their newly
introduced respective SCSS files
- Aligned the dashboard containers properly (see screenshots 1 and 2)
- Restored the original quick view tooltip background color (see
screenshots 3 and 4)
- Fixed the height of the toolbar in dialog views and also stretched it in
width (see screenshots 5 and 6
---
ui/css/cloudstack3.css | 60 ++
ui/css/src/scss/cloudstack3.scss | 1 +
ui/css/src/scss/components/blocking-overlay.scss | 31 +++
ui/css/src/scss/components/dashboard.scss | 42 +++
ui/css/src/scss/components/list-view.scss | 2 +-
ui/css/src/scss/components/multi-wizzard.scss | 21 +---
ui/css/src/scss/components/quick-view-tooltip.scss | 3 +-
7 files changed, 96 insertions(+), 64 deletions(-)
diff --git a/ui/css/cloudstack3.css b/ui/css/cloudstack3.css
index 5ef4a58..0d17cdc 100644
--- a/ui/css/cloudstack3.css
+++ b/ui/css/cloudstack3.css
@@ -565,18 +565,18 @@ body.login {
}
.blocking-overlay {
+ opacity: 0.7;
position: absolute;
- width: 100%;
- height: 100%;
- left: 0px;
- top: 0px;
- background: #F2F2F2;
z-index: 500;
+ top: 0;
+ left: 0;
+ width: 100%;
/*+opacity:70%;*/
+ height: 100%;
+ background: #f2f2f2;
filter: alpha(opacity=70);
-ms-filter: progid:DXImageTransform.Microsoft.Alpha(Opacity=70);
-moz-opacity: 0.7;
- opacity: 0.7;
}
.loading-overlay {
@@ -1555,11 +1555,12 @@ div.list-view
td.state.notsuitable-storage-migration-required span {
display: none !important;
}
-.quick-view-tooltip .detail-view .ui-tabs-panel {
+.quick-view-tooltip .detail-view.ui-tabs div.ui-tabs-panel {
display: inline-block;
float: left;
width: 100% !important;
height: auto;
+ background-color: inherit;
overflow: hidden;
}
@@ -4206,8 +4207,6 @@ textarea {
}
.dashboard.admin .dashboard-container {
- margin: 0 0 11px;
- padding: 0 8px 18px 0;
/*+border-radius:3px;*/
border: 1px solid #c8c2c2;
border-radius: 3px;
@@ -4218,7 +4217,7 @@ textarea {
}
.dashboard.admin .dashboard-container.sub {
- width: 468px;
+ width: 49.5%;
}
.dashboard.admin .dashboard-container.sub .button.view-all,
@@ -4274,13 +4273,15 @@ textarea {
/ Head*/
.dashboard.admin .dashboard-container.head {
float: left;
- width: 966px;
- height: 431px;
+ box-sizing: border-box;
+ width: 100%;
margin: 9px 0 0;
+ padding: 0 0;
}
.dashboard.admin .dashboard-container .top {
float: left;
+ box-sizing: border-box;
width: 100%;
margin: 0;
padding: 4px 4px 8px;
@@ -4334,29 +4335,22 @@ textarea {
/ Charts / stats*/
.dashboard.admin .zone-stats {
position: relative;
- top: 0;
- left: 0;
- width: 974px;
- /*+placement:shift 0px 0px;*/
- height: 416px;
+ width: 100%;
+ padding: 11px 0;
overflow: auto;
overflow-x: hidden;
}
.dashboard.admin .zone-stats ul {
position: relative;
- /*+placement:shift -2px 11px;*/
- top: 11px;
- left: -2px;
- width: 996px;
+ width: 100%;
}
.dashboard.admin .zone-stats ul li {
- position: absolute;
position: relative;
z-index: 1;
float: left;
- width: 488px;
+ width: 50%;
height: 79px;
font-size: 14px;
cursor: pointer;
@@ -4533,20 +4527,23 @@ textarea {
.dashboard.admin .dashboard-container.sub.alerts {
position: relative;
float: left;
- height: 170px;
- margin: 0 12px 0 0;
+ box-sizing: border-box;
+ height: 190px;
overflow: hidden;
}
-.dashboard.admin .dashboard-container.sub.alerts.last {
- margin-right: 0;
+.dashboard.admin .dashboard-container.sub.alerts.first {
+ margin-right: 1%;
+}
+
+.dashboard.admin .dashboard-container.sub.alerts .top {
+ height: 18%;
}
.dashboard.admin .dashboard-container.sub.alerts ul {
position: relative;
- width: 468px;
- height: 100%;
- margin: 0 0 0 8px;
+ width: 100%;
+ height: 82%;
overflow-y: scroll;
}
@@ -7597,7 +7594,6 @@ textarea {
div.toolbar,
.multi-wizard.zone-wizard .select-container .field .select-array-item {
display: block;
- height: 1px;
}
div.toolbar:after,
@@ -7818,7 +7814,7 @@ div.toolbar:after,
.ui-dialog .list-view .toolbar {
top: 50px;
- width: 854px;
+ width: 100%;
}
div.panel.ui-dialog div.list-view div.fixed-header {
diff --git a/ui/css/src/scss/cloudstack3.scss b/ui/css/src/scss/cloudstack3.scss
index 5a20e0d..0d523ca 100644
--- a/ui/css/src/scss/cloudstack3.scss
+++
[GitHub] [cloudstack] rhtyd merged pull request #3395: ui: adaptations
rhtyd merged pull request #3395: ui: adaptations URL: https://github.com/apache/cloudstack/pull/3395 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3371: Fix template size for managed storage / refactor cloud-install-sys-tmplt and createtmplt.sh
blueorangutan commented on issue #3371: Fix template size for managed storage / refactor cloud-install-sys-tmplt and createtmplt.sh URL: https://github.com/apache/cloudstack/pull/3371#issuecomment-501439982 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3152: Refactoring to remove duplicate code.
blueorangutan commented on issue #3152: Refactoring to remove duplicate code. URL: https://github.com/apache/cloudstack/pull/3152#issuecomment-501448549 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2885 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3371: Fix template size for managed storage / refactor cloud-install-sys-tmplt and createtmplt.sh
rhtyd commented on issue #3371: Fix template size for managed storage / refactor cloud-install-sys-tmplt and createtmplt.sh URL: https://github.com/apache/cloudstack/pull/3371#issuecomment-501439599 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] anuragaw commented on a change in pull request #3241: [WIP DO NOT MERGE] Allow users to share templates with Accounts or Projects through the
anuragaw commented on a change in pull request #3241: [WIP DO NOT MERGE] Allow
users to share templates with Accounts or Projects through the
URL: https://github.com/apache/cloudstack/pull/3241#discussion_r293198072
##
File path: server/src/main/java/com/cloud/template/TemplateManagerImpl.java
##
@@ -1541,14 +1539,23 @@ public boolean
updateTemplateOrIsoPermissions(BaseUpdateTemplateOrIsoPermissions
//Derive the domain id from the template owner as
updateTemplatePermissions is not cross domain operation
Account owner = _accountMgr.getAccount(ownerId);
final Domain domain = _domainDao.findById(owner.getDomainId());
+final boolean isCallerRootAdmin =
_accountMgr.isRootAdmin(caller.getAccountId());
if ("add".equalsIgnoreCase(operation)) {
final List accountNamesFinal = accountNames;
final List accountIds = new ArrayList();
Transaction.execute(new TransactionCallbackNoReturn() {
@Override
public void doInTransactionWithoutResult(TransactionStatus
status) {
for (String accountName : accountNamesFinal) {
-Account permittedAccount =
_accountDao.findActiveAccount(accountName, domain.getId());
+Account permittedAccount = null;
+if (isCallerRootAdmin) {
+List accountsWthName =
_accountDao.findAccountsLike(accountName);
Review comment:
changing
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3390: Add more info for creating volume snapshots
blueorangutan commented on issue #3390: Add more info for creating volume snapshots URL: https://github.com/apache/cloudstack/pull/3390#issuecomment-501537973 Trillian test result (tid-3689) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 25608 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3390-t3689-kvm-centos7.zip Smoke tests completed. 71 look OK, 0 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3152: Refactoring to remove duplicate code.
blueorangutan commented on issue #3152: Refactoring to remove duplicate code. URL: https://github.com/apache/cloudstack/pull/3152#issuecomment-501545298 Trillian test result (tid-3691) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 26532 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3152-t3691-kvm-centos7.zip Smoke tests completed. 71 look OK, 0 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
