[GitHub] [cloudstack] blueorangutan commented on issue #3540: [WIP DO NOT MERGE] VM ingestion

2019-09-11 Thread GitBox
blueorangutan commented on issue #3540: [WIP DO NOT MERGE] VM ingestion
URL: https://github.com/apache/cloudstack/pull/3540#issuecomment-530667981
 
 
   Trillian test result (tid-353)
   Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 35082 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3540-t353-xenserver-71.zip
   Intermittent failure detected: /marvin/tests/smoke/test_scale_vm.py
   Smoke tests completed. 76 look OK, 1 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_01_scale_vm | `Failure` | 23.94 | test_scale_vm.py
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #3540: [WIP DO NOT MERGE] VM ingestion

2019-09-11 Thread GitBox
blueorangutan commented on issue #3540: [WIP DO NOT MERGE] VM ingestion
URL: https://github.com/apache/cloudstack/pull/3540#issuecomment-530666421
 
 
   Trillian test result (tid-351)
   Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 35456 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3540-t351-vmware-65u2.zip
   Smoke tests completed. 77 look OK, 0 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #3540: [WIP DO NOT MERGE] VM ingestion

2019-09-11 Thread GitBox
blueorangutan commented on issue #3540: [WIP DO NOT MERGE] VM ingestion
URL: https://github.com/apache/cloudstack/pull/3540#issuecomment-530656734
 
 
   Trillian test result (tid-350)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 32125 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3540-t350-kvm-centos7.zip
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Smoke tests completed. 76 look OK, 1 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_05_rvpc_multi_tiers | `Failure` | 416.14 | test_vpc_redundant.py
   test_05_rvpc_multi_tiers | `Error` | 442.54 | test_vpc_redundant.py
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] nvazquez opened a new pull request #3595: [WIP] KVM dynamic VM scaling

2019-09-11 Thread GitBox
nvazquez opened a new pull request #3595: [WIP] KVM dynamic VM scaling
URL: https://github.com/apache/cloudstack/pull/3595
 
 
   ## Description
   Work in progress: Enable VM scaling for KVM
   
   ## Types of changes
   - [x] Enhancement (improves an existing feature and functionality)
   
   ## Screenshots (if appropriate):
   
   ## How Has This Been Tested?
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #3510: [WIP DO NOT MERGE] Allow additional config to vms

2019-09-11 Thread GitBox
blueorangutan commented on issue #3510: [WIP DO NOT MERGE] Allow additional 
config to vms
URL: https://github.com/apache/cloudstack/pull/3510#issuecomment-530593931
 
 
   Packaging result: ✖centos6 ✔centos7 ✔debian. JID-275


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #3510: [WIP DO NOT MERGE] Allow additional config to vms

2019-09-11 Thread GitBox
blueorangutan commented on issue #3510: [WIP DO NOT MERGE] Allow additional 
config to vms
URL: https://github.com/apache/cloudstack/pull/3510#issuecomment-530588844
 
 
   @anuragaw a Jenkins job has been kicked to build packages. I'll keep you 
posted as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] anuragaw commented on issue #3510: [WIP DO NOT MERGE] Allow additional config to vms

2019-09-11 Thread GitBox
anuragaw commented on issue #3510: [WIP DO NOT MERGE] Allow additional config 
to vms
URL: https://github.com/apache/cloudstack/pull/3510#issuecomment-530588768
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] borisstoyanov commented on issue #3593: Not able to call scripts with get diagnostics

2019-09-11 Thread GitBox
borisstoyanov commented on issue #3593: Not able to call scripts with get 
diagnostics
URL: https://github.com/apache/cloudstack/issues/3593#issuecomment-530567590
 
 
   Yes, the env is fresh installed and router should have these changes in it 
@anuragaw 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] rhtyd commented on issue #3553: [WIP] [DO NOT MERGE] CloudStack Backup & Recovery Framework

2019-09-11 Thread GitBox
rhtyd commented on issue #3553: [WIP] [DO NOT MERGE] CloudStack Backup & 
Recovery Framework
URL: https://github.com/apache/cloudstack/pull/3553#issuecomment-530561098
 
 
   @svenvogel yes Veeam is a supported provider plugin 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] svenvogel edited a comment on issue #3575: [WIP DO NOT MERGE] Health check feature for virtual router

2019-09-11 Thread GitBox
svenvogel edited a comment on issue #3575: [WIP DO NOT MERGE] Health check 
feature for virtual router
URL: https://github.com/apache/cloudstack/pull/3575#issuecomment-530552633
 
 
   @anuragaw i like definitively this feature. how does it work?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] svenvogel commented on issue #3575: [WIP DO NOT MERGE] Health check feature for virtual router

2019-09-11 Thread GitBox
svenvogel commented on issue #3575: [WIP DO NOT MERGE] Health check feature for 
virtual router
URL: https://github.com/apache/cloudstack/pull/3575#issuecomment-530552633
 
 
   @anuragaw i like definitively this feature.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] svenvogel commented on issue #3553: [WIP] [DO NOT MERGE] CloudStack Backup & Recovery Framework

2019-09-11 Thread GitBox
svenvogel commented on issue #3553: [WIP] [DO NOT MERGE] CloudStack Backup & 
Recovery Framework
URL: https://github.com/apache/cloudstack/pull/3553#issuecomment-530551417
 
 
   @rhtyd small questions. which provider does this mean? Veeam?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] svenvogel commented on issue #3594: Support for KVM dynamic scaling

2019-09-11 Thread GitBox
svenvogel commented on issue #3594: Support for KVM dynamic scaling
URL: https://github.com/apache/cloudstack/issues/3594#issuecomment-530549677
 
 
   @kiwiflyer is that call for a feature request?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #3575: [WIP DO NOT MERGE] Health check feature for virtual router

2019-09-11 Thread GitBox
blueorangutan commented on issue #3575: [WIP DO NOT MERGE] Health check feature 
for virtual router
URL: https://github.com/apache/cloudstack/pull/3575#issuecomment-530549217
 
 
   Packaging result: ✔centos6 ✖centos7 ✔debian. JID-274


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #3425: [WIP DO NOT MERGE] Better tracking host maintanence success and failure

2019-09-11 Thread GitBox
blueorangutan commented on issue #3425: [WIP DO NOT MERGE] Better tracking host 
maintanence success and failure
URL: https://github.com/apache/cloudstack/pull/3425#issuecomment-530549216
 
 
   Packaging result: ✔centos6 ✖centos7 ✔debian. JID-272


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #3510: [WIP DO NOT MERGE] Allow additional config to vms

2019-09-11 Thread GitBox
blueorangutan commented on issue #3510: [WIP DO NOT MERGE] Allow additional 
config to vms
URL: https://github.com/apache/cloudstack/pull/3510#issuecomment-530549218
 
 
   Packaging result: ✔centos6 ✖centos7 ✔debian. JID-273


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] kiwiflyer opened a new issue #3594: Support for KVM dynamic scaling

2019-09-11 Thread GitBox
kiwiflyer opened a new issue #3594: Support for KVM dynamic scaling
URL: https://github.com/apache/cloudstack/issues/3594
 
 
   Support the ability to dynamically scale or change multiple config 
components in a libvirt configuration.
   
   Initial support for vCPU, Memory, bandwidth limits, IOP min,max and burt 
limits.
   
   @rhtyd @skattoju4 @ustcweizhou @PaulAngus @rafaelweingartner  
@nathanejohnson 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #3575: [WIP DO NOT MERGE] Health check feature for virtual router

2019-09-11 Thread GitBox
blueorangutan commented on issue #3575: [WIP DO NOT MERGE] Health check feature 
for virtual router
URL: https://github.com/apache/cloudstack/pull/3575#issuecomment-530528400
 
 
   @anuragaw a Jenkins job has been kicked to build packages. I'll keep you 
posted as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] anuragaw commented on issue #3575: [WIP DO NOT MERGE] Health check feature for virtual router

2019-09-11 Thread GitBox
anuragaw commented on issue #3575: [WIP DO NOT MERGE] Health check feature for 
virtual router
URL: https://github.com/apache/cloudstack/pull/3575#issuecomment-530528130
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #3510: [WIP DO NOT MERGE] Allow additional config to vms

2019-09-11 Thread GitBox
blueorangutan commented on issue #3510: [WIP DO NOT MERGE] Allow additional 
config to vms
URL: https://github.com/apache/cloudstack/pull/3510#issuecomment-530527154
 
 
   @anuragaw a Jenkins job has been kicked to build packages. I'll keep you 
posted as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] anuragaw commented on issue #3510: [WIP DO NOT MERGE] Allow additional config to vms

2019-09-11 Thread GitBox
anuragaw commented on issue #3510: [WIP DO NOT MERGE] Allow additional config 
to vms
URL: https://github.com/apache/cloudstack/pull/3510#issuecomment-530526837
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #3425: [WIP DO NOT MERGE] Better tracking host maintanence success and failure

2019-09-11 Thread GitBox
blueorangutan commented on issue #3425: [WIP DO NOT MERGE] Better tracking host 
maintanence success and failure
URL: https://github.com/apache/cloudstack/pull/3425#issuecomment-530525303
 
 
   @anuragaw a Jenkins job has been kicked to build packages. I'll keep you 
posted as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] anuragaw commented on issue #3425: [WIP DO NOT MERGE] Better tracking host maintanence success and failure

2019-09-11 Thread GitBox
anuragaw commented on issue #3425: [WIP DO NOT MERGE] Better tracking host 
maintanence success and failure
URL: https://github.com/apache/cloudstack/pull/3425#issuecomment-530525042
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] anuragaw commented on issue #3593: Not able to call scripts with get diagnostics

2019-09-11 Thread GitBox
anuragaw commented on issue #3593: Not able to call scripts with get diagnostics
URL: https://github.com/apache/cloudstack/issues/3593#issuecomment-530524149
 
 
   Can you see if the router was patched with the scripts that is expected to 
run @borisstoyanov ? I mean if the VR was created and then you upgraded to this 
feature, the older VRs could be missing that script. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #3540: [WIP DO NOT MERGE] VM ingestion

2019-09-11 Thread GitBox
blueorangutan commented on issue #3540: [WIP DO NOT MERGE] VM ingestion
URL: https://github.com/apache/cloudstack/pull/3540#issuecomment-530514339
 
 
   @borisstoyanov a Trillian-Jenkins matrix job (centos6 mgmt + xs71, centos7 
mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] borisstoyanov commented on issue #3540: [WIP DO NOT MERGE] VM ingestion

2019-09-11 Thread GitBox
borisstoyanov commented on issue #3540: [WIP DO NOT MERGE] VM ingestion
URL: https://github.com/apache/cloudstack/pull/3540#issuecomment-530513988
 
 
   @blueorangutan test matrix


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] borisstoyanov commented on issue #3593: Not able to call scripts with get diagnostics

2019-09-11 Thread GitBox
borisstoyanov commented on issue #3593: Not able to call scripts with get 
diagnostics
URL: https://github.com/apache/cloudstack/issues/3593#issuecomment-530512323
 
 
   ping @anuragaw 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] borisstoyanov opened a new issue #3593: Not able to call scripts with get diagnostics

2019-09-11 Thread GitBox
borisstoyanov opened a new issue #3593: Not able to call scripts with get 
diagnostics
URL: https://github.com/apache/cloudstack/issues/3593
 
 
   
   
   # ISSUE TYPE
   
* Bug Report
   
   
   # COMPONENT NAME
   
   ~~~
   API, get diagnostics 
   ~~~
   
   # CLOUDSTACK VERSION
   
   
   ~~~
   4.13
   ~~~
   
   # CONFIGURATION
   
   
   
   # OS / ENVIRONMENT
   
   
   
   # SUMMARY
   
   get diagnostics fails to execute a script when called. I've setup a script 
that would create some files locally on the VR in the /opt/cloud/bin dir, but 
when calling it via the api and UI with [script]
   it does not run. 
   related to #3350 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] Jerem28 commented on issue #3580: Vmware hypervisor : enhance Mac OS compatibility

2019-09-11 Thread GitBox
Jerem28 commented on issue #3580: Vmware hypervisor : enhance Mac OS 
compatibility
URL: https://github.com/apache/cloudstack/pull/3580#issuecomment-530398157
 
 
   @DaanHoogland Actually, we have templates (Mac OS 10.13 High Sierra and 
10.14 Mojave) but with licenses belonging to where I work. So I can't share 
them. About Apple, we don't have informations from them. We've decided to set 
up this feature for our Cloudstack users purpose.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #3350: Get Diagnostics: Download logs and diagnostics data from SSVM, CPVM, Router

2019-09-11 Thread GitBox
blueorangutan commented on issue #3350: Get Diagnostics: Download logs and 
diagnostics data from SSVM, CPVM, Router
URL: https://github.com/apache/cloudstack/pull/3350#issuecomment-530364211
 
 
   @DaanHoogland a Trillian-Jenkins matrix job (centos6 mgmt + xs71, centos7 
mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] DaanHoogland commented on issue #3350: Get Diagnostics: Download logs and diagnostics data from SSVM, CPVM, Router

2019-09-11 Thread GitBox
DaanHoogland commented on issue #3350: Get Diagnostics: Download logs and 
diagnostics data from SSVM, CPVM, Router
URL: https://github.com/apache/cloudstack/pull/3350#issuecomment-530363895
 
 
   @blueorangutan test matrix


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] DaanHoogland commented on issue #3584: Unexpected Error when creating VM Snapshot on Stopped VM

2019-09-11 Thread GitBox
DaanHoogland commented on issue #3584: Unexpected Error when creating VM 
Snapshot on Stopped VM
URL: https://github.com/apache/cloudstack/issues/3584#issuecomment-530362480
 
 
   @mihle @luhaijiao What is the use of a VM snapshot when a VM is stopped? The 
only tangible thing is the disk image as a stopped VM does not have memory 
state.
   Isn't it completely appropriate to be not be able to take a VM snapshot 
(irrespective of the unclear error output)?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3576: [WIP] vmware: try to find exact file when multiple files are returned

2019-09-11 Thread GitBox
DaanHoogland commented on a change in pull request #3576: [WIP] vmware: try to 
find exact file when multiple files are returned
URL: https://github.com/apache/cloudstack/pull/3576#discussion_r323209218
 
 

 ##
 File path: 
vmware-base/src/main/java/com/cloud/hypervisor/vmware/mo/DatastoreMO.java
 ##
 @@ -416,22 +414,39 @@ public String searchFileInSubFolders(String fileName, 
boolean caseInsensitive, S
 s_logger.error(msg);
 throw new CloudException(msg);
 }
+String parentFolderPath;
+String absoluteFileName = null;
 for (HostDatastoreBrowserSearchResults result : results) {
 List info = result.getFile();
 if (info != null && info.size() > 0) {
 for (FileInfo fi : info) {
-absoluteFileName = parentFolderPath = 
result.getFolderPath();
-s_logger.info("Found file " + fileName + " in datastore at 
" + absoluteFileName);
-if (parentFolderPath.endsWith("]"))
-absoluteFileName += " ";
-absoluteFileName += fi.getPath();
-if(isValidCloudStackFolderPath(parentFolderPath, 
searchExcludedFolders)) {
+String possibleFilename = null;
+possibleFilename = parentFolderPath = 
result.getFolderPath();
 
 Review comment:
   should this double assignment really be here? it does not make the code 
clearer.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services