[GitHub] [cloudstack] andrijapanicsb commented on issue #3682: ui: fix migrate host form no host popup

2019-11-14 Thread GitBox
andrijapanicsb commented on issue #3682: ui: fix migrate host form no host popup URL: https://github.com/apache/cloudstack/pull/3682#issuecomment-553891135 I have done that Rohit check my previous comment. This is an

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3635: server: acquire IPv4 address when add secondary IP to nic if IP is not specified

2019-11-14 Thread GitBox
DaanHoogland commented on a change in pull request #3635: server: acquire IPv4 address when add secondary IP to nic if IP is not specified URL: https://github.com/apache/cloudstack/pull/3635#discussion_r346391870 ## File path:

[GitHub] [cloudstack] DaanHoogland commented on issue #3632: add class cleanup method

2019-11-14 Thread GitBox
DaanHoogland commented on issue #3632: add class cleanup method URL: https://github.com/apache/cloudstack/pull/3632#issuecomment-553950690 @blueorangutan package This is an automated message from the Apache Git Service.

[GitHub] [cloudstack] blueorangutan commented on issue #3632: add class cleanup method

2019-11-14 Thread GitBox
blueorangutan commented on issue #3632: add class cleanup method URL: https://github.com/apache/cloudstack/pull/3632#issuecomment-553950773 @DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] [cloudstack] GabrielBrascher edited a comment on issue #3186: Add possibility to set KVM MTU size for all NIC

2019-11-14 Thread GitBox
GabrielBrascher edited a comment on issue #3186: Add possibility to set KVM MTU size for all NIC URL: https://github.com/apache/cloudstack/pull/3186#issuecomment-553909811 @svenvogel I am testing it right now; should have feedback soon (based on code and manual tests).

[GitHub] [cloudstack] rhtyd commented on issue #3682: ui: fix migrate host form no host popup

2019-11-14 Thread GitBox
rhtyd commented on issue #3682: ui: fix migrate host form no host popup URL: https://github.com/apache/cloudstack/pull/3682#issuecomment-553888766 This can be merged if someone can manually QA/test to confirm. cc @andrijapanicsb @borisstoyanov

[GitHub] [cloudstack] DaanHoogland commented on issue #3669: server: Fix resource count of primary storage/volume because of Expunged volumes

2019-11-14 Thread GitBox
DaanHoogland commented on issue #3669: server: Fix resource count of primary storage/volume because of Expunged volumes URL: https://github.com/apache/cloudstack/pull/3669#issuecomment-553954929 @rakgenius @weizhouapache makes perfect sense. Have you looked at the usage server and billing

[GitHub] [cloudstack] weizhouapache commented on a change in pull request #3635: server: acquire IPv4 address when add secondary IP to nic if IP is not specified

2019-11-14 Thread GitBox
weizhouapache commented on a change in pull request #3635: server: acquire IPv4 address when add secondary IP to nic if IP is not specified URL: https://github.com/apache/cloudstack/pull/3635#discussion_r346405230 ## File path:

[GitHub] [cloudstack] DennisKonrad commented on issue #3179: Redundant VRouter guest network on wrong interface

2019-11-14 Thread GitBox
DennisKonrad commented on issue #3179: Redundant VRouter guest network on wrong interface URL: https://github.com/apache/cloudstack/issues/3179#issuecomment-553940664 @weizhouapache I found that the json the router receives really does not have the "nic_dev_id" set at all. Therefor the

[GitHub] [cloudstack] weizhouapache commented on issue #3179: Redundant VRouter guest network on wrong interface

2019-11-14 Thread GitBox
weizhouapache commented on issue #3179: Redundant VRouter guest network on wrong interface URL: https://github.com/apache/cloudstack/issues/3179#issuecomment-553952656 @DennisKonrad I reverted #2304, and it works

[GitHub] [cloudstack] GabrielBrascher commented on issue #3186: Add possibility to set KVM MTU size for all NIC

2019-11-14 Thread GitBox
GabrielBrascher commented on issue #3186: Add possibility to set KVM MTU size for all NIC URL: https://github.com/apache/cloudstack/pull/3186#issuecomment-553909811 @svenvogel I am testing it right now; should have a feedback soon (based on code and manual tests).

[GitHub] [cloudstack] ustcweizhou opened a new pull request #3688: New feature: Add support to destroy/recover volumes

2019-11-14 Thread GitBox
ustcweizhou opened a new pull request #3688: New feature: Add support to destroy/recover volumes URL: https://github.com/apache/cloudstack/pull/3688 ## Description cloudstack provides options to destroy and recover a vm. For volumes, we do not have

[GitHub] [cloudstack] blueorangutan commented on issue #3632: add class cleanup method

2019-11-14 Thread GitBox
blueorangutan commented on issue #3632: add class cleanup method URL: https://github.com/apache/cloudstack/pull/3632#issuecomment-553960255 Packaging result: ✖centos6 ✔centos7 ✔debian. JID-356 This is an automated message

[GitHub] [cloudstack] andrijapanicsb merged pull request #3682: ui: fix migrate host form no host popup

2019-11-14 Thread GitBox
andrijapanicsb merged pull request #3682: ui: fix migrate host form no host popup URL: https://github.com/apache/cloudstack/pull/3682 This is an automated message from the Apache Git Service. To respond to the message,

[cloudstack] branch master updated (96d98de -> c8681f5)

2019-11-14 Thread andrijapanic
This is an automated email from the ASF dual-hosted git repository. andrijapanic pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git. from 96d98de Merge remote-tracking branch 'origin/4.13' add c8681f5 ui: fix migrate host form no host

[GitHub] [cloudstack] anuragaw commented on issue #3425: [WIP DO NOT MERGE] Better tracking host maintanence success and failure

2019-11-14 Thread GitBox
anuragaw commented on issue #3425: [WIP DO NOT MERGE] Better tracking host maintanence success and failure URL: https://github.com/apache/cloudstack/pull/3425#issuecomment-554025507 @blueorangutan package This is an

[GitHub] [cloudstack] blueorangutan commented on issue #3425: [WIP DO NOT MERGE] Better tracking host maintanence success and failure

2019-11-14 Thread GitBox
blueorangutan commented on issue #3425: [WIP DO NOT MERGE] Better tracking host maintanence success and failure URL: https://github.com/apache/cloudstack/pull/3425#issuecomment-554025636 @anuragaw a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] [cloudstack] anuragaw commented on issue #3425: [WIP DO NOT MERGE] Better tracking host maintanence success and failure

2019-11-14 Thread GitBox
anuragaw commented on issue #3425: [WIP DO NOT MERGE] Better tracking host maintanence success and failure URL: https://github.com/apache/cloudstack/pull/3425#issuecomment-554038431 @blueorangutan package This is an

[GitHub] [cloudstack] blueorangutan commented on issue #3425: [WIP DO NOT MERGE] Better tracking host maintanence success and failure

2019-11-14 Thread GitBox
blueorangutan commented on issue #3425: [WIP DO NOT MERGE] Better tracking host maintanence success and failure URL: https://github.com/apache/cloudstack/pull/3425#issuecomment-554038613 @anuragaw a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] [cloudstack] blueorangutan commented on issue #3617: [KVM] Agent LB Fix: Connections from disabled KVM host agents are refused

2019-11-14 Thread GitBox
blueorangutan commented on issue #3617: [KVM] Agent LB Fix: Connections from disabled KVM host agents are refused URL: https://github.com/apache/cloudstack/pull/3617#issuecomment-554021164 Trillian test result (tid-476) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server

[GitHub] [cloudstack] GabrielBrascher commented on a change in pull request #3659: Fix typo: the past tense of shutdown is shutdown, not shutdowned

2019-11-14 Thread GitBox
GabrielBrascher commented on a change in pull request #3659: Fix typo: the past tense of shutdown is shutdown, not shutdowned URL: https://github.com/apache/cloudstack/pull/3659#discussion_r346482546 ## File path: api/src/main/java/com/cloud/vm/VirtualMachine.java ## @@

[GitHub] [cloudstack] blueorangutan commented on issue #3425: [WIP DO NOT MERGE] Better tracking host maintanence success and failure

2019-11-14 Thread GitBox
blueorangutan commented on issue #3425: [WIP DO NOT MERGE] Better tracking host maintanence success and failure URL: https://github.com/apache/cloudstack/pull/3425#issuecomment-554033879 Packaging result: ✖centos6 ✔centos7 ✔debian. JID-357

[GitHub] [cloudstack] anuragaw commented on a change in pull request #3425: [WIP DO NOT MERGE] Better tracking host maintanence success and failure

2019-11-14 Thread GitBox
anuragaw commented on a change in pull request #3425: [WIP DO NOT MERGE] Better tracking host maintanence success and failure URL: https://github.com/apache/cloudstack/pull/3425#discussion_r346508319 ## File path: test/integration/smoke/test_host_maintenance.py ## @@

[GitHub] [cloudstack] blueorangutan commented on issue #3425: [WIP DO NOT MERGE] Better tracking host maintanence success and failure

2019-11-14 Thread GitBox
blueorangutan commented on issue #3425: [WIP DO NOT MERGE] Better tracking host maintanence success and failure URL: https://github.com/apache/cloudstack/pull/3425#issuecomment-554046454 Packaging result: ✖centos6 ✔centos7 ✔debian. JID-358

[GitHub] [cloudstack] anuragaw commented on issue #3425: [WIP DO NOT MERGE] Better tracking host maintanence success and failure

2019-11-14 Thread GitBox
anuragaw commented on issue #3425: [WIP DO NOT MERGE] Better tracking host maintanence success and failure URL: https://github.com/apache/cloudstack/pull/3425#issuecomment-554047905 ping for review - @rhtyd , @nvazquez , @shwstppr , @DaanHoogland , @borisstoyanov

[GitHub] [cloudstack] anuragaw commented on issue #3425: [WIP DO NOT MERGE] Better tracking host maintanence success and failure

2019-11-14 Thread GitBox
anuragaw commented on issue #3425: [WIP DO NOT MERGE] Better tracking host maintanence success and failure URL: https://github.com/apache/cloudstack/pull/3425#issuecomment-554046870 @blueorangutan test This is an automated

[GitHub] [cloudstack] blueorangutan commented on issue #3425: [WIP DO NOT MERGE] Better tracking host maintanence success and failure

2019-11-14 Thread GitBox
blueorangutan commented on issue #3425: [WIP DO NOT MERGE] Better tracking host maintanence success and failure URL: https://github.com/apache/cloudstack/pull/3425#issuecomment-554047384 @anuragaw a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[GitHub] [cloudstack] anuragaw commented on issue #3425: [WIP DO NOT MERGE] Better tracking host maintanence success and failure

2019-11-14 Thread GitBox
anuragaw commented on issue #3425: [WIP DO NOT MERGE] Better tracking host maintanence success and failure URL: https://github.com/apache/cloudstack/pull/3425#issuecomment-554198020 @blueorangutan test This is an automated

[GitHub] [cloudstack] blueorangutan commented on issue #3425: [WIP DO NOT MERGE] Better tracking host maintanence success and failure

2019-11-14 Thread GitBox
blueorangutan commented on issue #3425: [WIP DO NOT MERGE] Better tracking host maintanence success and failure URL: https://github.com/apache/cloudstack/pull/3425#issuecomment-554198132 @anuragaw a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[GitHub] [cloudstack] GabrielBrascher commented on a change in pull request #3186: Add possibility to set KVM MTU size for all NIC

2019-11-14 Thread GitBox
GabrielBrascher commented on a change in pull request #3186: Add possibility to set KVM MTU size for all NIC URL: https://github.com/apache/cloudstack/pull/3186#discussion_r346628250 ## File path:

[GitHub] [cloudstack] GabrielBrascher commented on a change in pull request #3186: Add possibility to set KVM MTU size for all NIC

2019-11-14 Thread GitBox
GabrielBrascher commented on a change in pull request #3186: Add possibility to set KVM MTU size for all NIC URL: https://github.com/apache/cloudstack/pull/3186#discussion_r346473236 ## File path:

[GitHub] [cloudstack] GabrielBrascher commented on a change in pull request #3186: Add possibility to set KVM MTU size for all NIC

2019-11-14 Thread GitBox
GabrielBrascher commented on a change in pull request #3186: Add possibility to set KVM MTU size for all NIC URL: https://github.com/apache/cloudstack/pull/3186#discussion_r346597181 ## File path:

[GitHub] [cloudstack] GabrielBrascher commented on a change in pull request #3186: Add possibility to set KVM MTU size for all NIC

2019-11-14 Thread GitBox
GabrielBrascher commented on a change in pull request #3186: Add possibility to set KVM MTU size for all NIC URL: https://github.com/apache/cloudstack/pull/3186#discussion_r346622474 ## File path:

[GitHub] [cloudstack] GabrielBrascher commented on a change in pull request #3186: Add possibility to set KVM MTU size for all NIC

2019-11-14 Thread GitBox
GabrielBrascher commented on a change in pull request #3186: Add possibility to set KVM MTU size for all NIC URL: https://github.com/apache/cloudstack/pull/3186#discussion_r346624532 ## File path: server/src/main/java/com/cloud/vm/UserVmManagerImpl.java ## @@ -1054,7

[GitHub] [cloudstack] GabrielBrascher commented on a change in pull request #3186: Add possibility to set KVM MTU size for all NIC

2019-11-14 Thread GitBox
GabrielBrascher commented on a change in pull request #3186: Add possibility to set KVM MTU size for all NIC URL: https://github.com/apache/cloudstack/pull/3186#discussion_r346625196 ## File path: server/src/main/java/com/cloud/vm/UserVmManagerImpl.java ## @@ -2083,31

[GitHub] [cloudstack] GabrielBrascher commented on a change in pull request #3186: Add possibility to set KVM MTU size for all NIC

2019-11-14 Thread GitBox
GabrielBrascher commented on a change in pull request #3186: Add possibility to set KVM MTU size for all NIC URL: https://github.com/apache/cloudstack/pull/3186#discussion_r346597181 ## File path:

[GitHub] [cloudstack] andrijapanicsb commented on issue #3617: [KVM] Agent LB Fix: Connections from disabled KVM host agents are refused

2019-11-14 Thread GitBox
andrijapanicsb commented on issue #3617: [KVM] Agent LB Fix: Connections from disabled KVM host agents are refused URL: https://github.com/apache/cloudstack/pull/3617#issuecomment-553800862 @blueorangutan test This is an

[GitHub] [cloudstack] blueorangutan commented on issue #3617: [KVM] Agent LB Fix: Connections from disabled KVM host agents are refused

2019-11-14 Thread GitBox
blueorangutan commented on issue #3617: [KVM] Agent LB Fix: Connections from disabled KVM host agents are refused URL: https://github.com/apache/cloudstack/pull/3617#issuecomment-553801212 @andrijapanicsb a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run

[GitHub] [cloudstack] borisstoyanov opened a new issue #3684: With Chrome you cannot edit domain level settings

2019-11-14 Thread GitBox
borisstoyanov opened a new issue #3684: With Chrome you cannot edit domain level settings URL: https://github.com/apache/cloudstack/issues/3684 Chrome version: Version 78.0.3904.97 (Official Build) (64-bit) Automatically update Chrome for all users Learn more ![Screenshot

[GitHub] [cloudstack] borisstoyanov opened a new issue #3685: no way to unlink account/domain from ldap

2019-11-14 Thread GitBox
borisstoyanov opened a new issue #3685: no way to unlink account/domain from ldap URL: https://github.com/apache/cloudstack/issues/3685 ``` (localcloud) SBCM5> > link domaintoldap domainid=5a155ee3-70dd-4549-9d29-4c926530a8f0 type=group

[GitHub] [cloudstack] borisstoyanov opened a new issue #3687: Domain admins not able to add LDAP users

2019-11-14 Thread GitBox
borisstoyanov opened a new issue #3687: Domain admins not able to add LDAP users URL: https://github.com/apache/cloudstack/issues/3687 # ISSUE TYPE * Improvement Request # COMPONENT NAME ~~~ UI, API ~~~ # CLOUDSTACK VERSION

[GitHub] [cloudstack] borisstoyanov opened a new issue #3686: Domain level ldap server configuration is not displayed

2019-11-14 Thread GitBox
borisstoyanov opened a new issue #3686: Domain level ldap server configuration is not displayed URL: https://github.com/apache/cloudstack/issues/3686 # ISSUE TYPE * Bug Report # COMPONENT NAME ~~~ UI ~~~ # CLOUDSTACK VERSION

[GitHub] [cloudstack] weizhouapache commented on issue #3179: Redundant VRouter guest network on wrong interface

2019-11-14 Thread GitBox
weizhouapache commented on issue #3179: Redundant VRouter guest network on wrong interface URL: https://github.com/apache/cloudstack/issues/3179#issuecomment-553839855 @DennisKonrad I will test it as well This is an

[GitHub] [cloudstack] weizhouapache commented on issue #3686: Domain level ldap server configuration is not displayed

2019-11-14 Thread GitBox
weizhouapache commented on issue #3686: Domain level ldap server configuration is not displayed URL: https://github.com/apache/cloudstack/issues/3686#issuecomment-553839109 @borisstoyanov listall=true ? This is an automated

[GitHub] [cloudstack] borisstoyanov commented on issue #3686: Domain level ldap server configuration is not displayed

2019-11-14 Thread GitBox
borisstoyanov commented on issue #3686: Domain level ldap server configuration is not displayed URL: https://github.com/apache/cloudstack/issues/3686#issuecomment-553839977 I believe there's not such option: ``` (localcloud) SBCM5> > list ldapusers listtype= (localcloud)

[GitHub] [cloudstack] anuragaw commented on issue #3575: [WIP DO NOT MERGE] Health check feature for virtual router

2019-11-14 Thread GitBox
anuragaw commented on issue #3575: [WIP DO NOT MERGE] Health check feature for virtual router URL: https://github.com/apache/cloudstack/pull/3575#issuecomment-553844262 ping for review - @rhtyd , @nvazquez , @shwstppr , @DaanHoogland. Thanks guys!