[GitHub] [cloudstack] andrijapanicsb commented on pull request #4117: [VMware] Explicitly controlling VM hardware version

2020-06-15 Thread GitBox
andrijapanicsb commented on pull request #4117: URL: https://github.com/apache/cloudstack/pull/4117#issuecomment-644329050 @blueorangutan test centos7 vmware-67u3 This is an automated message from the Apache Git Service. To

[GitHub] [cloudstack] rhtyd removed a comment on pull request #4117: [VMware] Explicitly controlling VM hardware version

2020-06-15 Thread GitBox
rhtyd removed a comment on pull request #4117: URL: https://github.com/apache/cloudstack/pull/4117#issuecomment-643530366 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [cloudstack] blueorangutan removed a comment on pull request #4117: [VMware] Explicitly controlling VM hardware version

2020-06-15 Thread GitBox
blueorangutan removed a comment on pull request #4117: URL: https://github.com/apache/cloudstack/pull/4117#issuecomment-643060324 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [cloudstack] blueorangutan commented on pull request #4103: [VMware] Enable unmanaging guest VMs

2020-06-15 Thread GitBox
blueorangutan commented on pull request #4103: URL: https://github.com/apache/cloudstack/pull/4103#issuecomment-644356909 @nvazquez a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests

[GitHub] [cloudstack] blueorangutan commented on pull request #4131: [HEALTH] Master/4.15 Health Check please don't merge this

2020-06-15 Thread GitBox
blueorangutan commented on pull request #4131: URL: https://github.com/apache/cloudstack/pull/4131#issuecomment-644289307 Trillian test result (tid-1726) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 43318 seconds Marvin logs:

[GitHub] [cloudstack] blueorangutan commented on pull request #4103: [VMware] Enable unmanaging guest VMs

2020-06-15 Thread GitBox
blueorangutan commented on pull request #4103: URL: https://github.com/apache/cloudstack/pull/4103#issuecomment-644316198 @nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] [cloudstack] nvazquez commented on pull request #4103: [VMware] Enable unmanaging guest VMs

2020-06-15 Thread GitBox
nvazquez commented on pull request #4103: URL: https://github.com/apache/cloudstack/pull/4103#issuecomment-644315562 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [cloudstack] blueorangutan commented on pull request #4131: [HEALTH] Master/4.15 Health Check please don't merge this

2020-06-15 Thread GitBox
blueorangutan commented on pull request #4131: URL: https://github.com/apache/cloudstack/pull/4131#issuecomment-644315475 @DaanHoogland a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware67, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests

[GitHub] [cloudstack] nvazquez commented on pull request #4103: [VMware] Enable unmanaging guest VMs

2020-06-15 Thread GitBox
nvazquez commented on pull request #4103: URL: https://github.com/apache/cloudstack/pull/4103#issuecomment-644355995 @blueorangutan test centos7 vmware-67u3 This is an automated message from the Apache Git Service. To

[GitHub] [cloudstack] blueorangutan commented on pull request #4145: Fixing listVirtualMachinesMetrics to extend ListVMsCmd instead of ListVMsCmdByAdmin

2020-06-15 Thread GitBox
blueorangutan commented on pull request #4145: URL: https://github.com/apache/cloudstack/pull/4145#issuecomment-644302721 Trillian test result (tid-1727) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 37511 seconds Marvin logs:

[GitHub] [cloudstack] DaanHoogland commented on pull request #4131: [HEALTH] Master/4.15 Health Check please don't merge this

2020-06-15 Thread GitBox
DaanHoogland commented on pull request #4131: URL: https://github.com/apache/cloudstack/pull/4131#issuecomment-644315229 @blueorangutan test matrix This is an automated message from the Apache Git Service. To respond to the

[GitHub] [cloudstack] blueorangutan commented on pull request #4103: [VMware] Enable unmanaging guest VMs

2020-06-15 Thread GitBox
blueorangutan commented on pull request #4103: URL: https://github.com/apache/cloudstack/pull/4103#issuecomment-644330040 Packaging result: ✔centos7 ✔debian. JID-1378 This is an automated message from the Apache Git Service.

[GitHub] [cloudstack] blueorangutan commented on pull request #4117: [VMware] Explicitly controlling VM hardware version

2020-06-15 Thread GitBox
blueorangutan commented on pull request #4117: URL: https://github.com/apache/cloudstack/pull/4117#issuecomment-644329627 @andrijapanicsb a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests

[GitHub] [cloudstack] andrijapanicsb commented on pull request #4117: [VMware] Explicitly controlling VM hardware version

2020-06-15 Thread GitBox
andrijapanicsb commented on pull request #4117: URL: https://github.com/apache/cloudstack/pull/4117#issuecomment-644329616 > @rhtyd @Spaceman1984 could one of you test if we can drop the hardware version from the vmware svm template, bacause of this? ping @Spaceman1984 ^^^

[GitHub] [cloudstack] svenvogel commented on pull request #4103: [VMware] Enable unmanaging guest VMs

2020-06-15 Thread GitBox
svenvogel commented on pull request #4103: URL: https://github.com/apache/cloudstack/pull/4103#issuecomment-644386896 @nvazquez nice feature. Can you tell me where can be the use case for this that I understand this a little bit better? Cheers

[GitHub] [cloudstack] blueorangutan commented on pull request #4140: Adding showunique parameter to list templates and isos

2020-06-15 Thread GitBox
blueorangutan commented on pull request #4140: URL: https://github.com/apache/cloudstack/pull/4140#issuecomment-644524397 Packaging result: ✖centos7 ✖debian. JID-1379 This is an automated message from the Apache Git Service.

[GitHub] [cloudstack] blueorangutan commented on pull request #4132: Fix delete network with no services

2020-06-15 Thread GitBox
blueorangutan commented on pull request #4132: URL: https://github.com/apache/cloudstack/pull/4132#issuecomment-644528652 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This

[GitHub] [cloudstack] blueorangutan commented on pull request #4145: Fixing listVirtualMachinesMetrics to extend ListVMsCmd instead of ListVMsCmdByAdmin

2020-06-15 Thread GitBox
blueorangutan commented on pull request #4145: URL: https://github.com/apache/cloudstack/pull/4145#issuecomment-644541035 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[GitHub] [cloudstack] blueorangutan commented on pull request #4071: Dynamic roles improvements

2020-06-15 Thread GitBox
blueorangutan commented on pull request #4071: URL: https://github.com/apache/cloudstack/pull/4071#issuecomment-644544332 Packaging result: ✔centos7 ✖debian. JID-1383 This is an automated message from the Apache Git Service.

[GitHub] [cloudstack] nvazquez commented on pull request #4103: [VMware] Enable unmanaging guest VMs

2020-06-15 Thread GitBox
nvazquez commented on pull request #4103: URL: https://github.com/apache/cloudstack/pull/4103#issuecomment-644502098 @rhtyd this is ready for review now, thanks! This is an automated message from the Apache Git Service. To

[GitHub] [cloudstack] rhtyd commented on a change in pull request #4145: Fixing listVirtualMachinesMetrics to extend ListVMsCmd instead of ListVMsCmdByAdmin

2020-06-15 Thread GitBox
rhtyd commented on a change in pull request #4145: URL: https://github.com/apache/cloudstack/pull/4145#discussion_r440578482 ## File path: server/src/main/java/com/cloud/api/query/QueryManagerImpl.java ## @@ -781,7 +781,8 @@ Pair, Integer> result =

[GitHub] [cloudstack] blueorangutan commented on pull request #4068: Adding Centos8 Support

2020-06-15 Thread GitBox
blueorangutan commented on pull request #4068: URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-644544024 Packaging result: ✔centos7 ✖debian. JID-1382 This is an automated message from the Apache Git Service.

[GitHub] [cloudstack] rhtyd closed pull request #4140: Adding showunique parameter to list templates and isos

2020-06-15 Thread GitBox
rhtyd closed pull request #4140: URL: https://github.com/apache/cloudstack/pull/4140 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [cloudstack] blueorangutan commented on pull request #4145: Fixing listVirtualMachinesMetrics to extend ListVMsCmd instead of ListVMsCmdByAdmin

2020-06-15 Thread GitBox
blueorangutan commented on pull request #4145: URL: https://github.com/apache/cloudstack/pull/4145#issuecomment-644540495 Packaging result: ✔centos7 ✔debian. JID-1380 This is an automated message from the Apache Git Service.

[GitHub] [cloudstack] blueorangutan commented on pull request #4085: Fix duplicate user entries for vpn usage

2020-06-15 Thread GitBox
blueorangutan commented on pull request #4085: URL: https://github.com/apache/cloudstack/pull/4085#issuecomment-644540494 Packaging result: ✖centos7 ✖debian. JID-1381 This is an automated message from the Apache Git Service.

[GitHub] [cloudstack] blueorangutan commented on pull request #3998: NPE when VM is planned to migrate to other host during dynamic scaling

2020-06-15 Thread GitBox
blueorangutan commented on pull request #3998: URL: https://github.com/apache/cloudstack/pull/3998#issuecomment-644544991 Packaging result: ✔centos7 ✖debian. JID-1384 This is an automated message from the Apache Git Service.

[GitHub] [cloudstack] blueorangutan commented on pull request #4145: Fixing listVirtualMachinesMetrics to extend ListVMsCmd instead of ListVMsCmdByAdmin

2020-06-15 Thread GitBox
blueorangutan commented on pull request #4145: URL: https://github.com/apache/cloudstack/pull/4145#issuecomment-643924992 @davidjumani a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] [cloudstack] blueorangutan commented on pull request #4140: Adding showunique parameter to list templates and isos

2020-06-15 Thread GitBox
blueorangutan commented on pull request #4140: URL: https://github.com/apache/cloudstack/pull/4140#issuecomment-643925431 Packaging result: ✔centos7 ✔debian. JID-1376 This is an automated message from the Apache Git Service.

[GitHub] [cloudstack] davidjumani opened a new pull request #4145: Fixing listVirtualMachinesMetrics to extend ListVMsCmd instead of ListVMsCmdByAdmin

2020-06-15 Thread GitBox
davidjumani opened a new pull request #4145: URL: https://github.com/apache/cloudstack/pull/4145 ## Description This fixes the issue of listVirtualMachinesMetrics to extend ListVMsCmd instead of ListVMsCmdByAdmin which is a potential security bug. It now only extends ListVMsCmd, so

[GitHub] [cloudstack] davidjumani commented on pull request #4145: Fixing listVirtualMachinesMetrics to extend ListVMsCmd instead of ListVMsCmdByAdmin

2020-06-15 Thread GitBox
davidjumani commented on pull request #4145: URL: https://github.com/apache/cloudstack/pull/4145#issuecomment-643924810 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the

[GitHub] [cloudstack] blueorangutan commented on pull request #4145: Fixing listVirtualMachinesMetrics to extend ListVMsCmd instead of ListVMsCmdByAdmin

2020-06-15 Thread GitBox
blueorangutan commented on pull request #4145: URL: https://github.com/apache/cloudstack/pull/4145#issuecomment-643934009 Packaging result: ✔centos7 ✔debian. JID-1377 This is an automated message from the Apache Git Service.

[GitHub] [cloudstack] davidjumani commented on issue #4136: UI doesn't allow login if sessionkey and JSESSIONID cookies are deleted

2020-06-15 Thread GitBox
davidjumani commented on issue #4136: URL: https://github.com/apache/cloudstack/issues/4136#issuecomment-643928188 Calling a logout after a 401 does not appear to solve this This is an automated message from the Apache Git

[GitHub] [cloudstack] davidjumani edited a comment on issue #4136: UI doesn't allow login if sessionkey and JSESSIONID cookies are deleted

2020-06-15 Thread GitBox
davidjumani edited a comment on issue #4136: URL: https://github.com/apache/cloudstack/issues/4136#issuecomment-643928188 Calling a logout after a 401 does not appear to solve this even before / after clearing cookies This

[GitHub] [cloudstack] GabrielBrascher commented on a change in pull request #4140: Adding showunique parameter to list templates and isos

2020-06-15 Thread GitBox
GabrielBrascher commented on a change in pull request #4140: URL: https://github.com/apache/cloudstack/pull/4140#discussion_r440521942 ## File path: api/src/main/java/org/apache/cloudstack/api/command/user/template/ListTemplatesCmd.java ## @@ -78,6 +78,9 @@

[GitHub] [cloudstack] rhtyd commented on pull request #4145: Fixing listVirtualMachinesMetrics to extend ListVMsCmd instead of ListVMsCmdByAdmin

2020-06-15 Thread GitBox
rhtyd commented on pull request #4145: URL: https://github.com/apache/cloudstack/pull/4145#issuecomment-644525865 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [cloudstack] blueorangutan commented on pull request #4145: Fixing listVirtualMachinesMetrics to extend ListVMsCmd instead of ListVMsCmdByAdmin

2020-06-15 Thread GitBox
blueorangutan commented on pull request #4145: URL: https://github.com/apache/cloudstack/pull/4145#issuecomment-644526086 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This

[GitHub] [cloudstack] rhtyd commented on pull request #4121: server: fix TransactionLegacy DB connection leaks due to DB switching by B thread

2020-06-15 Thread GitBox
rhtyd commented on pull request #4121: URL: https://github.com/apache/cloudstack/pull/4121#issuecomment-644526252 ping 3 - @nvazquez @harikrishna-patnala @sureshanaparti @shwstppr @andrijapanicsb @weizhouapache @svenvogel @andrijapanicsb @wido @GabrielBrascher

[GitHub] [cloudstack] div8cn opened a new issue #4147: RBD primary storage Rados secret does not support multiple '/'

2020-06-15 Thread GitBox
div8cn opened a new issue #4147: URL: https://github.com/apache/cloudstack/issues/4147 When adding RBD primary storage, if multiple "/" appear in Rados secret, the following error will be reported immediately UI: Failed to add data store: DB Exception on:

[GitHub] [cloudstack] blueorangutan removed a comment on pull request #4140: Adding showunique parameter to list templates and isos

2020-06-15 Thread GitBox
blueorangutan removed a comment on pull request #4140: URL: https://github.com/apache/cloudstack/pull/4140#issuecomment-644238386 Trillian test result (tid-1725) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 59803 seconds Marvin logs:

[GitHub] [cloudstack] rhtyd commented on pull request #4068: Adding Centos8 Support

2020-06-15 Thread GitBox
rhtyd commented on pull request #4068: URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-644527187 @shwstppr @davidjumani good work both! Please keep it as a draft until testing validates, thanks cc @borisstoyanov @vladimirpetrov @blueorangutan package

[GitHub] [cloudstack] blueorangutan commented on pull request #4068: Adding Centos8 Support

2020-06-15 Thread GitBox
blueorangutan commented on pull request #4068: URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-644527511 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This

[GitHub] [cloudstack] rhtyd commented on pull request #4070: Update cloud-set-guest-password.in

2020-06-15 Thread GitBox
rhtyd commented on pull request #4070: URL: https://github.com/apache/cloudstack/pull/4070#issuecomment-644527433 Merging based on code review and provided tests, esp followups by @svenvogel - smoketests won't test this script.

[GitHub] [cloudstack] blueorangutan commented on pull request #4085: Fix duplicate user entries for vpn usage

2020-06-15 Thread GitBox
blueorangutan commented on pull request #4085: URL: https://github.com/apache/cloudstack/pull/4085#issuecomment-644526842 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This

[GitHub] [cloudstack] rhtyd commented on pull request #4085: Fix duplicate user entries for vpn usage

2020-06-15 Thread GitBox
rhtyd commented on pull request #4085: URL: https://github.com/apache/cloudstack/pull/4085#issuecomment-644526543 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [cloudstack] blueorangutan commented on pull request #4007: Restarting all networks that needs a restart in a VPC

2020-06-15 Thread GitBox
blueorangutan commented on pull request #4007: URL: https://github.com/apache/cloudstack/pull/4007#issuecomment-644528738 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This

[GitHub] [cloudstack] blueorangutan commented on pull request #4132: Fix delete network with no services

2020-06-15 Thread GitBox
blueorangutan commented on pull request #4132: URL: https://github.com/apache/cloudstack/pull/4132#issuecomment-644528795 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This

[GitHub] [cloudstack] rhtyd commented on pull request #4007: Restarting all networks that needs a restart in a VPC

2020-06-15 Thread GitBox
rhtyd commented on pull request #4007: URL: https://github.com/apache/cloudstack/pull/4007#issuecomment-644528386 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the

[GitHub] [cloudstack] blueorangutan commented on pull request #3976: [Do not merge] Enable sending hypervior host name via metadata - VR and Config Drive

2020-06-15 Thread GitBox
blueorangutan commented on pull request #3976: URL: https://github.com/apache/cloudstack/pull/3976#issuecomment-644528578 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This

[GitHub] [cloudstack] blueorangutan commented on pull request #3998: NPE when VM is planned to migrate to other host during dynamic scaling

2020-06-15 Thread GitBox
blueorangutan commented on pull request #3998: URL: https://github.com/apache/cloudstack/pull/3998#issuecomment-644528452 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This

[GitHub] [cloudstack] rhtyd closed pull request #3991: Multiple dynamic VM Scaling APIs can create duplicate usage events for the same time

2020-06-15 Thread GitBox
rhtyd closed pull request #3991: URL: https://github.com/apache/cloudstack/pull/3991 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [cloudstack] nvazquez commented on pull request #4103: [VMware] Enable unmanaging guest VMs

2020-06-15 Thread GitBox
nvazquez commented on pull request #4103: URL: https://github.com/apache/cloudstack/pull/4103#issuecomment-644501901 Hi @svenvogel thanks! Use cases for this feature are mainly being able to perform any operations to virtual machines directly through vCenter - for example migrating a

[GitHub] [cloudstack] rhtyd commented on a change in pull request #4145: Fixing listVirtualMachinesMetrics to extend ListVMsCmd instead of ListVMsCmdByAdmin

2020-06-15 Thread GitBox
rhtyd commented on a change in pull request #4145: URL: https://github.com/apache/cloudstack/pull/4145#discussion_r440579318 ## File path: server/src/main/java/com/cloud/api/query/QueryManagerImpl.java ## @@ -781,7 +781,8 @@ Pair, Integer> result =

[GitHub] [cloudstack] blueorangutan commented on pull request #4140: Adding showunique parameter to list templates and isos

2020-06-15 Thread GitBox
blueorangutan commented on pull request #4140: URL: https://github.com/apache/cloudstack/pull/4140#issuecomment-644523194 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This

[GitHub] [cloudstack] rhtyd commented on pull request #4140: Adding showunique parameter to list templates and isos

2020-06-15 Thread GitBox
rhtyd commented on pull request #4140: URL: https://github.com/apache/cloudstack/pull/4140#issuecomment-644522925 @RodrigoDLopez can you help review/test after the final changes? Thanks. @blueorangutan package This is

[GitHub] [cloudstack] rhtyd merged pull request #4070: Update cloud-set-guest-password.in

2020-06-15 Thread GitBox
rhtyd merged pull request #4070: URL: https://github.com/apache/cloudstack/pull/4070 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[cloudstack] branch master updated: setup: Update cloud-set-guest-password.in (#4070)

2020-06-15 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/master by this push: new 3ac8194 setup: Update

[GitHub] [cloudstack] blueorangutan removed a comment on pull request #4132: Fix delete network with no services

2020-06-15 Thread GitBox
blueorangutan removed a comment on pull request #4132: URL: https://github.com/apache/cloudstack/pull/4132#issuecomment-643596771 Trillian test result (tid-1699) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 30463 seconds Marvin logs:

[GitHub] [cloudstack] rhtyd commented on pull request #4004: Fixed null pointer and deployment issue on Xenserver with L2 Guest network with configDrive

2020-06-15 Thread GitBox
rhtyd commented on pull request #4004: URL: https://github.com/apache/cloudstack/pull/4004#issuecomment-644527926 @borisstoyanov per your testing is this ready to be merged, or needs further testing, the case of multiple nics per Daan's comment?

[GitHub] [cloudstack] rhtyd commented on pull request #4071: Dynamic roles improvements

2020-06-15 Thread GitBox
rhtyd commented on pull request #4071: URL: https://github.com/apache/cloudstack/pull/4071#issuecomment-644528040 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [cloudstack] rhtyd commented on pull request #3976: [Do not merge] Enable sending hypervior host name via metadata - VR and Config Drive

2020-06-15 Thread GitBox
rhtyd commented on pull request #3976: URL: https://github.com/apache/cloudstack/pull/3976#issuecomment-644528223 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [cloudstack] rhtyd commented on pull request #3998: NPE when VM is planned to migrate to other host during dynamic scaling

2020-06-15 Thread GitBox
rhtyd commented on pull request #3998: URL: https://github.com/apache/cloudstack/pull/3998#issuecomment-644528334 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [cloudstack] rhtyd commented on pull request #4132: Fix delete network with no services

2020-06-15 Thread GitBox
rhtyd commented on pull request #4132: URL: https://github.com/apache/cloudstack/pull/4132#issuecomment-644528133 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the

[GitHub] [cloudstack] blueorangutan commented on pull request #4071: Dynamic roles improvements

2020-06-15 Thread GitBox
blueorangutan commented on pull request #4071: URL: https://github.com/apache/cloudstack/pull/4071#issuecomment-644528207 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This

[GitHub] [cloudstack] harikrishna-patnala edited a comment on pull request #3991: Multiple dynamic VM Scaling APIs can create duplicate usage events for the same time

2020-06-15 Thread GitBox
harikrishna-patnala edited a comment on pull request #3991: URL: https://github.com/apache/cloudstack/pull/3991#issuecomment-644530219 > @harikrishna-patnala can you check/comment on the failing Travis tests? The failed tests are not related to scale vm operations and the

[GitHub] [cloudstack] harikrishna-patnala commented on pull request #3991: Multiple dynamic VM Scaling APIs can create duplicate usage events for the same time

2020-06-15 Thread GitBox
harikrishna-patnala commented on pull request #3991: URL: https://github.com/apache/cloudstack/pull/3991#issuecomment-644530219 > @harikrishna-patnala can you check/comment on the failing Travis tests? The failed tests are not related to scale vm operations and the corresponding

[GitHub] [cloudstack] davidjumani commented on a change in pull request #4145: Fixing listVirtualMachinesMetrics to extend ListVMsCmd instead of ListVMsCmdByAdmin

2020-06-15 Thread GitBox
davidjumani commented on a change in pull request #4145: URL: https://github.com/apache/cloudstack/pull/4145#discussion_r440052548 ## File path: server/src/main/java/com/cloud/api/query/QueryManagerImpl.java ## @@ -781,7 +781,8 @@ Pair, Integer> result =

[GitHub] [cloudstack] rhtyd commented on issue #4136: UI doesn't allow login if sessionkey and JSESSIONID cookies are deleted

2020-06-15 Thread GitBox
rhtyd commented on issue #4136: URL: https://github.com/apache/cloudstack/issues/4136#issuecomment-644041371 @davidjumani can you experiment by removing all cookies and then call logout API? This is an automated message

[GitHub] [cloudstack] rhtyd commented on pull request #4004: Fixed null pointer and deployment issue on Xenserver with L2 Guest network with configDrive

2020-06-15 Thread GitBox
rhtyd commented on pull request #4004: URL: https://github.com/apache/cloudstack/pull/4004#issuecomment-643959743 @Spaceman1984 cc @nvazquez please advise, if you've tested then we can merge this This is an automated

[GitHub] [cloudstack] rhtyd commented on pull request #4103: [VMware] Enable unmanaging guest VMs

2020-06-15 Thread GitBox
rhtyd commented on pull request #4103: URL: https://github.com/apache/cloudstack/pull/4103#issuecomment-643959943 Thanks @nvazquez I'll add this to my todos/review pile. This is an automated message from the Apache Git

[GitHub] [cloudstack] Spaceman1984 commented on pull request #4004: Fixed null pointer and deployment issue on Xenserver with L2 Guest network with configDrive

2020-06-15 Thread GitBox
Spaceman1984 commented on pull request #4004: URL: https://github.com/apache/cloudstack/pull/4004#issuecomment-643962227 I didn't test multiple network interfaces. This is an automated message from the Apache Git Service. To

[GitHub] [cloudstack] davidjumani commented on pull request #4145: Fixing listVirtualMachinesMetrics to extend ListVMsCmd instead of ListVMsCmdByAdmin

2020-06-15 Thread GitBox
davidjumani commented on pull request #4145: URL: https://github.com/apache/cloudstack/pull/4145#issuecomment-643956160 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [cloudstack] andrijapanicsb commented on issue #4136: UI doesn't allow login if sessionkey and JSESSIONID cookies are deleted

2020-06-15 Thread GitBox
andrijapanicsb commented on issue #4136: URL: https://github.com/apache/cloudstack/issues/4136#issuecomment-644011134 When the issue happens (not able to login to /client), you can go to /client/primate, login and logout - then all is fine and you can login back to /client. Once this

[GitHub] [cloudstack] davidjumani commented on a change in pull request #4145: Fixing listVirtualMachinesMetrics to extend ListVMsCmd instead of ListVMsCmdByAdmin

2020-06-15 Thread GitBox
davidjumani commented on a change in pull request #4145: URL: https://github.com/apache/cloudstack/pull/4145#discussion_r440052548 ## File path: server/src/main/java/com/cloud/api/query/QueryManagerImpl.java ## @@ -781,7 +781,8 @@ Pair, Integer> result =

[GitHub] [cloudstack] weizhouapache commented on a change in pull request #4145: Fixing listVirtualMachinesMetrics to extend ListVMsCmd instead of ListVMsCmdByAdmin

2020-06-15 Thread GitBox
weizhouapache commented on a change in pull request #4145: URL: https://github.com/apache/cloudstack/pull/4145#discussion_r43565 ## File path: server/src/main/java/com/cloud/api/query/QueryManagerImpl.java ## @@ -781,7 +781,8 @@ Pair, Integer> result =

[GitHub] [cloudstack] blueorangutan commented on pull request #4145: Fixing listVirtualMachinesMetrics to extend ListVMsCmd instead of ListVMsCmdByAdmin

2020-06-15 Thread GitBox
blueorangutan commented on pull request #4145: URL: https://github.com/apache/cloudstack/pull/4145#issuecomment-643956617 @davidjumani a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[GitHub] [cloudstack] davidjumani commented on pull request #4140: Adding showunique parameter to list templates and isos

2020-06-15 Thread GitBox
davidjumani commented on pull request #4140: URL: https://github.com/apache/cloudstack/pull/4140#issuecomment-643957014 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [cloudstack] blueorangutan commented on pull request #4140: Adding showunique parameter to list templates and isos

2020-06-15 Thread GitBox
blueorangutan commented on pull request #4140: URL: https://github.com/apache/cloudstack/pull/4140#issuecomment-643957500 @davidjumani a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[GitHub] [cloudstack] davidjumani commented on pull request #4140: Adding showunique parameter to list templates and isos

2020-06-15 Thread GitBox
davidjumani commented on pull request #4140: URL: https://github.com/apache/cloudstack/pull/4140#issuecomment-643957323 @RodrigoDLopez could you run a test again ? This is an automated message from the Apache Git Service. To

[cloudstack-primate] branch master updated: README: update links

2020-06-15 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack-primate.git The following commit(s) were added to refs/heads/master by this push: new 3f7b10b README: update links

[GitHub] [cloudstack] nvazquez closed pull request #3964: Simple DRS framework - Host provider with balanced and condensed algorithms

2020-06-15 Thread GitBox
nvazquez closed pull request #3964: URL: https://github.com/apache/cloudstack/pull/3964 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [cloudstack] RodrigoDLopez commented on pull request #4140: Adding showunique parameter to list templates and isos

2020-06-15 Thread GitBox
RodrigoDLopez commented on pull request #4140: URL: https://github.com/apache/cloudstack/pull/4140#issuecomment-644119338 sure This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [cloudstack] ravening opened a new issue #4146: Kubernetes Service: Unable to add new Kubernetes cluster

2020-06-15 Thread GitBox
ravening opened a new issue #4146: URL: https://github.com/apache/cloudstack/issues/4146 # ISSUE TYPE * Bug Report # COMPONENT NAME ~~~ kubernetes service ~~~ # CLOUDSTACK VERSION ~~~ 4.14.0.0 ~~~ #

[GitHub] [cloudstack] RodrigoDLopez edited a comment on pull request #4140: Adding showunique parameter to list templates and isos

2020-06-15 Thread GitBox
RodrigoDLopez edited a comment on pull request #4140: URL: https://github.com/apache/cloudstack/pull/4140#issuecomment-644119338 Did again those manual test, everything as expected * Test 01 ``` cloudmonkey -p acs listtemplates \ templatefilter=self \ showunique=true \

[GitHub] [cloudstack] blueorangutan commented on pull request #4140: Adding showunique parameter to list templates and isos

2020-06-15 Thread GitBox
blueorangutan commented on pull request #4140: URL: https://github.com/apache/cloudstack/pull/4140#issuecomment-644238386 Trillian test result (tid-1725) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 59803 seconds Marvin logs:

[GitHub] [cloudstack] davidjumani commented on pull request #4140: Adding showunique parameter to list templates and isos

2020-06-15 Thread GitBox
davidjumani commented on pull request #4140: URL: https://github.com/apache/cloudstack/pull/4140#issuecomment-644211522 @RodrigoDLopez Thanks! @rhtyd Changes made! This is an automated message from the Apache Git Service.