[GitHub] [cloudstack] blueorangutan commented on pull request #4186: Adding pagination for quotaSummary and quotaTariffList

2020-06-30 Thread GitBox
blueorangutan commented on pull request #4186: URL: https://github.com/apache/cloudstack/pull/4186#issuecomment-651591004 Packaging result: ✔centos7 ✔debian. JID-1488 This is an automated message from the Apache Git Service.

[GitHub] [cloudstack] blueorangutan commented on pull request #4186: Adding pagination for quotaSummary and quotaTariffList

2020-06-30 Thread GitBox
blueorangutan commented on pull request #4186: URL: https://github.com/apache/cloudstack/pull/4186#issuecomment-651577823 @davidjumani a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] [cloudstack] davidjumani commented on a change in pull request #4186: Adding pagination for quotaSummary and quotaTariffList

2020-06-30 Thread GitBox
davidjumani commented on a change in pull request #4186: URL: https://github.com/apache/cloudstack/pull/4186#discussion_r44740 ## File path: engine/schema/src/main/java/com/cloud/user/dao/AccountDaoImpl.java ## @@ -157,9 +157,16 @@ public AccountDaoImpl() {

[GitHub] [cloudstack] davidjumani commented on pull request #4186: Adding pagination for quotaSummary and quotaTariffList

2020-06-30 Thread GitBox
davidjumani commented on pull request #4186: URL: https://github.com/apache/cloudstack/pull/4186#issuecomment-651577058 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the

[GitHub] [cloudstack] borisstoyanov commented on pull request #4071: Dynamic roles improvements

2020-06-30 Thread GitBox
borisstoyanov commented on pull request #4071: URL: https://github.com/apache/cloudstack/pull/4071#issuecomment-651731703 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the

[GitHub] [cloudstack] blueorangutan commented on pull request #4117: [VMware] Explicitly controlling VM hardware version

2020-06-30 Thread GitBox
blueorangutan commented on pull request #4117: URL: https://github.com/apache/cloudstack/pull/4117#issuecomment-651746129 Packaging result: ✔centos7 ✔debian. JID-1490 This is an automated message from the Apache Git Service.

[GitHub] [cloudstack] blueorangutan commented on pull request #4053: Secondary Storage Usage Improvements

2020-06-30 Thread GitBox
blueorangutan commented on pull request #4053: URL: https://github.com/apache/cloudstack/pull/4053#issuecomment-651703800 @Pearl1594 a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[GitHub] [cloudstack] Pearl1594 commented on pull request #4053: Secondary Storage Usage Improvements

2020-06-30 Thread GitBox
Pearl1594 commented on pull request #4053: URL: https://github.com/apache/cloudstack/pull/4053#issuecomment-651703526 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [cloudstack] blueorangutan commented on pull request #4186: Adding pagination for quotaSummary and quotaTariffList

2020-06-30 Thread GitBox
blueorangutan commented on pull request #4186: URL: https://github.com/apache/cloudstack/pull/4186#issuecomment-651724288 @davidjumani a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[GitHub] [cloudstack] davidjumani commented on pull request #4186: Adding pagination for quotaSummary and quotaTariffList

2020-06-30 Thread GitBox
davidjumani commented on pull request #4186: URL: https://github.com/apache/cloudstack/pull/4186#issuecomment-651723621 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [cloudstack] blueorangutan commented on pull request #4117: [VMware] Explicitly controlling VM hardware version

2020-06-30 Thread GitBox
blueorangutan commented on pull request #4117: URL: https://github.com/apache/cloudstack/pull/4117#issuecomment-651731131 @nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] [cloudstack] nvazquez commented on pull request #4117: [VMware] Explicitly controlling VM hardware version

2020-06-30 Thread GitBox
nvazquez commented on pull request #4117: URL: https://github.com/apache/cloudstack/pull/4117#issuecomment-651730611 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [cloudstack] blueorangutan commented on pull request #4117: [VMware] Explicitly controlling VM hardware version

2020-06-30 Thread GitBox
blueorangutan commented on pull request #4117: URL: https://github.com/apache/cloudstack/pull/4117#issuecomment-651748413 @nvazquez a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests

[GitHub] [cloudstack] nvazquez commented on pull request #4117: [VMware] Explicitly controlling VM hardware version

2020-06-30 Thread GitBox
nvazquez commented on pull request #4117: URL: https://github.com/apache/cloudstack/pull/4117#issuecomment-651747839 @blueorangutan test centos7 vmware-67u3 This is an automated message from the Apache Git Service. To

[GitHub] [cloudstack] rhtyd commented on pull request #4116: cks: fix template, deployment issues

2020-06-30 Thread GitBox
rhtyd commented on pull request #4116: URL: https://github.com/apache/cloudstack/pull/4116#issuecomment-651690486 Can you help review and test @davidjumani This is an automated message from the Apache Git Service. To

[GitHub] [cloudstack] nvazquez commented on a change in pull request #4138: Fixed incorrect error message on invalid template type download

2020-06-30 Thread GitBox
nvazquez commented on a change in pull request #4138: URL: https://github.com/apache/cloudstack/pull/4138#discussion_r447636519 ## File path: core/src/main/java/com/cloud/storage/template/HttpTemplateDownloader.java ## @@ -218,7 +219,10 @@ public long download(boolean resume,

[GitHub] [cloudstack] blueorangutan commented on pull request #4071: Dynamic roles improvements

2020-06-30 Thread GitBox
blueorangutan commented on pull request #4071: URL: https://github.com/apache/cloudstack/pull/4071#issuecomment-651731964 @borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] [cloudstack] blueorangutan commented on pull request #4071: Dynamic roles improvements

2020-06-30 Thread GitBox
blueorangutan commented on pull request #4071: URL: https://github.com/apache/cloudstack/pull/4071#issuecomment-651746500 Packaging result: ✔centos7 ✔debian. JID-1491 This is an automated message from the Apache Git Service.

[GitHub] [cloudstack] blueorangutan commented on pull request #4156: Fixed removal of hosts from certsmap when running certificate auto-renew

2020-06-30 Thread GitBox
blueorangutan commented on pull request #4156: URL: https://github.com/apache/cloudstack/pull/4156#issuecomment-651749218 @nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] [cloudstack] nvazquez commented on pull request #4156: Fixed removal of hosts from certsmap when running certificate auto-renew

2020-06-30 Thread GitBox
nvazquez commented on pull request #4156: URL: https://github.com/apache/cloudstack/pull/4156#issuecomment-651748735 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [cloudstack] Spaceman1984 opened a new issue #4189: NioTest fails on fresh install of Fedora due to RSA key size < 2048

2020-06-30 Thread GitBox
Spaceman1984 opened a new issue #4189: URL: https://github.com/apache/cloudstack/issues/4189 On a fresh installation of Fedora 31, running the NioTest will fail. This is due to Fedora using 2048 as the minimum allowed size for a RSA key and cloudstack generates a 1024 size key.

[GitHub] [cloudstack] davidjumani commented on issue #4181: Quota API don't honour pagination and searching

2020-06-30 Thread GitBox
davidjumani commented on issue #4181: URL: https://github.com/apache/cloudstack/issues/4181#issuecomment-651622677 Would this also need to add search functionality in quotaTariffList? Since it only has a fixed list of 25 tariff types

[GitHub] [cloudstack] rhtyd commented on pull request #4016: Fixed private gateway can't be deleted

2020-06-30 Thread GitBox
rhtyd commented on pull request #4016: URL: https://github.com/apache/cloudstack/pull/4016#issuecomment-651681098 @Spaceman1984 private gateway would mean a nic, IP and route on the VR, not iptables rules This is an

[GitHub] [cloudstack] blueorangutan commented on pull request #4053: Secondary Storage Usage Improvements

2020-06-30 Thread GitBox
blueorangutan commented on pull request #4053: URL: https://github.com/apache/cloudstack/pull/4053#issuecomment-651689853 @Pearl1594 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] [cloudstack] Pearl1594 commented on pull request #4053: Secondary Storage Usage Improvements

2020-06-30 Thread GitBox
Pearl1594 commented on pull request #4053: URL: https://github.com/apache/cloudstack/pull/4053#issuecomment-651689167 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the

[GitHub] [cloudstack] blueorangutan commented on pull request #4053: Secondary Storage Usage Improvements

2020-06-30 Thread GitBox
blueorangutan commented on pull request #4053: URL: https://github.com/apache/cloudstack/pull/4053#issuecomment-651702384 Packaging result: ✔centos7 ✔debian. JID-1489 This is an automated message from the Apache Git Service.

[cloudstack-documentation] branch XenUpgrade-updated-docs updated (5eb619c -> 9891b8d)

2020-06-30 Thread andrijapanic
This is an automated email from the ASF dual-hosted git repository. andrijapanic pushed a change to branch XenUpgrade-updated-docs in repository https://gitbox.apache.org/repos/asf/cloudstack-documentation.git. from 5eb619c Update xenserver.rst add 9891b8d Update xenserver.rst No

[GitHub] [cloudstack] Spaceman1984 commented on pull request #4016: Fixed private gateway can't be deleted

2020-06-30 Thread GitBox
Spaceman1984 commented on pull request #4016: URL: https://github.com/apache/cloudstack/pull/4016#issuecomment-651617355 > @Spaceman1984 this looks like deletes pg in CloudStack DB, have you verified if this would also cleanup rules on the VR properly? @rhtyd I have checked

[cloudstack-documentation] branch XenUpgrade-updated-docs updated (9891b8d -> e2d1af9)

2020-06-30 Thread andrijapanic
This is an automated email from the ASF dual-hosted git repository. andrijapanic pushed a change to branch XenUpgrade-updated-docs in repository https://gitbox.apache.org/repos/asf/cloudstack-documentation.git. from 9891b8d Update xenserver.rst add e2d1af9 Update xenserver.rst No

[GitHub] [cloudstack] shwstppr commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

2020-06-30 Thread GitBox
shwstppr commented on pull request #4068: URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-651852791 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [cloudstack] blueorangutan commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

2020-06-30 Thread GitBox
blueorangutan commented on pull request #4068: URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-651853600 @shwstppr a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[GitHub] [cloudstack] nvazquez commented on pull request #4188: WIP: Fix snapshots garbage collection

2020-06-30 Thread GitBox
nvazquez commented on pull request #4188: URL: https://github.com/apache/cloudstack/pull/4188#issuecomment-651792167 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [cloudstack] blueorangutan commented on pull request #4188: WIP: Fix snapshots garbage collection

2020-06-30 Thread GitBox
blueorangutan commented on pull request #4188: URL: https://github.com/apache/cloudstack/pull/4188#issuecomment-651792837 @nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] [cloudstack] blueorangutan commented on pull request #4188: WIP: Fix snapshots garbage collection

2020-06-30 Thread GitBox
blueorangutan commented on pull request #4188: URL: https://github.com/apache/cloudstack/pull/4188#issuecomment-651808529 Packaging result: ✔centos7 ✔debian. JID-1493 This is an automated message from the Apache Git Service.

[GitHub] [cloudstack] blueorangutan commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

2020-06-30 Thread GitBox
blueorangutan commented on pull request #4068: URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-651824598 Packaging result: ✔centos7 ✔debian. JID-1494 This is an automated message from the Apache Git Service.

[GitHub] [cloudstack] Spaceman1984 commented on a change in pull request #4138: Fixed incorrect error message on invalid template type download

2020-06-30 Thread GitBox
Spaceman1984 commented on a change in pull request #4138: URL: https://github.com/apache/cloudstack/pull/4138#discussion_r447742017 ## File path: core/src/main/java/com/cloud/storage/template/HttpTemplateDownloader.java ## @@ -218,7 +219,10 @@ public long download(boolean

[GitHub] [cloudstack] blueorangutan commented on pull request #3976: Enable sending hypervior host name via metadata - VR and Config Drive

2020-06-30 Thread GitBox
blueorangutan commented on pull request #3976: URL: https://github.com/apache/cloudstack/pull/3976#issuecomment-651858777 Trillian test result (tid-1902) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 43242 seconds Marvin logs:

[GitHub] [cloudstack] blueorangutan commented on pull request #4156: Fixed removal of hosts from certsmap when running certificate auto-renew

2020-06-30 Thread GitBox
blueorangutan commented on pull request #4156: URL: https://github.com/apache/cloudstack/pull/4156#issuecomment-651760910 Packaging result: ✔centos7 ✔debian. JID-1492 This is an automated message from the Apache Git Service.

[GitHub] [cloudstack] nvazquez commented on pull request #4156: Fixed removal of hosts from certsmap when running certificate auto-renew

2020-06-30 Thread GitBox
nvazquez commented on pull request #4156: URL: https://github.com/apache/cloudstack/pull/4156#issuecomment-651766821 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [cloudstack] blueorangutan commented on pull request #4156: Fixed removal of hosts from certsmap when running certificate auto-renew

2020-06-30 Thread GitBox
blueorangutan commented on pull request #4156: URL: https://github.com/apache/cloudstack/pull/4156#issuecomment-651767145 @nvazquez a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[cloudstack-documentation] branch XenUpgrade-updated-docs updated (d83dad4 -> 87694db)

2020-06-30 Thread andrijapanic
This is an automated email from the ASF dual-hosted git repository. andrijapanic pushed a change to branch XenUpgrade-updated-docs in repository https://gitbox.apache.org/repos/asf/cloudstack-documentation.git. from d83dad4 Update xenserver.rst (#141) add 87694db Update xenserver.rst

[cloudstack-documentation] branch andrijapanicsb-patch-2 updated (9964ba3 -> bdd2f03)

2020-06-30 Thread andrijapanic
This is an automated email from the ASF dual-hosted git repository. andrijapanic pushed a change to branch andrijapanicsb-patch-2 in repository https://gitbox.apache.org/repos/asf/cloudstack-documentation.git. from 9964ba3 Update xenserver.rst add bdd2f03 Update xenserver.rst No new

[GitHub] [cloudstack] GabrielBrascher opened a new pull request #4190: Broadcast URI not set to vxlan, but vlan (Fix #3040)

2020-06-30 Thread GitBox
GabrielBrascher opened a new pull request #4190: URL: https://github.com/apache/cloudstack/pull/4190 ## Description This PR sets properly Broadcast URI to `vxlan://vxlan_id` when the physical network is of VXLAN. Fixes: #3040 Description of issue #3040: >

[GitHub] [cloudstack] GabrielBrascher closed pull request #4190: Broadcast URI not set to vxlan, but vlan (Fix #3040)

2020-06-30 Thread GitBox
GabrielBrascher closed pull request #4190: URL: https://github.com/apache/cloudstack/pull/4190 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[cloudstack-documentation] branch XenUpgrade-updated-docs updated (e2d1af9 -> d83dad4)

2020-06-30 Thread andrijapanic
This is an automated email from the ASF dual-hosted git repository. andrijapanic pushed a change to branch XenUpgrade-updated-docs in repository https://gitbox.apache.org/repos/asf/cloudstack-documentation.git. from e2d1af9 Update xenserver.rst add d83dad4 Update xenserver.rst (#141)

[cloudstack-documentation] branch XenUpgrade-updated-docs updated (5f001cf -> a96e9b3)

2020-06-30 Thread andrijapanic
This is an automated email from the ASF dual-hosted git repository. andrijapanic pushed a change to branch XenUpgrade-updated-docs in repository https://gitbox.apache.org/repos/asf/cloudstack-documentation.git. from 5f001cf Update xenserver.rst add a96e9b3 Update xenserver.rst No

[cloudstack-documentation] branch XenUpgrade-updated-docs updated (fbc6f74 -> ed194c7)

2020-06-30 Thread andrijapanic
This is an automated email from the ASF dual-hosted git repository. andrijapanic pushed a change to branch XenUpgrade-updated-docs in repository https://gitbox.apache.org/repos/asf/cloudstack-documentation.git. from fbc6f74 Update xenserver.rst add ed194c7 Update xenserver.rst No

[cloudstack-documentation] branch andrijapanicsb-patch-2 updated (bdd2f03 -> 7ed38de)

2020-06-30 Thread andrijapanic
This is an automated email from the ASF dual-hosted git repository. andrijapanic pushed a change to branch andrijapanicsb-patch-2 in repository https://gitbox.apache.org/repos/asf/cloudstack-documentation.git. from bdd2f03 Update xenserver.rst add 7ed38de Update xenserver.rst No new

[cloudstack-documentation] branch andrijapanicsb-patch-2 updated (7ed38de -> 3de2a0f)

2020-06-30 Thread andrijapanic
This is an automated email from the ASF dual-hosted git repository. andrijapanic pushed a change to branch andrijapanicsb-patch-2 in repository https://gitbox.apache.org/repos/asf/cloudstack-documentation.git. from 7ed38de Update xenserver.rst add 3de2a0f Update xenserver.rst No new

[cloudstack-documentation] branch XenUpgrade-updated-docs updated (a96e9b3 -> fbc6f74)

2020-06-30 Thread andrijapanic
This is an automated email from the ASF dual-hosted git repository. andrijapanic pushed a change to branch XenUpgrade-updated-docs in repository https://gitbox.apache.org/repos/asf/cloudstack-documentation.git. from a96e9b3 Update xenserver.rst add fbc6f74 Update xenserver.rst No

[cloudstack-documentation] branch andrijapanicsb-patch-2 created (now 9964ba3)

2020-06-30 Thread andrijapanic
This is an automated email from the ASF dual-hosted git repository. andrijapanic pushed a change to branch andrijapanicsb-patch-2 in repository https://gitbox.apache.org/repos/asf/cloudstack-documentation.git. at 9964ba3 Update xenserver.rst No new revisions were added by this update.

[cloudstack-documentation] branch XenUpgrade-updated-docs updated (87694db -> 5f001cf)

2020-06-30 Thread andrijapanic
This is an automated email from the ASF dual-hosted git repository. andrijapanic pushed a change to branch XenUpgrade-updated-docs in repository https://gitbox.apache.org/repos/asf/cloudstack-documentation.git. from 87694db Update xenserver.rst add 5f001cf Update xenserver.rst No

[GitHub] [cloudstack] blueorangutan commented on pull request #4053: Secondary Storage Usage Improvements

2020-06-30 Thread GitBox
blueorangutan commented on pull request #4053: URL: https://github.com/apache/cloudstack/pull/4053#issuecomment-652016745 Trillian test result (tid-1908) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 33671 seconds Marvin logs:

[GitHub] [cloudstack] blueorangutan commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

2020-06-30 Thread GitBox
blueorangutan commented on pull request #4068: URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-652124111 Trillian test result (tid-1915) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 3 seconds Marvin logs:

[GitHub] [cloudstack] blueorangutan commented on pull request #4071: Dynamic roles improvements

2020-06-30 Thread GitBox
blueorangutan commented on pull request #4071: URL: https://github.com/apache/cloudstack/pull/4071#issuecomment-652204115 @borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] [cloudstack] blueorangutan commented on pull request #4172: [VMware] Support to attach more than 15 data disks in VMware VM

2020-06-30 Thread GitBox
blueorangutan commented on pull request #4172: URL: https://github.com/apache/cloudstack/pull/4172#issuecomment-652204207 @sureshanaparti a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests

[GitHub] [cloudstack] sureshanaparti commented on pull request #4172: [VMware] Support to attach more than 15 data disks in VMware VM

2020-06-30 Thread GitBox
sureshanaparti commented on pull request #4172: URL: https://github.com/apache/cloudstack/pull/4172#issuecomment-652203768 @blueorangutan test centos7 vmware-67u3 This is an automated message from the Apache Git Service. To

[GitHub] [cloudstack] borisstoyanov commented on pull request #4071: Dynamic roles improvements

2020-06-30 Thread GitBox
borisstoyanov commented on pull request #4071: URL: https://github.com/apache/cloudstack/pull/4071#issuecomment-652203905 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the

[GitHub] [cloudstack] rhtyd commented on pull request #4117: [VMware] Explicitly controlling VM hardware version

2020-06-30 Thread GitBox
rhtyd commented on pull request #4117: URL: https://github.com/apache/cloudstack/pull/4117#issuecomment-652159733 @nvazquez can you check in backend jenkins why tests are taking time, is there something in the defaults changed causing issues on vcenter side? Thanks.

[cloudstack-cloudmonkey] annotated tag 6.1.0 updated (abc3192 -> f6a6b9e)

2020-06-30 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a change to annotated tag 6.1.0 in repository https://gitbox.apache.org/repos/asf/cloudstack-cloudmonkey.git. *** WARNING: tag 6.1.0 was modified! *** from abc3192 (commit) to f6a6b9e (tag) tagging

[GitHub] [cloudstack] sureshanaparti commented on pull request #4172: [VMware] Support to attach more than 15 data disks in VMware VM

2020-06-30 Thread GitBox
sureshanaparti commented on pull request #4172: URL: https://github.com/apache/cloudstack/pull/4172#issuecomment-652190027 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the

[GitHub] [cloudstack] blueorangutan commented on pull request #4172: [VMware] Support to attach more than 15 data disks in VMware VM

2020-06-30 Thread GitBox
blueorangutan commented on pull request #4172: URL: https://github.com/apache/cloudstack/pull/4172#issuecomment-652190177 @sureshanaparti a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] [cloudstack] blueorangutan commented on pull request #4172: [VMware] Support to attach more than 15 data disks in VMware VM

2020-06-30 Thread GitBox
blueorangutan commented on pull request #4172: URL: https://github.com/apache/cloudstack/pull/4172#issuecomment-652197621 Packaging result: ✔centos7 ✔debian. JID-1495 This is an automated message from the Apache Git Service.

[GitHub] [cloudstack] rhtyd commented on pull request #3976: Enable sending hypervior host name via metadata - VR and Config Drive

2020-06-30 Thread GitBox
rhtyd commented on pull request #3976: URL: https://github.com/apache/cloudstack/pull/3976#issuecomment-652161738 test LGTM, failures unrelated to this PR This is an automated message from the Apache Git Service. To respond

[GitHub] [cloudstack] rhtyd commented on pull request #4040: [KVM] Enable PVLAN support on L2 networks

2020-06-30 Thread GitBox
rhtyd commented on pull request #4040: URL: https://github.com/apache/cloudstack/pull/4040#issuecomment-652161406 @davidjumani is this ready for review/merging? This is an automated message from the Apache Git Service. To

[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #4172: [VMware] Support to attach more than 15 data disks in VMware VM

2020-06-30 Thread GitBox
sureshanaparti commented on a change in pull request #4172: URL: https://github.com/apache/cloudstack/pull/4172#discussion_r448106079 ## File path: plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/resource/VmwareResource.java ## @@ -2068,13 +2068,16 @@

[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #4172: [VMware] Support to attach more than 15 data disks in VMware VM

2020-06-30 Thread GitBox
sureshanaparti commented on a change in pull request #4172: URL: https://github.com/apache/cloudstack/pull/4172#discussion_r448106110 ## File path: plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/resource/VmwareResource.java ## @@ -2098,10 +2101,17 @@

[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #4172: [VMware] Support to attach more than 15 data disks in VMware VM

2020-06-30 Thread GitBox
sureshanaparti commented on a change in pull request #4172: URL: https://github.com/apache/cloudstack/pull/4172#discussion_r448110054 ## File path: vmware-base/src/main/java/com/cloud/hypervisor/vmware/mo/VirtualMachineMO.java ## @@ -2412,6 +2419,23 @@ public void

[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #4172: [VMware] Support to attach more than 15 data disks in VMware VM

2020-06-30 Thread GitBox
sureshanaparti commented on a change in pull request #4172: URL: https://github.com/apache/cloudstack/pull/4172#discussion_r448109972 ## File path: vmware-base/src/main/java/com/cloud/hypervisor/vmware/mo/VirtualMachineMO.java ## @@ -2412,6 +2419,23 @@ public void

[GitHub] [cloudstack] Pearl1594 commented on a change in pull request #4071: Dynamic roles improvements

2020-06-30 Thread GitBox
Pearl1594 commented on a change in pull request #4071: URL: https://github.com/apache/cloudstack/pull/4071#discussion_r448112372 ## File path: api/src/main/java/org/apache/cloudstack/api/command/admin/acl/UpdateRoleCmd.java ## @@ -67,13 +63,6 @@ public String getRoleName() {

[GitHub] [cloudstack] blueorangutan commented on pull request #4176: server: Purge all cookies on logout, set /client path on login

2020-06-30 Thread GitBox
blueorangutan commented on pull request #4176: URL: https://github.com/apache/cloudstack/pull/4176#issuecomment-652157386 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[GitHub] [cloudstack] rhtyd commented on pull request #4176: server: Purge all cookies on logout, set /client path on login

2020-06-30 Thread GitBox
rhtyd commented on pull request #4176: URL: https://github.com/apache/cloudstack/pull/4176#issuecomment-652157032 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [cloudstack] rhtyd commented on pull request #4182: kvm: pre-add 32 PCI controller for hot-plug issue

2020-06-30 Thread GitBox
rhtyd commented on pull request #4182: URL: https://github.com/apache/cloudstack/pull/4182#issuecomment-652157183 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [cloudstack] blueorangutan commented on pull request #4182: kvm: pre-add 32 PCI controller for hot-plug issue

2020-06-30 Thread GitBox
blueorangutan commented on pull request #4182: URL: https://github.com/apache/cloudstack/pull/4182#issuecomment-652157323 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[GitHub] [cloudstack] rhtyd commented on pull request #4156: Fixed removal of hosts from certsmap when running certificate auto-renew

2020-06-30 Thread GitBox
rhtyd commented on pull request #4156: URL: https://github.com/apache/cloudstack/pull/4156#issuecomment-652159406 @nvazquez yes it's because the code which adds the X509 cert to the hashmap (currently) uses the incoming client's IP address as the key. It may need checking or use host

[GitHub] [cloudstack] rhtyd commented on a change in pull request #4186: Adding pagination for quotaSummary and quotaTariffList

2020-06-30 Thread GitBox
rhtyd commented on a change in pull request #4186: URL: https://github.com/apache/cloudstack/pull/4186#discussion_r448090314 ## File path: engine/schema/src/main/java/com/cloud/user/dao/AccountDaoImpl.java ## @@ -157,9 +157,16 @@ public AccountDaoImpl() { @Override

[cloudstack] branch master updated: server: Enable sending hypervior host name via metadata - VR and Config Drive (#3976)

2020-06-30 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/master by this push: new a73712e server: Enable sending hypervior

[GitHub] [cloudstack] rhtyd merged pull request #3976: Enable sending hypervior host name via metadata - VR and Config Drive

2020-06-30 Thread GitBox
rhtyd merged pull request #3976: URL: https://github.com/apache/cloudstack/pull/3976 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

svn commit: r40262 - /dev/cloudstack/cloudmonkey-6.1.0/

2020-06-30 Thread rohit
Author: rohit Date: Wed Jul 1 04:20:27 2020 New Revision: 40262 Log: Committing release candidate artifacts for 6.1.0 to dist/dev/cloudstack in preparation for release vote Added: dev/cloudstack/cloudmonkey-6.1.0/