[GitHub] [cloudstack] rhtyd commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support
rhtyd commented on pull request #4068: URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-655304613 @shwstppr please fix conflicts as well This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4116: cks: fix template, deployment issues
blueorangutan commented on pull request #4116: URL: https://github.com/apache/cloudstack/pull/4116#issuecomment-655304432 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4116: cks: fix template, deployment issues
rhtyd commented on pull request #4116: URL: https://github.com/apache/cloudstack/pull/4116#issuecomment-655304019 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4156: Fixed removal of hosts from certsmap when running certificate auto-renew
blueorangutan commented on pull request #4156: URL: https://github.com/apache/cloudstack/pull/4156#issuecomment-655303763 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4156: Fixed removal of hosts from certsmap when running certificate auto-renew
rhtyd commented on pull request #4156: URL: https://github.com/apache/cloudstack/pull/4156#issuecomment-655303521 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on a change in pull request #4138: Fixed incorrect error message on invalid template type download
rhtyd commented on a change in pull request #4138:
URL: https://github.com/apache/cloudstack/pull/4138#discussion_r451300255
##
File path:
core/src/main/java/com/cloud/storage/template/HttpTemplateDownloader.java
##
@@ -243,7 +247,6 @@ private boolean copyBytes(File file, InputStream in,
RandomAccessFile out) throw
offset = writeBlock(bytes, out, block, offset);
if (!verifyFormat.isVerifiedFormat() && (offset >= 1048576 ||
offset >= remoteSize)) { //let's check format after we get 1MB or full file
verifyFormat.invoke();
-if (verifyFormat.isInvalid()) return true;
Review comment:
@Spaceman1984 cc @nvazquez why are we not validating format now?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4172: [VMware] Support to attach more than 15 data disks in VMware VM
blueorangutan commented on pull request #4172: URL: https://github.com/apache/cloudstack/pull/4172#issuecomment-655303123 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4172: [VMware] Support to attach more than 15 data disks in VMware VM
rhtyd commented on pull request #4172: URL: https://github.com/apache/cloudstack/pull/4172#issuecomment-655302736 @sureshanaparti this test is consistently failing, please check: ``` test_07_reboot_ssvm | Failure | 42.31 | test_ssvm.py ``` @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4128: Role based users in Projects
blueorangutan commented on pull request #4128: URL: https://github.com/apache/cloudstack/pull/4128#issuecomment-655268145 @Pearl1594 a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #4128: Role based users in Projects
Pearl1594 commented on pull request #4128: URL: https://github.com/apache/cloudstack/pull/4128#issuecomment-655267860 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4128: Role based users in Projects
blueorangutan commented on pull request #4128: URL: https://github.com/apache/cloudstack/pull/4128#issuecomment-655263705 Packaging result: ✔centos7 ✔debian. JID-1552 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on a change in pull request #4128: Role based users in Projects
Pearl1594 commented on a change in pull request #4128:
URL: https://github.com/apache/cloudstack/pull/4128#discussion_r451258447
##
File path:
server/src/main/java/org/apache/cloudstack/acl/ProjectRoleManagerImpl.java
##
@@ -0,0 +1,308 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.cloudstack.acl;
+
+import java.util.ArrayList;
+import java.util.Collections;
+import java.util.List;
+
+import javax.inject.Inject;
+
+import org.apache.cloudstack.acl.dao.ProjectRoleDao;
+import org.apache.cloudstack.acl.dao.ProjectRolePermissionsDao;
+import org.apache.cloudstack.acl.RolePermissionEntity.Permission;
+import
org.apache.cloudstack.api.command.admin.acl.project.CreateProjectRoleCmd;
+import
org.apache.cloudstack.api.command.admin.acl.project.CreateProjectRolePermissionCmd;
+import
org.apache.cloudstack.api.command.admin.acl.project.DeleteProjectRoleCmd;
+import
org.apache.cloudstack.api.command.admin.acl.project.DeleteProjectRolePermissionCmd;
+import
org.apache.cloudstack.api.command.admin.acl.project.ListProjectRolePermissionsCmd;
+import org.apache.cloudstack.api.command.admin.acl.project.ListProjectRolesCmd;
+import
org.apache.cloudstack.api.command.admin.acl.project.UpdateProjectRoleCmd;
+import
org.apache.cloudstack.api.command.admin.acl.project.UpdateProjectRolePermissionCmd;
+import org.apache.cloudstack.context.CallContext;
+import org.apache.commons.lang3.StringUtils;
+import org.apache.log4j.Logger;
+
+import com.cloud.event.ActionEvent;
+import com.cloud.event.EventTypes;
+import com.cloud.exception.PermissionDeniedException;
+import com.cloud.projects.Project;
+import com.cloud.projects.ProjectAccount;
+import com.cloud.projects.dao.ProjectAccountDao;
+import com.cloud.projects.dao.ProjectDao;
+import com.cloud.user.Account;
+import com.cloud.user.User;
+import com.cloud.user.dao.AccountDao;
+import com.cloud.utils.ListUtils;
+import com.cloud.utils.component.ManagerBase;
+import com.cloud.utils.component.PluggableService;
+import com.cloud.utils.db.Transaction;
+import com.cloud.utils.db.TransactionCallback;
+import com.cloud.utils.db.TransactionStatus;
+import com.cloud.utils.exception.CloudRuntimeException;
+import com.google.common.base.Strings;
+
+public class ProjectRoleManagerImpl extends ManagerBase implements
ProjectRoleService, PluggableService {
+@Inject
+ProjectAccountDao projAccDao;
+@Inject
+ProjectRoleDao projRoleDao;
+@Inject
+ProjectDao projectDao;
+@Inject
+AccountDao accountDao;
+@Inject
+ProjectRolePermissionsDao projRolePermissionsDao;
+
+private static final Logger LOGGER =
Logger.getLogger(ProjectRoleManagerImpl.class);
+
+private Project validateProjectId(Long projectId) {
+Project project = projectDao.findById(projectId);
+if (project == null) {
+throw new CloudRuntimeException("Invalid project id provided");
+}
+return project;
+}
+
+private void checkAccess(Long projectId) {
+Project project = validateProjectId(projectId);
+CallContext.current().setProject(project);
+
+if (!isEnabled()) {
+throw new PermissionDeniedException("Dynamic api checker is not
enabled, aborting role operation");
+}
+
+User user = getCurrentUser();
+Account callerAcc = accountDao.findById(user.getAccountId());
+
+if (callerAcc == null || callerAcc.getRoleId() == null) {
+throw new PermissionDeniedException("Restricted API called by an
invalid user account");
+}
+
+ProjectAccount projectAccount =
projAccDao.findByProjectIdUserId(projectId, callerAcc.getAccountId(),
user.getId());
+if (projectAccount == null) {
+projectAccount = projAccDao.findByProjectIdAccountId(projectId,
callerAcc.getAccountId());
+if (projectAccount == null) {
+throw new PermissionDeniedException("User/Account not part of
project");
+}
+}
+if (ProjectAccount.Role.Admin != projectAccount.getAccountRole()) {
+throw new PermissionDeniedException("User unauthorized to perform
operation in the project");
+}
+}
+
+
[GitHub] [cloudstack] Pearl1594 commented on pull request #4128: Role based users in Projects
Pearl1594 commented on pull request #4128: URL: https://github.com/apache/cloudstack/pull/4128#issuecomment-655257727 Thanks @nvazquez , I've addressed the comments This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on a change in pull request #4128: Role based users in Projects
Pearl1594 commented on a change in pull request #4128:
URL: https://github.com/apache/cloudstack/pull/4128#discussion_r451258110
##
File path:
api/src/main/java/org/apache/cloudstack/api/command/user/project/UpdateProjectCmd.java
##
@@ -68,11 +89,49 @@ public String getDisplayText() {
return displayText;
}
+public Long getUserId() {
+return userId;
+}
+
+public Long getDomainId() {
+if (domainId != null) {
+return domainId;
+}
+return CallContext.current().getCallingAccount().getDomainId();
+}
+
+public ProjectAccount.Role getRoleType(String role) {
+String type = role.substring(0, 1).toUpperCase() +
role.substring(1).toLowerCase();
+if (!EnumUtils.isValidEnum(ProjectAccount.Role.class, type)) {
+throw new InvalidParameterValueException("Only Admin or Regular
project role types are valid");
+}
+return Enum.valueOf(ProjectAccount.Role.class, type);
+}
+
+public ProjectAccount.Role getAccountRole() {
+if (roleType != null) {
+return getRoleType(roleType);
+}
+return ProjectAccount.Role.Regular;
+}
+
+public Long getAccountId() {
+return accountId;
+}
+
@Override
public String getCommandName() {
return s_name;
}
+public Boolean isSwapOwner() {
+if (swapOwner != null) {
Review comment:
done
##
File path:
api/src/main/java/org/apache/cloudstack/api/command/user/account/AddAccountToProjectCmd.java
##
@@ -72,6 +87,21 @@ public String getEmail() {
return email;
}
+public Long getProjectRoleId() {
+return projectRoleId;
+}
+
+public ProjectAccount.Role getRoleType() {
+if (roleType != null) {
Review comment:
done
##
File path:
api/src/main/java/org/apache/cloudstack/api/command/user/account/AddUserToProjectCmd.java
##
@@ -0,0 +1,154 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.cloudstack.api.command.user.account;
+
+import org.apache.cloudstack.acl.RoleType;
+import org.apache.cloudstack.api.APICommand;
+import org.apache.cloudstack.api.ApiArgValidator;
+import org.apache.cloudstack.api.ApiConstants;
+import org.apache.cloudstack.api.ApiErrorCode;
+import org.apache.cloudstack.api.BaseAsyncCmd;
+import org.apache.cloudstack.api.BaseCmd;
+import org.apache.cloudstack.api.Parameter;
+import org.apache.cloudstack.api.ServerApiException;
+import org.apache.cloudstack.api.response.ProjectResponse;
+import org.apache.cloudstack.api.response.ProjectRoleResponse;
+import org.apache.cloudstack.api.response.SuccessResponse;
+import org.apache.cloudstack.api.response.UserResponse;
+import org.apache.cloudstack.context.CallContext;
+import org.apache.commons.lang3.EnumUtils;
+
+import com.cloud.event.EventTypes;
+import com.cloud.exception.InvalidParameterValueException;
+import com.cloud.projects.ProjectAccount;
+
+@APICommand(name = AddUserToProjectCmd.APINAME, description = "Adds user to a
project", responseObject = SuccessResponse.class, since = "4.14",
+requestHasSensitiveInfo = false, responseHasSensitiveInfo = false,
authorized = {RoleType.Admin, RoleType.DomainAdmin, RoleType.ResourceAdmin,
RoleType.User})
+public class AddUserToProjectCmd extends BaseAsyncCmd {
+public static final String APINAME = "addUserToProject";
+
+/
+ API parameters /
+/
+
+@Parameter(name = ApiConstants.PROJECT_ID,
+type = BaseCmd.CommandType.UUID,
+entityType = ProjectResponse.class,
+required = true,
+description = "ID of the project to add the user to")
+private Long projectId;
+
+@Parameter(name = ApiConstants.USER_ID, type = BaseCmd.CommandType.UUID,
entityType = UserResponse.class,
+description = "User UUID, required for adding account from
external provisioning system")
+private Long userId;
+
+@Parameter(name = ApiConstants.EMAIL, type = CommandType.STRING,
description
[GitHub] [cloudstack] Pearl1594 commented on pull request #4128: Role based users in Projects
Pearl1594 commented on pull request #4128: URL: https://github.com/apache/cloudstack/pull/4128#issuecomment-655256553 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4128: Role based users in Projects
blueorangutan commented on pull request #4128: URL: https://github.com/apache/cloudstack/pull/4128#issuecomment-655256649 @Pearl1594 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support
rhtyd commented on pull request #4068: URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-655247303 CentOS8 kvm doesn't like volume to be detached This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[cloudstack] branch master updated (cb6b89c -> 64c6938)
This is an automated email from the ASF dual-hosted git repository. rohit pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git. from cb6b89c Merge remote-tracking branch 'origin/4.14' add 64c6938 db: VMware Guest OS Mappings fix (#4196) No new revisions were added by this update. Summary of changes: .../schema/src/main/resources/META-INF/db/schema-41400to41500.sql | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-)
[GitHub] [cloudstack] rhtyd merged pull request #4196: VMware: Guest OS Mappings fix
rhtyd merged pull request #4196: URL: https://github.com/apache/cloudstack/pull/4196 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[cloudstack] branch 4.13 updated: server: Purge all cookies on logout, set /client path on login (#4176)
This is an automated email from the ASF dual-hosted git repository.
rohit pushed a commit to branch 4.13
in repository https://gitbox.apache.org/repos/asf/cloudstack.git
The following commit(s) were added to refs/heads/4.13 by this push:
new 139aa13 server: Purge all cookies on logout, set /client path on
login (#4176)
139aa13 is described below
commit 139aa13e6ab6af1a871094cdae7607f00291d6e8
Author: Rohit Yadav
AuthorDate: Wed Jul 8 08:03:51 2020 +0530
server: Purge all cookies on logout, set /client path on login (#4176)
This will purge all the cookies on logout including multiple sessionkey
cookies if passed. On login, this will restrict sessionkey cookie
(httponly) to the / path.
Fixes #4136
Co-authored-by: Pearl Dsilva
---
.../src/main/java/org/apache/cloudstack/saml/SAMLUtils.java | 2 +-
server/src/main/java/com/cloud/api/ApiServlet.java | 13 +
2 files changed, 10 insertions(+), 5 deletions(-)
diff --git
a/plugins/user-authenticators/saml2/src/main/java/org/apache/cloudstack/saml/SAMLUtils.java
b/plugins/user-authenticators/saml2/src/main/java/org/apache/cloudstack/saml/SAMLUtils.java
index 6110cc5..6a03d44 100644
---
a/plugins/user-authenticators/saml2/src/main/java/org/apache/cloudstack/saml/SAMLUtils.java
+++
b/plugins/user-authenticators/saml2/src/main/java/org/apache/cloudstack/saml/SAMLUtils.java
@@ -280,7 +280,7 @@ public class SAMLUtils {
resp.addCookie(new Cookie("timezone", URLEncoder.encode(timezone,
HttpUtils.UTF_8)));
}
resp.addCookie(new Cookie("userfullname",
URLEncoder.encode(loginResponse.getFirstName() + " " +
loginResponse.getLastName(), HttpUtils.UTF_8).replace("+", "%20")));
-resp.addHeader("SET-COOKIE", String.format("%s=%s;HttpOnly",
ApiConstants.SESSIONKEY, loginResponse.getSessionKey()));
+resp.addHeader("SET-COOKIE", String.format("%s=%s;HttpOnly;Path=/",
ApiConstants.SESSIONKEY, loginResponse.getSessionKey()));
}
/**
diff --git a/server/src/main/java/com/cloud/api/ApiServlet.java
b/server/src/main/java/com/cloud/api/ApiServlet.java
index 4002ff8..c42980b 100644
--- a/server/src/main/java/com/cloud/api/ApiServlet.java
+++ b/server/src/main/java/com/cloud/api/ApiServlet.java
@@ -213,7 +213,7 @@ public class ApiServlet extends HttpServlet {
try {
responseString =
apiAuthenticator.authenticate(command, params, session, remoteAddress,
responseType, auditTrailSb, req, resp);
if (session != null &&
session.getAttribute(ApiConstants.SESSIONKEY) != null) {
-resp.addHeader("SET-COOKIE",
String.format("%s=%s;HttpOnly", ApiConstants.SESSIONKEY,
session.getAttribute(ApiConstants.SESSIONKEY)));
+resp.addHeader("SET-COOKIE",
String.format("%s=%s;HttpOnly;Path=/", ApiConstants.SESSIONKEY,
session.getAttribute(ApiConstants.SESSIONKEY)));
}
} catch (ServerApiException e) {
httpResponseCode = e.getErrorCode().getHttpCode();
@@ -238,9 +238,14 @@ public class ApiServlet extends HttpServlet {
} catch (final IllegalStateException ignored) {
}
}
-Cookie sessionKeyCookie = new
Cookie(ApiConstants.SESSIONKEY, "");
-sessionKeyCookie.setMaxAge(0);
-resp.addCookie(sessionKeyCookie);
+final Cookie[] cookies = req.getCookies();
+if (cookies != null) {
+for (final Cookie cookie : cookies) {
+cookie.setValue("");
+cookie.setMaxAge(0);
+resp.addCookie(cookie);
+}
+}
}
HttpUtils.writeHttpResponse(resp, responseString,
httpResponseCode, responseType, ApiServer.JSONcontentType.value());
return;
[cloudstack] branch 4.13 updated: server: Purge all cookies on logout, set /client path on login (#4176)
This is an automated email from the ASF dual-hosted git repository.
rohit pushed a commit to branch 4.13
in repository https://gitbox.apache.org/repos/asf/cloudstack.git
The following commit(s) were added to refs/heads/4.13 by this push:
new 139aa13 server: Purge all cookies on logout, set /client path on
login (#4176)
139aa13 is described below
commit 139aa13e6ab6af1a871094cdae7607f00291d6e8
Author: Rohit Yadav
AuthorDate: Wed Jul 8 08:03:51 2020 +0530
server: Purge all cookies on logout, set /client path on login (#4176)
This will purge all the cookies on logout including multiple sessionkey
cookies if passed. On login, this will restrict sessionkey cookie
(httponly) to the / path.
Fixes #4136
Co-authored-by: Pearl Dsilva
---
.../src/main/java/org/apache/cloudstack/saml/SAMLUtils.java | 2 +-
server/src/main/java/com/cloud/api/ApiServlet.java | 13 +
2 files changed, 10 insertions(+), 5 deletions(-)
diff --git
a/plugins/user-authenticators/saml2/src/main/java/org/apache/cloudstack/saml/SAMLUtils.java
b/plugins/user-authenticators/saml2/src/main/java/org/apache/cloudstack/saml/SAMLUtils.java
index 6110cc5..6a03d44 100644
---
a/plugins/user-authenticators/saml2/src/main/java/org/apache/cloudstack/saml/SAMLUtils.java
+++
b/plugins/user-authenticators/saml2/src/main/java/org/apache/cloudstack/saml/SAMLUtils.java
@@ -280,7 +280,7 @@ public class SAMLUtils {
resp.addCookie(new Cookie("timezone", URLEncoder.encode(timezone,
HttpUtils.UTF_8)));
}
resp.addCookie(new Cookie("userfullname",
URLEncoder.encode(loginResponse.getFirstName() + " " +
loginResponse.getLastName(), HttpUtils.UTF_8).replace("+", "%20")));
-resp.addHeader("SET-COOKIE", String.format("%s=%s;HttpOnly",
ApiConstants.SESSIONKEY, loginResponse.getSessionKey()));
+resp.addHeader("SET-COOKIE", String.format("%s=%s;HttpOnly;Path=/",
ApiConstants.SESSIONKEY, loginResponse.getSessionKey()));
}
/**
diff --git a/server/src/main/java/com/cloud/api/ApiServlet.java
b/server/src/main/java/com/cloud/api/ApiServlet.java
index 4002ff8..c42980b 100644
--- a/server/src/main/java/com/cloud/api/ApiServlet.java
+++ b/server/src/main/java/com/cloud/api/ApiServlet.java
@@ -213,7 +213,7 @@ public class ApiServlet extends HttpServlet {
try {
responseString =
apiAuthenticator.authenticate(command, params, session, remoteAddress,
responseType, auditTrailSb, req, resp);
if (session != null &&
session.getAttribute(ApiConstants.SESSIONKEY) != null) {
-resp.addHeader("SET-COOKIE",
String.format("%s=%s;HttpOnly", ApiConstants.SESSIONKEY,
session.getAttribute(ApiConstants.SESSIONKEY)));
+resp.addHeader("SET-COOKIE",
String.format("%s=%s;HttpOnly;Path=/", ApiConstants.SESSIONKEY,
session.getAttribute(ApiConstants.SESSIONKEY)));
}
} catch (ServerApiException e) {
httpResponseCode = e.getErrorCode().getHttpCode();
@@ -238,9 +238,14 @@ public class ApiServlet extends HttpServlet {
} catch (final IllegalStateException ignored) {
}
}
-Cookie sessionKeyCookie = new
Cookie(ApiConstants.SESSIONKEY, "");
-sessionKeyCookie.setMaxAge(0);
-resp.addCookie(sessionKeyCookie);
+final Cookie[] cookies = req.getCookies();
+if (cookies != null) {
+for (final Cookie cookie : cookies) {
+cookie.setValue("");
+cookie.setMaxAge(0);
+resp.addCookie(cookie);
+}
+}
}
HttpUtils.writeHttpResponse(resp, responseString,
httpResponseCode, responseType, ApiServer.JSONcontentType.value());
return;
[GitHub] [cloudstack] rhtyd merged pull request #4176: server: Purge all cookies on logout, set /client path on login
rhtyd merged pull request #4176: URL: https://github.com/apache/cloudstack/pull/4176 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4176: server: Purge all cookies on logout, set /client path on login
rhtyd commented on pull request #4176: URL: https://github.com/apache/cloudstack/pull/4176#issuecomment-655244575 Tests lgtm This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan removed a comment on pull request #4176: server: Purge all cookies on logout, set /client path on login
blueorangutan removed a comment on pull request #4176: URL: https://github.com/apache/cloudstack/pull/4176#issuecomment-653829247 Trillian test result (tid-1980) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 60425 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4176-t1980-kvm-centos7.zip Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py Intermittent failure detected: /marvin/tests/smoke/test_public_ip_range.py Intermittent failure detected: /marvin/tests/smoke/test_reset_vm_on_reboot.py Intermittent failure detected: /marvin/tests/smoke/test_resource_accounting.py Intermittent failure detected: /marvin/tests/smoke/test_router_dhcphosts.py Intermittent failure detected: /marvin/tests/smoke/test_router_dns.py Intermittent failure detected: /marvin/tests/smoke/test_router_dnsservice.py Intermittent failure detected: /marvin/tests/smoke/test_routers_iptables_default_policy.py Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py Intermittent failure detected: /marvin/tests/smoke/test_routers.py Intermittent failure detected: /marvin/tests/smoke/test_secondary_storage.py Intermittent failure detected: /marvin/tests/smoke/test_service_offerings.py Intermittent failure detected: /marvin/tests/smoke/test_snapshots.py Intermittent failure detected: /marvin/tests/smoke/test_ssvm.py Intermittent failure detected: /marvin/tests/smoke/test_templates.py Intermittent failure detected: /marvin/tests/smoke/test_usage.py Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py Intermittent failure detected: /marvin/tests/smoke/test_vm_snapshots.py Intermittent failure detected: /marvin/tests/smoke/test_volumes.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_router_nics.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py Smoke tests completed. 55 look OK, 22 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_02_vpc_privategw_static_routes | `Failure` | 170.13 | test_privategw_acl.py test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 196.34 | test_privategw_acl.py test_04_rvpc_privategw_static_routes | `Failure` | 278.32 | test_privategw_acl.py ContextSuite context=TestResetVmOnReboot>:setup | `Error` | 0.00 | test_reset_vm_on_reboot.py ContextSuite context=TestRAMCPUResourceAccounting>:setup | `Error` | 0.00 | test_resource_accounting.py ContextSuite context=TestRouterDHCPHosts>:setup | `Error` | 0.00 | test_router_dhcphosts.py ContextSuite context=TestRouterDHCPOpts>:setup | `Error` | 0.00 | test_router_dhcphosts.py ContextSuite context=TestRouterDns>:setup | `Error` | 0.00 | test_router_dns.py test_01_sys_vm_start | `Failure` | 0.06 | test_secondary_storage.py ContextSuite context=TestRouterDnsService>:setup | `Error` | 0.00 | test_router_dnsservice.py ContextSuite context=TestRouterIpTablesPolicies>:setup | `Error` | 0.00 | test_routers_iptables_default_policy.py ContextSuite context=TestVPCIpTablesPolicies>:setup | `Error` | 0.00 | test_routers_iptables_default_policy.py ContextSuite context=TestIsolatedNetworks>:setup | `Error` | 0.00 | test_routers_network_ops.py ContextSuite context=TestRedundantIsolateNetworks>:setup | `Error` | 0.00 | test_routers_network_ops.py ContextSuite context=TestRouterServices>:setup | `Error` | 0.00 | test_routers.py ContextSuite context=TestCpuCapServiceOfferings>:setup | `Error` | 0.00 | test_service_offerings.py ContextSuite context=TestServiceOfferings>:setup | `Error` | 0.15 | test_service_offerings.py ContextSuite context=TestSnapshotRootDisk>:setup | `Error` | 0.00 | test_snapshots.py test_01_list_sec_storage_vm | `Failure` | 0.03 | test_ssvm.py test_02_list_cpvm_vm | `Failure` | 0.02 | test_ssvm.py test_03_ssvm_internals | `Failure` | 0.02 | test_ssvm.py test_04_cpvm_internals | `Failure` | 0.02 | test_ssvm.py test_05_stop_ssvm | `Failure` | 0.02 | test_ssvm.py test_06_stop_cpvm | `Failure` | 0.02 | test_ssvm.py test_07_reboot_ssvm | `Failure` | 0.04 | test_ssvm.py test_08_reboot_cpvm | `Failure` | 0.02 | test_ssvm.py test_09_destroy_ssvm | `Failure` | 0.03 | test_ssvm.py test_10_destroy_cpvm | `Failure` | 0.02 | test_ssvm.py test_02_create_template_with_checksum_sha1 | `Error` | 65.41 | test_templates.py test_03_create_template_with_checksum_sha256 | `Error` | 65.36 | test_templates.py test_04_create_template_with_checksum_md5 | `Error` | 65.37 | test_templates.py test_05_create_template_with_no_checksum | `Error` | 65.31 | test_templates.py
[GitHub] [cloudstack] blueorangutan removed a comment on pull request #4176: server: Purge all cookies on logout, set /client path on login
blueorangutan removed a comment on pull request #4176: URL: https://github.com/apache/cloudstack/pull/4176#issuecomment-654477256 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan removed a comment on pull request #4176: server: Purge all cookies on logout, set /client path on login
blueorangutan removed a comment on pull request #4176: URL: https://github.com/apache/cloudstack/pull/4176#issuecomment-649205477 Trillian test result (tid-1841) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 29723 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4176-t1841-kvm-centos7.zip Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py Smoke tests completed. 75 look OK, 2 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_02_vpc_privategw_static_routes | `Failure` | 173.24 | test_privategw_acl.py test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 174.12 | test_privategw_acl.py test_04_rvpc_privategw_static_routes | `Failure` | 250.55 | test_privategw_acl.py test_hostha_kvm_host_degraded | `Error` | 7.57 | test_hostha_kvm.py This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support
blueorangutan commented on pull request #4068: URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-655222575 Trillian test result (tid-2018) Environment: kvm-centos8 (x2), Advanced Networking with Mgmt server 7 Total time taken: 54558 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4068-t2018-kvm-centos8.zip Intermittent failure detected: /marvin/tests/smoke/test_volumes.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py Smoke tests completed. 81 look OK, 2 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_06_download_detached_volume | `Error` | 14.30 | test_volumes.py test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | `Error` | 382.36 | test_vpc_redundant.py test_04_rvpc_network_garbage_collector_nics | `Error` | 3900.75 | test_vpc_redundant.py This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4176: server: Purge all cookies on logout, set /client path on login
blueorangutan commented on pull request #4176: URL: https://github.com/apache/cloudstack/pull/4176#issuecomment-655212705 Trillian test result (tid-2026) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 28097 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4176-t2026-kvm-centos7.zip Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py Smoke tests completed. 76 look OK, 1 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_02_vpc_privategw_static_routes | `Failure` | 176.97 | test_privategw_acl.py test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 176.08 | test_privategw_acl.py test_04_rvpc_privategw_static_routes | `Failure` | 245.60 | test_privategw_acl.py This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support
blueorangutan commented on pull request #4068: URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-655187632 Trillian test result (tid-2017) Environment: kvm-centos8 (x2), Advanced Networking with Mgmt server 8 Total time taken: 49184 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4068-t2017-kvm-centos8.zip Intermittent failure detected: /marvin/tests/smoke/test_volumes.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py Smoke tests completed. 81 look OK, 2 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_06_download_detached_volume | `Error` | 16.37 | test_volumes.py test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 435.38 | test_vpc_redundant.py test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | `Error` | 348.58 | test_vpc_redundant.py test_04_rvpc_network_garbage_collector_nics | `Error` | 3903.57 | test_vpc_redundant.py This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #4128: Role based users in Projects
nvazquez commented on pull request #4128: URL: https://github.com/apache/cloudstack/pull/4128#issuecomment-655164442 Looks good @Pearl1594 thanks, left some comments This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on a change in pull request #4128: Role based users in Projects
nvazquez commented on a change in pull request #4128:
URL: https://github.com/apache/cloudstack/pull/4128#discussion_r451155712
##
File path:
api/src/main/java/org/apache/cloudstack/api/command/user/project/UpdateProjectCmd.java
##
@@ -68,11 +89,49 @@ public String getDisplayText() {
return displayText;
}
+public Long getUserId() {
+return userId;
+}
+
+public Long getDomainId() {
+if (domainId != null) {
+return domainId;
+}
+return CallContext.current().getCallingAccount().getDomainId();
+}
+
+public ProjectAccount.Role getRoleType(String role) {
+String type = role.substring(0, 1).toUpperCase() +
role.substring(1).toLowerCase();
+if (!EnumUtils.isValidEnum(ProjectAccount.Role.class, type)) {
+throw new InvalidParameterValueException("Only Admin or Regular
project role types are valid");
+}
+return Enum.valueOf(ProjectAccount.Role.class, type);
+}
+
+public ProjectAccount.Role getAccountRole() {
+if (roleType != null) {
Review comment:
Same
##
File path: api/src/main/java/org/apache/cloudstack/api/BaseCmd.java
##
@@ -264,6 +269,10 @@ public String getActualCommandName() {
*/
public abstract long getEntityOwnerId();
+public List getEntityOwnerIds() {
+return null;
Review comment:
+1 verified
##
File path:
api/src/main/java/org/apache/cloudstack/api/command/user/project/UpdateProjectCmd.java
##
@@ -68,11 +89,49 @@ public String getDisplayText() {
return displayText;
}
+public Long getUserId() {
+return userId;
+}
+
+public Long getDomainId() {
+if (domainId != null) {
+return domainId;
+}
+return CallContext.current().getCallingAccount().getDomainId();
+}
+
+public ProjectAccount.Role getRoleType(String role) {
+String type = role.substring(0, 1).toUpperCase() +
role.substring(1).toLowerCase();
+if (!EnumUtils.isValidEnum(ProjectAccount.Role.class, type)) {
+throw new InvalidParameterValueException("Only Admin or Regular
project role types are valid");
+}
+return Enum.valueOf(ProjectAccount.Role.class, type);
+}
+
+public ProjectAccount.Role getAccountRole() {
+if (roleType != null) {
+return getRoleType(roleType);
+}
+return ProjectAccount.Role.Regular;
+}
+
+public Long getAccountId() {
+return accountId;
+}
+
@Override
public String getCommandName() {
return s_name;
}
+public Boolean isSwapOwner() {
+if (swapOwner != null) {
Review comment:
Minor one: this can be written in one line
##
File path:
api/src/main/java/org/apache/cloudstack/api/command/user/account/AddUserToProjectCmd.java
##
@@ -0,0 +1,154 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.cloudstack.api.command.user.account;
+
+import org.apache.cloudstack.acl.RoleType;
+import org.apache.cloudstack.api.APICommand;
+import org.apache.cloudstack.api.ApiArgValidator;
+import org.apache.cloudstack.api.ApiConstants;
+import org.apache.cloudstack.api.ApiErrorCode;
+import org.apache.cloudstack.api.BaseAsyncCmd;
+import org.apache.cloudstack.api.BaseCmd;
+import org.apache.cloudstack.api.Parameter;
+import org.apache.cloudstack.api.ServerApiException;
+import org.apache.cloudstack.api.response.ProjectResponse;
+import org.apache.cloudstack.api.response.ProjectRoleResponse;
+import org.apache.cloudstack.api.response.SuccessResponse;
+import org.apache.cloudstack.api.response.UserResponse;
+import org.apache.cloudstack.context.CallContext;
+import org.apache.commons.lang3.EnumUtils;
+
+import com.cloud.event.EventTypes;
+import com.cloud.exception.InvalidParameterValueException;
+import com.cloud.projects.ProjectAccount;
+
+@APICommand(name = AddUserToProjectCmd.APINAME, description = "Adds user to a
project", responseObject = SuccessResponse.class, since = "4.14",
+requestHasSensitiveInfo = false, responseHasSensitiveInfo = false,
authorized = {RoleType.Admin,
[GitHub] [cloudstack] blueorangutan commented on pull request #4128: Role based users in Projects
blueorangutan commented on pull request #4128: URL: https://github.com/apache/cloudstack/pull/4128#issuecomment-65560 Trillian test result (tid-2016) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 40096 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4128-t2016-kvm-centos7.zip Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py Smoke tests completed. 83 look OK, 1 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 319.02 | test_vpc_redundant.py test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | `Failure` | 251.75 | test_vpc_redundant.py This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support
blueorangutan commented on pull request #4068: URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-655078006 Trillian test result (tid-2015) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 8 Total time taken: 37257 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4068-t2015-kvm-centos7.zip Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py Smoke tests completed. 83 look OK, 0 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4196: VMware: Guest OS Mappings fix
blueorangutan commented on pull request #4196: URL: https://github.com/apache/cloudstack/pull/4196#issuecomment-655025991 Trillian test result (tid-2013) Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7 Total time taken: 37039 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4196-t2013-vmware-65u2.zip Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py Intermittent failure detected: /marvin/tests/smoke/test_ssvm.py Smoke tests completed. 83 look OK, 0 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] mib1185 opened a new issue #4206: Behavior vm.instancename.flag not as expected/documented
mib1185 opened a new issue #4206: URL: https://github.com/apache/cloudstack/issues/4206 # ISSUE TYPE * Bug Report # COMPONENT NAME ~~~ VMware plugin ~~~ # CLOUDSTACK VERSION ~~~ 4.13.0 ~~~ # CONFIGURATION ~~~ vCenter-Version: 6.7.0, 15976728 vSphere-Version: ESXi, 6.7.0, 10302608 `vm.instancename.flag` = `true` ~~~ # OS / ENVIRONMENT # SUMMARY Behavior of global parameter `vm.instancename.flag` has been changed with 51ee90074d5b53be261dcc746e4bd8a1058dfb6a and therefore does not work as expected by documentation http://docs.cloudstack.apache.org/en/latest/adminguide/virtual_machines.html#id2 # STEPS TO REPRODUCE ~~~ - set `vm.instancename.flag` to `true` - reboot management instance - create new instance via WebUI on VMware powered zone with provided "Name (Optional) = dummy-03" ~~~ # EXPECTED RESULTS ~~~ Name on vCenter = i---displayName Internal Name = i---displayName ~~~ # ACTUAL RESULTS ~~~ Name on vCenter = dummy-03 Internal Name = i-9-140-VM ~~~ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4176: server: Purge all cookies on logout, set /client path on login
blueorangutan commented on pull request #4176: URL: https://github.com/apache/cloudstack/pull/4176#issuecomment-654973236 @Pearl1594 a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #4176: server: Purge all cookies on logout, set /client path on login
Pearl1594 commented on pull request #4176: URL: https://github.com/apache/cloudstack/pull/4176#issuecomment-654972601 @rhtyd it works now - for both changing context.path to a value other that /client and for / Have to test it for SAML login This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #4176: server: Purge all cookies on logout, set /client path on login
Pearl1594 commented on pull request #4176: URL: https://github.com/apache/cloudstack/pull/4176#issuecomment-654972970 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4176: server: Purge all cookies on logout, set /client path on login
blueorangutan commented on pull request #4176: URL: https://github.com/apache/cloudstack/pull/4176#issuecomment-654917140 Packaging result: ✔centos7 ✔debian. JID-1551 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #4176: server: Purge all cookies on logout, set /client path on login
Pearl1594 commented on pull request #4176: URL: https://github.com/apache/cloudstack/pull/4176#issuecomment-654903140 @rhtyd looking into it This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4176: server: Purge all cookies on logout, set /client path on login
blueorangutan commented on pull request #4176: URL: https://github.com/apache/cloudstack/pull/4176#issuecomment-654903174 @Pearl1594 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #4176: server: Purge all cookies on logout, set /client path on login
Pearl1594 commented on pull request #4176: URL: https://github.com/apache/cloudstack/pull/4176#issuecomment-654902830 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4047: Look for active templates for VR deployment
blueorangutan commented on pull request #4047: URL: https://github.com/apache/cloudstack/pull/4047#issuecomment-654892141 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4047: Look for active templates for VR deployment
rhtyd commented on pull request #4047: URL: https://github.com/apache/cloudstack/pull/4047#issuecomment-654891499 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] weizhouapache closed pull request #4000: vm: Reset deviceId to fix missing nic with vm
weizhouapache closed pull request #4000: URL: https://github.com/apache/cloudstack/pull/4000 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] VincentHermes commented on issue #4199: HTTPS does not initiate
VincentHermes commented on issue #4199: URL: https://github.com/apache/cloudstack/issues/4199#issuecomment-654885550 @rhtyd We tried these certificate combinations: * Key - Server Cert - Intermediate Cert - RootCA * Key - Server Cert - Intermediate Cert * Key - Server Cert - RootCA * Key - Server Cert Only the server cert doesn't work of course because generating the keystore requires a fitting key. None of these worked however. The creation of the Self Signed happened like that: `openssl genrsa -out selfsigned.key 2048` `openssl req -new -key selfsigned.key -out selfsigned.csr` `openssl x509 -req -days 3650 -in selfsigned.csr -signkey selfsigned.key -out selfsigned.crt` `cat selfsigned.key selfsigned.crt > selfsignedcombined.crt` `openssl pkcs12 -in selfsignedcombined.crt -export -out selfsignedcombined.pkcs12` `keytool -importkeystore -srckeystore selfsignedcombined.pkcs12 -srcstoretype PKCS12 -destkeystore /etc/cloudstack/management/selfsignedcombined.pkcs12 -deststoretype pkcs12` And after editing `server.properties` it launched HTTPS with that self signed cert. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4150: [HEALTH][4.14] Health Check Run
blueorangutan commented on pull request #4150: URL: https://github.com/apache/cloudstack/pull/4150#issuecomment-654872667 Packaging result: ✔centos7 ✔debian. JID-1550 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4131: [HEALTH] Master/4.15 Health Check please don't merge this
blueorangutan commented on pull request #4131: URL: https://github.com/apache/cloudstack/pull/4131#issuecomment-654872668 Packaging result: ✔centos7 ✔debian. JID-1549 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4150: [HEALTH][4.14] Health Check Run
blueorangutan commented on pull request #4150: URL: https://github.com/apache/cloudstack/pull/4150#issuecomment-654851098 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4131: [HEALTH] Master/4.15 Health Check please don't merge this
blueorangutan commented on pull request #4131: URL: https://github.com/apache/cloudstack/pull/4131#issuecomment-654850888 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4131: [HEALTH] Master/4.15 Health Check please don't merge this
rhtyd commented on pull request #4131: URL: https://github.com/apache/cloudstack/pull/4131#issuecomment-654850307 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4176: server: Purge all cookies on logout, set /client path on login
rhtyd commented on pull request #4176: URL: https://github.com/apache/cloudstack/pull/4176#issuecomment-654850022 @Pearl1594 @davidjumani any progress on this? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4150: [HEALTH][4.14] Health Check Run
rhtyd commented on pull request #4150: URL: https://github.com/apache/cloudstack/pull/4150#issuecomment-654850203 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on issue #4199: HTTPS does not initiate
rhtyd commented on issue #4199: URL: https://github.com/apache/cloudstack/issues/4199#issuecomment-654845984 @VincentHermes thanks for sharing, does this work for you if you use a single certificate? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] VincentHermes commented on issue #4199: HTTPS does not initiate
VincentHermes commented on issue #4199: URL: https://github.com/apache/cloudstack/issues/4199#issuecomment-654841256 After additional investigation with our very capable colleague we seem to have found the error, but are not able to solve it. There is an exception on jetty regarding keystores: `Exception in thread "main" java.lang.IllegalStateException: KeyStores with multiple certificates are not supported on the` `base class org.eclipse.jetty.util.ssl.SslContextFactory. (Use org.eclipse.jetty.util.ssl.SslContextFactory$Server or` `org.eclipse.jetty.util.ssl.SslContextFactory$Client instead)` `at org.eclipse.jetty.util.ssl.SslContextFactory.newSniX509ExtendedKeyManager(SslContextFactory.java:1275)` ` ` `KeyStores with multiple certificates are not supported on the base class org.eclipse.jetty.util.ssl.SslContextFactory` Starting with `jetty-9.4.23.v20191118` the usage of `SslContextFactory` is deprecated and `SslContextFactory.Server` must be used instead. The embedded Version in CS 4.14 is `jetty-9.4.26.v20200117`. I think this is the root of our HTTPS Issue. We are not able to solve this but we are using an Apache Proxy now, which however does not allow to upload from local but that's another story. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[cloudstack] branch master updated (2c82aac -> cb6b89c)
This is an automated email from the ASF dual-hosted git repository. rohit pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git. from 2c82aac Merge remote-tracking branch 'origin/4.14' add db9f825 server: don't export B APIs if feature is not enabled globally (#4202) add cb6b89c Merge remote-tracking branch 'origin/4.14' No new revisions were added by this update. Summary of changes: .../apache/cloudstack/backup/BackupManager.java| 2 +- developer/developer-prefill.sql| 9 +++-- .../cloudstack/backup/BackupManagerImpl.java | 6 +- .../smoke/test_backup_recovery_dummy.py| 22 ++ 4 files changed, 27 insertions(+), 12 deletions(-)
[GitHub] [cloudstack] rhtyd commented on pull request #4202: server: don't export B APIs if feature is not enabled globally
rhtyd commented on pull request #4202: URL: https://github.com/apache/cloudstack/pull/4202#issuecomment-654839671 Tested on KVM env, it skips tests for dummy provider now: ``` Import provider backup offering from Dummy Backup and Recovery Provider ... SKIP: Skipping test cases which must only run for Simulator Test VM backup lifecycle ... SKIP: Skipping test cases which must only run for Simulator -- Ran 2 tests in 0.124s OK (SKIP=2) ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd merged pull request #4202: server: don't export B APIs if feature is not enabled globally
rhtyd merged pull request #4202: URL: https://github.com/apache/cloudstack/pull/4202 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[cloudstack] branch 4.14 updated: server: don't export B APIs if feature is not enabled globally (#4202)
This is an automated email from the ASF dual-hosted git repository.
rohit pushed a commit to branch 4.14
in repository https://gitbox.apache.org/repos/asf/cloudstack.git
The following commit(s) were added to refs/heads/4.14 by this push:
new db9f825 server: don't export B APIs if feature is not enabled
globally (#4202)
db9f825 is described below
commit db9f8258d7a8eff283ff055fb11bca41d1bfc94e
Author: Rohit Yadav
AuthorDate: Tue Jul 7 18:29:44 2020 +0530
server: don't export B APIs if feature is not enabled globally (#4202)
This change will ensure that B APIs are not exported if the feature
is not enabled in any of the zones.
Signed-off-by: Rohit Yadav
---
.../apache/cloudstack/backup/BackupManager.java| 2 +-
developer/developer-prefill.sql| 9 +++--
.../cloudstack/backup/BackupManagerImpl.java | 6 +-
.../smoke/test_backup_recovery_dummy.py| 22 ++
4 files changed, 27 insertions(+), 12 deletions(-)
diff --git a/api/src/main/java/org/apache/cloudstack/backup/BackupManager.java
b/api/src/main/java/org/apache/cloudstack/backup/BackupManager.java
index 7c9d3b6..5751125 100644
--- a/api/src/main/java/org/apache/cloudstack/backup/BackupManager.java
+++ b/api/src/main/java/org/apache/cloudstack/backup/BackupManager.java
@@ -38,7 +38,7 @@ public interface BackupManager extends BackupService,
Configurable, PluggableSer
ConfigKey BackupFrameworkEnabled = new ConfigKey<>("Advanced",
Boolean.class,
"backup.framework.enabled",
"false",
-"Is backup and recovery framework enabled.", true,
ConfigKey.Scope.Zone);
+"Is backup and recovery framework enabled.", false,
ConfigKey.Scope.Zone);
ConfigKey BackupProviderPlugin = new ConfigKey<>("Advanced",
String.class,
"backup.framework.provider.plugin",
diff --git a/developer/developer-prefill.sql b/developer/developer-prefill.sql
index c9ab468..0715e07 100644
--- a/developer/developer-prefill.sql
+++ b/developer/developer-prefill.sql
@@ -114,16 +114,21 @@ INSERT INTO `cloud`.`configuration` (category, instance,
component, name, value)
VALUES ('Advanced', 'DEFAULT', 'management-server',
'ping.timeout', '2.0');
--- Enable dynamic RBAC by default for fresh deployments
+-- Enable dynamic RBAC by default for developers
INSERT INTO `cloud`.`configuration` (category, instance, component, name,
value)
VALUES ('Advanced', 'DEFAULT', 'RoleService',
'dynamic.apichecker.enabled', 'true');
--- Enable RootCA auth strictness for fresh deployments
+-- Enable RootCA auth strictness for developers
INSERT INTO `cloud`.`configuration` (category, instance, component, name,
value)
VALUES ('Advanced', 'DEFAULT', 'RootCAProvider',
'ca.plugin.root.auth.strictness', 'true');
+-- Enable B feature for developers
+INSERT INTO `cloud`.`configuration` (category, instance, component, name,
value)
+VALUES ('Advanced', 'DEFAULT', 'BackupService',
+'backup.framework.enabled', 'true');
+
-- Add developer configuration entry; allows management server to be run as a
user other than "cloud"
INSERT INTO `cloud`.`configuration` (category, instance, component, name,
value)
VALUES ('Advanced', 'DEFAULT', 'management-server',
diff --git
a/server/src/main/java/org/apache/cloudstack/backup/BackupManagerImpl.java
b/server/src/main/java/org/apache/cloudstack/backup/BackupManagerImpl.java
index f3b0a3c..b11d1bc 100644
--- a/server/src/main/java/org/apache/cloudstack/backup/BackupManagerImpl.java
+++ b/server/src/main/java/org/apache/cloudstack/backup/BackupManagerImpl.java
@@ -736,7 +736,7 @@ public class BackupManagerImpl extends ManagerBase
implements BackupManager {
}
public boolean isDisabled(final Long zoneId) {
-return !BackupFrameworkEnabled.valueIn(zoneId);
+return !(BackupFrameworkEnabled.value() &&
BackupFrameworkEnabled.valueIn(zoneId));
}
private void validateForZone(final Long zoneId) {
@@ -769,6 +769,10 @@ public class BackupManagerImpl extends ManagerBase
implements BackupManager {
@Override
public List> getCommands() {
final List> cmdList = new ArrayList>();
+if (!BackupFrameworkEnabled.value()) {
+return cmdList;
+}
+
// Offerings
cmdList.add(ListBackupProvidersCmd.class);
cmdList.add(ListBackupProviderOfferingsCmd.class);
diff --git a/test/integration/smoke/test_backup_recovery_dummy.py
b/test/integration/smoke/test_backup_recovery_dummy.py
index 79f375c..0c7ae64 100644
--- a/test/integration/smoke/test_backup_recovery_dummy.py
+++ b/test/integration/smoke/test_backup_recovery_dummy.py
@@ -41,15 +41,9 @@ class TestDummyBackupAndRecovery(cloudstackTestCase):
assert False, "get_template() failed to return template with
description %s" %
[cloudstack-primate] branch master updated: compute: Changing VM Snapshots and Backups to their own tabs if allowed (#501)
This is an automated email from the ASF dual-hosted git repository.
rohit pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack-primate.git
The following commit(s) were added to refs/heads/master by this push:
new 47f169a compute: Changing VM Snapshots and Backups to their own tabs
if allowed (#501)
47f169a is described below
commit 47f169acf0a801120f5b4d627f072a78bee21ded
Author: davidjumani
AuthorDate: Tue Jul 7 18:20:12 2020 +0530
compute: Changing VM Snapshots and Backups to their own tabs if allowed
(#501)
Fixes #487
---
src/components/view/ListResourceTable.vue | 118 ++
src/config/section/compute.js | 9 ---
src/views/compute/InstanceTab.vue | 20 -
3 files changed, 136 insertions(+), 11 deletions(-)
diff --git a/src/components/view/ListResourceTable.vue
b/src/components/view/ListResourceTable.vue
new file mode 100644
index 000..8bc7ad6
--- /dev/null
+++ b/src/components/view/ListResourceTable.vue
@@ -0,0 +1,118 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+
+
+
+
+ {{ text }}
+ {{ text }}
+
+
+ {{ text }}
+
+
+
+
+
+
+import { api } from '@/api'
+import Status from '@/components/widgets/Status'
+
+export default {
+ name: 'ListResourceTable',
+ components: {
+Status
+ },
+ props: {
+apiName: {
+ type: String,
+ required: true
+},
+routerlink: {
+ type: Object,
+ default: () => {}
+},
+params: {
+ type: Object,
+ required: true
+},
+columns: {
+ type: Array,
+ required: true
+}
+ },
+ data () {
+return {
+ loading: false,
+ items: []
+}
+ },
+ mounted () {
+this.fetchData()
+ },
+ methods: {
+fetchData () {
+ this.loading = true
+ var params = this.params
+ params.listall = true
+ params.response = 'json'
+ params.details = 'min'
+ api(this.apiName, this.params).then(json => {
+var responseName
+var objectName
+for (const key in json) {
+ if (key.includes('response')) {
+responseName = key
+break
+ }
+}
+for (const key in json[responseName]) {
+ if (key === 'count') {
+continue
+ }
+ objectName = key
+ break
+}
+this.items = json[responseName][objectName]
+if (!this.items || this.items.length === 0) {
+ this.items = []
+}
+ }).finally(() => {
+this.loading = false
+ })
+},
+fetchColumns () {
+ var columns = []
+ for (const col of this.columns) {
+columns.push({
+ dataIndex: col,
+ title: this.$t('label.' + col),
+ scopedSlots: { customRender: col }
+})
+ }
+ return columns
+}
+ }
+}
+
diff --git a/src/config/section/compute.js b/src/config/section/compute.js
index 27d056b..2931764 100644
--- a/src/config/section/compute.js
+++ b/src/config/section/compute.js
@@ -63,15 +63,6 @@ export default {
},
searchFilters: ['name', 'zoneid', 'domainid', 'account', 'tags'],
details: ['displayname', 'name', 'id', 'state', 'ipaddress',
'templatename', 'ostypename', 'serviceofferingname', 'isdynamicallyscalable',
'haenable', 'hypervisor', 'boottype', 'bootmode', 'account', 'domain',
'zonename'],
- related: [{
-name: 'vmsnapshot',
-title: 'label.vm.snapshots',
-param: 'virtualmachineid'
- }, {
-name: 'backup',
-title: 'label.backup',
-param: 'virtualmachineid'
- }],
tabs: [{
component: () => import('@/views/compute/InstanceTab.vue')
}],
diff --git a/src/views/compute/InstanceTab.vue
b/src/views/compute/InstanceTab.vue
index e11bb19..8568d44 100644
--- a/src/views/compute/InstanceTab.vue
+++ b/src/views/compute/InstanceTab.vue
@@ -49,7 +49,7 @@
-
+{{ text }}
{{ parseFloat(item.size / (1024.0 * 1024.0 * 1024.0)).toFixed(2)
}} GB
@@ -115,6 +115,20 @@
+
+
[cloudstack-primate] branch master updated (74218bb -> 597df39)
This is an automated email from the ASF dual-hosted git repository. rohit pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack-primate.git. from 74218bb autogenview: store API parameters as router query for history (#454) add 597df39 views: add form element info tooltips (#483) No new revisions were added by this update. Summary of changes: src/views/compute/CreateKubernetesCluster.vue | 88 -- src/views/compute/KubernetesServiceTab.vue| 77 - src/views/compute/ScaleKubernetesCluster.vue | 16 +- src/views/compute/UpgradeKubernetesCluster.vue| 8 +- src/views/image/AddKubernetesSupportedVersion.vue | 56 ++- src/views/network/CreateIsolatedNetworkForm.vue | 101 ++-- src/views/network/CreateL2NetworkForm.vue | 85 -- src/views/network/CreateSharedNetworkForm.vue | 186 +++--- 8 files changed, 505 insertions(+), 112 deletions(-)
[cloudstack-primate] branch master updated: autogenview: store API parameters as router query for history (#454)
This is an automated email from the ASF dual-hosted git repository.
rohit pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack-primate.git
The following commit(s) were added to refs/heads/master by this push:
new 74218bb autogenview: store API parameters as router query for history
(#454)
74218bb is described below
commit 74218bb6bcb188088cef99f06b077c9005490f61
Author: Rohit Yadav
AuthorDate: Tue Jul 7 18:10:58 2020 +0530
autogenview: store API parameters as router query for history (#454)
This would store pagination, filter and search context in route query
which would allow for browser history navigation in list views.
Fixes #451
Signed-off-by: Rohit Yadav
---
src/components/view/SearchView.vue | 24 +++--
src/views/AutogenView.vue | 185 +++--
2 files changed, 115 insertions(+), 94 deletions(-)
diff --git a/src/components/view/SearchView.vue
b/src/components/view/SearchView.vue
index 6e5cfb3..5d162f5 100644
--- a/src/components/view/SearchView.vue
+++ b/src/components/view/SearchView.vue
@@ -99,7 +99,7 @@
class="filter-button"
size="small"
@click="() => { searchQuery = null }">
-
+
@@ -121,12 +121,12 @@ export default {
type: String,
default: () => ''
},
-selectedFilters: {
+searchParams: {
type: Object,
default: () => {}
}
},
- inject: ['parentSearch', 'parentFilter', 'parentChangeFilter'],
+ inject: ['parentSearch', 'parentChangeFilter'],
data () {
return {
searchQuery: null,
@@ -145,6 +145,18 @@ export default {
if (newValue) {
this.initFormFieldData()
}
+},
+'$route' (to, from) {
+ this.searchQuery = ''
+ if (to && to.query && 'q' in to.query) {
+this.searchQuery = to.query.q
+ }
+}
+ },
+ mounted () {
+this.searchQuery = ''
+if (this.$route && this.$route.query && 'q' in this.$route.query) {
+ this.searchQuery = this.$route.query.q
}
},
computed: {
@@ -380,7 +392,7 @@ export default {
onSearch (value) {
this.paramsFilter = {}
this.searchQuery = value
- this.parentSearch(this.searchQuery)
+ this.parentSearch({ searchQuery: this.searchQuery })
},
onClear () {
this.searchFilters.map(item => {
@@ -392,7 +404,7 @@ export default {
this.inputValue = null
this.searchQuery = null
this.paramsFilter = {}
- this.parentFilter(this.paramsFilter)
+ this.parentSearch(this.paramsFilter)
},
handleSubmit (e) {
e.preventDefault()
@@ -414,7 +426,7 @@ export default {
this.paramsFilter['tags[0].value'] = this.inputValue
}
}
-this.parentFilter(this.paramsFilter)
+this.parentSearch(this.paramsFilter)
})
},
handleKeyChange (e) {
diff --git a/src/views/AutogenView.vue b/src/views/AutogenView.vue
index 33d532b..dbfc573 100644
--- a/src/views/AutogenView.vue
+++ b/src/views/AutogenView.vue
@@ -28,7 +28,7 @@
shape="round"
size="small"
icon="reload"
-@click="fetchData({ listall: true, irefresh: true })">
+@click="fetchData({ irefresh: true })">
{{ $t('label.refresh') }}
-
+
+{{ $t('label.all') }}
+
+
{{ $t('label.' + filter) }}
@@ -71,7 +74,7 @@
@@ -346,7 +349,6 @@ export default {
parentFinishLoading: this.finishLoading,
parentSearch: this.onSearch,
parentChangeFilter: this.changeFilter,
- parentFilter: this.onFilter,
parentChangeResource: this.changeResource,
parentPollActionCompletion: this.pollActionCompletion,
parentEditTariffAction: () => {}
@@ -362,7 +364,6 @@ export default {
itemCount: 0,
page: 1,
pageSize: 10,
- searchQuery: '',
resource: {},
selectedRowKeys: [],
currentAction: {},
@@ -371,7 +372,7 @@ export default {
selectedFilter: '',
filters: [],
searchFilters: [],
- paramsFilters: {},
+ searchParams: {},
actions: [],
formModel: {},
confirmDirty: false
@@ -401,11 +402,14 @@ export default {
watch: {
'$route' (to, from) {
if (to.fullPath !== from.fullPath && !to.fullPath.includes('action/')) {
-this.searchQuery = ''
-this.paramsFilters = {}
-this.page = 1
+if ('page' in to.query) {
+ this.page = Number(to.query.page)
+ this.pageSize = Number(to.query.pagesize)
+} else {
+ this.page = 1
+ this.pageSize =
[cloudstack-primate] branch master updated: component: override projectid in case tags are in project
This is an automated email from the ASF dual-hosted git repository.
rohit pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack-primate.git
The following commit(s) were added to refs/heads/master by this push:
new 611e517 component: override projectid in case tags are in project
611e517 is described below
commit 611e5177865612e832964b502fca7e0852d4c42e
Author: Rohit Yadav
AuthorDate: Tue Jul 7 18:06:15 2020 +0530
component: override projectid in case tags are in project
Fixes #500
Signed-off-by: Rohit Yadav
---
src/components/view/InfoCard.vue | 17 ++---
1 file changed, 10 insertions(+), 7 deletions(-)
diff --git a/src/components/view/InfoCard.vue b/src/components/view/InfoCard.vue
index ae93566..067cacb 100644
--- a/src/components/view/InfoCard.vue
+++ b/src/components/view/InfoCard.vue
@@ -680,10 +680,6 @@ export default {
watch: {
resource: function (newItem, oldItem) {
this.resource = newItem
- if (newItem.id === oldItem.id) {
-return
- }
-
this.resourceType = this.$route.meta.resourceType
this.annotationType = ''
this.showKeys = false
@@ -706,8 +702,7 @@ export default {
if ('tags' in this.resource) {
this.tags = this.resource.tags
- }
- if (this.resourceType) {
+ } else if (this.resourceType) {
this.getTags()
}
if (this.annotationType) {
@@ -745,7 +740,15 @@ export default {
return
}
this.tags = []
- api('listTags', { listall: true, resourceid: this.resource.id,
resourcetype: this.resourceType }).then(json => {
+ const params = {
+listall: true,
+resourceid: this.resource.id,
+resourcetype: this.resourceType
+ }
+ if (this.$route.meta.name === 'project') {
+params.projectid = this.resource.id
+ }
+ api('listTags', params).then(json => {
if (json.listtagsresponse && json.listtagsresponse.tag) {
this.tags = json.listtagsresponse.tag
}
[GitHub] [cloudstack] blueorangutan commented on pull request #4131: [HEALTH] Master/4.15 Health Check please don't merge this
blueorangutan commented on pull request #4131: URL: https://github.com/apache/cloudstack/pull/4131#issuecomment-654789331 Packaging result: ✔centos7 ✔debian. JID-1548 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4131: [HEALTH] Master/4.15 Health Check please don't merge this
blueorangutan commented on pull request #4131: URL: https://github.com/apache/cloudstack/pull/4131#issuecomment-654774321 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4131: [HEALTH] Master/4.15 Health Check please don't merge this
rhtyd commented on pull request #4131: URL: https://github.com/apache/cloudstack/pull/4131#issuecomment-654773732 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[cloudstack-primate] branch master updated (bf68e2b -> 5c01a51)
This is an automated email from the ASF dual-hosted git repository. rohit pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack-primate.git. from bf68e2b bugfix: usability issue fixes (#506) add 5c01a51 github: issues template table to checklist (#508) No new revisions were added by this update. Summary of changes: .github/ISSUE_TEMPLATE/smoke_test_plan.md | 347 .github/ISSUE_TEMPLATE/test_full_plan.md | 1313 ++--- src/views/compute/InstanceTab.vue |3 - 3 files changed, 826 insertions(+), 837 deletions(-)
[cloudstack-primate] branch master updated (1f25e7c -> bf68e2b)
This is an automated email from the ASF dual-hosted git repository. rohit pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack-primate.git. from 1f25e7c Update smoke_test_plan.md (#504) add bf68e2b bugfix: usability issue fixes (#506) No new revisions were added by this update. Summary of changes: src/components/view/DetailSettings.vue | 9 - src/config/section/image.js| 2 +- src/views/AutogenView.vue | 2 +- 3 files changed, 10 insertions(+), 3 deletions(-)
[GitHub] [cloudstack] blueorangutan commented on pull request #4202: server: don't export B APIs if feature is not enabled globally
blueorangutan commented on pull request #4202: URL: https://github.com/apache/cloudstack/pull/4202#issuecomment-654742878 Packaging result: ✔centos7 ✔debian. JID-1547 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4150: [HEALTH][4.14] Health Check Run
blueorangutan commented on pull request #4150: URL: https://github.com/apache/cloudstack/pull/4150#issuecomment-654734127 Packaging result: ✔centos7 ✔debian. JID-1546 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4150: [HEALTH][4.14] Health Check Run
rhtyd commented on pull request #4150: URL: https://github.com/apache/cloudstack/pull/4150#issuecomment-654714929 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4150: [HEALTH][4.14] Health Check Run
blueorangutan commented on pull request #4150: URL: https://github.com/apache/cloudstack/pull/4150#issuecomment-654715455 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #4128: Role based users in Projects
Pearl1594 commented on pull request #4128: URL: https://github.com/apache/cloudstack/pull/4128#issuecomment-654698942 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4128: Role based users in Projects
blueorangutan commented on pull request #4128: URL: https://github.com/apache/cloudstack/pull/4128#issuecomment-654699333 @Pearl1594 a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4128: Role based users in Projects
blueorangutan commented on pull request #4128: URL: https://github.com/apache/cloudstack/pull/4128#issuecomment-654698577 Packaging result: ✔centos7 ✔debian. JID-1545 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support
blueorangutan commented on pull request #4068: URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-654693422 Packaging result: ✔centos7 ✔debian. JID-1544 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4116: cks: fix template, deployment issues
blueorangutan commented on pull request #4116: URL: https://github.com/apache/cloudstack/pull/4116#issuecomment-654693366 Packaging result: ✔centos7 ✔debian. JID-1543 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[cloudstack-primate] branch master updated: Update smoke_test_plan.md (#504)
This is an automated email from the ASF dual-hosted git repository. rohit pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack-primate.git The following commit(s) were added to refs/heads/master by this push: new 1f25e7c Update smoke_test_plan.md (#504) 1f25e7c is described below commit 1f25e7c21dc46c4d1cb555c585e98303217f2a46 Author: vladimirpetrov AuthorDate: Tue Jul 7 11:19:37 2020 +0300 Update smoke_test_plan.md (#504) --- .github/ISSUE_TEMPLATE/smoke_test_plan.md | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/.github/ISSUE_TEMPLATE/smoke_test_plan.md b/.github/ISSUE_TEMPLATE/smoke_test_plan.md index a29ca4a..705ed3b 100644 --- a/.github/ISSUE_TEMPLATE/smoke_test_plan.md +++ b/.github/ISSUE_TEMPLATE/smoke_test_plan.md @@ -18,6 +18,13 @@ labels: testing | Add network to VM, change IP address, make it default, delete | | | | | Add/delete secondary IP address | | | | | | | | | +| **Compute > Kubernetes** | | | | +| Add Kubernetes cluster | | | | +| Start/stop a Kubernetes cluster | | | | +| Scale Kubernetes cluster | | | | +| Upgrade Kubernetes cluster | | | | +| Delete Kubernetes cluster | | | | +| | | | | | **Add Instance groups** | | | | | Add/modify/delete instance group| | | | | | | | | @@ -142,7 +149,11 @@ labels: testing | | | | | | **Backup offering** | | | | | Import offering | | | | -| | | | | +| Configure backup provider (Veeam) | | | | +| Create backup offering | | | | +| Assign VM to backup offering | | | | +| Revert to backup | | | | +| Delete backup | | | | | **Network offering** | | | | | Add isolated network with some supported services | | | | | Add L2 network | | | | @@ -160,6 +171,7 @@ labels: testing | | | | | | **LDAP configuration** | | | | | Add LDAP configuration | | | | +| Login with LDAP account | | | | | | | | | | **Common functionality** | | | | | Sorting | | | |
[cloudstack-primate] branch master updated (8b20a95 -> 039f2e5)
This is an automated email from the ASF dual-hosted git repository. rohit pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack-primate.git. from 8b20a95 image: Fixing permission issues (#472) add 039f2e5 Update test_full_plan.md (#505) No new revisions were added by this update. Summary of changes: .github/ISSUE_TEMPLATE/test_full_plan.md | 17 ++--- 1 file changed, 14 insertions(+), 3 deletions(-)
[GitHub] [cloudstack] blueorangutan commented on pull request #4128: Role based users in Projects
blueorangutan commented on pull request #4128: URL: https://github.com/apache/cloudstack/pull/4128#issuecomment-654673977 @Pearl1594 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #4128: Role based users in Projects
Pearl1594 commented on pull request #4128: URL: https://github.com/apache/cloudstack/pull/4128#issuecomment-654673301 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4047: Look for active templates for VR deployment
blueorangutan commented on pull request #4047: URL: https://github.com/apache/cloudstack/pull/4047#issuecomment-654670858 Packaging result: ✔centos7 ✔debian. JID-1542 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4116: cks: fix template, deployment issues
rhtyd commented on pull request #4116: URL: https://github.com/apache/cloudstack/pull/4116#issuecomment-654658480 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4116: cks: fix template, deployment issues
blueorangutan commented on pull request #4116: URL: https://github.com/apache/cloudstack/pull/4116#issuecomment-654658771 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4128: Role based users in Projects
rhtyd commented on pull request #4128: URL: https://github.com/apache/cloudstack/pull/4128#issuecomment-654655533 @Pearl1594 can you merge latest master and rekick tests? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4182: kvm: pre-add 32 PCI controller for hot-plug issue
rhtyd commented on pull request #4182: URL: https://github.com/apache/cloudstack/pull/4182#issuecomment-654655086 On hold - tests are failing, needs investigation and explore best case solution This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on issue #3543: Live Volume Resize when fails returns as success on KVM
rhtyd commented on issue #3543: URL: https://github.com/apache/cloudstack/issues/3543#issuecomment-654654410 Not applicable anymore as CentOS6 is no longer supported This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd closed issue #3543: Live Volume Resize when fails returns as success on KVM
rhtyd closed issue #3543: URL: https://github.com/apache/cloudstack/issues/3543 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on issue #4160: Creating template from volume snapshot leads to leaking ssh-key in the new template's settings
rhtyd commented on issue #4160: URL: https://github.com/apache/cloudstack/issues/4160#issuecomment-654653637 Reviewed this, essentially the template will belong to the same user and the user may delete the key from settings. Closing. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd closed issue #4160: Creating template from volume snapshot leads to leaking ssh-key in the new template's settings
rhtyd closed issue #4160: URL: https://github.com/apache/cloudstack/issues/4160 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on issue #4204: Test issue: ipmisim/pyghmi does not work with CentOS8 patched ipmitool
rhtyd commented on issue #4204: URL: https://github.com/apache/cloudstack/issues/4204#issuecomment-654652865 With @shwstppr This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[cloudstack] 01/01: Merge remote-tracking branch 'origin/4.14'
This is an automated email from the ASF dual-hosted git repository. rohit pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git commit 2c82aac5aadcb891f3e7d110f629ffe934d7adf3 Merge: 7a41e27 b141b8e Author: Rohit Yadav AuthorDate: Tue Jul 7 12:53:05 2020 +0530 Merge remote-tracking branch 'origin/4.14' .../cloud/deploy/DeploymentPlanningManager.java| 3 ++ .../main/java/com/cloud/user/dao/AccountDao.java | 2 ++ .../java/com/cloud/user/dao/AccountDaoImpl.java| 12 +-- .../cloudstack/quota/dao/QuotaAccountDao.java | 3 ++ .../cloudstack/quota/dao/QuotaAccountDaoImpl.java | 14 ++-- .../cloudstack/quota/dao/QuotaTariffDao.java | 9 +++-- .../cloudstack/quota/dao/QuotaTariffDaoImpl.java | 39 +++- .../cloudstack/api/command/QuotaSummaryCmd.java| 9 ++--- .../cloudstack/api/command/QuotaTariffListCmd.java | 7 ++-- .../api/response/QuotaResponseBuilder.java | 10 -- .../api/response/QuotaResponseBuilderImpl.java | 42 +++--- .../api/response/QuotaSummaryResponse.java | 12 +++ .../api/command/QuotaTariffListCmdTest.java| 4 ++- .../deploy/DeploymentPlanningManagerImpl.java | 6 ++-- .../com/cloud/server/ManagementServerImpl.java | 5 +++ 15 files changed, 128 insertions(+), 49 deletions(-)
[cloudstack] branch master updated (7a41e27 -> 2c82aac)
This is an automated email from the ASF dual-hosted git repository. rohit pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git. from 7a41e27 server: Limit API from trying to start a VM that is already running (#3979) add b64d0b2 quota: Adding pagination for quotaSummary and quotaTariffList (#4186) add 4da374b server: Dedicated hosts should be 'Not Suitable' while find hosts for vm migration (#4001) add b141b8e Merge remote-tracking branch 'origin/4.13' into 4.14 new 2c82aac Merge remote-tracking branch 'origin/4.14' The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: .../cloud/deploy/DeploymentPlanningManager.java| 3 ++ .../main/java/com/cloud/user/dao/AccountDao.java | 2 ++ .../java/com/cloud/user/dao/AccountDaoImpl.java| 12 +-- .../cloudstack/quota/dao/QuotaAccountDao.java | 3 ++ .../cloudstack/quota/dao/QuotaAccountDaoImpl.java | 14 ++-- .../cloudstack/quota/dao/QuotaTariffDao.java | 9 +++-- .../cloudstack/quota/dao/QuotaTariffDaoImpl.java | 39 +++- .../cloudstack/api/command/QuotaSummaryCmd.java| 9 ++--- .../cloudstack/api/command/QuotaTariffListCmd.java | 7 ++-- .../api/response/QuotaResponseBuilder.java | 10 -- .../api/response/QuotaResponseBuilderImpl.java | 42 +++--- .../api/response/QuotaSummaryResponse.java | 12 +++ .../api/command/QuotaTariffListCmdTest.java| 4 ++- .../deploy/DeploymentPlanningManagerImpl.java | 6 ++-- .../com/cloud/server/ManagementServerImpl.java | 5 +++ 15 files changed, 128 insertions(+), 49 deletions(-)
[GitHub] [cloudstack] rhtyd closed issue #4181: Quota API don't honour pagination and searching
rhtyd closed issue #4181: URL: https://github.com/apache/cloudstack/issues/4181 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[cloudstack] 01/01: Merge remote-tracking branch 'origin/4.13' into 4.14
This is an automated email from the ASF dual-hosted git repository. rohit pushed a commit to branch 4.14 in repository https://gitbox.apache.org/repos/asf/cloudstack.git commit b141b8e256c4d824052e62b2f4158b790cf67430 Merge: b64d0b2 4da374b Author: Rohit Yadav AuthorDate: Tue Jul 7 12:51:46 2020 +0530 Merge remote-tracking branch 'origin/4.13' into 4.14 .../src/main/java/com/cloud/deploy/DeploymentPlanningManager.java | 3 +++ .../main/java/com/cloud/deploy/DeploymentPlanningManagerImpl.java | 6 ++ server/src/main/java/com/cloud/server/ManagementServerImpl.java | 5 + 3 files changed, 10 insertions(+), 4 deletions(-)
[cloudstack] branch 4.14 updated (b64d0b2 -> b141b8e)
This is an automated email from the ASF dual-hosted git repository. rohit pushed a change to branch 4.14 in repository https://gitbox.apache.org/repos/asf/cloudstack.git. from b64d0b2 quota: Adding pagination for quotaSummary and quotaTariffList (#4186) add 4da374b server: Dedicated hosts should be 'Not Suitable' while find hosts for vm migration (#4001) new b141b8e Merge remote-tracking branch 'origin/4.13' into 4.14 The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: .../src/main/java/com/cloud/deploy/DeploymentPlanningManager.java | 3 +++ .../main/java/com/cloud/deploy/DeploymentPlanningManagerImpl.java | 6 ++ server/src/main/java/com/cloud/server/ManagementServerImpl.java | 5 + 3 files changed, 10 insertions(+), 4 deletions(-)
[GitHub] [cloudstack] blueorangutan commented on pull request #4047: Look for active templates for VR deployment
blueorangutan commented on pull request #4047: URL: https://github.com/apache/cloudstack/pull/4047#issuecomment-654651062 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4047: Look for active templates for VR deployment
rhtyd commented on pull request #4047: URL: https://github.com/apache/cloudstack/pull/4047#issuecomment-654650530 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4000: vm: Reset deviceId to fix missing nic with vm
rhtyd commented on pull request #4000: URL: https://github.com/apache/cloudstack/pull/4000#issuecomment-654650349 @ustcweizhou can you review the failures? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack] rhtyd merged pull request #3979: Limit API from trying to start a VM that is already running
rhtyd merged pull request #3979: URL: https://github.com/apache/cloudstack/pull/3979 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
