[GitHub] [cloudstack] Spaceman1984 closed pull request #4016: Fixed private gateway can't be deleted

2020-08-05 Thread GitBox


Spaceman1984 closed pull request #4016:
URL: https://github.com/apache/cloudstack/pull/4016


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] blueorangutan commented on pull request #4180: Added nfs minor version support

2020-08-05 Thread GitBox


blueorangutan commented on pull request #4180:
URL: https://github.com/apache/cloudstack/pull/4180#issuecomment-669023145


   @Spaceman1984 a Jenkins job has been kicked to build packages. I'll keep you 
posted as I make progress.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] blueorangutan commented on pull request #4207: Human readable sizes in logs

2020-08-05 Thread GitBox


blueorangutan commented on pull request #4207:
URL: https://github.com/apache/cloudstack/pull/4207#issuecomment-669037839


   @Spaceman1984 a Jenkins job has been kicked to build packages. I'll keep you 
posted as I make progress.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] Spaceman1984 commented on pull request #4207: Human readable sizes in logs

2020-08-05 Thread GitBox


Spaceman1984 commented on pull request #4207:
URL: https://github.com/apache/cloudstack/pull/4207#issuecomment-669037328


   @blueorangutan package



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[cloudstack] branch 4.14 updated: vm: Reset deviceId to fix missing nic with vm (#4000)

2020-08-05 Thread rohit
This is an automated email from the ASF dual-hosted git repository.

rohit pushed a commit to branch 4.14
in repository https://gitbox.apache.org/repos/asf/cloudstack.git


The following commit(s) were added to refs/heads/4.14 by this push:
 new 4527424  vm: Reset deviceId to fix missing nic with vm (#4000)
4527424 is described below

commit 4527424fce0510cbeab6412faa23ee21838b07f1
Author: Wei Zhou 
AuthorDate: Wed Aug 5 10:19:03 2020 +0200

vm: Reset deviceId to fix missing nic with vm (#4000)

Co-authored-by: Wei Zhou <57355700+weizhouapa...@users.noreply.github.com>
---
 .../com/cloud/vm/VirtualMachineManagerImpl.java | 21 +
 1 file changed, 21 insertions(+)

diff --git 
a/engine/orchestration/src/main/java/com/cloud/vm/VirtualMachineManagerImpl.java
 
b/engine/orchestration/src/main/java/com/cloud/vm/VirtualMachineManagerImpl.java
index 8d7e4a5..f312752 100755
--- 
a/engine/orchestration/src/main/java/com/cloud/vm/VirtualMachineManagerImpl.java
+++ 
b/engine/orchestration/src/main/java/com/cloud/vm/VirtualMachineManagerImpl.java
@@ -1124,6 +1124,7 @@ public class VirtualMachineManagerImpl extends 
ManagerBase implements VirtualMac
 }
 
 try {
+resetVmNicsDeviceId(vm.getId());
 _networkMgr.prepare(vmProfile, new 
DeployDestination(dest.getDataCenter(), dest.getPod(), null, null, 
dest.getStorageForDisks()), ctx);
 if (vm.getHypervisorType() != HypervisorType.BareMetal) {
 volumeMgr.prepare(vmProfile, dest);
@@ -1317,6 +1318,26 @@ public class VirtualMachineManagerImpl extends 
ManagerBase implements VirtualMac
 }
 }
 
+private void resetVmNicsDeviceId(Long vmId) {
+final List nics = _nicsDao.listByVmId(vmId);
+Collections.sort(nics, new Comparator() {
+@Override
+public int compare(NicVO nic1, NicVO nic2) {
+Long nicDevId1 = Long.valueOf(nic1.getDeviceId());
+Long nicDevId2 = Long.valueOf(nic2.getDeviceId());
+return nicDevId1.compareTo(nicDevId2);
+}
+});
+int deviceId = 0;
+for (final NicVO nic : nics) {
+if (nic.getDeviceId() != deviceId) {
+nic.setDeviceId(deviceId);
+_nicsDao.update(nic.getId(),nic);
+}
+deviceId ++;
+}
+}
+
 // Add extra config data to the vmTO as a Map
 private void addExtraConfig(VirtualMachineTO vmTO) {
 Map details = vmTO.getDetails();



[GitHub] [cloudstack] rhtyd commented on pull request #4243: Update SystemVM debian iso from 10.4.0 to 10.5.0

2020-08-05 Thread GitBox


rhtyd commented on pull request #4243:
URL: https://github.com/apache/cloudstack/pull/4243#issuecomment-669052453


   Needs separate systemvm build if necessary
   cc @DaanHoogland 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] blueorangutan commented on pull request #4207: Human readable sizes in logs

2020-08-05 Thread GitBox


blueorangutan commented on pull request #4207:
URL: https://github.com/apache/cloudstack/pull/4207#issuecomment-669052649


   Packaging result: ✔centos7 ✔debian. JID-1653



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] rhtyd merged pull request #4000: vm: Reset deviceId to fix missing nic with vm

2020-08-05 Thread GitBox


rhtyd merged pull request #4000:
URL: https://github.com/apache/cloudstack/pull/4000


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[cloudstack] branch master updated (c3554ec -> 2237486)

2020-08-05 Thread rohit
This is an automated email from the ASF dual-hosted git repository.

rohit pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git.


from c3554ec  kvm: For ceph only if a port number has been specified define 
in the XML (#4231)
 add 2237486  server: Allow renaming cluster, host, and storage (#4165)

No new revisions were added by this update.

Summary of changes:
 .../java/com/cloud/resource/ResourceService.java   |  3 ++-
 .../command/admin/cluster/UpdateClusterCmd.java|  6 -
 .../api/command/admin/host/UpdateHostCmd.java  |  7 +
 .../admin/storage/UpdateStoragePoolCmd.java|  7 +
 .../com/cloud/resource/ResourceManagerImpl.java| 30 +++---
 .../resource/RollingMaintenanceManagerImpl.java|  8 --
 .../java/com/cloud/storage/StorageManagerImpl.java |  8 ++
 .../cloud/resource/MockResourceManagerImpl.java|  3 ++-
 ui/scripts/system.js   | 11 ++--
 9 files changed, 72 insertions(+), 11 deletions(-)



[GitHub] [cloudstack] rhtyd merged pull request #4165: Allow renaming cluster, host, and storage

2020-08-05 Thread GitBox


rhtyd merged pull request #4165:
URL: https://github.com/apache/cloudstack/pull/4165


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] blueorangutan commented on pull request #4150: [HEALTH][4.14] Health Check Run

2020-08-05 Thread GitBox


blueorangutan commented on pull request #4150:
URL: https://github.com/apache/cloudstack/pull/4150#issuecomment-669084072


   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] blueorangutan commented on pull request #4180: Added nfs minor version support

2020-08-05 Thread GitBox


blueorangutan commented on pull request #4180:
URL: https://github.com/apache/cloudstack/pull/4180#issuecomment-669033270


   Packaging result: ✔centos7 ✔debian. JID-1652



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[cloudstack] branch master updated (9ae1170 -> c3554ec)

2020-08-05 Thread rohit
This is an automated email from the ASF dual-hosted git repository.

rohit pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git.


from 9ae1170  Merge remote-tracking branch 'origin/4.14'
 add c3554ec  kvm: For ceph only if a port number has been specified define 
in the XML (#4231)

No new revisions were added by this update.

Summary of changes:
 .../kvm/resource/LibvirtStoragePoolDef.java|  7 ++-
 .../hypervisor/kvm/storage/KVMPhysicalDisk.java|  2 +-
 .../kvm/resource/LibvirtStoragePoolDefTest.java| 23 +-
 .../CloudStackPrimaryDataStoreLifeCycleImpl.java   |  2 +-
 4 files changed, 30 insertions(+), 4 deletions(-)



[GitHub] [cloudstack] rhtyd merged pull request #4231: kvm/ceph: Only if a port number has been specified define in the XML

2020-08-05 Thread GitBox


rhtyd merged pull request #4231:
URL: https://github.com/apache/cloudstack/pull/4231


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] rhtyd commented on a change in pull request #4034: Make DB upgrade queries idempotent for convenience

2020-08-05 Thread GitBox


rhtyd commented on a change in pull request #4034:
URL: https://github.com/apache/cloudstack/pull/4034#discussion_r465559421



##
File path: engine/schema/src/main/resources/META-INF/db/schema-41310to41400.sql
##
@@ -49,9 +49,9 @@ CREATE TABLE IF NOT EXISTS `cloud`.`backup_offering` (
   CONSTRAINT `fk_backup_offering__zone_id` FOREIGN KEY (`zone_id`) REFERENCES 
`data_center` (`id`) ON DELETE CASCADE
 ) ENGINE=InnoDB DEFAULT CHARSET=utf8;
 
-ALTER TABLE `cloud`.`vm_instance` ADD COLUMN `backup_offering_id` bigint 
unsigned DEFAULT NULL COMMENT 'ID of backup offering';
-ALTER TABLE `cloud`.`vm_instance` ADD COLUMN `backup_external_id` varchar(255) 
DEFAULT NULL COMMENT 'ID of external backup job or container if any';
-ALTER TABLE `cloud`.`vm_instance` ADD COLUMN `backup_volumes` text DEFAULT 
NULL COMMENT 'details of backedup volumes';
+CALL `cloud`.`IDEMPOTENT_ADD_COLUMN`('cloud.vm_instance','backup_offering_id', 
'bigint unsigned DEFAULT NULL COMMENT \'ID of backup offering\'');
+CALL `cloud`.`IDEMPOTENT_ADD_COLUMN`('cloud.vm_instance','backup_external_id', 
'varchar(255) DEFAULT NULL COMMENT \'ID of external backup job or container if 
any\'');
+CALL `cloud`.`IDEMPOTENT_ADD_COLUMN`('cloud.vm_instance','backup_volumes', 
'text DEFAULT NULL COMMENT \'details of backedup volumes\'');

Review comment:
   Procedure `IDEMPOTENT_ADD_COLUMN` may not be declared in this sql file.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] rhtyd commented on pull request #4141: [New feature] Load balancer customization (haproxy-based)

2020-08-05 Thread GitBox


rhtyd commented on pull request #4141:
URL: https://github.com/apache/cloudstack/pull/4141#issuecomment-669057374


   @weizhouapache will this require a new systemvmtemplate?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] andrijapanicsb commented on issue #4024: qemu 2.10+: consider adding --force-share flag

2020-08-05 Thread GitBox


andrijapanicsb commented on issue #4024:
URL: https://github.com/apache/cloudstack/issues/4024#issuecomment-669073369


   As we are not testing 2.10+ qemu (qemu-kvm-ev), we haven't seen any failures 
- but in general it could affect host-HA and similar actions (I wrote there 
"NFS v4 not affected" - so I guess not many people would be using NEW qemu with 
and OLD NFS...



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] ravening commented on pull request #4230: Enable resetting config values to default value

2020-08-05 Thread GitBox


ravening commented on pull request #4230:
URL: https://github.com/apache/cloudstack/pull/4230#issuecomment-669072481


   @rhtyd dont merge this as this depends on #4215 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] Spaceman1984 commented on pull request #4016: Fixed private gateway can't be deleted

2020-08-05 Thread GitBox


Spaceman1984 commented on pull request #4016:
URL: https://github.com/apache/cloudstack/pull/4016#issuecomment-669042479


   @blueorangutan test



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] Spaceman1984 commented on pull request #4180: Added nfs minor version support

2020-08-05 Thread GitBox


Spaceman1984 commented on pull request #4180:
URL: https://github.com/apache/cloudstack/pull/4180#issuecomment-669042279


   @blueorangutan test



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] rhtyd commented on pull request #4019: server: Move restoreVM to vm work job queue

2020-08-05 Thread GitBox


rhtyd commented on pull request #4019:
URL: https://github.com/apache/cloudstack/pull/4019#issuecomment-669054153


   @DaanHoogland is this good to merge?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] ustcweizhou opened a new pull request #4020: server: move UpdateDefaultNic to vm work job queue

2020-08-05 Thread GitBox


ustcweizhou opened a new pull request #4020:
URL: https://github.com/apache/cloudstack/pull/4020


   ## Description
   
   
   While remove secondary nic from a Running vm, if update the default nic to 
the secondary nic before the nic is removed, the vm will not have default nic 
(and cannot be started) when both operations are completed.
   
   It is because UpdateDefaultNic api is not handled as a vm work job 
(AddNicToVMCmd and RemoveNicFromVMCmd are), it is processed before nic is 
removed. The result is that secondary nic becomes default nic and got removed.
   
   
   
   
   
   
   
   
   ## Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [X] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ## Screenshots (if appropriate):
   
   ## How Has This Been Tested?
   
   
   
   
   1. remove secondary nic from a Running vm
   2. update default nic to the secondary nic before step 1 is finished.
   3. got an exception  as below.
   
   
![image](https://user-images.githubusercontent.com/3204966/78604196-b5753000-7859-11ea-9758-644fffc20a9b.png)
   
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] rhtyd commented on pull request #4020: server: move UpdateDefaultNic to vm work job queue

2020-08-05 Thread GitBox


rhtyd commented on pull request #4020:
URL: https://github.com/apache/cloudstack/pull/4020#issuecomment-669054544


   @blueorangutan test



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] rhtyd closed pull request #4020: server: move UpdateDefaultNic to vm work job queue

2020-08-05 Thread GitBox


rhtyd closed pull request #4020:
URL: https://github.com/apache/cloudstack/pull/4020


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] Spaceman1984 commented on pull request #4016: Fixed private gateway can't be deleted

2020-08-05 Thread GitBox


Spaceman1984 commented on pull request #4016:
URL: https://github.com/apache/cloudstack/pull/4016#issuecomment-669054415


   @rhtyd I have tested creating and deleting a private gateway, the nic, ip 
and route is created and removed. 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] blueorangutan commented on pull request #4213: Search vm snapshots using tags

2020-08-05 Thread GitBox


blueorangutan commented on pull request #4213:
URL: https://github.com/apache/cloudstack/pull/4213#issuecomment-669061624


   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] ravening commented on pull request #4220: Fix cpuallocated value in findHostsForMIgration api

2020-08-05 Thread GitBox


ravening commented on pull request #4220:
URL: https://github.com/apache/cloudstack/pull/4220#issuecomment-669061434


   > @ravening sorry I missed your comment, and merged based on 
@GabrielBrascher 's `I am good with the code as it is`. Do you need to do more 
work on this PR, should we revert? cc @DaanHoogland 
   
   Since it's ok for them that two functions returns different value, it's fine 
with me as well



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] blueorangutan commented on pull request #4190: Broadcast URI not set to vxlan, but vlan (Fix #3040)

2020-08-05 Thread GitBox


blueorangutan commented on pull request #4190:
URL: https://github.com/apache/cloudstack/pull/4190#issuecomment-669077357


   Packaging result: ✖centos7 ✔debian. JID-1657



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] blueorangutan commented on pull request #4213: Search vm snapshots using tags

2020-08-05 Thread GitBox


blueorangutan commented on pull request #4213:
URL: https://github.com/apache/cloudstack/pull/4213#issuecomment-669077326


   Packaging result: ✖centos7 ✔debian. JID-1656



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] rhtyd commented on pull request #4150: [HEALTH][4.14] Health Check Run

2020-08-05 Thread GitBox


rhtyd commented on pull request #4150:
URL: https://github.com/apache/cloudstack/pull/4150#issuecomment-669083479


   @blueorangutan package



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] Spaceman1984 closed pull request #4180: Added nfs minor version support

2020-08-05 Thread GitBox


Spaceman1984 closed pull request #4180:
URL: https://github.com/apache/cloudstack/pull/4180


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] Spaceman1984 commented on pull request #4180: Added nfs minor version support

2020-08-05 Thread GitBox


Spaceman1984 commented on pull request #4180:
URL: https://github.com/apache/cloudstack/pull/4180#issuecomment-669022660


   @blueorangutan package



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] Spaceman1984 commented on issue #4242: Unable to login with latest master 2020/08/04

2020-08-05 Thread GitBox


Spaceman1984 commented on issue #4242:
URL: https://github.com/apache/cloudstack/issues/4242#issuecomment-669026146


   
![Cookies](https://user-images.githubusercontent.com/49917670/89383278-82a25200-d6fc-11ea-9e1d-c263c0ce36d8.png)
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] Spaceman1984 commented on issue #4242: Unable to login with latest master 2020/08/04

2020-08-05 Thread GitBox


Spaceman1984 commented on issue #4242:
URL: https://github.com/apache/cloudstack/issues/4242#issuecomment-669026431


   @Pearl1594 seems like these cookies will expire tomorrow



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] Spaceman1984 edited a comment on issue #4242: Unable to login with latest master 2020/08/04

2020-08-05 Thread GitBox


Spaceman1984 edited a comment on issue #4242:
URL: https://github.com/apache/cloudstack/issues/4242#issuecomment-669026146


   
![Cookies](https://user-images.githubusercontent.com/49917670/89383278-82a25200-d6fc-11ea-9e1d-c263c0ce36d8.png)
   This is from the browser session where I could log in before switching to 
master



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] wido commented on pull request #4231: kvm/ceph: Only if a port number has been specified define in the XML

2020-08-05 Thread GitBox


wido commented on pull request #4231:
URL: https://github.com/apache/cloudstack/pull/4231#issuecomment-669030033


   For me it is



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] Spaceman1984 commented on issue #4242: Unable to login with latest master 2020/08/04

2020-08-05 Thread GitBox


Spaceman1984 commented on issue #4242:
URL: https://github.com/apache/cloudstack/issues/4242#issuecomment-669029960


   
   
![Cookies-Guest](https://user-images.githubusercontent.com/49917670/89383838-7e2a6900-d6fd-11ea-8f88-67c32902990e.png)

   The cookies from the guest session doesn't include a sessionkey for /client, 
maybe the different path on the new version is causing the issue.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] rhtyd commented on pull request #4235: [VMware] Full OVF properties support

2020-08-05 Thread GitBox


rhtyd commented on pull request #4235:
URL: https://github.com/apache/cloudstack/pull/4235#issuecomment-669058977


   @nvazquez @shwstppr unit tests are failing, please review travis or local 
build and fix. I see:
   ```
   ...
   [ERROR] 
testCheckAffinityNullPreferredHosts(com.cloud.vm.DeploymentPlanningManagerImplTest)
  Time elapsed: 0.005 s  <<< ERROR!
   org.springframework.beans.factory.UnsatisfiedDependencyException: Error 
creating bean with name 'deploymentPlanningManagerImpl': Unsatisfied dependency 
expressed through field 'templateDao'; nested exception is 
org.springframework.beans.factory.NoSuchBeanDefinitionException: No qualifying 
bean of type 'com.cloud.storage.dao.VMTemplateDao' available: expected at least 
1 bean which qualifies as autowire candidate. Dependency annotations: 
{@javax.inject.Inject()}
at 
com.cloud.vm.DeploymentPlanningManagerImplTest.testSetUp(DeploymentPlanningManagerImplTest.java:158)
   Caused by: org.springframework.beans.factory.NoSuchBeanDefinitionException: 
No qualifying bean of type 'com.cloud.storage.dao.VMTemplateDao' available: 
expected at least 1 bean which qualifies as autowire candidate. Dependency 
annotations: {@javax.inject.Inject()}
at 
com.cloud.vm.DeploymentPlanningManagerImplTest.testSetUp(DeploymentPlanningManagerImplTest.java:158)
   [ERROR] Errors: 
   [ERROR]   DeploymentPlanningManagerImplTest.testSetUp:158 » 
UnsatisfiedDependency Error ...
   [ERROR]   DeploymentPlanningManagerImplTest.testSetUp:158 » 
UnsatisfiedDependency Error ...
   [ERROR]   DeploymentPlanningManagerImplTest.testSetUp:158 » 
UnsatisfiedDependency Error ...
   [ERROR]   DeploymentPlanningManagerImplTest.testSetUp:158 » 
UnsatisfiedDependency Error ...
   [ERROR]   DeploymentPlanningManagerImplTest.testSetUp:158 » 
UnsatisfiedDependency Error ...
   [ERROR]   DeploymentPlanningManagerImplTest.testSetUp:158 » 
UnsatisfiedDependency Error ...
   [ERROR]   DeploymentPlanningManagerImplTest.testSetUp:158 » 
UnsatisfiedDependency Error ...
   [ERROR] Tests run: 846, Failures: 0, Errors: 7, Skipped: 5
   ...
   ```



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] blueorangutan commented on pull request #4230: Enable resetting config values to default value

2020-08-05 Thread GitBox


blueorangutan commented on pull request #4230:
URL: https://github.com/apache/cloudstack/pull/4230#issuecomment-669059135


   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] rhtyd commented on pull request #4230: Enable resetting config values to default value

2020-08-05 Thread GitBox


rhtyd commented on pull request #4230:
URL: https://github.com/apache/cloudstack/pull/4230#issuecomment-669058577


   @blueorangutan package



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] rhtyd merged pull request #4225: vmware: volume utilisation is always zero

2020-08-05 Thread GitBox


rhtyd merged pull request #4225:
URL: https://github.com/apache/cloudstack/pull/4225


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] blueorangutan commented on pull request #4235: [VMware] Full OVF properties support

2020-08-05 Thread GitBox


blueorangutan commented on pull request #4235:
URL: https://github.com/apache/cloudstack/pull/4235#issuecomment-669058662


   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] rhtyd commented on pull request #4235: [VMware] Full OVF properties support

2020-08-05 Thread GitBox


rhtyd commented on pull request #4235:
URL: https://github.com/apache/cloudstack/pull/4235#issuecomment-669058448


   @blueorangutan package
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] rhtyd commented on issue #4024: qemu 2.10+: consider adding --force-share flag

2020-08-05 Thread GitBox


rhtyd commented on issue #4024:
URL: https://github.com/apache/cloudstack/issues/4024#issuecomment-669065017


   @andrijapanicsb does this cause a blocker for CentOS7/8 etc? cc 
@DaanHoogland 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] rhtyd commented on issue #3934: Zones are returned in a random order

2020-08-05 Thread GitBox


rhtyd commented on issue #3934:
URL: https://github.com/apache/cloudstack/issues/3934#issuecomment-669064811


   @dpassante I tested 4.14/master I'm not able to see this. In UI as root 
admin you can re-order the zones and the order is honoured.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] rhtyd commented on issue #4242: Unable to login with latest master 2020/08/04

2020-08-05 Thread GitBox


rhtyd commented on issue #4242:
URL: https://github.com/apache/cloudstack/issues/4242#issuecomment-669064459


   @Spaceman1984 on latest branch/master what you're working on if you clear 
application cache (see clear storage on the Application tab) - are you able to 
log in? Are you using old UI or Primate for testing UI?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] GabrielBrascher commented on pull request #4190: Broadcast URI not set to vxlan, but vlan (Fix #3040)

2020-08-05 Thread GitBox


GabrielBrascher commented on pull request #4190:
URL: https://github.com/apache/cloudstack/pull/4190#issuecomment-669081062


   @rhtyd I will take a look at 4.14 and 4.15 then. If it has already been 
fixed I will close this one. Thanks!



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] blueorangutan commented on pull request #4016: Fixed private gateway can't be deleted

2020-08-05 Thread GitBox


blueorangutan commented on pull request #4016:
URL: https://github.com/apache/cloudstack/pull/4016#issuecomment-669029286


   Packaging result: ✔centos7 ✔debian. JID-1651



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] blueorangutan commented on pull request #4180: Added nfs minor version support

2020-08-05 Thread GitBox


blueorangutan commented on pull request #4180:
URL: https://github.com/apache/cloudstack/pull/4180#issuecomment-669043015


   @Spaceman1984 a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has 
been kicked to run smoke tests



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] blueorangutan commented on pull request #4016: Fixed private gateway can't be deleted

2020-08-05 Thread GitBox


blueorangutan commented on pull request #4016:
URL: https://github.com/apache/cloudstack/pull/4016#issuecomment-669042890


   @Spaceman1984 a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has 
been kicked to run smoke tests



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] blueorangutan commented on pull request #4020: server: move UpdateDefaultNic to vm work job queue

2020-08-05 Thread GitBox


blueorangutan commented on pull request #4020:
URL: https://github.com/apache/cloudstack/pull/4020#issuecomment-669055258


   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been 
kicked to run smoke tests



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] rhtyd commented on a change in pull request #4034: Make DB upgrade queries idempotent for convenience

2020-08-05 Thread GitBox


rhtyd commented on a change in pull request #4034:
URL: https://github.com/apache/cloudstack/pull/4034#discussion_r465557833



##
File path: 
engine/schema/src/main/resources/META-INF/db/schema-41310to41400-cleanup.sql
##
@@ -25,4 +25,4 @@ DELETE FROM `cloud`.`configuration` WHERE name = 
'host.maintenance.retries';
 UPDATE `cloud`.`storage_pool` SET path="/var/lib/libvirt/images" WHERE 
path="/var/lib/libvirt/images/";
 
 -- remove (one of) duplicate unique indexes from Region table
-ALTER TABLE `region` DROP INDEX `id_3`;
+ALTER TABLE `region` DROP INDEX IF EXISTS `id_3`;

Review comment:
   I ran this, it worked:
   ```
   > ALTER TABLE `region` DROP INDEX IF EXISTS `id_3`;
   Query OK, 0 rows affected, 1 warning (0.002 sec)
   Records: 0  Duplicates: 0  Warnings: 1
   
   ```





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[cloudstack] branch 4.14 updated: server: Fix cpuallocated value in findHostsForMIgration api (#4220)

2020-08-05 Thread rohit
This is an automated email from the ASF dual-hosted git repository.

rohit pushed a commit to branch 4.14
in repository https://gitbox.apache.org/repos/asf/cloudstack.git


The following commit(s) were added to refs/heads/4.14 by this push:
 new a529470  server: Fix cpuallocated value in findHostsForMIgration api 
(#4220)
a529470 is described below

commit a529470b16642b77a39a42da6bbc827a3bf08951
Author: Rakesh 
AuthorDate: Wed Aug 5 10:32:09 2020 +0200

server: Fix cpuallocated value in findHostsForMIgration api (#4220)

The findHostsForMigration api displays 0% always for
cpuallocated field which is wrong.

Fixes #4221
---
 .../com/cloud/api/query/dao/HostJoinDaoImpl.java| 21 -
 1 file changed, 12 insertions(+), 9 deletions(-)

diff --git a/server/src/main/java/com/cloud/api/query/dao/HostJoinDaoImpl.java 
b/server/src/main/java/com/cloud/api/query/dao/HostJoinDaoImpl.java
index 6f16462..597cc1c 100644
--- a/server/src/main/java/com/cloud/api/query/dao/HostJoinDaoImpl.java
+++ b/server/src/main/java/com/cloud/api/query/dao/HostJoinDaoImpl.java
@@ -190,10 +190,9 @@ public class HostJoinDaoImpl extends 
GenericDaoBase implements
 
 hostResponse.setHypervisorVersion(host.getHypervisorVersion());
 
-Float cpuWithOverprovisioning = host.getCpus() * 
host.getSpeed() * ApiDBUtils.getCpuOverprovisioningFactor(host.getClusterId());
-String cpuAlloc = decimalFormat.format(((float)cpu / 
cpuWithOverprovisioning * 100f)) + "%";
-hostResponse.setCpuAllocated(cpuAlloc);
-
hostResponse.setCpuWithOverprovisioning(cpuWithOverprovisioning.toString());
+float cpuWithOverprovisioning = host.getCpus() * 
host.getSpeed() * ApiDBUtils.getCpuOverprovisioningFactor(host.getClusterId());
+
hostResponse.setCpuAllocated(calculateResourceAllocatedPercentage(cpu, 
cpuWithOverprovisioning));
+
hostResponse.setCpuWithOverprovisioning(Float.toString(cpuWithOverprovisioning));
 }
 
 if (details.contains(HostDetails.all) || 
details.contains(HostDetails.stats)) {
@@ -317,7 +316,7 @@ public class HostJoinDaoImpl extends 
GenericDaoBase implements
 if (details.contains(HostDetails.all) || 
details.contains(HostDetails.capacity)) {
 // set allocated capacities
 Long mem = host.getMemReservedCapacity() + 
host.getMemUsedCapacity();
-Long cpu = host.getCpuReservedCapacity() + 
host.getCpuReservedCapacity();
+Long cpu = host.getCpuReservedCapacity() + 
host.getCpuUsedCapacity();
 
 hostResponse.setMemoryTotal(host.getTotalMemory());
 Float memWithOverprovisioning = host.getTotalMemory() * 
ApiDBUtils.getMemOverprovisioningFactor(host.getClusterId());
@@ -340,10 +339,9 @@ public class HostJoinDaoImpl extends 
GenericDaoBase implements
 
 hostResponse.setHypervisorVersion(host.getHypervisorVersion());
 
-Float cpuWithOverprovisioning = new Float(host.getCpus() * 
host.getSpeed() * ApiDBUtils.getCpuOverprovisioningFactor(host.getClusterId()));
-String cpuAlloc = decimalFormat.format(((float)cpu / 
cpuWithOverprovisioning * 100f)).toString() + "%";
-hostResponse.setCpuAllocated(cpuAlloc);
-
hostResponse.setCpuWithOverprovisioning(cpuWithOverprovisioning.toString());
+float cpuWithOverprovisioning = host.getCpus() * 
host.getSpeed() * ApiDBUtils.getCpuOverprovisioningFactor(host.getClusterId());
+
hostResponse.setCpuAllocated(calculateResourceAllocatedPercentage(cpu, 
cpuWithOverprovisioning));
+
hostResponse.setCpuWithOverprovisioning(Float.toString(cpuWithOverprovisioning));
 }
 
 if (details.contains(HostDetails.all) || 
details.contains(HostDetails.stats)) {
@@ -471,4 +469,9 @@ public class HostJoinDaoImpl extends 
GenericDaoBase implements
 return listBy(sc);
 }
 
+private String calculateResourceAllocatedPercentage(float resource, float 
resourceWithOverProvision) {
+DecimalFormat decimalFormat = new DecimalFormat("#.##");
+return decimalFormat.format(((float)resource / 
resourceWithOverProvision * 100.0f)) + "%";
+}
+
 }



[GitHub] [cloudstack] rhtyd commented on pull request #4220: Fix cpuallocated value in findHostsForMIgration api

2020-08-05 Thread GitBox


rhtyd commented on pull request #4220:
URL: https://github.com/apache/cloudstack/pull/4220#issuecomment-669060689


   @ravening sorry I missed your comment, and merged based on @GabrielBrascher 
's `I am good with the code as it is`. Do you need to do more work on this PR, 
should we revert? cc @DaanHoogland 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] rhtyd commented on pull request #4228: Dont add host back after agent service restart

2020-08-05 Thread GitBox


rhtyd commented on pull request #4228:
URL: https://github.com/apache/cloudstack/pull/4228#issuecomment-669059632


   @ravening I think resetting the host, zone, cluster, etc to default (or 
remove) should be enough. Post agent restart the agent will not know where to 
connect.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] rhtyd merged pull request #4220: Fix cpuallocated value in findHostsForMIgration api

2020-08-05 Thread GitBox


rhtyd merged pull request #4220:
URL: https://github.com/apache/cloudstack/pull/4220


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[cloudstack] branch 4.14 updated: vmware: volume utilisation is always zero (#4225)

2020-08-05 Thread rohit
This is an automated email from the ASF dual-hosted git repository.

rohit pushed a commit to branch 4.14
in repository https://gitbox.apache.org/repos/asf/cloudstack.git


The following commit(s) were added to refs/heads/4.14 by this push:
 new 2fce8b7  vmware: volume utilisation is always zero (#4225)
2fce8b7 is described below

commit 2fce8b733e19f37af990a6d21450c1a43a4c5bbd
Author: Rohit Yadav 
AuthorDate: Wed Aug 5 14:01:16 2020 +0530

vmware: volume utilisation is always zero (#4225)

This fixes issues of virtual size to be twice in case the disk is a
linked-clone root disk. The virtual size of root disk (first in chain)
must be used.

Signed-off-by: Rohit Yadav 
---
 .../main/java/com/cloud/hypervisor/vmware/resource/VmwareResource.java  | 1 -
 server/src/main/java/com/cloud/api/query/ViewResponseHelper.java| 2 +-
 .../src/main/java/com/cloud/hypervisor/vmware/mo/DatastoreMO.java   | 1 +
 3 files changed, 2 insertions(+), 2 deletions(-)

diff --git 
a/plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/resource/VmwareResource.java
 
b/plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/resource/VmwareResource.java
index fab6f0a..341e18c 100644
--- 
a/plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/resource/VmwareResource.java
+++ 
b/plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/resource/VmwareResource.java
@@ -3766,7 +3766,6 @@ public class VmwareResource implements 
StoragePoolResource, ServerResource, Vmwa
 VolumeStatsEntry vse = 
statEntry.get(chainInfo);
 if (vse != null) {
 
vse.setPhysicalSize(vse.getPhysicalSize() + physicalsize);
-
vse.setVirtualSize(vse.getVirtualSize() + virtualsize);
 }
 } else {
 VolumeStatsEntry vse = new 
VolumeStatsEntry(chainInfo, physicalsize, virtualsize);
diff --git a/server/src/main/java/com/cloud/api/query/ViewResponseHelper.java 
b/server/src/main/java/com/cloud/api/query/ViewResponseHelper.java
index ced81a6..4baf25c 100644
--- a/server/src/main/java/com/cloud/api/query/ViewResponseHelper.java
+++ b/server/src/main/java/com/cloud/api/query/ViewResponseHelper.java
@@ -268,7 +268,7 @@ public class ViewResponseHelper {
 
 public static List createVolumeResponse(ResponseView view, 
VolumeJoinVO... volumes) {
 Hashtable vrDataList = new Hashtable();
-DecimalFormat df = new DecimalFormat("0.00");
+DecimalFormat df = new DecimalFormat("0.0%");
 for (VolumeJoinVO vr : volumes) {
 VolumeResponse vrData = vrDataList.get(vr.getId());
 if (vrData == null) {
diff --git 
a/vmware-base/src/main/java/com/cloud/hypervisor/vmware/mo/DatastoreMO.java 
b/vmware-base/src/main/java/com/cloud/hypervisor/vmware/mo/DatastoreMO.java
index fa0c380..fd9a374 100644
--- a/vmware-base/src/main/java/com/cloud/hypervisor/vmware/mo/DatastoreMO.java
+++ b/vmware-base/src/main/java/com/cloud/hypervisor/vmware/mo/DatastoreMO.java
@@ -356,6 +356,7 @@ public class DatastoreMO extends BaseMO {
 FileQueryFlags fqf = new FileQueryFlags();
 fqf.setFileSize(true);
 fqf.setFileOwner(true);
+fqf.setFileType(true);
 fqf.setModification(true);
 searchSpec.setDetails(fqf);
 searchSpec.setSearchCaseInsensitive(false);



[GitHub] [cloudstack] GabrielBrascher commented on pull request #3730: Update SystemVM scripts from python2 to python3

2020-08-05 Thread GitBox


GabrielBrascher commented on pull request #3730:
URL: https://github.com/apache/cloudstack/pull/3730#issuecomment-669072243


   Travis is failing due to `pycodestyle` failures: 
https://travis-ci.org/github/apache/cloudstack/jobs/715011759
   I will address these "checkstyle" issues soon and update the PR.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] rhtyd commented on pull request #4220: Fix cpuallocated value in findHostsForMIgration api

2020-08-05 Thread GitBox


rhtyd commented on pull request #4220:
URL: https://github.com/apache/cloudstack/pull/4220#issuecomment-669082226


   Alright I'll not revert it, thnx for replying.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] Spaceman1984 commented on issue #4242: Unable to login with latest master 2020/08/04

2020-08-05 Thread GitBox


Spaceman1984 commented on issue #4242:
URL: https://github.com/apache/cloudstack/issues/4242#issuecomment-669015225


   Hi @Pearl1594 , seems like this is an issue that occurs when running an 
older version before going to latest master, I was able to log in using a guest 
session on chrome. Where do I find the sessionkey and path?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] Pearl1594 commented on issue #4242: Unable to login with latest master 2020/08/04

2020-08-05 Thread GitBox


Pearl1594 commented on issue #4242:
URL: https://github.com/apache/cloudstack/issues/4242#issuecomment-669018568


   @Spaceman1984 In your browser's dev tools, goto storage -> cookies. There 
you'd see the sessionkey; clicking on it, will fetch you details of the 
respective cookie.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] blueorangutan commented on pull request #4016: Fixed private gateway can't be deleted

2020-08-05 Thread GitBox


blueorangutan commented on pull request #4016:
URL: https://github.com/apache/cloudstack/pull/4016#issuecomment-669018672


   @Spaceman1984 a Jenkins job has been kicked to build packages. I'll keep you 
posted as I make progress.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #4144: Fix Usage failed to get pid

2020-08-05 Thread GitBox


DaanHoogland commented on a change in pull request #4144:
URL: https://github.com/apache/cloudstack/pull/4144#discussion_r465524355



##
File path: usage/src/main/java/com/cloud/usage/UsageManagerImpl.java
##
@@ -275,7 +277,16 @@ public boolean configure(String name, Map 
params) throws Configu
 s_logger.error("Unhandled exception configuring UsageManger", e);
 throw new ConfigurationException("Unhandled exception configuring 
UsageManager " + e.toString());
 }
-_pid = Integer.parseInt(System.getProperty("pid"));
+
+String processName = null;
+try {
+processName = ManagementFactory.getRuntimeMXBean().getName();
+_pid = Integer.parseInt(processName.split("@")[0]);
+} catch (Exception e) {
+String msg = String.format("Unable to get process Id for %s!", 
processName);
+s_logger.debug(msg , e);
+throw new ConfigurationException(msg + " " + e.toString());

Review comment:
   `logger.debug(msg, e)` should log the entire stacktrace @GabrielBrascher 
. and it gives the user to filter or direct the output to a certain 
stream/file. `e.printStacktrace()` only logs to stdout (or stderr, i forgot). 
in short i think not too much of it. I agree toString does not seem the best, 
but we have alreadyt output the stacktrace by then. A change from `toString()` 
to `getLocalizedMessage()` maybe, @div8cn? Of course we can add the entire 
exception again i.e. `throw new ConfigurationException(msg, e)`, that's fine as 
well.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] blueorangutan removed a comment on pull request #4235: [VMware] Full OVF properties support

2020-08-05 Thread GitBox


blueorangutan removed a comment on pull request #4235:
URL: https://github.com/apache/cloudstack/pull/4235#issuecomment-669035890


   Trillian test result (tid-2264)
   Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 55395 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4235-t2264-vmware-67u3.zip
   Intermittent failure detected: /marvin/tests/smoke/test_accounts.py
   Intermittent failure detected: /marvin/tests/smoke/test_async_job.py
   Intermittent failure detected: 
/marvin/tests/smoke/test_deploy_vgpu_enabled_vm.py
   Intermittent failure detected: 
/marvin/tests/smoke/test_deploy_vms_with_varied_deploymentplanners.py
   Intermittent failure detected: 
/marvin/tests/smoke/test_domain_service_offerings.py
   Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py
   Intermittent failure detected: 
/marvin/tests/smoke/test_kubernetes_clusters.py
   Intermittent failure detected: /marvin/tests/smoke/test_list_ids_parameter.py
   Intermittent failure detected: /marvin/tests/smoke/test_loadbalance.py
   Intermittent failure detected: 
/marvin/tests/smoke/test_nested_virtualization.py
   Intermittent failure detected: /marvin/tests/smoke/test_network_acl.py
   Intermittent failure detected: /marvin/tests/smoke/test_network.py
   Intermittent failure detected: /marvin/tests/smoke/test_nic.py
   Intermittent failure detected: /marvin/tests/smoke/test_password_server.py
   Intermittent failure detected: 
/marvin/tests/smoke/test_portforwardingrules.py
   Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
   Intermittent failure detected: /marvin/tests/smoke/test_projects.py
   Intermittent failure detected: /marvin/tests/smoke/test_reset_vm_on_reboot.py
   Intermittent failure detected: 
/marvin/tests/smoke/test_resource_accounting.py
   Intermittent failure detected: /marvin/tests/smoke/test_router_dhcphosts.py
   Intermittent failure detected: /marvin/tests/smoke/test_router_dns.py
   Intermittent failure detected: /marvin/tests/smoke/test_router_dnsservice.py
   Intermittent failure detected: 
/marvin/tests/smoke/test_routers_iptables_default_policy.py
   Intermittent failure detected: 
/marvin/tests/smoke/test_routers_network_ops.py
   Intermittent failure detected: /marvin/tests/smoke/test_routers.py
   Intermittent failure detected: /marvin/tests/smoke/test_service_offerings.py
   Intermittent failure detected: /marvin/tests/smoke/test_snapshots.py
   Intermittent failure detected: /marvin/tests/smoke/test_ssvm.py
   Intermittent failure detected: /marvin/tests/smoke/test_usage.py
   Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Smoke tests completed. 50 look OK, 29 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_forceDeleteDomain | `Failure` | 100.21 | test_accounts.py
   test_forceDeleteDomain | `Error` | 120.99 | test_accounts.py
   test_01_user_remove_VM_running | `Error` | 57.75 | test_accounts.py
   test_query_async_job_result | `Error` | 89.05 | test_async_job.py
   test_3d_gpu_support | `Error` | 292.06 | test_deploy_vgpu_enabled_vm.py
   test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 | `Error` | 156.82 | 
test_internal_lb.py
   test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 | `Error` | 166.23 | 
test_internal_lb.py
   test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 | `Error` | 265.27 | 
test_internal_lb.py
   test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 | `Error` | 279.81 | 
test_internal_lb.py
   test_03_deploy_vm_domain_service_offering | `Error` | 188.41 | 
test_domain_service_offerings.py
   test_01_deploy_kubernetes_cluster | `Error` | 163.06 | 
test_kubernetes_clusters.py
   test_02_deploy_kubernetes_ha_cluster | `Error` | 138.11 | 
test_kubernetes_clusters.py
   test_04_deploy_and_upgrade_kubernetes_cluster | `Error` | 94.27 | 
test_kubernetes_clusters.py
   test_05_deploy_and_upgrade_kubernetes_ha_cluster | `Error` | 133.36 | 
test_kubernetes_clusters.py
   test_06_deploy_and_invalid_upgrade_kubernetes_cluster | `Error` | 67.40 | 
test_kubernetes_clusters.py
   test_07_deploy_and_scale_kubernetes_cluster | `Error` | 64.24 | 
test_kubernetes_clusters.py
   ContextSuite context=TestKubernetesCluster>:teardown | `Error` | 145.45 | 
test_kubernetes_clusters.py
   ContextSuite context=TestListIdsParams>:setup | `Error` | 0.00 | 
test_list_ids_parameter.py
   test_nested_virtualization_vmware | `Error` | 328.28 | 
test_nested_virtualization.py
   test_network_acl | `Error` | 339.80 | test_network_acl.py
   test_delete_account | `Error` | 343.03 | test_network.py
   test_delete_network_while_vm_on_it | `Error` | 266.31 | test_network.py
   test_delete_network_while_vm_on_it | `Error` | 267.42 | test_network.py
   test_deploy_vm_l2network | `Error` | 

[GitHub] [cloudstack] rhtyd commented on pull request #4232: [HEALTH][4.13] Health Check Run

2020-08-05 Thread GitBox


rhtyd commented on pull request #4232:
URL: https://github.com/apache/cloudstack/pull/4232#issuecomment-669058316


   @Spaceman1984 let's open this again if/when we plan to do a 4.13 minor 
release



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] rhtyd closed pull request #4232: [HEALTH][4.13] Health Check Run

2020-08-05 Thread GitBox


rhtyd closed pull request #4232:
URL: https://github.com/apache/cloudstack/pull/4232


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] rhtyd commented on issue #4169: local iso upload failed

2020-08-05 Thread GitBox


rhtyd commented on issue #4169:
URL: https://github.com/apache/cloudstack/issues/4169#issuecomment-669065857


   @div8cn turns out we cannot check if the URL/server has a valid SSL 
certificate from javascript without using any external tool/service; it's 
therefore advised to use this feature use SSL enabled env. Alternatively, we 
can explore a fix in future that allows uploading on http:// URL for envs where 
SSL is not enabled by default.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] Spaceman1984 commented on pull request #4016: Fixed private gateway can't be deleted

2020-08-05 Thread GitBox


Spaceman1984 commented on pull request #4016:
URL: https://github.com/apache/cloudstack/pull/4016#issuecomment-669018291


   @blueorangutan package



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] blueorangutan commented on pull request #4235: [VMware] Full OVF properties support

2020-08-05 Thread GitBox


blueorangutan commented on pull request #4235:
URL: https://github.com/apache/cloudstack/pull/4235#issuecomment-669035890


   Trillian test result (tid-2264)
   Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 55395 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4235-t2264-vmware-67u3.zip
   Intermittent failure detected: /marvin/tests/smoke/test_accounts.py
   Intermittent failure detected: /marvin/tests/smoke/test_async_job.py
   Intermittent failure detected: 
/marvin/tests/smoke/test_deploy_vgpu_enabled_vm.py
   Intermittent failure detected: 
/marvin/tests/smoke/test_deploy_vms_with_varied_deploymentplanners.py
   Intermittent failure detected: 
/marvin/tests/smoke/test_domain_service_offerings.py
   Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py
   Intermittent failure detected: 
/marvin/tests/smoke/test_kubernetes_clusters.py
   Intermittent failure detected: /marvin/tests/smoke/test_list_ids_parameter.py
   Intermittent failure detected: /marvin/tests/smoke/test_loadbalance.py
   Intermittent failure detected: 
/marvin/tests/smoke/test_nested_virtualization.py
   Intermittent failure detected: /marvin/tests/smoke/test_network_acl.py
   Intermittent failure detected: /marvin/tests/smoke/test_network.py
   Intermittent failure detected: /marvin/tests/smoke/test_nic.py
   Intermittent failure detected: /marvin/tests/smoke/test_password_server.py
   Intermittent failure detected: 
/marvin/tests/smoke/test_portforwardingrules.py
   Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
   Intermittent failure detected: /marvin/tests/smoke/test_projects.py
   Intermittent failure detected: /marvin/tests/smoke/test_reset_vm_on_reboot.py
   Intermittent failure detected: 
/marvin/tests/smoke/test_resource_accounting.py
   Intermittent failure detected: /marvin/tests/smoke/test_router_dhcphosts.py
   Intermittent failure detected: /marvin/tests/smoke/test_router_dns.py
   Intermittent failure detected: /marvin/tests/smoke/test_router_dnsservice.py
   Intermittent failure detected: 
/marvin/tests/smoke/test_routers_iptables_default_policy.py
   Intermittent failure detected: 
/marvin/tests/smoke/test_routers_network_ops.py
   Intermittent failure detected: /marvin/tests/smoke/test_routers.py
   Intermittent failure detected: /marvin/tests/smoke/test_service_offerings.py
   Intermittent failure detected: /marvin/tests/smoke/test_snapshots.py
   Intermittent failure detected: /marvin/tests/smoke/test_ssvm.py
   Intermittent failure detected: /marvin/tests/smoke/test_usage.py
   Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Smoke tests completed. 50 look OK, 29 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_forceDeleteDomain | `Failure` | 100.21 | test_accounts.py
   test_forceDeleteDomain | `Error` | 120.99 | test_accounts.py
   test_01_user_remove_VM_running | `Error` | 57.75 | test_accounts.py
   test_query_async_job_result | `Error` | 89.05 | test_async_job.py
   test_3d_gpu_support | `Error` | 292.06 | test_deploy_vgpu_enabled_vm.py
   test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 | `Error` | 156.82 | 
test_internal_lb.py
   test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 | `Error` | 166.23 | 
test_internal_lb.py
   test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 | `Error` | 265.27 | 
test_internal_lb.py
   test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 | `Error` | 279.81 | 
test_internal_lb.py
   test_03_deploy_vm_domain_service_offering | `Error` | 188.41 | 
test_domain_service_offerings.py
   test_01_deploy_kubernetes_cluster | `Error` | 163.06 | 
test_kubernetes_clusters.py
   test_02_deploy_kubernetes_ha_cluster | `Error` | 138.11 | 
test_kubernetes_clusters.py
   test_04_deploy_and_upgrade_kubernetes_cluster | `Error` | 94.27 | 
test_kubernetes_clusters.py
   test_05_deploy_and_upgrade_kubernetes_ha_cluster | `Error` | 133.36 | 
test_kubernetes_clusters.py
   test_06_deploy_and_invalid_upgrade_kubernetes_cluster | `Error` | 67.40 | 
test_kubernetes_clusters.py
   test_07_deploy_and_scale_kubernetes_cluster | `Error` | 64.24 | 
test_kubernetes_clusters.py
   ContextSuite context=TestKubernetesCluster>:teardown | `Error` | 145.45 | 
test_kubernetes_clusters.py
   ContextSuite context=TestListIdsParams>:setup | `Error` | 0.00 | 
test_list_ids_parameter.py
   test_nested_virtualization_vmware | `Error` | 328.28 | 
test_nested_virtualization.py
   test_network_acl | `Error` | 339.80 | test_network_acl.py
   test_delete_account | `Error` | 343.03 | test_network.py
   test_delete_network_while_vm_on_it | `Error` | 266.31 | test_network.py
   test_delete_network_while_vm_on_it | `Error` | 267.42 | test_network.py
   test_deploy_vm_l2network | `Error` | 258.15 | 

[GitHub] [cloudstack] blueorangutan commented on pull request #4190: Broadcast URI not set to vxlan, but vlan (Fix #3040)

2020-08-05 Thread GitBox


blueorangutan commented on pull request #4190:
URL: https://github.com/apache/cloudstack/pull/4190#issuecomment-669062103


   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] rhtyd commented on pull request #4190: Broadcast URI not set to vxlan, but vlan (Fix #3040)

2020-08-05 Thread GitBox


rhtyd commented on pull request #4190:
URL: https://github.com/apache/cloudstack/pull/4190#issuecomment-669061792


   @GabrielBrascher did you try against 4.14, somehow I remember this was fixed 
recently? Thanks.
   @blueorangutan package



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] rhtyd commented on pull request #4213: Search vm snapshots using tags

2020-08-05 Thread GitBox


rhtyd commented on pull request #4213:
URL: https://github.com/apache/cloudstack/pull/4213#issuecomment-669061023


   @blueorangutan package



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] blueorangutan commented on pull request #4235: [VMware] Full OVF properties support

2020-08-05 Thread GitBox


blueorangutan commented on pull request #4235:
URL: https://github.com/apache/cloudstack/pull/4235#issuecomment-669067226


   Packaging result: ✖centos7 ✖debian. JID-1654



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] rhtyd commented on issue #4204: Test issue: ipmisim/pyghmi does not work with CentOS8 patched ipmitool

2020-08-05 Thread GitBox


rhtyd commented on issue #4204:
URL: https://github.com/apache/cloudstack/issues/4204#issuecomment-669067720


   @shwstppr pl send a doc PR on this to cloudstack-documentation website



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] blueorangutan commented on pull request #4230: Enable resetting config values to default value

2020-08-05 Thread GitBox


blueorangutan commented on pull request #4230:
URL: https://github.com/apache/cloudstack/pull/4230#issuecomment-669067308


   Packaging result: ✖centos7 ✖debian. JID-1655



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] priyankparihar closed pull request #1302: CLOUDSTACK-9104: VM naming convention in case vmware is used

2020-08-05 Thread GitBox


priyankparihar closed pull request #1302:
URL: https://github.com/apache/cloudstack/pull/1302


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] div8cn commented on issue #4234: Static NAT with multiple public interfaces uses wrong outgoing IP

2020-08-05 Thread GitBox


div8cn commented on issue #4234:
URL: https://github.com/apache/cloudstack/issues/4234#issuecomment-669186432


   
   
   We use this PR to solve this problem 
[#4236](https://github.com/apache/cloudstack/pull/4236)
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] Spaceman1984 closed issue #4242: Unable to login with latest master 2020/08/04

2020-08-05 Thread GitBox


Spaceman1984 closed issue #4242:
URL: https://github.com/apache/cloudstack/issues/4242


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] Spaceman1984 commented on issue #4242: Unable to login with latest master 2020/08/04

2020-08-05 Thread GitBox


Spaceman1984 commented on issue #4242:
URL: https://github.com/apache/cloudstack/issues/4242#issuecomment-669204667


   Ok @Pearl1594,  sounds like this is a duplicate issue then, closing.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] GabrielBrascher commented on a change in pull request #4030: some minor changes to make the build run with python 3

2020-08-05 Thread GitBox


GabrielBrascher commented on a change in pull request #4030:
URL: https://github.com/apache/cloudstack/pull/4030#discussion_r465753170



##
File path: tools/apidoc/gen_toc.py
##
@@ -245,10 +245,10 @@ def choose_category(fn):
 
 def xml_for(command):
 name = command['name']
-async = command['async'] and ' (A)' or ''
+asyncmethod = command['async'] and ' (A)' or ''

Review comment:
   Sorry if this comment is redundant, I see that @nvazquez mentioned about 
changing other pieces as well.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] GabrielBrascher commented on pull request #4243: Update SystemVM debian iso from 10.4.0 to 10.5.0

2020-08-05 Thread GitBox


GabrielBrascher commented on pull request #4243:
URL: https://github.com/apache/cloudstack/pull/4243#issuecomment-66937


   @DaanHoogland that is a good question. What do you think @rhtyd? 
   
   I can close this PR if you guys think it should be addressed inside a PR 
when the respective requires a new system VM template.
   
   The downside is that it could catch some developer that is not used with the 
building template process; but on the other hand, we don't need to keep an eye 
looking for changes on the Debian 10.X.Y.
   
   Alternatives that I see:
   1. Update iso just if a new template is necessary
   2. Create some fancy way to automatically update
   3. Update at any time if someone struggle with building and sees it (no 
automation checking from time to time the ISO)



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] GabrielBrascher commented on a change in pull request #4030: some minor changes to make the build run with python 3

2020-08-05 Thread GitBox


GabrielBrascher commented on a change in pull request #4030:
URL: https://github.com/apache/cloudstack/pull/4030#discussion_r465751633



##
File path: tools/apidoc/gen_toc.py
##
@@ -245,10 +245,10 @@ def choose_category(fn):
 
 def xml_for(command):
 name = command['name']
-async = command['async'] and ' (A)' or ''
+asyncmethod = command['async'] and ' (A)' or ''

Review comment:
   @DaanHoogland shouldn't the header of this python file be changed from 
`#!/cygdrive/c/Python27` to `#!/cygdrive/c/Python3`?





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] rhtyd commented on pull request #4150: [HEALTH][4.14] Health Check Run

2020-08-05 Thread GitBox


rhtyd commented on pull request #4150:
URL: https://github.com/apache/cloudstack/pull/4150#issuecomment-669099405


   @blueorangutan test



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] blueorangutan commented on pull request #4235: [VMware] Full OVF properties support

2020-08-05 Thread GitBox


blueorangutan commented on pull request #4235:
URL: https://github.com/apache/cloudstack/pull/4235#issuecomment-669099106


   @shwstppr a Jenkins job has been kicked to build packages. I'll keep you 
posted as I make progress.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] ravening edited a comment on pull request #4228: Dont add host back after agent service restart

2020-08-05 Thread GitBox


ravening edited a comment on pull request #4228:
URL: https://github.com/apache/cloudstack/pull/4228#issuecomment-669102037


   > @ravening @rhtyd how about hiding this behaviour behind a global setting 
`auto-add-hosts`? (default would have to be true for backwards compatibility)
   
   @DaanHoogland is this what you are suggesting?
   
   Lets say, I add a global setting `add.host.on.service.restart` with default 
value of true
   When we delete the host, if the value is false then we set zone/cluster/pod 
value to null else retain as it is
   
   Since default value is true, we dont change any value and host will be added 
back if service is restarted



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] blueorangutan commented on pull request #4235: [VMware] Full OVF properties support

2020-08-05 Thread GitBox


blueorangutan commented on pull request #4235:
URL: https://github.com/apache/cloudstack/pull/4235#issuecomment-669114429


   Packaging result: ✔centos7 ✔debian. JID-1661



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] div8cn commented on issue #4245: VM cannot run normally in kvm UEFI LEGACY mode

2020-08-05 Thread GitBox


div8cn commented on issue #4245:
URL: https://github.com/apache/cloudstack/issues/4245#issuecomment-669117797


   I have resources to provide testing
   @DaanHoogland 
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] ravening commented on pull request #4228: Dont add host back after agent service restart

2020-08-05 Thread GitBox


ravening commented on pull request #4228:
URL: https://github.com/apache/cloudstack/pull/4228#issuecomment-669140042


   @rhtyd @DaanHoogland please review again



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] rhtyd commented on pull request #4131: [HEALTH] Master/4.15 Health Check please don't merge this

2020-08-05 Thread GitBox


rhtyd commented on pull request #4131:
URL: https://github.com/apache/cloudstack/pull/4131#issuecomment-669152354


   @blueorangutan test matrix 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] DaanHoogland commented on issue #4247: getPublicNetworkNamePrefix return UNSAFE public network name

2020-08-05 Thread GitBox


DaanHoogland commented on issue #4247:
URL: https://github.com/apache/cloudstack/issues/4247#issuecomment-669162443


   sounds like you have figured the code @echoidcf . will you submit a PR for 
this?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] andrijapanicsb commented on pull request #4194: enable update tags on disk offerings

2020-08-05 Thread GitBox


andrijapanicsb commented on pull request #4194:
URL: https://github.com/apache/cloudstack/pull/4194#issuecomment-669174222


   (that boils down to "don't give a sharp knife to a kid, but let wife take 
the sharp knife to prepare a meal" - whoever is using it should be proficient 
;) )



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] DaanHoogland commented on pull request #4236: resolves issues Multiple Public Subnets static NAT

2020-08-05 Thread GitBox


DaanHoogland commented on pull request #4236:
URL: https://github.com/apache/cloudstack/pull/4236#issuecomment-669196113


   should we add
   Fixes #4234
   to the description of this PR, @havengit ?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] DaanHoogland commented on issue #4245: VM cannot run normally in kvm UEFI LEGACY mode

2020-08-05 Thread GitBox


DaanHoogland commented on issue #4245:
URL: https://github.com/apache/cloudstack/issues/4245#issuecomment-669087275


   @div8cn do you have resources to work on this?
   should we set a milestone yet?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] Spaceman1984 commented on issue #4242: Unable to login with latest master 2020/08/04

2020-08-05 Thread GitBox


Spaceman1984 commented on issue #4242:
URL: https://github.com/apache/cloudstack/issues/4242#issuecomment-669087721


   @rhtyd This is an edge case with a workaround, maybe we can close this one?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] DaanHoogland edited a comment on issue #4244: Attach iso failed for kvm UEFI

2020-08-05 Thread GitBox


DaanHoogland edited a comment on issue #4244:
URL: https://github.com/apache/cloudstack/issues/4244#issuecomment-669092988


   same question @div8cn do you have resources for this?
   And also does this work properly with BIOS or is the problem not specific to 
UEFI?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] DaanHoogland commented on issue #4244: Attach iso failed for kvm UEFI

2020-08-05 Thread GitBox


DaanHoogland commented on issue #4244:
URL: https://github.com/apache/cloudstack/issues/4244#issuecomment-669092988


   same question @div8cn do you have resources for this?
   And also does this work properly with BIOS or is the problem specific to 
UEFI?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] blueorangutan commented on pull request #4150: [HEALTH][4.14] Health Check Run

2020-08-05 Thread GitBox


blueorangutan commented on pull request #4150:
URL: https://github.com/apache/cloudstack/pull/4150#issuecomment-66907


   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been 
kicked to run smoke tests



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] DaanHoogland commented on pull request #4228: Dont add host back after agent service restart

2020-08-05 Thread GitBox


DaanHoogland commented on pull request #4228:
URL: https://github.com/apache/cloudstack/pull/4228#issuecomment-669099849


   @ravening @rhtyd how about hiding this behaviour behind a global setting 
`auto-add-hosts`? (default would have to be true for backwards compatibility)



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] blueorangutan commented on pull request #4235: [VMware] Full OVF properties support

2020-08-05 Thread GitBox


blueorangutan commented on pull request #4235:
URL: https://github.com/apache/cloudstack/pull/4235#issuecomment-669119578


   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been 
kicked to run smoke tests



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack] rhtyd commented on pull request #4235: [VMware] Full OVF properties support

2020-08-05 Thread GitBox


rhtyd commented on pull request #4235:
URL: https://github.com/apache/cloudstack/pull/4235#issuecomment-669119277


   @blueorangutan test centos7 vmware-67u3
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




  1   2   >