[GitHub] [cloudstack] rhtyd commented on pull request #4239: Disabling managing firewall - cloudstack-setup-management

2020-08-10 Thread GitBox
rhtyd commented on pull request #4239: URL: https://github.com/apache/cloudstack/pull/4239#issuecomment-671294257 this needs a test run as changes are in cloudstack-setup-management cc @davidjumani pl kick test when lab is online

[GitHub] [cloudstack] blueorangutan commented on pull request #4040: [WIP] [KVM] Enable PVLAN support on L2 networks

2020-08-10 Thread GitBox
blueorangutan commented on pull request #4040: URL: https://github.com/apache/cloudstack/pull/4040#issuecomment-671387310 @davidjumani a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #4128: Role based users in Projects

2020-08-10 Thread GitBox
DaanHoogland commented on a change in pull request #4128: URL: https://github.com/apache/cloudstack/pull/4128#discussion_r467932240 ## File path: results.xml ## @@ -0,0 +1,3 @@ + Review comment: this file is missing a license. either add it to the ignore list or add a

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #4248: vSphere advanced capabilities with datastore support and api improvements

2020-08-10 Thread GitBox
DaanHoogland commented on a change in pull request #4248: URL: https://github.com/apache/cloudstack/pull/4248#discussion_r467768177 ## File path: api/src/main/java/com/cloud/dc/VsphereStoragePolicy.java ## @@ -0,0 +1,31 @@ +// Licensed to the Apache Software Foundation (ASF)

[GitHub] [cloudstack] blueorangutan commented on pull request #4248: vSphere advanced capabilities with datastore support and api improvements

2020-08-10 Thread GitBox
blueorangutan commented on pull request #4248: URL: https://github.com/apache/cloudstack/pull/4248#issuecomment-671345669 @rhtyd a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware67, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests

[GitHub] [cloudstack] rhtyd commented on pull request #4248: vSphere advanced capabilities with datastore support and api improvements

2020-08-10 Thread GitBox
rhtyd commented on pull request #4248: URL: https://github.com/apache/cloudstack/pull/4248#issuecomment-671345154 @blueorangutan test matrix This is an automated message from the Apache Git Service. To respond to the

[GitHub] [cloudstack] davidjumani commented on pull request #4040: [WIP] [KVM] Enable PVLAN support on L2 networks

2020-08-10 Thread GitBox
davidjumani commented on pull request #4040: URL: https://github.com/apache/cloudstack/pull/4040#issuecomment-671386954 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the

[cloudstack] branch master updated (7707d3f -> 6a1ddf7)

2020-08-10 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git. from 7707d3f engine: fix NPE from fwd-merge 562a7db8dfd923c986f231a42c15669922574a7c add ce7a32c build: Fix

[GitHub] [cloudstack] blueorangutan commented on pull request #4250: [VMware] OVF Full properties support

2020-08-10 Thread GitBox
blueorangutan commented on pull request #4250: URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-671511729 Packaging result: ✔centos7 ✔debian. JID-1699 This is an automated message from the Apache Git Service.

[GitHub] [cloudstack] RodrigoDLopez commented on pull request #4255: Prevent null pointer on listPublicIpAddress cmd

2020-08-10 Thread GitBox
RodrigoDLopez commented on pull request #4255: URL: https://github.com/apache/cloudstack/pull/4255#issuecomment-671522909 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the

[GitHub] [cloudstack] GabrielBrascher commented on pull request #4190: Broadcast URI not set to vxlan, but vlan (Fix #3040)

2020-08-10 Thread GitBox
GabrielBrascher commented on pull request #4190: URL: https://github.com/apache/cloudstack/pull/4190#issuecomment-671483668 @rhtyd I just tested on master and the problem is still there. I also gave a quick look at the codebase and could not see any recent commit addressing this. I

[GitHub] [cloudstack] GabrielBrascher edited a comment on pull request #4190: Broadcast URI not set to vxlan, but vlan (Fix #3040)

2020-08-10 Thread GitBox
GabrielBrascher edited a comment on pull request #4190: URL: https://github.com/apache/cloudstack/pull/4190#issuecomment-671483668 @rhtyd I just tested on master and the problem is still there. I also gave a quick look at the codebase and could not see any recent commit addressing

[GitHub] [cloudstack] blueorangutan commented on pull request #4255: Prevent null pointer on listPublicIpAddress cmd

2020-08-10 Thread GitBox
blueorangutan commented on pull request #4255: URL: https://github.com/apache/cloudstack/pull/4255#issuecomment-671523338 @RodrigoDLopez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] [cloudstack] blueorangutan commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

2020-08-10 Thread GitBox
blueorangutan commented on pull request #4068: URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-671434990 Packaging result: ✖centos7 ✖debian. JID-1698 This is an automated message from the Apache Git Service.

[GitHub] [cloudstack] blueorangutan commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

2020-08-10 Thread GitBox
blueorangutan commented on pull request #4068: URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-671412040 @andrijapanicsb a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] [cloudstack] RodrigoDLopez opened a new pull request #4255: Prevent null pointer on listPublicIpAddress cmd

2020-08-10 Thread GitBox
RodrigoDLopez opened a new pull request #4255: URL: https://github.com/apache/cloudstack/pull/4255 ## Description I reproduced this in a production environment that had been upgraded from 4.9 to 4.11 and then to 4.13. If the environment has `data centers` and `VLANs`

[GitHub] [cloudstack] rhtyd commented on pull request #4250: [VMware] OVF Full properties support

2020-08-10 Thread GitBox
rhtyd commented on pull request #4250: URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-671493143 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [cloudstack] blueorangutan commented on pull request #4250: [VMware] OVF Full properties support

2020-08-10 Thread GitBox
blueorangutan commented on pull request #4250: URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-671493719 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This

[GitHub] [cloudstack] blueorangutan commented on pull request #4040: [WIP] [KVM] Enable PVLAN support on L2 networks

2020-08-10 Thread GitBox
blueorangutan commented on pull request #4040: URL: https://github.com/apache/cloudstack/pull/4040#issuecomment-671407884 Packaging result: ✔centos7 ✔debian. JID-1697 This is an automated message from the Apache Git Service.

[GitHub] [cloudstack] andrijapanicsb commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

2020-08-10 Thread GitBox
andrijapanicsb commented on pull request #4068: URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-671411321 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the

[GitHub] [cloudstack] RodrigoDLopez commented on a change in pull request #4256: Fix comparison using nullable objects

2020-08-10 Thread GitBox
RodrigoDLopez commented on a change in pull request #4256: URL: https://github.com/apache/cloudstack/pull/4256#discussion_r468181954 ## File path: utils/src/test/java/com/cloud/utils/TernaryTest.java ## @@ -28,7 +28,7 @@ public void testEquals() {

[GitHub] [cloudstack] RodrigoDLopez commented on a change in pull request #4256: Fix comparison using nullable objects

2020-08-10 Thread GitBox
RodrigoDLopez commented on a change in pull request #4256: URL: https://github.com/apache/cloudstack/pull/4256#discussion_r468181783 ## File path: server/src/main/java/com/cloud/storage/VolumeApiServiceImpl.java ## @@ -2199,7 +2199,7 @@ public Volume

[GitHub] [cloudstack] RodrigoDLopez opened a new pull request #4256: Fix comparison using nullable objects

2020-08-10 Thread GitBox
RodrigoDLopez opened a new pull request #4256: URL: https://github.com/apache/cloudstack/pull/4256 ## Description This PR fix some wrongs comparison using nullable objects. Preventing null pointer exception ## Types of changes - [ ] Breaking

[GitHub] [cloudstack] rafaelweingartner commented on a change in pull request #4256: Fix comparison using nullable objects

2020-08-10 Thread GitBox
rafaelweingartner commented on a change in pull request #4256: URL: https://github.com/apache/cloudstack/pull/4256#discussion_r468162010 ## File path: server/src/main/java/com/cloud/storage/VolumeApiServiceImpl.java ## @@ -2199,7 +2199,7 @@ public Volume

[GitHub] [cloudstack] RodrigoDLopez commented on pull request #4251: Handle with VM snapshot events

2020-08-10 Thread GitBox
RodrigoDLopez commented on pull request #4251: URL: https://github.com/apache/cloudstack/pull/4251#issuecomment-671639427 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the

[GitHub] [cloudstack] blueorangutan commented on pull request #4251: Handle with VM snapshot events

2020-08-10 Thread GitBox
blueorangutan commented on pull request #4251: URL: https://github.com/apache/cloudstack/pull/4251#issuecomment-671639693 @RodrigoDLopez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] [cloudstack] RodrigoDLopez commented on pull request #4256: Fix comparison using nullable objects

2020-08-10 Thread GitBox
RodrigoDLopez commented on pull request #4256: URL: https://github.com/apache/cloudstack/pull/4256#issuecomment-671639621 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the

[GitHub] [cloudstack] blueorangutan commented on pull request #4256: Fix comparison using nullable objects

2020-08-10 Thread GitBox
blueorangutan commented on pull request #4256: URL: https://github.com/apache/cloudstack/pull/4256#issuecomment-671639933 @RodrigoDLopez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] [cloudstack] RodrigoDLopez closed pull request #4257: remove the unnecessary check for tags when migrating volumes

2020-08-10 Thread GitBox
RodrigoDLopez closed pull request #4257: URL: https://github.com/apache/cloudstack/pull/4257 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [cloudstack] blueorangutan commented on pull request #4250: [VMware] OVF Full properties support

2020-08-10 Thread GitBox
blueorangutan commented on pull request #4250: URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-671529013 @rhtyd a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware67, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests

[GitHub] [cloudstack] rhtyd commented on pull request #4250: [VMware] OVF Full properties support

2020-08-10 Thread GitBox
rhtyd commented on pull request #4250: URL: https://github.com/apache/cloudstack/pull/4250#issuecomment-671528667 @blueorangutan test matrix This is an automated message from the Apache Git Service. To respond to the

[GitHub] [cloudstack] blueorangutan commented on pull request #4255: Prevent null pointer on listPublicIpAddress cmd

2020-08-10 Thread GitBox
blueorangutan commented on pull request #4255: URL: https://github.com/apache/cloudstack/pull/4255#issuecomment-671540776 Packaging result: ✔centos7 ✔debian. JID-1700 This is an automated message from the Apache Git Service.

[GitHub] [cloudstack] RodrigoDLopez opened a new pull request #4257: remove the unnecessary check for tags when migrating volumes

2020-08-10 Thread GitBox
RodrigoDLopez opened a new pull request #4257: URL: https://github.com/apache/cloudstack/pull/4257 ## Description With this commit [Fix limitation on tag matching in 'migrateVolume' with disk

[GitHub] [cloudstack] blueorangutan commented on pull request #4254: Name public network appropriately to avoid conflicts

2020-08-10 Thread GitBox
blueorangutan commented on pull request #4254: URL: https://github.com/apache/cloudstack/pull/4254#issuecomment-671740337 Trillian test result (tid-2343) Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7 Total time taken: 41604 seconds Marvin logs:

[GitHub] [cloudstack] echoidcf commented on issue #4247: getPublicNetworkNamePrefix return UNSAFE public network name

2020-08-10 Thread GitBox
echoidcf commented on issue #4247: URL: https://github.com/apache/cloudstack/issues/4247#issuecomment-671738308 > @echoidcf a pull request, sending code contribution to this repository Sounds cool, but I don't know much about java. I can read, but coding is another thing ^^.

[GitHub] [cloudstack] rhtyd commented on pull request #4248: vSphere advanced capabilities with datastore support and api improvements

2020-08-10 Thread GitBox
rhtyd commented on pull request #4248: URL: https://github.com/apache/cloudstack/pull/4248#issuecomment-671708319 @blueorangutan test centos7 vmware-67u3 This is an automated message from the Apache Git Service. To respond

[GitHub] [cloudstack] blueorangutan commented on pull request #4248: vSphere advanced capabilities with datastore support and api improvements

2020-08-10 Thread GitBox
blueorangutan commented on pull request #4248: URL: https://github.com/apache/cloudstack/pull/4248#issuecomment-671669251 Trillian test result (tid-2341) Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7 Total time taken: 41622 seconds Marvin logs:

[GitHub] [cloudstack] blueorangutan commented on pull request #4251: Handle with VM snapshot events

2020-08-10 Thread GitBox
blueorangutan commented on pull request #4251: URL: https://github.com/apache/cloudstack/pull/4251#issuecomment-671654387 Packaging result: ✔centos7 ✔debian. JID-1701 This is an automated message from the Apache Git Service.

[GitHub] [cloudstack] blueorangutan commented on pull request #4256: Fix comparison using nullable objects

2020-08-10 Thread GitBox
blueorangutan commented on pull request #4256: URL: https://github.com/apache/cloudstack/pull/4256#issuecomment-671654388 Packaging result: ✔centos7 ✔debian. JID-1702 This is an automated message from the Apache Git Service.

[GitHub] [cloudstack] blueorangutan commented on pull request #4248: vSphere advanced capabilities with datastore support and api improvements

2020-08-10 Thread GitBox
blueorangutan commented on pull request #4248: URL: https://github.com/apache/cloudstack/pull/4248#issuecomment-671697133 Trillian test result (tid-2340) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 47847 seconds Marvin logs:

[GitHub] [cloudstack] blueorangutan commented on pull request #4248: vSphere advanced capabilities with datastore support and api improvements

2020-08-10 Thread GitBox
blueorangutan commented on pull request #4248: URL: https://github.com/apache/cloudstack/pull/4248#issuecomment-671708466 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests

[GitHub] [cloudstack] GabrielBrascher edited a comment on pull request #3730: Update SystemVM scripts from python2 to python3

2020-08-10 Thread GitBox
GabrielBrascher edited a comment on pull request #3730: URL: https://github.com/apache/cloudstack/pull/3730#issuecomment-671670803 Pycodestyle has passed after the last commit. Jenkins and Travis are looking good. This one is ready for review/tests.

[GitHub] [cloudstack] GabrielBrascher commented on pull request #3730: Update SystemVM scripts from python2 to python3

2020-08-10 Thread GitBox
GabrielBrascher commented on pull request #3730: URL: https://github.com/apache/cloudstack/pull/3730#issuecomment-671670803 Pycodestyle has passed after last commit. Jenkins and Travisa are looking good. This one is ready for review/tests.

[GitHub] [cloudstack] DaanHoogland commented on pull request #4137: Adding VPN options for IKE version and IKE split connections.

2020-08-10 Thread GitBox
DaanHoogland commented on pull request #4137: URL: https://github.com/apache/cloudstack/pull/4137#issuecomment-671235144 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the

[GitHub] [cloudstack] blueorangutan commented on pull request #4137: Adding VPN options for IKE version and IKE split connections.

2020-08-10 Thread GitBox
blueorangutan commented on pull request #4137: URL: https://github.com/apache/cloudstack/pull/4137#issuecomment-671235590 @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[GitHub] [cloudstack] sm97 commented on issue #4241: Unexpected exception while executing org.apache.cloudstack.api.command.user.kubernetes.cluster.CreateKubernetesClusterCmd

2020-08-10 Thread GitBox
sm97 commented on issue #4241: URL: https://github.com/apache/cloudstack/issues/4241#issuecomment-671258651 @shwstppr Do I need to supply additional info? This is an automated message from the Apache Git Service. To respond

[GitHub] [cloudstack] shwstppr commented on issue #4241: Unexpected exception while executing org.apache.cloudstack.api.command.user.kubernetes.cluster.CreateKubernetesClusterCmd

2020-08-10 Thread GitBox
shwstppr commented on issue #4241: URL: https://github.com/apache/cloudstack/issues/4241#issuecomment-671259755 @sm97 sorry got occupied with some stuff last week. WIll get back to you on this later today. This is an

[GitHub] [cloudstack] rhtyd commented on issue #4246: plugPublicNic forgot to sort the nic devices before plug a new public network

2020-08-10 Thread GitBox
rhtyd commented on issue #4246: URL: https://github.com/apache/cloudstack/issues/4246#issuecomment-671205947 @Spaceman1984 please liase with @Pearl1594 as to who may be picking this up, thanks. This is an automated message

[GitHub] [cloudstack] rhtyd commented on issue #4247: getPublicNetworkNamePrefix return UNSAFE public network name

2020-08-10 Thread GitBox
rhtyd commented on issue #4247: URL: https://github.com/apache/cloudstack/issues/4247#issuecomment-671205777 @Pearl1594 instead of the fix you've proposed can you fix the usage of `getNicDeviceIndex` to find exact or most matching portgroup instead of startswith(), i.e. the search should

[GitHub] [cloudstack] Pearl1594 commented on a change in pull request #4254: Name public network appropriately to avoid conflicts

2020-08-10 Thread GitBox
Pearl1594 commented on a change in pull request #4254: URL: https://github.com/apache/cloudstack/pull/4254#discussion_r467732464 ## File path: vmware-base/src/main/java/com/cloud/hypervisor/vmware/mo/HypervisorHostHelper.java ## @@ -198,7 +198,7 @@ public static String

[GitHub] [cloudstack] rhtyd closed pull request #3312: 'sed -i' need postfix on mac

2020-08-10 Thread GitBox
rhtyd closed pull request #3312: URL: https://github.com/apache/cloudstack/pull/3312 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [cloudstack] rhtyd merged pull request #4253: Fix sed command failure in Mac OS.

2020-08-10 Thread GitBox
rhtyd merged pull request #4253: URL: https://github.com/apache/cloudstack/pull/4253 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [cloudstack] rhtyd commented on pull request #3312: 'sed -i' need postfix on mac

2020-08-10 Thread GitBox
rhtyd commented on pull request #3312: URL: https://github.com/apache/cloudstack/pull/3312#issuecomment-671209012 Closing as https://github.com/apache/cloudstack/pull/4253 fixed it This is an automated message from the

[GitHub] [cloudstack] rhtyd commented on pull request #4254: Name public network appropriately to avoid conflicts

2020-08-10 Thread GitBox
rhtyd commented on pull request #4254: URL: https://github.com/apache/cloudstack/pull/4254#issuecomment-671208661 @blueorangutan test centos7 vmware-67u3 This is an automated message from the Apache Git Service. To respond

[GitHub] [cloudstack] rhtyd commented on a change in pull request #4254: Name public network appropriately to avoid conflicts

2020-08-10 Thread GitBox
rhtyd commented on a change in pull request #4254: URL: https://github.com/apache/cloudstack/pull/4254#discussion_r467734042 ## File path: vmware-base/src/main/java/com/cloud/hypervisor/vmware/mo/HypervisorHostHelper.java ## @@ -198,7 +198,7 @@ public static String

[GitHub] [cloudstack] rhtyd commented on pull request #4253: Fix sed command failure in Mac OS.

2020-08-10 Thread GitBox
rhtyd commented on pull request #4253: URL: https://github.com/apache/cloudstack/pull/4253#issuecomment-671208788 LGTM travis and build (on Linux) passes This is an automated message from the Apache Git Service. To respond

[GitHub] [cloudstack] rhtyd commented on pull request #4128: Role based users in Projects

2020-08-10 Thread GitBox
rhtyd commented on pull request #4128: URL: https://github.com/apache/cloudstack/pull/4128#issuecomment-671209775 Rekicked travis This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [cloudstack] blueorangutan commented on pull request #4053: Secondary Storage Usage Improvements

2020-08-10 Thread GitBox
blueorangutan commented on pull request #4053: URL: https://github.com/apache/cloudstack/pull/4053#issuecomment-671209737 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This

[GitHub] [cloudstack] Pearl1594 commented on a change in pull request #4254: Name public network appropriately to avoid conflicts

2020-08-10 Thread GitBox
Pearl1594 commented on a change in pull request #4254: URL: https://github.com/apache/cloudstack/pull/4254#discussion_r467732464 ## File path: vmware-base/src/main/java/com/cloud/hypervisor/vmware/mo/HypervisorHostHelper.java ## @@ -198,7 +198,7 @@ public static String

[GitHub] [cloudstack] rhtyd closed pull request #4053: Secondary Storage Usage Improvements

2020-08-10 Thread GitBox
rhtyd closed pull request #4053: URL: https://github.com/apache/cloudstack/pull/4053 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [cloudstack] blueorangutan commented on pull request #4254: Name public network appropriately to avoid conflicts

2020-08-10 Thread GitBox
blueorangutan commented on pull request #4254: URL: https://github.com/apache/cloudstack/pull/4254#issuecomment-671209011 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests

[cloudstack] branch 4.14 updated: build: Fix sed command failure in Mac OS. (#4253)

2020-08-10 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a commit to branch 4.14 in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/4.14 by this push: new ce7a32c build: Fix sed command failure in Mac

[GitHub] [cloudstack] rhtyd commented on pull request #4053: Secondary Storage Usage Improvements

2020-08-10 Thread GitBox
rhtyd commented on pull request #4053: URL: https://github.com/apache/cloudstack/pull/4053#issuecomment-671209518 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [cloudstack] rhtyd commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

2020-08-10 Thread GitBox
rhtyd commented on pull request #4068: URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-671209608 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [cloudstack] rhtyd commented on pull request #4213: Search vm snapshots using tags

2020-08-10 Thread GitBox
rhtyd commented on pull request #4213: URL: https://github.com/apache/cloudstack/pull/4213#issuecomment-671209890 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [cloudstack] rhtyd closed pull request #4128: Role based users in Projects

2020-08-10 Thread GitBox
rhtyd closed pull request #4128: URL: https://github.com/apache/cloudstack/pull/4128 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [cloudstack] rhtyd commented on pull request #4239: Disabling managing firewall - cloudstack-setup-management

2020-08-10 Thread GitBox
rhtyd commented on pull request #4239: URL: https://github.com/apache/cloudstack/pull/4239#issuecomment-671210203 LGTM @blueorangutan package This is an automated message from the Apache Git Service. To respond to the

[GitHub] [cloudstack] blueorangutan commented on pull request #4213: Search vm snapshots using tags

2020-08-10 Thread GitBox
blueorangutan commented on pull request #4213: URL: https://github.com/apache/cloudstack/pull/4213#issuecomment-671210065 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This

[GitHub] [cloudstack] blueorangutan commented on pull request #4068: Adding Centos8, Ubuntu 20.04, XCPNG8.1 Support

2020-08-10 Thread GitBox
blueorangutan commented on pull request #4068: URL: https://github.com/apache/cloudstack/pull/4068#issuecomment-671210249 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This

[GitHub] [cloudstack] rhtyd closed pull request #4040: [KVM] Enable PVLAN support on L2 networks

2020-08-10 Thread GitBox
rhtyd closed pull request #4040: URL: https://github.com/apache/cloudstack/pull/4040 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [cloudstack] blueorangutan commented on pull request #4239: Disabling managing firewall - cloudstack-setup-management

2020-08-10 Thread GitBox
blueorangutan commented on pull request #4239: URL: https://github.com/apache/cloudstack/pull/4239#issuecomment-671210431 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This

[GitHub] [cloudstack] rhtyd commented on pull request #4040: [KVM] Enable PVLAN support on L2 networks

2020-08-10 Thread GitBox
rhtyd commented on pull request #4040: URL: https://github.com/apache/cloudstack/pull/4040#issuecomment-671210540 @davidjumani cc @borisstoyanov @vladimirpetrov - is this ready for merging or needs additional changes/fixes? @blueorangutan package

[GitHub] [cloudstack] davidjumani opened a new pull request #4040: [KVM] Enable PVLAN support on L2 networks

2020-08-10 Thread GitBox
davidjumani opened a new pull request #4040: URL: https://github.com/apache/cloudstack/pull/4040 ## Description This is an extention of #3732 for kvm. This is restricted to ovs > 2.9.2 Since Xen uses ovs 2.6, pvlan is unsupported. This also fixes issues of vms on the same

[GitHub] [cloudstack] rhtyd commented on pull request #4016: Fixed private gateway can't be deleted

2020-08-10 Thread GitBox
rhtyd commented on pull request #4016: URL: https://github.com/apache/cloudstack/pull/4016#issuecomment-671211245 @DaanHoogland @Spaceman1984 - my concern is that whether removing privategateway also remove the nic/configuration from the VPC VR or not? Based on code, I think it will solve

[GitHub] [cloudstack] rhtyd edited a comment on pull request #4016: Fixed private gateway can't be deleted

2020-08-10 Thread GitBox
rhtyd edited a comment on pull request #4016: URL: https://github.com/apache/cloudstack/pull/4016#issuecomment-671211245 @DaanHoogland @Spaceman1984 - my concern is that whether removing privategateway also remove the nic/configuration from the VPC VR or not? Based on code, I think it

[GitHub] [cloudstack] blueorangutan commented on pull request #4040: [KVM] Enable PVLAN support on L2 networks

2020-08-10 Thread GitBox
blueorangutan commented on pull request #4040: URL: https://github.com/apache/cloudstack/pull/4040#issuecomment-671210840 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This

[GitHub] [cloudstack] rhtyd closed pull request #4213: Search vm snapshots using tags

2020-08-10 Thread GitBox
rhtyd closed pull request #4213: URL: https://github.com/apache/cloudstack/pull/4213 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [cloudstack] DaanHoogland commented on pull request #4141: [New feature] Load balancer customization (haproxy-based)

2020-08-10 Thread GitBox
DaanHoogland commented on pull request #4141: URL: https://github.com/apache/cloudstack/pull/4141#issuecomment-671218525 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the

[GitHub] [cloudstack] blueorangutan commented on pull request #4141: [New feature] Load balancer customization (haproxy-based)

2020-08-10 Thread GitBox
blueorangutan commented on pull request #4141: URL: https://github.com/apache/cloudstack/pull/4141#issuecomment-671218822 @DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] [cloudstack] blueorangutan commented on pull request #4254: Name public network appropriately to avoid conflicts

2020-08-10 Thread GitBox
blueorangutan commented on pull request #4254: URL: https://github.com/apache/cloudstack/pull/4254#issuecomment-671181895 Packaging result: ✔centos7 ✔debian. JID-1688 This is an automated message from the Apache Git Service.

[GitHub] [cloudstack] blueorangutan commented on pull request #4253: Fix sed command failure in Mac OS.

2020-08-10 Thread GitBox
blueorangutan commented on pull request #4253: URL: https://github.com/apache/cloudstack/pull/4253#issuecomment-671189647 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This

[GitHub] [cloudstack] blueorangutan commented on pull request #4253: Fix sed command failure in Mac OS.

2020-08-10 Thread GitBox
blueorangutan commented on pull request #4253: URL: https://github.com/apache/cloudstack/pull/4253#issuecomment-671199939 Packaging result: ✔centos7 ✔debian. JID-1690 This is an automated message from the Apache Git Service.

[GitHub] [cloudstack] rhtyd commented on pull request #4253: Fix sed command failure in Mac OS.

2020-08-10 Thread GitBox
rhtyd commented on pull request #4253: URL: https://github.com/apache/cloudstack/pull/4253#issuecomment-671189204 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [cloudstack] rhtyd closed pull request #4239: Disabling managing firewall - cloudstack-setup-management

2020-08-10 Thread GitBox
rhtyd closed pull request #4239: URL: https://github.com/apache/cloudstack/pull/4239 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [cloudstack] blueorangutan commented on pull request #3250: [WIP DO NOT MERGE] server: compute offering for specified domain(s) and zone(s)

2020-08-10 Thread GitBox
blueorangutan commented on pull request #3250: URL: https://github.com/apache/cloudstack/pull/3250#issuecomment-67116 Packaging result: ✖centos7 ✖debian. JID-1689 This is an automated message from the Apache Git Service.