[GitHub] [cloudstack] weizhouapache commented on pull request #7037: Fix volume snapshot in a VM with an ISO attached

2023-01-02 Thread GitBox
weizhouapache commented on PR #7037: URL: https://github.com/apache/cloudstack/pull/7037#issuecomment-1369087952 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [cloudstack] GaOrtiga opened a new pull request, #7039: Allow download of System VM templates through the UI

2023-01-02 Thread GitBox
GaOrtiga opened a new pull request, #7039: URL: https://github.com/apache/cloudstack/pull/7039 ### Description The [PR#6750](https://github.com/apache/cloudstack/pull/6750) allowed Root Admins to download system VM templates through the API. This function was extended to the UI.

[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #7039: Allow download of System VM templates through the UI

2023-01-02 Thread GitBox
sonarcloud[bot] commented on PR #7039: URL: https://github.com/apache/cloudstack/pull/7039#issuecomment-1369172441 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [cloudstack] ezntt commented on a diff in pull request #7022: Cleanup APIs getCommandName

2023-01-02 Thread GitBox
ezntt commented on code in PR #7022: URL: https://github.com/apache/cloudstack/pull/7022#discussion_r1060195337 ## api/src/main/java/org/apache/cloudstack/api/BaseCmd.java: ## @@ -247,30 +247,36 @@ public void setResponseType(final String responseType) {

[GitHub] [cloudstack] ezntt commented on a diff in pull request #7022: Cleanup APIs getCommandName

2023-01-02 Thread GitBox
ezntt commented on code in PR #7022: URL: https://github.com/apache/cloudstack/pull/7022#discussion_r1060190770 ## api/src/main/java/org/apache/cloudstack/api/BaseCmd.java: ## @@ -247,30 +247,36 @@ public void setResponseType(final String responseType) {

[GitHub] [cloudstack] ezntt commented on a diff in pull request #7022: Cleanup APIs getCommandName

2023-01-02 Thread GitBox
ezntt commented on code in PR #7022: URL: https://github.com/apache/cloudstack/pull/7022#discussion_r1060190770 ## api/src/main/java/org/apache/cloudstack/api/BaseCmd.java: ## @@ -247,30 +247,36 @@ public void setResponseType(final String responseType) {

[GitHub] [cloudstack] blueorangutan commented on pull request #7037: Fix volume snapshot in a VM with an ISO attached

2023-01-02 Thread GitBox
blueorangutan commented on PR #7037: URL: https://github.com/apache/cloudstack/pull/7037#issuecomment-1369088434 @weizhouapache a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To

[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #7022: Cleanup APIs getCommandName

2023-01-02 Thread GitBox
sonarcloud[bot] commented on PR #7022: URL: https://github.com/apache/cloudstack/pull/7022#issuecomment-1369110400 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [cloudstack] aron-ac commented on issue #6987: Project User kubeadmin is not working with project k8s clusters

2023-01-02 Thread GitBox
aron-ac commented on issue #6987: URL: https://github.com/apache/cloudstack/issues/6987#issuecomment-1369169492 @davidjumani hope you had a great vacation. This bug has seemingly gotten worse in my environment, I'm seeing the same issue with regular users and project users. From the k8s

[GitHub] [cloudstack] codecov[bot] commented on pull request #7039: Allow download of System VM templates through the UI

2023-01-02 Thread GitBox
codecov[bot] commented on PR #7039: URL: https://github.com/apache/cloudstack/pull/7039#issuecomment-1369168669 # [Codecov](https://codecov.io/gh/apache/cloudstack/pull/7039?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)

[GitHub] [cloudstack] blueorangutan commented on pull request #7008: utils: fix human-readable parsing failures

2023-01-02 Thread GitBox
blueorangutan commented on PR #7008: URL: https://github.com/apache/cloudstack/pull/7008#issuecomment-1369387269 Trillian test result (tid-5732) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 47910 seconds Marvin logs:

[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #5797: Improve global settings UI to be more intuitive/logical

2023-01-02 Thread GitBox
sonarcloud[bot] commented on PR #5797: URL: https://github.com/apache/cloudstack/pull/5797#issuecomment-1369469126 SonarCloud Quality Gate failed. [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality

[GitHub] [cloudstack] blueorangutan commented on pull request #7037: Fix volume snapshot in a VM with an ISO attached

2023-01-02 Thread GitBox
blueorangutan commented on PR #7037: URL: https://github.com/apache/cloudstack/pull/7037#issuecomment-1369395532 Trillian test result (tid-5733) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 42466 seconds Marvin logs:

[GitHub] [cloudstack] blueorangutan commented on pull request #6005: Support to resize uploaded volume during attach

2023-01-02 Thread GitBox
blueorangutan commented on PR #6005: URL: https://github.com/apache/cloudstack/pull/6005#issuecomment-1368725513 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 5154 -- This is an

[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #6005: Support to resize uploaded volume during attach

2023-01-02 Thread GitBox
sonarcloud[bot] commented on PR #6005: URL: https://github.com/apache/cloudstack/pull/6005#issuecomment-1368727619 SonarCloud Quality Gate failed. [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality

[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #7028: add index to speed up querying IPs in the network-tab

2023-01-02 Thread GitBox
sonarcloud[bot] commented on PR #7028: URL: https://github.com/apache/cloudstack/pull/7028#issuecomment-1368732909 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [cloudstack] codecov[bot] commented on pull request #6005: Support to resize uploaded volume during attach

2023-01-02 Thread GitBox
codecov[bot] commented on PR #6005: URL: https://github.com/apache/cloudstack/pull/6005#issuecomment-1368770431 # [Codecov](https://codecov.io/gh/apache/cloudstack/pull/6005?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)

[GitHub] [cloudstack] blueorangutan commented on pull request #7037: Fix volume snapshot in a VM with an ISO attached

2023-01-02 Thread GitBox
blueorangutan commented on PR #7037: URL: https://github.com/apache/cloudstack/pull/7037#issuecomment-1369041367 @weizhouapache a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[GitHub] [cloudstack] weizhouapache commented on pull request #7037: Fix volume snapshot in a VM with an ISO attached

2023-01-02 Thread GitBox
weizhouapache commented on PR #7037: URL: https://github.com/apache/cloudstack/pull/7037#issuecomment-1369041168 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [cloudstack] blueorangutan commented on pull request #7037: Fix volume snapshot in a VM with an ISO attached

2023-01-02 Thread GitBox
blueorangutan commented on PR #7037: URL: https://github.com/apache/cloudstack/pull/7037#issuecomment-1369074584 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 5155 -- This is an

[GitHub] [cloudstack] soreana commented on pull request #6918: Override vr service offering

2023-01-02 Thread GitBox
soreana commented on PR #6918: URL: https://github.com/apache/cloudstack/pull/6918#issuecomment-1369075920 @DaanHoogland The `CreateNetworkOfferingTest` fails and I don't know why :( Build packages with -DskipTests, they were working. I'm trouble shooting to see what went wrong, let me

[GitHub] [cloudstack] codecov[bot] commented on pull request #7038: UI: user must specify the start of guest vlan range for advanced zone

2023-01-02 Thread GitBox
codecov[bot] commented on PR #7038: URL: https://github.com/apache/cloudstack/pull/7038#issuecomment-1369077390 # [Codecov](https://codecov.io/gh/apache/cloudstack/pull/7038?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)

[GitHub] [cloudstack] weizhouapache opened a new pull request, #7038: UI: user must specify the start of guest vlan range for advanced zone

2023-01-02 Thread GitBox
weizhouapache opened a new pull request, #7038: URL: https://github.com/apache/cloudstack/pull/7038 ### Description This PR fixes #6727 The start of guest vlan range is a must. if end is not set, the vlan range is start-start otherwise, the vlan range is start-end

[GitHub] [cloudstack] weizhouapache closed pull request #7008: utils: fix human-readable parsing failures

2023-01-02 Thread GitBox
weizhouapache closed pull request #7008: utils: fix human-readable parsing failures URL: https://github.com/apache/cloudstack/pull/7008 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [cloudstack] weizhouapache commented on pull request #7008: utils: fix human-readable parsing failures

2023-01-02 Thread GitBox
weizhouapache commented on PR #7008: URL: https://github.com/apache/cloudstack/pull/7008#issuecomment-1369007757 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [cloudstack] blueorangutan commented on pull request #7008: utils: fix human-readable parsing failures

2023-01-02 Thread GitBox
blueorangutan commented on PR #7008: URL: https://github.com/apache/cloudstack/pull/7008#issuecomment-1369008255 @weizhouapache a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To

[GitHub] [cloudstack] weizhouapache commented on pull request #7029: vm: add Expunged as final VM state and enable expunge VMs in Expunging state

2023-01-02 Thread GitBox
weizhouapache commented on PR #7029: URL: https://github.com/apache/cloudstack/pull/7029#issuecomment-1369008316 @DaanHoogland could you please review this PR ? thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [cloudstack] harikrishna-patnala commented on pull request #6924: [Draft] User two factor authentication

2023-01-02 Thread GitBox
harikrishna-patnala commented on PR #6924: URL: https://github.com/apache/cloudstack/pull/6924#issuecomment-1368865766 Yes @DaanHoogland this is for 4.18 only. Currently this is in queue for testing. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [cloudstack] DaanHoogland closed pull request #6924: [Draft] User two factor authentication

2023-01-02 Thread GitBox
DaanHoogland closed pull request #6924: [Draft] User two factor authentication URL: https://github.com/apache/cloudstack/pull/6924 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #6924: [Draft] User two factor authentication

2023-01-02 Thread GitBox
sonarcloud[bot] commented on PR #6924: URL: https://github.com/apache/cloudstack/pull/6924#issuecomment-1368912478 SonarCloud Quality Gate failed. [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality

[GitHub] [cloudstack] harikrishna-patnala opened a new pull request, #6924: [Draft] User two factor authentication

2023-01-02 Thread GitBox
harikrishna-patnala opened a new pull request, #6924: URL: https://github.com/apache/cloudstack/pull/6924 ### Description This PR introduces a new feature to add support for Two Factor Authentication 2FA in CloudStack. The corresponding documentation PR is at

[GitHub] [cloudstack] DaanHoogland commented on pull request #6918: Override vr service offering

2023-01-02 Thread GitBox
DaanHoogland commented on PR #6918: URL: https://github.com/apache/cloudstack/pull/6918#issuecomment-1368901764 @soreana I haven't had a chance to investigate very deeply yet, but at my laptop it also crashes with ``` [ERROR] Failed to execute goal