[GitHub] [cloudstack] rohityadavcloud commented on pull request #7237: console proxy: use AeadBase64Encryptor instead of AES/CBC/PKCS5Padding

2023-05-08 Thread via GitHub
rohityadavcloud commented on PR #7237: URL: https://github.com/apache/cloudstack/pull/7237#issuecomment-1537874090 @weizhouapache cc @nvazquez @DaanHoogland @shwstppr - is it still relevant, do we need any testing to merge this or can this be merged now? -- This is an automated message

[GitHub] [cloudstack] rohityadavcloud commented on pull request #7160: vmware: do not create vm datastore when attach an existing volume on solidfire

2023-05-08 Thread via GitHub
rohityadavcloud commented on PR #7160: URL: https://github.com/apache/cloudstack/pull/7160#issuecomment-1537875338 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [cloudstack] rohityadavcloud commented on pull request #7009: Ova checksums

2023-05-08 Thread via GitHub
rohityadavcloud commented on PR #7009: URL: https://github.com/apache/cloudstack/pull/7009#issuecomment-1537881051 Thanks @DaanHoogland let's fix this and pull it out of draft then. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [cloudstack] rohityadavcloud commented on issue #6962: Marvin and CloudStack integration tests aren't fully Python v3.9-3.11 compatible

2023-05-08 Thread via GitHub
rohityadavcloud commented on issue #6962: URL: https://github.com/apache/cloudstack/issues/6962#issuecomment-1537880393 Closing the encodestring issue was fixed in https://github.com/apache/cloudstack/pull/7027 -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [cloudstack] rohityadavcloud closed issue #6962: Marvin and CloudStack integration tests aren't fully Python v3.9-3.11 compatible

2023-05-08 Thread via GitHub
rohityadavcloud closed issue #6962: Marvin and CloudStack integration tests aren't fully Python v3.9-3.11 compatible URL: https://github.com/apache/cloudstack/issues/6962 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [cloudstack] rohityadavcloud commented on issue #6818: How to configer advanced zones with cloudstack version 4.13.1, vmware 16

2023-05-08 Thread via GitHub
rohityadavcloud commented on issue #6818: URL: https://github.com/apache/cloudstack/issues/6818#issuecomment-1537899458 Thanks for the question, unless there is a bug you've hit you may refer to the admin guide on https://docs.cloudstack.apache.org/en/latest/adminguide/index.html how to

[GitHub] [cloudstack] rohityadavcloud closed issue #6818: How to configer advanced zones with cloudstack version 4.13.1, vmware 16

2023-05-08 Thread via GitHub
rohityadavcloud closed issue #6818: How to configer advanced zones with cloudstack version 4.13.1, vmware 16 URL: https://github.com/apache/cloudstack/issues/6818 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [cloudstack] codecov[bot] commented on pull request #7489: Flexible tags for hosts and storage pools

2023-05-08 Thread via GitHub
codecov[bot] commented on PR #7489: URL: https://github.com/apache/cloudstack/pull/7489#issuecomment-1537909043 ##

[GitHub] [cloudstack] rohityadavcloud commented on issue #6726: INSTALL.md is incomplete and/or outdated

2023-05-08 Thread via GitHub
rohityadavcloud commented on issue #6726: URL: https://github.com/apache/cloudstack/issues/6726#issuecomment-1537907061 Thanks @mrog we'll schedule this, you're right about unmaintained INSTALL.md. Some of us maintain it here though

[GitHub] [cloudstack] rohityadavcloud commented on issue #7251: Events tab is missing for the following sections

2023-05-08 Thread via GitHub
rohityadavcloud commented on issue #7251: URL: https://github.com/apache/cloudstack/issues/7251#issuecomment-1537933764 @kiranchavala this is a new request, event tab may not be available or applicable for all these places. For example a VM starting on a network could be logged as an event

[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #7499: ui: fix action notifications

2023-05-08 Thread via GitHub
sonarcloud[bot] commented on PR #7499: URL: https://github.com/apache/cloudstack/pull/7499#issuecomment-1537963606 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [cloudstack] blueorangutan commented on pull request #7444: engine-orchestration,vmware: hypervisor migration during start vm migration

2023-05-08 Thread via GitHub
blueorangutan commented on PR #7444: URL: https://github.com/apache/cloudstack/pull/7444#issuecomment-1538052557 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 6041 -- This is an

[GitHub] [cloudstack] soreana commented on issue #7260: It is not possible to make network redundant in the UI

2023-05-08 Thread via GitHub
soreana commented on issue #7260: URL: https://github.com/apache/cloudstack/issues/7260#issuecomment-1538106227 Thanks @weizhouapache and @rohityadavcloud for the feedback. I'm totally agree with you that it is not necessary feature. I will discuss it with my team and get back to

[GitHub] [cloudstack] rohityadavcloud commented on pull request #7499: ui: fix action notifications

2023-05-08 Thread via GitHub
rohityadavcloud commented on PR #7499: URL: https://github.com/apache/cloudstack/pull/7499#issuecomment-1538227235 @blueorangutan ui -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [cloudstack] DaanHoogland commented on pull request #6812: Normalize encryption on global configurations values

2023-05-08 Thread via GitHub
DaanHoogland commented on PR #6812: URL: https://github.com/apache/cloudstack/pull/6812#issuecomment-1538248291 > @DaanHoogland @shwstppr in my opinion, this seems not to be a bug fix, but an improvement. I'd like to move it to 4.19.0.0 milestone, what do you think ? > > cc

[GitHub] [cloudstack] rohityadavcloud commented on pull request #7498: Fix null pointer on PowerFlex attach volume edge case

2023-05-08 Thread via GitHub
rohityadavcloud commented on PR #7498: URL: https://github.com/apache/cloudstack/pull/7498#issuecomment-1537824465 This is only NPE check, simply packaging and github actions tests are enough. @blueorangutan package -- This is an automated message from the Apache Git Service. To

[GitHub] [cloudstack] rohityadavcloud commented on pull request #7381: Fix foreign key constraints and the mysql procedure that is used

2023-05-08 Thread via GitHub
rohityadavcloud commented on PR #7381: URL: https://github.com/apache/cloudstack/pull/7381#issuecomment-1537856623 ping @harikrishna-patnala is this ready, could you address any outstanding comments and advise? Thanks. -- This is an automated message from the Apache Git Service. To

[GitHub] [cloudstack] blueorangutan commented on pull request #7392: Refactoring StorPool's smoke tests

2023-05-08 Thread via GitHub
blueorangutan commented on PR #7392: URL: https://github.com/apache/cloudstack/pull/7392#issuecomment-1537857555 @rohityadavcloud a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[GitHub] [cloudstack] blueorangutan commented on pull request #7499: ui: fix action notifications

2023-05-08 Thread via GitHub
blueorangutan commented on PR #7499: URL: https://github.com/apache/cloudstack/pull/7499#issuecomment-1537889665 @rohityadavcloud a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To

[GitHub] [cloudstack] rohityadavcloud commented on issue #7491: Unable to find management port group Management Network while migrating instances

2023-05-08 Thread via GitHub
rohityadavcloud commented on issue #7491: URL: https://github.com/apache/cloudstack/issues/7491#issuecomment-1537889779 @top-secrett did you restart cloudstack management server as well after the VMware infra was rebooted? -- This is an automated message from the Apache Git Service. To

[GitHub] [cloudstack] rohityadavcloud commented on pull request #7499: ui: fix action notifications

2023-05-08 Thread via GitHub
rohityadavcloud commented on PR #7499: URL: https://github.com/apache/cloudstack/pull/7499#issuecomment-1537888568 @blueorangutan ui -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [cloudstack] blueorangutan commented on pull request #7499: ui: fix action notifications

2023-05-08 Thread via GitHub
blueorangutan commented on PR #7499: URL: https://github.com/apache/cloudstack/pull/7499#issuecomment-1537902409 @shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [cloudstack] rohityadavcloud commented on issue #6950: Cross-account VPC network

2023-05-08 Thread via GitHub
rohityadavcloud commented on issue #6950: URL: https://github.com/apache/cloudstack/issues/6950#issuecomment-1537902613 @elShiaLabeouf you're right, VPCs are owned by accounts. If you require the VPC to be created/used between various accounts you can create such VPCs in projects to which

[GitHub] [cloudstack] rohityadavcloud closed issue #6950: Cross-account VPC network

2023-05-08 Thread via GitHub
rohityadavcloud closed issue #6950: Cross-account VPC network URL: https://github.com/apache/cloudstack/issues/6950 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [cloudstack] rohityadavcloud closed issue #7010: Github Actions Optimisations

2023-05-08 Thread via GitHub
rohityadavcloud closed issue #7010: Github Actions Optimisations URL: https://github.com/apache/cloudstack/issues/7010 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [cloudstack] rohityadavcloud commented on issue #7121: Plugin development

2023-05-08 Thread via GitHub
rohityadavcloud commented on issue #7121: URL: https://github.com/apache/cloudstack/issues/7121#issuecomment-1537920957 Thanks @vinokumark you're right the docs are wrong and refer to legacy UI, you may refer to https://github.com/shapeblue/hackerbook and

[GitHub] [cloudstack] rohityadavcloud commented on issue #7098: failure in test_affinity_groups_projects

2023-05-08 Thread via GitHub
rohityadavcloud commented on issue #7098: URL: https://github.com/apache/cloudstack/issues/7098#issuecomment-1537919782 Looks like is this fixed @DaanHoogland ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [cloudstack] rohityadavcloud commented on issue #7260: It is not possible to make network redundant in the UI

2023-05-08 Thread via GitHub
rohityadavcloud commented on issue #7260: URL: https://github.com/apache/cloudstack/issues/7260#issuecomment-1537937028 Please refer to https://github.com/apache/cloudstack/pull/7405#issuecomment-1537850131 and as others have mentioned https://github.com/apache/cloudstack/issues/4052

[GitHub] [cloudstack] rohityadavcloud commented on issue #7449: Don't run Github Actions jobs on forks and down-stream repos

2023-05-08 Thread via GitHub
rohityadavcloud commented on issue #7449: URL: https://github.com/apache/cloudstack/issues/7449#issuecomment-1537953218 @DaanHoogland can you help fix this? probably needs some kind of if checks on the workflow yamls? -- This is an automated message from the Apache Git Service. To

[GitHub] [cloudstack] rohityadavcloud closed issue #7419: Reporting a vulnerability

2023-05-08 Thread via GitHub
rohityadavcloud closed issue #7419: Reporting a vulnerability URL: https://github.com/apache/cloudstack/issues/7419 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [cloudstack] shwstppr commented on a diff in pull request #7421: api,server: fix VM.CREATE events on vm deploy without start

2023-05-08 Thread via GitHub
shwstppr commented on code in PR #7421: URL: https://github.com/apache/cloudstack/pull/7421#discussion_r1187167772 ## server/src/main/java/com/cloud/vm/UserVmManagerImpl.java: ## @@ -4810,9 +4810,12 @@ protected String validateUserData(String userData, HTTPMethod httpmethod) {

[GitHub] [cloudstack] rohityadavcloud commented on issue #7419: Reporting a vulnerability

2023-05-08 Thread via GitHub
rohityadavcloud commented on issue #7419: URL: https://github.com/apache/cloudstack/issues/7419#issuecomment-1537953843 @igibek This is documented here https://cloudstack.apache.org/security.html Closing as your question has been answered. -- This is an automated message from the

[GitHub] [cloudstack] JoaoJandre commented on pull request #7131: Normalize loggers and upgrade log4j 1.2 to log4j 2.19

2023-05-08 Thread via GitHub
JoaoJandre commented on PR #7131: URL: https://github.com/apache/cloudstack/pull/7131#issuecomment-1538291223 As requested in the devs mailing list, the following script is the one that I'm using to regenerate changes after merging them with the main branch: https://pastebin.com/zzbyhRNG

[GitHub] [cloudstack] rohityadavcloud commented on pull request #7163: fix tools/build/setnextversion.sh: do not update tools/apidoc/pom.xml

2023-05-08 Thread via GitHub
rohityadavcloud commented on PR #7163: URL: https://github.com/apache/cloudstack/pull/7163#issuecomment-1537874956 ping @shwstppr can you verify/test and help merge it? Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [cloudstack] shwstppr opened a new pull request, #7499: ui: fix action notifications

2023-05-08 Thread via GitHub
shwstppr opened a new pull request, #7499: URL: https://github.com/apache/cloudstack/pull/7499 ### Description Some UI actions were missing title and description in pollJob method preventing notification for them to be published. ### Types of changes - [ ] Breaking

[GitHub] [cloudstack] blueorangutan commented on pull request #7160: vmware: do not create vm datastore when attach an existing volume on solidfire

2023-05-08 Thread via GitHub
blueorangutan commented on PR #7160: URL: https://github.com/apache/cloudstack/pull/7160#issuecomment-1537876120 @rohityadavcloud a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[cloudstack] branch main updated (e234c3ccdc7 -> a2561df25b5)

2023-05-08 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/cloudstack.git from e234c3ccdc7 server: guard vm start inter-cluster migration with config (#7401) add 8bbe2f7cb22 engine/schema:

[cloudstack] 01/01: Merge remote-tracking branch 'origin/4.18'

2023-05-08 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/cloudstack.git commit a2561df25b5ef0ae5eaf66be65574996995276e9 Merge: e234c3ccdc7 897dad619b8 Author: Rohit Yadav AuthorDate: Mon May 8

[GitHub] [cloudstack] rohityadavcloud commented on issue #6857: Please add refresh button and add zone button

2023-05-08 Thread via GitHub
rohityadavcloud commented on issue #6857: URL: https://github.com/apache/cloudstack/issues/6857#issuecomment-1537910486 Could be a good improvement. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [cloudstack] blueorangutan commented on pull request #7160: vmware: do not create vm datastore when attach an existing volume on solidfire

2023-05-08 Thread via GitHub
blueorangutan commented on PR #7160: URL: https://github.com/apache/cloudstack/pull/7160#issuecomment-1537943066 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 6040 -- This is an

[GitHub] [cloudstack] blueorangutan commented on pull request #7499: ui: fix action notifications

2023-05-08 Thread via GitHub
blueorangutan commented on PR #7499: URL: https://github.com/apache/cloudstack/pull/7499#issuecomment-1537958463 @rohityadavcloud a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To

[cloudstack] branch main updated: .asf: grant triaging role access to frequent contributors

2023-05-08 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/main by this push: new 4243afbf04b .asf: grant triaging role access to

[GitHub] [cloudstack] weizhouapache commented on a diff in pull request #7485: engine-storage: fix errored template becomes active

2023-05-08 Thread via GitHub
weizhouapache commented on code in PR #7485: URL: https://github.com/apache/cloudstack/pull/7485#discussion_r1187234971 ## engine/storage/image/src/main/java/org/apache/cloudstack/storage/image/TemplateServiceImpl.java: ## @@ -286,6 +286,23 @@ public void

[GitHub] [cloudstack] blueorangutan commented on pull request #7444: engine-orchestration,vmware: hypervisor migration during start vm migration

2023-05-08 Thread via GitHub
blueorangutan commented on PR #7444: URL: https://github.com/apache/cloudstack/pull/7444#issuecomment-1538119737 @shwstppr a Trillian-Jenkins matrix job (centos7 mgmt + xenserver71, rocky8 mgmt + vmware67u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests -- This is an

[GitHub] [cloudstack] blueorangutan commented on pull request #7265: VR: do not restart conntrackd if no guest networks

2023-05-08 Thread via GitHub
blueorangutan commented on PR #7265: URL: https://github.com/apache/cloudstack/pull/7265#issuecomment-1538236848 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 6043 -- This is an

[GitHub] [cloudstack] blueorangutan commented on pull request #7404: Storage and volumes statistics tasks for StorPool primary storage

2023-05-08 Thread via GitHub
blueorangutan commented on PR #7404: URL: https://github.com/apache/cloudstack/pull/7404#issuecomment-1538243147 @DaanHoogland a Trillian-Jenkins matrix job (centos7 mgmt + xenserver71, rocky8 mgmt + vmware67u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests -- This is an

[GitHub] [cloudstack] weizhouapache closed issue #7196: systemvm/VR Volumes left in Destroy state after pool set to maintenance

2023-05-08 Thread via GitHub
weizhouapache closed issue #7196: systemvm/VR Volumes left in Destroy state after pool set to maintenance URL: https://github.com/apache/cloudstack/issues/7196 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [cloudstack] weizhouapache commented on issue #7196: systemvm/VR Volumes left in Destroy state after pool set to maintenance

2023-05-08 Thread via GitHub
weizhouapache commented on issue #7196: URL: https://github.com/apache/cloudstack/issues/7196#issuecomment-1538242840 this cannot be reproduced, closing it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [cloudstack] DaanHoogland commented on pull request #7404: Storage and volumes statistics tasks for StorPool primary storage

2023-05-08 Thread via GitHub
DaanHoogland commented on PR #7404: URL: https://github.com/apache/cloudstack/pull/7404#issuecomment-1538242619 @blueorangutan test matrix -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [cloudstack] blueorangutan commented on pull request #7265: VR: do not restart conntrackd if no guest networks

2023-05-08 Thread via GitHub
blueorangutan commented on PR #7265: URL: https://github.com/apache/cloudstack/pull/7265#issuecomment-1538278112 Trillian Build Failed (tid-6519) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[cloudstack-www] branch docusaurus-staging updated (4f65584f -> 7f497b40)

2023-05-08 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a change to branch docusaurus-staging in repository https://gitbox.apache.org/repos/asf/cloudstack-www.git from 4f65584f cmk update add 7f497b40 make blog single CTA No new revisions were added by this

[GitHub] [cloudstack] rohityadavcloud commented on pull request #7494: Fix direct download certificate check initial delay

2023-05-08 Thread via GitHub
rohityadavcloud commented on PR #7494: URL: https://github.com/apache/cloudstack/pull/7494#issuecomment-1537833732 Actually for the line changes, packaging tests and the github actions based smoke/component tests are enough. Thanks @mlsorensen for the fix. -- This is an automated message

[cloudstack] branch 4.18 updated: server: Fix DirectDownload certificate check initial delay (#7494)

2023-05-08 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a commit to branch 4.18 in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/4.18 by this push: new 8604cb53281 server: Fix DirectDownload

[GitHub] [cloudstack] rohityadavcloud merged pull request #7494: Fix direct download certificate check initial delay

2023-05-08 Thread via GitHub
rohityadavcloud merged PR #7494: URL: https://github.com/apache/cloudstack/pull/7494 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [cloudstack] blueorangutan commented on pull request #7404: Storage and volumes statistics tasks for StorPool primary storage

2023-05-08 Thread via GitHub
blueorangutan commented on PR #7404: URL: https://github.com/apache/cloudstack/pull/7404#issuecomment-1537852456 @rohityadavcloud a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[GitHub] [cloudstack] rohityadavcloud commented on pull request #7404: Storage and volumes statistics tasks for StorPool primary storage

2023-05-08 Thread via GitHub
rohityadavcloud commented on PR #7404: URL: https://github.com/apache/cloudstack/pull/7404#issuecomment-1537851777 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [cloudstack] rohityadavcloud commented on a diff in pull request #7485: engine-storage: fix errored template becomes active

2023-05-08 Thread via GitHub
rohityadavcloud commented on code in PR #7485: URL: https://github.com/apache/cloudstack/pull/7485#discussion_r1187097668 ## engine/storage/image/src/test/java/org/apache/cloudstack/storage/image/TemplateServiceImplTest.java: ## @@ -0,0 +1,84 @@ +/* + * Licensed to the Apache

[GitHub] [cloudstack] rohityadavcloud closed issue #6932: Usage problem: Is there another way besides "Setting Up a Site-to-Site VPN Connection" ?

2023-05-08 Thread via GitHub
rohityadavcloud closed issue #6932: Usage problem: Is there another way besides "Setting Up a Site-to-Site VPN Connection" ? URL: https://github.com/apache/cloudstack/issues/6932 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [cloudstack] rohityadavcloud commented on issue #6932: Usage problem: Is there another way besides "Setting Up a Site-to-Site VPN Connection" ?

2023-05-08 Thread via GitHub
rohityadavcloud commented on issue #6932: URL: https://github.com/apache/cloudstack/issues/6932#issuecomment-1537900732 @xuanyuanaosheng without proper description of your issue we can't advise. If the issue is about connectivity across regions/zones in VPCs, then both site-to-site VPN and

[GitHub] [cloudstack] rohityadavcloud closed issue #7295: How to achieve connectivity between different VPCs under different zones in CloudStack?

2023-05-08 Thread via GitHub
rohityadavcloud closed issue #7295: How to achieve connectivity between different VPCs under different zones in CloudStack? URL: https://github.com/apache/cloudstack/issues/7295 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [cloudstack] rohityadavcloud commented on issue #7295: How to achieve connectivity between different VPCs under different zones in CloudStack?

2023-05-08 Thread via GitHub
rohityadavcloud commented on issue #7295: URL: https://github.com/apache/cloudstack/issues/7295#issuecomment-1537916545 @xuanyuanaosheng as you've figured, the two popular ways are site-to-site VPN between two VPCs, or using private gateways and static routes. If you've already figured

[GitHub] [cloudstack] rohityadavcloud commented on issue #7138: No secondary storage VM for downloading template to image store

2023-05-08 Thread via GitHub
rohityadavcloud commented on issue #7138: URL: https://github.com/apache/cloudstack/issues/7138#issuecomment-1537924894 @mail2lawi sorry to hear your feedback, could you refer to one of these guides: https://docs.cloudstack.apache.org/en/latest/quickinstallationguide/qig.html

[GitHub] [cloudstack] weizhouapache commented on pull request #6812: Normalize encryption on global configurations values

2023-05-08 Thread via GitHub
weizhouapache commented on PR #6812: URL: https://github.com/apache/cloudstack/pull/6812#issuecomment-1537924320 great, thank for the update. @BryanMLima > I got some time to work on this one again, and now I could understand what you meant @weizhouapache. I added the

[GitHub] [cloudstack] rohityadavcloud closed issue #7138: No secondary storage VM for downloading template to image store

2023-05-08 Thread via GitHub
rohityadavcloud closed issue #7138: No secondary storage VM for downloading template to image store URL: https://github.com/apache/cloudstack/issues/7138 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [cloudstack] rohityadavcloud commented on issue #7280: CloudStack should support Selinux

2023-05-08 Thread via GitHub
rohityadavcloud commented on issue #7280: URL: https://github.com/apache/cloudstack/issues/7280#issuecomment-1537947267 @kiwiflyer we kind of do, but much of the selinux work requires operators/admin to define the rules. Here's an example of te file for cloud-agent pkg (cloudstack-agent

[GitHub] [cloudstack] blueorangutan commented on pull request #7444: engine-orchestration,vmware: hypervisor migration during start vm migration

2023-05-08 Thread via GitHub
blueorangutan commented on PR #7444: URL: https://github.com/apache/cloudstack/pull/7444#issuecomment-1537972899 @shwstppr a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. --

[GitHub] [cloudstack] weizhouapache commented on a diff in pull request #7265: VR: do not restart conntrackd if no guest networks

2023-05-08 Thread via GitHub
weizhouapache commented on code in PR #7265: URL: https://github.com/apache/cloudstack/pull/7265#discussion_r1187302976 ## systemvm/debian/opt/cloud/bin/cs/CsRedundant.py: ## @@ -282,7 +281,10 @@ def set_backup(self): self._remove_ipv6_guest_gateway() -

[GitHub] [cloudstack] weizhouapache merged pull request #7163: fix tools/build/setnextversion.sh: do not update tools/apidoc/pom.xml

2023-05-08 Thread via GitHub
weizhouapache merged PR #7163: URL: https://github.com/apache/cloudstack/pull/7163 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[cloudstack] branch 4.17 updated: fix tools/build/setnextversion.sh: do not update tools/apidoc/pom.xml (#7163)

2023-05-08 Thread weizhou
This is an automated email from the ASF dual-hosted git repository. weizhou pushed a commit to branch 4.17 in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/4.17 by this push: new ea2b5379850 fix tools/build/setnextversion.sh:

[GitHub] [cloudstack] blueorangutan commented on pull request #6442: Possibility to choose the source NAT IP address on a isolated network or VPC

2023-05-08 Thread via GitHub
blueorangutan commented on PR #6442: URL: https://github.com/apache/cloudstack/pull/6442#issuecomment-1538178083 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 6042 -- This is an

[GitHub] [cloudstack] rohityadavcloud commented on a diff in pull request #7160: vmware: do not create vm datastore when attach an existing volume on solidfire

2023-05-08 Thread via GitHub
rohityadavcloud commented on code in PR #7160: URL: https://github.com/apache/cloudstack/pull/7160#discussion_r1187360547 ## plugins/hypervisors/vmware/src/main/java/com/cloud/storage/resource/VmwareStorageProcessor.java: ## @@ -2822,7 +2822,10 @@ private ManagedObjectReference

[GitHub] [cloudstack] rohityadavcloud commented on a diff in pull request #7421: api,server: fix VM.CREATE events on vm deploy without start

2023-05-08 Thread via GitHub
rohityadavcloud commented on code in PR #7421: URL: https://github.com/apache/cloudstack/pull/7421#discussion_r1187098432 ## server/src/main/java/com/cloud/vm/UserVmManagerImpl.java: ## @@ -4810,9 +4810,12 @@ protected String validateUserData(String userData, HTTPMethod

[GitHub] [cloudstack] rohityadavcloud commented on pull request #7264: ssvm: continue with other secondary storages if fails to program a secondary storage

2023-05-08 Thread via GitHub
rohityadavcloud commented on PR #7264: URL: https://github.com/apache/cloudstack/pull/7264#issuecomment-1537872750 is this good to merge or we need any testing @weizhouapache @DaanHoogland ? -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [cloudstack] rohityadavcloud commented on pull request #5938: [Draft] VR: remove old json config when start vmware/xenserver VPC VRs

2023-05-08 Thread via GitHub
rohityadavcloud commented on PR #5938: URL: https://github.com/apache/cloudstack/pull/5938#issuecomment-1537884036 @weizhouapache is this still relevant, or the issue has been addressed (or doesn't need to be addressed)? -- This is an automated message from the Apache Git Service. To

[GitHub] [cloudstack] shwstppr commented on pull request #7499: ui: fix action notifications

2023-05-08 Thread via GitHub
shwstppr commented on PR #7499: URL: https://github.com/apache/cloudstack/pull/7499#issuecomment-1537902047 @blueorangutan ui -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [cloudstack] codecov[bot] commented on pull request #7488: [Enhancement] removed commented code in DhcpProtocolParserServer.java

2023-05-08 Thread via GitHub
codecov[bot] commented on PR #7488: URL: https://github.com/apache/cloudstack/pull/7488#issuecomment-1537913013 ##

[GitHub] [cloudstack] rohityadavcloud commented on issue #7278: Unable to order the ISO/templates in the UI

2023-05-08 Thread via GitHub
rohityadavcloud commented on issue #7278: URL: https://github.com/apache/cloudstack/issues/7278#issuecomment-1537946160 @shwstppr we need to check if it's the UI or API that's broken or re-test and close if we can't rperoduce. Certinaly works for me in 4.17.2. -- This is an automated

[GitHub] [cloudstack] shwstppr commented on pull request #7444: engine-orchestration,vmware: hypervisor migration during start vm migration

2023-05-08 Thread via GitHub
shwstppr commented on PR #7444: URL: https://github.com/apache/cloudstack/pull/7444#issuecomment-1537970015 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [cloudstack] rohityadavcloud commented on pull request #7499: ui: fix action notifications

2023-05-08 Thread via GitHub
rohityadavcloud commented on PR #7499: URL: https://github.com/apache/cloudstack/pull/7499#issuecomment-1538263468 It appears there was a disk space issue, thnx for raising this @shwstppr I'll add some monitoring on the community QA server soon. -- This is an automated message from the

[cloudstack] branch 4.18 updated (897dad619b8 -> 88ff77dae10)

2023-05-08 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a change to branch 4.18 in repository https://gitbox.apache.org/repos/asf/cloudstack.git from 897dad619b8 marvin: replace encodestring for encodebytes (#7027) add 88ff77dae10 ui: fix action notifications

[GitHub] [cloudstack] rohityadavcloud merged pull request #7499: ui: fix action notifications

2023-05-08 Thread via GitHub
rohityadavcloud merged PR #7499: URL: https://github.com/apache/cloudstack/pull/7499 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [cloudstack] blueorangutan commented on pull request #7265: VR: do not restart conntrackd if no guest networks

2023-05-08 Thread via GitHub
blueorangutan commented on PR #7265: URL: https://github.com/apache/cloudstack/pull/7265#issuecomment-1538274100 @weizhouapache a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To

[GitHub] [cloudstack] rohityadavcloud commented on a diff in pull request #7486: [MINOR][Enhancement] improved concatenation way in PropertiesStorage.java

2023-05-08 Thread via GitHub
rohityadavcloud commented on code in PR #7486: URL: https://github.com/apache/cloudstack/pull/7486#discussion_r1187079958 ## agent/src/main/java/com/cloud/agent/dao/impl/PropertiesStorage.java: ## @@ -92,11 +92,11 @@ public synchronized boolean configure(String name, Map

[GitHub] [cloudstack] rohityadavcloud commented on pull request #7405: Enable defining a network as redundant during restart through the UI

2023-05-08 Thread via GitHub
rohityadavcloud commented on PR #7405: URL: https://github.com/apache/cloudstack/pull/7405#issuecomment-1537850131 Sorry -1, we had a conversation in the past. In fact this feature never had existed, until I had put it in. After discussions and feedback from users esp service providers, we

[cloudstack] branch 4.18 updated: marvin: replace encodestring for encodebytes (#7027)

2023-05-08 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a commit to branch 4.18 in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/4.18 by this push: new 897dad619b8 marvin: replace encodestring for

[GitHub] [cloudstack] rohityadavcloud merged pull request #7027: python 3.9 comptibility fixes

2023-05-08 Thread via GitHub
rohityadavcloud merged PR #7027: URL: https://github.com/apache/cloudstack/pull/7027 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [cloudstack] blueorangutan commented on pull request #7392: Refactoring StorPool's smoke tests

2023-05-08 Thread via GitHub
blueorangutan commented on PR #7392: URL: https://github.com/apache/cloudstack/pull/7392#issuecomment-1537923939 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 6039 -- This is an

[GitHub] [cloudstack] codecov[bot] commented on pull request #7499: ui: fix action notifications

2023-05-08 Thread via GitHub
codecov[bot] commented on PR #7499: URL: https://github.com/apache/cloudstack/pull/7499#issuecomment-1537955161 ##

[GitHub] [cloudstack] DaanHoogland commented on a diff in pull request #7153: Introducing concept of domain VPCs

2023-05-08 Thread via GitHub
DaanHoogland commented on code in PR #7153: URL: https://github.com/apache/cloudstack/pull/7153#discussion_r1187176420 ## server/src/main/java/com/cloud/network/IpAddressManagerImpl.java: ## @@ -1476,7 +1476,8 @@ public IPAddressVO associateIPToGuestNetwork(long ipId, long

[GitHub] [cloudstack] blueorangutan commented on pull request #7499: ui: fix action notifications

2023-05-08 Thread via GitHub
blueorangutan commented on PR #7499: URL: https://github.com/apache/cloudstack/pull/7499#issuecomment-1537965370 UI build failed: :heavy_multiplication_x: (SL-JID-100) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [cloudstack] DaanHoogland commented on a diff in pull request #7265: VR: do not restart conntrackd if no guest networks

2023-05-08 Thread via GitHub
DaanHoogland commented on code in PR #7265: URL: https://github.com/apache/cloudstack/pull/7265#discussion_r1187270808 ## systemvm/debian/opt/cloud/bin/cs/CsRedundant.py: ## @@ -282,7 +281,10 @@ def set_backup(self): self._remove_ipv6_guest_gateway() -

[GitHub] [cloudstack] shwstppr commented on pull request #7444: engine-orchestration,vmware: hypervisor migration during start vm migration

2023-05-08 Thread via GitHub
shwstppr commented on PR #7444: URL: https://github.com/apache/cloudstack/pull/7444#issuecomment-1538117044 @blueorangutan test matrix -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [cloudstack] blueorangutan commented on pull request #7499: ui: fix action notifications

2023-05-08 Thread via GitHub
blueorangutan commented on PR #7499: URL: https://github.com/apache/cloudstack/pull/7499#issuecomment-1538227924 @rohityadavcloud a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To

[GitHub] [cloudstack] blueorangutan commented on pull request #6442: Possibility to choose the source NAT IP address on a isolated network or VPC

2023-05-08 Thread via GitHub
blueorangutan commented on PR #6442: URL: https://github.com/apache/cloudstack/pull/6442#issuecomment-1538342690 Trillian Build Failed (tid-6520) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [cloudstack] blueorangutan commented on pull request #7494: Fix direct download certificate check initial delay

2023-05-08 Thread via GitHub
blueorangutan commented on PR #7494: URL: https://github.com/apache/cloudstack/pull/7494#issuecomment-1537826183 @rohityadavcloud a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To

[GitHub] [cloudstack] blueorangutan commented on pull request #7498: Fix null pointer on PowerFlex attach volume edge case

2023-05-08 Thread via GitHub
blueorangutan commented on PR #7498: URL: https://github.com/apache/cloudstack/pull/7498#issuecomment-1537826221 @rohityadavcloud a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[GitHub] [cloudstack] rohityadavcloud merged pull request #7482: Qemu migration hook: check for source length before using element 0

2023-05-08 Thread via GitHub
rohityadavcloud merged PR #7482: URL: https://github.com/apache/cloudstack/pull/7482 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[cloudstack] branch 4.18 updated: Qemu migration hook: check for source length before using element 0 (#7482)

2023-05-08 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a commit to branch 4.18 in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/4.18 by this push: new bdd53633148 Qemu migration hook: check for

[GitHub] [cloudstack] rohityadavcloud commented on pull request #7494: Fix direct download certificate check initial delay

2023-05-08 Thread via GitHub
rohityadavcloud commented on PR #7494: URL: https://github.com/apache/cloudstack/pull/7494#issuecomment-1537825300 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [cloudstack] rohityadavcloud commented on a diff in pull request #7416: remove supportedOwner from Resource.ResourceType

2023-05-08 Thread via GitHub
rohityadavcloud commented on code in PR #7416: URL: https://github.com/apache/cloudstack/pull/7416#discussion_r1187088983 ## api/src/main/java/com/cloud/configuration/Resource.java: ## @@ -22,55 +22,34 @@ public interface Resource { String UNLIMITED = "Unlimited";

  1   2   >