Re: [PR] Ability to specify NFS mount options while adding a primary storage and modify them on a pre-existing primary storage [cloudstack]

2024-04-24 Thread via GitHub
abh1sar commented on code in PR #8947: URL: https://github.com/apache/cloudstack/pull/8947#discussion_r1577320634 ## plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtStoragePoolDef.java: ## @@ -124,10 +138,17 @@ public AuthenticationType

Re: [PR] Ability to specify NFS mount options while adding a primary storage and modify them on a pre-existing primary storage [cloudstack]

2024-04-24 Thread via GitHub
abh1sar commented on code in PR #8947: URL: https://github.com/apache/cloudstack/pull/8947#discussion_r1577321008 ## plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/LibvirtStorageAdaptor.java: ## @@ -654,20 +654,54 @@ public KVMStoragePool

Re: [PR] Ability to specify NFS mount options while adding a primary storage and modify them on a pre-existing primary storage [cloudstack]

2024-04-24 Thread via GitHub
abh1sar commented on code in PR #8947: URL: https://github.com/apache/cloudstack/pull/8947#discussion_r1577321283 ## server/src/main/java/com/cloud/api/query/QueryManagerImpl.java: ## @@ -2994,6 +2994,11 @@ private ListResponse createStoragesPoolResponse(Pair

Re: [PR] cleanup some smoke tests [cloudstack]

2024-04-24 Thread via GitHub
DaanHoogland commented on code in PR #8196: URL: https://github.com/apache/cloudstack/pull/8196#discussion_r1577343767 ## test/integration/smoke/test_primary_storage.py: ## @@ -156,14 +150,17 @@ def test_01_primary_storage_nfs(self): storage_response.type,

Re: [PR] Updates to HPE-Primera and Pure FlashArray Drivers to use Host-based VLUN Assignments [cloudstack]

2024-04-24 Thread via GitHub
blueorangutan commented on PR #8889: URL: https://github.com/apache/cloudstack/pull/8889#issuecomment-2074185916 @DaanHoogland a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To

Re: [PR] Fixup resource limit checks [cloudstack]

2024-04-24 Thread via GitHub
blueorangutan commented on PR #8935: URL: https://github.com/apache/cloudstack/pull/8935#issuecomment-2074186005 @vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Re: [PR] Fixup listing of serivce offering & storagepools with tags [cloudstack]

2024-04-24 Thread via GitHub
blueorangutan commented on PR #8937: URL: https://github.com/apache/cloudstack/pull/8937#issuecomment-2074186063 @vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Re: [PR] Updates to HPE-Primera and Pure FlashArray Drivers to use Host-based VLUN Assignments [cloudstack]

2024-04-24 Thread via GitHub
DaanHoogland commented on PR #8889: URL: https://github.com/apache/cloudstack/pull/8889#issuecomment-2074186775 @harikrishna-patnala @rp- @slavkap , can you please review? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] Ability to specify NFS mount options while adding a primary storage and modify them on a pre-existing primary storage [cloudstack]

2024-04-24 Thread via GitHub
abh1sar commented on code in PR #8947: URL: https://github.com/apache/cloudstack/pull/8947#discussion_r1577319088 ## api/src/main/java/org/apache/cloudstack/api/response/StoragePoolResponse.java: ## @@ -101,6 +101,10 @@ public class StoragePoolResponse extends

Re: [PR] Ability to specify NFS mount options while adding a primary storage and modify them on a pre-existing primary storage [cloudstack]

2024-04-24 Thread via GitHub
abh1sar commented on code in PR #8947: URL: https://github.com/apache/cloudstack/pull/8947#discussion_r1577319326 ## api/src/main/java/org/apache/cloudstack/api/response/StoragePoolResponse.java: ## @@ -101,6 +101,10 @@ public class StoragePoolResponse extends

Re: [PR] Ability to specify NFS mount options while adding a primary storage and modify them on a pre-existing primary storage [cloudstack]

2024-04-24 Thread via GitHub
abh1sar commented on code in PR #8947: URL: https://github.com/apache/cloudstack/pull/8947#discussion_r1577323243 ## ui/src/config/section/infra/primaryStorages.js: ## @@ -109,6 +109,16 @@ export default { defaultArgs: { enabled: true }, show: (record) => { return

Re: [PR] Ability to specify NFS mount options while adding a primary storage and modify them on a pre-existing primary storage [cloudstack]

2024-04-24 Thread via GitHub
abh1sar commented on PR #8947: URL: https://github.com/apache/cloudstack/pull/8947#issuecomment-2074164098 @sureshanaparti @harikrishna-patnala @shwstppr have addressed all review comments. Will raise a documentation PR shortly. -- This is an automated message from the Apache Git

Re: [PR] Updates to HPE-Primera and Pure FlashArray Drivers to use Host-based VLUN Assignments [cloudstack]

2024-04-24 Thread via GitHub
DaanHoogland commented on PR #8889: URL: https://github.com/apache/cloudstack/pull/8889#issuecomment-2074184247 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Ability to specify NFS mount options while adding a primary storage and modify them on a pre-existing primary storage [cloudstack]

2024-04-24 Thread via GitHub
abh1sar commented on code in PR #8947: URL: https://github.com/apache/cloudstack/pull/8947#discussion_r1577322814 ## ui/public/locales/en.json: ## @@ -3184,6 +3188,7 @@ "message.success.disable.saml.auth": "Successfully disabled SAML authorization",

Re: [PR] Ability to specify NFS mount options while adding a primary storage and modify them on a pre-existing primary storage [cloudstack]

2024-04-24 Thread via GitHub
abh1sar commented on code in PR #8947: URL: https://github.com/apache/cloudstack/pull/8947#discussion_r1577321600 ## server/src/main/java/com/cloud/storage/StorageManagerImpl.java: ## @@ -903,6 +918,20 @@ public PrimaryDataStoreInfo createPool(CreateStoragePoolCmd cmd) throws

Re: [PR] Ability to specify NFS mount options while adding a primary storage and modify them on a pre-existing primary storage [cloudstack]

2024-04-24 Thread via GitHub
abh1sar commented on code in PR #8947: URL: https://github.com/apache/cloudstack/pull/8947#discussion_r1577321806 ## server/src/main/java/com/cloud/storage/StorageManagerImpl.java: ## @@ -1085,6 +1114,24 @@ public PrimaryDataStoreInfo updateStoragePool(UpdateStoragePoolCmd

Re: [PR] Ability to specify NFS mount options while adding a primary storage and modify them on a pre-existing primary storage [cloudstack]

2024-04-24 Thread via GitHub
abh1sar commented on code in PR #8947: URL: https://github.com/apache/cloudstack/pull/8947#discussion_r1577322261 ## ui/public/locales/en.json: ## @@ -2440,6 +2442,7 @@ "message.action.disable.zone": "Please confirm that you want to disable this zone.",

Re: [PR] Ability to specify NFS mount options while adding a primary storage and modify them on a pre-existing primary storage [cloudstack]

2024-04-24 Thread via GitHub
abh1sar commented on code in PR #8947: URL: https://github.com/apache/cloudstack/pull/8947#discussion_r1577328091 ## ui/src/config/section/infra/primaryStorages.js: ## @@ -34,7 +34,7 @@ export default { fields.push('zonename') return fields }, - details: ['name',

Re: [PR] Fixup listing of serivce offering & storagepools with tags [cloudstack]

2024-04-24 Thread via GitHub
vishesh92 commented on PR #8937: URL: https://github.com/apache/cloudstack/pull/8937#issuecomment-2074182293 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Fixup resource limit checks [cloudstack]

2024-04-24 Thread via GitHub
vishesh92 commented on PR #8935: URL: https://github.com/apache/cloudstack/pull/8935#issuecomment-2074182544 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Fix link to removed volumes being shown in info card [cloudstack]

2024-04-24 Thread via GitHub
DaanHoogland commented on PR #8833: URL: https://github.com/apache/cloudstack/pull/8833#issuecomment-2074182760 @winterhazel , I marked this for 4.20 now as it is targeted for main. Do you want this in 4.19? -- This is an automated message from the Apache Git Service. To respond to the

Re: [I] IP address conflicts held by public IPs of virtual routers [cloudstack]

2024-04-24 Thread via GitHub
DaanHoogland commented on issue #8967: URL: https://github.com/apache/cloudstack/issues/8967#issuecomment-2074616301 thanks @vdombrovski , this will (obviously) be hard to reproduce in a lab environment. the true/false flag of the databag should ensure that IPs are removed, so it not being

Re: [PR] upgrade: move 4.19.0->4.20.0 to 4.19.1->4.20.0 [cloudstack]

2024-04-24 Thread via GitHub
blueorangutan commented on PR #8893: URL: https://github.com/apache/cloudstack/pull/8893#issuecomment-2074617598 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9396 -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] extract host from websocket to add route [cloudstack]

2024-04-24 Thread via GitHub
blueorangutan commented on PR #8922: URL: https://github.com/apache/cloudstack/pull/8922#issuecomment-2074738071 @DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make

Re: [PR] [UI] Add option to specify account/project while deploying VMs and creating networks [cloudstack]

2024-04-24 Thread via GitHub
BryanMLima commented on PR #8919: URL: https://github.com/apache/cloudstack/pull/8919#issuecomment-2074876643 > @BryanMLima looks good, one issue; if I choose to create in domain A user a and then choose to create a network in domain B I get an error. This makes sense but the error looks

Re: [PR] VR: fix dnmasq misconfiguration if there are multiple IP ranges in a shared network [cloudstack]

2024-04-24 Thread via GitHub
weizhouapache merged PR #8741: URL: https://github.com/apache/cloudstack/pull/8741 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

(cloudstack) branch 4.18 updated: VR: fix dnmasq misconfiguration if there are multiple IP ranges in a shared network (#8741)

2024-04-24 Thread weizhou
This is an automated email from the ASF dual-hosted git repository. weizhou pushed a commit to branch 4.18 in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/4.18 by this push: new 3b0e6ac90c0 VR: fix dnmasq misconfiguration if

Re: [PR] prevent an NPE on an uninitialised TemplateObject [cloudstack]

2024-04-24 Thread via GitHub
DaanHoogland commented on PR #8898: URL: https://github.com/apache/cloudstack/pull/8898#issuecomment-2074903024 > [SF] Trillian test result (tid-9945) Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server r8 Total time taken: 64704 seconds Marvin logs:

Re: [PR] VR: fix dnmasq misconfiguration if there are multiple IP ranges in a shared network [cloudstack]

2024-04-24 Thread via GitHub
ccycv commented on PR #8741: URL: https://github.com/apache/cloudstack/pull/8741#issuecomment-2074928729 > > > > dhcp-option=eth0,26,1500 > > > > > > > > > @ccycv You tested with the changes in this PR, right ? just to confirm > > > > > > Yes, with this PR > >

Re: [PR] GUI whitelabel runtime system [cloudstack]

2024-04-24 Thread via GitHub
codecov-commenter commented on PR #8942: URL: https://github.com/apache/cloudstack/pull/8942#issuecomment-2074933254 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/8942?dropdown=coverage=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)

Re: [PR] Extra parameter for UpdateImageStore [cloudstack]

2024-04-24 Thread via GitHub
DaanHoogland commented on PR #8941: URL: https://github.com/apache/cloudstack/pull/8941#issuecomment-2074956101 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [I] KVM Incremental Snapshots/Backups [cloudstack]

2024-04-24 Thread via GitHub
JoaoJandre commented on issue #8907: URL: https://github.com/apache/cloudstack/issues/8907#issuecomment-2074978778 > > > Ok, one more, will coalescing of snapshots on secondary be implemented at all? (and do we think we need it?) > > > > > > I don't see a reason to coalesce

Re: [PR] framework/db: introduce a new MySQL table based distributed lock [cloudstack]

2024-04-24 Thread via GitHub
rohityadavcloud commented on PR #8968: URL: https://github.com/apache/cloudstack/pull/8968#issuecomment-2074980538 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Fixup listing of serivce offering & storagepools with tags [cloudstack]

2024-04-24 Thread via GitHub
blueorangutan commented on PR #8937: URL: https://github.com/apache/cloudstack/pull/8937#issuecomment-2074672416 @borisstoyanov a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To

Re: [I] problem on adding new node to kubernetes [cloudstack]

2024-04-24 Thread via GitHub
weizhouapache commented on issue #8943: URL: https://github.com/apache/cloudstack/issues/8943#issuecomment-2074681059 > we have 4.19.0.1, so we have to wait 4.19.1 release i'm afraid you can cherry-pick the commit to 4.19.0.1, build the packages and deploy it. @ugenk cloudstack

Re: [I] PKIX path building failed when trying to add a host to the cluster with HTTPS linstor [cloudstack]

2024-04-24 Thread via GitHub
rp- commented on issue #8963: URL: https://github.com/apache/cloudstack/issues/8963#issuecomment-2074676097 this is the first request for this, I didn't have it on my TODO list. I can add it, but certainly low priority. -- This is an automated message from the Apache Git Service. To

Re: [I] PKIX path building failed when trying to add a host to the cluster with HTTPS linstor [cloudstack]

2024-04-24 Thread via GitHub
DaanHoogland commented on issue #8963: URL: https://github.com/apache/cloudstack/issues/8963#issuecomment-2074726714 > this is the first request for this, I didn't have it on my TODO list. I can add it, but certainly low priority. I'm not trying to tell you what to do @rp- , just

Re: [I] KVM Incremental Snapshots/Backups [cloudstack]

2024-04-24 Thread via GitHub
JoaoJandre commented on issue #8907: URL: https://github.com/apache/cloudstack/issues/8907#issuecomment-2074769237 > Ok, one more, will coalescing of snapshots on secondary be implemented at all? (and do we think we need it?) I don't see a reason to coalesce snapshots on secondary.

Re: [PR] Fix ordering of secondary storages with the algorithm `firstfitleastconsumed` [cloudstack]

2024-04-24 Thread via GitHub
BryanMLima commented on PR #8557: URL: https://github.com/apache/cloudstack/pull/8557#issuecomment-2074988854 @sureshanaparti could you trigger the CI here? cc @DaanHoogland -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] [UI] Add option to specify account/project while deploying VMs and creating networks [cloudstack]

2024-04-24 Thread via GitHub
blueorangutan commented on PR #8919: URL: https://github.com/apache/cloudstack/pull/8919#issuecomment-2075123702 [SF] Trillian Build Failed (tid-9988) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] VR: fix dnmasq misconfiguration if there are multiple IP ranges in a shared network [cloudstack]

2024-04-24 Thread via GitHub
blueorangutan commented on PR #8741: URL: https://github.com/apache/cloudstack/pull/8741#issuecomment-2074551964 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9393 -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] Change storage pool scope from Cluster to Zone and vise versa [cloudstack]

2024-04-24 Thread via GitHub
shwstppr commented on code in PR #8875: URL: https://github.com/apache/cloudstack/pull/8875#discussion_r1577642488 ## test/integration/smoke/test_primary_storage.py: ## @@ -372,8 +372,6 @@ def __init__(self): "a": "NFS-A", "b": "NFS-B" } - -

Re: [PR] Fix KVM live migration with NFS volumes [cloudstack]

2024-04-24 Thread via GitHub
blueorangutan commented on PR #8952: URL: https://github.com/apache/cloudstack/pull/8952#issuecomment-2074691381 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9397 -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] Fix KVM live migration with NFS volumes [cloudstack]

2024-04-24 Thread via GitHub
blueorangutan commented on PR #8952: URL: https://github.com/apache/cloudstack/pull/8952#issuecomment-2074714079 @DaanHoogland a [SL] Trillian-Jenkins test job (rocky8 mgmt + kvm-rocky8) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To

Re: [PR] Update en.json [cloudstack]

2024-04-24 Thread via GitHub
blueorangutan commented on PR #8958: URL: https://github.com/apache/cloudstack/pull/8958#issuecomment-2074714117 UI build: :heavy_check_mark: Live QA URL: https://qa.cloudstack.cloud/simulator/pr/8958 (QA-JID-320) -- This is an automated message from the Apache Git Service. To respond

Re: [PR] New feature: Implicit host tags [cloudstack]

2024-04-24 Thread via GitHub
blueorangutan commented on PR #8929: URL: https://github.com/apache/cloudstack/pull/8929#issuecomment-2074755037 @weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make

Re: [PR] New feature: Implicit host tags [cloudstack]

2024-04-24 Thread via GitHub
weizhouapache commented on PR #8929: URL: https://github.com/apache/cloudstack/pull/8929#issuecomment-2074772736 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

(cloudstack) branch main updated (a6f3560152b -> 0af923e6181)

2024-04-24 Thread dahn
This is an automated email from the ASF dual-hosted git repository. dahn pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/cloudstack.git from a6f3560152b fix log4j to log4j2 issue (#8966) add 96ae479000a [Usage] Create network billing (#7236) add

(cloudstack) 01/01: Merge branch '4.19'

2024-04-24 Thread dahn
This is an automated email from the ASF dual-hosted git repository. dahn pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/cloudstack.git commit 0af923e618180d3fb8f01ecc56b5a8d854ad1d23 Merge: a6f3560152b 0514caedd6a Author: Daan Hoogland AuthorDate: Wed Apr 24

Re: [PR] VR: fix dnmasq misconfiguration if there are multiple IP ranges in a shared network [cloudstack]

2024-04-24 Thread via GitHub
ccycv commented on PR #8741: URL: https://github.com/apache/cloudstack/pull/8741#issuecomment-2074778456 > @ccycv can you test it ? Just tested in 2 different environments, CloudStack 4.18.1 and 4.19, looks fine. I only think the MTU should be at the end of the config file; right

Re: [PR] Extra parameter for UpdateImageStore [cloudstack]

2024-04-24 Thread via GitHub
blueorangutan commented on PR #8941: URL: https://github.com/apache/cloudstack/pull/8941#issuecomment-2074960641 @DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make

Re: [PR] [UI] Add option to specify account/project while deploying VMs and creating networks [cloudstack]

2024-04-24 Thread via GitHub
blueorangutan commented on PR #8919: URL: https://github.com/apache/cloudstack/pull/8919#issuecomment-2075147817 [SF] Trillian Build Failed (tid-9989) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] VR: fix dnmasq misconfiguration if there are multiple IP ranges in a shared network [cloudstack]

2024-04-24 Thread via GitHub
blueorangutan commented on PR #8741: URL: https://github.com/apache/cloudstack/pull/8741#issuecomment-2074578224 @DaanHoogland a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To

Re: [PR] New feature: Implicit host tags [cloudstack]

2024-04-24 Thread via GitHub
blueorangutan commented on PR #8929: URL: https://github.com/apache/cloudstack/pull/8929#issuecomment-2074774914 @weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make

Re: [I] KVM Incremental Snapshots/Backups [cloudstack]

2024-04-24 Thread via GitHub
DaanHoogland commented on issue #8907: URL: https://github.com/apache/cloudstack/issues/8907#issuecomment-2074814490 > > Ok, one more, will coalescing of snapshots on secondary be implemented at all? (and do we think we need it?) > > I don't see a reason to coalesce snapshots on

Re: [PR] [UI] Add option to specify account/project while deploying VMs and creating networks [cloudstack]

2024-04-24 Thread via GitHub
DaanHoogland commented on PR #8919: URL: https://github.com/apache/cloudstack/pull/8919#issuecomment-2074911645 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] framework/db: introduce a new MySQL table based distributed lock [cloudstack]

2024-04-24 Thread via GitHub
blueorangutan commented on PR #8968: URL: https://github.com/apache/cloudstack/pull/8968#issuecomment-2074922270 Packaging result [SF]: ✖️ el7 ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 9402 -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [I] Unable to Secure CloudStack System VMs with Dynamic URL [cloudstack]

2024-04-24 Thread via GitHub
DaanHoogland commented on issue #8957: URL: https://github.com/apache/cloudstack/issues/8957#issuecomment-2074540742 > @weizhouapache I tried a telnet to 443 and 8443443 is not connected

Re: [PR] Fix KVM live migration with NFS volumes [cloudstack]

2024-04-24 Thread via GitHub
DaanHoogland commented on PR #8952: URL: https://github.com/apache/cloudstack/pull/8952#issuecomment-2074565341 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Update en.json [cloudstack]

2024-04-24 Thread via GitHub
sureshanaparti commented on PR #8958: URL: https://github.com/apache/cloudstack/pull/8958#issuecomment-2074687262 @blueorangutan ui -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Update en.json [cloudstack]

2024-04-24 Thread via GitHub
blueorangutan commented on PR #8958: URL: https://github.com/apache/cloudstack/pull/8958#issuecomment-2074687982 @sureshanaparti a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To

Re: [PR] extract host from websocket to add route [cloudstack]

2024-04-24 Thread via GitHub
DaanHoogland commented on PR #8922: URL: https://github.com/apache/cloudstack/pull/8922#issuecomment-2074734899 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[PR] framework/db: introduce a new MySQL table based distributed lock [cloudstack]

2024-04-24 Thread via GitHub
rohityadavcloud opened a new pull request, #8968: URL: https://github.com/apache/cloudstack/pull/8968 This introduces a MySQL innodb table based distributed lock which can be used by one or more management server and its threads. This removes usage of MySQL server provided locking

Re: [PR] framework/db: introduce a new MySQL table based distributed lock [cloudstack]

2024-04-24 Thread via GitHub
blueorangutan commented on PR #8968: URL: https://github.com/apache/cloudstack/pull/8968#issuecomment-2074789634 @rohityadavcloud a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make

Re: [PR] framework/db: introduce a new MySQL table based distributed lock [cloudstack]

2024-04-24 Thread via GitHub
rohityadavcloud commented on PR #8968: URL: https://github.com/apache/cloudstack/pull/8968#issuecomment-2074787837 This is largely WIP and experimental, at the point I'm only looking for automated tests which are easier done via a PR, I'm not looking for any feedback and review - thanks.

Re: [PR] VR: fix dnmasq misconfiguration if there are multiple IP ranges in a shared network [cloudstack]

2024-04-24 Thread via GitHub
ccycv commented on PR #8741: URL: https://github.com/apache/cloudstack/pull/8741#issuecomment-2074849548 > > dhcp-option=eth0,26,1500 > > @ccycv You tested with the changes in this PR, right ? just to confirm Yes, with this PR -- This is an automated message from the Apache

Re: [PR] New feature: Implicit host tags [cloudstack]

2024-04-24 Thread via GitHub
blueorangutan commented on PR #8929: URL: https://github.com/apache/cloudstack/pull/8929#issuecomment-2074910544 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9401 -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] [UI] Add option to specify account/project while deploying VMs and creating networks [cloudstack]

2024-04-24 Thread via GitHub
DaanHoogland commented on PR #8919: URL: https://github.com/apache/cloudstack/pull/8919#issuecomment-2074912857 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] VR: fix dnmasq misconfiguration if there are multiple IP ranges in a shared network [cloudstack]

2024-04-24 Thread via GitHub
weizhouapache commented on PR #8741: URL: https://github.com/apache/cloudstack/pull/8741#issuecomment-2074945273 > Failed to fetch results with details: bash: line 1: /opt/cloud/bin/filesystem_writable_check.py: Permission denied > > Update: after making the file

Re: [PR] Improve logs in primary storage removal process [cloudstack]

2024-04-24 Thread via GitHub
BryanMLima commented on PR #8649: URL: https://github.com/apache/cloudstack/pull/8649#issuecomment-2075005065 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] prevent an NPE on an uninitialised TemplateObject [cloudstack]

2024-04-24 Thread via GitHub
DaanHoogland commented on PR #8898: URL: https://github.com/apache/cloudstack/pull/8898#issuecomment-2075039409 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [I] Wrong resource usage often reported in multiple area [cloudstack]

2024-04-24 Thread via GitHub
levindecaro commented on issue #8927: URL: https://github.com/apache/cloudstack/issues/8927#issuecomment-2075067604 @DaanHoogland So far, I heard it is a intermitted issue from users, when they do some excess create/start/stop/destroy VM within a short period. After hours, the

Re: [PR] Extra parameter for UpdateImageStore [cloudstack]

2024-04-24 Thread via GitHub
blueorangutan commented on PR #8941: URL: https://github.com/apache/cloudstack/pull/8941#issuecomment-2075098360 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9405 -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] systemvm: add template_zone_ref record when add a new zone with same hypervisor type [cloudstack]

2024-04-24 Thread via GitHub
DaanHoogland commented on PR #8395: URL: https://github.com/apache/cloudstack/pull/8395#issuecomment-2074572625 @blueorangutan test rocky8 kvm-rocky8 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] systemvm: add template_zone_ref record when add a new zone with same hypervisor type [cloudstack]

2024-04-24 Thread via GitHub
blueorangutan commented on PR #8395: URL: https://github.com/apache/cloudstack/pull/8395#issuecomment-2074573940 @DaanHoogland a [SL] Trillian-Jenkins test job (rocky8 mgmt + kvm-rocky8) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To

Re: [PR] VR: fix dnmasq misconfiguration if there are multiple IP ranges in a shared network [cloudstack]

2024-04-24 Thread via GitHub
DaanHoogland commented on PR #8741: URL: https://github.com/apache/cloudstack/pull/8741#issuecomment-2074573789 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Fix KVM live migration with NFS volumes [cloudstack]

2024-04-24 Thread via GitHub
blueorangutan commented on PR #8952: URL: https://github.com/apache/cloudstack/pull/8952#issuecomment-2074569887 @DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make

Re: [PR] Fixup listing of serivce offering & storagepools with tags [cloudstack]

2024-04-24 Thread via GitHub
borisstoyanov commented on PR #8937: URL: https://github.com/apache/cloudstack/pull/8937#issuecomment-2074670065 @blueorangutan test keepEnv -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] New feature: Implicit host tags [cloudstack]

2024-04-24 Thread via GitHub
weizhouapache commented on PR #8929: URL: https://github.com/apache/cloudstack/pull/8929#issuecomment-2074752726 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] VR: fix dnmasq misconfiguration if there are multiple IP ranges in a shared network [cloudstack]

2024-04-24 Thread via GitHub
weizhouapache commented on PR #8741: URL: https://github.com/apache/cloudstack/pull/8741#issuecomment-2074873523 > > > dhcp-option=eth0,26,1500 > > > > > > @ccycv You tested with the changes in this PR, right ? just to confirm > > Yes, with this PR great, thanks

Re: [PR] prevent an NPE on an uninitialised TemplateObject [cloudstack]

2024-04-24 Thread via GitHub
blueorangutan commented on PR #8898: URL: https://github.com/apache/cloudstack/pull/8898#issuecomment-2074873574 @DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make

Re: [PR] prevent an NPE on an uninitialised TemplateObject [cloudstack]

2024-04-24 Thread via GitHub
DaanHoogland commented on PR #8898: URL: https://github.com/apache/cloudstack/pull/8898#issuecomment-2074872766 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] framework/db: introduce a new MySQL table based distributed lock [cloudstack]

2024-04-24 Thread via GitHub
blueorangutan commented on PR #8968: URL: https://github.com/apache/cloudstack/pull/8968#issuecomment-2074982813 @rohityadavcloud a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make

Re: [PR] Limit `listRoles` API visibility [cloudstack]

2024-04-24 Thread via GitHub
blueorangutan commented on PR #8639: URL: https://github.com/apache/cloudstack/pull/8639#issuecomment-2075004653 @BryanMLima a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Re: [PR] [UI] Add option to specify account/project while deploying VMs and creating networks [cloudstack]

2024-04-24 Thread via GitHub
blueorangutan commented on PR #8919: URL: https://github.com/apache/cloudstack/pull/8919#issuecomment-2074917531 @DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make

Re: [PR] [UI] Add option to specify account/project while deploying VMs and creating networks [cloudstack]

2024-04-24 Thread via GitHub
DaanHoogland commented on PR #8919: URL: https://github.com/apache/cloudstack/pull/8919#issuecomment-2074918126 > Thanks for testing @DaanHoogland, I got this error in the QA environment, though it is using the 4.19 branch to build it. However, when I built locally with the main branch,

Re: [PR] Refactor KubernetesClusterResourceModifierActionWorker [cloudstack]

2024-04-24 Thread via GitHub
BryanMLima commented on code in PR #8801: URL: https://github.com/apache/cloudstack/pull/8801#discussion_r1577900824 ## plugins/integrations/kubernetes-service/src/main/java/com/cloud/kubernetes/cluster/actionworkers/KubernetesClusterResourceModifierActionWorker.java: ## @@

Re: [PR] prevent an NPE on an uninitialised TemplateObject [cloudstack]

2024-04-24 Thread via GitHub
blueorangutan commented on PR #8898: URL: https://github.com/apache/cloudstack/pull/8898#issuecomment-2075041403 @DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make

Re: [I] KVM Incremental Snapshots/Backups [cloudstack]

2024-04-24 Thread via GitHub
DaanHoogland commented on issue #8907: URL: https://github.com/apache/cloudstack/issues/8907#issuecomment-2074527512 Ok, one more, will coalescing of snapshots on secondary be implemented at all? (and do we think we need it?) -- This is an automated message from the Apache Git Service.

Re: [PR] systemvm: add template_zone_ref record when add a new zone with same hypervisor type [cloudstack]

2024-04-24 Thread via GitHub
blueorangutan commented on PR #8395: URL: https://github.com/apache/cloudstack/pull/8395#issuecomment-2074550784 [SF] Trillian Build Failed (tid-9980) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [I] Wrong mountpoint generated on secondary storage for ISO on live migration [cloudstack]

2024-04-24 Thread via GitHub
DaanHoogland commented on issue #8901: URL: https://github.com/apache/cloudstack/issues/8901#issuecomment-2074568586 @loth there are some PRs out for similar issues, #8952 and for the 4.19 branch #8909. Will you have the chance to test with those patches? -- This is an automated message

Re: [I] Wrong resource usage often reported in multiple area [cloudstack]

2024-04-24 Thread via GitHub
DaanHoogland commented on issue #8927: URL: https://github.com/apache/cloudstack/issues/8927#issuecomment-2074637572 @levindecaro , several queries (and possible actions) - is this an intermitted issue or consequent? - if this is really an issue with usage; for those resources you

Re: [PR] Change storage pool scope from Cluster to Zone and vise versa [cloudstack]

2024-04-24 Thread via GitHub
abh1sar commented on code in PR #8875: URL: https://github.com/apache/cloudstack/pull/8875#discussion_r1577718662 ## test/integration/smoke/test_primary_storage_scope.py: ## @@ -0,0 +1,170 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor

Re: [PR] Fix KVM live migration with NFS volumes [cloudstack]

2024-04-24 Thread via GitHub
DaanHoogland commented on PR #8952: URL: https://github.com/apache/cloudstack/pull/8952#issuecomment-2074713097 @blueorangutan test rocky8 kvm-rocky8 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] VR: fix dnmasq misconfiguration if there are multiple IP ranges in a shared network [cloudstack]

2024-04-24 Thread via GitHub
weizhouapache commented on PR #8741: URL: https://github.com/apache/cloudstack/pull/8741#issuecomment-2074823833 > dhcp-option=eth0,26,1500 @ccycv You tested with the changes in this PR, right ? just to confirm -- This is an automated message from the Apache Git Service. To

Re: [PR] framework/db: introduce a new MySQL table based distributed lock [cloudstack]

2024-04-24 Thread via GitHub
rohityadavcloud commented on PR #8968: URL: https://github.com/apache/cloudstack/pull/8968#issuecomment-2074973924 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Limit `listRoles` API visibility [cloudstack]

2024-04-24 Thread via GitHub
BryanMLima commented on PR #8639: URL: https://github.com/apache/cloudstack/pull/8639#issuecomment-207469 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Improve logs in primary storage removal process [cloudstack]

2024-04-24 Thread via GitHub
blueorangutan commented on PR #8649: URL: https://github.com/apache/cloudstack/pull/8649#issuecomment-2075009152 @BryanMLima a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Re: [I] IP address conflicts held by public IPs of virtual routers [cloudstack]

2024-04-24 Thread via GitHub
DaanHoogland commented on issue #8967: URL: https://github.com/apache/cloudstack/issues/8967#issuecomment-2075009281 oh, that, ``` 2024-04-23 13:11:27,089 WARNING Unable to find and process databag for file: ip_associations.json.a81b47b8-2a91-42a2-a529-1de42849049c, for json

Re: [PR] [UI] Add option to specify account/project while deploying VMs and creating networks [cloudstack]

2024-04-24 Thread via GitHub
blueorangutan commented on PR #8919: URL: https://github.com/apache/cloudstack/pull/8919#issuecomment-2075098359 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9404 -- This is an automated message from the Apache Git Service. To respond to the message, please log

  1   2   3   >