[GitHub] blueorangutan commented on issue #2218: CLOUDSTACK-9782: New Background Polling Task Manager
blueorangutan commented on issue #2218: CLOUDSTACK-9782: New Background Polling Task Manager URL: https://github.com/apache/cloudstack/pull/2218#issuecomment-319841991 Trillian test result (tid-1306) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 41798 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2218-t1306-kvm-centos7.zip Intermitten failure detected: /marvin/tests/smoke/test_deploy_virtio_scsi_vm.py Intermitten failure detected: /marvin/tests/smoke/test_deploy_vm_iso.py Intermitten failure detected: /marvin/tests/smoke/test_internal_lb.py Intermitten failure detected: /marvin/tests/smoke/test_iso.py Intermitten failure detected: /marvin/tests/smoke/test_network.py Intermitten failure detected: /marvin/tests/smoke/test_nic.py Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py Intermitten failure detected: /marvin/tests/smoke/test_router_dns.py Intermitten failure detected: /marvin/tests/smoke/test_routers.py Intermitten failure detected: /marvin/tests/smoke/test_vpc_router_nics.py Test completed. 50 look OK, 7 have error(s) Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_VPC_nics_after_destroy | `Failure` | 412.36 | test_vpc_router_nics.py test_04_rvpc_privategw_static_routes | `Failure` | 333.61 | test_privategw_acl.py test_03_vpc_privategw_restart_vpc_cleanup | `Error` | 291.89 | test_privategw_acl.py test_01_nic | `Error` | 193.93 | test_nic.py test_reboot_router | `Error` | 238.47 | test_network.py test_04_extract_Iso | `Error` | 5.13 | test_iso.py test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 | `Error` | 138.07 | test_internal_lb.py ContextSuite context=TestDeployVirtioSCSIVM>:teardown | `Error` | 144.22 | test_deploy_virtio_scsi_vm.py test_change_service_offering_for_vm_with_snapshots | Skipped | 0.00 | test_vm_snapshots.py test_09_copy_delete_template | Skipped | 0.02 | test_templates.py test_06_copy_template | Skipped | 0.00 | test_templates.py test_static_role_account_acls | Skipped | 0.03 | test_staticroles.py test_11_ss_nfs_version_on_ssvm | Skipped | 0.03 | test_ssvm.py test_01_scale_vm | Skipped | 0.00 | test_scale_vm.py test_01_primary_storage_iscsi | Skipped | 0.06 | test_primary_storage.py test_vm_nic_adapter_vmxnet3 | Skipped | 0.00 | test_nic_adapter_type.py test_nested_virtualization_vmware | Skipped | 0.00 | test_nested_virtualization.py test_06_copy_iso | Skipped | 0.00 | test_iso.py test_deploy_vgpu_enabled_vm | Skipped | 0.05 | test_deploy_vgpu_enabled_vm.py test_3d_gpu_support | Skipped | 0.10 | test_deploy_vgpu_enabled_vm.py This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #1919: CLOUDSTACK-9763: set ssh public key when creating vm data
blueorangutan commented on issue #1919: CLOUDSTACK-9763: set ssh public key when creating vm data URL: https://github.com/apache/cloudstack/pull/1919#issuecomment-319833649 Packaging result: ?centos6 ?centos7 ?debian. JID-907 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #1912: CLOUDSTACK-9749: Disable password service on ilb systemvm
blueorangutan commented on issue #1912: CLOUDSTACK-9749: Disable password service on ilb systemvm URL: https://github.com/apache/cloudstack/pull/1912#issuecomment-319832809 Packaging result: ?centos6 ?centos7 ?debian. JID-906 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2138: CLOUDSTACK-9944 In Cluster Management Server, Sometimes hosts stays i?
blueorangutan commented on issue #2138: CLOUDSTACK-9944 In Cluster Management Server, Sometimes hosts stays i? URL: https://github.com/apache/cloudstack/pull/2138#issuecomment-319832169 Packaging result: ?centos6 ?centos7 ?debian. JID-905 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2013: Bug-ID: CLOUDSTACK-9734 Destroy VM Fails sometimes
blueorangutan commented on issue #2013: Bug-ID: CLOUDSTACK-9734 Destroy VM Fails sometimes URL: https://github.com/apache/cloudstack/pull/2013#issuecomment-319832147 Packaging result: ?centos6 ?centos7 ?debian. JID-904 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2058: CLOUDSTACK-9888: Duplicate usage while processing usage events
blueorangutan commented on issue #2058: CLOUDSTACK-9888: Duplicate usage while processing usage events URL: https://github.com/apache/cloudstack/pull/2058#issuecomment-319822489 Packaging result: ?centos6 ?centos7 ?debian. JID-903 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #1919: CLOUDSTACK-9763: set ssh public key when creating vm data
rhtyd commented on issue #1919: CLOUDSTACK-9763: set ssh public key when creating vm data URL: https://github.com/apache/cloudstack/pull/1919#issuecomment-319821162 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #1919: CLOUDSTACK-9763: set ssh public key when creating vm data
blueorangutan commented on issue #1919: CLOUDSTACK-9763: set ssh public key when creating vm data URL: https://github.com/apache/cloudstack/pull/1919#issuecomment-319821293 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #1912: CLOUDSTACK-9749: Disable password service on ilb systemvm
blueorangutan commented on issue #1912: CLOUDSTACK-9749: Disable password service on ilb systemvm URL: https://github.com/apache/cloudstack/pull/1912#issuecomment-319821136 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #1912: CLOUDSTACK-9749: Disable password service on ilb systemvm
rhtyd commented on issue #1912: CLOUDSTACK-9749: Disable password service on ilb systemvm URL: https://github.com/apache/cloudstack/pull/1912#issuecomment-319821023 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #1912: [4.8] CLOUDSTACK-9749: Disable password service on ilb systemvm
rhtyd commented on issue #1912: [4.8] CLOUDSTACK-9749: Disable password service on ilb systemvm URL: https://github.com/apache/cloudstack/pull/1912#issuecomment-319820824 @fmaximus can you rebase against 4.9, or master branch? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #1912: [4.8] CLOUDSTACK-9749: Disable password service on ilb systemvm
rhtyd commented on issue #1912: [4.8] CLOUDSTACK-9749: Disable password service on ilb systemvm URL: https://github.com/apache/cloudstack/pull/1912#issuecomment-319820824 @fmaximus can you rebase against 4.9, or master branch? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[cloudstack] branch master updated: CLOUDSTACK-8906: /var/log/cloud/ doesn't get logrotated on xenserver (#883)
This is an automated email from the ASF dual-hosted git repository. bhaisaab pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/master by this push: new 5397106 CLOUDSTACK-8906: /var/log/cloud/ doesn't get logrotated on xenserver (#883) 5397106 is described below commit 5397106a7621e974343927c70ec19abe819237bf Author: SudharmaJain AuthorDate: Thu Aug 3 04:21:16 2017 +0530 CLOUDSTACK-8906: /var/log/cloud/ doesn't get logrotated on xenserver (#883) After integrating XS with CCP the following folder gets created: /var/log/cloud/ however the logs in that are not rotated resulting in root file system fill up. It was a known issue and link http://support.citrix.com/article/CTX138064 describes the issue and solution. Used the article and added corresponding changes to Cloudstack. --- scripts/vm/hypervisor/xenserver/logrotate | 29 +++ scripts/vm/hypervisor/xenserver/setupxenserver.sh | 2 +- scripts/vm/hypervisor/xenserver/xenserver60/patch | 1 + scripts/vm/hypervisor/xenserver/xenserver62/patch | 1 + scripts/vm/hypervisor/xenserver/xenserver65/patch | 1 + 5 files changed, 33 insertions(+), 1 deletion(-) diff --git a/scripts/vm/hypervisor/xenserver/logrotate b/scripts/vm/hypervisor/xenserver/logrotate new file mode 100644 index 000..375b7e7 --- /dev/null +++ b/scripts/vm/hypervisor/xenserver/logrotate @@ -0,0 +1,29 @@ +#!/bin/bash +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +# Version @VERSION@ +# +# script to perform logrotation on xenserver 6.0.2 and later + +/usr/sbin/logrotate /etc/logrotate.d/cloudlog +EXITVALUE=$? +if [ $EXITVALUE != 0 ]; then +/usr/bin/logger -t logrotate "ALERT exited abnormally with [$EXITVALUE]" +fi +[ -f /opt/xensource/bin/delete_old_logs_by_space ] && /opt/xensource/bin/delete_old_logs_by_space +exit 0 diff --git a/scripts/vm/hypervisor/xenserver/setupxenserver.sh b/scripts/vm/hypervisor/xenserver/setupxenserver.sh index 14ba1c2..6c850c6 100755 --- a/scripts/vm/hypervisor/xenserver/setupxenserver.sh +++ b/scripts/vm/hypervisor/xenserver/setupxenserver.sh @@ -49,7 +49,7 @@ sed -i 's/0\.0\.0\.0/127\.0\.0\.1/' /opt/xensource/libexec/qemu-dm-wrapper 2>&1 sed -i /NOZEROCONF/d /etc/sysconfig/network echo "NOZEROCONF=yes" >> /etc/sysconfig/network -mv -n /etc/cron.daily/logrotate /etc/cron.hourly 2>&1 +[ -f /etc/cron.hourly/logrotate ] || mv /etc/cron.daily/logrotate /etc/cron.hourly 2>&1 # more aio thread echo 1048576 >/proc/sys/fs/aio-max-nr diff --git a/scripts/vm/hypervisor/xenserver/xenserver60/patch b/scripts/vm/hypervisor/xenserver/xenserver60/patch index 4b0973f..bea0cf9 100644 --- a/scripts/vm/hypervisor/xenserver/xenserver60/patch +++ b/scripts/vm/hypervisor/xenserver/xenserver60/patch @@ -69,3 +69,4 @@ ovs-get-dhcp-iface.sh=..,0755,/opt/cloud/bin ovs-get-bridge.sh=..,0755,/opt/cloud/bin cloudlog=..,0644,/etc/logrotate.d update_host_passwd.sh=../..,0755,/opt/cloud/bin +logrotate=..,0755,/etc/cron.hourly \ No newline at end of file diff --git a/scripts/vm/hypervisor/xenserver/xenserver62/patch b/scripts/vm/hypervisor/xenserver/xenserver62/patch index 8f65877..db137c9 100644 --- a/scripts/vm/hypervisor/xenserver/xenserver62/patch +++ b/scripts/vm/hypervisor/xenserver/xenserver62/patch @@ -65,3 +65,4 @@ ovs-get-dhcp-iface.sh=..,0755,/opt/cloud/bin ovs-get-bridge.sh=..,0755,/opt/cloud/bin cloudlog=..,0644,/etc/logrotate.d update_host_passwd.sh=../..,0755,/opt/cloud/bin +logrotate=..,0755,/etc/cron.hourly \ No newline at end of file diff --git a/scripts/vm/hypervisor/xenserver/xenserver65/patch b/scripts/vm/hypervisor/xenserver/xenserver65/patch index 8f65877..db137c9 100644 --- a/scripts/vm/hypervisor/xenserver/xenserver65/patch +++ b/scripts/vm/hypervisor/xenserver/xenserver65/patch @@ -65,3 +65,4 @@ ovs-get-dhcp-iface.sh=..,0755,/opt/cloud/bin ovs-get-bridge.sh=..,0755,/opt/cloud/bin cloudlog=..,0644,/etc/logrotate.d update_host_passwd.sh=../..,0755,/opt/cloud/bin +logrotate=..,0755,/etc/cron.hourly \ No newline at end of file -- To stop receiving notification emails like this one, please contact ['"commits@cloudstack.apache.org" '].
[GitHub] rhtyd commented on issue #883: CLOUDSTACK-8906: /var/log/cloud/ doesn't get logrotated on xenserver
rhtyd commented on issue #883: CLOUDSTACK-8906: /var/log/cloud/ doesn't get logrotated on xenserver URL: https://github.com/apache/cloudstack/pull/883#issuecomment-319820522 Merging based on CI results, no regressions seen and manual test confirmation on the PR. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd closed pull request #883: CLOUDSTACK-8906: /var/log/cloud/ doesn't get logrotated on xenserver
rhtyd closed pull request #883: CLOUDSTACK-8906: /var/log/cloud/ doesn't get logrotated on xenserver URL: https://github.com/apache/cloudstack/pull/883 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd closed pull request #2119: CLOUDSTACK-9925: Quota memory tariff value is for 1MB of RAM used per month (not hour)
rhtyd closed pull request #2119: CLOUDSTACK-9925: Quota memory tariff value is for 1MB of RAM used per month (not hour) URL: https://github.com/apache/cloudstack/pull/2119 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[cloudstack] branch master updated: CLOUDSTACK-9925: Quota memory tariff value is for 1MB of RAM used per month (not hour) (#2119)
This is an automated email from the ASF dual-hosted git repository.
bhaisaab pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git
The following commit(s) were added to refs/heads/master by this push:
new e0b6dcb CLOUDSTACK-9925: Quota memory tariff value is for 1MB of RAM
used per month (not hour) (#2119)
e0b6dcb is described below
commit e0b6dcbe4a31ddb2f3c0dedbedab85a44e6f84c6
Author: Gabriel Beims Bräscher
AuthorDate: Wed Aug 2 19:47:33 2017 -0300
CLOUDSTACK-9925: Quota memory tariff value is for 1MB of RAM used per month
(not hour) (#2119)
The quota memory tariff description in the CloudStack UI is wrong when
defines that the value is for "using 1MB or RAM for 1 hour". The quota currency
values reflect the value of a resource used per month, not an hour.
Quota divides the tariff value by the number of hours a month has (30 days
- 720 hours); then it calculates the credits used by a client based on the
amount of resources used per hour. The memory tariff description in the
interface is wrong and can guide users to configure values for an hour.
---
.../quota/src/org/apache/cloudstack/quota/constant/QuotaTypes.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
a/framework/quota/src/org/apache/cloudstack/quota/constant/QuotaTypes.java
b/framework/quota/src/org/apache/cloudstack/quota/constant/QuotaTypes.java
index 36910f4..6e1432d 100644
--- a/framework/quota/src/org/apache/cloudstack/quota/constant/QuotaTypes.java
+++ b/framework/quota/src/org/apache/cloudstack/quota/constant/QuotaTypes.java
@@ -57,7 +57,7 @@ public class QuotaTypes extends UsageTypes {
quotaTypeList.put(VM_SNAPSHOT, new QuotaTypes(VM_SNAPSHOT,
"VM_SNAPSHOT", "GB-Month", "VM Snapshot storage usage"));
quotaTypeList.put(CPU_CLOCK_RATE, new QuotaTypes(CPU_CLOCK_RATE,
"CPU_CLOCK_RATE", "Compute-Month", "Quota tariff for using 1 CPU of clock rate
100MHz"));
quotaTypeList.put(CPU_NUMBER, new QuotaTypes(CPU_NUMBER, "CPU_NUMBER",
"Compute-Month", "Quota tariff for running VM that has 1vCPU"));
-quotaTypeList.put(MEMORY, new QuotaTypes(MEMORY, "MEMORY",
"Compute-Month", "Quota tariff for using 1MB or RAM for 1 hour"));
+quotaTypeList.put(MEMORY, new QuotaTypes(MEMORY, "MEMORY",
"Compute-Month", "Quota tariff for using 1MB of RAM"));
quotaTypeMap = Collections.unmodifiableMap(quotaTypeList);
}
--
To stop receiving notification emails like this one, please contact
['"commits@cloudstack.apache.org" '].
[GitHub] rhtyd commented on issue #2119: CLOUDSTACK-9925: Quota memory tariff value is for 1MB of RAM used per month (not hour)
rhtyd commented on issue #2119: CLOUDSTACK-9925: Quota memory tariff value is for 1MB of RAM used per month (not hour) URL: https://github.com/apache/cloudstack/pull/2119#issuecomment-319819787 LGTM. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd closed pull request #2145: CLOUDSTACK-9697: Added better error message user if tries to shrink
rhtyd closed pull request #2145: CLOUDSTACK-9697: Added better error message user if tries to shrink URL: https://github.com/apache/cloudstack/pull/2145 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[cloudstack] branch master updated: CLOUDSTACK-9697: Added better error message user if tries to shrink (#2145)
This is an automated email from the ASF dual-hosted git repository.
bhaisaab pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git
The following commit(s) were added to refs/heads/master by this push:
new e43a4b9 CLOUDSTACK-9697: Added better error message user if tries to
shrink (#2145)
e43a4b9 is described below
commit e43a4b9a09eb330ab148a4913c36e1ca2738adc3
Author: Rashmi D
AuthorDate: Thu Aug 3 04:15:45 2017 +0530
CLOUDSTACK-9697: Added better error message user if tries to shrink (#2145)
the VM ROOT volume size
Skip the API call altogether if the UI detects this and throw a more user
friendly message
---
ui/l10n/en.js | 1 +
ui/scripts/storage.js | 5 +
2 files changed, 6 insertions(+)
diff --git a/ui/l10n/en.js b/ui/l10n/en.js
index a579784..3503296 100644
--- a/ui/l10n/en.js
+++ b/ui/l10n/en.js
@@ -2276,6 +2276,7 @@ var dictionary = {"ICMP.code":"ICMP Code",
"message.vnmc.available.list":"VNMC is not available from provider list.",
"message.vnmc.not.available.list":"VNMC is not available from provider list.",
"message.volume.create.template.confirm":"Please confirm that you wish to
create a template for this disk volume. Creation of the template can range
from several minutes to longer depending on the size of the volume.",
+"message.volume.root.shrink.disk.size" :"Shrink operation on ROOT volume not
supported",
"message.waiting.for.builtin.templates.to.load":"Waiting for builtin templates
to load...",
"message.you.must.have.at.least.one.physical.network":"You must have at least
one physical network",
"message.your.cloudstack.is.ready":"Your CloudStack is ready!",
diff --git a/ui/scripts/storage.js b/ui/scripts/storage.js
index 9638f1e..b71dbe2 100644
--- a/ui/scripts/storage.js
+++ b/ui/scripts/storage.js
@@ -1706,6 +1706,11 @@
array1.push("&maxiops=" +
todb(maxIops));
}
}
+//if original disk size > new disk size
+if ((args.context.volumes[0].type ==
"ROOT")
+&& (args.context.volumes[0].size >
(newSize * (1024 * 1024 * 1024 {
+return
args.response.error('message.volume.root.shrink.disk.size');
+}
$.ajax({
--
To stop receiving notification emails like this one, please contact
['"commits@cloudstack.apache.org" '].
[GitHub] rhtyd commented on issue #2145: CLOUDSTACK-9697: Added better error message user if tries to shrink
rhtyd commented on issue #2145: CLOUDSTACK-9697: Added better error message user if tries to shrink URL: https://github.com/apache/cloudstack/pull/2145#issuecomment-319819443 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2138: CLOUDSTACK-9944 In Cluster Management Server, Sometimes hosts stays i?
rhtyd commented on issue #2138: CLOUDSTACK-9944 In Cluster Management Server, Sometimes hosts stays i? URL: https://github.com/apache/cloudstack/pull/2138#issuecomment-319819256 LGTM. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2073: CLOUDSTACK-9896: API: listDedicatedXXX should respect pagination
blueorangutan commented on issue #2073: CLOUDSTACK-9896: API: listDedicatedXXX should respect pagination URL: https://github.com/apache/cloudstack/pull/2073#issuecomment-319819358 Packaging result: ?centos6 ?centos7 ?debian. JID-902 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2138: CLOUDSTACK-9944 In Cluster Management Server, Sometimes hosts stays i?
blueorangutan commented on issue #2138: CLOUDSTACK-9944 In Cluster Management Server, Sometimes hosts stays i? URL: https://github.com/apache/cloudstack/pull/2138#issuecomment-319818917 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2138: CLOUDSTACK-9944 In Cluster Management Server, Sometimes hosts stays i?
rhtyd commented on issue #2138: CLOUDSTACK-9944 In Cluster Management Server, Sometimes hosts stays i? URL: https://github.com/apache/cloudstack/pull/2138#issuecomment-319818760 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2137: CLOUDSTACK-9950:listUsageRecords doesnt return required fields
rhtyd commented on issue #2137: CLOUDSTACK-9950:listUsageRecords doesnt return required fields URL: https://github.com/apache/cloudstack/pull/2137#issuecomment-319818643 Merging based on Travis checks and code review, explicit Trillian tests are not necessary. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd closed pull request #2137: CLOUDSTACK-9950:listUsageRecords doesnt return required fields
rhtyd closed pull request #2137: CLOUDSTACK-9950:listUsageRecords doesnt return required fields URL: https://github.com/apache/cloudstack/pull/2137 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[cloudstack] branch master updated: CLOUDSTACK-9950:listUsageRecords doesnt return required fields (#2137)
This is an automated email from the ASF dual-hosted git repository.
bhaisaab pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git
The following commit(s) were added to refs/heads/master by this push:
new b936feb CLOUDSTACK-9950:listUsageRecords doesnt return required
fields (#2137)
b936feb is described below
commit b936feb108bd4f91a13f735f8ae2d8f47a926525
Author: mrunalinikankariya
AuthorDate: Thu Aug 3 04:09:57 2017 +0530
CLOUDSTACK-9950:listUsageRecords doesnt return required fields (#2137)
There is no cpuspeed, cpunumber or memory details in the listUsageRecords
output as documented
In DB (cloud_usage table) we have cpu_speed, cpu_cores and ram fileds, but
these are not populated for all the VM's. These fields are only populated for
the VM's which are deployed with custom service offerings.
---
server/src/com/cloud/api/ApiResponseHelper.java | 18 +++---
1 file changed, 15 insertions(+), 3 deletions(-)
diff --git a/server/src/com/cloud/api/ApiResponseHelper.java
b/server/src/com/cloud/api/ApiResponseHelper.java
index d9fd01c..80633e1 100644
--- a/server/src/com/cloud/api/ApiResponseHelper.java
+++ b/server/src/com/cloud/api/ApiResponseHelper.java
@@ -3249,9 +3249,21 @@ public class ApiResponseHelper implements
ResponseGenerator {
//Hypervisor Type
usageRecResponse.setType(usageRecord.getType());
//Dynamic compute offerings details
-usageRecResponse.setCpuNumber(usageRecord.getCpuCores());
-usageRecResponse.setCpuSpeed(usageRecord.getCpuSpeed());
-usageRecResponse.setMemory(usageRecord.getMemory());
+if(usageRecord.getCpuCores() != null) {
+usageRecResponse.setCpuNumber(usageRecord.getCpuCores());
+} else if (svcOffering.getCpu() != null){
+
usageRecResponse.setCpuNumber(svcOffering.getCpu().longValue());
+}
+if(usageRecord.getCpuSpeed() != null) {
+usageRecResponse.setCpuSpeed(usageRecord.getCpuSpeed());
+} else if(svcOffering.getSpeed() != null){
+
usageRecResponse.setCpuSpeed(svcOffering.getSpeed().longValue());
+}
+if(usageRecord.getMemory() != null) {
+usageRecResponse.setMemory(usageRecord.getMemory());
+} else if(svcOffering.getRamSize() != null) {
+
usageRecResponse.setMemory(svcOffering.getRamSize().longValue());
+}
} else if (usageRecord.getUsageType() == UsageTypes.IP_ADDRESS) {
//isSourceNAT
--
To stop receiving notification emails like this one, please contact
['"commits@cloudstack.apache.org" '].
[GitHub] rhtyd commented on issue #2137: CLOUDSTACK-9950:listUsageRecords doesnt return required fields
rhtyd commented on issue #2137: CLOUDSTACK-9950:listUsageRecords doesnt return required fields URL: https://github.com/apache/cloudstack/pull/2137#issuecomment-319818530 LGTM. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on a change in pull request #2122: CLOUDSTACK-9909: Logrotate config for tomcat needs to be updated for ?
rhtyd commented on a change in pull request #2122: CLOUDSTACK-9909: Logrotate
config for tomcat needs to be updated for ?
URL: https://github.com/apache/cloudstack/pull/2122#discussion_r131015092
##
File path: server/conf/cloudstack-catalina7.logrotate
##
@@ -0,0 +1,27 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+
+/var/log/cloudstack/management/catalina.out {
+copytruncate
+daily
+rotate 14
+compress
+missingok
+create 0644 cloud cloud
+su cloud cloud
Review comment:
The only difference is 'su cloud cloud', will it break if we include this
change in the tomcat6 based logrotate file?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] rhtyd commented on issue #2013: Bug-ID: CLOUDSTACK-9734 Destroy VM Fails sometimes
rhtyd commented on issue #2013: Bug-ID: CLOUDSTACK-9734 Destroy VM Fails sometimes URL: https://github.com/apache/cloudstack/pull/2013#issuecomment-319818050 LGTM (code) @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2013: Bug-ID: CLOUDSTACK-9734 Destroy VM Fails sometimes
blueorangutan commented on issue #2013: Bug-ID: CLOUDSTACK-9734 Destroy VM Fails sometimes URL: https://github.com/apache/cloudstack/pull/2013#issuecomment-319818083 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2058: CLOUDSTACK-9888: Duplicate usage while processing usage events
blueorangutan commented on issue #2058: CLOUDSTACK-9888: Duplicate usage while processing usage events URL: https://github.com/apache/cloudstack/pull/2058#issuecomment-319817883 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2058: CLOUDSTACK-9888: Duplicate usage while processing usage events
rhtyd commented on issue #2058: CLOUDSTACK-9888: Duplicate usage while processing usage events URL: https://github.com/apache/cloudstack/pull/2058#issuecomment-319817865 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #1470: Make the generated json files unique to prevent concurrency issues
rhtyd commented on issue #1470: Make the generated json files unique to prevent concurrency issues URL: https://github.com/apache/cloudstack/pull/1470#issuecomment-319817759 ping @remibergsma This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[cloudstack] branch master updated: CLOUDSTACK-9840: Fix datetime format of snapshots events (#2008)
This is an automated email from the ASF dual-hosted git repository. bhaisaab pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/master by this push: new 43ae8e3 CLOUDSTACK-9840: Fix datetime format of snapshots events (#2008) 43ae8e3 is described below commit 43ae8e3503bc746f412e34e3fe6488e00def4ed0 Author: Olivier Lemasle AuthorDate: Thu Aug 3 00:31:49 2017 +0200 CLOUDSTACK-9840: Fix datetime format of snapshots events (#2008) Include the timezone in datetime format of snapshot events, to be consistent with every other events. "eventDateTime" was added by @chipchilders in commit 14ee684ce3 and was updated the same day to add the timezone (commit bf967eb622f) except for Snapshots. --- server/src/com/cloud/storage/listener/SnapshotStateListener.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/server/src/com/cloud/storage/listener/SnapshotStateListener.java b/server/src/com/cloud/storage/listener/SnapshotStateListener.java index f4decf6..344f81c 100644 --- a/server/src/com/cloud/storage/listener/SnapshotStateListener.java +++ b/server/src/com/cloud/storage/listener/SnapshotStateListener.java @@ -101,7 +101,7 @@ public class SnapshotStateListener implements StateListener'].
[GitHub] rhtyd closed pull request #2008: [CLOUDSTACK-9840] Fix datetime format of snapshots events
rhtyd closed pull request #2008: [CLOUDSTACK-9840] Fix datetime format of snapshots events URL: https://github.com/apache/cloudstack/pull/2008 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[cloudstack] branch master updated (7fea069 -> 1d95cbb)
This is an automated email from the ASF dual-hosted git repository. bhaisaab pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git. from 7fea069 CLOUDSTACK-9954 Unable to create service offering with networkrate=0 (#2142) add 974e01e CLOUDSTACK-10011: Fix Agent logrotation (#2094) add b60e173 Merge branch '4.9' into 4.10 new 1d95cbb Merge branch '4.10' The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: agent/conf/cloudstack-agent.logrotate | 4 ++-- debian/rules | 3 ++- 2 files changed, 4 insertions(+), 3 deletions(-) -- To stop receiving notification emails like this one, please contact ['"commits@cloudstack.apache.org" '].
[GitHub] rhtyd commented on issue #2008: [CLOUDSTACK-9840] Fix datetime format of snapshots events
rhtyd commented on issue #2008: [CLOUDSTACK-9840] Fix datetime format of snapshots events URL: https://github.com/apache/cloudstack/pull/2008#issuecomment-319816919 LGTM. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[cloudstack] 01/01: Merge branch '4.10'
This is an automated email from the ASF dual-hosted git repository. bhaisaab pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git commit 1d95cbbfed4107b8e3be74a066442531e183be2f Merge: 7fea069 b60e173 Author: Rohit Yadav AuthorDate: Thu Aug 3 00:31:12 2017 +0200 Merge branch '4.10' agent/conf/cloudstack-agent.logrotate | 4 ++-- debian/rules | 3 ++- 2 files changed, 4 insertions(+), 3 deletions(-) -- To stop receiving notification emails like this one, please contact "commits@cloudstack.apache.org" .
[GitHub] rhtyd commented on a change in pull request #2050: CLOUDSTACK-9865: improper os types for xenserver 6.5
rhtyd commented on a change in pull request #2050: CLOUDSTACK-9865: improper os types for xenserver 6.5 URL: https://github.com/apache/cloudstack/pull/2050#discussion_r131013646 ## File path: setup/db/db/schema-4920to41000.sql ## @@ -48,7 +48,7 @@ INSERT IGNORE INTO `cloud`.`guest_os_hypervisor` (uuid, hypervisor_type, hypervi INSERT IGNORE INTO `cloud`.`guest_os_hypervisor` (uuid, hypervisor_type, hypervisor_version, guest_os_name, guest_os_id, created, is_user_defined) VALUES (UUID(), 'VMware', '6.0', 'windows9_64Guest', 258, now(), 0); INSERT IGNORE INTO `cloud`.`guest_os_hypervisor` (uuid, hypervisor_type, hypervisor_version, guest_os_name, guest_os_id, created, is_user_defined) VALUES (UUID(), 'KVM', 'default', 'Windows 10', 258, now(), 0); -INSERT IGNORE INTO `cloud`.`guest_os_hypervisor` (uuid, hypervisor_type, hypervisor_version, guest_os_name, guest_os_id, created, is_user_defined) VALUES (UUID(), 'Xenserver', '6.5.0', 'Windows Server 2016 (64-bit)', 259, now(), 0); Review comment: Can this be moved to 4.10->4.11 upgrade path, thanks This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[cloudstack] 01/01: Merge branch '4.9' into 4.10
This is an automated email from the ASF dual-hosted git repository. bhaisaab pushed a commit to branch 4.10 in repository https://gitbox.apache.org/repos/asf/cloudstack.git commit b60e173c5c14e0a5539d0391d4724f4807efb9bd Merge: d53f500 974e01e Author: Rohit Yadav AuthorDate: Thu Aug 3 00:29:24 2017 +0200 Merge branch '4.9' into 4.10 agent/conf/cloudstack-agent.logrotate | 4 ++-- debian/rules | 3 ++- 2 files changed, 4 insertions(+), 3 deletions(-) -- To stop receiving notification emails like this one, please contact "commits@cloudstack.apache.org" .
[cloudstack] branch 4.10 updated (d53f500 -> b60e173)
This is an automated email from the ASF dual-hosted git repository. bhaisaab pushed a change to branch 4.10 in repository https://gitbox.apache.org/repos/asf/cloudstack.git. from d53f500 Merge branch '4.9' into 4.10 add 974e01e CLOUDSTACK-10011: Fix Agent logrotation (#2094) new b60e173 Merge branch '4.9' into 4.10 The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: agent/conf/cloudstack-agent.logrotate | 4 ++-- debian/rules | 3 ++- 2 files changed, 4 insertions(+), 3 deletions(-) -- To stop receiving notification emails like this one, please contact ['"commits@cloudstack.apache.org" '].
[cloudstack] branch 4.9 updated: CLOUDSTACK-10011: Fix Agent logrotation (#2094)
This is an automated email from the ASF dual-hosted git repository.
bhaisaab pushed a commit to branch 4.9
in repository https://gitbox.apache.org/repos/asf/cloudstack.git
The following commit(s) were added to refs/heads/4.9 by this push:
new 974e01e CLOUDSTACK-10011: Fix Agent logrotation (#2094)
974e01e is described below
commit 974e01ed088524a03b8de1d578f029a1b4c7e9f9
Author: Ronald van Zantvoort
AuthorDate: Thu Aug 3 00:29:02 2017 +0200
CLOUDSTACK-10011: Fix Agent logrotation (#2094)
* CS Agent: Correct logrotation for agent log
* CS Agent: Logrotate security_group as well
* CS Agent: fix logrotation file perms so logrotate doesnt skip it
---
agent/conf/cloudstack-agent.logrotate | 4 ++--
debian/rules | 3 ++-
2 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/agent/conf/cloudstack-agent.logrotate
b/agent/conf/cloudstack-agent.logrotate
index 202de8f..6733af5 100644
--- a/agent/conf/cloudstack-agent.logrotate
+++ b/agent/conf/cloudstack-agent.logrotate
@@ -15,8 +15,8 @@
# specific language governing permissions and limitations
# under the License.
-/var/log/cloudstack/agent/cloudstack-agent.out
-/var/log/cloudstack/agent/cloudstack-agent.err
+@AGENTLOG@
+/var/log/cloudstack/agent/security_group.log
{
copytruncate
daily
diff --git a/debian/rules b/debian/rules
index cfe7514..8983c97 100755
--- a/debian/rules
+++ b/debian/rules
@@ -51,10 +51,11 @@ override_dh_auto_install:
install -m0644 packaging/systemd/$(PACKAGE)-agent.service
debian/$(PACKAGE)-agent/lib/systemd/system/$(PACKAGE)-agent.service
install -m0644 packaging/systemd/$(PACKAGE)-agent.default
$(DESTDIR)/$(SYSCONFDIR)/default/$(PACKAGE)-agent
+ install -D -m0644 agent/target/transformed/cloudstack-agent.logrotate
$(DESTDIR)/$(SYSCONFDIR)/logrotate.d/cloudstack-agent
+
install -D agent/target/transformed/cloud-setup-agent
$(DESTDIR)/usr/bin/cloudstack-setup-agent
install -D agent/target/transformed/cloud-ssh
$(DESTDIR)/usr/bin/cloudstack-ssh
install -D agent/target/transformed/cloudstack-agent-profile.sh
$(DESTDIR)/$(SYSCONFDIR)/profile.d/cloudstack-agent-profile.sh
- install -D agent/target/transformed/cloudstack-agent.logrotate
$(DESTDIR)/$(SYSCONFDIR)/logrotate.d/cloudstack-agent
install -D agent/target/transformed/cloudstack-agent-upgrade
$(DESTDIR)/usr/bin/cloudstack-agent-upgrade
install -D agent/target/transformed/libvirtqemuhook
$(DESTDIR)/usr/share/$(PACKAGE)-agent/lib/
install -D agent/target/transformed/*
$(DESTDIR)/$(SYSCONFDIR)/$(PACKAGE)/agent
--
To stop receiving notification emails like this one, please contact
['"commits@cloudstack.apache.org" '].
[GitHub] rhtyd closed pull request #2094: Agent logrotation
rhtyd closed pull request #2094: Agent logrotation URL: https://github.com/apache/cloudstack/pull/2094 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #1966: CLOUDSTACK-9801: IPSec VPN does not work after vRouter reboot or recreate
rhtyd commented on issue #1966: CLOUDSTACK-9801: IPSec VPN does not work after vRouter reboot or recreate URL: https://github.com/apache/cloudstack/pull/1966#issuecomment-319815845 Ping, any discussions/reviews? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2073: CLOUDSTACK-9896: API: listDedicatedXXX should respect pagination
blueorangutan commented on issue #2073: CLOUDSTACK-9896: API: listDedicatedXXX should respect pagination URL: https://github.com/apache/cloudstack/pull/2073#issuecomment-319815292 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2073: CLOUDSTACK-9896: API: listDedicatedXXX should respect pagination
rhtyd commented on issue #2073: CLOUDSTACK-9896: API: listDedicatedXXX should respect pagination URL: https://github.com/apache/cloudstack/pull/2073#issuecomment-319815128 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2078: CLOUDSTACK-9902: add consoleproxy.sslEnable toggle
rhtyd commented on issue #2078: CLOUDSTACK-9902: add consoleproxy.sslEnable toggle URL: https://github.com/apache/cloudstack/pull/2078#issuecomment-319814980 @nathanejohnson can you move the schema changes to 4.10->4.11 db upgrade path This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[cloudstack] branch master updated: CLOUDSTACK-9954 Unable to create service offering with networkrate=0 (#2142)
This is an automated email from the ASF dual-hosted git repository.
bhaisaab pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git
The following commit(s) were added to refs/heads/master by this push:
new 7fea069 CLOUDSTACK-9954 Unable to create service offering with
networkrate=0 (#2142)
7fea069 is described below
commit 7fea069e8ad8c694b18aed1ebbb73b3946297653
Author: SowjanyaPatha
AuthorDate: Thu Aug 3 03:49:38 2017 +0530
CLOUDSTACK-9954 Unable to create service offering with networkrate=0 (#2142)
Unable to create service offering with networkrate=0(Unlimited network
throttling) with an error "Failed to create service offering xxx: specify
the network rate value more than 0".
---
server/src/com/cloud/configuration/ConfigurationManagerImpl.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/server/src/com/cloud/configuration/ConfigurationManagerImpl.java
b/server/src/com/cloud/configuration/ConfigurationManagerImpl.java
index f7a6104..6c66fa3 100755
--- a/server/src/com/cloud/configuration/ConfigurationManagerImpl.java
+++ b/server/src/com/cloud/configuration/ConfigurationManagerImpl.java
@@ -2054,7 +2054,7 @@ public class ConfigurationManagerImpl extends ManagerBase
implements Configurati
if(!allowNetworkRate) {
throw new InvalidParameterValueException("Network rate can be
specified only for non-System offering and system offerings having
\"domainrouter\" systemvmtype");
}
-if(cmd.getNetworkRate().intValue() < 1) {
+if(cmd.getNetworkRate().intValue() < 0) {
throw new InvalidParameterValueException("Failed to create
service offering " + name + ": specify the network rate value more than 0");
}
}
--
To stop receiving notification emails like this one, please contact
['"commits@cloudstack.apache.org" '].
[GitHub] rhtyd closed pull request #2142: CLOUDSTACK-9954 Unable to create service offering with networkrate=0
rhtyd closed pull request #2142: CLOUDSTACK-9954 Unable to create service offering with networkrate=0 URL: https://github.com/apache/cloudstack/pull/2142 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2190: CLOUDSTACK-10010: Fixed the negotiation of S2S VPN connections
rhtyd commented on issue #2190: CLOUDSTACK-10010: Fixed the negotiation of S2S VPN connections URL: https://github.com/apache/cloudstack/pull/2190#issuecomment-319814210 @swill tests still seem to fail This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #1255: Cloudstack-8961: Changes related to the UI of VPN Users management.
rhtyd commented on issue #1255: Cloudstack-8961: Changes related to the UI of VPN Users management. URL: https://github.com/apache/cloudstack/pull/1255#issuecomment-319814047 Closed with https://github.com/apache/cloudstack/pull/2130 merged. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[cloudstack] branch master updated: CLOUDSTACK-8961: Changes related to the UI of VPN Users management. (#2130)
This is an automated email from the ASF dual-hosted git repository.
bhaisaab pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git
The following commit(s) were added to refs/heads/master by this push:
new 1b898d6 CLOUDSTACK-8961: Changes related to the UI of VPN Users
management. (#2130)
1b898d6 is described below
commit 1b898d610c7c8fe6da34e299052d71faee64bbeb
Author: Nitin Kumar Maharana
AuthorDate: Thu Aug 3 03:44:53 2017 +0530
CLOUDSTACK-8961: Changes related to the UI of VPN Users management. (#2130)
The current VPN users are added in the VPN tab inside the public IP after
the VPN is enabled. For each network(for which VPN is supported and enabled),
the VPN users are shared. As the Cloudstack doc says “ The account owner can
create and manage users for their VPN. CloudStack does not use its account
database for this purpose but uses a separate table. The VPN user database is
shared across all the VPNs created by the account owner. All VPN users get
access to all VPNs created by th [...]
The current implementation of going inside each network and adding VPN
users give the first feel as if the users are network based. To fix this,
Shifted the VPN users to networks tab view.
---
ui/l10n/en.js | 3 +
ui/scripts/network.js | 393 ++
2 files changed, 303 insertions(+), 93 deletions(-)
diff --git a/ui/l10n/en.js b/ui/l10n/en.js
index bd6ac0a..a579784 100644
--- a/ui/l10n/en.js
+++ b/ui/l10n/en.js
@@ -1777,6 +1777,7 @@ var dictionary = {"ICMP.code":"ICMP Code",
"label.vpn":"VPN",
"label.vpn.customer.gateway":"VPN Customer Gateway",
"label.vpn.force.encapsulation":"Force UDP Encapsulation of ESP Packets",
+"label.vpn.users":"VPN Users",
"label.vsmctrlvlanid":"Control VLAN ID",
"label.vsmpktvlanid":"Packet VLAN ID",
"label.vsmstoragevlanid":"Storage VLAN ID",
@@ -1847,6 +1848,7 @@ var dictionary = {"ICMP.code":"ICMP Code",
"message.action.delete.template":"Please confirm that you want to delete this
template.",
"message.action.delete.template.for.all.zones":"The template is used by all
zones. Please confirm that you want to delete it from all zones.",
"message.action.delete.volume":"Please confirm that you want to delete this
volume.",
+"message.action.delete.vpn.user":"Please confirm that you want to delete the
VPN user.",
"message.action.delete.zone":"Please confirm that you want to delete this
zone.",
"message.action.destroy.instance":"Please confirm that you want to destroy
this instance.",
"message.action.destroy.systemvm":"Please confirm that you want to destroy
this System VM.",
@@ -2077,6 +2079,7 @@ var dictionary = {"ICMP.code":"ICMP Code",
"message.enable.vpn.access":"VPN is currently disabled for this IP Address.
Would you like to enable VPN access?",
"message.enabled.vpn":"Your Remote Access VPN is currently enabled and can be
accessed via the IP",
"message.enabled.vpn.ip.sec":"Your IPSec pre-shared key is",
+"message.enabled.vpn.note":"Note: VPN users are now accessed by changing views
at the networks tab.",
"message.enabling.network.offering":"Enabling network offering",
"message.enabling.security.group.provider":"Enabling Security Group provider",
"message.enabling.vpc.offering":"Enabling VPC offering",
diff --git a/ui/scripts/network.js b/ui/scripts/network.js
index f365cf5..7f27373 100644
--- a/ui/scripts/network.js
+++ b/ui/scripts/network.js
@@ -400,6 +400,23 @@
}
}
}
+//Ajax call to check if VPN is enabled.
+$.ajax({
+url: createURL('listRemoteAccessVpns'),
+data: {
+account: g_account,
+domainid: g_domainid,
+listAll: true
+},
+async: false,
+success: function(vpnResponse) {
+var isVPNEnabled =
vpnResponse.listremoteaccessvpnsresponse.count;
+
+if (isVPNEnabled) {
+sectionsToShow.push('vpnuser');
+}
+}
+});
}
});
@@ -4259,99 +4276,11 @@
$('').addClass('psk').html(_l('message.enabled.vpn.ip.sec') + ' ')
.append($('').html(psk))
)
-).multiEdit({
-context: args.context,
-noSelect: true,
-fields: {
-
[GitHub] rhtyd closed pull request #2130: CLOUDSTACK-8961: Changes related to the UI of VPN Users management.
rhtyd closed pull request #2130: CLOUDSTACK-8961: Changes related to the UI of VPN Users management. URL: https://github.com/apache/cloudstack/pull/2130 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd closed pull request #1255: Cloudstack-8961: Changes related to the UI of VPN Users management.
rhtyd closed pull request #1255: Cloudstack-8961: Changes related to the UI of VPN Users management. URL: https://github.com/apache/cloudstack/pull/1255 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2130: CLOUDSTACK-8961: Changes related to the UI of VPN Users management.
rhtyd commented on issue #2130: CLOUDSTACK-8961: Changes related to the UI of VPN Users management. URL: https://github.com/apache/cloudstack/pull/2130#issuecomment-319813790 LGTM, merging based on manual test reviews by @remibergsma and Travis regression tests. This is purely UI change, trillian based tests are not necessary. Merging. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on a change in pull request #2181: CLOUDSTACK-9957 Annotations
rhtyd commented on a change in pull request #2181: CLOUDSTACK-9957 Annotations
URL: https://github.com/apache/cloudstack/pull/2181#discussion_r131009939
##
File path:
api/src/org/apache/cloudstack/api/command/admin/annotation/RemoveAnnotationCmd.java
##
@@ -0,0 +1,66 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+package org.apache.cloudstack.api.command.admin.annotation;
+
+import com.cloud.exception.ConcurrentOperationException;
+import com.cloud.exception.InsufficientCapacityException;
+import com.cloud.exception.NetworkRuleConflictException;
+import com.cloud.exception.ResourceAllocationException;
+import com.cloud.exception.ResourceUnavailableException;
+import com.cloud.user.Account;
+import org.apache.cloudstack.acl.RoleType;
+import org.apache.cloudstack.api.APICommand;
+import org.apache.cloudstack.api.ApiConstants;
+import org.apache.cloudstack.api.BaseCmd;
+import org.apache.cloudstack.api.Parameter;
+import org.apache.cloudstack.api.ServerApiException;
+import org.apache.cloudstack.api.response.AnnotationResponse;
+
+@APICommand(name = RemoveAnnotationCmd.APINAME, description = "remove an
annotation.", responseObject = AnnotationResponse.class,
+requestHasSensitiveInfo = false, responseHasSensitiveInfo = false,
since = "4.11", authorized = {RoleType.Admin})
Review comment:
same as above, please see ^^
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] rhtyd commented on a change in pull request #2181: CLOUDSTACK-9957 Annotations
rhtyd commented on a change in pull request #2181: CLOUDSTACK-9957 Annotations URL: https://github.com/apache/cloudstack/pull/2181#discussion_r131010010 ## File path: api/src/org/apache/cloudstack/api/response/AnnotationResponse.java ## @@ -0,0 +1,121 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. +package org.apache.cloudstack.api.response; + +import com.cloud.serializer.Param; +import com.google.gson.annotations.SerializedName; +import org.apache.cloudstack.annotation.Annotation; +import org.apache.cloudstack.annotation.AnnotationService; +import org.apache.cloudstack.api.ApiConstants; +import org.apache.cloudstack.api.BaseResponse; +import org.apache.cloudstack.api.EntityReference; + +import java.util.Date; + +/** + * @since 4.11 Review comment: The comment is useless, not necessary. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on a change in pull request #2181: CLOUDSTACK-9957 Annotations
rhtyd commented on a change in pull request #2181: CLOUDSTACK-9957 Annotations URL: https://github.com/apache/cloudstack/pull/2181#discussion_r131010070 ## File path: engine/schema/src/org/apache/cloudstack/annotation/AnnotationVO.java ## @@ -0,0 +1,154 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. +package org.apache.cloudstack.annotation; + +import com.cloud.utils.db.GenericDao; + +import javax.persistence.Column; +import javax.persistence.Entity; +import javax.persistence.GeneratedValue; +import javax.persistence.GenerationType; +import javax.persistence.Id; +import javax.persistence.Table; +import java.util.Date; +import java.util.UUID; + +/** + * @since 4.11 Review comment: The comment in not necessary. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on a change in pull request #2181: CLOUDSTACK-9957 Annotations
rhtyd commented on a change in pull request #2181: CLOUDSTACK-9957 Annotations URL: https://github.com/apache/cloudstack/pull/2181#discussion_r131010097 ## File path: engine/schema/src/org/apache/cloudstack/annotation/dao/AnnotationDao.java ## @@ -0,0 +1,30 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. +package org.apache.cloudstack.annotation.dao; + +import org.apache.cloudstack.annotation.AnnotationVO; +import com.cloud.utils.db.GenericDao; + +import java.util.List; + +/** Review comment: The comment is not necessary. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on a change in pull request #2181: CLOUDSTACK-9957 Annotations
rhtyd commented on a change in pull request #2181: CLOUDSTACK-9957 Annotations
URL: https://github.com/apache/cloudstack/pull/2181#discussion_r131009905
##
File path:
api/src/org/apache/cloudstack/api/command/admin/annotation/ListAnnotationsCmd.java
##
@@ -0,0 +1,81 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+package org.apache.cloudstack.api.command.admin.annotation;
+
+import com.cloud.exception.ConcurrentOperationException;
+import com.cloud.exception.InsufficientCapacityException;
+import com.cloud.exception.NetworkRuleConflictException;
+import com.cloud.exception.ResourceAllocationException;
+import com.cloud.exception.ResourceUnavailableException;
+import com.cloud.utils.StringUtils;
+import com.google.common.base.Preconditions;
+import org.apache.cloudstack.acl.RoleType;
+import org.apache.cloudstack.api.APICommand;
+import org.apache.cloudstack.api.ApiConstants;
+import org.apache.cloudstack.api.BaseCmd;
+import org.apache.cloudstack.api.BaseListCmd;
+import org.apache.cloudstack.api.Parameter;
+import org.apache.cloudstack.api.ServerApiException;
+import org.apache.cloudstack.api.response.AnnotationResponse;
+import org.apache.cloudstack.api.response.ListResponse;
+
+@APICommand(name = ListAnnotationsCmd.APINAME, description = "Lists
annotations.", responseObject = AnnotationResponse.class,
+requestHasSensitiveInfo = false, responseHasSensitiveInfo = false,
since = "4.11", authorized = {RoleType.Admin})
Review comment:
Same as above, if we allow annotations to be created by users let allow them
here.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] rhtyd commented on a change in pull request #2181: CLOUDSTACK-9957 Annotations
rhtyd commented on a change in pull request #2181: CLOUDSTACK-9957 Annotations
URL: https://github.com/apache/cloudstack/pull/2181#discussion_r131009819
##
File path:
api/src/org/apache/cloudstack/api/command/admin/annotation/AddAnnotationCmd.java
##
@@ -0,0 +1,83 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+package org.apache.cloudstack.api.command.admin.annotation;
+
+import com.cloud.exception.ConcurrentOperationException;
+import com.cloud.exception.InsufficientCapacityException;
+import com.cloud.exception.NetworkRuleConflictException;
+import com.cloud.exception.ResourceAllocationException;
+import com.cloud.exception.ResourceUnavailableException;
+import com.cloud.user.Account;
+import com.google.common.base.Preconditions;
+import org.apache.cloudstack.annotation.AnnotationService;
+import org.apache.cloudstack.api.APICommand;
+import org.apache.cloudstack.api.ApiConstants;
+import org.apache.cloudstack.api.BaseCmd;
+import org.apache.cloudstack.api.Parameter;
+import org.apache.cloudstack.api.ServerApiException;
+import org.apache.cloudstack.api.response.AnnotationResponse;
+
+/**
+ * @since 4.11
+ */
+@APICommand(name = AddAnnotationCmd.APINAME, description = "add an
annotation.", responseObject = AnnotationResponse.class,
+requestHasSensitiveInfo = false, responseHasSensitiveInfo = false)
+public class AddAnnotationCmd extends BaseCmd{
+
+@Parameter(name = ApiConstants.ANNOTATION, type = CommandType.STRING,
description = "the annotation text")
+private String annotation;
+@Parameter(name = ApiConstants.ENTITY_TYPE, type = CommandType.STRING,
description = "the entity type")
+private String entityType;
+@Parameter(name = ApiConstants.ENTITY_ID, type = CommandType.STRING,
description = "the id of the entity to annotate")
+private String entityUuid;
+
+public String getAnnotation() {
+return annotation;
+}
+
+public AnnotationService.EntityType getEntityType() {
+return AnnotationService.EntityType.valueOf(entityType);
+}
+
+public String getEntityUuid() {
+return entityUuid;
+}
+
+public static final String APINAME = "addAnnotation";
+
+@Override
+public void execute()
+throws ResourceUnavailableException,
InsufficientCapacityException, ServerApiException,
ConcurrentOperationException, ResourceAllocationException,
+NetworkRuleConflictException {
+Preconditions.checkNotNull(entityUuid,"I have to have an entity to set
an annotation on!");
+AnnotationResponse annotationResponse =
annotationService.addAnnotation(this);
+annotationResponse.setResponseName(getCommandName());
+this.setResponseObject(annotationResponse);
+}
+
+@Override
+public String getCommandName() {
+return APINAME.toLowerCase() + BaseCmd.RESPONSE_SUFFIX;
+}
+
+@Override
+public long getEntityOwnerId() {
+// for now all annotations are belong to us
+return Account.ACCOUNT_ID_SYSTEM;
Review comment:
Use CallContext to get calling user
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] rhtyd commented on a change in pull request #2181: CLOUDSTACK-9957 Annotations
rhtyd commented on a change in pull request #2181: CLOUDSTACK-9957 Annotations
URL: https://github.com/apache/cloudstack/pull/2181#discussion_r131009770
##
File path:
api/src/org/apache/cloudstack/api/command/admin/annotation/AddAnnotationCmd.java
##
@@ -0,0 +1,81 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+package org.apache.cloudstack.api.command.admin.annotation;
+
+import com.cloud.exception.ConcurrentOperationException;
+import com.cloud.exception.InsufficientCapacityException;
+import com.cloud.exception.NetworkRuleConflictException;
+import com.cloud.exception.ResourceAllocationException;
+import com.cloud.exception.ResourceUnavailableException;
+import com.cloud.user.Account;
+import com.google.common.base.Preconditions;
+import org.apache.cloudstack.acl.RoleType;
+import org.apache.cloudstack.annotation.AnnotationService;
+import org.apache.cloudstack.api.APICommand;
+import org.apache.cloudstack.api.ApiConstants;
+import org.apache.cloudstack.api.BaseCmd;
+import org.apache.cloudstack.api.Parameter;
+import org.apache.cloudstack.api.ServerApiException;
+import org.apache.cloudstack.api.response.AnnotationResponse;
+
+@APICommand(name = AddAnnotationCmd.APINAME, description = "add an
annotation.", responseObject = AnnotationResponse.class,
+requestHasSensitiveInfo = false, responseHasSensitiveInfo = false,
since = "4.11", authorized = {RoleType.Admin})
Review comment:
Do we want anyone to annotate their resources, say VMs? i.e. allow users?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] rhtyd commented on a change in pull request #2181: CLOUDSTACK-9957 Annotations
rhtyd commented on a change in pull request #2181: CLOUDSTACK-9957 Annotations URL: https://github.com/apache/cloudstack/pull/2181#discussion_r131010147 ## File path: engine/schema/src/org/apache/cloudstack/annotation/dao/AnnotationDaoImpl.java ## @@ -0,0 +1,59 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. +package org.apache.cloudstack.annotation.dao; + +import com.cloud.utils.db.GenericDaoBase; +import com.cloud.utils.db.SearchBuilder; +import com.cloud.utils.db.SearchCriteria; +import org.apache.cloudstack.annotation.AnnotationVO; +import org.springframework.stereotype.Component; + +import java.util.List; + +/** + * @since 4.1 Review comment: Remove this comment please, this is not necessary. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2217: [4.9] Smoketest health checkrun
rhtyd commented on issue #2217: [4.9] Smoketest health checkrun URL: https://github.com/apache/cloudstack/pull/2217#issuecomment-319811798 @borisstoyanov can you help go through the list of failures and identify if they are ignorable or we need to fix them, or revert some of the backported changes in 4.9 branch. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] nitin-maharana commented on issue #1859: CLOUDSTACK-8672 : NCC Integration with CloudStack.
nitin-maharana commented on issue #1859: CLOUDSTACK-8672 : NCC Integration with CloudStack. URL: https://github.com/apache/cloudstack/pull/1859#issuecomment-297402316 Hi @rafaelweingartner : I have created one more PR with reduced number of commits. Please find this PR #2031 . This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] nitin-maharana commented on issue #1859: CLOUDSTACK-8672 : NCC Integration with CloudStack.
nitin-maharana commented on issue #1859: CLOUDSTACK-8672 : NCC Integration with CloudStack. URL: https://github.com/apache/cloudstack/pull/1859#issuecomment-319722471 TEST This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] nitin-maharana commented on issue #1859: CLOUDSTACK-8672 : NCC Integration with CloudStack.
nitin-maharana commented on issue #1859: CLOUDSTACK-8672 : NCC Integration with CloudStack. URL: https://github.com/apache/cloudstack/pull/1859#issuecomment-319722471 TEST This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2217: [4.9] Smoketest health checkrun
blueorangutan commented on issue #2217: [4.9] Smoketest health checkrun URL: https://github.com/apache/cloudstack/pull/2217#issuecomment-319706261 Trillian test result (tid-1303) Environment: vmware-55u3 (x2), Advanced Networking with Mgmt server 7 Total time taken: 54181 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2217-t1303-vmware-55u3.zip Intermitten failure detected: /marvin/tests/smoke/test_list_ids_parameter.py Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py Intermitten failure detected: /marvin/tests/smoke/test_routers_network_ops.py Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py Intermitten failure detected: /marvin/tests/smoke/test_vpc_router_nics.py Intermitten failure detected: /marvin/tests/smoke/test_vpc_vpn.py Test completed. 49 look OK, 5 have error(s) Test | Result | Time (s) | Test File --- | --- | --- | --- test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | `Failure` | 434.54 | test_vpc_redundant.py test_02_redundant_VPC_default_routes | `Failure` | 1359.24 | test_vpc_redundant.py test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | `Failure` | 411.11 | test_routers_network_ops.py test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | `Failure` | 420.23 | test_routers_network_ops.py test_04_rvpc_privategw_static_routes | `Failure` | 831.03 | test_privategw_acl.py test_02_vpc_privategw_static_routes | `Failure` | 489.08 | test_privategw_acl.py test_01_vpc_site2site_vpn | `Error` | 513.93 | test_vpc_vpn.py test_01_redundant_vpc_site2site_vpn | `Error` | 704.79 | test_vpc_vpn.py ContextSuite context=TestListIdsParams>:setup | `Error` | 0.00 | test_list_ids_parameter.py test_08_resize_volume | Skipped | 10.17 | test_volumes.py test_07_resize_fail | Skipped | 15.44 | test_volumes.py test_09_copy_delete_template | Skipped | 0.02 | test_templates.py test_06_copy_template | Skipped | 0.00 | test_templates.py test_static_role_account_acls | Skipped | 0.03 | test_staticroles.py test_01_scale_vm | Skipped | 63.39 | test_scale_vm.py test_01_primary_storage_iscsi | Skipped | 0.04 | test_primary_storage.py test_vm_nic_adapter_vmxnet3 | Skipped | 0.00 | test_nic_adapter_type.py test_06_copy_iso | Skipped | 0.00 | test_iso.py test_deploy_vgpu_enabled_vm | Skipped | 0.00 | test_deploy_vgpu_enabled_vm.py This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] borisstoyanov opened a new pull request #2219: CLOUDSTACK-9989: Extend smoketests suite
borisstoyanov opened a new pull request #2219: CLOUDSTACK-9989: Extend smoketests suite URL: https://github.com/apache/cloudstack/pull/2219 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #1246: CLOUDSTACK-9165 unable to use reserved IP range in a network for exte?
blueorangutan commented on issue #1246: CLOUDSTACK-9165 unable to use reserved IP range in a network for exte? URL: https://github.com/apache/cloudstack/pull/1246#issuecomment-319698199 Packaging result: ?centos6 ?centos7 ?debian. JID-901 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] borisstoyanov commented on issue #2209: CLOUDSTACK-10017: Adding 'quick-test' attribute to list of smoketests?
borisstoyanov commented on issue #2209: CLOUDSTACK-10017: Adding 'quick-test' attribute to list of smoketests? URL: https://github.com/apache/cloudstack/pull/2209#issuecomment-319692039 Thanks @rhtyd, I've rebased and squashed all the commits This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #1246: CLOUDSTACK-9165 unable to use reserved IP range in a network for exte?
blueorangutan commented on issue #1246: CLOUDSTACK-9165 unable to use reserved IP range in a network for exte? URL: https://github.com/apache/cloudstack/pull/1246#issuecomment-319679083 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #1246: CLOUDSTACK-9165 unable to use reserved IP range in a network for exte?
rhtyd commented on issue #1246: CLOUDSTACK-9165 unable to use reserved IP range in a network for exte? URL: https://github.com/apache/cloudstack/pull/1246#issuecomment-319678785 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2217: [4.9] Smoketest health checkrun
blueorangutan commented on issue #2217: [4.9] Smoketest health checkrun URL: https://github.com/apache/cloudstack/pull/2217#issuecomment-319676741 Trillian test result (tid-1301) Environment: xenserver-65sp1 (x2), Advanced Networking with Mgmt server 6 Total time taken: 62466 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2217-t1301-xenserver-65sp1.zip Intermitten failure detected: /marvin/tests/smoke/test_network.py Intermitten failure detected: /marvin/tests/smoke/test_nic.py Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py Intermitten failure detected: /marvin/tests/smoke/test_router_dhcphosts.py Intermitten failure detected: /marvin/tests/smoke/test_router_dns.py Intermitten failure detected: /marvin/tests/smoke/test_routers_network_ops.py Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py Intermitten failure detected: /marvin/tests/smoke/test_vpc_router_nics.py Test completed. 48 look OK, 6 have error(s) Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_VPC_nics_after_destroy | `Failure` | 812.63 | test_vpc_router_nics.py test_05_rvpc_multi_tiers | `Failure` | 588.92 | test_vpc_redundant.py test_04_rvpc_network_garbage_collector_nics | `Failure` | 1516.22 | test_vpc_redundant.py test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 691.29 | test_vpc_redundant.py test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | `Failure` | 526.14 | test_routers_network_ops.py test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | `Failure` | 555.73 | test_routers_network_ops.py test_04_rvpc_privategw_static_routes | `Failure` | 1125.08 | test_privategw_acl.py test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | `Error` | 723.56 | test_vpc_redundant.py test_03_vpc_privategw_restart_vpc_cleanup | `Error` | 967.94 | test_privategw_acl.py test_01_nic | `Error` | 368.15 | test_nic.py test_reboot_router | `Error` | 629.12 | test_network.py test_09_copy_delete_template | Skipped | 0.01 | test_templates.py test_06_copy_template | Skipped | 0.00 | test_templates.py test_static_role_account_acls | Skipped | 0.02 | test_staticroles.py test_vm_nic_adapter_vmxnet3 | Skipped | 0.00 | test_nic_adapter_type.py test_06_copy_iso | Skipped | 0.00 | test_iso.py test_deploy_vgpu_enabled_vm | Skipped | 0.01 | test_deploy_vgpu_enabled_vm.py This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2209: CLOUDSTACK-10017: Adding 'quick-test' attribute to list of smoketests?
rhtyd commented on issue #2209: CLOUDSTACK-10017: Adding 'quick-test' attribute to list of smoketests? URL: https://github.com/apache/cloudstack/pull/2209#issuecomment-319671507 Good effort, @borisstoyanov can you rebase Github is such a complainer :) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2218: CLOUDSTACK-9782: New Background Polling Task Manager
blueorangutan commented on issue #2218: CLOUDSTACK-9782: New Background Polling Task Manager URL: https://github.com/apache/cloudstack/pull/2218#issuecomment-319659778 @borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] borisstoyanov commented on issue #2218: CLOUDSTACK-9782: New Background Polling Task Manager
borisstoyanov commented on issue #2218: CLOUDSTACK-9782: New Background Polling Task Manager URL: https://github.com/apache/cloudstack/pull/2218#issuecomment-319659709 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] syed commented on issue #2204: [CLOUDSTACK-10025] Adding Support for NoVNC Console for KVM
syed commented on issue #2204: [CLOUDSTACK-10025] Adding Support for NoVNC Console for KVM URL: https://github.com/apache/cloudstack/pull/2204#issuecomment-319658897 @sachinnitw1317 Can you also have a look at [https://github.com/syed/java-websockify/blob/withauth/src/main/java/WsHandlerWithAuth.java](https://github.com/syed/java-websockify/blob/withauth/src/main/java/WsHandlerWithAuth.java) for a better implementation of the proxy. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2218: CLOUDSTACK-9782: New Background Polling Task Manager
rhtyd commented on issue #2218: CLOUDSTACK-9782: New Background Polling Task Manager URL: https://github.com/apache/cloudstack/pull/2218#issuecomment-319623377 @borisstoyanov @DaanHoogland and others - please review. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] borisstoyanov commented on issue #2203: All private, public, and guest interfaceses are marked as untagged ca?
borisstoyanov commented on issue #2203: All private, public, and guest interfaceses are marked as untagged ca? URL: https://github.com/apache/cloudstack/pull/2203#issuecomment-319591440 Hi @konstantintrushin, you can create a ticket describing your improvement/bugfix in the community JIRA: https://issues.apache.org/jira/browse/cloudstack/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
