[GitHub] marcaurele commented on issue #1934: [CLOUDSTACK-9772] Template: perform a HEAD request to check file size from a URL

[GitBox]

marcaurele commented on issue #1934: [CLOUDSTACK-9772] Template: perform a HEAD 
request to check file size from a URL
URL: https://github.com/apache/cloudstack/pull/1934#issuecomment-347766735
 
 
   @rhtyd ready on my side with the fallback on a GET request if the HEAD fails


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2343: [WIP] CLOUDSTACK-10161: Use Maven wrapper

[GitBox]

rhtyd commented on issue #2343: [WIP] CLOUDSTACK-10161: Use Maven wrapper
URL: https://github.com/apache/cloudstack/pull/2343#issuecomment-347725108
 
 
   This will replace one tool dependency (mvn) to another (mvnw) and also 
addition of library (.jar file) in codebase is not recommended. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] khos2ow commented on issue #2283: CLOUDSTACK-10105: Maven standard

[GitBox]

khos2ow commented on issue #2283: CLOUDSTACK-10105: Maven standard
URL: https://github.com/apache/cloudstack/pull/2283#issuecomment-347626821
 
 
   @marcaurele @rhtyd Hi. Is there any update/ETA on this PR? The reason is I 
created another PR (#2343) which somehow has the same nature and it's still WIP.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] khos2ow commented on issue #2283: CLOUDSTACK-10105: Maven standard

[GitBox]

khos2ow commented on issue #2283: CLOUDSTACK-10105: Maven standard
URL: https://github.com/apache/cloudstack/pull/2283#issuecomment-347626821
 
 
   @marcaurele @rhtyd Hi. Is there any update/ETA on this PR? The reason is I 
created another PR (#2343) which is somehow has the same nature and it's still 
WIP.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] khos2ow opened a new pull request #2343: [WIP] Use Maven wrapper

[GitBox]

khos2ow opened a new pull request #2343: [WIP] Use Maven wrapper
URL: https://github.com/apache/cloudstack/pull/2343
 
 
   Use maven wrapper to be used as `./mvnw foo bar -Pbaz` instead of `mvn foo 
bar -Pbaz`.
   
   - wrapper is checked in directly in the repository
   - no need to have maven installed on OS


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on a change in pull request #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9

[GitBox]

rhtyd commented on a change in pull request #2211: CLOUDSTACK-10013: Migrate 
systemvmtemplate to Debian9
URL: https://github.com/apache/cloudstack/pull/2211#discussion_r153578554
 
 

 ##
 File path: tools/appliance/definitions/systemvmtemplate/configure_networking.sh
 ##
 @@ -21,13 +21,6 @@ set -x
 
 HOSTNAME=systemvm
 
-# Adding a 2 sec delay to the interface up, to make the dhclient happy
-function set_interface_sleep() {
-  grep "pre-up sleep 2" /etc/network/interfaces && return
-
-  echo "pre-up sleep 2" >> /etc/network/interfaces
-}
-
 function configure_resolv_conf() {
   grep 8.8.8.8 /etc/resolv.conf && grep 8.8.4.4 /etc/resolv.conf && return
 
 Review comment:
   I'll check and remove.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on a change in pull request #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9

[GitBox]

rhtyd commented on a change in pull request #2211: CLOUDSTACK-10013: Migrate 
systemvmtemplate to Debian9
URL: https://github.com/apache/cloudstack/pull/2211#discussion_r153578494
 
 

 ##
 File path: 
tools/appliance/definitions/systemvmtemplate/install_systemvm_packages.sh
 ##
 @@ -52,9 +52,9 @@ function install_packages() {
 ${apt_get} install links:i386 libuuid1:i386 libc6:i386
   fi
 
-  ${apt_get} install \
-rsyslog logrotate cron chkconfig insserv net-tools ifupdown vim-tiny 
netbase iptables \
-openssh-server e2fsprogs dhcp3-client tcpdump socat wget \
+  ${apt_get} install grub-legacy \
+rsyslog logrotate cron insserv net-tools ifupdown vim tmux netbase 
iptables \
 
 Review comment:
   Can be removed, will test.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #1940: CLOUDSTACK-9781:ACS records ID in events tables instead of UUID.

[GitBox]

blueorangutan commented on issue #1940: CLOUDSTACK-9781:ACS records ID in 
events tables instead of UUID.
URL: https://github.com/apache/cloudstack/pull/1940#issuecomment-347575225
 
 
   Packaging result: ?centos6 ?centos7 ?debian. JID-1316


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #1740: CLOUDSTACK-9572 Snapshot on primary storage not cleaned up after Stor?

[GitBox]

blueorangutan commented on issue #1740: CLOUDSTACK-9572 Snapshot on primary 
storage not cleaned up after Stor?
URL: https://github.com/apache/cloudstack/pull/1740#issuecomment-347575272
 
 
   Packaging result: ?centos6 ?centos7 ?debian. JID-1318


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2312: CLOUDSTACK-7793 Create Snaphot with quiesce option set to true fails ?

[GitBox]

blueorangutan commented on issue #2312: CLOUDSTACK-7793 Create Snaphot with 
quiesce option set to true fails ?
URL: https://github.com/apache/cloudstack/pull/2312#issuecomment-347575227
 
 
   Packaging result: ?centos6 ?centos7 ?debian. JID-1317


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] resmo commented on a change in pull request #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9

[GitBox]

resmo commented on a change in pull request #2211: CLOUDSTACK-10013: Migrate 
systemvmtemplate to Debian9
URL: https://github.com/apache/cloudstack/pull/2211#discussion_r153526904
 
 

 ##
 File path: 
tools/appliance/definitions/systemvmtemplate/install_systemvm_packages.sh
 ##
 @@ -52,9 +52,9 @@ function install_packages() {
 ${apt_get} install links:i386 libuuid1:i386 libc6:i386
   fi
 
-  ${apt_get} install \
-rsyslog logrotate cron chkconfig insserv net-tools ifupdown vim-tiny 
netbase iptables \
-openssh-server e2fsprogs dhcp3-client tcpdump socat wget \
+  ${apt_get} install grub-legacy \
+rsyslog logrotate cron insserv net-tools ifupdown vim tmux netbase 
iptables \
 
 Review comment:
   is `inserv` really needed?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #1554: CLOUDSTACK-9602: API: improve resource limits comprehension

[GitBox]

blueorangutan commented on issue #1554: CLOUDSTACK-9602: API: improve resource 
limits comprehension
URL: https://github.com/apache/cloudstack/pull/1554#issuecomment-347559026
 
 
   Packaging result: ?centos6 ?centos7 ?debian. JID-1315


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #1760: CLOUDSTACK-9593: userdata: enforce data is a multiple of 4 characters

[GitBox]

blueorangutan commented on issue #1760: CLOUDSTACK-9593: userdata: enforce data 
is a multiple of 4 characters
URL: https://github.com/apache/cloudstack/pull/1760#issuecomment-347559025
 
 
   Packaging result: ?centos6 ?centos7 ?debian. JID-1314


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rafaelweingartner commented on a change in pull request #2340: CLOUDSTACK-10106: GPU/vGPU Support on VMWare

[GitBox]

rafaelweingartner commented on a change in pull request #2340: 
CLOUDSTACK-10106: GPU/vGPU Support on VMWare
URL: https://github.com/apache/cloudstack/pull/2340#discussion_r153520500
 
 

 ##
 File path: 
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
 ##
 @@ -4766,6 +4848,31 @@ protected Answer execute(UnregisterNicCommand cmd) {
 }
 }
 
+/**
+ * GetGPUStatsCommand is used to collect the GPU/vGPU details of all the
+ * GPU enabled hosts.
+ * Do Nothing.
+ * @param cmd
+ * @return Answer
+ */
+protected Answer execute(final GetGPUStatsCommand cmd) {
+final VmwareContext context = getServiceContext();
+final VmwareHypervisorHost hyperHost = getHyperHost(context);
+final HostMO hostMo = new HostMO(context, hyperHost.getMor());
+
+HashMap> groupDetails = new 
HashMap>();
+
+try {
+groupDetails = hostMo.getGPUGroupDetails();
 
 Review comment:
   Yes this one. Then, you could do directly inside the Try/catch:
   ` HashMap> groupDetails = 
hostMo.getGPUGroupDetails()`
   
   This would avoid the creation of a hashmap at line 4863 that is subsequently 
just dropped for the garbage collector.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rafaelweingartner commented on a change in pull request #2340: CLOUDSTACK-10106: GPU/vGPU Support on VMWare

[GitBox]

rafaelweingartner commented on a change in pull request #2340: 
CLOUDSTACK-10106: GPU/vGPU Support on VMWare
URL: https://github.com/apache/cloudstack/pull/2340#discussion_r153520500
 
 

 ##
 File path: 
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
 ##
 @@ -4766,6 +4848,31 @@ protected Answer execute(UnregisterNicCommand cmd) {
 }
 }
 
+/**
+ * GetGPUStatsCommand is used to collect the GPU/vGPU details of all the
+ * GPU enabled hosts.
+ * Do Nothing.
+ * @param cmd
+ * @return Answer
+ */
+protected Answer execute(final GetGPUStatsCommand cmd) {
+final VmwareContext context = getServiceContext();
+final VmwareHypervisorHost hyperHost = getHyperHost(context);
+final HostMO hostMo = new HostMO(context, hyperHost.getMor());
+
+HashMap> groupDetails = new 
HashMap>();
+
+try {
+groupDetails = hostMo.getGPUGroupDetails();
 
 Review comment:
   Yes this one. Then, you could do directly inside the Try/catch:
   ` HashMap> groupDetails = 
hostMo.getGPUGroupDetails()`
   
   This would avoid the creation of a hashmap that is subsequently just dropped 
for the garbage collector.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9

[GitBox]

blueorangutan commented on issue #2211: CLOUDSTACK-10013: Migrate 
systemvmtemplate to Debian9
URL: https://github.com/apache/cloudstack/pull/2211#issuecomment-347551242
 
 
   Packaging result: ?centos6 ?centos7 ?debian. JID-1313


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] resmo commented on a change in pull request #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9

[GitBox]

resmo commented on a change in pull request #2211: CLOUDSTACK-10013: Migrate 
systemvmtemplate to Debian9
URL: https://github.com/apache/cloudstack/pull/2211#discussion_r153515550
 
 

 ##
 File path: tools/appliance/definitions/systemvmtemplate/configure_networking.sh
 ##
 @@ -21,13 +21,6 @@ set -x
 
 HOSTNAME=systemvm
 
-# Adding a 2 sec delay to the interface up, to make the dhclient happy
-function set_interface_sleep() {
-  grep "pre-up sleep 2" /etc/network/interfaces && return
-
-  echo "pre-up sleep 2" >> /etc/network/interfaces
-}
-
 function configure_resolv_conf() {
   grep 8.8.8.8 /etc/resolv.conf && grep 8.8.4.4 /etc/resolv.conf && return
 
 Review comment:
   this can be removed IMHO since systemd resolvconfd has already a fallback to 
google dns resolvers
   
   #FallbackDNS=8.8.8.8 8.8.4.4 2001:4860:4860:: 2001:4860:4860::8844
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] marcaurele commented on issue #1934: [CLOUDSTACK-9772] Template: perform a HEAD request to check file size from a URL

[GitBox]

marcaurele commented on issue #1934: [CLOUDSTACK-9772] Template: perform a HEAD 
request to check file size from a URL
URL: https://github.com/apache/cloudstack/pull/1934#issuecomment-347543620
 
 
   @rhtyd I will amend the code to support the case with S3 pre-signed URL 
which will potentially fail on a HEAD operation. It will *try* to perform a 
HEAD operation and if it does not work, it tries to do a normal GET. I'll ping 
you when it's updated.
   cc @remibergsma @wido @borisstoyanov 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #1740: CLOUDSTACK-9572 Snapshot on primary storage not cleaned up after Stor?

[GitBox]

blueorangutan commented on issue #1740: CLOUDSTACK-9572 Snapshot on primary 
storage not cleaned up after Stor?
URL: https://github.com/apache/cloudstack/pull/1740#issuecomment-347542511
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #1740: CLOUDSTACK-9572 Snapshot on primary storage not cleaned up after Stor?

[GitBox]

rhtyd commented on issue #1740: CLOUDSTACK-9572 Snapshot on primary storage not 
cleaned up after Stor?
URL: https://github.com/apache/cloudstack/pull/1740#issuecomment-347542359
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2298: CLOUDSTACK-9620: Enhancements for managed storage

[GitBox]

rhtyd commented on issue #2298: CLOUDSTACK-9620: Enhancements for managed 
storage
URL: https://github.com/apache/cloudstack/pull/2298#issuecomment-347542196
 
 
   @mike-tutkowski is this ready for prime time review and testing, or still in 
progress?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2312: CLOUDSTACK-7793 Create Snaphot with quiesce option set to true fails ?

[GitBox]

blueorangutan commented on issue #2312: CLOUDSTACK-7793 Create Snaphot with 
quiesce option set to true fails ?
URL: https://github.com/apache/cloudstack/pull/2312#issuecomment-347541572
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2312: CLOUDSTACK-7793 Create Snaphot with quiesce option set to true fails ?

[GitBox]

rhtyd commented on issue #2312: CLOUDSTACK-7793 Create Snaphot with quiesce 
option set to true fails ?
URL: https://github.com/apache/cloudstack/pull/2312#issuecomment-347541338
 
 
   LGTM @yvsubhash - this needs to be tested first, before this can be 
considered for merging.
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #1835: CLOUDSTACK-9681: Make the migration of volume to go through allocator?

[GitBox]

rhtyd commented on issue #1835: CLOUDSTACK-9681: Make the migration of volume 
to go through allocator?
URL: https://github.com/apache/cloudstack/pull/1835#issuecomment-347541157
 
 
   @anshul1886 please check/fix build failures


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #1940: CLOUDSTACK-9781:ACS records ID in events tables instead of UUID.

[GitBox]

blueorangutan commented on issue #1940: CLOUDSTACK-9781:ACS records ID in 
events tables instead of UUID.
URL: https://github.com/apache/cloudstack/pull/1940#issuecomment-347540935
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #1940: CLOUDSTACK-9781:ACS records ID in events tables instead of UUID.

[GitBox]

rhtyd commented on issue #1940: CLOUDSTACK-9781:ACS records ID in events tables 
instead of UUID.
URL: https://github.com/apache/cloudstack/pull/1940#issuecomment-347540848
 
 
   @jayantpatil1234 please address outstanding questions/comments
   @blueorangutan package
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #1760: CLOUDSTACK-9593: userdata: enforce data is a multiple of 4 characters

[GitBox]

blueorangutan commented on issue #1760: CLOUDSTACK-9593: userdata: enforce data 
is a multiple of 4 characters
URL: https://github.com/apache/cloudstack/pull/1760#issuecomment-347540585
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2263: CLOUDSTACK-10070: Fixing some component tests and adding them in travis

[GitBox]

rhtyd commented on issue #2263: CLOUDSTACK-10070: Fixing some component tests 
and adding them in travis
URL: https://github.com/apache/cloudstack/pull/2263#issuecomment-347540658
 
 
   @borisstoyanov the additional tests are still failing, are you planning to 
work on them or remove the test_organization_states.py from this PR?
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #1760: CLOUDSTACK-9593: userdata: enforce data is a multiple of 4 characters

[GitBox]

rhtyd commented on issue #1760: CLOUDSTACK-9593: userdata: enforce data is a 
multiple of 4 characters
URL: https://github.com/apache/cloudstack/pull/1760#issuecomment-347540468
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #1554: CLOUDSTACK-9602: API: improve resource limits comprehension

[GitBox]

blueorangutan commented on issue #1554: CLOUDSTACK-9602: API: improve resource 
limits comprehension
URL: https://github.com/apache/cloudstack/pull/1554#issuecomment-347540600
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #1554: CLOUDSTACK-9602: API: improve resource limits comprehension

[GitBox]

rhtyd commented on issue #1554: CLOUDSTACK-9602: API: improve resource limits 
comprehension
URL: https://github.com/apache/cloudstack/pull/1554#issuecomment-347540403
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #1934: [CLOUDSTACK-9772] Template: perform a HEAD request to check file size from a URL

[GitBox]

rhtyd commented on issue #1934: [CLOUDSTACK-9772] Template: perform a HEAD 
request to check file size from a URL
URL: https://github.com/apache/cloudstack/pull/1934#issuecomment-347540270
 
 
   @marcaurele are you happy to further testing/merging, or you think this can 
break use-cases for people using URLs where HEAD may not be supported by 
hosting server?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2311: CLOUDSTACK-10134 Optimization of applying port forwarding rules

[GitBox]

rhtyd commented on issue #2311: CLOUDSTACK-10134 Optimization of applying port 
forwarding rules
URL: https://github.com/apache/cloudstack/pull/2311#issuecomment-347539643
 
 
   @yvsubhash please review outstanding test failures, and fix is applicable


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on a change in pull request #2244: CLOUDSTACK-10054:Volume download times out in 3600 seconds

[GitBox]

rhtyd commented on a change in pull request #2244: CLOUDSTACK-10054:Volume 
download times out in 3600 seconds
URL: https://github.com/apache/cloudstack/pull/2244#discussion_r153505547
 
 

 ##
 File path: 
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareStorageManagerImpl.java
 ##
 @@ -98,28 +98,31 @@
 @Override
 public boolean execute(VmwareHostService hostService, 
CreateEntityDownloadURLCommand cmd) {
 DataTO data = cmd.getData();
+int timeout = 
NumbersUtil.parseInt(cmd.getContextParam(VmwareManager.s_vmwareOVAPackageTimeout.key()),
 VmwareManagerImpl.DEFAULT_VM_OVA_PACKAGE_TIMEOUT);
 
 Review comment:
   Instead of `DEFAULT_VM_OVA_PACKAGE_TIMEOUT` use the value dynamically by 
calling a method or reading the current value, using the ConfigKey (i.e. 
multiply them). This will enable admins to change value and enforce new 
settings without restarting the mgmt server(s).


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on a change in pull request #2244: CLOUDSTACK-10054:Volume download times out in 3600 seconds

[GitBox]

rhtyd commented on a change in pull request #2244: CLOUDSTACK-10054:Volume 
download times out in 3600 seconds
URL: https://github.com/apache/cloudstack/pull/2244#discussion_r153505188
 
 

 ##
 File path: 
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManager.java
 ##
 @@ -42,6 +44,9 @@
 static final ConfigKey s_vmwareSearchExcludeFolder = new 
ConfigKey("Advanced", String.class, "vmware.search.exclude.folders", 
null,
 "Comma seperated list of Datastore Folders to exclude from VMWare 
search", true, ConfigKey.Scope.Global);
 
+static final ConfigKey s_vmwareOVAPackageTimeout = new 
ConfigKey(Integer.class, "vmware.package.ova.timeout", 
"Advanced",String.valueOf(VM_OVA_PACKAGE_TIMEOUT_SEC),
 
 Review comment:
   Fix a space after `,`. Remove the `VM_OVA_PACKAGE_TIMEOUT_SEC` and 
`SEC_TO_MILLIS_MULTIPLIER`.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on a change in pull request #2292: CLOUDSTACK-10108:ConfigKey based approach for reading 'ping' configua?

[GitBox]

rhtyd commented on a change in pull request #2292: CLOUDSTACK-10108:ConfigKey 
based approach for reading 'ping' configua?
URL: https://github.com/apache/cloudstack/pull/2292#discussion_r153504694
 
 

 ##
 File path: engine/schema/src/com/cloud/host/dao/HostDaoImpl.java
 ##
 @@ -995,8 +994,8 @@ public boolean updateState(Status oldStatus, Event event, 
Status newStatus, Host
 }
 }
 if (event.equals(Event.ManagementServerDown)) {
-Float pingTimeout = 
NumbersUtil.parseFloat(_configDao.getValue("ping.timeout"), 2.5f);
-Integer pingInterval = 
NumbersUtil.parseInt(_configDao.getValue("ping.interval"), 60);
+float pingTimeout = 
(Float)_configDepot.get("ping.timeout").value();
 
 Review comment:
   @mrunalinikankariya no you can refactor and move a `ConfigKey` to a new 
class that will cause change in its `category` that's all. Please test and try 
this approach instead.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2304: CLOUDSTACK-10127: KVM + Ovs: Incorrect devId on static nat

[GitBox]

blueorangutan commented on issue #2304: CLOUDSTACK-10127: KVM + Ovs: Incorrect 
devId on static nat
URL: https://github.com/apache/cloudstack/pull/2304#issuecomment-347537786
 
 
   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been 
kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2304: CLOUDSTACK-10127: KVM + Ovs: Incorrect devId on static nat

[GitBox]

rhtyd commented on issue #2304: CLOUDSTACK-10127: KVM + Ovs: Incorrect devId on 
static nat
URL: https://github.com/apache/cloudstack/pull/2304#issuecomment-347537489
 
 
   @blueorangutan test


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2274: CLOUDSTACK-10096 Can't reset integration.api.port and usage.sanity.ch?

[GitBox]

blueorangutan commented on issue #2274: CLOUDSTACK-10096 Can't reset 
integration.api.port and usage.sanity.ch?
URL: https://github.com/apache/cloudstack/pull/2274#issuecomment-347537459
 
 
   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been 
kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2274: CLOUDSTACK-10096 Can't reset integration.api.port and usage.sanity.ch?

[GitBox]

rhtyd commented on issue #2274: CLOUDSTACK-10096 Can't reset 
integration.api.port and usage.sanity.ch?
URL: https://github.com/apache/cloudstack/pull/2274#issuecomment-347537385
 
 
   @blueorangutan test


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9

[GitBox]

rhtyd commented on issue #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to 
Debian9
URL: https://github.com/apache/cloudstack/pull/2211#issuecomment-347536694
 
 
   @wido I've clubbed our commits to minimize overall commits, kindly review 
the changes and help test them on KVM+basic/sg etc. I've tested with advanced 
zone so far, and the only outstanding issues are around VPC (rVR related) and 
VPN.
   
   Since introduction of new systemvmtemplate may affect the wide range of 
userbase, pinging people to engage and seek feedback/review in the interim - 
@swill @syed @NuxRo @resmo @pdion891 @DaanHoogland @fmaximus @GabrielBrascher 
@jayapalu @karuturi @marcaurele @PaulAngus @nvazquez @rafaelweingartner 
@ustcweizhou and others


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[cloudstack] 02/03: CLOUDSTACK-10129: UX improvements and event timeline

[bhaisaab]

This is an automated email from the ASF dual-hosted git repository.

bhaisaab pushed a commit to branch debian9-systemvmtemplate
in repository https://gitbox.apache.org/repos/asf/cloudstack.git

commit 487c362b4a8d920e7ed135948c61a2848c125f11
Author: Rohit Yadav 
AuthorDate: Tue Nov 28 19:25:09 2017 +0530

CLOUDSTACK-10129: UX improvements and event timeline

- Fixes timezone issue where dates show up as nvalid in UI
- Introduces new event timeline listing/filtering of events
- Several UI improvements to add columns in list views
- Bulk operations support in instance list view to shutdown and destroy
  multiple-selected VMs (limitation: after operation, redundant entries
  may show up in the list view, refreshing VM list view fixes that)

Signed-off-by: Rohit Yadav 
---
 .../org/apache/cloudstack/api/ApiConstants.java|   2 +
 .../api/command/user/event/ListEventsCmd.java  |   7 +
 .../cloudstack/api/response/EventResponse.java |   2 +-
 .../schema/src/com/cloud/user/UserAccountVO.java   |   4 +
 engine/schema/src/com/cloud/user/UserVO.java   |   4 +
 .../src/com/cloud/api/query/QueryManagerImpl.java  |  10 +-
 ui/l10n/en.js  |   2 +
 ui/scripts/events.js   |  20 +-
 ui/scripts/instances.js| 275 -
 ui/scripts/metrics.js  |  13 +-
 ui/scripts/network.js  |  51 +++-
 ui/scripts/sharedFunctions.js  |   2 +-
 ui/scripts/storage.js  |  30 ++-
 ui/scripts/system.js   |  90 ++-
 ui/scripts/templates.js|  27 ++
 15 files changed, 393 insertions(+), 146 deletions(-)

diff --git a/api/src/org/apache/cloudstack/api/ApiConstants.java 
b/api/src/org/apache/cloudstack/api/ApiConstants.java
index a5bd95f..89deeef 100644
--- a/api/src/org/apache/cloudstack/api/ApiConstants.java
+++ b/api/src/org/apache/cloudstack/api/ApiConstants.java
@@ -205,6 +205,7 @@ public class ApiConstants {
 public static final String OUTOFBANDMANAGEMENT_POWERSTATE = 
"outofbandmanagementpowerstate";
 public static final String OUTOFBANDMANAGEMENT_ENABLED = 
"outofbandmanagementenabled";
 public static final String PARAMS = "params";
+public static final String PARENT_ID = "parentid";
 public static final String PARENT_DOMAIN_ID = "parentdomainid";
 public static final String PASSWORD = "password";
 public static final String SHOULD_UPDATE_PASSWORD = 
"update_passwd_on_host";
@@ -274,6 +275,7 @@ public class ApiConstants {
 public static final String SNAPSHOT_QUIESCEVM = "quiescevm";
 public static final String SOURCE_ZONE_ID = "sourcezoneid";
 public static final String START_DATE = "startdate";
+public static final String START_ID = "startid";
 public static final String START_IP = "startip";
 public static final String START_IPV6 = "startipv6";
 public static final String START_PORT = "startport";
diff --git 
a/api/src/org/apache/cloudstack/api/command/user/event/ListEventsCmd.java 
b/api/src/org/apache/cloudstack/api/command/user/event/ListEventsCmd.java
index a4934fa..b98c308 100644
--- a/api/src/org/apache/cloudstack/api/command/user/event/ListEventsCmd.java
+++ b/api/src/org/apache/cloudstack/api/command/user/event/ListEventsCmd.java
@@ -65,6 +65,9 @@ public class ListEventsCmd extends 
BaseListProjectAndAccountResourcesCmd {
 @Parameter(name = ApiConstants.TYPE, type = CommandType.STRING, 
description = "the event type (see event types)")
 private String type;
 
+@Parameter(name = ApiConstants.START_ID, type = CommandType.UUID, 
entityType = EventResponse.class, description = "the parent/start ID of the 
event, when provided this will list all the events with the start/parent ID 
including the parent event")
+private Long startId;
+
 /
 /// Accessors ///
 /
@@ -97,6 +100,10 @@ public class ListEventsCmd extends 
BaseListProjectAndAccountResourcesCmd {
 return type;
 }
 
+public Long getStartId() {
+return startId;
+}
+
 /
 /// API Implementation///
 /
diff --git a/api/src/org/apache/cloudstack/api/response/EventResponse.java 
b/api/src/org/apache/cloudstack/api/response/EventResponse.java
index 5ce66ed..da15434 100644
--- a/api/src/org/apache/cloudstack/api/response/EventResponse.java
+++ b/api/src/org/apache/cloudstack/api/response/EventResponse.java
@@ -78,7 +78,7 @@ public class EventResponse extends BaseResponse implements 
ControlledViewEntityR
 @Param(description 

[cloudstack] 03/03: wip- make redundant routers work again

[bhaisaab]

This is an automated email from the ASF dual-hosted git repository.

bhaisaab pushed a commit to branch debian9-systemvmtemplate
in repository https://gitbox.apache.org/repos/asf/cloudstack.git

commit 233fb7047c3d95d38284579af795d0fd1b769681
Author: Rohit Yadav 
AuthorDate: Sun Nov 26 13:32:33 2017 +0530

wip- make redundant routers work again

fix blockers

Signed-off-by: Rohit Yadav 
---
 .../debian/config/opt/cloud/bin/configure.py   |   6 +-
 .../debian/config/opt/cloud/bin/cs/CsRedundant.py  | 133 ---
 .../config/opt/cloud/bin/cs/CsStaticRoutes.py  |   5 +-
 .../debian/config/opt/cloud/bin/setup/common.sh|  59 ++-
 .../opt/cloud/templates/checkrouter.sh.templ   |   2 +-
 .../opt/cloud/templates/keepalived.conf.templ  |   2 +-
 .../root/redundant_router/arping_gateways.sh.templ |  29 --
 .../config/root/redundant_router/backup.sh.templ   |  39 --
 .../config/root/redundant_router/check_bumpup.sh   |  19 -
 .../root/redundant_router/check_heartbeat.sh.templ |  60 ---
 .../root/redundant_router/checkrouter.sh.templ |  56 ---
 .../root/redundant_router/conntrackd.conf.templ| 401 -
 .../config/root/redundant_router/disable_pubip.sh  |  23 --
 .../root/redundant_router/enable_pubip.sh.templ|  50 ---
 .../config/root/redundant_router/fault.sh.templ|  37 --
 .../root/redundant_router/heartbeat.sh.templ   |  20 -
 .../root/redundant_router/keepalived.conf.templ|  57 ---
 .../config/root/redundant_router/master.sh.templ   |  60 ---
 .../root/redundant_router/primary-backup.sh.templ  | 126 ---
 .../config/root/redundant_router/services.sh   |  68 
 20 files changed, 31 insertions(+), 1221 deletions(-)

diff --git a/systemvm/patches/debian/config/opt/cloud/bin/configure.py 
b/systemvm/patches/debian/config/opt/cloud/bin/configure.py
index 68d1c26..9a09f9b 100755
--- a/systemvm/patches/debian/config/opt/cloud/bin/configure.py
+++ b/systemvm/patches/debian/config/opt/cloud/bin/configure.py
@@ -31,11 +31,10 @@ import os.path
 import os
 from fcntl import flock, LOCK_EX, LOCK_UN
 
+import cs.CsHelper as CsHelper
 from cs.CsDatabag import CsDataBag, CsCmdLine
-import cs.CsHelper
 from cs.CsNetfilter import CsNetfilters
 from cs.CsDhcp import CsDhcp
-from cs.CsRedundant import *
 from cs.CsFile import CsFile
 from cs.CsApp import CsApache, CsDnsmasq
 from cs.CsMonitor import CsMonitor
@@ -1063,9 +1062,6 @@ def main(argv):
 CsHelper.save_iptables("iptables-save", 
"/etc/iptables/router_rules.v4")
 CsHelper.save_iptables("ip6tables-save", 
"/etc/iptables/router_rules.v6")
 
-red = CsRedundant(config)
-red.set()
-
 if process_file in ["cmd_line.json", "static_routes.json"]:
 logging.debug("Configuring static routes")
 static_routes = CsStaticRoutes("staticroutes", config)
diff --git a/systemvm/patches/debian/config/opt/cloud/bin/cs/CsRedundant.py 
b/systemvm/patches/debian/config/opt/cloud/bin/cs/CsRedundant.py
index f8d2bc2..c0c13db 100755
--- a/systemvm/patches/debian/config/opt/cloud/bin/cs/CsRedundant.py
+++ b/systemvm/patches/debian/config/opt/cloud/bin/cs/CsRedundant.py
@@ -64,139 +64,6 @@ class CsRedundant(object):
 self.address = config.address()
 self.config = config
 
-def set(self):
-logging.debug("Router redundancy status is %s", self.cl.is_redundant())
-if self.cl.is_redundant():
-self._redundant_on()
-else:
-self._redundant_off()
-
-def _redundant_off(self):
-CsHelper.service("conntrackd", "stop")
-CsHelper.service("keepalived", "stop")
-CsHelper.umount_tmpfs(self.CS_RAMDISK_DIR)
-CsHelper.rmdir(self.CS_RAMDISK_DIR)
-CsHelper.rm(self.CONNTRACKD_CONF)
-CsHelper.rm(self.KEEPALIVED_CONF)
-
-def _redundant_on(self):
-guest = self.address.get_guest_if()
-
-# No redundancy if there is no guest network
-if guest is None:
-self.set_backup()
-self._redundant_off()
-return
-
-interfaces = [interface for interface in self.address.get_interfaces() 
if interface.is_guest()]
-isDeviceReady = False
-dev = ''
-for interface in interfaces:
-if dev == interface.get_device():
-continue
-dev = interface.get_device()
-logging.info("Wait for devices to be configured so we can start 
keepalived")
-devConfigured = CsDevice(dev, self.config).waitfordevice()
-if devConfigured:
-command = "ip link show %s | grep 'state UP'" % dev
-devUp = CsHelper.execute(command)
-if devUp:
-logging.info("Device %s is present, let's start keepalive 
now." % dev)
-isDeviceReady = True
-
-if not isDeviceReady:
-

[cloudstack] branch debian9-systemvmtemplate updated (5e9092e -> 233fb70)

[bhaisaab]

This is an automated email from the ASF dual-hosted git repository.

bhaisaab pushed a change to branch debian9-systemvmtemplate
in repository https://gitbox.apache.org/repos/asf/cloudstack.git.


 discard 5e9092e  wip- make redundant routers work again
 discard 9ead74a  CLOUDSTACK-10013: Debian9 SystemVM appliance improvements
 discard 8f41288  CLOUDSTACK-10129: UX improvements and event timeline
 new a0eacb9  CLOUDSTACK-10013: Debian9 SystemVM appliance improvements
 new 487c362  CLOUDSTACK-10129: UX improvements and event timeline
 new 233fb70  wip- make redundant routers work again

This update added new revisions after undoing existing revisions.
That is to say, some revisions that were in the old version of the
branch are not in the new version.  This situation occurs
when a user --force pushes a change and generates a repository
containing something like this:

 * -- * -- B -- O -- O -- O   (5e9092e)
\
 N -- N -- N   refs/heads/debian9-systemvmtemplate (233fb70)

You should already have received notification emails for all of the O
revisions, and so the following emails describe only the N revisions
from the common base, B.

Any revisions marked "omit" are not gone; other references still
refer to them.  Any revisions marked "discard" are gone forever.

The 3 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:

-- 
To stop receiving notification emails like this one, please contact
['"commits@cloudstack.apache.org" '].

[GitHub] blueorangutan commented on issue #2274: CLOUDSTACK-10096 Can't reset integration.api.port and usage.sanity.ch?

[GitBox]

blueorangutan commented on issue #2274: CLOUDSTACK-10096 Can't reset 
integration.api.port and usage.sanity.ch?
URL: https://github.com/apache/cloudstack/pull/2274#issuecomment-347534430
 
 
   Packaging result: ?centos6 ?centos7 ?debian. JID-1312


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9

[GitBox]

rhtyd commented on issue #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to 
Debian9
URL: https://github.com/apache/cloudstack/pull/2211#issuecomment-347534331
 
 
   Thanks @borisstoyanov as part of the general effort I'll try to fix the 
features, especially refactor/fix the keepalived, conntrackd and strongswan 
configs and see if I can get the same baseline results (or on par) with the 
current master. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[cloudstack] 02/05: CLOUDSTACK-10013: Make Debian9 systemvmtemplates work with systemd

[bhaisaab]

This is an automated email from the ASF dual-hosted git repository.

bhaisaab pushed a commit to branch debian9-systemvmtemplate
in repository https://gitbox.apache.org/repos/asf/cloudstack.git

commit e2680351e0646c46e7611ae998fab76578d87c3b
Author: Wido den Hollander 
AuthorDate: Thu Aug 10 13:51:11 2017 +0200

CLOUDSTACK-10013: Make Debian9 systemvmtemplates work with systemd

- Load the nf_conntrack_ipv6 module for IPv6 connection tracking on SSVM
- Move systemd services to /etc and enable services after they have been
  installed
- Disable most services by default and enable in cloud-early-config
- Start services after enabling them using systemd
- In addition remove /etc/init.d/cloud as this is no longer needed and
  done by systemd
- Accept DOS/MBR as file format for ISO images as well

Under Debian 7 the 'file' command would return:

  debian-9.1.0-amd64-netinst.iso: ISO 9660 CD-ROM filesystem data UDF 
filesystem data

Under Debian 9 however it will return

  debian-9.1.0-amd64-netinst.iso: DOS/MBR boot sector

This would make the HTTPTemplateDownloader in the Secondary Storage VM 
refuse the ISO as
a valid template because it's not a correct format.

Changes this behavior so that it accepts both.
This allows us to use Debian 9 as a System VM template.

Not sure though if enabling them is enough for systemd to still start them
on first boot

Signed-off-by: Wido den Hollander 
---
 .gitignore |   2 +
 systemvm/patches/debian/config/etc/init.d/cloud| 155 -
 .../debian/config/etc/init.d/cloud-early-config|  55 ++--
 .../systemvmtemplate/configure_conntrack.sh|   1 +
 .../configure_systemvm_services.sh |  22 +--
 .../utils/imagestore/ImageStoreUtil.java   |   2 +-
 6 files changed, 30 insertions(+), 207 deletions(-)

diff --git a/.gitignore b/.gitignore
index 29b4ffc..1a73724 100644
--- a/.gitignore
+++ b/.gitignore
@@ -97,3 +97,5 @@ systemvm/.pydevproject
 test/.pydevprojec
 plugins/hypervisors/kvm/.pydevproject
 scripts/.pydevproject
+*.qcow2
+*.raw
diff --git a/systemvm/patches/debian/config/etc/init.d/cloud 
b/systemvm/patches/debian/config/etc/init.d/cloud
deleted file mode 100755
index 9b3a63b..000
--- a/systemvm/patches/debian/config/etc/init.d/cloud
+++ /dev/null
@@ -1,155 +0,0 @@
-#!/bin/bash
-### BEGIN INIT INFO
-# Provides:  cloud
-# Required-Start:$local_fs cloud-early-config
-# Required-Stop: $local_fs
-# Default-Start: 3 4 5
-# Default-Stop:  0 1 6
-# Short-Description: Start up the CloudStack cloud service
-### END INIT INFO
-# Licensed to the Apache Software Foundation (ASF) under one
-# or more contributor license agreements.  See the NOTICE file
-# distributed with this work for additional information
-# regarding copyright ownership.  The ASF licenses this file
-# to you under the Apache License, Version 2.0 (the
-# "License"); you may not use this file except in compliance
-# with the License.  You may obtain a copy of the License at
-#
-#   http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing,
-# software distributed under the License is distributed on an
-# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
-# KIND, either express or implied.  See the License for the
-# specific language governing permissions and limitations
-# under the License.
-
-#set -x
-
-ENABLED=0
-[ -e /etc/default/cloud ] && . /etc/default/cloud
-
-CMDLINE=$(cat /var/cache/cloud/cmdline)
-
-if [ ! -z $CLOUD_DEBUG ];then
-  LOG_FILE=/var/log/cloud/cloud.out
-else
-  LOG_FILE=/dev/null
-fi
-
-TYPE="router"
-for i in $CMDLINE
-  do
-# search for foo=bar pattern and cut out foo
-FIRSTPATTERN=$(echo $i | cut -d= -f1)
-case $FIRSTPATTERN in 
-  type)
-  TYPE=$(echo $i | cut -d= -f2)
-  ;;
-esac
-done
-
-# Source function library.
-if [ -f /etc/init.d/functions ]
-then
-  . /etc/init.d/functions
-fi
-
-if [ -f ./lib/lsb/init-functions ]
-then
-  . /lib/lsb/init-functions
-fi
-
-_success() {
-  if [ -f /etc/init.d/functions ]
-  then
-success
-  else
-echo "Success"
-  fi
-}
-
-_failure() {
-  if [ -f /etc/init.d/functions ]
-  then
-failure
-  else
-echo "Failed"
-  fi
-}
-RETVAL=$?
-CLOUDSTACK_HOME="/usr/local/cloud"
-if [ -f  $CLOUDSTACK_HOME/systemvm/utils.sh ];
-then
-  . $CLOUDSTACK_HOME/systemvm/utils.sh
-else
-  _failure
-fi
-
-# mkdir -p /var/log/vmops
-
-start() {
-   local pid=$(get_pids)
-   if [ "$pid" != "" ]; then
-   echo "CloudStack cloud sevice is already running, PID = $pid"
-   return 0
-   fi
-
-   echo -n "Starting CloudStack cloud service (type=$TYPE) "
-   if [ -f $CLOUDSTACK_HOME/systemvm/run.sh ];
-   then
- if [ "$pid" == "" ]
- then
-   (cd $CLOUDSTACK_HOME/systemvm; nohup ./run.sh > 

[cloudstack] branch debian9-systemvmtemplate updated (30b8305 -> 5e9092e)

[bhaisaab]

This is an automated email from the ASF dual-hosted git repository.

bhaisaab pushed a change to branch debian9-systemvmtemplate
in repository https://gitbox.apache.org/repos/asf/cloudstack.git.


omit 30b8305  CLoudstack UX improvements
omit 85cbd3a  UI feature: Event timeline listing
omit 4760eac  fix blocker, cyclical imports, several UI fixes
omit 2e596aa  minor fixes
omit 0ba8839  fix ssh patching
omit 86d83d0  wip- make redundant routers work again
omit e0fa409  fixes
omit 593d125  more fixes
omit 2b31308  reformating
omit c27d547  fix passwd server test
omit 5880923  pass test
omit 49884b2  fix haproxy syntax
omit 4dcf083  fix test failures
omit 8dd930a  fixes
omit c5084f2  improvements
omit 25388d4  remove postinit
omit 3555f66  Fixed ssvm tests, make them faster
omit 9596650  fix failures
omit ee6e66b  make systemvms faster and better
omit 76ae9bb  refactor individual setup scripts
omit 272e774  template changes
omit 1caae17  fix removing shar scripts
omit 54e270b  remove all logs
omit 24b40f7  remove stuff
omit a719a97  fix description for run.sh
omit 6d2525e  Remove unknown key with random user key
omit aabd6380 don't disalbe hyperv daemon it runs anyway from 
cloud-early-config
omit abe56b0  regression fixes
omit 8e44acd  major scripts refactoring, make cloud-early-config small
omit 4ae34cb  use log4j xml don't patch via cloud-early-config
omit 332c791  disable services by default
omit 383857f  misc fixes changes
omit 8bb33cb  Use sha512 sum, use distro provided packages
omit 8de9af5  use hostnamectl to add hostname
omit 7d206e1  fix regression
omit 074b3f2  make console proxy launch faster
omit 23b55dc  fix dnsmasq starting issue
omit 2c68bc4  speed up console proxy service loading
omit c63c4fa  sshd is enabled by default
omit fd09e65  update vhd-util url
omit 615dc63  enable additional modules
omit 9ee9623  update: update iso url
omit 8bc20f8  remove unknown ssh key
omit 8dd68ad  Start services after enabling them using systemd
omit 56b2e6c  Ignore files from build of SSVM
omit ea160f6  Disable most services by default and enable in 
cloud-early-config
omit ea8d313  Accept DOS/MBR as file format for ISO images as well
omit 3abcfec  Move systemd services to /etc and enable services after they 
have been installed
omit a4d7862  Load the nf_conntrack_ipv6 module for IPv6 connection 
tracking on SSVM
omit b492094  CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9
 add d65f044  CLOUDSTACK-10138: Load br_netfilter in security_group 
management script (#2321)
 add fdf2509  CLOUDSTACK-10160: Fix typo in Libvirt XML definition for 
Virtio-SCSI (#2341)
 add f506a99  CLOUDSTACK-10154: fixing some smoketests failures (#2335)
 add bec48c6   CLOUDSTACK-10140: Fix for when template is created from 
snapshot template.properties are corrupted (#2322)
 add cd56112  Resource dedicated to a domain is owned by the root domain
 add bd56044  Merge pull request #2124 from GabrielBrascher/CLOUDSTACK-9432
 new fbb6c18  CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9
 new e268035  CLOUDSTACK-10013: Make Debian9 systemvmtemplates work with 
systemd
 new 8f41288  CLOUDSTACK-10129: UX improvements and event timeline
 new 9ead74a  CLOUDSTACK-10013: Debian9 SystemVM appliance improvements
 new 5e9092e  wip- make redundant routers work again

This update added new revisions after undoing existing revisions.
That is to say, some revisions that were in the old version of the
branch are not in the new version.  This situation occurs
when a user --force pushes a change and generates a repository
containing something like this:

 * -- * -- B -- O -- O -- O   (30b8305)
\
 N -- N -- N   refs/heads/debian9-systemvmtemplate (5e9092e)

You should already have received notification emails for all of the O
revisions, and so the following emails describe only the N revisions
from the common base, B.

Any revisions marked "omit" are not gone; other references still
refer to them.  Any revisions marked "discard" are gone forever.

The 5 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 .../cloud/storage/template/TemplateLocation.java   | 53 +++-
 debian/cloudstack-agent.postinst   |  9 +++
 .../hypervisor/kvm/resource/LibvirtVMDef.java  |  4 +-
 .../hypervisor/kvm/resource/LibvirtVMDefTest.java  | 10 +++
 .../affinity/AffinityGroupServiceImpl.java | 73 +-
 .../affinity/AffinityGroupServiceImplTest.java | 43 +
 .../resource/NfsSecondaryStorageResource.java  |  8 +--
 

[cloudstack] 05/05: wip- make redundant routers work again

[bhaisaab]

This is an automated email from the ASF dual-hosted git repository.

bhaisaab pushed a commit to branch debian9-systemvmtemplate
in repository https://gitbox.apache.org/repos/asf/cloudstack.git

commit 5e9092ef04ed6e14419e08005d962cda748f4982
Author: Rohit Yadav 
AuthorDate: Sun Nov 26 13:32:33 2017 +0530

wip- make redundant routers work again

fix blockers

Signed-off-by: Rohit Yadav 
---
 .../debian/config/opt/cloud/bin/configure.py   |   6 +-
 .../debian/config/opt/cloud/bin/cs/CsRedundant.py  | 133 ---
 .../config/opt/cloud/bin/cs/CsStaticRoutes.py  |   5 +-
 .../debian/config/opt/cloud/bin/setup/common.sh|  59 ++-
 .../opt/cloud/templates/checkrouter.sh.templ   |   2 +-
 .../opt/cloud/templates/keepalived.conf.templ  |   2 +-
 .../root/redundant_router/arping_gateways.sh.templ |  29 --
 .../config/root/redundant_router/backup.sh.templ   |  39 --
 .../config/root/redundant_router/check_bumpup.sh   |  19 -
 .../root/redundant_router/check_heartbeat.sh.templ |  60 ---
 .../root/redundant_router/checkrouter.sh.templ |  56 ---
 .../root/redundant_router/conntrackd.conf.templ| 401 -
 .../config/root/redundant_router/disable_pubip.sh  |  23 --
 .../root/redundant_router/enable_pubip.sh.templ|  50 ---
 .../config/root/redundant_router/fault.sh.templ|  37 --
 .../root/redundant_router/heartbeat.sh.templ   |  20 -
 .../root/redundant_router/keepalived.conf.templ|  57 ---
 .../config/root/redundant_router/master.sh.templ   |  60 ---
 .../root/redundant_router/primary-backup.sh.templ  | 126 ---
 .../config/root/redundant_router/services.sh   |  68 
 20 files changed, 31 insertions(+), 1221 deletions(-)

diff --git a/systemvm/patches/debian/config/opt/cloud/bin/configure.py 
b/systemvm/patches/debian/config/opt/cloud/bin/configure.py
index 68d1c26..9a09f9b 100755
--- a/systemvm/patches/debian/config/opt/cloud/bin/configure.py
+++ b/systemvm/patches/debian/config/opt/cloud/bin/configure.py
@@ -31,11 +31,10 @@ import os.path
 import os
 from fcntl import flock, LOCK_EX, LOCK_UN
 
+import cs.CsHelper as CsHelper
 from cs.CsDatabag import CsDataBag, CsCmdLine
-import cs.CsHelper
 from cs.CsNetfilter import CsNetfilters
 from cs.CsDhcp import CsDhcp
-from cs.CsRedundant import *
 from cs.CsFile import CsFile
 from cs.CsApp import CsApache, CsDnsmasq
 from cs.CsMonitor import CsMonitor
@@ -1063,9 +1062,6 @@ def main(argv):
 CsHelper.save_iptables("iptables-save", 
"/etc/iptables/router_rules.v4")
 CsHelper.save_iptables("ip6tables-save", 
"/etc/iptables/router_rules.v6")
 
-red = CsRedundant(config)
-red.set()
-
 if process_file in ["cmd_line.json", "static_routes.json"]:
 logging.debug("Configuring static routes")
 static_routes = CsStaticRoutes("staticroutes", config)
diff --git a/systemvm/patches/debian/config/opt/cloud/bin/cs/CsRedundant.py 
b/systemvm/patches/debian/config/opt/cloud/bin/cs/CsRedundant.py
index f8d2bc2..c0c13db 100755
--- a/systemvm/patches/debian/config/opt/cloud/bin/cs/CsRedundant.py
+++ b/systemvm/patches/debian/config/opt/cloud/bin/cs/CsRedundant.py
@@ -64,139 +64,6 @@ class CsRedundant(object):
 self.address = config.address()
 self.config = config
 
-def set(self):
-logging.debug("Router redundancy status is %s", self.cl.is_redundant())
-if self.cl.is_redundant():
-self._redundant_on()
-else:
-self._redundant_off()
-
-def _redundant_off(self):
-CsHelper.service("conntrackd", "stop")
-CsHelper.service("keepalived", "stop")
-CsHelper.umount_tmpfs(self.CS_RAMDISK_DIR)
-CsHelper.rmdir(self.CS_RAMDISK_DIR)
-CsHelper.rm(self.CONNTRACKD_CONF)
-CsHelper.rm(self.KEEPALIVED_CONF)
-
-def _redundant_on(self):
-guest = self.address.get_guest_if()
-
-# No redundancy if there is no guest network
-if guest is None:
-self.set_backup()
-self._redundant_off()
-return
-
-interfaces = [interface for interface in self.address.get_interfaces() 
if interface.is_guest()]
-isDeviceReady = False
-dev = ''
-for interface in interfaces:
-if dev == interface.get_device():
-continue
-dev = interface.get_device()
-logging.info("Wait for devices to be configured so we can start 
keepalived")
-devConfigured = CsDevice(dev, self.config).waitfordevice()
-if devConfigured:
-command = "ip link show %s | grep 'state UP'" % dev
-devUp = CsHelper.execute(command)
-if devUp:
-logging.info("Device %s is present, let's start keepalive 
now." % dev)
-isDeviceReady = True
-
-if not isDeviceReady:
-

[cloudstack] 03/05: CLOUDSTACK-10129: UX improvements and event timeline

[bhaisaab]

This is an automated email from the ASF dual-hosted git repository.

bhaisaab pushed a commit to branch debian9-systemvmtemplate
in repository https://gitbox.apache.org/repos/asf/cloudstack.git

commit 8f41288e85fbbc9dedc63f724eab506a64f62ddd
Author: Rohit Yadav 
AuthorDate: Tue Nov 28 19:25:09 2017 +0530

CLOUDSTACK-10129: UX improvements and event timeline

- Fixes timezone issue where dates show up as nvalid in UI
- Introduces new event timeline listing/filtering of events
- Several UI improvements to add columns in list views
- Bulk operations support in instance list view to shutdown and destroy
  multiple-selected VMs (limitation: after operation, redundant entries
  may show up in the list view, refreshing VM list view fixes that)

Signed-off-by: Rohit Yadav 
---
 .../org/apache/cloudstack/api/ApiConstants.java|   2 +
 .../api/command/user/event/ListEventsCmd.java  |   7 +
 .../cloudstack/api/response/EventResponse.java |   2 +-
 .../schema/src/com/cloud/user/UserAccountVO.java   |   4 +
 engine/schema/src/com/cloud/user/UserVO.java   |   4 +
 .../src/com/cloud/api/query/QueryManagerImpl.java  |  10 +-
 ui/l10n/en.js  |   2 +
 ui/scripts/events.js   |  20 +-
 ui/scripts/instances.js| 275 -
 ui/scripts/metrics.js  |  13 +-
 ui/scripts/network.js  |  51 +++-
 ui/scripts/sharedFunctions.js  |   2 +-
 ui/scripts/storage.js  |  30 ++-
 ui/scripts/system.js   |  90 ++-
 ui/scripts/templates.js|  27 ++
 15 files changed, 393 insertions(+), 146 deletions(-)

diff --git a/api/src/org/apache/cloudstack/api/ApiConstants.java 
b/api/src/org/apache/cloudstack/api/ApiConstants.java
index a5bd95f..89deeef 100644
--- a/api/src/org/apache/cloudstack/api/ApiConstants.java
+++ b/api/src/org/apache/cloudstack/api/ApiConstants.java
@@ -205,6 +205,7 @@ public class ApiConstants {
 public static final String OUTOFBANDMANAGEMENT_POWERSTATE = 
"outofbandmanagementpowerstate";
 public static final String OUTOFBANDMANAGEMENT_ENABLED = 
"outofbandmanagementenabled";
 public static final String PARAMS = "params";
+public static final String PARENT_ID = "parentid";
 public static final String PARENT_DOMAIN_ID = "parentdomainid";
 public static final String PASSWORD = "password";
 public static final String SHOULD_UPDATE_PASSWORD = 
"update_passwd_on_host";
@@ -274,6 +275,7 @@ public class ApiConstants {
 public static final String SNAPSHOT_QUIESCEVM = "quiescevm";
 public static final String SOURCE_ZONE_ID = "sourcezoneid";
 public static final String START_DATE = "startdate";
+public static final String START_ID = "startid";
 public static final String START_IP = "startip";
 public static final String START_IPV6 = "startipv6";
 public static final String START_PORT = "startport";
diff --git 
a/api/src/org/apache/cloudstack/api/command/user/event/ListEventsCmd.java 
b/api/src/org/apache/cloudstack/api/command/user/event/ListEventsCmd.java
index a4934fa..b98c308 100644
--- a/api/src/org/apache/cloudstack/api/command/user/event/ListEventsCmd.java
+++ b/api/src/org/apache/cloudstack/api/command/user/event/ListEventsCmd.java
@@ -65,6 +65,9 @@ public class ListEventsCmd extends 
BaseListProjectAndAccountResourcesCmd {
 @Parameter(name = ApiConstants.TYPE, type = CommandType.STRING, 
description = "the event type (see event types)")
 private String type;
 
+@Parameter(name = ApiConstants.START_ID, type = CommandType.UUID, 
entityType = EventResponse.class, description = "the parent/start ID of the 
event, when provided this will list all the events with the start/parent ID 
including the parent event")
+private Long startId;
+
 /
 /// Accessors ///
 /
@@ -97,6 +100,10 @@ public class ListEventsCmd extends 
BaseListProjectAndAccountResourcesCmd {
 return type;
 }
 
+public Long getStartId() {
+return startId;
+}
+
 /
 /// API Implementation///
 /
diff --git a/api/src/org/apache/cloudstack/api/response/EventResponse.java 
b/api/src/org/apache/cloudstack/api/response/EventResponse.java
index 5ce66ed..da15434 100644
--- a/api/src/org/apache/cloudstack/api/response/EventResponse.java
+++ b/api/src/org/apache/cloudstack/api/response/EventResponse.java
@@ -78,7 +78,7 @@ public class EventResponse extends BaseResponse implements 
ControlledViewEntityR
 @Param(description 

[cloudstack] 01/05: CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9

[bhaisaab]

This is an automated email from the ASF dual-hosted git repository.

bhaisaab pushed a commit to branch debian9-systemvmtemplate
in repository https://gitbox.apache.org/repos/asf/cloudstack.git

commit fbb6c1818d04d1a1ace4eac07a40254e8d36ce93
Author: Rohit Yadav 
AuthorDate: Sun Jul 23 18:01:35 2017 +0200

CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9

  SystemVM changes to work on Debian 9
- Migrate away from chkconfig to systemctl
- Remove xenstore-utils override deb pkg
- Fix runlevel in sysv scripts for systemd

Signed-off-by: Rohit Yadav 
---
 systemvm/patches/debian/buildsystemvm.sh   | 577 -
 systemvm/patches/debian/config/etc/init.d/cloud|  10 +-
 .../debian/config/etc/init.d/cloud-early-config|  23 +-
 .../debian/config/etc/init.d/cloud-passwd-srvr |  10 +-
 systemvm/patches/debian/config/etc/init.d/postinit |   6 +-
 systemvm/patches/debian/config/etc/rc.local|   2 +-
 systemvm/patches/debian/config/etc/ssh/sshd_config |   1 -
 .../debian/config/opt/cloud/bin/patchsystemvm.sh   | 128 ++---
 tools/appliance/build.sh   |   2 +-
 .../definitions/systemvmtemplate/apt_upgrade.sh|   9 +-
 .../systemvmtemplate/authorized_keys.sh|   1 +
 .../definitions/systemvmtemplate/build_time.sh |  26 -
 .../definitions/systemvmtemplate/cleanup.sh|   1 -
 .../definitions/systemvmtemplate/configure_grub.sh |   6 +-
 .../systemvmtemplate/configure_login.sh|  15 +-
 .../systemvmtemplate/configure_networking.sh   |  25 +-
 .../configure_systemvm_services.sh |  94 +++-
 .../definitions/systemvmtemplate/definition.rb |  36 +-
 .../systemvmtemplate/install_systemvm_packages.sh  |  32 +-
 .../definitions/systemvmtemplate/preseed.cfg   |  69 ++-
 .../definitions/systemvmtemplate/zerodisk.sh   |   9 +-
 21 files changed, 267 insertions(+), 815 deletions(-)

diff --git a/systemvm/patches/debian/buildsystemvm.sh 
b/systemvm/patches/debian/buildsystemvm.sh
deleted file mode 100755
index a34b1dd..000
--- a/systemvm/patches/debian/buildsystemvm.sh
+++ /dev/null
@@ -1,577 +0,0 @@
-#!/bin/bash
-# Licensed to the Apache Software Foundation (ASF) under one
-# or more contributor license agreements.  See the NOTICE file
-# distributed with this work for additional information
-# regarding copyright ownership.  The ASF licenses this file
-# to you under the Apache License, Version 2.0 (the
-# "License"); you may not use this file except in compliance
-# with the License.  You may obtain a copy of the License at
-# 
-#   http://www.apache.org/licenses/LICENSE-2.0
-# 
-# Unless required by applicable law or agreed to in writing,
-# software distributed under the License is distributed on an
-# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
-# KIND, either express or implied.  See the License for the
-# specific language governing permissions and limitations
-# under the License.
-
-echo ""
-echo " Note there is a new systemvm build script based on "
-echo " Veewee(Vagrant) under tools/appliance."
-echo ""
-
-set -e
-set -x
-
-IMAGENAME=systemvm
-LOCATION=/var/lib/images/systemvm
-PASSWORD=password
-#APT_PROXY=192.168.1.115:3142/
-APT_PROXY=
-HOSTNAME=systemvm
-SIZE=2000
-DEBIAN_MIRROR=ftp.us.debian.org/debian
-MINIMIZE=true
-CLOUDSTACK_RELEASE=4.0
-offset=4096
-baseimage() {
-  mkdir -p $LOCATION
-  #dd if=/dev/zero of=$IMAGELOC bs=1M  count=$SIZE
-  dd if=/dev/zero of=$IMAGELOC bs=1M seek=$((SIZE - 1)) count=1
-  loopdev=$(losetup -f)
-  losetup $loopdev $IMAGELOC
-  parted $loopdev -s 'mklabel msdos'
-  parted $loopdev -s 'mkpart primary ext3 4096B -1'
-  sleep 2 
-  losetup -d $loopdev
-  loopdev=$(losetup --show -o $offset -f $IMAGELOC )
-  mkfs.ext3  -L ROOT $loopdev
-  mkdir -p $MOUNTPOINT
-  tune2fs -c 100 -i 0 $loopdev
-  sleep 2 
-  losetup -d $loopdev
-  
-  mount -o loop,offset=$offset $IMAGELOC  $MOUNTPOINT
-  
-  #debootstrap --variant=minbase 
--keyring=/usr/share/keyrings/debian-archive-keyring.gpg wheezy $MOUNTPOINT 
http://${APT_PROXY}${DEBIAN_MIRROR}
-  debootstrap --variant=minbase --arch=i386 wheezy $MOUNTPOINT 
http://${APT_PROXY}${DEBIAN_MIRROR}
-}
-
-
-fixapt() {
-  if [ "$APT_PROXY" != "" ]; then
-  cat >> etc/apt/apt.conf.d/01proxy << EOF
-Acquire::http::Proxy "http://${APT_PROXY};;
-EOF
-  fi
-
-  cat > etc/apt/sources.list << EOF
-deb http://http.debian.net/debian/ wheezy main contrib non-free
-deb-src http://http.debian.net/debian/ wheezy main contrib non-free
-
-deb http://security.debian.org/ wheezy/updates main
-deb-src http://security.debian.org/ wheezy/updates main
-
-deb http://http.debian.net/debian/ wheezy-backports main
-deb-src http://http.debian.net/debian/ wheezy-backports main
-EOF
-
-  cat >> etc/apt/apt.conf << EOF
-APT::Default-Release "stable"; 

[GitHub] blueorangutan commented on issue #2304: CLOUDSTACK-10127: KVM + Ovs: Incorrect devId on static nat

[GitBox]

blueorangutan commented on issue #2304: CLOUDSTACK-10127: KVM + Ovs: Incorrect 
devId on static nat
URL: https://github.com/apache/cloudstack/pull/2304#issuecomment-347532787
 
 
   Packaging result: ?centos6 ?centos7 ?debian. JID-1311


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] borisstoyanov commented on issue #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9

[GitBox]

borisstoyanov commented on issue #2211: CLOUDSTACK-10013: Migrate 
systemvmtemplate to Debian9
URL: https://github.com/apache/cloudstack/pull/2211#issuecomment-347530544
 
 
   @rhtyd I don't think any of those require fixing in the marvin tests, if so, 
please let me know will be happy to help. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9

[GitBox]

rhtyd commented on issue #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to 
Debian9
URL: https://github.com/apache/cloudstack/pull/2211#issuecomment-347525528
 
 
   I triaged the bugs, the only set of features needing 
fixing/improvements/testing are:
   - Redundant VRs (fixes to keepalived and conntrackd handlings)
   - Strongswan fixes/improvements /cc @swill 
   - rVR, VPC and VPN related test failures
   
   The only outstanding smoketest failures on KVM are: /cc @PaulAngus 
@borisstoyanov and others
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   | test_02_internallb_r | Failure  | 318.006 | 
test_internal_lb.py  |
   | test_04_rvpc_interna | exceptions.TypeError | 252.257 | 
test_internal_lb.py  |
   | test_01_vpc_privateg | Failure  | 41.601  | 
test_privategw_acl.p |
   | test_02_vpc_privateg | Failure  | 122.789 | 
test_privategw_acl.p |
   | test_03_vpc_privateg | Failure  | 112.787 | 
test_privategw_acl.p |
   | test_04_rvpc_private | Failure  | 193.353 | 
test_privategw_acl.p |
   | test_01_RVR_Network_ | Failure  | 284.568 | 
test_routers_network |
   | test_02_RVR_Network_ | Failure  | 287.109 | 
test_routers_network |
   | test_03_RVR_Network_ | Failure  | 78.525  | 
test_routers_network |
   | test_01_create_redun | Failure  | 288.040 | 
test_vpc_redundant.p |
   | test_01_create_redun | exceptions.Exception | 293.161 | 
test_vpc_redundant.p |
   | test_02_redundant_VP | exceptions.Exception | 16.045  | 
test_vpc_redundant.p |
   | test_03_create_redun | exceptions.Exception | 16.011  | 
test_vpc_redundant.p |
   | test_04_rvpc_network | exceptions.Exception | 16.002  | 
test_vpc_redundant.p |
   | test_05_rvpc_multi_t | exceptions.Exception | 5.989   | 
test_vpc_redundant.p |
   | test_01_VPC_nics_aft | exceptions.Exception | 5.925   | 
test_vpc_router_nics |
   | test_02_VPC_default_ | exceptions.Exception | 10.941  | 
test_vpc_router_nics |
   | test_01_redundant_vp | Failure  | 5.364   | test_vpc_vpn.py
  |
   | test_01_vpc_remote_a | Failure  | 5.164   | test_vpc_vpn.py
  |
   | test_01_vpc_site2sit | Failure  | 10.333  | test_vpc_vpn.py
  |
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2274: CLOUDSTACK-10096 Can't reset integration.api.port and usage.sanity.ch?

[GitBox]

blueorangutan commented on issue #2274: CLOUDSTACK-10096 Can't reset 
integration.api.port and usage.sanity.ch?
URL: https://github.com/apache/cloudstack/pull/2274#issuecomment-347524450
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2274: CLOUDSTACK-10096 Can't reset integration.api.port and usage.sanity.ch?

[GitBox]

rhtyd commented on issue #2274: CLOUDSTACK-10096 Can't reset 
integration.api.port and usage.sanity.ch?
URL: https://github.com/apache/cloudstack/pull/2274#issuecomment-347524214
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2304: CLOUDSTACK-10127: KVM + Ovs: Incorrect devId on static nat

[GitBox]

rhtyd commented on issue #2304: CLOUDSTACK-10127: KVM + Ovs: Incorrect devId on 
static nat
URL: https://github.com/apache/cloudstack/pull/2304#issuecomment-347521493
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2124: CLOUDSTACK-9432: cluster/host dedicated to a domain is owned by the root domain

[GitBox]

rhtyd commented on issue #2124: CLOUDSTACK-9432: cluster/host dedicated to a 
domain is owned by the root domain
URL: https://github.com/apache/cloudstack/pull/2124#issuecomment-347520146
 
 
   @GabrielBrascher okay, I'll run regression tests on master later. Kindly use 
'squash merge' in future and commits should include the JIRA id in their commit 
summary such as `CLOUDSTACK-: short summary`...


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[cloudstack] branch master updated (bec48c6 -> bd56044)

[gabriel]

This is an automated email from the ASF dual-hosted git repository.

gabriel pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git.


from bec48c6   CLOUDSTACK-10140: Fix for when template is created from 
snapshot template.properties are corrupted (#2322)
 add cd56112  Resource dedicated to a domain is owned by the root domain
 new bd56044  Merge pull request #2124 from GabrielBrascher/CLOUDSTACK-9432

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 .../affinity/AffinityGroupServiceImpl.java | 73 +-
 .../affinity/AffinityGroupServiceImplTest.java | 43 +
 2 files changed, 77 insertions(+), 39 deletions(-)

-- 
To stop receiving notification emails like this one, please contact
['"commits@cloudstack.apache.org" '].

[cloudstack] 01/01: Merge pull request #2124 from GabrielBrascher/CLOUDSTACK-9432

[gabriel]

This is an automated email from the ASF dual-hosted git repository.

gabriel pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git

commit bd5604428be5713f47f10db93019193d144ce745
Merge: bec48c6 cd56112
Author: Gabriel Beims Bräscher 
AuthorDate: Tue Nov 28 10:31:23 2017 -0200

Merge pull request #2124 from GabrielBrascher/CLOUDSTACK-9432

CLOUDSTACK-9432: cluster/host dedicated to a domain is owned by the root 
domain

 .../affinity/AffinityGroupServiceImpl.java | 73 +-
 .../affinity/AffinityGroupServiceImplTest.java | 43 +
 2 files changed, 77 insertions(+), 39 deletions(-)

-- 
To stop receiving notification emails like this one, please contact
"commits@cloudstack.apache.org" .

[GitHub] GabrielBrascher closed pull request #2124: CLOUDSTACK-9432: cluster/host dedicated to a domain is owned by the root domain

[GitBox]

GabrielBrascher closed pull request #2124: CLOUDSTACK-9432: cluster/host 
dedicated to a domain is owned by the root domain
URL: https://github.com/apache/cloudstack/pull/2124
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/server/src/org/apache/cloudstack/affinity/AffinityGroupServiceImpl.java 
b/server/src/org/apache/cloudstack/affinity/AffinityGroupServiceImpl.java
index f2502442c18..f2c91c8addb 100644
--- a/server/src/org/apache/cloudstack/affinity/AffinityGroupServiceImpl.java
+++ b/server/src/org/apache/cloudstack/affinity/AffinityGroupServiceImpl.java
@@ -117,7 +117,7 @@ public AffinityGroup 
createAffinityGroup(CreateAffinityGroupCmd createAffinityGr
 @DB
 @Override
 public AffinityGroup createAffinityGroup(final String accountName, final 
Long projectId, final Long domainId, final String affinityGroupName, final 
String affinityGroupType,
-final String description) {
+final String description) {
 
 // validate the affinityGroupType
 Map typeProcessorMap = 
getAffinityTypeToProcessorMap();
@@ -158,7 +158,7 @@ public AffinityGroup createAffinityGroup(final String 
accountName, final Long pr
 verifyAffinityGroupNameInUse(owner.getAccountId(), 
owner.getDomainId(), affinityGroupName);
 verifyDomainLevelAffinityGroupName(domainLevel, owner.getDomainId(), 
affinityGroupName);
 
-AffinityGroupVO group = createAffinityGroup(processor, owner, aclType, 
affinityGroupName, affinityGroupType, description);
+AffinityGroupVO group = createAffinityGroup(processor, owner, aclType, 
affinityGroupName, affinityGroupType, description, domainLevel, domainId);
 
 if (s_logger.isDebugEnabled()) {
 s_logger.debug("Created affinity group =" + affinityGroupName);
@@ -176,25 +176,27 @@ private void verifyAccessToDomainWideProcessor(Account 
caller, AffinityGroupProc
 }
 }
 
-private AffinityGroupVO createAffinityGroup(final AffinityGroupProcessor 
processor, final Account owner, final ACLType aclType, final String 
affinityGroupName, final String affinityGroupType, final String description) {
+private AffinityGroupVO createAffinityGroup(final AffinityGroupProcessor 
processor, final Account owner, final ACLType aclType, final String 
affinityGroupName, final String affinityGroupType, final String description, 
boolean domainLevel, Long domainId) {
+
+final Long affinityGroupDomainId = 
getDomainIdBasedOnDomainLevel(owner, domainLevel, domainId);
+
 return Transaction.execute(new TransactionCallback() {
 @Override
 public AffinityGroupVO doInTransaction(TransactionStatus status) {
-AffinityGroupVO group =
-new AffinityGroupVO(affinityGroupName, affinityGroupType, 
description, owner.getDomainId(), owner.getId(), aclType);
+AffinityGroupVO group = new AffinityGroupVO(affinityGroupName, 
affinityGroupType, description, affinityGroupDomainId, owner.getId(), aclType);
 _affinityGroupDao.persist(group);
 
 if (aclType == ACLType.Domain) {
 boolean subDomainAccess = false;
 subDomainAccess = processor.subDomainAccess();
-AffinityGroupDomainMapVO domainMap = new 
AffinityGroupDomainMapVO(group.getId(), owner.getDomainId(),
+AffinityGroupDomainMapVO domainMap = new 
AffinityGroupDomainMapVO(group.getId(), affinityGroupDomainId,
 subDomainAccess);
 _affinityGroupDomainMapDao.persist(domainMap);
 //send event for storing the domain wide resource access
 Map params = new HashMap();
 params.put(ApiConstants.ENTITY_TYPE, AffinityGroup.class);
 params.put(ApiConstants.ENTITY_ID, group.getId());
-params.put(ApiConstants.DOMAIN_ID, owner.getDomainId());
+params.put(ApiConstants.DOMAIN_ID, affinityGroupDomainId);
 params.put(ApiConstants.SUBDOMAIN_ACCESS, subDomainAccess);
 _messageBus.publish(_name, 
EntityManager.MESSAGE_ADD_DOMAIN_WIDE_ENTITY_EVENT, PublishScope.LOCAL,
 params);
@@ -205,6 +207,20 @@ public AffinityGroupVO doInTransaction(TransactionStatus 
status) {
 });
 }
 
+/**
+ * If the account is null (domainLevel is true), then returns the domain 
id passed as a
+ * parameter; otherwise (domainLevel is false) it returns the domain id 
from the owner account.
+ *
+ * @note: this method fixes a critical bug. More details in JIRA ticket 

[GitHub] GabrielBrascher commented on issue #2124: CLOUDSTACK-9432: cluster/host dedicated to a domain is owned by the root domain

[GitBox]

GabrielBrascher commented on issue #2124: CLOUDSTACK-9432: cluster/host 
dedicated to a domain is owned by the root domain
URL: https://github.com/apache/cloudstack/pull/2124#issuecomment-347507685
 
 
   Thanks for the review @rafaelweingartner @houthuis @remibergsma @rhtyd. I 
think this PR is ready for merge.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9

[GitBox]

blueorangutan commented on issue #2211: CLOUDSTACK-10013: Migrate 
systemvmtemplate to Debian9
URL: https://github.com/apache/cloudstack/pull/2211#issuecomment-346004410
 
 
   Trillian test result (tid-1673)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 52593 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2211-t1673-kvm-centos7.zip
   Intermitten failure detected: 
/marvin/tests/smoke/test_deploy_virtio_scsi_vm.py
   Intermitten failure detected: /marvin/tests/smoke/test_host_annotations.py
   Intermitten failure detected: /marvin/tests/smoke/test_internal_lb.py
   Intermitten failure detected: /marvin/tests/smoke/test_loadbalance.py
   Intermitten failure detected: /marvin/tests/smoke/test_nic.py
   Intermitten failure detected: /marvin/tests/smoke/test_password_server.py
   Intermitten failure detected: /marvin/tests/smoke/test_primary_storage.py
   Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
   Intermitten failure detected: /marvin/tests/smoke/test_routers_network_ops.py
   Intermitten failure detected: /marvin/tests/smoke/test_routers.py
   Intermitten failure detected: /marvin/tests/smoke/test_ssvm.py
   Intermitten failure detected: /marvin/tests/smoke/test_vm_snapshots.py
   Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Intermitten failure detected: /marvin/tests/smoke/test_vpc_router_nics.py
   Intermitten failure detected: /marvin/tests/smoke/test_vpc_vpn.py
   Test completed. 49 look OK, 14 have error(s)
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_01_vpc_remote_access_vpn | `Failure` | 126.32 | test_vpc_vpn.py
   test_01_VPC_nics_after_destroy | `Failure` | 1962.68 | 
test_vpc_router_nics.py
   test_05_rvpc_multi_tiers | `Failure` | 425.92 | test_vpc_redundant.py
   test_04_rvpc_network_garbage_collector_nics | `Failure` | 415.62 | 
test_vpc_redundant.py
   test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | 
`Failure` | 394.89 | test_vpc_redundant.py
   test_02_redundant_VPC_default_routes | `Failure` | 451.19 | 
test_vpc_redundant.py
   test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 491.92 | 
test_vpc_redundant.py
   test_10_destroy_cpvm | `Failure` | 276.62 | test_ssvm.py
   test_09_destroy_ssvm | `Failure` | 434.22 | test_ssvm.py
   test_08_reboot_cpvm | `Failure` | 186.45 | test_ssvm.py
   test_06_stop_cpvm | `Failure` | 191.61 | test_ssvm.py
   test_04_cpvm_internals | `Failure` | 0.88 | test_ssvm.py
   test_03_ssvm_internals | `Failure` | 2.91 | test_ssvm.py
   test_03_RVR_Network_check_router_state | `Failure` | 239.81 | 
test_routers_network_ops.py
   test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | `Failure` | 
432.26 | test_routers_network_ops.py
   test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | `Failure` | 
460.06 | test_routers_network_ops.py
   test_02_router_internal_adv | `Failure` | 1.01 | test_routers.py
   test_04_rvpc_privategw_static_routes | `Failure` | 832.01 | 
test_privategw_acl.py
   test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 278.68 | 
test_privategw_acl.py
   test_02_vpc_privategw_static_routes | `Failure` | 288.72 | 
test_privategw_acl.py
   test_01_vpc_privategw_acl | `Failure` | 96.87 | test_privategw_acl.py
   test_assign_and_removal_lb | `Failure` | 115.43 | test_loadbalance.py
   test_02_create_lb_rule_non_nat | `Failure` | 110.44 | test_loadbalance.py
   test_01_create_lb_rule_src_nat | `Failure` | 115.58 | test_loadbalance.py
   test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 | `Failure` | 629.39 | 
test_internal_lb.py
   test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 | `Failure` | 389.94 | 
test_internal_lb.py
   test_01_redundant_vpc_site2site_vpn | `Error` | 997.12 | test_vpc_vpn.py
   test_05_rvpc_multi_tiers | `Error` | 476.80 | test_vpc_redundant.py
   test_07_reboot_ssvm | `Error` | 305.56 | test_ssvm.py
   test_05_stop_ssvm | `Error` | 425.86 | test_ssvm.py
   test_01_primary_storage_nfs | `Error` | 0.15 | test_primary_storage.py
   ContextSuite context=TestStorageTags>:setup | `Error` | 0.26 | 
test_primary_storage.py
   test_isolate_network_password_server | `Error` | 20.59 | 
test_password_server.py
   test_01_nic | `Error` | 288.27 | test_nic.py
   test_04_rvpc_internallb_haproxy_stats_on_all_interfaces | `Error` | 652.66 | 
test_internal_lb.py
   test_03_vpc_internallb_haproxy_stats_on_all_interfaces | `Error` | 326.31 | 
test_internal_lb.py
   test_05_add_annotation_for_invalid_entityType | `Error` | 0.08 | 
test_host_annotations.py
   test_06_verify_guest_lspci_again | `Error` | 610.79 | 
test_deploy_virtio_scsi_vm.py
   test_04_verify_guest_lspci | `Error` | 610.77 | test_deploy_virtio_scsi_vm.py
   test_change_service_offering_for_vm_with_snapshots | Skipped | 0.00 | 
test_vm_snapshots.py
   test_09_copy_delete_template | Skipped | 0.02 | test_templates.py
   

[GitHub] nitin-maharana commented on a change in pull request #2340: CLOUDSTACK-10106: GPU/vGPU Support on VMWare

[GitBox]

nitin-maharana commented on a change in pull request #2340: CLOUDSTACK-10106: 
GPU/vGPU Support on VMWare
URL: https://github.com/apache/cloudstack/pull/2340#discussion_r153443468
 
 

 ##
 File path: 
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
 ##
 @@ -5101,14 +5209,32 @@ private void fillHostNetworkInfo(VmwareContext 
serviceContext, StartupRoutingCom
 }
 }
 
-private void fillHostDetailsInfo(VmwareContext serviceContext, Map details) throws Exception {
+private void fillHostDetailsInfo(final Map details) throws 
Exception {
 VmwareHypervisorHost hyperHost = getHyperHost(getServiceContext());
 
 if (hyperHost.isHAEnabled()) {
 details.put("NativeHA", "true");
 }
 }
 
+private void fillHostGpuInfo(final StartupRoutingCommand cmd) throws 
Exception {
+final VmwareContext context = getServiceContext();
+final VmwareHypervisorHost hyperHost = getHyperHost(context);
+final HostMO hostMo = new HostMO(context, hyperHost.getMor());
+
+try {
+final HashMap> groupDetails 
= hostMo.getGPUGroupDetails();
+cmd.setGpuGroupDetails(groupDetails);
+if (groupDetails != null && !groupDetails.isEmpty()) {
+cmd.setHostTags("GPU");
+}
+} catch (final Exception e) {
 
 Review comment:
   Sure. I will modify this.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] nitin-maharana commented on a change in pull request #2340: CLOUDSTACK-10106: GPU/vGPU Support on VMWare

[GitBox]

nitin-maharana commented on a change in pull request #2340: CLOUDSTACK-10106: 
GPU/vGPU Support on VMWare
URL: https://github.com/apache/cloudstack/pull/2340#discussion_r153440683
 
 

 ##
 File path: 
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
 ##
 @@ -4766,6 +4848,31 @@ protected Answer execute(UnregisterNicCommand cmd) {
 }
 }
 
+/**
+ * GetGPUStatsCommand is used to collect the GPU/vGPU details of all the
+ * GPU enabled hosts.
+ * Do Nothing.
+ * @param cmd
+ * @return Answer
+ */
+protected Answer execute(final GetGPUStatsCommand cmd) {
+final VmwareContext context = getServiceContext();
+final VmwareHypervisorHost hyperHost = getHyperHost(context);
+final HostMO hostMo = new HostMO(context, hyperHost.getMor());
+
+HashMap> groupDetails = new 
HashMap>();
+
+try {
+groupDetails = hostMo.getGPUGroupDetails();
 
 Review comment:
   You mean this statement: return new GetGPUStatsAnswer(cmd, groupDetails);?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] nitin-maharana commented on a change in pull request #2340: CLOUDSTACK-10106: GPU/vGPU Support on VMWare

[GitBox]

nitin-maharana commented on a change in pull request #2340: CLOUDSTACK-10106: 
GPU/vGPU Support on VMWare
URL: https://github.com/apache/cloudstack/pull/2340#discussion_r153436096
 
 

 ##
 File path: 
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
 ##
 @@ -3348,9 +3404,35 @@ protected Answer execute(StopCommand cmd) {
 // i.e., i-x-y. This is the internal VM name.
 VmwareContext context = getServiceContext();
 VmwareHypervisorHost hyperHost = getHyperHost(context);
+
 try {
 VirtualMachineMO vmMo = 
hyperHost.findVmOnHyperHost(cmd.getVmName());
+
 if (vmMo != null) {
 
 Review comment:
   Sure, I would do that.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] nitin-maharana commented on a change in pull request #2340: CLOUDSTACK-10106: GPU/vGPU Support on VMWare

[GitBox]

nitin-maharana commented on a change in pull request #2340: CLOUDSTACK-10106: 
GPU/vGPU Support on VMWare
URL: https://github.com/apache/cloudstack/pull/2340#discussion_r153434917
 
 

 ##
 File path: 
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
 ##
 @@ -2254,6 +2270,46 @@ protected void configureVideoCard(VirtualMachineMO 
vmMo, VirtualMachineTO vmSpec
 }
 }
 
+/**
+ * Sets GPU card details to the one provided in detail vgpu.type (if 
provided) on {@code vmConfigSpec}.
+ * @param vmMo
+ * @param vmSpec
+ * @param vmConfigSpec
+ * @throws RuntimeFaultFaultMsg
+ * @throws Exception
+ */
+protected void configureGpuCard(final VirtualMachineMO vmMo, final 
VirtualMachineTO vmSpec, final VirtualMachineConfigSpec vmConfigSpec) throws 
Exception {
+final String vGpuProfile = vmSpec.getGpuDevice().getVgpuType();
+
+VirtualDevice pciPassthroughDevice = null;
+HostMO hostMo = new HostMO(vmMo.getContext(), 
getHyperHost(vmMo.getContext()).getMor());
+
+if (vGpuProfile.equalsIgnoreCase(GPU.GPUType.passthrough.toString())) {
+// Fetch the available direct PCI graphics card available for 
allocation
+String pciDeviceId = 
hostMo.getPciIdForAvailableDirectPciPassthroughDevice();
+VirtualMachinePciPassthroughInfo hostPciDeviceInfo = 
hostMo.getHostPciDeviceInfo(pciDeviceId);
+
+if (hostPciDeviceInfo == null) {
+final String msg = "Unable to find free passthrough GPU to be 
allocated to VM. Please check the host hardware configuration.";
+s_logger.error(msg);
+throw new Exception(msg);
+}
+
+pciPassthroughDevice = 
hostMo.prepareDirectPciPassthroughDevice(hostPciDeviceInfo);
+} else {
+pciPassthroughDevice = 
hostMo.prepareSharedPciPassthroughDevice(vGpuProfile);
+}
+
+if (pciPassthroughDevice != null) {
 
 Review comment:
   @rafaelweingartner, I just cross-checked, It's not possible because we 
initialize the object in hostMo prepareDirectPciPassthroughDevice and 
prepareSharedPciPassthroughDevice If/Else statement. It's redundant but I feel 
it's safe to check. Do you want me to remove?  Thanks!!


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9

[GitBox]

blueorangutan commented on issue #2211: CLOUDSTACK-10013: Migrate 
systemvmtemplate to Debian9
URL: https://github.com/apache/cloudstack/pull/2211#issuecomment-346900674
 
 
   Packaging result: ?centos6 ?centos7 ?debian. JID-1298


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9

[GitBox]

blueorangutan commented on issue #2211: CLOUDSTACK-10013: Migrate 
systemvmtemplate to Debian9
URL: https://github.com/apache/cloudstack/pull/2211#issuecomment-347012905
 
 
   Packaging result: ?centos6 ?centos7 ?debian. JID-1304


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2211: CLOUDSTACK-10013: Migrate systemvmtemplate to Debian9

[GitBox]

blueorangutan commented on issue #2211: CLOUDSTACK-10013: Migrate 
systemvmtemplate to Debian9
URL: https://github.com/apache/cloudstack/pull/2211#issuecomment-346948871
 
 
   Packaging result: ?centos6 ?centos7 ?debian. JID-1299


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services