[GitHub] blueorangutan commented on issue #2376: [4.11] Smoketest Health Check

[GitBox]

blueorangutan commented on issue #2376: [4.11] Smoketest Health Check
URL: https://github.com/apache/cloudstack/pull/2376#issuecomment-369484773
 
 
   Trillian test result (tid-2301)
   Environment: vmware-65 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 36711 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2376-t2301-vmware-65.zip
   Smoke tests completed. 67 look OK, 0 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2469: CLOUDSTACK-10132: Extend support for management servers LB for agents

[GitBox]

blueorangutan commented on issue #2469: CLOUDSTACK-10132: Extend support for 
management servers LB for agents
URL: https://github.com/apache/cloudstack/pull/2469#issuecomment-369468980
 
 
   Trillian test result (tid-2300)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 30863 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2469-t2300-kvm-centos7.zip
   Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
   Intermitten failure detected: /marvin/tests/smoke/test_hostha_kvm.py
   Smoke tests completed. 65 look OK, 2 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_02_vpc_privategw_static_routes | `Failure` | 191.87 | 
test_privategw_acl.py
   test_04_rvpc_privategw_static_routes | `Failure` | 336.46 | 
test_privategw_acl.py
   test_hostha_enable_ha_when_host_in_maintenance | `Error` | 1.94 | 
test_hostha_kvm.py
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2458: CLOUDSTACK-10296: Find time different from last timestamp

[GitBox]

blueorangutan commented on issue #2458: CLOUDSTACK-10296: Find time different 
from last timestamp
URL: https://github.com/apache/cloudstack/pull/2458#issuecomment-369451877
 
 
   Trillian test result (tid-2299)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 35592 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2458-t2299-kvm-centos7.zip
   Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
   Intermitten failure detected: /marvin/tests/smoke/test_public_ip_range.py
   Intermitten failure detected: /marvin/tests/smoke/test_templates.py
   Intermitten failure detected: /marvin/tests/smoke/test_usage.py
   Intermitten failure detected: /marvin/tests/smoke/test_volumes.py
   Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Smoke tests completed. 62 look OK, 5 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 151.60 | 
test_privategw_acl.py
   test_04_extract_template | `Failure` | 128.27 | test_templates.py
   ContextSuite context=TestISOUsage>:setup | `Error` | 0.00 | test_usage.py
   test_06_download_detached_volume | `Failure` | 139.67 | test_volumes.py
   test_04_rvpc_network_garbage_collector_nics | `Failure` | 514.94 | 
test_vpc_redundant.py
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rafaelweingartner commented on issue #2437: [CLOUDSTACK-10257]Create template/volume does not allow to specify HVM requirements

[GitBox]

rafaelweingartner commented on issue #2437: [CLOUDSTACK-10257]Create 
template/volume does not allow to specify HVM requirements
URL: https://github.com/apache/cloudstack/pull/2437#issuecomment-369397722
 
 
   @khos2ow would you mind reviewing this one?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2376: [4.11] Smoketest Health Check

[GitBox]

blueorangutan commented on issue #2376: [4.11] Smoketest Health Check
URL: https://github.com/apache/cloudstack/pull/2376#issuecomment-369368022
 
 
   Trillian test result (tid-2296)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 33095 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2376-t2296-kvm-centos7.zip
   Intermitten failure detected: /marvin/tests/smoke/test_host_maintenance.py
   Intermitten failure detected: /marvin/tests/smoke/test_hostha_kvm.py
   Smoke tests completed. 66 look OK, 1 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_hostha_enable_ha_when_host_in_maintenance | `Error` | 4.08 | 
test_hostha_kvm.py
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2376: [4.11] Smoketest Health Check

[GitBox]

blueorangutan commented on issue #2376: [4.11] Smoketest Health Check
URL: https://github.com/apache/cloudstack/pull/2376#issuecomment-369348423
 
 
   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-65) has been 
kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2376: [4.11] Smoketest Health Check

[GitBox]

rhtyd commented on issue #2376: [4.11] Smoketest Health Check
URL: https://github.com/apache/cloudstack/pull/2376#issuecomment-369348300
 
 
   @blueorangutan test centos7 vmware-65


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2469: CLOUDSTACK-10132: Extend support for management servers LB for agents

[GitBox]

blueorangutan commented on issue #2469: CLOUDSTACK-10132: Extend support for 
management servers LB for agents
URL: https://github.com/apache/cloudstack/pull/2469#issuecomment-369348141
 
 
   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been 
kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2469: CLOUDSTACK-10132: Extend support for management servers LB for agents

[GitBox]

rhtyd commented on issue #2469: CLOUDSTACK-10132: Extend support for management 
servers LB for agents
URL: https://github.com/apache/cloudstack/pull/2469#issuecomment-369347995
 
 
   @blueorangutan test 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2439: [CLOUDSTACK-10259] Missing float part of secondary storage data in listAccounts method

[GitBox]

blueorangutan commented on issue #2439: [CLOUDSTACK-10259] Missing float part 
of secondary storage data in listAccounts method
URL: https://github.com/apache/cloudstack/pull/2439#issuecomment-369346636
 
 
   Trillian test result (tid-2294)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 34174 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2439-t2294-kvm-centos7.zip
   Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
   Intermitten failure detected: /marvin/tests/smoke/test_ssvm.py
   Intermitten failure detected: /marvin/tests/smoke/test_hostha_kvm.py
   Smoke tests completed. 65 look OK, 2 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_04_rvpc_privategw_static_routes | `Failure` | 382.89 | 
test_privategw_acl.py
   test_hostha_enable_ha_when_host_in_maintenance | `Error` | 3.10 | 
test_hostha_kvm.py
   test_hostha_kvm_host_recovering | `Error` | 8.01 | test_hostha_kvm.py
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2469: CLOUDSTACK-10132: Extend support for management servers LB for agents

[GitBox]

blueorangutan commented on issue #2469: CLOUDSTACK-10132: Extend support for 
management servers LB for agents
URL: https://github.com/apache/cloudstack/pull/2469#issuecomment-369336980
 
 
   Trillian test result (tid-2293)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 33477 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2469-t2293-kvm-centos7.zip
   Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
   Intermitten failure detected: /marvin/tests/smoke/test_hostha_kvm.py
   Smoke tests completed. 65 look OK, 2 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_02_vpc_privategw_static_routes | `Failure` | 215.78 | 
test_privategw_acl.py
   test_04_rvpc_privategw_static_routes | `Failure` | 336.79 | 
test_privategw_acl.py
   test_hostha_enable_ha_when_host_in_maintenance | `Error` | 1.17 | 
test_hostha_kvm.py
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rafaelweingartner commented on issue #2433: CLOUDSTACK-10268: Fix and enhance package script

[GitBox]

rafaelweingartner commented on issue #2433: CLOUDSTACK-10268: Fix and enhance 
package script
URL: https://github.com/apache/cloudstack/pull/2433#issuecomment-369332416
 
 
   @rhtyd the other changes you were talking about, are they one "Version.java"?
   
   @khos2ow can you explain them further?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rafaelweingartner commented on issue #2433: CLOUDSTACK-10268: Fix and enhance package script

[GitBox]

rafaelweingartner commented on issue #2433: CLOUDSTACK-10268: Fix and enhance 
package script
URL: https://github.com/apache/cloudstack/pull/2433#issuecomment-369332416
 
 
   @rhtyd the other changes you were talking about, are they on "Version.java"?
   
   @khos2ow can you explain them further?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rafaelweingartner commented on a change in pull request #2433: CLOUDSTACK-10268: Fix and enhance package script

[GitBox]

rafaelweingartner commented on a change in pull request #2433: 
CLOUDSTACK-10268: Fix and enhance package script
URL: https://github.com/apache/cloudstack/pull/2433#discussion_r171336674
 
 

 ##
 File path: tools/build/setnextversion.sh
 ##
 @@ -16,60 +16,125 @@
 # specific language governing permissions and limitations
 # under the License.
 
-version='TESTBUILD'
-sourcedir=~/cloudstack/
-branch='master'
+set -e
 
-usage(){
-echo "usage: $0 -v version [-b branch] [-s source dir] [-h]"
-echo "  -v sets the version"
-echo "  -b sets the branch (defaults to 'master')"
-echo "  -s sets the source directory (defaults to $sourcedir)"
-echo "  -h"
+usage() {
+cat << USAGE
+Usage: setnextversion.sh --version string [OPTIONS]...
+Set the next version of CloudStack in the POMs.
+
+Mandatory arguments:
+   -v, --version stringSet the next version to be applied
+
+Optional arguments:
+   -b, --branch string Set the branch to update the 
version into (default "master")
+   -s, --sourcedir string  Set the source directory to clone 
repo into (default "$sourcedir")
+   -n, --no-commit Apply only the version change and 
don't git commit them (default "false")
 
 Review comment:
   As far as I know we do not have a wiki page to document this script. It 
might be interesting to create one though.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rafaelweingartner commented on issue #2470: [CLOUDSTACK-10197] Update DisplayText of XenServer tools ISO entry in the database when it already exists

[GitBox]

rafaelweingartner commented on issue #2470: [CLOUDSTACK-10197] Update 
DisplayText of XenServer tools ISO entry in the database when it already exists
URL: https://github.com/apache/cloudstack/pull/2470#issuecomment-369331118
 
 
   @khos2ow thanks for the review.
   And yes, those check-style rules are quite annoying. We need to discuss and 
change them to better fit the common practice nowadays.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] khos2ow commented on a change in pull request #2433: CLOUDSTACK-10268: Fix and enhance package script

[GitBox]

khos2ow commented on a change in pull request #2433: CLOUDSTACK-10268: Fix and 
enhance package script
URL: https://github.com/apache/cloudstack/pull/2433#discussion_r171329386
 
 

 ##
 File path: tools/build/setnextversion.sh
 ##
 @@ -16,60 +16,125 @@
 # specific language governing permissions and limitations
 # under the License.
 
-version='TESTBUILD'
-sourcedir=~/cloudstack/
-branch='master'
+set -e
 
-usage(){
-echo "usage: $0 -v version [-b branch] [-s source dir] [-h]"
-echo "  -v sets the version"
-echo "  -b sets the branch (defaults to 'master')"
-echo "  -s sets the source directory (defaults to $sourcedir)"
-echo "  -h"
+usage() {
+cat << USAGE
+Usage: setnextversion.sh --version string [OPTIONS]...
+Set the next version of CloudStack in the POMs.
+
+Mandatory arguments:
+   -v, --version stringSet the next version to be applied
+
+Optional arguments:
+   -b, --branch string Set the branch to update the 
version into (default "master")
+   -s, --sourcedir string  Set the source directory to clone 
repo into (default "$sourcedir")
+   -n, --no-commit Apply only the version change and 
don't git commit them (default "false")
 
 Review comment:
   Where in wiki? The only place I could find that references 
`setnextversion.sh` is 
https://cwiki.apache.org/confluence/display/CLOUDSTACK/Release+Procedure .


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] khos2ow commented on issue #2470: [CLOUDSTACK-10197] Update DisplayText of XenServer tools ISO entry in the database when it already exists

[GitBox]

khos2ow commented on issue #2470: [CLOUDSTACK-10197] Update DisplayText of 
XenServer tools ISO entry in the database when it already exists
URL: https://github.com/apache/cloudstack/pull/2470#issuecomment-369320257
 
 
   @rafaelweingartner It seems you have some "trailing spaces" issues on 
`XcpServerDiscovererTest.java` and couple of variable name issues. The latter 
one is really annoying, because it forces to have `^_?[a-zA-Z0-9]*$` for final 
variables.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2376: [4.11] Smoketest Health Check

[GitBox]

blueorangutan commented on issue #2376: [4.11] Smoketest Health Check
URL: https://github.com/apache/cloudstack/pull/2376#issuecomment-369305048
 
 
   Trillian test result (tid-2297)
   Environment: vmware-65 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 21277 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2376-t2297-vmware-65.zip
   Intermitten failure detected: /marvin/tests/smoke/test_public_ip_range.py
   Intermitten failure detected: /marvin/tests/smoke/test_reset_vm_on_reboot.py
   Intermitten failure detected: /marvin/tests/smoke/test_router_dhcphosts.py
   Intermitten failure detected: /marvin/tests/smoke/test_router_dns.py
   Intermitten failure detected: /marvin/tests/smoke/test_router_dnsservice.py
   Intermitten failure detected: 
/marvin/tests/smoke/test_routers_iptables_default_policy.py
   Intermitten failure detected: /marvin/tests/smoke/test_routers_network_ops.py
   Intermitten failure detected: /marvin/tests/smoke/test_routers.py
   Intermitten failure detected: /marvin/tests/smoke/test_scale_vm.py
   Intermitten failure detected: /marvin/tests/smoke/test_secondary_storage.py
   Intermitten failure detected: /marvin/tests/smoke/test_service_offerings.py
   Intermitten failure detected: /marvin/tests/smoke/test_snapshots.py
   Intermitten failure detected: /marvin/tests/smoke/test_ssvm.py
   Intermitten failure detected: /marvin/tests/smoke/test_templates.py
   Intermitten failure detected: /marvin/tests/smoke/test_usage.py
   Intermitten failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
   Intermitten failure detected: /marvin/tests/smoke/test_vm_snapshots.py
   Intermitten failure detected: /marvin/tests/smoke/test_volumes.py
   Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Intermitten failure detected: /marvin/tests/smoke/test_vpc_router_nics.py
   Intermitten failure detected: /marvin/tests/smoke/test_vpc_vpn.py
   Intermitten failure detected: /marvin/tests/smoke/test_host_maintenance.py
   Smoke tests completed. 46 look OK, 21 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   ContextSuite context=TestResetVmOnReboot>:setup | `Error` | 0.00 | 
test_reset_vm_on_reboot.py
   ContextSuite context=TestRouterDHCPHosts>:setup | `Error` | 0.00 | 
test_router_dhcphosts.py
   ContextSuite context=TestRouterDHCPOpts>:setup | `Error` | 0.00 | 
test_router_dhcphosts.py
   ContextSuite context=TestRouterDns>:setup | `Error` | 0.00 | 
test_router_dns.py
   ContextSuite context=TestRouterDnsService>:setup | `Error` | 0.00 | 
test_router_dnsservice.py
   ContextSuite context=TestRouterIpTablesPolicies>:setup | `Error` | 0.00 | 
test_routers_iptables_default_policy.py
   ContextSuite context=TestVPCIpTablesPolicies>:setup | `Error` | 0.00 | 
test_routers_iptables_default_policy.py
   test_01_isolate_network_FW_PF_default_routes_egress_true | `Error` | 0.19 | 
test_routers_network_ops.py
   test_02_isolate_network_FW_PF_default_routes_egress_false | `Error` | 0.19 | 
test_routers_network_ops.py
   ContextSuite context=TestRedundantIsolateNetworks>:setup | `Error` | 1.53 | 
test_routers_network_ops.py
   ContextSuite context=TestRouterServices>:setup | `Error` | 0.00 | 
test_routers.py
   ContextSuite context=TestScaleVm>:setup | `Error` | 0.00 | test_scale_vm.py
   test_01_sys_vm_start | `Failure` | 0.16 | test_secondary_storage.py
   test_02_sys_template_ready | `Failure` | 0.16 | test_secondary_storage.py
   ContextSuite context=TestServiceOfferings>:setup | `Error` | 0.34 | 
test_service_offerings.py
   ContextSuite context=TestSnapshotRootDisk>:setup | `Error` | 0.00 | 
test_snapshots.py
   test_01_list_sec_storage_vm | `Failure` | 0.07 | test_ssvm.py
   test_02_list_cpvm_vm | `Failure` | 0.07 | test_ssvm.py
   test_03_ssvm_internals | `Failure` | 0.06 | test_ssvm.py
   test_04_cpvm_internals | `Failure` | 0.06 | test_ssvm.py
   test_05_stop_ssvm | `Failure` | 0.07 | test_ssvm.py
   test_06_stop_cpvm | `Failure` | 0.07 | test_ssvm.py
   test_07_reboot_ssvm | `Failure` | 0.07 | test_ssvm.py
   test_08_reboot_cpvm | `Failure` | 0.07 | test_ssvm.py
   test_09_destroy_ssvm | `Failure` | 0.06 | test_ssvm.py
   test_10_destroy_cpvm | `Failure` | 0.08 | test_ssvm.py
   test_02_create_template_with_checksum_sha1 | `Error` | 65.89 | 
test_templates.py
   test_03_create_template_with_checksum_sha256 | `Error` | 66.09 | 
test_templates.py
   test_04_create_template_with_checksum_md5 | `Error` | 65.55 | 
test_templates.py
   test_05_create_template_with_no_checksum | `Error` | 65.97 | 
test_templates.py
   ContextSuite context=TestTemplates>:setup | `Error` | 1.15 | 
test_templates.py
   ContextSuite context=TestCreateVolume>:setup | `Error` | 0.00 | 
test_volumes.py
   ContextSuite context=TestVolumes>:setup | `Error` | 0.00 | test_volumes.py
   ContextSuite context=TestISOUsage>:setup | `Error` | 0.00 | test_usage.py
   

[GitHub] blueorangutan commented on issue #2433: CLOUDSTACK-10268: Fix and enhance package script

[GitBox]

blueorangutan commented on issue #2433: CLOUDSTACK-10268: Fix and enhance 
package script
URL: https://github.com/apache/cloudstack/pull/2433#issuecomment-369302413
 
 
   Packaging result: ?centos6 ?centos7 ?debian. JID-1747


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2433: CLOUDSTACK-10268: Fix and enhance package script

[GitBox]

rhtyd commented on issue #2433: CLOUDSTACK-10268: Fix and enhance package script
URL: https://github.com/apache/cloudstack/pull/2433#issuecomment-369291280
 
 
   @rafaelweingartner I'm okay with the change subject to testing. However, I 
see several new changes in files not related to packaging.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on a change in pull request #2433: CLOUDSTACK-10268: Fix and enhance package script

[GitBox]

rhtyd commented on a change in pull request #2433: CLOUDSTACK-10268: Fix and 
enhance package script
URL: https://github.com/apache/cloudstack/pull/2433#discussion_r171297624
 
 

 ##
 File path: tools/build/setnextversion.sh
 ##
 @@ -16,60 +16,125 @@
 # specific language governing permissions and limitations
 # under the License.
 
-version='TESTBUILD'
-sourcedir=~/cloudstack/
-branch='master'
+set -e
 
-usage(){
-echo "usage: $0 -v version [-b branch] [-s source dir] [-h]"
-echo "  -v sets the version"
-echo "  -b sets the branch (defaults to 'master')"
-echo "  -s sets the source directory (defaults to $sourcedir)"
-echo "  -h"
+usage() {
+cat << USAGE
+Usage: setnextversion.sh --version string [OPTIONS]...
+Set the next version of CloudStack in the POMs.
+
+Mandatory arguments:
+   -v, --version stringSet the next version to be applied
+
+Optional arguments:
+   -b, --branch string Set the branch to update the 
version into (default "master")
+   -s, --sourcedir string  Set the source directory to clone 
repo into (default "$sourcedir")
+   -n, --no-commit Apply only the version change and 
don't git commit them (default "false")
 
 Review comment:
   @khos2ow @rafaelweingartner please update the wiki as well.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on a change in pull request #2433: CLOUDSTACK-10268: Fix and enhance package script

[GitBox]

rhtyd commented on a change in pull request #2433: CLOUDSTACK-10268: Fix and 
enhance package script
URL: https://github.com/apache/cloudstack/pull/2433#discussion_r171297761
 
 

 ##
 File path: utils/src/main/java/com/cloud/maint/Version.java
 ##
 @@ -19,59 +19,86 @@
 
 package com.cloud.maint;
 
+import java.util.regex.Pattern;
+
+import org.apache.commons.lang.StringUtils;
+
 public class Version {
+public static void main(String[] args) {
 
 Review comment:
   Remove main() @khos2ow 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2433: CLOUDSTACK-10268: Fix and enhance package script

[GitBox]

blueorangutan commented on issue #2433: CLOUDSTACK-10268: Fix and enhance 
package script
URL: https://github.com/apache/cloudstack/pull/2433#issuecomment-369290516
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2433: CLOUDSTACK-10268: Fix and enhance package script

[GitBox]

rhtyd commented on issue #2433: CLOUDSTACK-10268: Fix and enhance package script
URL: https://github.com/apache/cloudstack/pull/2433#issuecomment-369290181
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rafaelweingartner commented on issue #2425: [CLOUDSTACK-10240] ACS cannot migrate a local volume to shared storage

[GitBox]

rafaelweingartner commented on issue #2425: [CLOUDSTACK-10240] ACS cannot 
migrate a local volume to shared storage
URL: https://github.com/apache/cloudstack/pull/2425#issuecomment-369288296
 
 
   @DaanHoogland thanks for the explanations.  Yes I was considering false 
positive/negative differently, but as long as we are able to explain them 
further as you did, we can understand each other.
   
   So, it seems that most of these failures are due to runtime issues, normally 
from timeouts. Moreover, as far as we know it is not possible for the tests to 
return with a "success" message, when there is a problem. Unless, of course, if 
there is a problem/case that the current tests do not cover.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2458: CLOUDSTACK-10296: Find time different from last timestamp

[GitBox]

rhtyd commented on issue #2458: CLOUDSTACK-10296: Find time different from last 
timestamp
URL: https://github.com/apache/cloudstack/pull/2458#issuecomment-369221396
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2458: CLOUDSTACK-10296: Find time different from last timestamp

[GitBox]

blueorangutan commented on issue #2458: CLOUDSTACK-10296: Find time different 
from last timestamp
URL: https://github.com/apache/cloudstack/pull/2458#issuecomment-369221589
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2458: CLOUDSTACK-10296: Find time different from last timestamp

[GitBox]

blueorangutan commented on issue #2458: CLOUDSTACK-10296: Find time different 
from last timestamp
URL: https://github.com/apache/cloudstack/pull/2458#issuecomment-368788862
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2458: CLOUDSTACK-10296: Find time different from last timestamp

[GitBox]

blueorangutan commented on issue #2458: CLOUDSTACK-10296: Find time different 
from last timestamp
URL: https://github.com/apache/cloudstack/pull/2458#issuecomment-368802621
 
 
   Packaging result: ?centos6 ?centos7 ?debian. JID-1736


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2458: CLOUDSTACK-10296: Find time different from last timestamp

[GitBox]

blueorangutan commented on issue #2458: CLOUDSTACK-10296: Find time different 
from last timestamp
URL: https://github.com/apache/cloudstack/pull/2458#issuecomment-369286076
 
 
   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been 
kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2458: CLOUDSTACK-10296: Find time different from last timestamp

[GitBox]

rhtyd commented on issue #2458: CLOUDSTACK-10296: Find time different from last 
timestamp
URL: https://github.com/apache/cloudstack/pull/2458#issuecomment-368840600
 
 
   @blueorangutan test


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2458: CLOUDSTACK-10296: Find time different from last timestamp

[GitBox]

blueorangutan commented on issue #2458: CLOUDSTACK-10296: Find time different 
from last timestamp
URL: https://github.com/apache/cloudstack/pull/2458#issuecomment-368840865
 
 
   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been 
kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2458: CLOUDSTACK-10296: Find time different from last timestamp

[GitBox]

blueorangutan commented on issue #2458: CLOUDSTACK-10296: Find time different 
from last timestamp
URL: https://github.com/apache/cloudstack/pull/2458#issuecomment-369230666
 
 
   Packaging result: ?centos6 ?centos7 ?debian. JID-1743


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2458: CLOUDSTACK-10296: Find time different from last timestamp

[GitBox]

rhtyd commented on issue #2458: CLOUDSTACK-10296: Find time different from last 
timestamp
URL: https://github.com/apache/cloudstack/pull/2458#issuecomment-369285874
 
 
   @blueorangutan test


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2408: asserted fixes for direct downloads

[GitBox]

blueorangutan commented on issue #2408: asserted fixes for direct downloads
URL: https://github.com/apache/cloudstack/pull/2408#issuecomment-369284763
 
 
   Packaging result: ?centos6 ?centos7 ?debian. JID-1746


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2458: CLOUDSTACK-10296: Find time different from last timestamp

[GitBox]

blueorangutan commented on issue #2458: CLOUDSTACK-10296: Find time different 
from last timestamp
URL: https://github.com/apache/cloudstack/pull/2458#issuecomment-369284760
 
 
   Packaging result: ?centos6 ?centos7 ?debian. JID-1745


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2408: asserted fixes for direct downloads

[GitBox]

blueorangutan commented on issue #2408: asserted fixes for direct downloads
URL: https://github.com/apache/cloudstack/pull/2408#issuecomment-369262447
 
 
   @nvazquez a Jenkins job has been kicked to build packages. I'll keep you 
posted as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] nvazquez commented on issue #2408: asserted fixes for direct downloads

[GitBox]

nvazquez commented on issue #2408: asserted fixes for direct downloads
URL: https://github.com/apache/cloudstack/pull/2408#issuecomment-369262338
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2458: CLOUDSTACK-10296: Find time different from last timestamp

[GitBox]

blueorangutan commented on issue #2458: CLOUDSTACK-10296: Find time different 
from last timestamp
URL: https://github.com/apache/cloudstack/pull/2458#issuecomment-369258939
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2458: CLOUDSTACK-10296: Find time different from last timestamp

[GitBox]

rhtyd commented on issue #2458: CLOUDSTACK-10296: Find time different from last 
timestamp
URL: https://github.com/apache/cloudstack/pull/2458#issuecomment-369258652
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] DaanHoogland commented on issue #2425: [CLOUDSTACK-10240] ACS cannot migrate a local volume to shared storage

[GitBox]

DaanHoogland commented on issue #2425: [CLOUDSTACK-10240] ACS cannot migrate a 
local volume to shared storage
URL: https://github.com/apache/cloudstack/pull/2425#issuecomment-369239103
 
 
   @rafaelweingartner , first to clarify; my understanding of flase positive 
and false negitive is reversed from yours;
   a false positive: a bug is reported but it isn't there
   a false negative: a bug is not reported in spite of being there
   kind of like in the doping control mafia; positive means your busted. maybe 
a bit counter intuitive but I'll run with it (pun as happy accident)
   
   So more more to the point, a false positive might be due to a timing issue 
that occurs because of the nested nature of the test environment, and isn't a 
real issue. I can think of no false negative counterpart for that.
   maybe we can think of more examples of the reverse but the issue is that we 
need to assess on each failure if it is noteworthy and we need to keep doing 
code reviews.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] DaanHoogland commented on issue #2425: [CLOUDSTACK-10240] ACS cannot migrate a local volume to shared storage

[GitBox]

DaanHoogland commented on issue #2425: [CLOUDSTACK-10240] ACS cannot migrate a 
local volume to shared storage
URL: https://github.com/apache/cloudstack/pull/2425#issuecomment-369239103
 
 
   @rafaelweingartner , first to clarify; my understanding of false positive 
and false negitive is reversed from yours;
   a false positive: a bug is reported but it isn't there
   a false negative: a bug is not reported in spite of being there
   kind of like in the doping control mafia; positive means your busted. maybe 
a bit counter intuitive but I'll run with it (pun as happy accident)
   
   So more more to the point, a false positive might be due to a timing issue 
that occurs because of the nested nature of the test environment, and isn't a 
real issue. I can think of no false negative counterpart for that.
   maybe we can think of more examples of the reverse but the issue is that we 
need to assess on each failure if it is noteworthy and we need to keep doing 
code reviews.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #1780: Fix the KVM hypervisor's handling of not-really-SCSI devices.

[GitBox]

rhtyd commented on issue #1780: Fix the KVM hypervisor's handling of 
not-really-SCSI devices.
URL: https://github.com/apache/cloudstack/pull/1780#issuecomment-369234235
 
 
   Please fix the conflict.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rafaelweingartner opened a new pull request #2470: Update DisplayText of XenServer tools ISO entry in the database when it already exists

[GitBox]

rafaelweingartner opened a new pull request #2470: Update DisplayText of 
XenServer tools ISO entry in the database when it already exists
URL: https://github.com/apache/cloudstack/pull/2470
 
 
   Changes here were suggestions made to #2365, but for some reason, the PR was 
merged without considering them. Both the update of the ?displayText?  value 
and unit test cases were suggested as improvements in that PR.
   
   After coding, I also when through those classes and removed unused variables.
   
   @khos2ow can you take a look here?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2458: CLOUDSTACK-10296: Find time different from last timestamp

[GitBox]

blueorangutan commented on issue #2458: CLOUDSTACK-10296: Find time different 
from last timestamp
URL: https://github.com/apache/cloudstack/pull/2458#issuecomment-369230666
 
 
   Packaging result: ?centos6 ?centos7 ?debian. JID-1743


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #1780: Fix the KVM hypervisor's handling of not-really-SCSI devices.

[GitBox]

blueorangutan commented on issue #1780: Fix the KVM hypervisor's handling of 
not-really-SCSI devices.
URL: https://github.com/apache/cloudstack/pull/1780#issuecomment-369230668
 
 
   Packaging result: ?centos6 ?centos7 ?debian. JID-1744


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #1780: Fix the KVM hypervisor's handling of not-really-SCSI devices.

[GitBox]

blueorangutan commented on issue #1780: Fix the KVM hypervisor's handling of 
not-really-SCSI devices.
URL: https://github.com/apache/cloudstack/pull/1780#issuecomment-369228676
 
 
   @borisstoyanov a Jenkins job has been kicked to build packages. I'll keep 
you posted as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] borisstoyanov commented on issue #1780: Fix the KVM hypervisor's handling of not-really-SCSI devices.

[GitBox]

borisstoyanov commented on issue #1780: Fix the KVM hypervisor's handling of 
not-really-SCSI devices.
URL: https://github.com/apache/cloudstack/pull/1780#issuecomment-369228604
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2458: CLOUDSTACK-10296: Find time different from last timestamp

[GitBox]

blueorangutan commented on issue #2458: CLOUDSTACK-10296: Find time different 
from last timestamp
URL: https://github.com/apache/cloudstack/pull/2458#issuecomment-369221589
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2458: CLOUDSTACK-10296: Find time different from last timestamp

[GitBox]

rhtyd commented on issue #2458: CLOUDSTACK-10296: Find time different from last 
timestamp
URL: https://github.com/apache/cloudstack/pull/2458#issuecomment-369221396
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rafaelweingartner commented on issue #2425: [CLOUDSTACK-10240] ACS cannot migrate a local volume to shared storage

[GitBox]

rafaelweingartner commented on issue #2425: [CLOUDSTACK-10240] ACS cannot 
migrate a local volume to shared storage
URL: https://github.com/apache/cloudstack/pull/2425#issuecomment-369214377
 
 
   The one I remember right now is the HA test, which I have seen failing in 
PRs 2438 and 2469. 
   My doubt is the following, as long as we have false negatives (showing that 
there is a problem, when there isn't), can't we have false positive (showing 
that everything is ok, when it is not) as well?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] DaanHoogland commented on issue #2425: [CLOUDSTACK-10240] ACS cannot migrate a local volume to shared storage

[GitBox]

DaanHoogland commented on issue #2425: [CLOUDSTACK-10240] ACS cannot migrate a 
local volume to shared storage
URL: https://github.com/apache/cloudstack/pull/2425#issuecomment-369212735
 
 
   These are nested environments in which we test so they might be false 
positives as you imply by your question. I think we still need to check the 
errors. What PR shows these? I saw failures today but nowhere the exact same 
bunch, @rafaelweingartner ?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[cloudstack] branch master updated: dateutil: constistency of tzdate input and output (#2392)

[dahn]

This is an automated email from the ASF dual-hosted git repository.

dahn pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git


The following commit(s) were added to refs/heads/master by this push:
 new 2ad5202  dateutil: constistency of tzdate input and output (#2392)
2ad5202 is described below

commit 2ad520282319da9a03061b8c744e51a4ffdf94a2
Author: Yoan Blanc 
AuthorDate: Wed Feb 28 12:28:10 2018 +0100

dateutil: constistency of tzdate input and output (#2392)

Signed-off-by: Yoan Blanc 
Signed-off-by: Daan Hoogland 
---
 utils/src/main/java/com/cloud/utils/DateUtil.java  | 10 +---
 .../test/java/com/cloud/utils/DateUtilTest.java| 27 +++---
 2 files changed, 26 insertions(+), 11 deletions(-)

diff --git a/utils/src/main/java/com/cloud/utils/DateUtil.java 
b/utils/src/main/java/com/cloud/utils/DateUtil.java
index 7787e1b..9f046d1 100644
--- a/utils/src/main/java/com/cloud/utils/DateUtil.java
+++ b/utils/src/main/java/com/cloud/utils/DateUtil.java
@@ -38,10 +38,14 @@ public class DateUtil {
 return new Date();
 }
 
-// -MM-ddTHH:mm:ssZ
+// -MM-ddTHH:mm:ss or -MM-ddTHH:mm:ssZ
 public static Date parseTZDateString(String str) throws ParseException {
-DateFormat dfParse = new SimpleDateFormat("-MM-dd'T'HH:mm:ss'Z'Z");
-return dfParse.parse(str);
+try {
+return s_outputFormat.parse(str);
+} catch (ParseException e) {
+final DateFormat dfParse = new 
SimpleDateFormat("-MM-dd'T'HH:mm:ss'Z'Z");
+return dfParse.parse(str);
+}
 }
 
 public static Date parseDateString(TimeZone tz, String dateString) {
diff --git a/utils/src/test/java/com/cloud/utils/DateUtilTest.java 
b/utils/src/test/java/com/cloud/utils/DateUtilTest.java
index ba88505..190adea 100644
--- a/utils/src/test/java/com/cloud/utils/DateUtilTest.java
+++ b/utils/src/test/java/com/cloud/utils/DateUtilTest.java
@@ -27,6 +27,9 @@ import java.util.TimeZone;
 
 import com.cloud.utils.DateUtil.IntervalType;
 
+import org.junit.Test;
+
+import static org.junit.Assert.assertEquals;
 
 public class DateUtilTest {
 
@@ -44,17 +47,25 @@ public class DateUtilTest {
 if (args.length == 2) {
 System.out.println("Next run time: " + 
DateUtil.getNextRunTime(IntervalType.getIntervalType(args[0]), args[1], "GMT", 
time).toString());
 }
+}
 
-time = new Date();
+@Test
+public void zonedTimeFormatLegacy() throws ParseException {
+Date time = new Date();
 DateFormat dfDate = new SimpleDateFormat("-MM-dd'T'HH:mm:ss'Z'Z");
 String str = dfDate.format(time);
-System.out.println("Formated TZ time string : " + str);
-try {
-Date dtParsed = DateUtil.parseTZDateString(str);
-System.out.println("Parsed TZ time string : " + 
dtParsed.toString());
-} catch (ParseException e) {
-System.err.println("Parsing failed\n string : " + str + 
"\nexception :" + e.getLocalizedMessage());
-}
+Date dtParsed = DateUtil.parseTZDateString(str);
+
+assertEquals(time.toString(), dtParsed.toString());
 }
 
+@Test
+public void zonedTimeFormat() throws ParseException {
+Date time = new Date();
+DateFormat dfDate = new SimpleDateFormat("-MM-dd'T'HH:mm:ssZ");
+String str = dfDate.format(time);
+Date dtParsed = DateUtil.parseTZDateString(str);
+
+assertEquals(time.toString(), dtParsed.toString());
+}
 }

-- 
To stop receiving notification emails like this one, please contact
d...@apache.org.

[GitHub] DaanHoogland closed pull request #2392: dateutil: constistency of tzdate input and output

[GitBox]

DaanHoogland closed pull request #2392: dateutil: constistency of tzdate input 
and output
URL: https://github.com/apache/cloudstack/pull/2392
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/utils/src/main/java/com/cloud/utils/DateUtil.java 
b/utils/src/main/java/com/cloud/utils/DateUtil.java
index 7787e1be3ba..9f046d11446 100644
--- a/utils/src/main/java/com/cloud/utils/DateUtil.java
+++ b/utils/src/main/java/com/cloud/utils/DateUtil.java
@@ -38,10 +38,14 @@ public static Date currentGMTTime() {
 return new Date();
 }
 
-// -MM-ddTHH:mm:ssZ
+// -MM-ddTHH:mm:ss or -MM-ddTHH:mm:ssZ
 public static Date parseTZDateString(String str) throws ParseException {
-DateFormat dfParse = new SimpleDateFormat("-MM-dd'T'HH:mm:ss'Z'Z");
-return dfParse.parse(str);
+try {
+return s_outputFormat.parse(str);
+} catch (ParseException e) {
+final DateFormat dfParse = new 
SimpleDateFormat("-MM-dd'T'HH:mm:ss'Z'Z");
+return dfParse.parse(str);
+}
 }
 
 public static Date parseDateString(TimeZone tz, String dateString) {
diff --git a/utils/src/test/java/com/cloud/utils/DateUtilTest.java 
b/utils/src/test/java/com/cloud/utils/DateUtilTest.java
index ba88505f04d..190adeab2db 100644
--- a/utils/src/test/java/com/cloud/utils/DateUtilTest.java
+++ b/utils/src/test/java/com/cloud/utils/DateUtilTest.java
@@ -27,6 +27,9 @@
 
 import com.cloud.utils.DateUtil.IntervalType;
 
+import org.junit.Test;
+
+import static org.junit.Assert.assertEquals;
 
 public class DateUtilTest {
 
@@ -44,17 +47,25 @@ public static void main(String[] args) {
 if (args.length == 2) {
 System.out.println("Next run time: " + 
DateUtil.getNextRunTime(IntervalType.getIntervalType(args[0]), args[1], "GMT", 
time).toString());
 }
+}
 
-time = new Date();
+@Test
+public void zonedTimeFormatLegacy() throws ParseException {
+Date time = new Date();
 DateFormat dfDate = new SimpleDateFormat("-MM-dd'T'HH:mm:ss'Z'Z");
 String str = dfDate.format(time);
-System.out.println("Formated TZ time string : " + str);
-try {
-Date dtParsed = DateUtil.parseTZDateString(str);
-System.out.println("Parsed TZ time string : " + 
dtParsed.toString());
-} catch (ParseException e) {
-System.err.println("Parsing failed\n string : " + str + 
"\nexception :" + e.getLocalizedMessage());
-}
+Date dtParsed = DateUtil.parseTZDateString(str);
+
+assertEquals(time.toString(), dtParsed.toString());
 }
 
+@Test
+public void zonedTimeFormat() throws ParseException {
+Date time = new Date();
+DateFormat dfDate = new SimpleDateFormat("-MM-dd'T'HH:mm:ssZ");
+String str = dfDate.format(time);
+Date dtParsed = DateUtil.parseTZDateString(str);
+
+assertEquals(time.toString(), dtParsed.toString());
+}
 }


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] DaanHoogland commented on issue #2392: dateutil: constistency of tzdate input and output

[GitBox]

DaanHoogland commented on issue #2392: dateutil: constistency of tzdate input 
and output
URL: https://github.com/apache/cloudstack/pull/2392#issuecomment-369210911
 
 
   checked the error, it is a network unavailable so not related to the date 
format :)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2376: [4.11] Smoketest Health Check

[GitBox]

rhtyd commented on issue #2376: [4.11] Smoketest Health Check
URL: https://github.com/apache/cloudstack/pull/2376#issuecomment-369195992
 
 
   @blueorangutan test matrix


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2376: [4.11] Smoketest Health Check

[GitBox]

blueorangutan commented on issue #2376: [4.11] Smoketest Health Check
URL: https://github.com/apache/cloudstack/pull/2376#issuecomment-369195854
 
 
   Packaging result: ?centos6 ?centos7 ?debian. JID-1742


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2376: [4.11] Smoketest Health Check

[GitBox]

blueorangutan commented on issue #2376: [4.11] Smoketest Health Check
URL: https://github.com/apache/cloudstack/pull/2376#issuecomment-369185397
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2376: [4.11] Smoketest Health Check

[GitBox]

rhtyd commented on issue #2376: [4.11] Smoketest Health Check
URL: https://github.com/apache/cloudstack/pull/2376#issuecomment-369185234
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] borisstoyanov commented on issue #2439: [CLOUDSTACK-10259] Missing float part of secondary storage data in listAccounts method

[GitBox]

borisstoyanov commented on issue #2439: [CLOUDSTACK-10259] Missing float part 
of secondary storage data in listAccounts method
URL: https://github.com/apache/cloudstack/pull/2439#issuecomment-369167711
 
 
   @blueorangutan test


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2439: [CLOUDSTACK-10259] Missing float part of secondary storage data in listAccounts method

[GitBox]

blueorangutan commented on issue #2439: [CLOUDSTACK-10259] Missing float part 
of secondary storage data in listAccounts method
URL: https://github.com/apache/cloudstack/pull/2439#issuecomment-369167781
 
 
   @borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has 
been kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2469: CLOUDSTACK-10132: Extend support for management servers LB for agents

[GitBox]

rhtyd commented on issue #2469: CLOUDSTACK-10132: Extend support for management 
servers LB for agents
URL: https://github.com/apache/cloudstack/pull/2469#issuecomment-369162909
 
 
   @blueorangutan test


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2469: CLOUDSTACK-10132: Extend support for management servers LB for agents

[GitBox]

blueorangutan commented on issue #2469: CLOUDSTACK-10132: Extend support for 
management servers LB for agents
URL: https://github.com/apache/cloudstack/pull/2469#issuecomment-369163049
 
 
   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been 
kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services