[GitHub] blueorangutan commented on issue #2502: [CLOUDSTACK-10352] XenServer: Support online migration of a virtual disk from non-managed to managed storage

[GitBox]

blueorangutan commented on issue #2502: [CLOUDSTACK-10352] XenServer: Support 
online migration of a virtual disk from non-managed to managed storage
URL: https://github.com/apache/cloudstack/pull/2502#issuecomment-380311941
 
 
   Trillian test result (tid-2487)
   Environment: vmware-65 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 51499 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2502-t2487-vmware-65.zip
   Intermitten failure detected: /marvin/tests/smoke/test_certauthority_root.py
   Intermitten failure detected: /marvin/tests/smoke/test_public_ip_range.py
   Intermitten failure detected: /marvin/tests/smoke/test_reset_vm_on_reboot.py
   Intermitten failure detected: /marvin/tests/smoke/test_router_dhcphosts.py
   Intermitten failure detected: /marvin/tests/smoke/test_router_dns.py
   Intermitten failure detected: /marvin/tests/smoke/test_router_dnsservice.py
   Intermitten failure detected: 
/marvin/tests/smoke/test_routers_iptables_default_policy.py
   Intermitten failure detected: /marvin/tests/smoke/test_routers_network_ops.py
   Intermitten failure detected: /marvin/tests/smoke/test_routers.py
   Intermitten failure detected: /marvin/tests/smoke/test_scale_vm.py
   Intermitten failure detected: /marvin/tests/smoke/test_secondary_storage.py
   Intermitten failure detected: /marvin/tests/smoke/test_service_offerings.py
   Intermitten failure detected: /marvin/tests/smoke/test_snapshots.py
   Intermitten failure detected: /marvin/tests/smoke/test_ssvm.py
   Intermitten failure detected: /marvin/tests/smoke/test_templates.py
   Intermitten failure detected: /marvin/tests/smoke/test_usage.py
   Intermitten failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
   Intermitten failure detected: /marvin/tests/smoke/test_vm_snapshots.py
   Intermitten failure detected: /marvin/tests/smoke/test_volumes.py
   Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Intermitten failure detected: /marvin/tests/smoke/test_vpc_router_nics.py
   Intermitten failure detected: /marvin/tests/smoke/test_vpc_vpn.py
   Intermitten failure detected: /marvin/tests/smoke/test_host_maintenance.py
   Smoke tests completed. 46 look OK, 21 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   ContextSuite context=TestResetVmOnReboot>:setup | `Error` | 0.00 | 
test_reset_vm_on_reboot.py
   ContextSuite context=TestRouterDHCPHosts>:setup | `Error` | 0.00 | 
test_router_dhcphosts.py
   ContextSuite context=TestRouterDHCPOpts>:setup | `Error` | 0.00 | 
test_router_dhcphosts.py
   ContextSuite context=TestChangeServiceOfferingForVmWithSnapshots>:setup | 
`Error` | 0.00 | test_vm_snapshots.py
   ContextSuite context=TestVmSnapshot>:setup | `Error` | 0.00 | 
test_vm_snapshots.py
   ContextSuite context=TestRouterDns>:setup | `Error` | 0.00 | 
test_router_dns.py
   ContextSuite context=TestRouterDnsService>:setup | `Error` | 0.00 | 
test_router_dnsservice.py
   ContextSuite context=TestRouterIpTablesPolicies>:setup | `Error` | 0.00 | 
test_routers_iptables_default_policy.py
   ContextSuite context=TestVPCIpTablesPolicies>:setup | `Error` | 0.00 | 
test_routers_iptables_default_policy.py
   test_01_isolate_network_FW_PF_default_routes_egress_true | `Error` | 0.15 | 
test_routers_network_ops.py
   test_02_isolate_network_FW_PF_default_routes_egress_false | `Error` | 0.14 | 
test_routers_network_ops.py
   ContextSuite context=TestRedundantIsolateNetworks>:setup | `Error` | 1.29 | 
test_routers_network_ops.py
   ContextSuite context=TestRouterServices>:setup | `Error` | 0.00 | 
test_routers.py
   ContextSuite context=TestScaleVm>:setup | `Error` | 0.00 | test_scale_vm.py
   test_01_sys_vm_start | `Failure` | 0.12 | test_secondary_storage.py
   test_02_sys_template_ready | `Failure` | 0.08 | test_secondary_storage.py
   ContextSuite context=TestCpuCapServiceOfferings>:teardown | `Error` | 0.00 | 
test_service_offerings.py
   ContextSuite context=TestServiceOfferings>:setup | `Error` | 0.16 | 
test_service_offerings.py
   ContextSuite context=TestSnapshotRootDisk>:setup | `Error` | 0.00 | 
test_snapshots.py
   test_01_list_sec_storage_vm | `Failure` | 0.03 | test_ssvm.py
   test_02_list_cpvm_vm | `Failure` | 0.03 | test_ssvm.py
   test_03_ssvm_internals | `Failure` | 0.03 | test_ssvm.py
   test_04_cpvm_internals | `Failure` | 0.03 | test_ssvm.py
   test_05_stop_ssvm | `Failure` | 0.03 | test_ssvm.py
   test_06_stop_cpvm | `Failure` | 0.03 | test_ssvm.py
   test_07_reboot_ssvm | `Failure` | 0.03 | test_ssvm.py
   test_08_reboot_cpvm | `Failure` | 0.03 | test_ssvm.py
   test_09_destroy_ssvm | `Failure` | 0.03 | test_ssvm.py
   test_10_destroy_cpvm | `Failure` | 0.03 | test_ssvm.py
   test_02_create_template_with_checksum_sha1 | `Error` | 65.42 | 
test_templates.py
   test_03_create_template_with_checksum_sha256 | `Error` | 65.41 | 
test_templates.py
   

[GitHub] falcon78921 commented on issue #2546: Libvirt-bin has trouble starting if -d is stated in /etc/default/libvirt-bin (libvirtd_opts)

[GitBox]

falcon78921 commented on issue #2546: Libvirt-bin has trouble starting if -d is 
stated in /etc/default/libvirt-bin (libvirtd_opts)
URL: https://github.com/apache/cloudstack/issues/2546#issuecomment-380298190
 
 
   Thanks @rhtyd I'm happy to help! :)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rafaelweingartner commented on issue #2560: ui: Make zonal dashboard larger

[GitBox]

rafaelweingartner commented on issue #2560: ui: Make zonal dashboard larger
URL: https://github.com/apache/cloudstack/pull/2560#issuecomment-380292815
 
 
   I merged this PR. However, there is a problem now to merge forward. 
@DaanHoogland how are you managing the merge forward of that PR that created 
the upgrade from 4.10 to 4.11? I think to merge things forward now, we need 
first to merge your PR in master.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rafaelweingartner closed pull request #2560: ui: Make zonal dashboard larger

[GitBox]

rafaelweingartner closed pull request #2560: ui: Make zonal dashboard larger
URL: https://github.com/apache/cloudstack/pull/2560
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/ui/css/cloudstack3.css b/ui/css/cloudstack3.css
index 519778ba59b..e7d4a0cfe41 100644
--- a/ui/css/cloudstack3.css
+++ b/ui/css/cloudstack3.css
@@ -4451,7 +4451,7 @@ textarea {
 / Head*/
 .dashboard.admin .dashboard-container.head {
   width: 966px;
-  height: 331px;
+  height: 431px;
   margin: 9px 0 0;
   float: left;
 }
@@ -4511,7 +4511,7 @@ textarea {
 / Charts / stats*/
 .dashboard.admin .zone-stats {
   width: 974px;
-  height: 316px;
+  height: 416px;
   overflow: auto;
   overflow-x: hidden;
   /*+placement:shift 0px 0px;*/
@@ -4710,7 +4710,7 @@ textarea {
 .dashboard.admin .dashboard-container.sub.alerts {
   float: left;
   margin: 0 12px 0 0;
-  height: 270px;
+  height: 170px;
   overflow: hidden;
   position: relative;
 }


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[cloudstack] branch 4.11 updated: ui: Make zonal dashboard larger (#2560)

[rafael]

This is an automated email from the ASF dual-hosted git repository.

rafael pushed a commit to branch 4.11
in repository https://gitbox.apache.org/repos/asf/cloudstack.git


The following commit(s) were added to refs/heads/4.11 by this push:
 new d588f7d  ui: Make zonal dashboard larger (#2560)
d588f7d is described below

commit d588f7d92bf2b2d46bb991303bfbb8d49881874a
Author: Rohit Yadav 
AuthorDate: Wed Apr 11 06:23:02 2018 +0530

ui: Make zonal dashboard larger (#2560)

The host/alert dashboard panels are on the top side, the dashboard
statistics page gets less room. This increases the panel by 100px for
zone dashboard and decreases the host/alert panels by 100px.

Signed-off-by: Rohit Yadav 
---
 ui/css/cloudstack3.css | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/ui/css/cloudstack3.css b/ui/css/cloudstack3.css
index 519778b..e7d4a0c 100644
--- a/ui/css/cloudstack3.css
+++ b/ui/css/cloudstack3.css
@@ -4451,7 +4451,7 @@ textarea {
 / Head*/
 .dashboard.admin .dashboard-container.head {
   width: 966px;
-  height: 331px;
+  height: 431px;
   margin: 9px 0 0;
   float: left;
 }
@@ -4511,7 +4511,7 @@ textarea {
 / Charts / stats*/
 .dashboard.admin .zone-stats {
   width: 974px;
-  height: 316px;
+  height: 416px;
   overflow: auto;
   overflow-x: hidden;
   /*+placement:shift 0px 0px;*/
@@ -4710,7 +4710,7 @@ textarea {
 .dashboard.admin .dashboard-container.sub.alerts {
   float: left;
   margin: 0 12px 0 0;
-  height: 270px;
+  height: 170px;
   overflow: hidden;
   position: relative;
 }

-- 
To stop receiving notification emails like this one, please contact
raf...@apache.org.

[cloudstack-cloudmonkey] 02/02: cloudmonkey: initial Go port (cmk)

[rohit]

This is an automated email from the ASF dual-hosted git repository.

rohit pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack-cloudmonkey.git

commit a6fb80da71d30ea5fefb735bcff34290066a534c
Author: Rohit Yadav 
AuthorDate: Wed Apr 11 04:06:56 2018 +0530

cloudmonkey: initial Go port (cmk)

- Basic command handling and shell
- API verb, resource autocompletion
- PoC API arg autocompletion with interactive selector

Signed-off-by: Rohit Yadav 
---
 .gitignore   |  23 
 CHANGES.md   |   7 +++
 Makefile |  55 +++
 NOTICE   |   2 +-
 README.md| 102 --
 cli/completer.go | 165 +++
 cli/exec.go  |  38 +
 cli/selector.go  |  90 ++
 cli/shell.go |  87 +
 cmd/api.go   |  64 +
 cmd/command.go   |  64 +
 cmd/exit.go  |  42 ++
 cmd/help.go  |  37 +
 cmd/login.go |  74 +
 cmd/network.go   | 106 +++
 cmd/request.go   |  39 +
 cmd/set.go   |  45 +++
 cmd/shell.go |  44 +++
 cmd/sync.go  |  39 +
 cmd/version.go   |  31 +++
 cmk.go   |  35 
 config/cache.go  | 117 +++
 config/config.go | 100 +
 config/util.go   |  67 ++
 24 files changed, 1404 insertions(+), 69 deletions(-)

diff --git a/.gitignore b/.gitignore
new file mode 100644
index 000..bdce524
--- /dev/null
+++ b/.gitignore
@@ -0,0 +1,23 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+cmk
+dist
+*.exe
+*.test
+*.out
+.idea
diff --git a/CHANGES.md b/CHANGES.md
index 013d837..761a768 100644
--- a/CHANGES.md
+++ b/CHANGES.md
@@ -1,6 +1,13 @@
 Apache CloudStack CloudMonkey Changelog
 ---
 
+Version 6.0.0 (alpha, in progress)
+=
+This release includes
+- Rewrite cloudmonkey in golang
+- Interactive parameter completion
+- Simplification of configuration
+
 Version 5.3.3
 =
 This release includes
diff --git a/Makefile b/Makefile
new file mode 100644
index 000..fda6cce
--- /dev/null
+++ b/Makefile
@@ -0,0 +1,55 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+build:
+   go build -ldflags='-s -w' -o cmk cmk.go
+
+run:
+   go run cmk.go
+
+test:
+   go test
+
+install: build
+   @echo Copied to ~/bin
+   @cp cmk ~/bin
+
+debug:
+   go build -gcflags='-N -l' -o cmk cmk.go &&  dlv --listen=:2345 
--headless=true --api-version=2 exec ./cmk
+
+dist:
+   rm -fr dist
+   mkdir -p dist
+   GOOS=linux   GOARCH=amd64 go build -ldflags='-s -w' -o 
dist/cmk-linux-amd64 cmk.go
+   GOOS=linux   GOARCH=386   go build -ldflags='-s -w' -o 
dist/cmk-linux-i386 cmk.go
+   GOOS=linux   GOARCH=arm64 go build -ldflags='-s -w' -o 
dist/cmk-linux-arm64 cmk.go
+   GOOS=linux   GOARCH=arm   go build -ldflags='-s -w' -o 
dist/cmk-linux-arm cmk.go
+   GOOS=windows GOARCH=amd64 go build -ldflags='-s -w' -o dist/cmk-x64.exe 
cmk.go
+   GOOS=windows GOARCH=386   go build -ldflags='-s -w' -o dist/cmk-x32.exe 
cmk.go
+   GOOS=darwin  GOARCH=amd64 go build -ldflags='-s 

[cloudstack-cloudmonkey] 01/02: cloudmonkey: purge legacy files

[rohit]

This is an automated email from the ASF dual-hosted git repository.

rohit pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack-cloudmonkey.git

commit 7b55fb417ac6788b009c1caf040f2a9dbb6e0031
Author: Rohit Yadav 
AuthorDate: Wed Apr 11 04:02:40 2018 +0530

cloudmonkey: purge legacy files

Signed-off-by: Rohit Yadav 
---
 .gitignore  |  28 --
 Dockerfile  |  36 --
 Makefile|  41 --
 cloudmonkey/__init__.py |  23 --
 cloudmonkey/cachemaker.py   | 182 -
 cloudmonkey/cloudmonkey.py  | 937 
 cloudmonkey/config.py   | 209 --
 cloudmonkey/precache.py |  19 -
 cloudmonkey/printer.py  | 124 --
 cloudmonkey/requester.py| 335 
 config.docker   |  25 --
 docs/.gitignore |   1 -
 docs/Makefile   | 177 -
 docs/source/cloudmonkey.rst |  62 ---
 docs/source/conf.py | 262 -
 docs/source/index.rst   |  37 --
 docs/source/modules.rst |   7 -
 setup.cfg   |   7 -
 setup.py|  86 
 19 files changed, 2598 deletions(-)

diff --git a/.gitignore b/.gitignore
deleted file mode 100644
index 63c8cd1..000
--- a/.gitignore
+++ /dev/null
@@ -1,28 +0,0 @@
-# Licensed to the Apache Software Foundation (ASF) under one
-# or more contributor license agreements.  See the NOTICE file
-# distributed with this work for additional information
-# regarding copyright ownership.  The ASF licenses this file
-# to you under the Apache License, Version 2.0 (the
-# "License"); you may not use this file except in compliance
-# with the License.  You may obtain a copy of the License at
-#
-#   http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing,
-# software distributed under the License is distributed on an
-# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
-# KIND, either express or implied.  See the License for the
-# specific language governing permissions and limitations
-# under the License.
-
-dist/
-*~
-*.log
-*.pyc
-*.egginfo/
-*.egg-info/
-.DS_Store
-*.swp
-build/
-.*
-!.gitignore
diff --git a/Dockerfile b/Dockerfile
deleted file mode 100644
index 696974d..000
--- a/Dockerfile
+++ /dev/null
@@ -1,36 +0,0 @@
-# Licensed to the Apache Software Foundation (ASF) under one
-# or more contributor license agreements.  See the NOTICE file
-# distributed with this work for additional information
-# regarding copyright ownership.  The ASF licenses this file
-# to you under the Apache License, Version 2.0 (the
-# "License"); you may not use this file except in compliance
-# with the License.  You may obtain a copy of the License at
-# 
-#   http://www.apache.org/licenses/LICENSE-2.0
-# 
-# Unless required by applicable law or agreed to in writing,
-# software distributed under the License is distributed on an
-# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
-# KIND, either express or implied.  See the License for the
-# specific language governing permissions and limitations
-# under the License.
-#
-#
-FROM python:2
-
-MAINTAINER "Apache CloudStack" 
-LABEL Description="Apache CloudStack CloudMonkey; Python based CloudStack 
command line interface"
-LABEL Vendor="Apache.org"
-LABEL License=ApacheV2
-LABEL Version=5.3.3
-
-COPY . /cloudstack-cloudmonkey
-RUN pip install requests
-RUN (cd /cloudstack-cloudmonkey; python setup.py build)
-RUN (cd /cloudstack-cloudmonkey; python setup.py install)
-
-RUN mkdir -p /cloudmonkey
-WORKDIR /cloudmonkey
-COPY config.docker /cloudmonkey/config
-
-ENTRYPOINT ["cloudmonkey", "-c", "/cloudmonkey/config"]
\ No newline at end of file
diff --git a/Makefile b/Makefile
deleted file mode 100644
index 182cbce..000
--- a/Makefile
+++ /dev/null
@@ -1,41 +0,0 @@
-# Licensed to the Apache Software Foundation (ASF) under one
-# or more contributor license agreements.  See the NOTICE file
-# distributed with this work for additional information
-# regarding copyright ownership.  The ASF licenses this file
-# to you under the Apache License, Version 2.0 (the
-# "License"); you may not use this file except in compliance
-# with the License.  You may obtain a copy of the License at
-#
-#   http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing,
-# software distributed under the License is distributed on an
-# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
-# KIND, either express or implied.  See the License for the
-# specific language governing permissions and limitations
-# under the License.
-
-all: clean buildwithcache
-
-runtests:
-   nosetests -v --verbosity=3
-
-buildwithcache: buildcache build
-
-build:
-   python setup.py build
-   python setup.py sdist
-
-check:
-   pep8 cloudmonkey/*.py
-

[cloudstack-cloudmonkey] branch master updated (721cc26 -> a6fb80d)

[rohit]

This is an automated email from the ASF dual-hosted git repository.

rohit pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack-cloudmonkey.git.


from 721cc26  cloudmonkey: update precache against latest CloudStack master
 new 7b55fb4  cloudmonkey: purge legacy files
 new a6fb80d  cloudmonkey: initial Go port (cmk)

The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 .gitignore  |  17 +-
 CHANGES.md  |   7 +
 Dockerfile  |  36 --
 Makefile|  48 ++-
 NOTICE  |   2 +-
 README.md   | 102 ++---
 cli/completer.go| 165 
 cli/exec.go |  38 ++
 cli/selector.go |  90 +
 cli/shell.go|  87 
 cloudmonkey/__init__.py |  23 --
 cloudmonkey/cachemaker.py   | 182 -
 cloudmonkey/cloudmonkey.py  | 937 
 cloudmonkey/config.py   | 209 --
 cloudmonkey/precache.py |  19 -
 cloudmonkey/printer.py  | 124 --
 cloudmonkey/requester.py| 335 
 cmd/api.go  |  64 +++
 cmd/command.go  |  64 +++
 cmd/exit.go |  42 ++
 cmd/help.go |  37 ++
 cmd/login.go|  74 
 cmd/network.go  | 106 +
 cmd/request.go  |  39 ++
 cmd/set.go  |  45 +++
 cmd/shell.go|  44 +++
 cmd/sync.go |  39 ++
 cmd/version.go  |  31 ++
 cmk.go  |  35 ++
 config.docker   |  25 --
 config/cache.go | 117 ++
 config/config.go| 100 +
 config/util.go  |  67 
 docs/.gitignore |   1 -
 docs/Makefile   | 177 -
 docs/source/cloudmonkey.rst |  62 ---
 docs/source/conf.py | 262 -
 docs/source/index.rst   |  37 --
 docs/source/modules.rst |   7 -
 setup.cfg   |   7 -
 setup.py|  86 
 41 files changed, 1363 insertions(+), 2626 deletions(-)
 delete mode 100644 Dockerfile
 create mode 100644 cli/completer.go
 create mode 100644 cli/exec.go
 create mode 100644 cli/selector.go
 create mode 100644 cli/shell.go
 delete mode 100644 cloudmonkey/__init__.py
 delete mode 100644 cloudmonkey/cachemaker.py
 delete mode 100644 cloudmonkey/cloudmonkey.py
 delete mode 100644 cloudmonkey/config.py
 delete mode 100644 cloudmonkey/precache.py
 delete mode 100644 cloudmonkey/printer.py
 delete mode 100644 cloudmonkey/requester.py
 create mode 100644 cmd/api.go
 create mode 100644 cmd/command.go
 create mode 100644 cmd/exit.go
 create mode 100644 cmd/help.go
 create mode 100644 cmd/login.go
 create mode 100644 cmd/network.go
 create mode 100644 cmd/request.go
 create mode 100644 cmd/set.go
 create mode 100644 cmd/shell.go
 create mode 100644 cmd/sync.go
 create mode 100644 cmd/version.go
 create mode 100644 cmk.go
 delete mode 100644 config.docker
 create mode 100644 config/cache.go
 create mode 100644 config/config.go
 create mode 100644 config/util.go
 delete mode 100644 docs/.gitignore
 delete mode 100644 docs/Makefile
 delete mode 100644 docs/source/cloudmonkey.rst
 delete mode 100644 docs/source/conf.py
 delete mode 100644 docs/source/index.rst
 delete mode 100644 docs/source/modules.rst
 delete mode 100644 setup.cfg
 delete mode 100644 setup.py

-- 
To stop receiving notification emails like this one, please contact
ro...@apache.org.

[GitHub] mike-tutkowski commented on issue #2499: Updates to capacity management

[GitBox]

mike-tutkowski commented on issue #2499: Updates to capacity management
URL: https://github.com/apache/cloudstack/pull/2499#issuecomment-380260288
 
 
   These test failures do not seem to be related to this PR. Here are some 
examples of the errors:
   
   **test_primary_storage.py:**
   errorText:Primary storage with id 5 cannot be disabled.
   errorText:Failed to add data store: Storage pool 
nfs://10.2.0.16/acs/primary/pr2499-t2470-kvm-centos7/marvin_pri1 already in use 
by another pod (id=1)\n']
   
   **test_snapshots.py:**
   errorText:Failed to add data store: Storage pool 
nfs://10.2.0.16/acs/primary/pr2499-t2470-kvm-centos7/nfs2 already in use by 
another pod (id=1)\n']
   
   **test_vm_life_cycle.py:**
   errortext : u'Cannot migrate VM, destination host is not in correct state, 
has status: Up, state: Disabled'}, accountid : 
u'be964da7-397f-11e8-a179-06965801071a'}\n"]


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[cloudstack-cloudmonkey.wiki] branch master updated: Updated Usage (markdown)

[rohit]

This is an automated email from the ASF dual-hosted git repository.

rohit pushed a commit to branch master
in repository 
https://gitbox.apache.org/repos/asf/cloudstack-cloudmonkey.wiki.git


The following commit(s) were added to refs/heads/master by this push:
 new b30234d  Updated Usage (markdown)
b30234d is described below

commit b30234dc0c4f696e50156ab5130fa0c9bdf351ab
Author: Rohit Yadav 
AuthorDate: Wed Apr 11 01:54:34 2018 +0530

Updated Usage (markdown)
---
 Usage.md | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/Usage.md b/Usage.md
index 3e0f590..6d99c50 100644
--- a/Usage.md
+++ b/Usage.md
@@ -1 +1,3 @@
-For legacy cloudmonkey (Python based) until version 5.3.3, please refer the 
[old cwiki 
doc](https://cwiki.apache.org/confluence/display/CLOUDSTACK/CloudStack+cloudmonkey+CLI)
 for usage.
\ No newline at end of file
+For legacy cloudmonkey (Python based) until version 5.3.3, please refer the 
[old cwiki 
doc](https://cwiki.apache.org/confluence/display/CLOUDSTACK/CloudStack+cloudmonkey+CLI)
 for usage.
+
+This page is under progress, the usage will be more or less same as the legacy 
cloudmonkey (python based).
\ No newline at end of file

-- 
To stop receiving notification emails like this one, please contact
ro...@apache.org.

[cloudstack-cloudmonkey.wiki] branch master updated: wiki: modern cloudmonkey usage

[rohit]

This is an automated email from the ASF dual-hosted git repository.

rohit pushed a commit to branch master
in repository 
https://gitbox.apache.org/repos/asf/cloudstack-cloudmonkey.wiki.git


The following commit(s) were added to refs/heads/master by this push:
 new 3915159  wiki: modern cloudmonkey usage
3915159 is described below

commit 391515931bc1520f507cde2a40c0c75db3f9d632
Author: Rohit Yadav 
AuthorDate: Wed Apr 11 01:47:58 2018 +0530

wiki: modern cloudmonkey usage
---
 Usage.md | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Usage.md b/Usage.md
new file mode 100644
index 000..3e0f590
--- /dev/null
+++ b/Usage.md
@@ -0,0 +1 @@
+For legacy cloudmonkey (Python based) until version 5.3.3, please refer the 
[old cwiki 
doc](https://cwiki.apache.org/confluence/display/CLOUDSTACK/CloudStack+cloudmonkey+CLI)
 for usage.
\ No newline at end of file

-- 
To stop receiving notification emails like this one, please contact
ro...@apache.org.

[cloudstack-cloudmonkey] branch 5.3 created (now 721cc26)

[rohit]

This is an automated email from the ASF dual-hosted git repository.

rohit pushed a change to branch 5.3
in repository https://gitbox.apache.org/repos/asf/cloudstack-cloudmonkey.git.


  at 721cc26  cloudmonkey: update precache against latest CloudStack master

No new revisions were added by this update.

-- 
To stop receiving notification emails like this one, please contact
ro...@apache.org.

[cloudstack-cloudmonkey] branch documentation deleted (was a987b90)

[rohit]

This is an automated email from the ASF dual-hosted git repository.

rohit pushed a change to branch documentation
in repository https://gitbox.apache.org/repos/asf/cloudstack-cloudmonkey.git.


 was a987b90  Updating docs config

The revisions that were on this branch are still contained in
other references; therefore, this change does not discard any commits
from the repository.

-- 
To stop receiving notification emails like this one, please contact
ro...@apache.org.

[cloudstack-cloudmonkey] branch 5.1.0 deleted (was 0b7a6bc)

[rohit]

This is an automated email from the ASF dual-hosted git repository.

rohit pushed a change to branch 5.1.0
in repository https://gitbox.apache.org/repos/asf/cloudstack-cloudmonkey.git.


 was 0b7a6bc  Prepare for 5.1.0 release

The revisions that were on this branch are still contained in
other references; therefore, this change does not discard any commits
from the repository.

-- 
To stop receiving notification emails like this one, please contact
ro...@apache.org.

[cloudstack-cloudmonkey] annotated tag 5.2.0 updated (29695f9 -> 9d9183f)

[rohit]

This is an automated email from the ASF dual-hosted git repository.

rohit pushed a change to annotated tag 5.2.0
in repository https://gitbox.apache.org/repos/asf/cloudstack-cloudmonkey.git.


*** WARNING: tag 5.2.0 was modified! ***

from 29695f9  (commit)
  to 9d9183f  (tag)
 tagging 29695f97494b1046b77d483af2a5f064c168823c (commit)
 replaces 5.0.0
  by Rohit Yadav
  on Tue Aug 26 01:29:00 2014 +0200

- Log -
Tagging release 5.2.0 on branch 5.2.
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.15 (Darwin)

iQIcBAABAgAGBQJT+8a8AAoJEEhCSCEO49iEfcsP/3VR3VniWr1MRm/wf05JS+c+
EjjcmpLGhrf72Mw4neAl456K9i3JNfvstrqWQJoILPGYGt1/+A9o88WIfqtCo2yA
eooR/hHv1CMaj2HjqAbILwj9ZUB/rFhry3SF2KtaRLSm0ITxZx3gArPGoS6ta6/w
f1/PPirw6IO887345xmw6uMFKi+MyXMbZFheJzWrjnwL49Fv0jj7iM2bZ0G9pVu9
V14/+N+TZD1NpbCBDDIAyurS/gIaK21S4KuQeHBUzT8DUkgtFnZBvfVnH72L/jSI
HwkyLQRSNY8e2iXa8lo5WbNy+WQuL+ljcDlzSaccTTHAY2Q8Zw0lrxPrLhQtYAb3
9kgNKV2FT80HzdfkTdclQ6LQmImyuRrg8S+rADYJsnu4Ln3ku8i79KO9msAvaxXV
RVCrltGVyEM7DDXY0pKsfAAKrDqQTm/hP1AVGFD52blGk5esu+aVGkDGvJkYR3UX
vtgC6PROJYCNmyOAYNPMKmHt13G3IBuagBsU8IZWnL0GI2tGILwzY7GQAlsEJQgB
YNJrCYhHGHNHSQfUg9XGpO4BEAn5i1ap8Kq9Bkf1K/R8zfICmOLqbbM8Xfsm6QuK
8ihT2BnPGTaQVzn3KhFRUFyZTz/bmGwA6DEgHU2VHVf8wNKO4O++VKG4ncYmxBV8
SrrYk8eqNOPiBGDrW6Du
=vT2P
-END PGP SIGNATURE-
---


No new revisions were added by this update.

Summary of changes:

-- 
To stop receiving notification emails like this one, please contact
ro...@apache.org.

[cloudstack-cloudmonkey] branch 5.0 deleted (was ce79f6e)

[rohit]

This is an automated email from the ASF dual-hosted git repository.

rohit pushed a change to branch 5.0
in repository https://gitbox.apache.org/repos/asf/cloudstack-cloudmonkey.git.


 was ce79f6e  Bumping version to 5.0.1

This change permanently discards the following revisions:

 discard ce79f6e  Bumping version to 5.0.1

-- 
To stop receiving notification emails like this one, please contact
ro...@apache.org.

[cloudstack-cloudmonkey] branch 5.2 deleted (was 29695f9)

[rohit]

This is an automated email from the ASF dual-hosted git repository.

rohit pushed a change to branch 5.2
in repository https://gitbox.apache.org/repos/asf/cloudstack-cloudmonkey.git.


 was 29695f9  CHANGES: update change file for release 5.2.0

The revisions that were on this branch are still contained in
other references; therefore, this change does not discard any commits
from the repository.

-- 
To stop receiving notification emails like this one, please contact
ro...@apache.org.

[cloudstack-cloudmonkey] annotated tag 5.2.0 deleted (was 9d9183f)

[rohit]

This is an automated email from the ASF dual-hosted git repository.

rohit pushed a change to annotated tag 5.2.0
in repository https://gitbox.apache.org/repos/asf/cloudstack-cloudmonkey.git.


*** WARNING: tag 5.2.0 was deleted! ***

   tag was  9d9183f

The revisions that were on this annotated tag are still contained in
other references; therefore, this change does not discard any commits
from the repository.

-- 
To stop receiving notification emails like this one, please contact
ro...@apache.org.

[GitHub] nitin-maharana commented on a change in pull request #2486: [CLOUDSTACK-10323] Allow changing disk offering during volume migration

[GitBox]

nitin-maharana commented on a change in pull request #2486: [CLOUDSTACK-10323] 
Allow changing disk offering during volume migration 
URL: https://github.com/apache/cloudstack/pull/2486#discussion_r175389327
 
 

 ##
 File path: server/src/main/java/com/cloud/storage/VolumeApiServiceImpl.java
 ##
 @@ -2097,26 +2079,102 @@ public Volume migrateVolume(MigrateVolumeCmd cmd) {
 }
 }
 
-return orchestrateMigrateVolume(vol.getId(), destPool.getId(), 
liveMigrateVolume);
+return orchestrateMigrateVolume(vol, destPool, liveMigrateVolume, 
newDiskOffering);
 }
 
-private Volume orchestrateMigrateVolume(long volumeId, long destPoolId, 
boolean liveMigrateVolume) {
-VolumeVO vol = _volsDao.findById(volumeId);
-assert (vol != null);
-StoragePool destPool = 
(StoragePool)dataStoreMgr.getDataStore(destPoolId, DataStoreRole.Primary);
-assert (destPool != null);
+/**
+ * Retrieve the new disk offering UUID that might be sent to replace the 
current one in the volume being migrated.
+ * If no disk offering UUID is provided we return null. Otherwise, we 
perform the following checks.
+ * 
+ *  Is the disk offering UUID entered valid? If not, an  {@link 
InvalidParameterValueException} is thrown;
+ *  If the disk offering was already removed, we thrown an {@link 
InvalidParameterValueException} is thrown;
+ *  We then check if the user executing the operation has access to 
the given disk offering.
+ * 
+ *
+ * If all checks pass, we move forward returning the disk offering object.
+ */
+private DiskOfferingVO retrieveAndValidateNewDiskOffering(MigrateVolumeCmd 
cmd) {
+String newDiskOfferingUuid = cmd.getNewDiskOfferingUuid();
+if (org.apache.commons.lang.StringUtils.isBlank(newDiskOfferingUuid)) {
+return null;
+}
+DiskOfferingVO newDiskOffering = 
_diskOfferingDao.findByUuid(newDiskOfferingUuid);
+if (newDiskOffering == null) {
+throw new InvalidParameterValueException(String.format("The disk 
offering informed is not valid [id=%s].", newDiskOfferingUuid));
+}
+if (newDiskOffering.getRemoved() != null) {
+throw new InvalidParameterValueException(String.format("We cannot 
assign a removed disk offering [id=%s] to a volume. ", 
newDiskOffering.getUuid()));
+}
+Account caller = CallContext.current().getCallingAccount();
+_accountMgr.checkAccess(caller, newDiskOffering);
+return newDiskOffering;
+}
+
+/**
+ * Performs the validations required for replacing the disk offering while 
migrating the volume of storage. If no new disk offering is provided, we do not 
execute any validation.
+ * If a disk offering is informed, we then proceed with the following 
checks.
+ * 
 
 Review comment:
   Same here.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] eligorio commented on issue #2548: Upgrade to 4.11 and pre-existent saml2 authentication settings

[GitBox]

eligorio commented on issue #2548: Upgrade to 4.11 and pre-existent saml2 
authentication settings
URL: https://github.com/apache/cloudstack/issues/2548#issuecomment-379907315
 
 
   We reproduced the issue using the recipe of your last comment.
   
   ![screen shot 2018-04-10 at 14 24 
48](https://user-images.githubusercontent.com/14877312/38576028-522dde16-3cd3-11e8-942b-96758dc132a5.png)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] nitin-maharana commented on a change in pull request #2560: ui: Make zonal dashboard larger

[GitBox]

nitin-maharana commented on a change in pull request #2560: ui: Make zonal 
dashboard larger
URL: https://github.com/apache/cloudstack/pull/2560#discussion_r180507118
 
 

 ##
 File path: ui/css/cloudstack3.css
 ##
 @@ -4451,7 +4451,7 @@ textarea {
 / Head*/
 .dashboard.admin .dashboard-container.head {
   width: 966px;
-  height: 331px;
+  height: 431px;
 
 Review comment:
   LGTM.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] nitin-maharana commented on a change in pull request #2560: ui: Make zonal dashboard larger

[GitBox]

nitin-maharana commented on a change in pull request #2560: ui: Make zonal 
dashboard larger
URL: https://github.com/apache/cloudstack/pull/2560#discussion_r180507118
 
 

 ##
 File path: ui/css/cloudstack3.css
 ##
 @@ -4451,7 +4451,7 @@ textarea {
 / Head*/
 .dashboard.admin .dashboard-container.head {
   width: 966px;
-  height: 331px;
+  height: 431px;
 
 Review comment:
   LGTM.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] nitin-maharana commented on a change in pull request #2559: Upgrade path 4.11 through 4.11.1 to 4.12

[GitBox]

nitin-maharana commented on a change in pull request #2559: Upgrade path 4.11 
through 4.11.1 to 4.12
URL: https://github.com/apache/cloudstack/pull/2559#discussion_r180502246
 
 

 ##
 File path: 
engine/schema/src/test/java/com/cloud/upgrade/DatabaseUpgradeCheckerTest.java
 ##
 @@ -74,6 +75,28 @@ public void testCalculateUpgradePath490to4910() {
 
 }
 
+@Test
 
 Review comment:
   Would be great if you add similar one from 4.11.1 to 4.12.0 as well.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] nitin-maharana commented on a change in pull request #2559: Upgrade path 4.11 through 4.11.1 to 4.12

[GitBox]

nitin-maharana commented on a change in pull request #2559: Upgrade path 4.11 
through 4.11.1 to 4.12
URL: https://github.com/apache/cloudstack/pull/2559#discussion_r180500452
 
 

 ##
 File path: 
engine/schema/src/main/resources/META-INF/db/schema-41100to41110-cleanup.sql
 ##
 @@ -16,5 +16,5 @@
 -- under the License.
 
 --;
--- Schema upgrade cleanup from 4.11.0.0 to 4.12.0.0
+-- Schema upgrade from 4.11.0.0 to 4.11.1.0
 
 Review comment:
   @DaanHoogland, Thanks for the PR. I think it would be more meaningful if we 
add the word "cleanup" here.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2390: [CLOUDSTACK-10214] Unable to remove local primary storage

[GitBox]

blueorangutan commented on issue #2390: [CLOUDSTACK-10214] Unable to remove 
local primary storage
URL: https://github.com/apache/cloudstack/pull/2390#issuecomment-380153586
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1898


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rafaelweingartner commented on issue #2511: [CLOUDSTACK-10344] bug when moving ACL rules (change order with drag and drop)

[GitBox]

rafaelweingartner commented on issue #2511: [CLOUDSTACK-10344] bug when moving 
ACL rules (change order with drag and drop)
URL: https://github.com/apache/cloudstack/pull/2511#issuecomment-380148227
 
 
   @nitin-maharana do you approve this PR?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rafaelweingartner commented on issue #2511: [CLOUDSTACK-10344] bug when moving ACL rules (change order with drag and drop)

[GitBox]

rafaelweingartner commented on issue #2511: [CLOUDSTACK-10344] bug when moving 
ACL rules (change order with drag and drop)
URL: https://github.com/apache/cloudstack/pull/2511#issuecomment-380148227
 
 
   @nitin-maharana did you approve this PR?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2390: [CLOUDSTACK-10214] Unable to remove local primary storage

[GitBox]

blueorangutan commented on issue #2390: [CLOUDSTACK-10214] Unable to remove 
local primary storage
URL: https://github.com/apache/cloudstack/pull/2390#issuecomment-380144503
 
 
   @rafaelweingartner a Jenkins job has been kicked to build packages. I'll 
keep you posted as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rafaelweingartner commented on issue #2390: [CLOUDSTACK-10214] Unable to remove local primary storage

[GitBox]

rafaelweingartner commented on issue #2390: [CLOUDSTACK-10214] Unable to remove 
local primary storage
URL: https://github.com/apache/cloudstack/pull/2390#issuecomment-380144240
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2550: debian: Use only `-l` for libvirtd default file on debian

[GitBox]

blueorangutan commented on issue #2550: debian: Use only `-l` for libvirtd 
default file on debian
URL: https://github.com/apache/cloudstack/pull/2550#issuecomment-380085295
 
 
   Packaging result: ✔centos6 ✖centos7 ✔debian. JID-1897


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2560: ui: Make zonal dashboard larger

[GitBox]

blueorangutan commented on issue #2560: ui: Make zonal dashboard larger
URL: https://github.com/apache/cloudstack/pull/2560#issuecomment-380085237
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1896


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rafaelweingartner commented on issue #2560: ui: Make zonal dashboard larger

[GitBox]

rafaelweingartner commented on issue #2560: ui: Make zonal dashboard larger
URL: https://github.com/apache/cloudstack/pull/2560#issuecomment-380083388
 
 
   I have seen this in some websites lately. Sometimes I find it great, because 
it can give a pretty good idea of the software; however, sometimes I also find 
it is useless...
   
   I guess it depends on what we want to show, and how we show it.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rafaelweingartner commented on issue #2560: ui: Make zonal dashboard larger

[GitBox]

rafaelweingartner commented on issue #2560: ui: Make zonal dashboard larger
URL: https://github.com/apache/cloudstack/pull/2560#issuecomment-380083388
 
 
   I have seen this in different websites lately. Sometimes I find it great, 
because it can give a pretty good idea of the software; however, sometimes I 
also find it is useless...
   
   I guess it depends on what we want to show, and how we show it.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2560: ui: Make zonal dashboard larger

[GitBox]

rhtyd commented on issue #2560: ui: Make zonal dashboard larger
URL: https://github.com/apache/cloudstack/pull/2560#issuecomment-380081139
 
 
   Thanks @rafaelweingartner @DaanHoogland. Just another unrelated thought - 
would it be nice to show cloudstack screenshots showing various views in action 
 on our website? 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2502: [CLOUDSTACK-10352] XenServer: Support online migration of a virtual disk from non-managed to managed storage

[GitBox]

blueorangutan commented on issue #2502: [CLOUDSTACK-10352] XenServer: Support 
online migration of a virtual disk from non-managed to managed storage
URL: https://github.com/apache/cloudstack/pull/2502#issuecomment-380077303
 
 
   @PaulAngus a Trillian-Jenkins matrix job (centos6 mgmt + xs71, centos7 mgmt 
+ vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2486: [CLOUDSTACK-10323] Allow changing disk offering during volume migration

[GitBox]

blueorangutan commented on issue #2486: [CLOUDSTACK-10323] Allow changing disk 
offering during volume migration 
URL: https://github.com/apache/cloudstack/pull/2486#issuecomment-380077312
 
 
   @PaulAngus a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been 
kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] PaulAngus commented on issue #2502: [CLOUDSTACK-10352] XenServer: Support online migration of a virtual disk from non-managed to managed storage

[GitBox]

PaulAngus commented on issue #2502: [CLOUDSTACK-10352] XenServer: Support 
online migration of a virtual disk from non-managed to managed storage
URL: https://github.com/apache/cloudstack/pull/2502#issuecomment-380077171
 
 
   @blueorangutan test matrix
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] PaulAngus commented on issue #2486: [CLOUDSTACK-10323] Allow changing disk offering during volume migration

[GitBox]

PaulAngus commented on issue #2486: [CLOUDSTACK-10323] Allow changing disk 
offering during volume migration 
URL: https://github.com/apache/cloudstack/pull/2486#issuecomment-380076997
 
 
   @blueorangutan test
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2404: [CLOUDSTACK-10230] User should not be able to use removed “Guest OS type”

[GitBox]

blueorangutan commented on issue #2404: [CLOUDSTACK-10230] User should not be 
able to use removed “Guest OS type”
URL: https://github.com/apache/cloudstack/pull/2404#issuecomment-380077038
 
 
   @PaulAngus a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been 
kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] DaanHoogland commented on issue #2490: Create database upgrade from 4.11.0.0 to 4.11.1.0 & VMWare version to OS mappings

[GitBox]

DaanHoogland commented on issue #2490: Create database upgrade from 4.11.0.0 to 
4.11.1.0 & VMWare version to OS mappings
URL: https://github.com/apache/cloudstack/pull/2490#issuecomment-380076927
 
 
   np @nitin-maharana , would be if you had objection though. And we can always 
revert, remember ;)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] PaulAngus commented on issue #2404: [CLOUDSTACK-10230] User should not be able to use removed “Guest OS type”

[GitBox]

PaulAngus commented on issue #2404: [CLOUDSTACK-10230] User should not be able 
to use removed “Guest OS type”
URL: https://github.com/apache/cloudstack/pull/2404#issuecomment-380076824
 
 
   @blueorangutan test
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2550: debian: Use only `-l` for libvirtd default file on debian

[GitBox]

blueorangutan commented on issue #2550: debian: Use only `-l` for libvirtd 
default file on debian
URL: https://github.com/apache/cloudstack/pull/2550#issuecomment-380076518
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2560: ui: Make zonal dashboard larger

[GitBox]

blueorangutan commented on issue #2560: ui: Make zonal dashboard larger
URL: https://github.com/apache/cloudstack/pull/2560#issuecomment-380075538
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd opened a new pull request #2560: ui: Make zonal dashboard larger

[GitBox]

rhtyd opened a new pull request #2560: ui: Make zonal dashboard larger
URL: https://github.com/apache/cloudstack/pull/2560
 
 
   The host/alert dashboard panels are on the top side, the dashboard
   statistics page gets less room. This increases the panel by 100px for
   zone dashboard and decreases the host/alert panels by 100px.
   
   
   
   ## Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [ ] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ## Screenshots (if appropriate):
   
   ![screenshot from 2018-04-10 
17-35-32](https://user-images.githubusercontent.com/95203/38556057-f3d33060-3ce5-11e8-80b8-1ef32b413aee.png)
   
   ## How Has This Been Tested?
   
   UI changes + refresh.
   
   
   
   
   ## Checklist:
   
   
   - [ ] I have read the 
[CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md)
 document.
   - [ ] My code follows the code style of this project.
   - [ ] My change requires a change to the documentation.
   - [ ] I have updated the documentation accordingly.
   Testing
   - [ ] I have added tests to cover my changes.
   - [ ] All relevant new and existing integration tests have passed.
   - [ ] A full integration testsuite with all test that can run on my 
environment has passed.
   
   
   @blueorangutan package
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] DaanHoogland commented on issue #2533: Web-UI creates all isolated Nets with IP range 10.1.1.0/24

[GitBox]

DaanHoogland commented on issue #2533: Web-UI creates all isolated Nets with IP 
range 10.1.1.0/24
URL: https://github.com/apache/cloudstack/issues/2533#issuecomment-380075111
 
 
   @mdesaive I am not sure if I fully understand this second issue. It seems 
you are only adding a NIC in the UI and then comparing it with adding a network 
with cloudmonkey. It may well be related but I can't tell from your description.
   My guess is that it is a consequential error, due to the limited address 
space given to a network created through the UI, especially if a previous 
network had the same CIDR and the NIC is created on a VM connected to that 
previous network. (hope I make more sense to you than to myself)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] DaanHoogland commented on a change in pull request #2559: Upgrade path 4.11 through 4.11.1 to 4.12

[GitBox]

DaanHoogland commented on a change in pull request #2559: Upgrade path 4.11 
through 4.11.1 to 4.12
URL: https://github.com/apache/cloudstack/pull/2559#discussion_r180390422
 
 

 ##
 File path: 
engine/schema/src/main/java/com/cloud/upgrade/DatabaseUpgradeChecker.java
 ##
 @@ -139,313 +140,317 @@ public DatabaseUpgradeChecker() {
 new Upgrade40to41(), new Upgrade410to420(), new 
Upgrade420to421(), new Upgrade421to430(), new Upgrade430to440(), new 
Upgrade440to441(), new Upgrade441to442(),
 new Upgrade442to450(), new Upgrade450to451(), new 
Upgrade451to452(), new Upgrade452to460(), new Upgrade460to461(), new 
Upgrade461to470(), new Upgrade470to471(),
 new Upgrade471to480(), new Upgrade480to481(), new 
Upgrade481to490(), new Upgrade490to4910(), new Upgrade4910to4920(), new 
Upgrade4920to4930(),
-new Upgrade4930to41000(), new Upgrade41000to41100(), new 
Upgrade41100to41200()});
+new Upgrade4930to41000(), new Upgrade41000to41100(), new 
Upgrade41100to41110(), new Upgrade41110to41200()});
 
 _upgradeMap.put(CloudStackVersion.parse("2.2.1"),
 new DbUpgrade[] {new Upgrade221to222(), new 
UpgradeSnapshot223to224(), new Upgrade222to224(), new Upgrade224to225(), new 
Upgrade225to226(), new Upgrade227to228(),
 new Upgrade228to229(), new Upgrade229to2210(), new 
Upgrade2210to2211(), new Upgrade2211to2212(), new Upgrade2212to2213(), new 
Upgrade2213to2214(),
 new Upgrade2214to30(), new Upgrade30to301(), new 
Upgrade301to302(), new Upgrade302to40(), new Upgrade40to41(), new 
Upgrade410to420(), new Upgrade420to421(),
 new Upgrade421to430(), new Upgrade430to440(), new 
Upgrade440to441(), new Upgrade441to442(), new Upgrade442to450(), new 
Upgrade450to451(), new Upgrade451to452(),
 new Upgrade452to460(), new Upgrade460to461(), new 
Upgrade461to470(), new Upgrade470to471(), new Upgrade471to480(), new 
Upgrade480to481(), new Upgrade481to490(),
-new Upgrade490to4910(), new Upgrade4910to4920(), new 
Upgrade4920to4930(), new Upgrade4930to41000(), new Upgrade41000to41100(), new 
Upgrade41100to41200()});
+new Upgrade490to4910(), new Upgrade4910to4920(), new 
Upgrade4920to4930(), new Upgrade4930to41000(), new Upgrade41000to41100(),
+new Upgrade41100to41110(),  new Upgrade41110to41200()});
 
 _upgradeMap.put(CloudStackVersion.parse("2.2.2"),
 new DbUpgrade[] {new Upgrade222to224(), new 
UpgradeSnapshot223to224(), new Upgrade224to225(), new Upgrade225to226(), new 
Upgrade227to228(), new Upgrade228to229(),
 new Upgrade229to2210(), new Upgrade2210to2211(), new 
Upgrade2211to2212(), new Upgrade2212to2213(), new Upgrade2213to2214(), new 
Upgrade2214to30(),
 new Upgrade30to301(), new Upgrade301to302(), new 
Upgrade302to40(), new Upgrade40to41(), new Upgrade410to420(), new 
Upgrade420to421(), new Upgrade421to430(),
 new Upgrade430to440(), new Upgrade440to441(), new 
Upgrade441to442(), new Upgrade442to450(), new Upgrade450to451(), new 
Upgrade451to452(), new Upgrade452to460(),
 new Upgrade460to461(), new Upgrade461to470(), new 
Upgrade470to471(), new Upgrade471to480(), new Upgrade480to481(), new 
Upgrade481to490(), new Upgrade490to4910(),
-new Upgrade4910to4920(), new Upgrade4920to4930(), new 
Upgrade4930to41000(), new Upgrade41000to41100(), new Upgrade41100to41200()});
+new Upgrade4910to4920(), new Upgrade4920to4930(), new 
Upgrade4930to41000(), new Upgrade41000to41100(), new Upgrade41100to41110(), new 
Upgrade41110to41200()});
 
 _upgradeMap.put(CloudStackVersion.parse("2.2.3"),
 new DbUpgrade[] {new Upgrade222to224(), new 
UpgradeSnapshot223to224(), new Upgrade224to225(), new Upgrade225to226(), new 
Upgrade227to228(), new Upgrade228to229(),
 new Upgrade229to2210(), new Upgrade2210to2211(), new 
Upgrade2211to2212(), new Upgrade2212to2213(), new Upgrade2213to2214(), new 
Upgrade2214to30(),
 new Upgrade30to301(), new Upgrade301to302(), new 
Upgrade302to40(), new Upgrade40to41(), new Upgrade410to420(), new 
Upgrade420to421(), new Upgrade421to430(),
 new Upgrade430to440(), new Upgrade440to441(), new 
Upgrade441to442(), new Upgrade442to450(), new Upgrade450to451(), new 
Upgrade451to452(), new Upgrade452to460(),
 new Upgrade460to461(), new Upgrade461to470(), new 
Upgrade470to471(), new Upgrade471to480(), new Upgrade480to481(), new 
Upgrade481to490(), new Upgrade490to4910(),
-new Upgrade4910to4920(), new Upgrade4920to4930(), new 
Upgrade4930to41000(), new Upgrade41000to41100(), new Upgrade41100to41200()});
+   new Upgrade4910to4920(), new Upgrade4920to4930(), new 
Upgrade4930to41000(), new Upgrade41000to41100(), new Upgrade41100to41110(), new 
Upgrade41110to41200()});
 
 

[GitHub] rafaelweingartner closed pull request #2401: [CLOUDSTACK-10226] CloudStack is not importing Local storage properly

[GitBox]

rafaelweingartner closed pull request #2401: [CLOUDSTACK-10226] CloudStack is 
not importing Local storage properly
URL: https://github.com/apache/cloudstack/pull/2401
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/plugins/hypervisors/xenserver/src/main/java/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java
 
b/plugins/hypervisors/xenserver/src/main/java/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java
index 19670b2066e..4a9001b27da 100644
--- 
a/plugins/hypervisors/xenserver/src/main/java/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java
+++ 
b/plugins/hypervisors/xenserver/src/main/java/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java
@@ -51,8 +51,10 @@
 
 import org.apache.cloudstack.storage.to.TemplateObjectTO;
 import org.apache.cloudstack.storage.to.VolumeObjectTO;
+import org.apache.commons.collections.CollectionUtils;
 import org.apache.commons.collections.MapUtils;
 import org.apache.commons.io.FileUtils;
+import org.apache.commons.lang3.BooleanUtils;
 import org.apache.log4j.Logger;
 import org.apache.xmlrpc.XmlRpcException;
 import org.joda.time.Duration;
@@ -173,7 +175,7 @@
  * used to describe what type of resource a storage device is of
  */
 public enum SRType {
-EXT, FILE, ISCSI, ISO, LVM, LVMOHBA, LVMOISCSI,
+EXT, ISO, LVM, LVMOHBA, LVMOISCSI,
 /**
  * used for resigning metadata (like SR UUID and VDI UUID when a
  * particular storage manager is installed on a XenServer host (for 
back-end snapshots to work))
@@ -761,11 +763,6 @@ protected VDI cloudVDIcopy(final Connection conn, final 
VDI vdi, final SR sr, in
 final HashMap vmMetaDatum = new HashMap();
 try {
 final Map vm_map = VM.getAllRecords(conn); // USE
-// THIS TO
-// GET ALL
-// VMS
-// FROM A
-// CLUSTER
 if (vm_map != null) {
 for (final VM.Record record : vm_map.values()) {
 if (record.isControlDomain || record.isASnapshot || 
record.isATemplate) {
@@ -2274,16 +2271,11 @@ public HostStatsEntry getHostStats(final Connection 
conn, final GetHostStatsComm
 }
 
 protected HashMap 
getHostVmStateReport(final Connection conn) {
-
-// TODO : new VM sync model does not require a cluster-scope report, we
-// need to optimize
-// the report accordingly
 final HashMap vmStates = new 
HashMap();
 Map vm_map = null;
 for (int i = 0; i < 2; i++) {
 try {
-vm_map = VM.getAllRecords(conn); // USE THIS TO GET ALL VMS 
FROM
-// A CLUSTER
+vm_map = VM.getAllRecords(conn);
 break;
 } catch (final Throwable e) {
 s_logger.warn("Unable to get vms", e);
@@ -2652,76 +2644,6 @@ public String getLabel() {
 return result;
 }
 
-protected SR getLocalEXTSR(final Connection conn) {
-try {
-final Map map = SR.getAllRecords(conn);
-if (map != null && !map.isEmpty()) {
-for (final Map.Entry entry : map.entrySet()) {
-final SR.Record srRec = entry.getValue();
-if (SRType.FILE.equals(srRec.type) || 
SRType.EXT.equals(srRec.type)) {
-final Set pbds = srRec.PBDs;
-if (pbds == null) {
-continue;
-}
-for (final PBD pbd : pbds) {
-final Host host = pbd.getHost(conn);
-if (!isRefNull(host) && 
host.getUuid(conn).equals(_host.getUuid())) {
-if (!pbd.getCurrentlyAttached(conn)) {
-pbd.plug(conn);
-}
-final SR sr = entry.getKey();
-sr.scan(conn);
-return sr;
-}
-}
-}
-}
-}
-} catch (final XenAPIException e) {
-final String msg = "Unable to get local EXTSR in host:" + 
_host.getUuid() + e.toString();
-s_logger.warn(msg);
-} catch (final XmlRpcException e) {
-final String msg = "Unable to get local EXTSR in host:" + 
_host.getUuid() + e.getCause();
-s_logger.warn(msg);
-}
-return null;
-}
-
-

[cloudstack] branch master updated: [CLOUDSTACK-10226] CloudStack is not importing Local storage properly (#2401)

[rafael]

This is an automated email from the ASF dual-hosted git repository.

rafael pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git


The following commit(s) were added to refs/heads/master by this push:
 new bbc9204  [CLOUDSTACK-10226] CloudStack is not importing Local storage 
properly (#2401)
bbc9204 is described below

commit bbc92046655bc528846090eddf1fc38abd2da90a
Author: Rafael Weingärtner 
AuthorDate: Tue Apr 10 08:49:07 2018 -0300

[CLOUDSTACK-10226] CloudStack is not importing Local storage properly 
(#2401)

* [CLOUDSTACK-10226] CloudStack is not importing Local storage properly

CloudStack is importing as Local storage any XenServer SR that is of type 
LVM or EXT. This causes a problem when one wants to use both Direct attach 
storage and local storage. Moreover, CloudStack was not importing all of the 
local storage that a host has available when local storage is enabled. It was 
only importing the First SR it sees.

To fix the first problem we started ignoring SRs that have the flag 
shared=true when discovering local storages. SRs configured to be shared are 
used as direct attached storage, and therefore should not be imported again as 
local ones.
To fix the second problem, we started loading all Local storage and 
importing them accordingly to ACS.

* Cleanups and formatting
---
 .../xenserver/resource/CitrixResourceBase.java | 275 ++---
 .../xenserver/resource/XenServer56Resource.java|   3 +-
 .../resource/Xenserver625StorageProcessor.java |   2 +-
 .../hypervisor/xenserver/resource/XsHost.java  |   9 -
 .../xenserver/resource/CitrixResourceBaseTest.java | 202 ++-
 .../xenserver/resource/XcpOssResourceTest.java |   7 +-
 .../xenserver/resource/XcpServerResourceTest.java  |   7 +-
 .../resource/XenServer56FP1ResourceTest.java   |   7 +-
 .../resource/XenServer56ResourceTest.java  |   7 +-
 .../resource/XenServer56SP2ResourceTest.java   |   3 +-
 .../resource/XenServer600ResourceTest.java |   3 +-
 .../resource/XenServer650ResourceTest.java |   3 +-
 .../com/cloud/server/ManagementServerImpl.java | 140 ---
 .../java/com/cloud/storage/StorageManagerImpl.java | 208 +++-
 .../com/cloud/storage/StorageManagerImplTest.java  |  61 +
 15 files changed, 558 insertions(+), 379 deletions(-)

diff --git 
a/plugins/hypervisors/xenserver/src/main/java/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java
 
b/plugins/hypervisors/xenserver/src/main/java/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java
index 19670b2..4a9001b 100644
--- 
a/plugins/hypervisors/xenserver/src/main/java/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java
+++ 
b/plugins/hypervisors/xenserver/src/main/java/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java
@@ -51,8 +51,10 @@ import javax.xml.parsers.ParserConfigurationException;
 
 import org.apache.cloudstack.storage.to.TemplateObjectTO;
 import org.apache.cloudstack.storage.to.VolumeObjectTO;
+import org.apache.commons.collections.CollectionUtils;
 import org.apache.commons.collections.MapUtils;
 import org.apache.commons.io.FileUtils;
+import org.apache.commons.lang3.BooleanUtils;
 import org.apache.log4j.Logger;
 import org.apache.xmlrpc.XmlRpcException;
 import org.joda.time.Duration;
@@ -173,7 +175,7 @@ public abstract class CitrixResourceBase implements 
ServerResource, HypervisorRe
  * used to describe what type of resource a storage device is of
  */
 public enum SRType {
-EXT, FILE, ISCSI, ISO, LVM, LVMOHBA, LVMOISCSI,
+EXT, ISO, LVM, LVMOHBA, LVMOISCSI,
 /**
  * used for resigning metadata (like SR UUID and VDI UUID when a
  * particular storage manager is installed on a XenServer host (for 
back-end snapshots to work))
@@ -761,11 +763,6 @@ public abstract class CitrixResourceBase implements 
ServerResource, HypervisorRe
 final HashMap vmMetaDatum = new HashMap();
 try {
 final Map vm_map = VM.getAllRecords(conn); // USE
-// THIS TO
-// GET ALL
-// VMS
-// FROM A
-// CLUSTER
 if (vm_map != null) {
 for (final VM.Record record : vm_map.values()) {
 if (record.isControlDomain || record.isASnapshot || 
record.isATemplate) {
@@ -2274,16 +2271,11 @@ public abstract class CitrixResourceBase implements 
ServerResource, HypervisorRe
 }
 
 protected HashMap 
getHostVmStateReport(final Connection conn) {
-
-// TODO : new VM sync model does not require a cluster-scope report, we
-// need to optimize
-// the report accordingly
 final HashMap vmStates = new 
HashMap

[cloudstack] branch master updated: [CLOUDSTACK-10301] Allow updating the network ACL list name and Description (#2462)

[rafael]

This is an automated email from the ASF dual-hosted git repository.

rafael pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git


The following commit(s) were added to refs/heads/master by this push:
 new b08f9e0  [CLOUDSTACK-10301] Allow updating the network ACL list name 
and Description (#2462)
b08f9e0 is described below

commit b08f9e053ff301d59dc81283704be37dc1871905
Author: Rafael Weingärtner 
AuthorDate: Tue Apr 10 08:46:52 2018 -0300

[CLOUDSTACK-10301] Allow updating the network ACL list name and Description 
(#2462)

* [CLOUDSTACK-10301] Allow updating the network ACL list name and 
description

* Fixes suggested by Daan
---
 .../com/cloud/network/vpc/NetworkACLService.java   |  5 +-
 .../user/network/UpdateNetworkACLListCmd.java  | 22 -
 .../java/com/cloud/network/vpc/NetworkACLVO.java   |  8 ++
 .../cloud/network/vpc/NetworkACLServiceImpl.java   | 25 --
 .../network/vpc/NetworkACLServiceImplTest.java | 94 +++---
 ui/l10n/ar.js  |  1 +
 ui/l10n/ca.js  |  1 +
 ui/l10n/de_DE.js   |  1 +
 ui/l10n/en.js  |  1 +
 ui/l10n/es.js  |  1 +
 ui/l10n/fr_FR.js   |  1 +
 ui/l10n/hu.js  |  1 +
 ui/l10n/it_IT.js   |  1 +
 ui/l10n/ja_JP.js   |  1 +
 ui/l10n/ko_KR.js   |  1 +
 ui/l10n/nb_NO.js   |  1 +
 ui/l10n/nl_NL.js   |  1 +
 ui/l10n/pl.js  |  1 +
 ui/l10n/pt_BR.js   |  1 +
 ui/l10n/ru_RU.js   |  1 +
 ui/l10n/zh_CN.js   |  1 +
 ui/scripts/ui/widgets/detailView.js|  2 +-
 ui/scripts/vpc.js  | 35 +++-
 23 files changed, 180 insertions(+), 27 deletions(-)

diff --git a/api/src/main/java/com/cloud/network/vpc/NetworkACLService.java 
b/api/src/main/java/com/cloud/network/vpc/NetworkACLService.java
index dd7c862..378b15c 100644
--- a/api/src/main/java/com/cloud/network/vpc/NetworkACLService.java
+++ b/api/src/main/java/com/cloud/network/vpc/NetworkACLService.java
@@ -22,6 +22,7 @@ import 
org.apache.cloudstack.api.command.user.network.CreateNetworkACLCmd;
 import org.apache.cloudstack.api.command.user.network.ListNetworkACLListsCmd;
 import org.apache.cloudstack.api.command.user.network.ListNetworkACLsCmd;
 import org.apache.cloudstack.api.command.user.network.UpdateNetworkACLItemCmd;
+import org.apache.cloudstack.api.command.user.network.UpdateNetworkACLListCmd;
 
 import com.cloud.exception.ResourceUnavailableException;
 import com.cloud.utils.Pair;
@@ -38,7 +39,7 @@ public interface NetworkACLService {
 NetworkACL getNetworkACL(long id);
 
 /**
- * List NetworkACLs by Id/Name/Network or Vpc it belongs to
+ * List NetworkACLs by Id/Name/Network or VPC it belongs to
  */
 Pair 
listNetworkACLs(ListNetworkACLListsCmd cmd);
 
@@ -87,6 +88,6 @@ public interface NetworkACLService {
  */
 boolean replaceNetworkACLonPrivateGw(long aclId, long privateGatewayId) 
throws ResourceUnavailableException;
 
-NetworkACL updateNetworkACL(Long id, String customId, Boolean forDisplay);
+NetworkACL updateNetworkACL(UpdateNetworkACLListCmd 
updateNetworkACLListCmd);
 
 }
diff --git 
a/api/src/main/java/org/apache/cloudstack/api/command/user/network/UpdateNetworkACLListCmd.java
 
b/api/src/main/java/org/apache/cloudstack/api/command/user/network/UpdateNetworkACLListCmd.java
index aa1f557..22eaf21 100644
--- 
a/api/src/main/java/org/apache/cloudstack/api/command/user/network/UpdateNetworkACLListCmd.java
+++ 
b/api/src/main/java/org/apache/cloudstack/api/command/user/network/UpdateNetworkACLListCmd.java
@@ -31,8 +31,7 @@ import com.cloud.exception.ResourceUnavailableException;
 import com.cloud.network.vpc.NetworkACL;
 import com.cloud.user.Account;
 
-@APICommand(name = "updateNetworkACLList", description = "Updates network ACL 
list", responseObject = SuccessResponse.class, since = "4.4",
-requestHasSensitiveInfo = false, responseHasSensitiveInfo = false)
+@APICommand(name = "updateNetworkACLList", description = "Updates network ACL 
list", responseObject = SuccessResponse.class, since = "4.4", 
requestHasSensitiveInfo = false, responseHasSensitiveInfo = false)
 public class UpdateNetworkACLListCmd extends BaseAsyncCustomIdCmd {
 public static final Logger s_logger = 
Logger.getLogger(UpdateNetworkACLListCmd.class.getName());
 private static final String s_name = "updatenetworkacllistresponse";
@@ -44,9 +43,16 @@ public class UpdateNetworkACLListCmd extends 

[GitHub] rafaelweingartner closed pull request #2462: [CLOUDSTACK-10301] Allow updating the network ACL list name and Description

[GitBox]

rafaelweingartner closed pull request #2462: [CLOUDSTACK-10301] Allow updating 
the network ACL list name and Description
URL: https://github.com/apache/cloudstack/pull/2462
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/api/src/main/java/com/cloud/network/vpc/NetworkACLService.java 
b/api/src/main/java/com/cloud/network/vpc/NetworkACLService.java
index dd7c862d46b..378b15ce940 100644
--- a/api/src/main/java/com/cloud/network/vpc/NetworkACLService.java
+++ b/api/src/main/java/com/cloud/network/vpc/NetworkACLService.java
@@ -22,6 +22,7 @@
 import org.apache.cloudstack.api.command.user.network.ListNetworkACLListsCmd;
 import org.apache.cloudstack.api.command.user.network.ListNetworkACLsCmd;
 import org.apache.cloudstack.api.command.user.network.UpdateNetworkACLItemCmd;
+import org.apache.cloudstack.api.command.user.network.UpdateNetworkACLListCmd;
 
 import com.cloud.exception.ResourceUnavailableException;
 import com.cloud.utils.Pair;
@@ -38,7 +39,7 @@
 NetworkACL getNetworkACL(long id);
 
 /**
- * List NetworkACLs by Id/Name/Network or Vpc it belongs to
+ * List NetworkACLs by Id/Name/Network or VPC it belongs to
  */
 Pair 
listNetworkACLs(ListNetworkACLListsCmd cmd);
 
@@ -87,6 +88,6 @@
  */
 boolean replaceNetworkACLonPrivateGw(long aclId, long privateGatewayId) 
throws ResourceUnavailableException;
 
-NetworkACL updateNetworkACL(Long id, String customId, Boolean forDisplay);
+NetworkACL updateNetworkACL(UpdateNetworkACLListCmd 
updateNetworkACLListCmd);
 
 }
diff --git 
a/api/src/main/java/org/apache/cloudstack/api/command/user/network/UpdateNetworkACLListCmd.java
 
b/api/src/main/java/org/apache/cloudstack/api/command/user/network/UpdateNetworkACLListCmd.java
index aa1f557e72b..22eaf2180ca 100644
--- 
a/api/src/main/java/org/apache/cloudstack/api/command/user/network/UpdateNetworkACLListCmd.java
+++ 
b/api/src/main/java/org/apache/cloudstack/api/command/user/network/UpdateNetworkACLListCmd.java
@@ -31,8 +31,7 @@
 import com.cloud.network.vpc.NetworkACL;
 import com.cloud.user.Account;
 
-@APICommand(name = "updateNetworkACLList", description = "Updates network ACL 
list", responseObject = SuccessResponse.class, since = "4.4",
-requestHasSensitiveInfo = false, responseHasSensitiveInfo = false)
+@APICommand(name = "updateNetworkACLList", description = "Updates network ACL 
list", responseObject = SuccessResponse.class, since = "4.4", 
requestHasSensitiveInfo = false, responseHasSensitiveInfo = false)
 public class UpdateNetworkACLListCmd extends BaseAsyncCustomIdCmd {
 public static final Logger s_logger = 
Logger.getLogger(UpdateNetworkACLListCmd.class.getName());
 private static final String s_name = "updatenetworkacllistresponse";
@@ -44,9 +43,16 @@
 @Parameter(name = ApiConstants.ID, type = CommandType.UUID, entityType = 
NetworkACLResponse.class, required = true, description = "the ID of the network 
ACL")
 private Long id;
 
-@Parameter(name = ApiConstants.FOR_DISPLAY, type = CommandType.BOOLEAN, 
description = "an optional field, whether to the display the list to the end 
user or not", since = "4.4", authorized = {RoleType.Admin})
+@Parameter(name = ApiConstants.FOR_DISPLAY, type = CommandType.BOOLEAN, 
description = "an optional field, whether to the display the list to the end 
user or not", since = "4.4", authorized = {
+RoleType.Admin})
 private Boolean display;
 
+@Parameter(name = ApiConstants.NAME, type = CommandType.STRING, 
description = "Name of the network ACL list")
+private String name;
+
+@Parameter(name = ApiConstants.DESCRIPTION, type = CommandType.STRING, 
description = "Description of the network ACL list")
+private String description;
+
 /
 /// Accessors ///
 /
@@ -85,7 +91,7 @@ public long getEntityOwnerId() {
 
 @Override
 public void execute() throws ResourceUnavailableException {
-NetworkACL acl = _networkACLService.updateNetworkACL(id, 
this.getCustomId(), getDisplay());
+NetworkACL acl = _networkACLService.updateNetworkACL(this);
 NetworkACLResponse aclResponse = 
_responseGenerator.createNetworkACLResponse(acl);
 setResponseObject(aclResponse);
 aclResponse.setResponseName(getCommandName());
@@ -97,4 +103,12 @@ public void checkUuid() {
 _uuidMgr.checkUuid(this.getCustomId(), NetworkACL.class);
 }
 }
+
+public String getDescription() {
+return description;
+}
+
+public String getName() {
+return name;
+}
 }
diff --git 

[GitHub] rafaelweingartner commented on a change in pull request #2559: Upgrade path 4.11 through 4.11.1 to 4.12

[GitBox]

rafaelweingartner commented on a change in pull request #2559: Upgrade path 
4.11 through 4.11.1 to 4.12
URL: https://github.com/apache/cloudstack/pull/2559#discussion_r180387679
 
 

 ##
 File path: 
engine/schema/src/main/java/com/cloud/upgrade/DatabaseUpgradeChecker.java
 ##
 @@ -139,313 +140,317 @@ public DatabaseUpgradeChecker() {
 new Upgrade40to41(), new Upgrade410to420(), new 
Upgrade420to421(), new Upgrade421to430(), new Upgrade430to440(), new 
Upgrade440to441(), new Upgrade441to442(),
 new Upgrade442to450(), new Upgrade450to451(), new 
Upgrade451to452(), new Upgrade452to460(), new Upgrade460to461(), new 
Upgrade461to470(), new Upgrade470to471(),
 new Upgrade471to480(), new Upgrade480to481(), new 
Upgrade481to490(), new Upgrade490to4910(), new Upgrade4910to4920(), new 
Upgrade4920to4930(),
-new Upgrade4930to41000(), new Upgrade41000to41100(), new 
Upgrade41100to41200()});
+new Upgrade4930to41000(), new Upgrade41000to41100(), new 
Upgrade41100to41110(), new Upgrade41110to41200()});
 
 _upgradeMap.put(CloudStackVersion.parse("2.2.1"),
 new DbUpgrade[] {new Upgrade221to222(), new 
UpgradeSnapshot223to224(), new Upgrade222to224(), new Upgrade224to225(), new 
Upgrade225to226(), new Upgrade227to228(),
 new Upgrade228to229(), new Upgrade229to2210(), new 
Upgrade2210to2211(), new Upgrade2211to2212(), new Upgrade2212to2213(), new 
Upgrade2213to2214(),
 new Upgrade2214to30(), new Upgrade30to301(), new 
Upgrade301to302(), new Upgrade302to40(), new Upgrade40to41(), new 
Upgrade410to420(), new Upgrade420to421(),
 new Upgrade421to430(), new Upgrade430to440(), new 
Upgrade440to441(), new Upgrade441to442(), new Upgrade442to450(), new 
Upgrade450to451(), new Upgrade451to452(),
 new Upgrade452to460(), new Upgrade460to461(), new 
Upgrade461to470(), new Upgrade470to471(), new Upgrade471to480(), new 
Upgrade480to481(), new Upgrade481to490(),
-new Upgrade490to4910(), new Upgrade4910to4920(), new 
Upgrade4920to4930(), new Upgrade4930to41000(), new Upgrade41000to41100(), new 
Upgrade41100to41200()});
+new Upgrade490to4910(), new Upgrade4910to4920(), new 
Upgrade4920to4930(), new Upgrade4930to41000(), new Upgrade41000to41100(),
+new Upgrade41100to41110(),  new Upgrade41110to41200()});
 
 _upgradeMap.put(CloudStackVersion.parse("2.2.2"),
 new DbUpgrade[] {new Upgrade222to224(), new 
UpgradeSnapshot223to224(), new Upgrade224to225(), new Upgrade225to226(), new 
Upgrade227to228(), new Upgrade228to229(),
 new Upgrade229to2210(), new Upgrade2210to2211(), new 
Upgrade2211to2212(), new Upgrade2212to2213(), new Upgrade2213to2214(), new 
Upgrade2214to30(),
 new Upgrade30to301(), new Upgrade301to302(), new 
Upgrade302to40(), new Upgrade40to41(), new Upgrade410to420(), new 
Upgrade420to421(), new Upgrade421to430(),
 new Upgrade430to440(), new Upgrade440to441(), new 
Upgrade441to442(), new Upgrade442to450(), new Upgrade450to451(), new 
Upgrade451to452(), new Upgrade452to460(),
 new Upgrade460to461(), new Upgrade461to470(), new 
Upgrade470to471(), new Upgrade471to480(), new Upgrade480to481(), new 
Upgrade481to490(), new Upgrade490to4910(),
-new Upgrade4910to4920(), new Upgrade4920to4930(), new 
Upgrade4930to41000(), new Upgrade41000to41100(), new Upgrade41100to41200()});
+new Upgrade4910to4920(), new Upgrade4920to4930(), new 
Upgrade4930to41000(), new Upgrade41000to41100(), new Upgrade41100to41110(), new 
Upgrade41110to41200()});
 
 _upgradeMap.put(CloudStackVersion.parse("2.2.3"),
 new DbUpgrade[] {new Upgrade222to224(), new 
UpgradeSnapshot223to224(), new Upgrade224to225(), new Upgrade225to226(), new 
Upgrade227to228(), new Upgrade228to229(),
 new Upgrade229to2210(), new Upgrade2210to2211(), new 
Upgrade2211to2212(), new Upgrade2212to2213(), new Upgrade2213to2214(), new 
Upgrade2214to30(),
 new Upgrade30to301(), new Upgrade301to302(), new 
Upgrade302to40(), new Upgrade40to41(), new Upgrade410to420(), new 
Upgrade420to421(), new Upgrade421to430(),
 new Upgrade430to440(), new Upgrade440to441(), new 
Upgrade441to442(), new Upgrade442to450(), new Upgrade450to451(), new 
Upgrade451to452(), new Upgrade452to460(),
 new Upgrade460to461(), new Upgrade461to470(), new 
Upgrade470to471(), new Upgrade471to480(), new Upgrade480to481(), new 
Upgrade481to490(), new Upgrade490to4910(),
-new Upgrade4910to4920(), new Upgrade4920to4930(), new 
Upgrade4930to41000(), new Upgrade41000to41100(), new Upgrade41100to41200()});
+   new Upgrade4910to4920(), new Upgrade4920to4930(), new 
Upgrade4930to41000(), new Upgrade41000to41100(), new Upgrade41100to41110(), new 
Upgrade41110to41200()});
 
 

[GitHub] rafaelweingartner commented on a change in pull request #2559: Upgrade path 4.11 through 4.11.1 to 4.12

[GitBox]

rafaelweingartner commented on a change in pull request #2559: Upgrade path 
4.11 through 4.11.1 to 4.12
URL: https://github.com/apache/cloudstack/pull/2559#discussion_r180387679
 
 

 ##
 File path: 
engine/schema/src/main/java/com/cloud/upgrade/DatabaseUpgradeChecker.java
 ##
 @@ -139,313 +140,317 @@ public DatabaseUpgradeChecker() {
 new Upgrade40to41(), new Upgrade410to420(), new 
Upgrade420to421(), new Upgrade421to430(), new Upgrade430to440(), new 
Upgrade440to441(), new Upgrade441to442(),
 new Upgrade442to450(), new Upgrade450to451(), new 
Upgrade451to452(), new Upgrade452to460(), new Upgrade460to461(), new 
Upgrade461to470(), new Upgrade470to471(),
 new Upgrade471to480(), new Upgrade480to481(), new 
Upgrade481to490(), new Upgrade490to4910(), new Upgrade4910to4920(), new 
Upgrade4920to4930(),
-new Upgrade4930to41000(), new Upgrade41000to41100(), new 
Upgrade41100to41200()});
+new Upgrade4930to41000(), new Upgrade41000to41100(), new 
Upgrade41100to41110(), new Upgrade41110to41200()});
 
 _upgradeMap.put(CloudStackVersion.parse("2.2.1"),
 new DbUpgrade[] {new Upgrade221to222(), new 
UpgradeSnapshot223to224(), new Upgrade222to224(), new Upgrade224to225(), new 
Upgrade225to226(), new Upgrade227to228(),
 new Upgrade228to229(), new Upgrade229to2210(), new 
Upgrade2210to2211(), new Upgrade2211to2212(), new Upgrade2212to2213(), new 
Upgrade2213to2214(),
 new Upgrade2214to30(), new Upgrade30to301(), new 
Upgrade301to302(), new Upgrade302to40(), new Upgrade40to41(), new 
Upgrade410to420(), new Upgrade420to421(),
 new Upgrade421to430(), new Upgrade430to440(), new 
Upgrade440to441(), new Upgrade441to442(), new Upgrade442to450(), new 
Upgrade450to451(), new Upgrade451to452(),
 new Upgrade452to460(), new Upgrade460to461(), new 
Upgrade461to470(), new Upgrade470to471(), new Upgrade471to480(), new 
Upgrade480to481(), new Upgrade481to490(),
-new Upgrade490to4910(), new Upgrade4910to4920(), new 
Upgrade4920to4930(), new Upgrade4930to41000(), new Upgrade41000to41100(), new 
Upgrade41100to41200()});
+new Upgrade490to4910(), new Upgrade4910to4920(), new 
Upgrade4920to4930(), new Upgrade4930to41000(), new Upgrade41000to41100(),
+new Upgrade41100to41110(),  new Upgrade41110to41200()});
 
 _upgradeMap.put(CloudStackVersion.parse("2.2.2"),
 new DbUpgrade[] {new Upgrade222to224(), new 
UpgradeSnapshot223to224(), new Upgrade224to225(), new Upgrade225to226(), new 
Upgrade227to228(), new Upgrade228to229(),
 new Upgrade229to2210(), new Upgrade2210to2211(), new 
Upgrade2211to2212(), new Upgrade2212to2213(), new Upgrade2213to2214(), new 
Upgrade2214to30(),
 new Upgrade30to301(), new Upgrade301to302(), new 
Upgrade302to40(), new Upgrade40to41(), new Upgrade410to420(), new 
Upgrade420to421(), new Upgrade421to430(),
 new Upgrade430to440(), new Upgrade440to441(), new 
Upgrade441to442(), new Upgrade442to450(), new Upgrade450to451(), new 
Upgrade451to452(), new Upgrade452to460(),
 new Upgrade460to461(), new Upgrade461to470(), new 
Upgrade470to471(), new Upgrade471to480(), new Upgrade480to481(), new 
Upgrade481to490(), new Upgrade490to4910(),
-new Upgrade4910to4920(), new Upgrade4920to4930(), new 
Upgrade4930to41000(), new Upgrade41000to41100(), new Upgrade41100to41200()});
+new Upgrade4910to4920(), new Upgrade4920to4930(), new 
Upgrade4930to41000(), new Upgrade41000to41100(), new Upgrade41100to41110(), new 
Upgrade41110to41200()});
 
 _upgradeMap.put(CloudStackVersion.parse("2.2.3"),
 new DbUpgrade[] {new Upgrade222to224(), new 
UpgradeSnapshot223to224(), new Upgrade224to225(), new Upgrade225to226(), new 
Upgrade227to228(), new Upgrade228to229(),
 new Upgrade229to2210(), new Upgrade2210to2211(), new 
Upgrade2211to2212(), new Upgrade2212to2213(), new Upgrade2213to2214(), new 
Upgrade2214to30(),
 new Upgrade30to301(), new Upgrade301to302(), new 
Upgrade302to40(), new Upgrade40to41(), new Upgrade410to420(), new 
Upgrade420to421(), new Upgrade421to430(),
 new Upgrade430to440(), new Upgrade440to441(), new 
Upgrade441to442(), new Upgrade442to450(), new Upgrade450to451(), new 
Upgrade451to452(), new Upgrade452to460(),
 new Upgrade460to461(), new Upgrade461to470(), new 
Upgrade470to471(), new Upgrade471to480(), new Upgrade480to481(), new 
Upgrade481to490(), new Upgrade490to4910(),
-new Upgrade4910to4920(), new Upgrade4920to4930(), new 
Upgrade4930to41000(), new Upgrade41000to41100(), new Upgrade41100to41200()});
+   new Upgrade4910to4920(), new Upgrade4920to4930(), new 
Upgrade4930to41000(), new Upgrade41000to41100(), new Upgrade41100to41110(), new 
Upgrade41110to41200()});
 
 

[GitHub] DaanHoogland opened a new pull request #2559: Upgrade4.11.1

[GitBox]

DaanHoogland opened a new pull request #2559: Upgrade4.11.1
URL: https://github.com/apache/cloudstack/pull/2559
 
 
   ## Description
   Upgrade path 4.11.0 --> 4.11.1 --> 4.12.0
   
   ## Types of changes
   
   - [?] Breaking change (fix or feature that would cause existing 
functionality to change)
   - [?] New feature (non-breaking change which adds functionality)
   - [?] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ## Screenshots (if appropriate):
   
   ## How Has This Been Tested?
   
   
   
   
   
   ## Checklist:
   
   
   - [ ] I have read the 
[CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md)
 document.
   - [ ] My code follows the code style of this project.
   - [ ] My change requires a change to the documentation.
   - [ ] I have updated the documentation accordingly.
   Testing
   - [ ] I have added tests to cover my changes.
   - [ ] All relevant new and existing integration tests have passed.
   - [ ] A full integration testsuite with all test that can run on my 
environment has passed.
   
   
   @blueorangutan package
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2538: Remove deprecated tomcat configuration file instead of moving it, sin…

[GitBox]

rhtyd commented on issue #2538: Remove deprecated tomcat configuration file 
instead of moving it, sin…
URL: https://github.com/apache/cloudstack/pull/2538#issuecomment-380046622
 
 
   The failed tests are all env related, the changes in the PR cannot be 
validated with Trillian smoke tests as they are upgrade related. Given the 
upgrade procedure was manually tested by @ernjvr / @borisstoyanov I'm okay with 
the merging, no regressions seen. We'll re-test during weekly runs.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] s-seitz opened a new issue #2558: API uploadSslCert does not work

[GitBox]

s-seitz opened a new issue #2558: API uploadSslCert does not work
URL: https://github.com/apache/cloudstack/issues/2558
 
 
   
   
   # ISSUE TYPE
   
* Bug Report
   
   # COMPONENT NAME
   
   ~~~
   API
   ~~~
   
   # CLOUDSTACK VERSION
   
   
   ~~~
   4.11.0.0
   ~~~
   
   # CONFIGURATION
   
   
   Advanced Networking, Cloudstack 4.11.0.0 on Ubuntu 14.04 LTS, MySQL 
5.5.59-0ubuntu0.14.04.1
   
   # OS / ENVIRONMENT
   
   
   Ubuntu 14.04.5 LTS
   # SUMMARY
   
   
   Uploading sslcertificates ( 
https://cloudstack.apache.org/api/apidocs-4.11/apis/uploadSslCert.html ) fails 
for two reasons.
   a) Including the CertChain, it's very likely that the Request Header Size 
grows > 8k and results in HTTP Error 414.
   b) Leaving the CertChain empty to get a shorter GET Request, the Cloudstack 
API responds with Error 530: DB Exception on: 
com.mysql.jdbc.JDBC4PreparedStatement@7ba59657
   
   
   # STEPS TO REPRODUCE
   
   
   
   ~~~
   
   Here 's the sample output of a response. For obvious reasons the 
certificate, key and fingerprint  as well as the name are redacted.
   
   Error 530: DB Exception on: com.mysql.jdbc.JDBC4PreparedStatement@7ba59657: 
INSERT INTO sslcerts (sslcerts.id, sslcerts.uuid, sslcerts.certificate, 
sslcerts.chain, sslcerts.key, sslcerts.password, sslcerts.account_id, 
sslcerts.domain_id, sslcerts.fingerprint, sslcerts.name) VALUES (null, 
_binary'4ed417b3-77b6-42bf-9a82-81ed25aaedc2', _binary'-BEGIN 
CERTIFICATE-\n R E D A C T E D \n-END CERTIFICATE-', null, 
_binary'K E Y R E D A C T E D==', null, 160, 2, 
_binary'00:11:22:33:44:55:66:77:88:F7:AE:73:81:BA:D9:B7:AF:46:D8:E2:F8:EA:7C:FF:00:B7:DE:F7:D7:CF:9B:C9',
 _binary'STAR.some.tld')
   errorcode,uuidList,cserrorcode,errortext
   
   
   
   ~~~
   
   
   
   # EXPECTED RESULTS
   
   
   ~~~
   
   One would expect a certificate available to select after uploading it.
   
   ~~~
   
   # ACTUAL RESULTS
   
   
   
   ~~~
   
   
   ~~~
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] nitin-maharana commented on issue #2490: Create database upgrade from 4.11.0.0 to 4.11.1.0 & VMWare version to OS mappings

[GitBox]

nitin-maharana commented on issue #2490: Create database upgrade from 4.11.0.0 
to 4.11.1.0 & VMWare version to OS mappings
URL: https://github.com/apache/cloudstack/pull/2490#issuecomment-380045539
 
 
   Sorry @DaanHoogland, Somehow I missed your message. LGTM from my side. 
Anyway, it's merged as it had already two LGTMs. Thanks.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on a change in pull request #2554: agent: Add logging to libvirt qemu hook and cleanup

[GitBox]

rhtyd commented on a change in pull request #2554: agent: Add logging to 
libvirt qemu hook and cleanup
URL: https://github.com/apache/cloudstack/pull/2554#discussion_r180362060
 
 

 ##
 File path: agent/bindir/libvirtqemuhook.in
 ##
 @@ -6,59 +6,78 @@
 # to you under the Apache License, Version 2.0 (the
 # "License"); you may not use this file except in compliance
 # with the License.  You may obtain a copy of the License at
-# 
+#
 #   http://www.apache.org/licenses/LICENSE-2.0
-# 
+#
 # Unless required by applicable law or agreed to in writing,
 # software distributed under the License is distributed on an
 # "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
 # KIND, either express or implied.  See the License for the
 # specific language governing permissions and limitations
 # under the License.
-import sys
+
+import logging
 import re
+import sys
 from xml.dom.minidom import parse
 from cloudutils.configFileOps import configFileOps
 from cloudutils.networkConfig import networkConfig
+
+logging.basicConfig(filename='/var/log/libvirt/qemu-hook.log',
 
 Review comment:
   Yes.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on a change in pull request #2554: agent: Add logging to libvirt qemu hook and cleanup

[GitBox]

rhtyd commented on a change in pull request #2554: agent: Add logging to 
libvirt qemu hook and cleanup
URL: https://github.com/apache/cloudstack/pull/2554#discussion_r180362104
 
 

 ##
 File path: agent/bindir/libvirtqemuhook.in
 ##
 @@ -6,59 +6,78 @@
 # to you under the Apache License, Version 2.0 (the
 # "License"); you may not use this file except in compliance
 # with the License.  You may obtain a copy of the License at
-# 
+#
 #   http://www.apache.org/licenses/LICENSE-2.0
-# 
+#
 # Unless required by applicable law or agreed to in writing,
 # software distributed under the License is distributed on an
 # "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
 # KIND, either express or implied.  See the License for the
 # specific language governing permissions and limitations
 # under the License.
-import sys
+
+import logging
 import re
+import sys
 from xml.dom.minidom import parse
 from cloudutils.configFileOps import configFileOps
 from cloudutils.networkConfig import networkConfig
+
+logging.basicConfig(filename='/var/log/libvirt/qemu-hook.log',
+filemode='a',
+format='%(asctime)s,%(msecs)d %(name)s %(levelname)s 
%(message)s',
+datefmt='%H:%M:%S',
+level=logging.INFO)
+logger = logging.getLogger('qemu-hook')
+
 def isOldStyleBridge(brName):
 if brName.find("cloudVirBr") == 0:
return True
 else:
return False
+
 def isNewStyleBridge(brName):
 if brName.startswith('brvx-'):
 return False
 if re.match(r"br(\w+)-(\d+)", brName) == None:
return False
 else:
return True
+
 def getGuestNetworkDevice():
-netlib = networkConfig() 
+netlib = networkConfig()
 cfo = configFileOps("/etc/cloudstack/agent/agent.properties")
 guestDev = cfo.getEntry("guest.network.device")
 enslavedDev = netlib.getEnslavedDev(guestDev, 1)
 return enslavedDev.split(".")[0]
+
 def handleMigrateBegin():
 try:
 domain = parse(sys.stdin)
 for interface in domain.getElementsByTagName("interface"):
 source = interface.getElementsByTagName("source")[0]
 bridge = source.getAttribute("bridge")
 if isOldStyleBridge(bridge):
-vlanId = bridge.replace("cloudVirBr","")
+vlanId = bridge.replace("cloudVirBr", "")
 elif isNewStyleBridge(bridge):
-vlanId = re.sub(r"br(\w+)-","",bridge)
+vlanId = re.sub(r"br(\w+)-", "", bridge)
 else:
 continue
 phyDev = getGuestNetworkDevice()
-newBrName="br" + phyDev + "-" + vlanId
+newBrName = "br" + phyDev + "-" + vlanId
 source.setAttribute("bridge", newBrName)
 print(domain.toxml())
 except:
 pass
+
+
 if __name__ == '__main__':
 if len(sys.argv) != 5:
 sys.exit(0)
 
-if sys.argv[2] == "migrate" and sys.argv[3] == "begin":
-handleMigrateBegin() 
+# For docs refer https://libvirt.org/hooks.html#qemu
+logger.debug("Executing qemu hook with args: %s" % sys.argv)
+guest_name, action, status = sys.argv[1:4]
 
 Review comment:
   I'll fix this.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mdesaive commented on issue #2533: Web-UI creates all isolated Nets with IP range 10.1.1.0/24

[GitBox]

mdesaive commented on issue #2533: Web-UI creates all isolated Nets with IP 
range 10.1.1.0/24
URL: https://github.com/apache/cloudstack/issues/2533#issuecomment-380029916
 
 
   @DaanHoogland I have another issue for isolated networks created through the 
web-UI. Can you decide if that is a new ticket, of if it is fixed with this 
issue?
   
   It is not possible to add a NIC on an isolated network created through the 
web-UI I. I receive an exception:
   
   com.cloud.utils.exception.CloudRuntimeException: Insufficient capacity when 
adding NIC to VM[User|i-157-2357-VM]: 
com.cloud.exception.InsufficientAddressCapacityException: Insufficient address 
capacityScope=interface com.cloud.dc.DataCenter; id=1
   
   For networks created with CloudMonkey and with explicit declaration of 
"gateway" and "netmask" adding NICs is working.
   
   create network displaytext=testnet name=testnet networkofferingid= 
zoneid= projectid= gateway=172.17.1.1 netmask=255.255.252.0 
networkdomain=


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] s-seitz commented on issue #2541: Add "Lets Encrypt CA" Certpath to SSVM Keystore (for cdimage.debian.org)

[GitBox]

s-seitz commented on issue #2541: Add "Lets Encrypt CA" Certpath to SSVM 
Keystore (for cdimage.debian.org)
URL: https://github.com/apache/cloudstack/issues/2541#issuecomment-380029210
 
 
   @rhtyd  Great and thank's in advance if you'ld find time before 4.11.1.0. I 
was not thinking about downloading a truststore from public ressources instead 
of having it somewhere at a fixed location at the storage the SSVM is connected 
to.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] PaulAngus commented on issue #2517: manual mapped ldap fix

[GitBox]

PaulAngus commented on issue #2517: manual mapped ldap fix
URL: https://github.com/apache/cloudstack/pull/2517#issuecomment-379777403
 
 
   LGTM
   Manually tested with login to Active Directory on Windows 2012r2 Server.
   Could log in with user account, where previously could not.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[cloudstack] branch 4.11 updated: Create database upgrade from 4.11.0.0 to 4.11.1.0 & VMWare version to OS mappings (#2490)

[dahn]

This is an automated email from the ASF dual-hosted git repository.

dahn pushed a commit to branch 4.11
in repository https://gitbox.apache.org/repos/asf/cloudstack.git


The following commit(s) were added to refs/heads/4.11 by this push:
 new 6b6b382  Create database upgrade from 4.11.0.0 to 4.11.1.0 & VMWare 
version to OS mappings (#2490)
6b6b382 is described below

commit 6b6b3824aabaa9b3d7add62ac7c173b8c7634325
Author: ernjvr 
AuthorDate: Tue Apr 10 10:25:43 2018 +0200

Create database upgrade from 4.11.0.0 to 4.11.1.0 & VMWare version to OS 
mappings (#2490)

* Create database upgrade from 4.11.0.0 to 4.11.1.0. Add missing VMWare 
version to OS mapping SQL in the schema-41100to41110.sql.

* add unit test and add 4.11.0.0 entry to _upgradeMap
---
 .../META-INF/db/schema-41100to41110-cleanup.sql|  20 
 .../resources/META-INF/db/schema-41100to41110.sql  |  81 +
 .../com/cloud/upgrade/DatabaseUpgradeChecker.java  | 130 -
 .../com/cloud/upgrade/dao/Upgrade41100to41110.java |  69 +++
 .../cloud/upgrade/DatabaseUpgradeCheckerTest.java  |  23 
 5 files changed, 265 insertions(+), 58 deletions(-)

diff --git 
a/engine/schema/resources/META-INF/db/schema-41100to41110-cleanup.sql 
b/engine/schema/resources/META-INF/db/schema-41100to41110-cleanup.sql
new file mode 100644
index 000..704c71e
--- /dev/null
+++ b/engine/schema/resources/META-INF/db/schema-41100to41110-cleanup.sql
@@ -0,0 +1,20 @@
+-- Licensed to the Apache Software Foundation (ASF) under one
+-- or more contributor license agreements.  See the NOTICE file
+-- distributed with this work for additional information
+-- regarding copyright ownership.  The ASF licenses this file
+-- to you under the Apache License, Version 2.0 (the
+-- "License"); you may not use this file except in compliance
+-- with the License.  You may obtain a copy of the License at
+--
+--   http://www.apache.org/licenses/LICENSE-2.0
+--
+-- Unless required by applicable law or agreed to in writing,
+-- software distributed under the License is distributed on an
+-- "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+-- KIND, either express or implied.  See the License for the
+-- specific language governing permissions and limitations
+-- under the License.
+
+--;
+-- Schema upgrade from 4.11.0.0 to 4.11.1.0
+--;
\ No newline at end of file
diff --git a/engine/schema/resources/META-INF/db/schema-41100to41110.sql 
b/engine/schema/resources/META-INF/db/schema-41100to41110.sql
new file mode 100644
index 000..03e76c5
--- /dev/null
+++ b/engine/schema/resources/META-INF/db/schema-41100to41110.sql
@@ -0,0 +1,81 @@
+-- Licensed to the Apache Software Foundation (ASF) under one
+-- or more contributor license agreements.  See the NOTICE file
+-- distributed with this work for additional information
+-- regarding copyright ownership.  The ASF licenses this file
+-- to you under the Apache License, Version 2.0 (the
+-- "License"); you may not use this file except in compliance
+-- with the License.  You may obtain a copy of the License at
+--
+--   http://www.apache.org/licenses/LICENSE-2.0
+--
+-- Unless required by applicable law or agreed to in writing,
+-- software distributed under the License is distributed on an
+-- "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+-- KIND, either express or implied.  See the License for the
+-- specific language governing permissions and limitations
+-- under the License.
+
+--;
+-- Schema upgrade from 4.11.0.0 to 4.11.1.0
+--;
+
+-- VMWare hypervisor guest OS mappings
+
+DELETE from`cloud`.`guest_os_hypervisor` WHERE guest_os_id='269' AND 
hypervisor_version = '6.0' AND hypervisor_type='VMware';
+DELETE from`cloud`.`guest_os_hypervisor` WHERE guest_os_id='270' AND 
hypervisor_version = '6.0' AND hypervisor_type='VMware';
+
+INSERT IGNORE INTO `cloud`.`guest_os_hypervisor` (uuid, hypervisor_type, 
hypervisor_version, guest_os_name, guest_os_id, created, is_user_defined) 
VALUES (UUID(), 'VMware', '5.0', 'debian6_64Guest', 133, now(), 0);
+INSERT IGNORE INTO `cloud`.`guest_os_hypervisor` (uuid, hypervisor_type, 
hypervisor_version, guest_os_name, guest_os_id, created, is_user_defined) 
VALUES (UUID(), 'VMware', '5.0', 'debian6Guest', 132, now(), 0);
+INSERT IGNORE INTO `cloud`.`guest_os_hypervisor` (uuid, hypervisor_type, 
hypervisor_version, guest_os_name, guest_os_id, created, is_user_defined) 
VALUES (UUID(), 'VMware', '5.1', 'centosGuest', 171, now(), 0);
+INSERT IGNORE INTO `cloud`.`guest_os_hypervisor` (uuid, hypervisor_type, 
hypervisor_version, guest_os_name, guest_os_id, created, is_user_defined) 
VALUES (UUID(), 'VMware', '5.1', 'centosGuest', 179, now(), 0);
+INSERT IGNORE INTO `cloud`.`guest_os_hypervisor` (uuid, hypervisor_type, 
hypervisor_version, guest_os_name, guest_os_id, created, is_user_defined) 
VALUES (UUID(), 'VMware', '5.1', 'debian6_64Guest', 133, now(), 0);
+INSERT IGNORE INTO `cloud`.`guest_os_hypervisor` 

[GitHub] DaanHoogland closed pull request #2490: Create database upgrade from 4.11.0.0 to 4.11.1.0 & VMWare version to OS mappings

[GitBox]

DaanHoogland closed pull request #2490: Create database upgrade from 4.11.0.0 
to 4.11.1.0 & VMWare version to OS mappings
URL: https://github.com/apache/cloudstack/pull/2490
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/engine/schema/resources/META-INF/db/schema-41100to41110-cleanup.sql 
b/engine/schema/resources/META-INF/db/schema-41100to41110-cleanup.sql
new file mode 100644
index 000..704c71e659b
--- /dev/null
+++ b/engine/schema/resources/META-INF/db/schema-41100to41110-cleanup.sql
@@ -0,0 +1,20 @@
+-- Licensed to the Apache Software Foundation (ASF) under one
+-- or more contributor license agreements.  See the NOTICE file
+-- distributed with this work for additional information
+-- regarding copyright ownership.  The ASF licenses this file
+-- to you under the Apache License, Version 2.0 (the
+-- "License"); you may not use this file except in compliance
+-- with the License.  You may obtain a copy of the License at
+--
+--   http://www.apache.org/licenses/LICENSE-2.0
+--
+-- Unless required by applicable law or agreed to in writing,
+-- software distributed under the License is distributed on an
+-- "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+-- KIND, either express or implied.  See the License for the
+-- specific language governing permissions and limitations
+-- under the License.
+
+--;
+-- Schema upgrade from 4.11.0.0 to 4.11.1.0
+--;
\ No newline at end of file
diff --git a/engine/schema/resources/META-INF/db/schema-41100to41110.sql 
b/engine/schema/resources/META-INF/db/schema-41100to41110.sql
new file mode 100644
index 000..03e76c510c5
--- /dev/null
+++ b/engine/schema/resources/META-INF/db/schema-41100to41110.sql
@@ -0,0 +1,81 @@
+-- Licensed to the Apache Software Foundation (ASF) under one
+-- or more contributor license agreements.  See the NOTICE file
+-- distributed with this work for additional information
+-- regarding copyright ownership.  The ASF licenses this file
+-- to you under the Apache License, Version 2.0 (the
+-- "License"); you may not use this file except in compliance
+-- with the License.  You may obtain a copy of the License at
+--
+--   http://www.apache.org/licenses/LICENSE-2.0
+--
+-- Unless required by applicable law or agreed to in writing,
+-- software distributed under the License is distributed on an
+-- "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+-- KIND, either express or implied.  See the License for the
+-- specific language governing permissions and limitations
+-- under the License.
+
+--;
+-- Schema upgrade from 4.11.0.0 to 4.11.1.0
+--;
+
+-- VMWare hypervisor guest OS mappings
+
+DELETE from`cloud`.`guest_os_hypervisor` WHERE guest_os_id='269' AND 
hypervisor_version = '6.0' AND hypervisor_type='VMware';
+DELETE from`cloud`.`guest_os_hypervisor` WHERE guest_os_id='270' AND 
hypervisor_version = '6.0' AND hypervisor_type='VMware';
+
+INSERT IGNORE INTO `cloud`.`guest_os_hypervisor` (uuid, hypervisor_type, 
hypervisor_version, guest_os_name, guest_os_id, created, is_user_defined) 
VALUES (UUID(), 'VMware', '5.0', 'debian6_64Guest', 133, now(), 0);
+INSERT IGNORE INTO `cloud`.`guest_os_hypervisor` (uuid, hypervisor_type, 
hypervisor_version, guest_os_name, guest_os_id, created, is_user_defined) 
VALUES (UUID(), 'VMware', '5.0', 'debian6Guest', 132, now(), 0);
+INSERT IGNORE INTO `cloud`.`guest_os_hypervisor` (uuid, hypervisor_type, 
hypervisor_version, guest_os_name, guest_os_id, created, is_user_defined) 
VALUES (UUID(), 'VMware', '5.1', 'centosGuest', 171, now(), 0);
+INSERT IGNORE INTO `cloud`.`guest_os_hypervisor` (uuid, hypervisor_type, 
hypervisor_version, guest_os_name, guest_os_id, created, is_user_defined) 
VALUES (UUID(), 'VMware', '5.1', 'centosGuest', 179, now(), 0);
+INSERT IGNORE INTO `cloud`.`guest_os_hypervisor` (uuid, hypervisor_type, 
hypervisor_version, guest_os_name, guest_os_id, created, is_user_defined) 
VALUES (UUID(), 'VMware', '5.1', 'debian6_64Guest', 133, now(), 0);
+INSERT IGNORE INTO `cloud`.`guest_os_hypervisor` (uuid, hypervisor_type, 
hypervisor_version, guest_os_name, guest_os_id, created, is_user_defined) 
VALUES (UUID(), 'VMware', '5.1', 'debian6Guest', 132, now(), 0);
+INSERT IGNORE INTO `cloud`.`guest_os_hypervisor` (uuid, hypervisor_type, 
hypervisor_version, guest_os_name, guest_os_id, created, is_user_defined) 
VALUES (UUID(), 'VMware', '5.1', 'debian7_64Guest', 184, now(), 0);
+INSERT IGNORE INTO `cloud`.`guest_os_hypervisor` (uuid, hypervisor_type, 
hypervisor_version, guest_os_name, guest_os_id, created, is_user_defined) 
VALUES (UUID(), 'VMware', '5.5', 'centos6Guest', 171, now(), 0);
+INSERT IGNORE INTO `cloud`.`guest_os_hypervisor` (uuid, hypervisor_type, 
hypervisor_version, guest_os_name, guest_os_id, created, 

[GitHub] blueorangutan commented on issue #2404: [CLOUDSTACK-10230] User should not be able to use removed “Guest OS type”

[GitBox]

blueorangutan commented on issue #2404: [CLOUDSTACK-10230] User should not be 
able to use removed “Guest OS type”
URL: https://github.com/apache/cloudstack/pull/2404#issuecomment-380007025
 
 
   @borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has 
been kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] borisstoyanov commented on issue #2404: [CLOUDSTACK-10230] User should not be able to use removed “Guest OS type”

[GitBox]

borisstoyanov commented on issue #2404: [CLOUDSTACK-10230] User should not be 
able to use removed “Guest OS type”
URL: https://github.com/apache/cloudstack/pull/2404#issuecomment-380006706
 
 
   @blueorangutan test


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2486: [CLOUDSTACK-10323] Allow changing disk offering during volume migration

[GitBox]

blueorangutan commented on issue #2486: [CLOUDSTACK-10323] Allow changing disk 
offering during volume migration 
URL: https://github.com/apache/cloudstack/pull/2486#issuecomment-379994394
 
 
   @borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has 
been kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] borisstoyanov commented on issue #2486: [CLOUDSTACK-10323] Allow changing disk offering during volume migration

[GitBox]

borisstoyanov commented on issue #2486: [CLOUDSTACK-10323] Allow changing disk 
offering during volume migration 
URL: https://github.com/apache/cloudstack/pull/2486#issuecomment-379994205
 
 
   yup, let me run it again @blueorangutan test 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services