[GitHub] nitin-maharana commented on a change in pull request #2508: CLOUDSTACK-9114: Reduce VR downtime during network restart

[GitBox]

nitin-maharana commented on a change in pull request #2508: CLOUDSTACK-9114: 
Reduce VR downtime during network restart
URL: https://github.com/apache/cloudstack/pull/2508#discussion_r180965420
 
 

 ##
 File path: 
api/src/org/apache/cloudstack/api/command/user/network/RestartNetworkCmd.java
 ##
 @@ -57,6 +57,9 @@
 @Parameter(name = ApiConstants.CLEANUP, type = CommandType.BOOLEAN, 
required = false, description = "If cleanup old network elements")
 private Boolean cleanup;
 
+@Parameter(name = ApiConstants.MAKEREDUNDANTE, type = CommandType.BOOLEAN, 
required = false, description = "Turn the network into a network with redundant 
routers.", since = "4.11.1")
 
 Review comment:
   @rhtyd, Thanks for adding this functionality. I think there is a typo in 
ApiConstants name, E at the end. Would be great if we change the name of 
existing name to MAKE_REDUNDANT, I just checked the usage is also very less.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] nitin-maharana commented on a change in pull request #2508: CLOUDSTACK-9114: Reduce VR downtime during network restart

[GitBox]

nitin-maharana commented on a change in pull request #2508: CLOUDSTACK-9114: 
Reduce VR downtime during network restart
URL: https://github.com/apache/cloudstack/pull/2508#discussion_r180965420
 
 

 ##
 File path: 
api/src/org/apache/cloudstack/api/command/user/network/RestartNetworkCmd.java
 ##
 @@ -57,6 +57,9 @@
 @Parameter(name = ApiConstants.CLEANUP, type = CommandType.BOOLEAN, 
required = false, description = "If cleanup old network elements")
 private Boolean cleanup;
 
+@Parameter(name = ApiConstants.MAKEREDUNDANTE, type = CommandType.BOOLEAN, 
required = false, description = "Turn the network into a network with redundant 
routers.", since = "4.11.1")
 
 Review comment:
   @rhtyd, Thanks for adding this functionality. I think there is a typo in 
ApiConstants name, E at the end. Would be great if we change the name of 
existing name to MAKE_RENDUNDANT, I just checked the usage is also very less.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2563: CLOUDSTACK-10304: turn off apache2 server tokens and signature in systemvms

[GitBox]

rhtyd commented on issue #2563: CLOUDSTACK-10304: turn off apache2 server 
tokens and signature in systemvms
URL: https://github.com/apache/cloudstack/pull/2563#issuecomment-380608955
 
 
   @blueorangutan test 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2563: CLOUDSTACK-10304: turn off apache2 server tokens and signature in systemvms

[GitBox]

blueorangutan commented on issue #2563: CLOUDSTACK-10304: turn off apache2 
server tokens and signature in systemvms
URL: https://github.com/apache/cloudstack/pull/2563#issuecomment-380609114
 
 
   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been 
kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2563: CLOUDSTACK-10304: turn off apache2 server tokens and signature in systemvms

[GitBox]

blueorangutan commented on issue #2563: CLOUDSTACK-10304: turn off apache2 
server tokens and signature in systemvms
URL: https://github.com/apache/cloudstack/pull/2563#issuecomment-380607397
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1906


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd closed issue #2546: Libvirt-bin has trouble starting if -d is stated in /etc/default/libvirt-bin (libvirtd_opts)

[GitBox]

rhtyd closed issue #2546: Libvirt-bin has trouble starting if -d is stated in 
/etc/default/libvirt-bin (libvirtd_opts)
URL: https://github.com/apache/cloudstack/issues/2546
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2546: Libvirt-bin has trouble starting if -d is stated in /etc/default/libvirt-bin (libvirtd_opts)

[GitBox]

rhtyd commented on issue #2546: Libvirt-bin has trouble starting if -d is 
stated in /etc/default/libvirt-bin (libvirtd_opts)
URL: https://github.com/apache/cloudstack/issues/2546#issuecomment-380601228
 
 
   Fixed in #2550 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2563: systemvm: turn off apache2 server tokens and signature

[GitBox]

blueorangutan commented on issue #2563: systemvm: turn off apache2 server 
tokens and signature
URL: https://github.com/apache/cloudstack/pull/2563#issuecomment-380600764
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd opened a new pull request #2563: systemvm: turn off apache2 server tokens and signature

[GitBox]

rhtyd opened a new pull request #2563: systemvm: turn off apache2 server tokens 
and signature
URL: https://github.com/apache/cloudstack/pull/2563
 
 
   This turns off apache2 server version signature/token in headers.
   
   
   
   
   ## Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [ ] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ## How Has This Been Tested?
   
   This is after the fix, apache version is not seen in http response/headers:
   ```
   > curl -I http://192.168.1.50
   HTTP/1.1 403 Forbidden
   Date: Wed, 11 Apr 2018 21:24:38 GMT
   Server: Apache
   Content-Type: text/html; charset=iso-8859-1
   
   ```
   
   
   
   
   ## Checklist:
   
   
   - [ ] I have read the 
[CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md)
 document.
   - [ ] My code follows the code style of this project.
   - [ ] My change requires a change to the documentation.
   - [ ] I have updated the documentation accordingly.
   Testing
   - [ ] I have added tests to cover my changes.
   - [ ] All relevant new and existing integration tests have passed.
   - [ ] A full integration testsuite with all test that can run on my 
environment has passed.
   
   
   @blueorangutan package
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] khos2ow commented on issue #2561: cloud-early-config detects unknown hypervisor type "xen-domU"

[GitBox]

khos2ow commented on issue #2561: cloud-early-config detects unknown hypervisor 
type "xen-domU"
URL: https://github.com/apache/cloudstack/issues/2561#issuecomment-380557349
 
 
   I've found a rather interesting, potential problem, on this. Hypervisor 
detection has been changed in bb96564, `virt-what` executed prior to check from 
`/proc/xen` or in my change at 535e615 to read from `dmesg`.
   
   I just tested executing virt-what on both PV and HVM vms on my environment 
(Xen 7.1.1 and 7.1.0) and I'm getting conflicting results from `virt-what` 
(needs more investigation) but I believe we need to read from `/proc/xen` and 
`dmesg` prior to `virt-what`.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2562: consoleproxy: use consoleproxy.domain for non-ssl enable env

[GitBox]

blueorangutan commented on issue #2562: consoleproxy: use consoleproxy.domain 
for non-ssl enable env
URL: https://github.com/apache/cloudstack/pull/2562#issuecomment-380542853
 
 
   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been 
kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2562: consoleproxy: use consoleproxy.domain for non-ssl enable env

[GitBox]

rhtyd commented on issue #2562: consoleproxy: use consoleproxy.domain for 
non-ssl enable env
URL: https://github.com/apache/cloudstack/pull/2562#issuecomment-380542589
 
 
   @blueorangutan test


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2562: consoleproxy: use consoleproxy.domain for non-ssl enable env

[GitBox]

blueorangutan commented on issue #2562: consoleproxy: use consoleproxy.domain 
for non-ssl enable env
URL: https://github.com/apache/cloudstack/pull/2562#issuecomment-380539285
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1905


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2561: cloud-early-config detects unknown hypervisor type "xen-domU"

[GitBox]

rhtyd commented on issue #2561: cloud-early-config detects unknown hypervisor 
type "xen-domU"
URL: https://github.com/apache/cloudstack/issues/2561#issuecomment-380534342
 
 
   @rafaelweingartner yes, as others has pointed out we use the `router.xxx` to 
specify the systemvmtemplate name which gets used for all the systemvms (cpvm, 
ssvm, routers etc)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rafaelweingartner commented on issue #2561: cloud-early-config detects unknown hypervisor type "xen-domU"

[GitBox]

rafaelweingartner commented on issue #2561: cloud-early-config detects unknown 
hypervisor type "xen-domU"
URL: https://github.com/apache/cloudstack/issues/2561#issuecomment-380532790
 
 
   @khos2ow ah... that might work because you change the type to system in the 
database. However, that might not be a sure thing. If you take a look into 
`com.cloud.consoleproxy.ConsoleProxyManagerImpl.startNew(long)`  and 
`org.apache.cloudstack.secondarystorage.SecondaryStorageManagerImpl.startNew(long,
 Role)`. You will see that they do not look into that router parameter.
   
   Those methods simply use the method 
`com.cloud.storage.dao.VMTemplateDaoImpl.findSystemVMReadyTemplate(long, 
HypervisorType) `, which only looks for the first template it find. 
   
   That is one of the reason for PR: #2275 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rafaelweingartner commented on issue #2561: cloud-early-config detects unknown hypervisor type "xen-domU"

[GitBox]

rafaelweingartner commented on issue #2561: cloud-early-config detects unknown 
hypervisor type "xen-domU"
URL: https://github.com/apache/cloudstack/issues/2561#issuecomment-380532790
 
 
   @khos2ow ah... that might work because you change the type to system in the 
database. However, that might not be a sure thing. If you take a look into 
`com.cloud.consoleproxy.ConsoleProxyManagerImpl.startNew(long)`  and 
`org.apache.cloudstack.secondarystorage.SecondaryStorageManagerImpl.startNew(long,
 Role)`. You will see that it does not look into that router parameter.
   
   Those methods simply use the method 
`com.cloud.storage.dao.VMTemplateDaoImpl.findSystemVMReadyTemplate(long, 
HypervisorType) `, which only looks for the first template it find. 
   
   That is one of the reason for PR: #2275 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2562: consoleproxy: use consoleproxy.domain for non-ssl enable env

[GitBox]

blueorangutan commented on issue #2562: consoleproxy: use consoleproxy.domain 
for non-ssl enable env
URL: https://github.com/apache/cloudstack/pull/2562#issuecomment-380531657
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2562: consoleproxy: use consoleproxy.domain for non-ssl enable env

[GitBox]

blueorangutan commented on issue #2562: consoleproxy: use consoleproxy.domain 
for non-ssl enable env
URL: https://github.com/apache/cloudstack/pull/2562#issuecomment-380521312
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1904


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2562: consoleproxy: use consoleproxy.domain for non-ssl enable env

[GitBox]

rhtyd commented on issue #2562: consoleproxy: use consoleproxy.domain for 
non-ssl enable env
URL: https://github.com/apache/cloudstack/pull/2562#issuecomment-380531353
 
 
   @blueorangutan package
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] khos2ow commented on issue #2561: cloud-early-config detects unknown hypervisor type "xen-domU"

[GitBox]

khos2ow commented on issue #2561: cloud-early-config detects unknown hypervisor 
type "xen-domU"
URL: https://github.com/apache/cloudstack/issues/2561#issuecomment-380530741
 
 
   Well, that's how we upgrade our systemvm templates when required.
   
   - add new template from ui
   - change its `type` to `SYSTEM` (in db)
   - update current running SSVM and CPVM to use this new template (in db)
   - change `router.template.xenserver` to use this new template (in db)
   - restart mgmt server and destroy VMs to be spun up with new template


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2562: consoleproxy: use consoleproxy.domain for non-ssl enable env

[GitBox]

blueorangutan commented on issue #2562: consoleproxy: use consoleproxy.domain 
for non-ssl enable env
URL: https://github.com/apache/cloudstack/pull/2562#issuecomment-380521312
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1904


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] khos2ow commented on issue #2561: cloud-early-config detects unknown hypervisor type "xen-domU"

[GitBox]

khos2ow commented on issue #2561: cloud-early-config detects unknown hypervisor 
type "xen-domU"
URL: https://github.com/apache/cloudstack/issues/2561#issuecomment-380516091
 
 
   @MartinEmrich afaik you should never use `cloud-install-sys-tmplt` after the 
first installation was done, it will mess up ssh key inside systemvm template 
and result in management server cannot _talk_ to system vms.
   
   @rafaelweingartner yes it does, SSVM, CPVM work as is (with the process 
@rhtyd  mentioned above) and VR gets to use the same new template through 
`router.template.xenserver` setting.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rafaelweingartner commented on issue #2561: cloud-early-config detects unknown hypervisor type "xen-domU"

[GitBox]

rafaelweingartner commented on issue #2561: cloud-early-config detects unknown 
hypervisor type "xen-domU"
URL: https://github.com/apache/cloudstack/issues/2561#issuecomment-380516710
 
 
   I am pretty sure it does not they get the systemvm.iso injected (if this 
is the only thing that matter to you), but I think the execution flow is 
different when it comes on selecting the template.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rafaelweingartner commented on issue #2561: cloud-early-config detects unknown hypervisor type "xen-domU"

[GitBox]

rafaelweingartner commented on issue #2561: cloud-early-config detects unknown 
hypervisor type "xen-domU"
URL: https://github.com/apache/cloudstack/issues/2561#issuecomment-380516710
 
 
   I am pretty sure it does not they get the systemvm.iso injected (if this 
is the only thing that matter to you), but I think the execution flow is 
different when it comes on selecting the hypervisor.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] khos2ow commented on issue #2561: cloud-early-config detects unknown hypervisor type "xen-domU"

[GitBox]

khos2ow commented on issue #2561: cloud-early-config detects unknown hypervisor 
type "xen-domU"
URL: https://github.com/apache/cloudstack/issues/2561#issuecomment-380516091
 
 
   @MartinEmrich afaik you should never use `cloud-install-sys-tmplt` after the 
first installation was done, it will mess up ssh key inside systemvm template 
and result management server cannot _talk_ to system vms.
   
   @rafaelweingartner yes it does, SSVM, CPVM work as is (with the process 
@rhtyd  mentioned above) and VR gets to use the same new template through 
`router.template.xenserver` setting.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] khos2ow commented on issue #2561: cloud-early-config detects unknown hypervisor type "xen-domU"

[GitBox]

khos2ow commented on issue #2561: cloud-early-config detects unknown hypervisor 
type "xen-domU"
URL: https://github.com/apache/cloudstack/issues/2561#issuecomment-380514982
 
 
   @rhtyd this specific change doesn't require a new systemvm template and will 
be deployed on systemvms using `systemvm.iso`.
   
   @MartinEmrich the file `/opt/cloud/bin/setup/cloud-early-config` is the 
source file and you need to check if it's actually correctly updated in 
`/etc/init.d/cloud-early-config`.
   
   I'll have to look to see what's going on with `/usr/bin` and `/usr/sbin`.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rafaelweingartner commented on issue #2561: cloud-early-config detects unknown hypervisor type "xen-domU"

[GitBox]

rafaelweingartner commented on issue #2561: cloud-early-config detects unknown 
hypervisor type "xen-domU"
URL: https://github.com/apache/cloudstack/issues/2561#issuecomment-380514125
 
 
   @rhtyd does it work for SSVM and console proxy?  I was under the impression 
that this would only change the template for routers.
   
   There is this PR to enable customizing system VMs template here: 
https://github.com/apache/cloudstack/pull/2275


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2562: consoleproxy: use consoleproxy.domain for non-ssl enable env

[GitBox]

blueorangutan commented on issue #2562: consoleproxy: use consoleproxy.domain 
for non-ssl enable env
URL: https://github.com/apache/cloudstack/pull/2562#issuecomment-380513957
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd opened a new pull request #2562: consoleproxy: use consoleproxy.domain for non-ssl enable env

[GitBox]

rhtyd opened a new pull request #2562: consoleproxy: use consoleproxy.domain 
for non-ssl enable env
URL: https://github.com/apache/cloudstack/pull/2562
 
 
   This allows CloudStack to use a console proxy domain instead of public
   IP address even when ssl is not enabled but console proxy url/domain
   is defined in global settings.
   
   This allows use of domain url for console proxy endpoint, without needing to 
have
   SSL certificates setup.
   
   
   
   
   ## Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [ ] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ## Screenshots (if appropriate):
   
   ## How Has This Been Tested?
   
   
   
   
   
   ## Checklist:
   
   
   - [ ] I have read the 
[CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md)
 document.
   - [ ] My code follows the code style of this project.
   - [ ] My change requires a change to the documentation.
   - [ ] I have updated the documentation accordingly.
   Testing
   - [ ] I have added tests to cover my changes.
   - [ ] All relevant new and existing integration tests have passed.
   - [ ] A full integration testsuite with all test that can run on my 
environment has passed.
   
   
   @blueorangutan package
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2561: cloud-early-config detects unknown hypervisor type "xen-domU"

[GitBox]

rhtyd commented on issue #2561: cloud-early-config detects unknown hypervisor 
type "xen-domU"
URL: https://github.com/apache/cloudstack/issues/2561#issuecomment-380513137
 
 
   @MartinEmrich You register a template like you normally do, give it a name 
and change bunch of global settings, such as `router.template.xenserver` to the 
new template's name, in the db in the vm_template details set type=SYSTEM. Btw 
I've the new 4.11 templates here: 
https://lab.yadav.cloud/systemvmtemplates/4.11/


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2486: [CLOUDSTACK-10323] Allow changing disk offering during volume migration

[GitBox]

blueorangutan commented on issue #2486: [CLOUDSTACK-10323] Allow changing disk 
offering during volume migration 
URL: https://github.com/apache/cloudstack/pull/2486#issuecomment-380504152
 
 
   Trillian test result (tid-2488)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 97660 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2486-t2488-kvm-centos7.zip
   Intermitten failure detected: /marvin/tests/smoke/test_certauthority_root.py
   Intermitten failure detected: /marvin/tests/smoke/test_primary_storage.py
   Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
   Intermitten failure detected: /marvin/tests/smoke/test_routers.py
   Intermitten failure detected: /marvin/tests/smoke/test_snapshots.py
   Intermitten failure detected: /marvin/tests/smoke/test_ssvm.py
   Intermitten failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
   Intermitten failure detected: /marvin/tests/smoke/test_host_maintenance.py
   Intermitten failure detected: /marvin/tests/smoke/test_hostha_kvm.py
   Smoke tests completed. 61 look OK, 6 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_01_add_primary_storage_disabled_host | `Error` | 0.74 | 
test_primary_storage.py
   test_01_primary_storage_nfs | `Error` | 0.12 | test_primary_storage.py
   ContextSuite context=TestStorageTags>:setup | `Error` | 0.21 | 
test_primary_storage.py
   test_04_restart_network_wo_cleanup | `Failure` | 4.11 | test_routers.py
   test_02_list_snapshots_with_removed_data_store | `Error` | 1.16 | 
test_snapshots.py
   test_08_migrate_vm | `Error` | 18.91 | test_vm_life_cycle.py
   test_01_cancel_host_maintenace_with_no_migration_jobs | `Failure` | 1.14 | 
test_host_maintenance.py
   test_02_cancel_host_maintenace_with_migration_jobs | `Error` | 2.31 | 
test_host_maintenance.py
   test_hostha_enable_ha_when_host_in_maintenance | `Error` | 1.56 | 
test_hostha_kvm.py
   test_hostha_kvm_host_degraded | `Failure` | 1503.52 | test_hostha_kvm.py
   test_hostha_kvm_host_fencing | `Failure` | 619.78 | test_hostha_kvm.py
   test_hostha_kvm_host_recovering | `Failure` | 621.92 | test_hostha_kvm.py
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] MartinEmrich commented on issue #2561: cloud-early-config detects unknown hypervisor type "xen-domU"

[GitBox]

MartinEmrich commented on issue #2561: cloud-early-config detects unknown 
hypervisor type "xen-domU"
URL: https://github.com/apache/cloudstack/issues/2561#issuecomment-380491619
 
 
   I built the new systemvm, but I have issues installing it:
   During a previous update from 4.9.2.0 to 4.11.0, I installed the new 
systemvm via UI as "systemvm-xenserver-4.11". This maps to 
/secondary/templates/tmpl/2/204.
   Using `cloud-install-sys-tmplt` installs it into /secondary/templates/1/204. 
   Newly created system vms use "systemvm-xenserver-4.11" (still the old one), 
which cannot be deleted. What's the safe way to replace a current systemvm 
template with the same version?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2502: [CLOUDSTACK-10352] XenServer: Support online migration of a virtual disk from non-managed to managed storage

[GitBox]

blueorangutan commented on issue #2502: [CLOUDSTACK-10352] XenServer: Support 
online migration of a virtual disk from non-managed to managed storage
URL: https://github.com/apache/cloudstack/pull/2502#issuecomment-380489540
 
 
   Trillian test result (tid-2486)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 95304 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2502-t2486-kvm-centos7.zip
   Intermitten failure detected: /marvin/tests/smoke/test_certauthority_root.py
   Intermitten failure detected: /marvin/tests/smoke/test_routers.py
   Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Intermitten failure detected: /marvin/tests/smoke/test_hostha_kvm.py
   Smoke tests completed. 64 look OK, 3 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_04_restart_network_wo_cleanup | `Failure` | 3.04 | test_routers.py
   test_04_rvpc_network_garbage_collector_nics | `Failure` | 525.86 | 
test_vpc_redundant.py
   test_hostha_enable_ha_when_host_in_maintenance | `Error` | 3.60 | 
test_hostha_kvm.py
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] khos2ow commented on a change in pull request #2557: Add "Fixes: number" to PR template for auto-closing issues

[GitBox]

khos2ow commented on a change in pull request #2557: Add "Fixes: number" to PR 
template for auto-closing issues
URL: https://github.com/apache/cloudstack/pull/2557#discussion_r180791250
 
 

 ##
 File path: PULL_REQUEST_TEMPLATE.md
 ##
 @@ -12,6 +12,12 @@
 - [ ] Enhancement (improves an existing feature and functionality)
 - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
 
+
+
+
 
 Review comment:
   That's true! Although the correct syntax would be `Fixes #..., Fixes #..., 
...`. The keyword needs to be specified before number everytime 
([reference](https://help.github.com/articles/closing-issues-using-keywords/#closing-multiple-issues)).


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2404: [CLOUDSTACK-10230] User should not be able to use removed “Guest OS type”

[GitBox]

blueorangutan commented on issue #2404: [CLOUDSTACK-10230] User should not be 
able to use removed “Guest OS type”
URL: https://github.com/apache/cloudstack/pull/2404#issuecomment-380467249
 
 
   Trillian test result (tid-2484)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 91748 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2404-t2484-kvm-centos7.zip
   Intermitten failure detected: /marvin/tests/smoke/test_certauthority_root.py
   Intermitten failure detected: /marvin/tests/smoke/test_routers.py
   Intermitten failure detected: /marvin/tests/smoke/test_hostha_kvm.py
   Smoke tests completed. 65 look OK, 2 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_04_restart_network_wo_cleanup | `Failure` | 2.96 | test_routers.py
   test_hostha_enable_ha_when_host_in_maintenance | `Error` | 4.70 | 
test_hostha_kvm.py
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2559: Upgrade path 4.11 through 4.11.1 to 4.12

[GitBox]

blueorangutan commented on issue #2559: Upgrade path 4.11 through 4.11.1 to 4.12
URL: https://github.com/apache/cloudstack/pull/2559#issuecomment-380443017
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1903


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] MartinEmrich commented on issue #2561: cloud-early-config detects unknown hypervisor type "xen-domU"

[GitBox]

MartinEmrich commented on issue #2561: cloud-early-config detects unknown 
hypervisor type "xen-domU"
URL: https://github.com/apache/cloudstack/issues/2561#issuecomment-380437332
 
 
   @rhtyd Thanks for the hint, a new systemvm image is building, too, right now 
(No KVM in VirtualBox, so I removed "accelerator":"kvm" from the packer config 
and it will probably take ages...
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2559: Upgrade path 4.11 through 4.11.1 to 4.12

[GitBox]

blueorangutan commented on issue #2559: Upgrade path 4.11 through 4.11.1 to 4.12
URL: https://github.com/apache/cloudstack/pull/2559#issuecomment-380435398
 
 
   @borisstoyanov a Jenkins job has been kicked to build packages. I'll keep 
you posted as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] borisstoyanov commented on issue #2559: Upgrade path 4.11 through 4.11.1 to 4.12

[GitBox]

borisstoyanov commented on issue #2559: Upgrade path 4.11 through 4.11.1 to 4.12
URL: https://github.com/apache/cloudstack/pull/2559#issuecomment-380435160
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2505: CLOUDSTACK-10333: Secure Live VM Migration for KVM

[GitBox]

blueorangutan commented on issue #2505: CLOUDSTACK-10333: Secure Live VM 
Migration for KVM
URL: https://github.com/apache/cloudstack/pull/2505#issuecomment-380429185
 
 
   @borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has 
been kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] borisstoyanov commented on issue #2505: CLOUDSTACK-10333: Secure Live VM Migration for KVM

[GitBox]

borisstoyanov commented on issue #2505: CLOUDSTACK-10333: Secure Live VM 
Migration for KVM
URL: https://github.com/apache/cloudstack/pull/2505#issuecomment-380428948
 
 
   @blueorangutan test


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2561: cloud-early-config detects unknown hypervisor type "xen-domU"

[GitBox]

rhtyd commented on issue #2561: cloud-early-config detects unknown hypervisor 
type "xen-domU"
URL: https://github.com/apache/cloudstack/issues/2561#issuecomment-380425651
 
 
   @MartinEmrich the 4.11.0.0 systemvmtemplate cannot be used with 
4.11.1.0-SNAPSHOT. There was a commit from @khos2ow that changed the xenserver 
pv vs hvm detection, this happens in cloud-early-config script that cannot be 
simply patched. I'll update 4.11.1.0 systemvmtemplate in next few weeks.
   
   @khos2ow can you comment on the /usr/bin, /usr/sbin path change?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2561: cloud-early-config detects unknown hypervisor type "xen-domU"

[GitBox]

rhtyd commented on issue #2561: cloud-early-config detects unknown hypervisor 
type "xen-domU"
URL: https://github.com/apache/cloudstack/issues/2561#issuecomment-380425651
 
 
   @MartinEmrich the 4.11.0.0 systemvmtemplate cannot be used with 
4.11.1.0-SNAPSHOT. There was a commit from @khos2ow that changed the xenserver 
pv vs hvm detection, this happens in cloud-early-config script that cannot be 
simply patched. I'll update 4.11.1.0 systemvmtemplate in next few weeks.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2505: CLOUDSTACK-10333: Secure Live VM Migration for KVM

[GitBox]

blueorangutan commented on issue #2505: CLOUDSTACK-10333: Secure Live VM 
Migration for KVM
URL: https://github.com/apache/cloudstack/pull/2505#issuecomment-380420402
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1902


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] MartinEmrich opened a new issue #2561: cloud-early-config detects unknown hypervisor type "xen-domU"

[GitBox]

MartinEmrich opened a new issue #2561: cloud-early-config detects unknown 
hypervisor type "xen-domU"
URL: https://github.com/apache/cloudstack/issues/2561
 
 
   # ISSUE TYPE
* Bug Report
   
   # COMPONENT NAME
   systemVM image 4.11 for XenServer
   ~~~
   
   ~~~
   
   # CLOUDSTACK VERSION
   4.11.0 as well as 4.11.1 git from today.
   SystemVM: 4.11.0 Sun Jan 14 15:37:28 UTC 2018
   ~~~
   
   ~~~
   
   # CONFIGURATION
   XenServer 6.5 SP1
   
   
   # OS / ENVIRONMENT
   Management Server on CentOS 7.
   SystemVMs running as "Debian 9.3" in HVM mode.
   
   
   # SUMMARY
   Newly created system VMs are not configured, cloud.log reports "systemvm 
type=" (nothing else).
   
   the `/opt/cloud/bin/setup/cloud-early-config` script tries to detect the 
hypervisor type, there are cases for "xen-pv" and "xen-hvm". But it uses 
"virt-what", which returns the unknown type "xen-domU".
   
   After applying these fixes...
   
   * add "xen-domU" to the "xen-hvm" case
   * changing the path to xenstore-read from /usr/sbin to /usr/bin
   
   and rebooting, the SystemVM comes up correctly.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] nitin-maharana commented on a change in pull request #2559: Upgrade path 4.11 through 4.11.1 to 4.12

[GitBox]

nitin-maharana commented on a change in pull request #2559: Upgrade path 4.11 
through 4.11.1 to 4.12
URL: https://github.com/apache/cloudstack/pull/2559#discussion_r180719535
 
 

 ##
 File path: 
engine/schema/src/test/java/com/cloud/upgrade/DatabaseUpgradeCheckerTest.java
 ##
 @@ -74,6 +77,30 @@ public void testCalculateUpgradePath490to4910() {
 
 }
 
+@Test
+public void testCalculateUpgradePath410to412() {
+
+final CloudStackVersion dbVersion = 
CloudStackVersion.parse("4.10.0.0");
+assertNotNull(dbVersion);
+
+final CloudStackVersion currentVersion = 
CloudStackVersion.parse("4.12.0.0");
+assertNotNull(currentVersion);
+
+final DatabaseUpgradeChecker checker = new DatabaseUpgradeChecker();
+final DbUpgrade[] upgrades = checker.calculateUpgradePath(dbVersion, 
currentVersion);
+
+assertNotNull(upgrades);
+assertTrue(upgrades.length >= 1);
+assertTrue(upgrades[0] instanceof Upgrade41000to41100);
+assertTrue(upgrades[1] instanceof Upgrade41100to41110);
+assertTrue(upgrades[2] instanceof Upgrade41110to41200);
+
+assertTrue(Arrays.equals(new String[] { "4.11.0.0", "4.11.1.0"},
 
 Review comment:
   @DaanHoogland, I think, Similarly we could add for upgrades[0] as well.
   
   assertTrue(Arrays.equals(new String[] { "4.10.0.0", "4.11.0.0"}, 
upgrades[0].getUpgradableVersionRange()));


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rafaelweingartner commented on a change in pull request #2557: Add "Fixes: number" to PR template for auto-closing issues

[GitBox]

rafaelweingartner commented on a change in pull request #2557: Add "Fixes: 
number" to PR template for auto-closing issues
URL: https://github.com/apache/cloudstack/pull/2557#discussion_r180718794
 
 

 ##
 File path: PULL_REQUEST_TEMPLATE.md
 ##
 @@ -12,6 +12,12 @@
 - [ ] Enhancement (improves an existing feature and functionality)
 - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
 
+
+
+
 
 Review comment:
   Can I suggest one other thing? What about changing `## GitHub Issue` to `## 
GitHub Issues/PRs`
   Then, you could use: 
   ```
   
   
   ```
   
   
   A PR can also be used to close (address) other PRs' topic and issues at the 
same time.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rafaelweingartner commented on a change in pull request #2557: Add "Fixes: number" to PR template for auto-closing issues

[GitBox]

rafaelweingartner commented on a change in pull request #2557: Add "Fixes: 
number" to PR template for auto-closing issues
URL: https://github.com/apache/cloudstack/pull/2557#discussion_r180718794
 
 

 ##
 File path: PULL_REQUEST_TEMPLATE.md
 ##
 @@ -12,6 +12,12 @@
 - [ ] Enhancement (improves an existing feature and functionality)
 - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
 
+
+
+
 
 Review comment:
   Can I suggest one other thing? What about changing `## GitHub Issue` to `## 
GitHub Issues/PRs`
   Then, you could use: 
   ```
   
   
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2505: CLOUDSTACK-10333: Secure Live VM Migration for KVM

[GitBox]

rhtyd commented on issue #2505: CLOUDSTACK-10333: Secure Live VM Migration for 
KVM
URL: https://github.com/apache/cloudstack/pull/2505#issuecomment-380414753
 
 
   Okay @borisstoyanov 
   All - please hold merging this, I may include some keystore related changes 
reported in recent issues.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] borisstoyanov commented on issue #2559: Upgrade path 4.11 through 4.11.1 to 4.12

[GitBox]

borisstoyanov commented on issue #2559: Upgrade path 4.11 through 4.11.1 to 4.12
URL: https://github.com/apache/cloudstack/pull/2559#issuecomment-380414826
 
 
   @DaanHoogland let me do a quick upgrade test. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2505: CLOUDSTACK-10333: Secure Live VM Migration for KVM

[GitBox]

blueorangutan commented on issue #2505: CLOUDSTACK-10333: Secure Live VM 
Migration for KVM
URL: https://github.com/apache/cloudstack/pull/2505#issuecomment-380414312
 
 
   @borisstoyanov a Jenkins job has been kicked to build packages. I'll keep 
you posted as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] borisstoyanov commented on issue #2505: CLOUDSTACK-10333: Secure Live VM Migration for KVM

[GitBox]

borisstoyanov commented on issue #2505: CLOUDSTACK-10333: Secure Live VM 
Migration for KVM
URL: https://github.com/apache/cloudstack/pull/2505#issuecomment-380414080
 
 
   I've resolved the conflict, let me run tests again @rhtyd 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2376: [4.11] Smoketest Health Check

[GitBox]

blueorangutan commented on issue #2376: [4.11] Smoketest Health Check
URL: https://github.com/apache/cloudstack/pull/2376#issuecomment-380386417
 
 
   @rhtyd a Trillian-Jenkins matrix job (centos6 mgmt + xs71, centos7 mgmt + 
vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2376: [4.11] Smoketest Health Check

[GitBox]

rhtyd commented on issue #2376: [4.11] Smoketest Health Check
URL: https://github.com/apache/cloudstack/pull/2376#issuecomment-380386351
 
 
   @blueorangutan test matrix 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2376: [4.11] Smoketest Health Check

[GitBox]

blueorangutan commented on issue #2376: [4.11] Smoketest Health Check
URL: https://github.com/apache/cloudstack/pull/2376#issuecomment-380386107
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1901


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2550: debian: Use only `-l` for libvirtd default file on debian

[GitBox]

blueorangutan commented on issue #2550: debian: Use only `-l` for libvirtd 
default file on debian
URL: https://github.com/apache/cloudstack/pull/2550#issuecomment-380385904
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1900


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2376: [4.11] Smoketest Health Check

[GitBox]

blueorangutan commented on issue #2376: [4.11] Smoketest Health Check
URL: https://github.com/apache/cloudstack/pull/2376#issuecomment-380375072
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2376: [4.11] Smoketest Health Check

[GitBox]

rhtyd commented on issue #2376: [4.11] Smoketest Health Check
URL: https://github.com/apache/cloudstack/pull/2376#issuecomment-380374950
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2550: debian: Use only `-l` for libvirtd default file on debian

[GitBox]

blueorangutan commented on issue #2550: debian: Use only `-l` for libvirtd 
default file on debian
URL: https://github.com/apache/cloudstack/pull/2550#issuecomment-380374248
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2550: debian: Use only `-l` for libvirtd default file on debian

[GitBox]

blueorangutan commented on issue #2550: debian: Use only `-l` for libvirtd 
default file on debian
URL: https://github.com/apache/cloudstack/pull/2550#issuecomment-380076518
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd closed pull request #2550: debian: Use only `-l` for libvirtd default file on debian

[GitBox]

rhtyd closed pull request #2550: debian: Use only `-l` for libvirtd default 
file on debian
URL: https://github.com/apache/cloudstack/pull/2550
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/python/lib/cloud_utils.py b/python/lib/cloud_utils.py
index 43c93c87631..a9afb04dd8e 100644
--- a/python/lib/cloud_utils.py
+++ b/python/lib/cloud_utils.py
@@ -759,7 +759,7 @@ def execute(self):
if os.path.exists("/etc/init/libvirt-bin.conf"):
replace_line("/etc/init/libvirt-bin.conf", 
"exec /usr/sbin/libvirtd","exec /usr/sbin/libvirtd -d -l")
else:
-   
replace_or_add_line("/etc/default/libvirt-bin","libvirtd_opts=","libvirtd_opts='-l
 -d'")
+   
replace_or_add_line("/etc/default/libvirt-bin","libvirtd_opts=","libvirtd_opts='-l'")

else:
raise AssertionError("Unsupported distribution")
diff --git a/python/lib/cloudutils/serviceConfig.py 
b/python/lib/cloudutils/serviceConfig.py
index c9c019c5abe..68d1b9cef5b 100755
--- a/python/lib/cloudutils/serviceConfig.py
+++ b/python/lib/cloudutils/serviceConfig.py
@@ -526,9 +526,12 @@ def setupLiveMigration(self):
 if os.path.exists("/etc/init/libvirt-bin.conf"):
 cfo = configFileOps("/etc/init/libvirt-bin.conf", self)
 cfo.replace_line("exec /usr/sbin/libvirtd","exec 
/usr/sbin/libvirtd -d -l")
-else:
+elif os.path.exists("/etc/default/libvirt-bin"):
 cfo = configFileOps("/etc/default/libvirt-bin", self)
-cfo.replace_or_add_line("libvirtd_opts=","libvirtd_opts='-l -d'")
+cfo.replace_or_add_line("libvirtd_opts=","libvirtd_opts='-l'")
+elif os.path.exists("/etc/default/libvirtd"):
+cfo = configFileOps("/etc/default/libvirtd", self)
+cfo.replace_or_add_line("libvirtd_opts=","libvirtd_opts='-l'")
 
 def config(self):
 try:


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[cloudstack] branch 4.11 updated: debian: Use only `-l` for libvirtd default file on debian (#2550)

[rohit]

This is an automated email from the ASF dual-hosted git repository.

rohit pushed a commit to branch 4.11
in repository https://gitbox.apache.org/repos/asf/cloudstack.git


The following commit(s) were added to refs/heads/4.11 by this push:
 new ea33a35  debian: Use only `-l` for libvirtd default file on debian 
(#2550)
ea33a35 is described below

commit ea33a3529785efea24dbd5dd096cdc9ffb869dd8
Author: Rohit Yadav 
AuthorDate: Wed Apr 11 14:08:57 2018 +0530

debian: Use only `-l` for libvirtd default file on debian (#2550)

This fixes #2546

Signed-off-by: Rohit Yadav 
---
 python/lib/cloud_utils.py  | 2 +-
 python/lib/cloudutils/serviceConfig.py | 7 +--
 2 files changed, 6 insertions(+), 3 deletions(-)

diff --git a/python/lib/cloud_utils.py b/python/lib/cloud_utils.py
index 43c93c8..a9afb04 100644
--- a/python/lib/cloud_utils.py
+++ b/python/lib/cloud_utils.py
@@ -759,7 +759,7 @@ class SetupLiveMigration(ConfigTask):
if os.path.exists("/etc/init/libvirt-bin.conf"):
replace_line("/etc/init/libvirt-bin.conf", 
"exec /usr/sbin/libvirtd","exec /usr/sbin/libvirtd -d -l")
else:
-   
replace_or_add_line("/etc/default/libvirt-bin","libvirtd_opts=","libvirtd_opts='-l
 -d'")
+   
replace_or_add_line("/etc/default/libvirt-bin","libvirtd_opts=","libvirtd_opts='-l'")

else:
raise AssertionError("Unsupported distribution")
diff --git a/python/lib/cloudutils/serviceConfig.py 
b/python/lib/cloudutils/serviceConfig.py
index c9c019c..68d1b9c 100755
--- a/python/lib/cloudutils/serviceConfig.py
+++ b/python/lib/cloudutils/serviceConfig.py
@@ -526,9 +526,12 @@ class libvirtConfigUbuntu(serviceCfgBase):
 if os.path.exists("/etc/init/libvirt-bin.conf"):
 cfo = configFileOps("/etc/init/libvirt-bin.conf", self)
 cfo.replace_line("exec /usr/sbin/libvirtd","exec 
/usr/sbin/libvirtd -d -l")
-else:
+elif os.path.exists("/etc/default/libvirt-bin"):
 cfo = configFileOps("/etc/default/libvirt-bin", self)
-cfo.replace_or_add_line("libvirtd_opts=","libvirtd_opts='-l -d'")
+cfo.replace_or_add_line("libvirtd_opts=","libvirtd_opts='-l'")
+elif os.path.exists("/etc/default/libvirtd"):
+cfo = configFileOps("/etc/default/libvirtd", self)
+cfo.replace_or_add_line("libvirtd_opts=","libvirtd_opts='-l'")
 
 def config(self):
 try:

-- 
To stop receiving notification emails like this one, please contact
ro...@apache.org.

[GitHub] blueorangutan commented on issue #2550: debian: Use only `-l` for libvirtd default file on debian

[GitBox]

blueorangutan commented on issue #2550: debian: Use only `-l` for libvirtd 
default file on debian
URL: https://github.com/apache/cloudstack/pull/2550#issuecomment-380085295
 
 
   Packaging result: ✔centos6 ✖centos7 ✔debian. JID-1897


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2499: Updates to capacity management

[GitBox]

blueorangutan commented on issue #2499: Updates to capacity management
URL: https://github.com/apache/cloudstack/pull/2499#issuecomment-380373414
 
 
   @borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has 
been kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] borisstoyanov commented on issue #2499: Updates to capacity management

[GitBox]

borisstoyanov commented on issue #2499: Updates to capacity management
URL: https://github.com/apache/cloudstack/pull/2499#issuecomment-380373099
 
 
   @blueorangutan test


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] DaanHoogland commented on a change in pull request #2559: Upgrade path 4.11 through 4.11.1 to 4.12

[GitBox]

DaanHoogland commented on a change in pull request #2559: Upgrade path 4.11 
through 4.11.1 to 4.12
URL: https://github.com/apache/cloudstack/pull/2559#discussion_r180662555
 
 

 ##
 File path: 
engine/schema/src/test/java/com/cloud/upgrade/DatabaseUpgradeCheckerTest.java
 ##
 @@ -74,6 +75,28 @@ public void testCalculateUpgradePath490to4910() {
 
 }
 
+@Test
 
 Review comment:
   I think it adds more value to expand the 4.10 to end up at 4.12 in this case.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] DaanHoogland commented on a change in pull request #2559: Upgrade path 4.11 through 4.11.1 to 4.12

[GitBox]

DaanHoogland commented on a change in pull request #2559: Upgrade path 4.11 
through 4.11.1 to 4.12
URL: https://github.com/apache/cloudstack/pull/2559#discussion_r180662358
 
 

 ##
 File path: 
engine/schema/src/main/resources/META-INF/db/schema-41100to41110-cleanup.sql
 ##
 @@ -16,5 +16,5 @@
 -- under the License.
 
 --;
--- Schema upgrade cleanup from 4.11.0.0 to 4.12.0.0
+-- Schema upgrade from 4.11.0.0 to 4.11.1.0
 
 Review comment:
   will do


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2499: Updates to capacity management

[GitBox]

blueorangutan commented on issue #2499: Updates to capacity management
URL: https://github.com/apache/cloudstack/pull/2499#issuecomment-380359724
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1899


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] DaanHoogland commented on issue #2560: ui: Make zonal dashboard larger

[GitBox]

DaanHoogland commented on issue #2560: ui: Make zonal dashboard larger
URL: https://github.com/apache/cloudstack/pull/2560#issuecomment-380357856
 
 
   yes, @rafaelweingartner makes sense. #2559 needs to go first. 
@nitin-maharana had some comments on it, i'll address them this morning.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] borisstoyanov commented on issue #2390: [CLOUDSTACK-10214] Unable to remove local primary storage

[GitBox]

borisstoyanov commented on issue #2390: [CLOUDSTACK-10214] Unable to remove 
local primary storage
URL: https://github.com/apache/cloudstack/pull/2390#issuecomment-380353613
 
 
   @blueorangutan test


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2390: [CLOUDSTACK-10214] Unable to remove local primary storage

[GitBox]

blueorangutan commented on issue #2390: [CLOUDSTACK-10214] Unable to remove 
local primary storage
URL: https://github.com/apache/cloudstack/pull/2390#issuecomment-380353647
 
 
   @borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has 
been kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2499: Updates to capacity management

[GitBox]

blueorangutan commented on issue #2499: Updates to capacity management
URL: https://github.com/apache/cloudstack/pull/2499#issuecomment-380353094
 
 
   @borisstoyanov a Jenkins job has been kicked to build packages. I'll keep 
you posted as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] borisstoyanov commented on issue #2499: Updates to capacity management

[GitBox]

borisstoyanov commented on issue #2499: Updates to capacity management
URL: https://github.com/apache/cloudstack/pull/2499#issuecomment-380352857
 
 
   Thanks fro the integration test @mike-tutkowski, let me repackage and run 
them again
   @blueorangutan package 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services