[GitHub] rafaelweingartner opened a new pull request #2607: Allow changing disk offering of VMs' root volume

2018-04-26 Thread GitBox
rafaelweingartner opened a new pull request #2607: Allow changing disk offering of VMs' root volume URL: https://github.com/apache/cloudstack/pull/2607 ## Description Currently, users are not able to change the disk offering of VMs' root volumes. It might be interesting to allow

[GitHub] rafaelweingartner commented on a change in pull request #2486: [CLOUDSTACK-10323] Allow changing disk offering during volume migration

2018-04-26 Thread GitBox
rafaelweingartner commented on a change in pull request #2486: [CLOUDSTACK-10323] Allow changing disk offering during volume migration URL: https://github.com/apache/cloudstack/pull/2486#discussion_r184533044 ## File path:

[GitHub] GabrielBrascher commented on a change in pull request #2486: [CLOUDSTACK-10323] Allow changing disk offering during volume migration

2018-04-26 Thread GitBox
GabrielBrascher commented on a change in pull request #2486: [CLOUDSTACK-10323] Allow changing disk offering during volume migration URL: https://github.com/apache/cloudstack/pull/2486#discussion_r184524300 ## File path:

[GitHub] GabrielBrascher commented on a change in pull request #2486: [CLOUDSTACK-10323] Allow changing disk offering during volume migration

2018-04-26 Thread GitBox
GabrielBrascher commented on a change in pull request #2486: [CLOUDSTACK-10323] Allow changing disk offering during volume migration URL: https://github.com/apache/cloudstack/pull/2486#discussion_r184505828 ## File path:

[GitHub] GabrielBrascher commented on issue #2275: CLOUDSTACK-9975: Allow customizing system VM templates for SSVM and Console Proxy

2018-04-26 Thread GitBox
GabrielBrascher commented on issue #2275: CLOUDSTACK-9975: Allow customizing system VM templates for SSVM and Console Proxy URL: https://github.com/apache/cloudstack/pull/2275#issuecomment-384776794 Hi @rhtyd, sorry for the delay on this one. Unfortunately, that parameter

[GitHub] GabrielBrascher commented on issue #2275: CLOUDSTACK-9975: Allow customizing system VM templates for SSVM and Console Proxy

2018-04-26 Thread GitBox
GabrielBrascher commented on issue #2275: CLOUDSTACK-9975: Allow customizing system VM templates for SSVM and Console Proxy URL: https://github.com/apache/cloudstack/pull/2275#issuecomment-384776794 Hi @rhtyd, sorry for the delay on this one. Unfortunately, that parameter (“”)

[GitHub] GabrielBrascher commented on issue #2275: CLOUDSTACK-9975: Allow customizing system VM templates for SSVM and Console Proxy

2018-04-26 Thread GitBox
GabrielBrascher commented on issue #2275: CLOUDSTACK-9975: Allow customizing system VM templates for SSVM and Console Proxy URL: https://github.com/apache/cloudstack/pull/2275#issuecomment-384776794 Hi @rhtyd, sorry for the delay on this one. Unfortunately, without this proposal, it

[GitHub] GabrielBrascher commented on issue #2275: CLOUDSTACK-9975: Allow customizing system VM templates for SSVM and Console Proxy

2018-04-26 Thread GitBox
GabrielBrascher commented on issue #2275: CLOUDSTACK-9975: Allow customizing system VM templates for SSVM and Console Proxy URL: https://github.com/apache/cloudstack/pull/2275#issuecomment-384776794 Hi @rhtyd, sorry for the delay on this one. Unfortunately, it does change only router

[GitHub] blueorangutan commented on issue #2605: xenserver: Add support for XS 7.3, 7.4 and XCP-ng 7.4

2018-04-26 Thread GitBox
blueorangutan commented on issue #2605: xenserver: Add support for XS 7.3, 7.4 and XCP-ng 7.4 URL: https://github.com/apache/cloudstack/pull/2605#issuecomment-384775661 Trillian test result (tid-2539) Environment: xenserver-74 (x2), Advanced Networking with Mgmt server 7 Total time

[GitHub] GabrielBrascher commented on issue #1709: CLOUDSTACK-7982: KVM live migration with local storage

2018-04-26 Thread GitBox
GabrielBrascher commented on issue #1709: CLOUDSTACK-7982: KVM live migration with local storage URL: https://github.com/apache/cloudstack/pull/1709#issuecomment-384764252 @marcaurele Do you need any help with this PR? Please ping me if necessary.

[GitHub] rafaelweingartner commented on a change in pull request #2606: When creating a new account (via domain admin) it is possible to select “root admin” as the role for the new user

2018-04-26 Thread GitBox
rafaelweingartner commented on a change in pull request #2606: When creating a new account (via domain admin) it is possible to select “root admin” as the role for the new user URL: https://github.com/apache/cloudstack/pull/2606#discussion_r184505772 ## File path:

[GitHub] nitin-maharana commented on a change in pull request #2606: When creating a new account (via domain admin) it is possible to select “root admin” as the role for the new user

2018-04-26 Thread GitBox
nitin-maharana commented on a change in pull request #2606: When creating a new account (via domain admin) it is possible to select “root admin” as the role for the new user URL: https://github.com/apache/cloudstack/pull/2606#discussion_r184453195 ## File path:

[GitHub] pdube commented on issue #2412: CLOUDSTACK-9677: Adding storage policy support for swift as secondary…

2018-04-26 Thread GitBox
pdube commented on issue #2412: CLOUDSTACK-9677: Adding storage policy support for swift as secondary… URL: https://github.com/apache/cloudstack/pull/2412#issuecomment-384691609 Thanks @khos2ow This is an automated message

[GitHub] rafaelweingartner commented on issue #2382: CLOUDSTACK-4045 IP address acquired with associateIpAddress is marked as source NAT

2018-04-26 Thread GitBox
rafaelweingartner commented on issue #2382: CLOUDSTACK-4045 IP address acquired with associateIpAddress is marked as source NAT URL: https://github.com/apache/cloudstack/pull/2382#issuecomment-384644724 @DaanHoogland are you happy with the tests result? Or, would you like to execute them

[GitHub] rafaelweingartner commented on issue #2382: CLOUDSTACK-4045 IP address acquired with associateIpAddress is marked as source NAT

2018-04-26 Thread GitBox
rafaelweingartner commented on issue #2382: CLOUDSTACK-4045 IP address acquired with associateIpAddress is marked as source NAT URL: https://github.com/apache/cloudstack/pull/2382#issuecomment-384644414 @blueorangutan package.

[GitHub] rafaelweingartner commented on a change in pull request #2382: CLOUDSTACK-4045 IP address acquired with associateIpAddress is marked as source NAT

2018-04-26 Thread GitBox
rafaelweingartner commented on a change in pull request #2382: CLOUDSTACK-4045 IP address acquired with associateIpAddress is marked as source NAT URL: https://github.com/apache/cloudstack/pull/2382#discussion_r184392158 ## File path:

[GitHub] rafaelweingartner commented on a change in pull request #2399: CLOUDSTACK-10223 delete snapshots when deleting domain

2018-04-26 Thread GitBox
rafaelweingartner commented on a change in pull request #2399: CLOUDSTACK-10223 delete snapshots when deleting domain URL: https://github.com/apache/cloudstack/pull/2399#discussion_r184390757 ## File path: server/src/main/java/com/cloud/storage/snapshot/SnapshotManagerImpl.java

[GitHub] BruceKuiLiu commented on issue #2599: CLOUDSTACK-10363: Change method names.

2018-04-26 Thread GitBox
BruceKuiLiu commented on issue #2599: CLOUDSTACK-10363: Change method names. URL: https://github.com/apache/cloudstack/pull/2599#issuecomment-384642781 @rafaelweingartner Thanks. This is an automated message from the Apache

[cloudstack] branch master updated: [CLOUDSTACK-10254] checkstyle: add package name declaration validation (#2422)

2018-04-26 Thread rafael
This is an automated email from the ASF dual-hosted git repository. rafael pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/master by this push: new 46bd94c [CLOUDSTACK-10254] checkstyle: add

[GitHub] rafaelweingartner closed pull request #2422: [CLOUDSTACK-10254] checkstyle: add package name declaration validation

2018-04-26 Thread GitBox
rafaelweingartner closed pull request #2422: [CLOUDSTACK-10254] checkstyle: add package name declaration validation URL: https://github.com/apache/cloudstack/pull/2422 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the

[GitHub] rafaelweingartner commented on a change in pull request #2503: Support multiple volume access groups per compute cluster

2018-04-26 Thread GitBox
rafaelweingartner commented on a change in pull request #2503: Support multiple volume access groups per compute cluster URL: https://github.com/apache/cloudstack/pull/2503#discussion_r184387941 ## File path:

[GitHub] BruceKuiLiu opened a new pull request #2600: CLOUDSTACK-10362: Change the "getXXX" method names to "isXXX".

2018-04-26 Thread GitBox
BruceKuiLiu opened a new pull request #2600: CLOUDSTACK-10362: Change the "getXXX" method names to "isXXX". URL: https://github.com/apache/cloudstack/pull/2600 These Boolean-return methods are named "getXXX", but other Boolean-return methods are named "isXXX", such as the following two

[GitHub] rafaelweingartner commented on issue #2536: fix typo c bug in externalId feature UI

2018-04-26 Thread GitBox
rafaelweingartner commented on issue #2536: fix typo c bug in externalId feature UI URL: https://github.com/apache/cloudstack/pull/2536#issuecomment-384639663 @rhtyd Do we really need a screenshot here? Looking at the code it is clear the problem and how it was fixed. What do you

[GitHub] BruceKuiLiu opened a new pull request #2601: CLOUDSTACK-10364: Change the "setXXX" method names to "getXXX".

2018-04-26 Thread GitBox
BruceKuiLiu opened a new pull request #2601: CLOUDSTACK-10364: Change the "setXXX" method names to "getXXX". URL: https://github.com/apache/cloudstack/pull/2601 The two methods are named as "setXXX", actually, they are not setter but getter. Thus, they should be renamed as "getXXX".

[GitHub] BruceKuiLiu opened a new pull request #2602: CLOUDSTACK-10365: Change the "getXXX" boolean-related method names to…

2018-04-26 Thread GitBox
BruceKuiLiu opened a new pull request #2602: CLOUDSTACK-10365: Change the "getXXX" boolean-related method names to… URL: https://github.com/apache/cloudstack/pull/2602 … "isXXX". These boolean-return methods are named as "getXXX". Other boolean-return methods are named as

[GitHub] rafaelweingartner commented on issue #2599: CLOUDSTACK-10362, CLOUDSTACK-10363, CLOUDSTACK-10364, CLOUDSTACK-10365 Change method names.

2018-04-26 Thread GitBox
rafaelweingartner commented on issue #2599: CLOUDSTACK-10362, CLOUDSTACK-10363, CLOUDSTACK-10364, CLOUDSTACK-10365 Change method names. URL: https://github.com/apache/cloudstack/pull/2599#issuecomment-384638539 @BruceKuiLiu even though everything seems to be ok here, I actually likes the

[cloudstack] branch master updated (4c42aaf -> b3c22df)

2018-04-26 Thread rafael
This is an automated email from the ASF dual-hosted git repository. rafael pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git. from 4c42aaf [CLOUDSTACK-10356] Fix NPE in Cloudstack found with NPEDetector (#2573) add b6d420b

[cloudstack] branch master updated: [CLOUDSTACK-10356] Fix NPE in Cloudstack found with NPEDetector (#2573)

2018-04-26 Thread rafael
This is an automated email from the ASF dual-hosted git repository. rafael pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/master by this push: new 4c42aaf [CLOUDSTACK-10356] Fix NPE in

[GitHub] rafaelweingartner closed pull request #2573: [CLOUDSTACK-10356] Fix NPE in Cloudstack found with NPEDetector

2018-04-26 Thread GitBox
rafaelweingartner closed pull request #2573: [CLOUDSTACK-10356] Fix NPE in Cloudstack found with NPEDetector URL: https://github.com/apache/cloudstack/pull/2573 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake

[GitHub] blueorangutan commented on issue #2606: When creating a new account (via domain admin) it is possible to select “root admin” as the role for the new user

2018-04-26 Thread GitBox
blueorangutan commented on issue #2606: When creating a new account (via domain admin) it is possible to select “root admin” as the role for the new user URL: https://github.com/apache/cloudstack/pull/2606#issuecomment-384605712 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1972

[GitHub] blueorangutan commented on issue #2606: When creating a new account (via domain admin) it is possible to select “root admin” as the role for the new user

2018-04-26 Thread GitBox
blueorangutan commented on issue #2606: When creating a new account (via domain admin) it is possible to select “root admin” as the role for the new user URL: https://github.com/apache/cloudstack/pull/2606#issuecomment-384597882 @DaanHoogland a Jenkins job has been kicked to build

[GitHub] DaanHoogland commented on issue #2606: When creating a new account (via domain admin) it is possible to select “root admin” as the role for the new user

2018-04-26 Thread GitBox
DaanHoogland commented on issue #2606: When creating a new account (via domain admin) it is possible to select “root admin” as the role for the new user URL: https://github.com/apache/cloudstack/pull/2606#issuecomment-384597706 looks good, I will run the tests though. @blueorangutan

[GitHub] rafaelweingartner commented on a change in pull request #2606: When creating a new account (via domain admin) it is possible to select “root admin” as the role for the new user

2018-04-26 Thread GitBox
rafaelweingartner commented on a change in pull request #2606: When creating a new account (via domain admin) it is possible to select “root admin” as the role for the new user URL: https://github.com/apache/cloudstack/pull/2606#discussion_r184344842 ## File path:

[GitHub] DaanHoogland commented on issue #2116: CLOUDSTACK-8959: Option to attach the config drive

2018-04-26 Thread GitBox
DaanHoogland commented on issue #2116: CLOUDSTACK-8959: Option to attach the config drive URL: https://github.com/apache/cloudstack/pull/2116#issuecomment-384590959 @fmaximus did you already incorporate the changes here, maybe except the setting part? In case you did we can close this

[GitHub] nitin-maharana commented on a change in pull request #2606: When creating a new account (via domain admin) it is possible to select “root admin” as the role for the new user

2018-04-26 Thread GitBox
nitin-maharana commented on a change in pull request #2606: When creating a new account (via domain admin) it is possible to select “root admin” as the role for the new user URL: https://github.com/apache/cloudstack/pull/2606#discussion_r184332395 ## File path:

[GitHub] resmo commented on issue #2091: CLOUDSTACK-8609: [VMware] VM is not accessible after migration across clusters

2018-04-26 Thread GitBox
resmo commented on issue #2091: CLOUDSTACK-8609: [VMware] VM is not accessible after migration across clusters URL: https://github.com/apache/cloudstack/pull/2091#issuecomment-384573516 I would like to see this in 4.11.1 @rhtyd

[GitHub] blueorangutan commented on issue #2605: xenserver: Add support for XS 7.3, 7.4 and XCP-ng 7.4

2018-04-26 Thread GitBox
blueorangutan commented on issue #2605: xenserver: Add support for XS 7.3, 7.4 and XCP-ng 7.4 URL: https://github.com/apache/cloudstack/pull/2605#issuecomment-384536663 Trillian test result (tid-2535) Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7 Total time