blueorangutan commented on issue #2673: Fix test_configdrive.py and
test_nuage_configdrive
URL: https://github.com/apache/cloudstack/pull/2673#issuecomment-391951708
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been
kicked to run smoke tests
rhtyd commented on issue #2673: Fix test_configdrive.py and
test_nuage_configdrive
URL: https://github.com/apache/cloudstack/pull/2673#issuecomment-391951561
@blueorangutan test centos7 kvm-centos7 component/test_configdrive.py
--
blueorangutan commented on issue #2674: Create unit test cases for
'ConfigDriveBuilder' class
URL: https://github.com/apache/cloudstack/pull/2674#issuecomment-391951236
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been
kicked to run smoke tests
-
blueorangutan commented on issue #2673: Fix test_configdrive.py and
test_nuage_configdrive
URL: https://github.com/apache/cloudstack/pull/2673#issuecomment-391951232
@rhtyd I understand these words: "help", "hello", "thanks", "package", "test"
Test command usage: test [mgmt os] [hypervis
rhtyd commented on issue #2673: Fix test_configdrive.py and
test_nuage_configdrive
URL: https://github.com/apache/cloudstack/pull/2673#issuecomment-391951190
@blueorangutan help
This is an automated message from the Apache Gi
rhtyd commented on issue #2674: Create unit test cases for 'ConfigDriveBuilder'
class
URL: https://github.com/apache/cloudstack/pull/2674#issuecomment-391951091
@blueorangutan test
This is an automated message from the Apache
rafaelweingartner commented on a change in pull request #2674: Create unit test
cases for 'ConfigDriveBuilder' class
URL: https://github.com/apache/cloudstack/pull/2674#discussion_r190768820
##
File path:
engine/storage/configdrive/src/org/apache/cloudstack/storage/configdrive/Conf
GabrielBrascher commented on a change in pull request #2674: Create unit test
cases for 'ConfigDriveBuilder' class
URL: https://github.com/apache/cloudstack/pull/2674#discussion_r190764087
##
File path:
engine/storage/configdrive/src/org/apache/cloudstack/storage/configdrive/Config
blueorangutan commented on issue #2674: Create unit test cases for
'ConfigDriveBuilder' class
URL: https://github.com/apache/cloudstack/pull/2674#issuecomment-391827541
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2087
Th
blueorangutan commented on issue #2672: CLOUDSTACK-10377: Fix Network restart
for Nuage
URL: https://github.com/apache/cloudstack/pull/2672#issuecomment-391824723
Trillian test result (tid-2710)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 25
blueorangutan commented on issue #2674: Create unit test cases for
'ConfigDriveBuilder' class
URL: https://github.com/apache/cloudstack/pull/2674#issuecomment-391818411
@rafaelweingartner a Jenkins job has been kicked to build packages. I'll
keep you posted as I make progress.
---
rafaelweingartner commented on issue #2674: Create unit test cases for
'ConfigDriveBuilder' class
URL: https://github.com/apache/cloudstack/pull/2674#issuecomment-391818275
@blueorangutan package
This is an automated message
rafaelweingartner commented on issue #2674: Create unit test cases for
'ConfigDriveBuilder' class
URL: https://github.com/apache/cloudstack/pull/2674#issuecomment-391776552
@rhtyd and @DaanHoogland and finally Jenkins is Green!
--
rafaelweingartner commented on issue #2674: Create unit test cases for
'ConfigDriveBuilder' class
URL: https://github.com/apache/cloudstack/pull/2674#issuecomment-391743061
@khos2ow I am also fixing that
`MockServerTest.testIsMockServerCanUpgradeConnectionToSsl()`.
--
rafaelweingartner commented on a change in pull request #2674: Create unit test
cases for 'ConfigDriveBuilder' class
URL: https://github.com/apache/cloudstack/pull/2674#discussion_r190580669
##
File path:
engine/storage/configdrive/src/org/apache/cloudstack/storage/configdrive/Conf
DaanHoogland commented on a change in pull request #2674: Create unit test
cases for 'ConfigDriveBuilder' class
URL: https://github.com/apache/cloudstack/pull/2674#discussion_r190580025
##
File path:
engine/storage/configdrive/src/org/apache/cloudstack/storage/configdrive/ConfigDri
rafaelweingartner commented on a change in pull request #2674: Create unit test
cases for 'ConfigDriveBuilder' class
URL: https://github.com/apache/cloudstack/pull/2674#discussion_r190578350
##
File path:
engine/storage/configdrive/src/org/apache/cloudstack/storage/configdrive/Conf
rafaelweingartner commented on a change in pull request #2674: Create unit test
cases for 'ConfigDriveBuilder' class
URL: https://github.com/apache/cloudstack/pull/2674#discussion_r190577524
##
File path:
engine/storage/configdrive/src/org/apache/cloudstack/storage/configdrive/Conf
DaanHoogland commented on a change in pull request #2674: Create unit test
cases for 'ConfigDriveBuilder' class
URL: https://github.com/apache/cloudstack/pull/2674#discussion_r190571861
##
File path:
engine/storage/configdrive/src/org/apache/cloudstack/storage/configdrive/ConfigDri
DaanHoogland commented on a change in pull request #2674: Create unit test
cases for 'ConfigDriveBuilder' class
URL: https://github.com/apache/cloudstack/pull/2674#discussion_r190553310
##
File path:
engine/storage/configdrive/src/org/apache/cloudstack/storage/configdrive/ConfigDri
blueorangutan commented on issue #2376: [4.11] Smoketest Health Check
URL: https://github.com/apache/cloudstack/pull/2376#issuecomment-391700911
Trillian test result (tid-2705)
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 72005 seconds
Mar
blueorangutan commented on issue #2674: Create unit test cases for
'ConfigDriveBuilder' class
URL: https://github.com/apache/cloudstack/pull/2674#issuecomment-391690795
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2086
Th
rafaelweingartner commented on issue #2674: Create unit test cases for
'ConfigDriveBuilder' class
URL: https://github.com/apache/cloudstack/pull/2674#issuecomment-391684905
That is interesting. I am used to do the opposite. I only restrict
something, when I want this behavior. Otherwise, I
rafaelweingartner commented on issue #2674: Create unit test cases for
'ConfigDriveBuilder' class
URL: https://github.com/apache/cloudstack/pull/2674#issuecomment-391684905
That is interesting. I used to do the opposite. I only restrict something,
when I want this behavior. Otherwise, I le
rhtyd commented on issue #2674: Create unit test cases for 'ConfigDriveBuilder'
class
URL: https://github.com/apache/cloudstack/pull/2674#issuecomment-391683840
@rafaelweingartner I prefer keeping objects open to assignments/change only
if necessary, so I keep adding `final` by default. I'
rhtyd commented on a change in pull request #2674: Create unit test cases for
'ConfigDriveBuilder' class
URL: https://github.com/apache/cloudstack/pull/2674#discussion_r190555046
##
File path:
engine/storage/configdrive/src/org/apache/cloudstack/storage/configdrive/ConfigDriveBuild
rafaelweingartner commented on issue #2674: Create unit test cases for
'ConfigDriveBuilder' class
URL: https://github.com/apache/cloudstack/pull/2674#issuecomment-391683383
ah the `final` keyword. I am quite picky with things that do not seem to add
value to the code.
I can add them ba
rafaelweingartner commented on a change in pull request #2674: Create unit test
cases for 'ConfigDriveBuilder' class
URL: https://github.com/apache/cloudstack/pull/2674#discussion_r190554730
##
File path:
engine/storage/configdrive/src/org/apache/cloudstack/storage/configdrive/Conf
blueorangutan commented on issue #2672: CLOUDSTACK-10377: Fix Network restart
for Nuage
URL: https://github.com/apache/cloudstack/pull/2672#issuecomment-391683196
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been
kicked to run smoke tests
---
rhtyd commented on issue #2672: CLOUDSTACK-10377: Fix Network restart for Nuage
URL: https://github.com/apache/cloudstack/pull/2672#issuecomment-391683187
@blueorangutan test
This is an automated message from the Apache Git Se
rhtyd commented on issue #2672: CLOUDSTACK-10377: Fix Network restart for Nuage
URL: https://github.com/apache/cloudstack/pull/2672#issuecomment-391683134
@blueorangutan package
This is an automated message from the Apache Git
rhtyd commented on issue #2672: CLOUDSTACK-10377: Fix Network restart for Nuage
URL: https://github.com/apache/cloudstack/pull/2672#issuecomment-391683134
@blueorangutan package
This is an automated message from the Apache Git
blueorangutan commented on issue #2674: Create unit test cases for
'ConfigDriveBuilder' class
URL: https://github.com/apache/cloudstack/pull/2674#issuecomment-391682966
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted
as I make progress.
---
rhtyd commented on a change in pull request #2674: Create unit test cases for
'ConfigDriveBuilder' class
URL: https://github.com/apache/cloudstack/pull/2674#discussion_r190554509
##
File path:
engine/storage/configdrive/src/org/apache/cloudstack/storage/configdrive/ConfigDriveBuild
rhtyd commented on issue #2674: Create unit test cases for 'ConfigDriveBuilder'
class
URL: https://github.com/apache/cloudstack/pull/2674#issuecomment-391682919
Thanks @rafaelweingartner - I dislike however getting those `final` removed
:)
@blueorangutan package
---
dhlaluku closed pull request #2675: Remote Diganosis api
URL: https://github.com/apache/cloudstack/pull/2675
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from
rafaelweingartner commented on a change in pull request #2674: Create unit test
cases for 'ConfigDriveBuilder' class
URL: https://github.com/apache/cloudstack/pull/2674#discussion_r190554424
##
File path:
engine/storage/configdrive/src/org/apache/cloudstack/storage/configdrive/Conf
rhtyd commented on a change in pull request #2674: Create unit test cases for
'ConfigDriveBuilder' class
URL: https://github.com/apache/cloudstack/pull/2674#discussion_r190554237
##
File path:
engine/storage/configdrive/src/org/apache/cloudstack/storage/configdrive/ConfigDriveBuild
rhtyd commented on a change in pull request #2674: Create unit test cases for
'ConfigDriveBuilder' class
URL: https://github.com/apache/cloudstack/pull/2674#discussion_r190553845
##
File path:
engine/storage/configdrive/src/org/apache/cloudstack/storage/configdrive/ConfigDriveBuild
dhlaluku opened a new pull request #2675: Remote Diganosis api
URL: https://github.com/apache/cloudstack/pull/2675
## Description
This a new feature for CloudStack to provide functionality for the admin
user to execute network utitlity commands (ping, tracert, arping) directly from
rhtyd commented on a change in pull request #2674: Create unit test cases for
'ConfigDriveBuilder' class
URL: https://github.com/apache/cloudstack/pull/2674#discussion_r190553845
##
File path:
engine/storage/configdrive/src/org/apache/cloudstack/storage/configdrive/ConfigDriveBuild
blueorangutan commented on issue #2672: CLOUDSTACK-10377: Fix Network restart
for Nuage
URL: https://github.com/apache/cloudstack/pull/2672#issuecomment-391681352
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2085
This is
rafaelweingartner opened a new pull request #2674: Create unit test cases for
'ConfigDriveBuilder' class
URL: https://github.com/apache/cloudstack/pull/2674
## Description
## Types of changes
- [ ] Breaking change (fix or feature that would cause existing
func
blueorangutan commented on issue #2673: Fix test_configdrive.py and
test_nuage_configdrive
URL: https://github.com/apache/cloudstack/pull/2673#issuecomment-391679443
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2084
This
DaanHoogland commented on issue #2673: Fix test_configdrive.py and
test_nuage_configdrive
URL: https://github.com/apache/cloudstack/pull/2673#issuecomment-391672388
Fixes: #2671
doesn't it!?
This is an automated message f
rhtyd commented on issue #2672: CLOUDSTACK-10377: Fix Network restart for Nuage
URL: https://github.com/apache/cloudstack/pull/2672#issuecomment-391671353
@blueorangutan package
This is an automated message from the Apache Git
blueorangutan commented on issue #2672: CLOUDSTACK-10377: Fix Network restart
for Nuage
URL: https://github.com/apache/cloudstack/pull/2672#issuecomment-391671396
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted
as I make progress.
-
borisstoyanov commented on issue #2673: Fix test_configdrive.py and
test_nuage_configdrive
URL: https://github.com/apache/cloudstack/pull/2673#issuecomment-391669082
@fmaximus thanks for the fixes, let me see how this behaves in trillian and
will get back to you!
-
borisstoyanov commented on issue #2673: Fix test_configdrive.py and
test_nuage_configdrive
URL: https://github.com/apache/cloudstack/pull/2673#issuecomment-391669128
@blueorangutan package
This is an automated message from th
blueorangutan commented on issue #2673: Fix test_configdrive.py and
test_nuage_configdrive
URL: https://github.com/apache/cloudstack/pull/2673#issuecomment-391669201
@borisstoyanov a Jenkins job has been kicked to build packages. I'll keep
you posted as I make progress.
--
fmaximus opened a new pull request #2673: Fix test_configdrive.py and
test_nuage_configdrive
URL: https://github.com/apache/cloudstack/pull/2673
## Description
Some fixes to the marvin tests were still ongoing, when PR #2566 was merged.
## Types of changes
- [ ] Breakin
blueorangutan commented on issue #2376: [4.11] Smoketest Health Check
URL: https://github.com/apache/cloudstack/pull/2376#issuecomment-391665029
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2083
This is an automated messag
blueorangutan commented on issue #2376: [4.11] Smoketest Health Check
URL: https://github.com/apache/cloudstack/pull/2376#issuecomment-391664720
Trillian test result (tid-2706)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 64632 seconds
Marv
rafaelweingartner commented on issue #2665: configdrive: run unit test only for
Linux
URL: https://github.com/apache/cloudstack/pull/2665#issuecomment-391664144
@DaanHoogland I am almost finished with the complete set of unit tests for
the static methods as you originally designed this cod
rafaelweingartner commented on issue #2671: configdrive testing needs
refactorring
URL: https://github.com/apache/cloudstack/issues/2671#issuecomment-391663174
@wido that is the idea. It might be a good idea to have an "integration"/API
test (those written in python) that calls the API tha
fmaximus opened a new pull request #2672: CLOUDSTACK-10377: Fix Network restart
for Nuage
URL: https://github.com/apache/cloudstack/pull/2672
## Description
Changes in PR #2508 have caused network restart to fail in a Nuage setup,
as the new VR takes the same IP as the old one, an
blueorangutan commented on issue #2376: [4.11] Smoketest Health Check
URL: https://github.com/apache/cloudstack/pull/2376#issuecomment-391658202
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted
as I make progress.
rhtyd commented on issue #2376: [4.11] Smoketest Health Check
URL: https://github.com/apache/cloudstack/pull/2376#issuecomment-391658134
@blueorangutan package
This is an automated message from the Apache Git Service.
To respo
wido commented on issue #2671: configdrive testing needs refactorring
URL: https://github.com/apache/cloudstack/issues/2671#issuecomment-391652584
If we have a proper Mock we do not need a integration test I think
This is an a
DaanHoogland commented on issue #2671: configdrive testing needs refactorring
URL: https://github.com/apache/cloudstack/issues/2671#issuecomment-391646414
as #2665 now mocks the tool, I am wondering if we need an integration style
test still. @rafaelweingartner @wido @fmaximus @mike-tutkows
This is an automated email from the ASF dual-hosted git repository.
paul_a pushed a commit to branch 4.11.1.0-RC20180524T1000
in repository https://gitbox.apache.org/repos/asf/cloudstack.git
commit 5f48487dc62fd1decaabc4ab2a10f549d6c82400
Author: Paul Angus
AuthorDate: Thu May 24 10:00:35 2018 +
This is an automated email from the ASF dual-hosted git repository.
paul_a pushed a change to branch 4.11.1.0-RC20180524T1000
in repository https://gitbox.apache.org/repos/asf/cloudstack.git.
at 5f48487 Updating pom.xml version numbers for release 4.11.1.0
This branch includes the follow
Author: paul_a
Date: Thu May 24 09:10:39 2018
New Revision: 27081
Log:
Committing release candidate artifacts for 4.11.1.0 to dist/dev/cloudstack in
preparation for release vote
Added:
dev/cloudstack/4.11.1.0/apache-cloudstack-4.11.1.0-src.tar.bz2 (with
props)
dev/cloudstack/4.11.1.0/
Author: paul_a
Date: Thu May 24 08:25:34 2018
New Revision: 27080
Log:
Committing release candidate artifacts for 4.11.1.0 to dist/dev/cloudstack in
preparation for release vote
Added:
dev/cloudstack/4.11.1.0/apache-cloudstack-4.11.1.0-src.tar.bz2 (with
props)
dev/cloudstack/4.11.1.0/
Author: paul_a
Date: Thu May 24 08:16:45 2018
New Revision: 27079
Log:
Committing release candidate artifacts for 4.11.1.0 to dist/dev/cloudstack in
preparation for release vote
Added:
dev/cloudstack/4.11.1.0/
dev/cloudstack/4.11.1.0/apache-cloudstack-4.11.1.0-src.tar.bz2 (with
props)
blueorangutan commented on issue #2376: [4.11] Smoketest Health Check
URL: https://github.com/apache/cloudstack/pull/2376#issuecomment-391625245
Packaging result: ✔centos6 ✔centos7 ✖debian. JID-2082
This is an automated messag
DaanHoogland commented on issue #2665: configdrive: run unit test only for Linux
URL: https://github.com/apache/cloudstack/pull/2665#issuecomment-391622534
As for @rhtyd 's comment above, after jenkins passes I will revert the
removal of the test and extract line 350 of ConfigDriveNetworkEl
DaanHoogland commented on issue #2665: configdrive: run unit test only for Linux
URL: https://github.com/apache/cloudstack/pull/2665#issuecomment-391619983
as for running on macos, i think the following might do:
```
diff --git
a/engine/storage/configdrive/src/org/apache/cloudstack/st
blueorangutan commented on issue #2376: [4.11] Smoketest Health Check
URL: https://github.com/apache/cloudstack/pull/2376#issuecomment-391618683
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted
as I make progress.
rhtyd commented on issue #2376: [4.11] Smoketest Health Check
URL: https://github.com/apache/cloudstack/pull/2376#issuecomment-391618563
@blueorangutan package
This is an automated message from the Apache Git Service.
To respo
mike-tutkowski commented on issue #2670: Removing an old, unused NetApp plug-in
URL: https://github.com/apache/cloudstack/pull/2670#issuecomment-391618593
Hi Rohit,
I sent a message to dev@, but not to users@.
I’ll go ahead and forward it to users@ now.
Thanks,
Mike
This is an automated email from the ASF dual-hosted git repository.
rohit pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git.
from 76a4e56 Merge branch '4.11'
add 2fad5be ui: Fixes #2666 conditional template filter (#2669)
new ca17b6
asfgit closed issue #2666: Non-admin User receives an error message when
entering disk offering section of create instance wizard
URL: https://github.com/apache/cloudstack/issues/2666
This is an automated message from the Ap
This is an automated email from the ASF dual-hosted git repository.
rohit pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git
commit ca17b6a126d8842adb750146a3f843e6acbadd04
Merge: 76a4e56 2fad5be
Author: Rohit Yadav
AuthorDate: Thu May 24 13:01:11 2
rhtyd closed pull request #2669: conditional template filter
URL: https://github.com/apache/cloudstack/pull/2669
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (f
This is an automated email from the ASF dual-hosted git repository.
rohit pushed a commit to branch 4.11
in repository https://gitbox.apache.org/repos/asf/cloudstack.git
The following commit(s) were added to refs/heads/4.11 by this push:
new 2fad5be ui: Fixes #2666 conditional template fil
rhtyd commented on issue #2669: conditional template filter
URL: https://github.com/apache/cloudstack/pull/2669#issuecomment-391616976
Merging this based on tests and reviews, counting Paul's LGTM from the
comment.
This is an
DaanHoogland commented on a change in pull request #2665: configdrive: run unit
test only for Linux
URL: https://github.com/apache/cloudstack/pull/2665#discussion_r190486722
##
File path:
server/test/com/cloud/network/element/ConfigDriveNetworkElementTest.java
##
@@ -242,
DaanHoogland commented on issue #2665: configdrive: run unit test only for Linux
URL: https://github.com/apache/cloudstack/pull/2665#issuecomment-391614257
@fmaximus there is a nuage specific config drive test suite. Can you verify
that these tstill pass? And do those all need to be nuage s
rhtyd commented on a change in pull request #2665: configdrive: run unit test
only for Linux
URL: https://github.com/apache/cloudstack/pull/2665#discussion_r190485989
##
File path:
server/test/com/cloud/network/element/ConfigDriveNetworkElementTest.java
##
@@ -242,34 +242
DaanHoogland opened a new issue #2671: configdrive testing needs refactorring
URL: https://github.com/apache/cloudstack/issues/2671
Config drive refactoring has led to an external utility being used in a
unittest for it (genisoimage). This test must be done, however but in an
integrati
81 matches
Mail list logo
