[GitHub] blueorangutan commented on issue #2923: Improved perfomance on creating VM (KVM)
blueorangutan commented on issue #2923: Improved perfomance on creating VM (KVM) URL: https://github.com/apache/cloudstack/pull/2923#issuecomment-432534683 Trillian test result (tid-3112) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 22042 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2923-t3112-kvm-centos7.zip Smoke tests completed. 67 look OK, 0 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[cloudstack] 01/01: Merge remote-tracking branch 'origin/4.11'
This is an automated email from the ASF dual-hosted git repository. rohit pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git commit 8d31024a60cb43cb8b0d3c06ac96d1af09c4d905 Merge: c8ca9e2 e092529 Author: Rohit Yadav AuthorDate: Wed Oct 24 11:08:00 2018 +0530 Merge remote-tracking branch 'origin/4.11' systemvm/debian/etc/systemd/system/cloud-postinit.service | 1 - systemvm/debian/etc/systemd/system/cloud.service | 3 +-- 2 files changed, 1 insertion(+), 3 deletions(-)
[cloudstack] branch master updated (c8ca9e2 -> 8d31024)
This is an automated email from the ASF dual-hosted git repository. rohit pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git. from c8ca9e2 template: create/updateTemplate should allow to set/change sshKeyEnabled (#2922) add e092529 systemvm: Ensure cloud service reboots after failure (#2916) new 8d31024 Merge remote-tracking branch 'origin/4.11' The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: systemvm/debian/etc/systemd/system/cloud-postinit.service | 1 - systemvm/debian/etc/systemd/system/cloud.service | 3 +-- 2 files changed, 1 insertion(+), 3 deletions(-)
[cloudstack] branch master updated: template: create/updateTemplate should allow to set/change sshKeyEnabled (#2922)
This is an automated email from the ASF dual-hosted git repository.
rohit pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git
The following commit(s) were added to refs/heads/master by this push:
new c8ca9e2 template: create/updateTemplate should allow to set/change
sshKeyEnabled (#2922)
c8ca9e2 is described below
commit c8ca9e2fa0774e0909ab700ec170f00934ab7681
Author: Abhishek
AuthorDate: Wed Oct 24 11:07:03 2018 +0530
template: create/updateTemplate should allow to set/change sshKeyEnabled
(#2922)
Added sshKeyEnabled key in createTemplate and updateTemplate API.
Fixes #2822.
Signed-off-by: Abhishek Kumar
---
.../org/apache/cloudstack/api/BaseUpdateTemplateOrIsoCmd.java | 7 +++
.../api/command/user/template/CreateTemplateCmd.java | 7 +++
.../src/main/java/com/cloud/template/TemplateManagerImpl.java | 10 +-
3 files changed, 23 insertions(+), 1 deletion(-)
diff --git
a/api/src/main/java/org/apache/cloudstack/api/BaseUpdateTemplateOrIsoCmd.java
b/api/src/main/java/org/apache/cloudstack/api/BaseUpdateTemplateOrIsoCmd.java
index 3676734..cd7aee7 100644
---
a/api/src/main/java/org/apache/cloudstack/api/BaseUpdateTemplateOrIsoCmd.java
+++
b/api/src/main/java/org/apache/cloudstack/api/BaseUpdateTemplateOrIsoCmd.java
@@ -58,6 +58,9 @@ public abstract class BaseUpdateTemplateOrIsoCmd extends
BaseCmd {
@Parameter(name = ApiConstants.PASSWORD_ENABLED, type =
CommandType.BOOLEAN, description = "true if the image supports the password
reset feature; default is false")
private Boolean passwordEnabled;
+@Parameter(name = ApiConstants.SSHKEY_ENABLED, type = CommandType.BOOLEAN,
description = "true if the template supports the sshkey upload feature; default
is false")
+private Boolean sshKeyEnabled;
+
@Parameter(name = ApiConstants.SORT_KEY, type = CommandType.INTEGER,
description = "sort key of the template, integer")
private Integer sortKey;
@@ -109,6 +112,10 @@ public abstract class BaseUpdateTemplateOrIsoCmd extends
BaseCmd {
return passwordEnabled;
}
+public Boolean isSshKeyEnabled() {
+return sshKeyEnabled;
+}
+
public String getFormat() {
return format;
}
diff --git
a/api/src/main/java/org/apache/cloudstack/api/command/user/template/CreateTemplateCmd.java
b/api/src/main/java/org/apache/cloudstack/api/command/user/template/CreateTemplateCmd.java
index 42f1383..aa8ecee 100644
---
a/api/src/main/java/org/apache/cloudstack/api/command/user/template/CreateTemplateCmd.java
+++
b/api/src/main/java/org/apache/cloudstack/api/command/user/template/CreateTemplateCmd.java
@@ -92,6 +92,9 @@ public class CreateTemplateCmd extends BaseAsyncCreateCmd {
description = "true if the template supports the password reset
feature; default is false")
private Boolean passwordEnabled;
+@Parameter(name = ApiConstants.SSHKEY_ENABLED, type = CommandType.BOOLEAN,
description = "true if the template supports the sshkey upload feature; default
is false")
+private Boolean sshKeyEnabled;
+
@Parameter(name = ApiConstants.REQUIRES_HVM, type = CommandType.BOOLEAN,
description = "true if the template requres HVM, false otherwise")
private Boolean requiresHvm;
@@ -163,6 +166,10 @@ public class CreateTemplateCmd extends BaseAsyncCreateCmd {
return passwordEnabled;
}
+public Boolean isSshKeyEnabled() {
+return sshKeyEnabled;
+}
+
public Boolean getRequiresHvm() {
return requiresHvm;
}
diff --git a/server/src/main/java/com/cloud/template/TemplateManagerImpl.java
b/server/src/main/java/com/cloud/template/TemplateManagerImpl.java
index dc57a8a..59aa600 100755
--- a/server/src/main/java/com/cloud/template/TemplateManagerImpl.java
+++ b/server/src/main/java/com/cloud/template/TemplateManagerImpl.java
@@ -1736,11 +1736,13 @@ public class TemplateManagerImpl extends ManagerBase
implements TemplateManager,
Integer bits = cmd.getBits();
Boolean requiresHvm = cmd.getRequiresHvm();
Boolean passwordEnabled = cmd.isPasswordEnabled();
+Boolean sshKeyEnabled = cmd.isSshKeyEnabled();
Boolean isPublic = cmd.isPublic();
Boolean featured = cmd.isFeatured();
int bitsValue = ((bits == null) ? 64 : bits.intValue());
boolean requiresHvmValue = ((requiresHvm == null) ? true :
requiresHvm.booleanValue());
boolean passwordEnabledValue = ((passwordEnabled == null) ? false :
passwordEnabled.booleanValue());
+boolean sshKeyEnabledValue = ((sshKeyEnabled == null) ? false :
sshKeyEnabled.booleanValue());
if (isPublic == null) {
isPublic = Boolean.FALSE;
}
@@ -1849,7 +1851,7 @@ public class TemplateManagerImpl extends ManagerBase
implements TemplateManager,
}
privateTemplate = new VMTemplateVO(nextTemplateId, name,
ImageFormat.RAW, i
[GitHub] rhtyd closed issue #2822: create/updateTemplate does not allow to set/change sshkeyenabled
rhtyd closed issue #2822: create/updateTemplate does not allow to set/change sshkeyenabled URL: https://github.com/apache/cloudstack/issues/2822 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2925: kvm: use libvirtd as service name for all distributions
blueorangutan commented on issue #2925: kvm: use libvirtd as service name for all distributions URL: https://github.com/apache/cloudstack/pull/2925#issuecomment-432519115 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd closed pull request #2922: template: create/updateTemplate should allow to set/change sshKeyEnabled
rhtyd closed pull request #2922: template: create/updateTemplate should allow
to set/change sshKeyEnabled
URL: https://github.com/apache/cloudstack/pull/2922
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/api/src/main/java/org/apache/cloudstack/api/BaseUpdateTemplateOrIsoCmd.java
b/api/src/main/java/org/apache/cloudstack/api/BaseUpdateTemplateOrIsoCmd.java
index 36767345a4b..cd7aee771ef 100644
---
a/api/src/main/java/org/apache/cloudstack/api/BaseUpdateTemplateOrIsoCmd.java
+++
b/api/src/main/java/org/apache/cloudstack/api/BaseUpdateTemplateOrIsoCmd.java
@@ -58,6 +58,9 @@
@Parameter(name = ApiConstants.PASSWORD_ENABLED, type =
CommandType.BOOLEAN, description = "true if the image supports the password
reset feature; default is false")
private Boolean passwordEnabled;
+@Parameter(name = ApiConstants.SSHKEY_ENABLED, type = CommandType.BOOLEAN,
description = "true if the template supports the sshkey upload feature; default
is false")
+private Boolean sshKeyEnabled;
+
@Parameter(name = ApiConstants.SORT_KEY, type = CommandType.INTEGER,
description = "sort key of the template, integer")
private Integer sortKey;
@@ -109,6 +112,10 @@ public Boolean getPasswordEnabled() {
return passwordEnabled;
}
+public Boolean isSshKeyEnabled() {
+return sshKeyEnabled;
+}
+
public String getFormat() {
return format;
}
diff --git
a/api/src/main/java/org/apache/cloudstack/api/command/user/template/CreateTemplateCmd.java
b/api/src/main/java/org/apache/cloudstack/api/command/user/template/CreateTemplateCmd.java
index 42f138300bc..aa8ecee132f 100644
---
a/api/src/main/java/org/apache/cloudstack/api/command/user/template/CreateTemplateCmd.java
+++
b/api/src/main/java/org/apache/cloudstack/api/command/user/template/CreateTemplateCmd.java
@@ -92,6 +92,9 @@
description = "true if the template supports the password reset
feature; default is false")
private Boolean passwordEnabled;
+@Parameter(name = ApiConstants.SSHKEY_ENABLED, type = CommandType.BOOLEAN,
description = "true if the template supports the sshkey upload feature; default
is false")
+private Boolean sshKeyEnabled;
+
@Parameter(name = ApiConstants.REQUIRES_HVM, type = CommandType.BOOLEAN,
description = "true if the template requres HVM, false otherwise")
private Boolean requiresHvm;
@@ -163,6 +166,10 @@ public Boolean isPasswordEnabled() {
return passwordEnabled;
}
+public Boolean isSshKeyEnabled() {
+return sshKeyEnabled;
+}
+
public Boolean getRequiresHvm() {
return requiresHvm;
}
diff --git a/server/src/main/java/com/cloud/template/TemplateManagerImpl.java
b/server/src/main/java/com/cloud/template/TemplateManagerImpl.java
index dc57a8a9ef3..59aa600d10f 100755
--- a/server/src/main/java/com/cloud/template/TemplateManagerImpl.java
+++ b/server/src/main/java/com/cloud/template/TemplateManagerImpl.java
@@ -1736,11 +1736,13 @@ public VMTemplateVO
createPrivateTemplateRecord(CreateTemplateCmd cmd, Account t
Integer bits = cmd.getBits();
Boolean requiresHvm = cmd.getRequiresHvm();
Boolean passwordEnabled = cmd.isPasswordEnabled();
+Boolean sshKeyEnabled = cmd.isSshKeyEnabled();
Boolean isPublic = cmd.isPublic();
Boolean featured = cmd.isFeatured();
int bitsValue = ((bits == null) ? 64 : bits.intValue());
boolean requiresHvmValue = ((requiresHvm == null) ? true :
requiresHvm.booleanValue());
boolean passwordEnabledValue = ((passwordEnabled == null) ? false :
passwordEnabled.booleanValue());
+boolean sshKeyEnabledValue = ((sshKeyEnabled == null) ? false :
sshKeyEnabled.booleanValue());
if (isPublic == null) {
isPublic = Boolean.FALSE;
}
@@ -1849,7 +1851,7 @@ public VMTemplateVO
createPrivateTemplateRecord(CreateTemplateCmd cmd, Account t
}
privateTemplate = new VMTemplateVO(nextTemplateId, name,
ImageFormat.RAW, isPublic, featured, isExtractable,
TemplateType.USER, null, requiresHvmValue, bitsValue,
templateOwner.getId(), null, description,
-passwordEnabledValue, guestOS.getId(), true, hyperType,
templateTag, cmd.getDetails(), false, isDynamicScalingEnabled, false);
+passwordEnabledValue, guestOS.getId(), true, hyperType,
templateTag, cmd.getDetails(), sshKeyEnabledValue, isDynamicScalingEnabled,
false);
if (sourceTemplateId != null) {
if (s_logger.isDebugEnabled()) {
@@ -2010,6 +2012,7 @@ private VMTemplateVO
updateTemplateOrIso(BaseUpdateTemplateOrIsoCmd cmd) {
String format = cmd.getFormat();
Long guestOSId = cmd.
[GitHub] rhtyd commented on issue #2925: kvm: use libvirtd as service name for all distributions
rhtyd commented on issue #2925: kvm: use libvirtd as service name for all distributions URL: https://github.com/apache/cloudstack/pull/2925#issuecomment-432518929 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2921: template: Return requireshvm key in list template response
blueorangutan commented on issue #2921: template: Return requireshvm key in list template response URL: https://github.com/apache/cloudstack/pull/2921#issuecomment-432512268 Trillian test result (tid-3110) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 30046 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2921-t3110-kvm-centos7.zip Intermittent failure detected: /marvin/tests/smoke/test_multipleips_per_nic.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py Intermittent failure detected: /marvin/tests/smoke/test_host_maintenance.py Smoke tests completed. 67 look OK, 2 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_nic_secondaryip_add_remove | `Error` | 43.37 | test_multipleips_per_nic.py test_04_rvpc_network_garbage_collector_nics | `Failure` | 274.37 | test_vpc_redundant.py This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2925: kvm: use libvirtd as service name for all distributions
blueorangutan commented on issue #2925: kvm: use libvirtd as service name for all distributions URL: https://github.com/apache/cloudstack/pull/2925#issuecomment-432505430 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2373 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2925: kvm: use libvirtd as service name for all distributions
blueorangutan commented on issue #2925: kvm: use libvirtd as service name for all distributions URL: https://github.com/apache/cloudstack/pull/2925#issuecomment-432500593 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2925: kvm: use libvirtd as service name for all distributions
rhtyd commented on issue #2925: kvm: use libvirtd as service name for all distributions URL: https://github.com/apache/cloudstack/pull/2925#issuecomment-432500449 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2689: Existing templates not downloaded when adding new secondary storage
rhtyd commented on issue #2689: Existing templates not downloaded when adding new secondary storage URL: https://github.com/apache/cloudstack/issues/2689#issuecomment-432500224 /cc @ernjvr - something to consider This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd opened a new pull request #2925: kvm: use libvirtd as service name for all distributions
rhtyd opened a new pull request #2925: kvm: use libvirtd as service name for all distributions URL: https://github.com/apache/cloudstack/pull/2925 Since we support only Ubuntu 16.04+ on master/4.12+, we can now use the libvirt service name `libvirtd` for all distributions. This also fixes an optional package name for libvirtd installation on Debian 9+. Fixes #2909 ## Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [x] Bug fix (non-breaking change which fixes an issue) - [ ] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2922: template: create/updateTemplate should allow to set/change sshKeyEnabled
blueorangutan commented on issue #2922: template: create/updateTemplate should allow to set/change sshKeyEnabled URL: https://github.com/apache/cloudstack/pull/2922#issuecomment-432498342 Trillian test result (tid-3111) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 23275 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2922-t3111-kvm-centos7.zip Intermittent failure detected: /marvin/tests/smoke/test_multipleips_per_nic.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py Smoke tests completed. 67 look OK, 2 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_nic_secondaryip_add_remove | `Error` | 22.50 | test_multipleips_per_nic.py test_04_rvpc_network_garbage_collector_nics | `Failure` | 453.83 | test_vpc_redundant.py This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2915: packaging: install plugins at /usr/share/cloudstack-management/lib
rhtyd commented on issue #2915: packaging: install plugins at /usr/share/cloudstack-management/lib URL: https://github.com/apache/cloudstack/pull/2915#issuecomment-432495170 Test LGTM. Can anyone review this - @rafaelweingartner @GabrielBrascher @wido @nvazquez @borisstoyanov @dhlaluku @ernjvr @anuragaw, thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd opened a new issue #2924: deleteDomain with cleanup=true sometimes fails
rhtyd opened a new issue #2924: deleteDomain with cleanup=true sometimes fails URL: https://github.com/apache/cloudstack/issues/2924 The deleteDomain API with cleanup=true fails in case a delete account has not been cleaned up. Steps to reproduce: - Create CloudStack Domain, account - Deploy vm, delete vm - Delete account, delete domain and failure will be seen at deleteDomain API: ``` DEBUG [c.c.u.DomainManagerImpl] (API-Job-Executor-123:ctx-2uuix ctx-ff5ae6df) (logid:f90df4d4) Can't delete the domain yet because it has 1accounts that need a cleanup com.cloud.utils.exception.CloudRuntimeException: Failed to clean up domain resources and sub domains, delete failed on domain xyz (id: 123). ``` # ISSUE TYPE * Bug Report # COMPONENT NAME ~~~ API, Service Layer ~~~ # CLOUDSTACK VERSION ~~~ 4.11.2.0-rc3 ~~~ This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2923: Improved perfomance on creating VM (KVM)
blueorangutan commented on issue #2923: Improved perfomance on creating VM (KVM) URL: https://github.com/apache/cloudstack/pull/2923#issuecomment-432466089 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2923: Improved perfomance on creating VM (KVM)
rhtyd commented on issue #2923: Improved perfomance on creating VM (KVM) URL: https://github.com/apache/cloudstack/pull/2923#issuecomment-432465919 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2923: Improved perfomance on creating VM (KVM)
blueorangutan commented on issue #2923: Improved perfomance on creating VM (KVM) URL: https://github.com/apache/cloudstack/pull/2923#issuecomment-432465811 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2372 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2918: Improved perfomance on creating VM (KVM)
rhtyd commented on issue #2918: Improved perfomance on creating VM (KVM) URL: https://github.com/apache/cloudstack/pull/2918#issuecomment-432460779 You may close this one, the 4.11 PR will ne fwd merged on master. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2923: Improved perfomance on creating VM (KVM)
blueorangutan commented on issue #2923: Improved perfomance on creating VM (KVM) URL: https://github.com/apache/cloudstack/pull/2923#issuecomment-432460638 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2923: Improved perfomance on creating VM (KVM)
rhtyd commented on issue #2923: Improved perfomance on creating VM (KVM) URL: https://github.com/apache/cloudstack/pull/2923#issuecomment-432460532 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] DennisKonrad commented on issue #2917: Showing VRs in Infrastructure > Virtual Routers fails due to CloudStackVersion.parse(String)
DennisKonrad commented on issue #2917: Showing VRs in Infrastructure > Virtual Routers fails due to CloudStackVersion.parse(String) URL: https://github.com/apache/cloudstack/issues/2917#issuecomment-432458244 Oh ok, now I fully understand where our problem was coming from. The build.sh used the BUILD_NUMBER from jenkins without us knowing it and therefor version was set automatically to the build number in jenkins. I did not recognize that the magically incrementing number was the same as in jenkins. So this clears it up for me. Ok, I'm not sure if this automagic link to the jenkins build number is a good thing if it automagically produces systemvm's that will later fail with the error message we got. Of course it might be a case that happens not so often but if one would like to use the build number he could just call build.sh in jenkins and set the build number as an argument himself. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] khos2ow commented on issue #2917: Showing VRs in Infrastructure > Virtual Routers fails due to CloudStackVersion.parse(String)
khos2ow commented on issue #2917: Showing VRs in Infrastructure > Virtual Routers fails due to CloudStackVersion.parse(String) URL: https://github.com/apache/cloudstack/issues/2917#issuecomment-432454307 Yes any thing which conforms to the type of _version_ with additional optinal branding or timestamp (separated by `-`) will be regarded as valid. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] khos2ow commented on issue #2917: Showing VRs in Infrastructure > Virtual Routers fails due to CloudStackVersion.parse(String)
khos2ow commented on issue #2917: Showing VRs in Infrastructure > Virtual Routers fails due to CloudStackVersion.parse(String) URL: https://github.com/apache/cloudstack/issues/2917#issuecomment-432453836 No problem at all. There are flags in `build.sh` which you can use to differentiate the incremental builds (I'm AFK now, will check later) but it would be better to produce something like this `4.12.0.0-63` to prevent confusion. (Use `-` instead of `.`) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] DennisKonrad commented on issue #2917: Showing VRs in Infrastructure > Virtual Routers fails due to CloudStackVersion.parse(String)
DennisKonrad commented on issue #2917: Showing VRs in Infrastructure > Virtual Routers fails due to CloudStackVersion.parse(String) URL: https://github.com/apache/cloudstack/issues/2917#issuecomment-432453574 @khos2ow Maybe the version string produced by build.sh without any arguments should also be regarded as a valid version string for a svm so things like that cannot happen? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] DennisKonrad edited a comment on issue #2917: Showing VRs in Infrastructure > Virtual Routers fails due to CloudStackVersion.parse(String)
DennisKonrad edited a comment on issue #2917: Showing VRs in Infrastructure > Virtual Routers fails due to CloudStackVersion.parse(String) URL: https://github.com/apache/cloudstack/issues/2917#issuecomment-432452280 One has to really watch out with build.sh to get it right. There's one zero to much. I have to fix it again but then it will be alright This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] DennisKonrad edited a comment on issue #2917: Showing VRs in Infrastructure > Virtual Routers fails due to CloudStackVersion.parse(String)
DennisKonrad edited a comment on issue #2917: Showing VRs in Infrastructure > Virtual Routers fails due to CloudStackVersion.parse(String) URL: https://github.com/apache/cloudstack/issues/2917#issuecomment-432452280 One has to really watch out with build.sh to get it right. There's one zero to much. I have to fix it again but then it will be right This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] DennisKonrad commented on issue #2917: Showing VRs in Infrastructure > Virtual Routers fails due to CloudStackVersion.parse(String)
DennisKonrad commented on issue #2917: Showing VRs in Infrastructure > Virtual Routers fails due to CloudStackVersion.parse(String) URL: https://github.com/apache/cloudstack/issues/2917#issuecomment-432452280 One has to really watch out with build.sh to not get it right. There's one zero to much. I have to fix it again but then it will be right This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] DennisKonrad commented on issue #2917: Showing VRs in Infrastructure > Virtual Routers fails due to CloudStackVersion.parse(String)
DennisKonrad commented on issue #2917: Showing VRs in Infrastructure > Virtual Routers fails due to CloudStackVersion.parse(String) URL: https://github.com/apache/cloudstack/issues/2917#issuecomment-432451299 So now `/etc/cloudstack-release` is back to:  This should work fine now. Thank again This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] DennisKonrad closed issue #2917: Showing VRs in Infrastructure > Virtual Routers fails due to CloudStackVersion.parse(String)
DennisKonrad closed issue #2917: Showing VRs in Infrastructure > Virtual Routers fails due to CloudStackVersion.parse(String) URL: https://github.com/apache/cloudstack/issues/2917 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] DennisKonrad commented on issue #2917: Showing VRs in Infrastructure > Virtual Routers fails due to CloudStackVersion.parse(String)
DennisKonrad commented on issue #2917: Showing VRs in Infrastructure > Virtual Routers fails due to CloudStackVersion.parse(String) URL: https://github.com/apache/cloudstack/issues/2917#issuecomment-432448091 @khos2ow your hint led me in the right direction Many apologies for this. Our jenkins build script had some bug and therefor did not set the version argument for the svm build.sh anymore But because the error was so misleading we thought there is a bug in your code. Many apologies for this. Thanks for helping This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] khos2ow commented on issue #2917: Showing VRs in Infrastructure > Virtual Routers fails due to CloudStackVersion.parse(String)
khos2ow commented on issue #2917: Showing VRs in Infrastructure > Virtual Routers fails due to CloudStackVersion.parse(String) URL: https://github.com/apache/cloudstack/issues/2917#issuecomment-432446387 Yes it should have the same format as in `int.int.int[.int][-branding][-snapshot|timestamp|build_number]` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] DennisKonrad commented on issue #2917: Showing VRs in Infrastructure > Virtual Routers fails due to CloudStackVersion.parse(String)
DennisKonrad commented on issue #2917: Showing VRs in Infrastructure > Virtual Routers fails due to CloudStackVersion.parse(String) URL: https://github.com/apache/cloudstack/issues/2917#issuecomment-432445301 Hi @khos2ow, it took me some time to double check on this. It seems there is a problem with the systemvm's we are building at the moment "cloudstack-release" is set to the following for us:  So I think we have to modify something about our SVM-build process so the output of `/etc/cloudstack-release` matches one of the syntaxes in the tests you updated? Thank you very much for this hint This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] alexanderbazhenoff commented on issue #2918: Improved perfomance on creating VM (KVM)
alexanderbazhenoff commented on issue #2918: Improved perfomance on creating VM (KVM) URL: https://github.com/apache/cloudstack/pull/2918#issuecomment-432439602 > @alexanderbazhenoff can you rebase and edit base branch to 4.11 if possible? https://github.com/apache/cloudstack/pull/2923 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] alexanderbazhenoff opened a new pull request #2923: Improved perfomance on creating VM (KVM)
alexanderbazhenoff opened a new pull request #2923: Improved perfomance on creating VM (KVM) URL: https://github.com/apache/cloudstack/pull/2923 Improved perfomance on creating VM for KVM virtualization. Also for 4.11. Read details here: https://github.com/apache/cloudstack/pull/2918 ## Description ## Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [x] Bug fix (non-breaking change which fixes an issue) - [x] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) ## Screenshots (if appropriate): ## How Has This Been Tested? More than 500VMs orchestration on the same host (1 x VCPU, 384 Mb ram, Linux). Created 500 VMs using python scripts. Measured time. 2 x Xeon E5 CPU + 256Gb RAM + 2 x SSDs. Managment, Database, baremetal agent on the same server. ZFS filesystem pool for NFS share (primary/secondary). KVM virtualization on the host. No affects. Just replaced ifconfig with ip. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] alexanderbazhenoff commented on issue #2918: Improved perfomance on creating VM (KVM)
alexanderbazhenoff commented on issue #2918: Improved perfomance on creating VM (KVM) URL: https://github.com/apache/cloudstack/pull/2918#issuecomment-432432891 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] khos2ow commented on issue #2917: Showing VRs in Infrastructure > Virtual Routers fails due to CloudStackVersion.parse(String)
khos2ow commented on issue #2917: Showing VRs in Infrastructure > Virtual Routers fails due to CloudStackVersion.parse(String) URL: https://github.com/apache/cloudstack/issues/2917#issuecomment-432419290 @DennisKonrad can you check the VR version directly from the machine? `/etc/cloudstack-release`. The weird thing about your screenshot is that it complains `0` is not of a correct format in which it should have been `4.12.0.0`. Basically what the reformatted code does is strip anything after first occurrence of `-` and process the rest. Which means the value passed to `org.apache.cloudstack.utils.CloudStackVersion.parse()` is `0-`. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] alexanderbazhenoff edited a comment on issue #2918: Improved perfomance on creating VM (KVM)
alexanderbazhenoff edited a comment on issue #2918: Improved perfomance on creating VM (KVM) URL: https://github.com/apache/cloudstack/pull/2918#issuecomment-432412102 > It makes sense, right? I mean, if it is not up, we set it to up. Yes, it makes sense. Now fixed. To be honest I don't see the reason to use the whole constructions (which again takies some milliseconds on creating VMs): `# is vlanBr up?` `ip link show dev $vlanBr > /dev/null 2>/dev/null` `if [ $? -eq 0 ]` `then` `ip link set $vlanBr up` `fi` `return 0` Just to save original code style. But: `ip link set $vlanBr up > /dev/null 2>/dev/null` without any condition is faster. Also: `ip link set $vlanDev up > /dev/null 2>/dev/null` instead of: `# is up?` `ip link show dev $vlanDev > /dev/null 2>/dev/null` `if [ $? -eq 0 ]` `then` `ip link set $vlanDev up > /dev/null` `fi` This will not fail on nonnexistent interfaces. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2793: Destroyvm also removes volumes
blueorangutan commented on issue #2793: Destroyvm also removes volumes URL: https://github.com/apache/cloudstack/pull/2793#issuecomment-432416633 Trillian test result (tid-3109) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 31210 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2793-t3109-kvm-centos7.zip Intermittent failure detected: /marvin/tests/smoke/test_multipleips_per_nic.py Intermittent failure detected: /marvin/tests/smoke/test_public_ip_range.py Intermittent failure detected: /marvin/tests/smoke/test_templates.py Intermittent failure detected: /marvin/tests/smoke/test_usage.py Intermittent failure detected: /marvin/tests/smoke/test_volumes.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py Smoke tests completed. 64 look OK, 5 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_nic_secondaryip_add_remove | `Error` | 35.37 | test_multipleips_per_nic.py test_04_extract_template | `Failure` | 128.27 | test_templates.py ContextSuite context=TestISOUsage>:setup | `Error` | 0.00 | test_usage.py test_06_download_detached_volume | `Failure` | 137.61 | test_volumes.py test_04_rvpc_network_garbage_collector_nics | `Failure` | 443.32 | test_vpc_redundant.py This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] alexanderbazhenoff edited a comment on issue #2918: Improved perfomance on creating VM (KVM)
alexanderbazhenoff edited a comment on issue #2918: Improved perfomance on creating VM (KVM) URL: https://github.com/apache/cloudstack/pull/2918#issuecomment-432412102 > It makes sense, right? I mean, if it is not up, we set it to up. Yes, it makes sense. To be honest I don't see the reason to use the whole constructions (which again takies some milliseconds on creating VMs): `# is vlanBr up?` `ip link show dev $vlanBr > /dev/null 2>/dev/null` `if [ $? -eq 0 ]` `then` `ip link set $vlanBr up` `fi` `return 0` Just to save original code style. But: `ip link set $vlanBr up > /dev/null 2>/dev/null` without any condition is faster. Also: `ip link set $vlanDev up > /dev/null 2>/dev/null` instead of: `# is up?` `ip link show dev $vlanDev > /dev/null 2>/dev/null` `if [ $? -eq 0 ]` `then` `ip link set $vlanDev up > /dev/null` `fi` This will not fail on nonnexistent interfaces. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] alexanderbazhenoff edited a comment on issue #2918: Improved perfomance on creating VM (KVM)
alexanderbazhenoff edited a comment on issue #2918: Improved perfomance on creating VM (KVM) URL: https://github.com/apache/cloudstack/pull/2918#issuecomment-432412102 > It makes sense, right? I mean, if it is not up, we set it to up. Yes, it makes sense. To be honest I don't see the reason to use the whole constructions (which again takies some milliseconds on creating VMs): `# is vlanBr up?` `ip link show dev $vlanBr > /dev/null 2>/dev/null` `if [ $? -eq 0 ]` `then` `ip link set $vlanBr up` `fi` `return 0` Just to save original code style. But: `ip link set $vlanBr up > /dev/null 2>/dev/null` without any condition is faster. Also: `ip link set $vlanDev up > /dev/null 2>/dev/null` instead of: `# is up?` `ip link show dev $vlanDev > /dev/null 2>/dev/null` `if [ $? -eq 0 ]` `then` `ip link set $vlanDev up > /dev/null` `fi` This will not fail on nonnexistent interfaces. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] alexanderbazhenoff edited a comment on issue #2918: Improved perfomance on creating VM (KVM)
alexanderbazhenoff edited a comment on issue #2918: Improved perfomance on creating VM (KVM) URL: https://github.com/apache/cloudstack/pull/2918#issuecomment-432412102 > It makes sense, right? I mean, if it is not up, we set it to up. Yes, it makes sense. To be honest I don't see the reason to use the whole constructionы taking milliseconds on creating VMs: `# is vlanBr up?` `ip link show dev $vlanBr > /dev/null 2>/dev/null` `if [ $? -eq 0 ]` `then` `ip link set $vlanBr up` `fi` `return 0` Just to save original code style. But: `ip link set $vlanBr up > /dev/null 2>/dev/null` without any condition is faster. Also: `ip link set $vlanDev up > /dev/null 2>/dev/null` instead of: `# is up?` `ip link show dev $vlanDev > /dev/null 2>/dev/null` `if [ $? -eq 0 ]` `then` `ip link set $vlanDev up > /dev/null` `fi` This will not fail on nonnexistent interfaces. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] alexanderbazhenoff commented on issue #2918: Improved perfomance on creating VM (KVM)
alexanderbazhenoff commented on issue #2918: Improved perfomance on creating VM (KVM) URL: https://github.com/apache/cloudstack/pull/2918#issuecomment-432412102 > It makes sense, right? I mean, if it is not up, we set it to up. Yes, it makes sense. To be honest I don't see the reason to use the whole this construction taking milliseconds on creating VMs: `# is vlanBr up?` `ip link show dev $vlanBr > /dev/null 2>/dev/null` `if [ $? -eq 0 ]` `then` `ip link set $vlanBr up` `fi` `return 0` Just to save original code style. But: `ip link set $vlanBr up > /dev/null 2>/dev/null` without any condition is faster. Also: `ip link set $vlanDev up > /dev/null 2>/dev/null` instead of: `# is up?` `ip link show dev $vlanDev > /dev/null 2>/dev/null` `if [ $? -eq 0 ]` `then` `ip link set $vlanDev up > /dev/null` `fi` This will not fail on nonnexistent interfaces. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2918: Improved perfomance on creating VM (KVM)
blueorangutan commented on issue #2918: Improved perfomance on creating VM (KVM) URL: https://github.com/apache/cloudstack/pull/2918#issuecomment-432404671 Trillian test result (tid-3108) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 31417 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2918-t3108-kvm-centos7.zip Intermittent failure detected: /marvin/tests/smoke/test_deploy_virtio_scsi_vm.py Intermittent failure detected: /marvin/tests/smoke/test_diagnostics.py Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py Intermittent failure detected: /marvin/tests/smoke/test_iso.py Intermittent failure detected: /marvin/tests/smoke/test_loadbalance.py Intermittent failure detected: /marvin/tests/smoke/test_multipleips_per_nic.py Intermittent failure detected: /marvin/tests/smoke/test_network.py Intermittent failure detected: /marvin/tests/smoke/test_password_server.py Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py Intermittent failure detected: /marvin/tests/smoke/test_public_ip_range.py Intermittent failure detected: /marvin/tests/smoke/test_reset_vm_on_reboot.py Intermittent failure detected: /marvin/tests/smoke/test_router_dhcphosts.py Intermittent failure detected: /marvin/tests/smoke/test_router_dns.py Intermittent failure detected: /marvin/tests/smoke/test_router_dnsservice.py Intermittent failure detected: /marvin/tests/smoke/test_routers_iptables_default_policy.py Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py Intermittent failure detected: /marvin/tests/smoke/test_routers.py Intermittent failure detected: /marvin/tests/smoke/test_secondary_storage.py Intermittent failure detected: /marvin/tests/smoke/test_service_offerings.py Intermittent failure detected: /marvin/tests/smoke/test_snapshots.py Intermittent failure detected: /marvin/tests/smoke/test_ssvm.py Intermittent failure detected: /marvin/tests/smoke/test_templates.py Intermittent failure detected: /marvin/tests/smoke/test_usage.py Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py Intermittent failure detected: /marvin/tests/smoke/test_vm_snapshots.py Intermittent failure detected: /marvin/tests/smoke/test_volumes.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_router_nics.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py Intermittent failure detected: /marvin/tests/smoke/test_host_maintenance.py Smoke tests completed. 40 look OK, 29 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_04_extract_Iso | `Failure` | 6.53 | test_iso.py test_04_verify_guest_lspci | `Error` | 715.43 | test_deploy_virtio_scsi_vm.py test_06_verify_guest_lspci_again | `Error` | 715.44 | test_deploy_virtio_scsi_vm.py test_01_port_fwd_on_src_nat | `Failure` | 718.70 | test_network.py test_02_port_fwd_on_non_src_nat | `Failure` | 721.80 | test_network.py test_reboot_router | `Failure` | 350.12 | test_network.py test_network_rules_acquired_public_ip_1_static_nat_rule | `Failure` | 721.38 | test_network.py test_network_rules_acquired_public_ip_2_nat_rule | `Failure` | 722.40 | test_network.py test_network_rules_acquired_public_ip_3_Load_Balancer_Rule | `Failure` | 726.60 | test_network.py test_01_ping_in_vr_success | `Error` | 60.19 | test_diagnostics.py test_02_ping_in_vr_failure | `Error` | 60.17 | test_diagnostics.py test_07_arping_in_vr | `Failure` | 5.14 | test_diagnostics.py test_08_arping_in_ssvm | `Failure` | 5.15 | test_diagnostics.py test_09_arping_in_cpvm | `Failure` | 5.15 | test_diagnostics.py test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 | `Failure` | 193.69 | test_internal_lb.py test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 | `Failure` | 229.19 | test_internal_lb.py test_03_vpc_internallb_haproxy_stats_on_all_interfaces | `Error` | 128.56 | test_internal_lb.py test_04_rvpc_internallb_haproxy_stats_on_all_interfaces | `Error` | 154.01 | test_internal_lb.py test_isolate_network_password_server | `Failure` | 190.36 | test_password_server.py test_01_create_lb_rule_src_nat | `Failure` | 480.29 | test_loadbalance.py test_02_create_lb_rule_non_nat | `Failure` | 57.17 | test_loadbalance.py test_assign_and_removal_lb | `Failure` | 57.18 | test_loadbalance.py test_nic_secondaryip_add_remove | `Error` | 22.03 | test_multipleips_per_nic.py test_02_vpc_privategw_static_routes | `Failure` | 793.98 | test_privategw_acl.py test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 793.92 | test_privategw_acl.py test_04_rvpc_privategw_static_routes | `Failure` | 861.33 | test_privategw_acl.py ContextS
[GitHub] blueorangutan commented on issue #2922: template: create/updateTemplate should allow to set/change sshKeyEnabled
blueorangutan commented on issue #2922: template: create/updateTemplate should allow to set/change sshKeyEnabled URL: https://github.com/apache/cloudstack/pull/2922#issuecomment-432403450 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2922: template: create/updateTemplate should allow to set/change sshKeyEnabled
rhtyd commented on issue #2922: template: create/updateTemplate should allow to set/change sshKeyEnabled URL: https://github.com/apache/cloudstack/pull/2922#issuecomment-432403414 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2922: template: create/updateTemplate should allow to set/change sshKeyEnabled
blueorangutan commented on issue #2922: template: create/updateTemplate should allow to set/change sshKeyEnabled URL: https://github.com/apache/cloudstack/pull/2922#issuecomment-432401799 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2371 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2921: template: Return requireshvm key in list template response
blueorangutan commented on issue #2921: template: Return requireshvm key in list template response URL: https://github.com/apache/cloudstack/pull/2921#issuecomment-432397348 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2921: template: Return requireshvm key in list template response
rhtyd commented on issue #2921: template: Return requireshvm key in list template response URL: https://github.com/apache/cloudstack/pull/2921#issuecomment-432397243 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2922: template: create/updateTemplate should allow to set/change sshKeyEnabled
blueorangutan commented on issue #2922: template: create/updateTemplate should allow to set/change sshKeyEnabled URL: https://github.com/apache/cloudstack/pull/2922#issuecomment-432390474 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2922: template: create/updateTemplate should allow to set/change sshKeyEnabled
rhtyd commented on issue #2922: template: create/updateTemplate should allow to set/change sshKeyEnabled URL: https://github.com/apache/cloudstack/pull/2922#issuecomment-432390298 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sh0wstopper opened a new pull request #2922: template: create/updateTemplate should allow to set/change sshKeyEnabled
sh0wstopper opened a new pull request #2922: template: create/updateTemplate should allow to set/change sshKeyEnabled URL: https://github.com/apache/cloudstack/pull/2922 Added sshKeyEnabled key in createTemplate and updateTemplate API. Fixes #2822 ## Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [x] Bug fix (non-breaking change which fixes an issue) - [x] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2921: template: Return requireshvm key in list template response
blueorangutan commented on issue #2921: template: Return requireshvm key in list template response URL: https://github.com/apache/cloudstack/pull/2921#issuecomment-432384600 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2370 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] somejfn edited a comment on issue #2890: KVMHAMonitor thread blocks indefinitely while NFS not available
somejfn edited a comment on issue #2890: KVMHAMonitor thread blocks indefinitely while NFS not available URL: https://github.com/apache/cloudstack/issues/2890#issuecomment-432374446 Confirmed we see similar behavior on 4.11.2rc3 and the agent went in Down state. Agent logs: 810986-e702-36ea-a87b-fd48064ecb12 2018-10-23 13:14:40,391 INFO [kvm.resource.LibvirtConnection] (agentRequest-Handler-4:null) (logid:f8cd7cf7) No existing libvirtd connection found. Opening a new one 2018-10-23 13:14:40,392 WARN [kvm.resource.LibvirtConnection] (agentRequest-Handler-4:null) (logid:f8cd7cf7) Can not find a connection for Instance i-4-24-VM. Assuming the default connection. 2018-10-23 13:14:40,399 INFO [kvm.storage.LibvirtStorageAdaptor] (agentRequest-Handler-4:null) (logid:f8cd7cf7) Trying to fetch storage pool 4e49054a-463f-306f-9678-b0d9b02af9a1 from libvirt 2018-10-23 13:14:51,496 INFO [kvm.storage.LibvirtStorageAdaptor] (agentRequest-Handler-2:null) (logid:3a0df8e5) Trying to fetch storage pool 0e233ec5-ea14-439e-bfde-a8c7566d254c from libvirt 2018-10-23 13:14:51,498 INFO [kvm.storage.LibvirtStorageAdaptor] (agentRequest-Handler-2:null) (logid:3a0df8e5) Asking libvirt to refresh storage pool 0e233ec5-ea14-439e-bfde-a8c7566d254c 2018-10-23 13:15:25,027 INFO [kvm.storage.LibvirtStorageAdaptor] (agentRequest-Handler-1:null) (logid:581a1d95) Trying to fetch storage pool 0e233ec5-ea14-439e-bfde-a8c7566d254c from libvirt 2018-10-23 13:15:25,029 INFO [kvm.storage.LibvirtStorageAdaptor] (agentRequest-Handler-1:null) (logid:581a1d95) Asking libvirt to refresh storage pool 0e233ec5-ea14-439e-bfde-a8c7566d254c 2018-10-23 13:15:25,590 INFO [kvm.storage.LibvirtStorageAdaptor] (agentRequest-Handler-5:null) (logid:581a1d95) Trying to fetch storage pool 3e810986-e702-36ea-a87b-fd48064ecb12 from libvirt 2018-10-23 13:15:25,592 INFO [kvm.storage.LibvirtStorageAdaptor] (agentRequest-Handler-5:null) (logid:581a1d95) Asking libvirt to refresh storage pool 3e810986-e702-36ea-a87b-fd48064ecb12 2018-10-23 13:21:28,804 WARN [kvm.resource.KVMHAChecker] (Script-3:null) (logid:) Interrupting script. 2018-10-23 13:21:28,806 WARN [kvm.resource.KVMHAChecker] (pool-15160-thread-1:null) (logid:c3d5dcaf) Timed out: /usr/share/cloudstack-common/scripts/vm/hypervisor/kvm/kvmheartbeat.sh -i 10.73.96.232 -p /vol/t500_0_fls3_pool36_root -m /mnt/d05f1c9d-9454-3707-a6c4-781398af198d -h 10.73.96.212 -r -t 60 . Output is: 2018-10-23 13:21:32,826 WARN [kvm.resource.KVMHAChecker] (Script-7:null) (logid:) Interrupting script. 2018-10-23 13:21:32,827 WARN [kvm.resource.KVMHAChecker] (pool-15161-thread-1:null) (logid:c3d5dcaf) Timed out: /usr/share/cloudstack-common/scripts/vm/hypervisor/kvm/kvmheartbeat.sh -i 10.73.96.232 -p /vol/t500_0_fls3_pool36_root -m /mnt/d05f1c9d-9454-3707-a6c4-781398af198d -h 10.73.96.212 -r -t 60 . Output is: 2018-10-23 13:21:36,846 WARN [kvm.resource.KVMHAChecker] (Script-4:null) (logid:) Interrupting script. 2018-10-23 13:21:36,847 WARN [kvm.resource.KVMHAChecker] (pool-15162-thread-1:null) (logid:4a3cb34f) Timed out: /usr/share/cloudstack-common/scripts/vm/hypervisor/kvm/kvmheartbeat.sh -i 10.73.96.232 -p /vol/t500_0_fls3_pool36_root -m /mnt/d05f1c9d-9454-3707-a6c4-781398af198d -h 10.73.96.212 -r -t 60 . Output is: 2018-10-23 13:24:44,205 INFO [cloud.agent.Agent] (Agent-Handler-1:null) (logid:5a5a7500) Lost connection to host: 10.73.96.19. Attempting reconnection while we still have 5 commands in progress. 2018-10-23 13:24:44,206 INFO [utils.nio.NioClient] (Agent-Handler-1:null) (logid:5a5a7500) NioClient connection closed 2018-10-23 13:24:44,206 INFO [cloud.agent.Agent] (Agent-Handler-1:null) (logid:5a5a7500) Reconnecting to host:10.73.96.19 2018-10-23 13:24:44,207 INFO [utils.nio.NioClient] (Agent-Handler-1:null) (logid:5a5a7500) Connecting to 10.73.96.19:8250 2018-10-23 13:24:44,207 INFO [utils.nio.Link] (Agent-Handler-1:null) (logid:5a5a7500) Conf file found: /etc/cloudstack/agent/agent.properties Note sometimes you will see the agent successfully go in Disconnect state but the host HA framework might still fire after the kvm.ha.degraded.max.period timer and that is not expected. In any case we want to avoid massive KVM host resets via IPMI for storage related problems because this is more damaging than waiting for primary storage to come back. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] somejfn commented on issue #2890: KVMHAMonitor thread blocks indefinitely while NFS not available
somejfn commented on issue #2890: KVMHAMonitor thread blocks indefinitely while NFS not available URL: https://github.com/apache/cloudstack/issues/2890#issuecomment-432374446 Confirmed we see similar behavior on 4.11.2rc3 and the agent went in Down state. Agent logs: 810986-e702-36ea-a87b-fd48064ecb12 2018-10-23 13:14:40,391 INFO [kvm.resource.LibvirtConnection] (agentRequest-Handler-4:null) (logid:f8cd7cf7) No existing libvirtd connection found. Opening a new one 2018-10-23 13:14:40,392 WARN [kvm.resource.LibvirtConnection] (agentRequest-Handler-4:null) (logid:f8cd7cf7) Can not find a connection for Instance i-4-24-VM. Assuming the default connection. 2018-10-23 13:14:40,399 INFO [kvm.storage.LibvirtStorageAdaptor] (agentRequest-Handler-4:null) (logid:f8cd7cf7) Trying to fetch storage pool 4e49054a-463f-306f-9678-b0d9b02af9a1 from libvirt 2018-10-23 13:14:51,496 INFO [kvm.storage.LibvirtStorageAdaptor] (agentRequest-Handler-2:null) (logid:3a0df8e5) Trying to fetch storage pool 0e233ec5-ea14-439e-bfde-a8c7566d254c from libvirt 2018-10-23 13:14:51,498 INFO [kvm.storage.LibvirtStorageAdaptor] (agentRequest-Handler-2:null) (logid:3a0df8e5) Asking libvirt to refresh storage pool 0e233ec5-ea14-439e-bfde-a8c7566d254c 2018-10-23 13:15:25,027 INFO [kvm.storage.LibvirtStorageAdaptor] (agentRequest-Handler-1:null) (logid:581a1d95) Trying to fetch storage pool 0e233ec5-ea14-439e-bfde-a8c7566d254c from libvirt 2018-10-23 13:15:25,029 INFO [kvm.storage.LibvirtStorageAdaptor] (agentRequest-Handler-1:null) (logid:581a1d95) Asking libvirt to refresh storage pool 0e233ec5-ea14-439e-bfde-a8c7566d254c 2018-10-23 13:15:25,590 INFO [kvm.storage.LibvirtStorageAdaptor] (agentRequest-Handler-5:null) (logid:581a1d95) Trying to fetch storage pool 3e810986-e702-36ea-a87b-fd48064ecb12 from libvirt 2018-10-23 13:15:25,592 INFO [kvm.storage.LibvirtStorageAdaptor] (agentRequest-Handler-5:null) (logid:581a1d95) Asking libvirt to refresh storage pool 3e810986-e702-36ea-a87b-fd48064ecb12 2018-10-23 13:21:28,804 WARN [kvm.resource.KVMHAChecker] (Script-3:null) (logid:) Interrupting script. 2018-10-23 13:21:28,806 WARN [kvm.resource.KVMHAChecker] (pool-15160-thread-1:null) (logid:c3d5dcaf) Timed out: /usr/share/cloudstack-common/scripts/vm/hypervisor/kvm/kvmheartbeat.sh -i 10.73.96.232 -p /vol/t500_0_fls3_pool36_root -m /mnt/d05f1c9d-9454-3707-a6c4-781398af198d -h 10.73.96.212 -r -t 60 . Output is: 2018-10-23 13:21:32,826 WARN [kvm.resource.KVMHAChecker] (Script-7:null) (logid:) Interrupting script. 2018-10-23 13:21:32,827 WARN [kvm.resource.KVMHAChecker] (pool-15161-thread-1:null) (logid:c3d5dcaf) Timed out: /usr/share/cloudstack-common/scripts/vm/hypervisor/kvm/kvmheartbeat.sh -i 10.73.96.232 -p /vol/t500_0_fls3_pool36_root -m /mnt/d05f1c9d-9454-3707-a6c4-781398af198d -h 10.73.96.212 -r -t 60 . Output is: 2018-10-23 13:21:36,846 WARN [kvm.resource.KVMHAChecker] (Script-4:null) (logid:) Interrupting script. 2018-10-23 13:21:36,847 WARN [kvm.resource.KVMHAChecker] (pool-15162-thread-1:null) (logid:4a3cb34f) Timed out: /usr/share/cloudstack-common/scripts/vm/hypervisor/kvm/kvmheartbeat.sh -i 10.73.96.232 -p /vol/t500_0_fls3_pool36_root -m /mnt/d05f1c9d-9454-3707-a6c4-781398af198d -h 10.73.96.212 -r -t 60 . Output is: 2018-10-23 13:24:44,205 INFO [cloud.agent.Agent] (Agent-Handler-1:null) (logid:5a5a7500) Lost connection to host: 10.73.96.19. Attempting reconnection while we still have 5 commands in progress. 2018-10-23 13:24:44,206 INFO [utils.nio.NioClient] (Agent-Handler-1:null) (logid:5a5a7500) NioClient connection closed 2018-10-23 13:24:44,206 INFO [cloud.agent.Agent] (Agent-Handler-1:null) (logid:5a5a7500) Reconnecting to host:10.73.96.19 2018-10-23 13:24:44,207 INFO [utils.nio.NioClient] (Agent-Handler-1:null) (logid:5a5a7500) Connecting to 10.73.96.19:8250 2018-10-23 13:24:44,207 INFO [utils.nio.Link] (Agent-Handler-1:null) (logid:5a5a7500) Conf file found: /etc/cloudstack/agent/agent.properties Note sometimes you will see the agent successfully go in Disconnect state but the host HA framework might still fire after the kvm.ha.degraded.max.period timer and that is not expected. In any case we want to avoid massive KVM host resets via IPMI for storage related problems because this is more damaging than waiting to primary storage to come back. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2921: template: Return requireshvm key in list template response
blueorangutan commented on issue #2921: template: Return requireshvm key in list template response URL: https://github.com/apache/cloudstack/pull/2921#issuecomment-432373138 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2921: template: Return requireshvm key in list template response
rhtyd commented on issue #2921: template: Return requireshvm key in list template response URL: https://github.com/apache/cloudstack/pull/2921#issuecomment-432372715 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sh0wstopper opened a new pull request #2921: template: Return requireshvm key in list template response
sh0wstopper opened a new pull request #2921: template: Return requireshvm key in list template response URL: https://github.com/apache/cloudstack/pull/2921 Added requireshvm key in the response of list template API. Fixes #2821 ## Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [x] Bug fix (non-breaking change which fixes an issue) - [ ] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2916: systemvm: Ensure cloud service reboots after failure
blueorangutan commented on issue #2916: systemvm: Ensure cloud service reboots after failure URL: https://github.com/apache/cloudstack/pull/2916#issuecomment-432364122 Trillian test result (tid-3106) Environment: vmware-55u3 (x2), Advanced Networking with Mgmt server 7 Total time taken: 33251 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2916-t3106-vmware-55u3.zip Smoke tests completed. 67 look OK, 0 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd closed pull request #2916: systemvm: Ensure cloud service reboots after failure
rhtyd closed pull request #2916: systemvm: Ensure cloud service reboots after failure URL: https://github.com/apache/cloudstack/pull/2916 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/systemvm/debian/etc/systemd/system/cloud-postinit.service b/systemvm/debian/etc/systemd/system/cloud-postinit.service index a9abff443fa..cb20aaf7c06 100644 --- a/systemvm/debian/etc/systemd/system/cloud-postinit.service +++ b/systemvm/debian/etc/systemd/system/cloud-postinit.service @@ -2,7 +2,6 @@ Description=CloudStack post-patching init script After=cloud-early-config.service network.target local-fs.target Before=ssh.service -Requires=networking.service [Install] WantedBy=multi-user.target diff --git a/systemvm/debian/etc/systemd/system/cloud.service b/systemvm/debian/etc/systemd/system/cloud.service index 9c61be46eba..22439239caa 100644 --- a/systemvm/debian/etc/systemd/system/cloud.service +++ b/systemvm/debian/etc/systemd/system/cloud.service @@ -9,5 +9,4 @@ WantedBy=multi-user.target Type=simple WorkingDirectory=/usr/local/cloud/systemvm ExecStart=/usr/local/cloud/systemvm/_run.sh -Restart=always -RestartSec=5 +Restart=on-failure This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[cloudstack] branch 4.11 updated: systemvm: Ensure cloud service reboots after failure (#2916)
This is an automated email from the ASF dual-hosted git repository. rohit pushed a commit to branch 4.11 in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/4.11 by this push: new e092529 systemvm: Ensure cloud service reboots after failure (#2916) e092529 is described below commit e092529c987a5091e63c326479407b88aa71ca67 Author: Rohit Yadav AuthorDate: Tue Oct 23 23:33:08 2018 +0530 systemvm: Ensure cloud service reboots after failure (#2916) This fixes an issue for systemvms (CPVM and SSVM) on VMware, as eth0 is not programmed (link-local) the networking.service fails to start which is a dependency for cloud-postinit service. When cloud-postinit service fails to start/run, it fails to start the agent (cloud) process. This fixes the smoketest failures we saw in case of VMware 6.5 with 4.11. Signed-off-by: Rohit Yadav --- systemvm/debian/etc/systemd/system/cloud-postinit.service | 1 - systemvm/debian/etc/systemd/system/cloud.service | 3 +-- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/systemvm/debian/etc/systemd/system/cloud-postinit.service b/systemvm/debian/etc/systemd/system/cloud-postinit.service index a9abff4..cb20aaf 100644 --- a/systemvm/debian/etc/systemd/system/cloud-postinit.service +++ b/systemvm/debian/etc/systemd/system/cloud-postinit.service @@ -2,7 +2,6 @@ Description=CloudStack post-patching init script After=cloud-early-config.service network.target local-fs.target Before=ssh.service -Requires=networking.service [Install] WantedBy=multi-user.target diff --git a/systemvm/debian/etc/systemd/system/cloud.service b/systemvm/debian/etc/systemd/system/cloud.service index 9c61be4..2243923 100644 --- a/systemvm/debian/etc/systemd/system/cloud.service +++ b/systemvm/debian/etc/systemd/system/cloud.service @@ -9,5 +9,4 @@ WantedBy=multi-user.target Type=simple WorkingDirectory=/usr/local/cloud/systemvm ExecStart=/usr/local/cloud/systemvm/_run.sh -Restart=always -RestartSec=5 +Restart=on-failure
[GitHub] rhtyd commented on issue #2916: systemvm: Ensure cloud service reboots after failure
rhtyd commented on issue #2916: systemvm: Ensure cloud service reboots after failure URL: https://github.com/apache/cloudstack/pull/2916#issuecomment-432355648 100% smoketests pass w00t! Will merge This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2915: packaging: install plugins at /usr/share/cloudstack-management/lib
blueorangutan commented on issue #2915: packaging: install plugins at /usr/share/cloudstack-management/lib URL: https://github.com/apache/cloudstack/pull/2915#issuecomment-432351087 Trillian test result (tid-3107) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 27415 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2915-t3107-kvm-centos7.zip Intermittent failure detected: /marvin/tests/smoke/test_public_ip_range.py Intermittent failure detected: /marvin/tests/smoke/test_templates.py Intermittent failure detected: /marvin/tests/smoke/test_usage.py Intermittent failure detected: /marvin/tests/smoke/test_volumes.py Smoke tests completed. 64 look OK, 3 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_04_extract_template | `Failure` | 128.36 | test_templates.py ContextSuite context=TestISOUsage>:setup | `Error` | 0.00 | test_usage.py test_06_download_detached_volume | `Failure` | 136.78 | test_volumes.py This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2916: systemvm: Ensure cloud service reboots after failure
blueorangutan commented on issue #2916: systemvm: Ensure cloud service reboots after failure URL: https://github.com/apache/cloudstack/pull/2916#issuecomment-432319134 Trillian test result (tid-3105) Environment: vmware-65 (x2), Advanced Networking with Mgmt server 7 Total time taken: 28579 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2916-t3105-vmware-65.zip Smoke tests completed. 67 look OK, 0 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rafaelweingartner commented on issue #2918: Improved perfomance on creating VM (KVM)
rafaelweingartner commented on issue #2918: Improved perfomance on creating VM (KVM) URL: https://github.com/apache/cloudstack/pull/2918#issuecomment-432313431 > > > Opps, found some strange `-gt` condition. > `# is vlanBr up?` > `ip link show dev $vlanBr > /dev/null 2>/dev/null` > ` if [ $? -gt 0 ]` > Should be `-eq` there. > > Please don't commit until we test this. All changes will be ASAP. Thanks. It makes sense, right? I mean, if it is not up, we set it to up. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] Overv opened a new issue #2920: SSH key pairs are not searchable
Overv opened a new issue #2920: SSH key pairs are not searchable URL: https://github.com/apache/cloudstack/issues/2920 The `keyword` argument in `listSSHKeyPairs` is ignored, causing the search in the UI not to work. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] bwsw commented on issue #2918: Improved perfomance on creating VM (KVM)
bwsw commented on issue #2918: Improved perfomance on creating VM (KVM) URL: https://github.com/apache/cloudstack/pull/2918#issuecomment-432299335 @rhtyd why don't you use ``` grep 'veth20fd2a1:' /proc/net/dev ``` instead of calling for `ip` command? More specifically: ``` if grep -q 'eth0:' /proc/net/dev then fi ``` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] alexanderbazhenoff edited a comment on issue #2918: Improved perfomance on creating VM (KVM)
alexanderbazhenoff edited a comment on issue #2918: Improved perfomance on creating VM (KVM) URL: https://github.com/apache/cloudstack/pull/2918#issuecomment-432274527 Opps, found some strange `-gt` condition. `# is vlanBr up?` `ip link show dev $vlanBr > /dev/null 2>/dev/null` ` if [ $? -gt 0 ]` Should be `-eq` there. Please don't commit until we test this. All changes will be ASAP. Thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] alexanderbazhenoff commented on issue #2918: Improved perfomance on creating VM (KVM)
alexanderbazhenoff commented on issue #2918: Improved perfomance on creating VM (KVM) URL: https://github.com/apache/cloudstack/pull/2918#issuecomment-432274527 Opps, found some strange `-gt` condition. `# is vlanBr up?` `ip link show dev $vlanBr > /dev/null 2>/dev/null` ` if [ $? --gt 0 ]` Should be `-eq` there Please don't commit until we test and change this. Thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2916: systemvm: Ensure cloud service reboots after failure
blueorangutan commented on issue #2916: systemvm: Ensure cloud service reboots after failure URL: https://github.com/apache/cloudstack/pull/2916#issuecomment-432270520 Trillian test result (tid-3104) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 24931 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2916-t3104-kvm-centos7.zip Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py Smoke tests completed. 67 look OK, 0 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] houthuis commented on issue #2793: Destroyvm also removes volumes
houthuis commented on issue #2793: Destroyvm also removes volumes URL: https://github.com/apache/cloudstack/pull/2793#issuecomment-432213458 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2793: Destroyvm also removes volumes
blueorangutan commented on issue #2793: Destroyvm also removes volumes URL: https://github.com/apache/cloudstack/pull/2793#issuecomment-432213699 @houthuis a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] andrijapanic commented on issue #2870: KVM HyperV Enlightment for Improved Windows Server 2008+ Performance
andrijapanic commented on issue #2870: KVM HyperV Enlightment for Improved Windows Server 2008+ Performance URL: https://github.com/apache/cloudstack/pull/2870#issuecomment-432218653 I agree on VirtIO stuff absolutely. It's just that, even with all FAQ and so on, still end-user sometimes continue to use specific a Windows OS type instead of Windows PV, so it makes sense to solve all Windows OS types with this nice patch. As for future support of OS types inside ACS, that is a good point, but doesn't warrant not applying patch for all of Win OS types, in my opinion. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] kiwiflyer commented on issue #2870: KVM HyperV Enlightment for Improved Windows Server 2008+ Performance
kiwiflyer commented on issue #2870: KVM HyperV Enlightment for Improved Windows Server 2008+ Performance URL: https://github.com/apache/cloudstack/pull/2870#issuecomment-432216214 @andrijapanic I'm open to changing it to use all Windows OS types. My mine reason for picking one was some backwards compatibility. At least in the KVM world, I'm unsure why we continue to maintain tons of different OS types/names, as running any OS without virtio is extremely painful in terms of performance. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2918: Improved perfomance on creating VM (KVM)
blueorangutan commented on issue #2918: Improved perfomance on creating VM (KVM) URL: https://github.com/apache/cloudstack/pull/2918#issuecomment-432202950 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2918: Improved perfomance on creating VM (KVM)
rhtyd commented on issue #2918: Improved perfomance on creating VM (KVM) URL: https://github.com/apache/cloudstack/pull/2918#issuecomment-432202856 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wido commented on issue #2913: Deactivate ehcache
wido commented on issue #2913: Deactivate ehcache URL: https://github.com/apache/cloudstack/pull/2913#issuecomment-432188112 I have seen some issues with ehcache as well on mgmt servers, we disabled it often on deployment. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2880: [4.11.2]: rolling upgrade of VR results in duplicate VRs
rhtyd commented on issue #2880: [4.11.2]: rolling upgrade of VR results in duplicate VRs URL: https://github.com/apache/cloudstack/issues/2880#issuecomment-432182058 Thanks for sharing @resmo let me investigate and get back to you This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] resmo commented on issue #2880: [4.11.2]: rolling upgrade of VR results in duplicate VRs
resmo commented on issue #2880: [4.11.2]: rolling upgrade of VR results in duplicate VRs URL: https://github.com/apache/cloudstack/issues/2880#issuecomment-432179489 @rhtyd still hitting this exception in rc3 with `network.rolling.restart=false` ~~~ Caused by: com.mysql.jdbc.exceptions.jdbc4.MySQLIntegrityConstraintViolationException: Duplicate entry '32468' for key 'PRIMARY' at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method) at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62) at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45) ... 75 more ~~~ :cry: This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2793: Destroyvm also removes volumes
blueorangutan commented on issue #2793: Destroyvm also removes volumes URL: https://github.com/apache/cloudstack/pull/2793#issuecomment-432177891 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2368 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2918: Improved perfomance on creating VM (KVM)
rhtyd commented on issue #2918: Improved perfomance on creating VM (KVM) URL: https://github.com/apache/cloudstack/pull/2918#issuecomment-432175620 @alexanderbazhenoff can you rebase and edit base branch to 4.11 if possible? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2918: Improved perfomance on creating VM (KVM)
blueorangutan commented on issue #2918: Improved perfomance on creating VM (KVM) URL: https://github.com/apache/cloudstack/pull/2918#issuecomment-432175559 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2918: Improved perfomance on creating VM (KVM)
rhtyd commented on issue #2918: Improved perfomance on creating VM (KVM) URL: https://github.com/apache/cloudstack/pull/2918#issuecomment-432175328 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2915: packaging: install plugins at /usr/share/cloudstack-management/lib
blueorangutan commented on issue #2915: packaging: install plugins at /usr/share/cloudstack-management/lib URL: https://github.com/apache/cloudstack/pull/2915#issuecomment-432174857 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2915: packaging: install plugins at /usr/share/cloudstack-management/lib
rhtyd commented on issue #2915: packaging: install plugins at /usr/share/cloudstack-management/lib URL: https://github.com/apache/cloudstack/pull/2915#issuecomment-432174516 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2793: Destroyvm also removes volumes
blueorangutan commented on issue #2793: Destroyvm also removes volumes URL: https://github.com/apache/cloudstack/pull/2793#issuecomment-432167805 @houthuis a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] houthuis commented on issue #2793: Destroyvm also removes volumes
houthuis commented on issue #2793: Destroyvm also removes volumes URL: https://github.com/apache/cloudstack/pull/2793#issuecomment-432167611 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] marcaurele commented on issue #2913: Deactivate ehcache
marcaurele commented on issue #2913: Deactivate ehcache URL: https://github.com/apache/cloudstack/pull/2913#issuecomment-432141300 @rhtyd sure This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2916: systemvm: Ensure cloud service reboots after failure
blueorangutan commented on issue #2916: systemvm: Ensure cloud service reboots after failure URL: https://github.com/apache/cloudstack/pull/2916#issuecomment-432137914 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-55u3) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2916: systemvm: Ensure cloud service reboots after failure
rhtyd commented on issue #2916: systemvm: Ensure cloud service reboots after failure URL: https://github.com/apache/cloudstack/pull/2916#issuecomment-432137684 @blueorangutan test centos7 vmware-55u3 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2916: systemvm: Ensure cloud service reboots after failure
blueorangutan commented on issue #2916: systemvm: Ensure cloud service reboots after failure URL: https://github.com/apache/cloudstack/pull/2916#issuecomment-432137557 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-65) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2916: systemvm: Ensure cloud service reboots after failure
rhtyd commented on issue #2916: systemvm: Ensure cloud service reboots after failure URL: https://github.com/apache/cloudstack/pull/2916#issuecomment-432137484 @blueorangutan test centos7 vmware-65 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2913: Deactivate ehcache
rhtyd commented on issue #2913: Deactivate ehcache URL: https://github.com/apache/cloudstack/pull/2913#issuecomment-432136970 @marcaurele the idea of ehcache was to reduce some load to the db server. Can you start a discussion thread on dev@ with details like what and how you'll replace ehcache. And your long term plan re:DB refactoring, the goals, proposed timeline etc. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] marcaurele commented on issue #2913: Deactivate ehcache
marcaurele commented on issue #2913: Deactivate ehcache URL: https://github.com/apache/cloudstack/pull/2913#issuecomment-432119404 @rafaelweingartner @rhtyd Before doing to much work if people would not agree with my findings I simply wanted to push this PR to open the discussion on ehcache topic. I will post another one removing all the code that use ehcache to clean it up if this one is going to be merged. Are those findings not a surprise to you ? cc @wido This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
