[GitHub] rhtyd commented on issue #2995: Improvements on upload direct download certificates
rhtyd commented on issue #2995: Improvements on upload direct download certificates URL: https://github.com/apache/cloudstack/pull/2995#issuecomment-435268315 @nvazquez please check build failure This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] bdonnahue commented on issue #2996: GRE Isolation Broken in VPC Tier
bdonnahue commented on issue #2996: GRE Isolation Broken in VPC Tier URL: https://github.com/apache/cloudstack/issues/2996#issuecomment-435237852 Making the network redundant does not create any more router vms This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] bdonnahue commented on issue #2996: GRE Isolation Broken in VPC Tier
bdonnahue commented on issue #2996: GRE Isolation Broken in VPC Tier URL: https://github.com/apache/cloudstack/issues/2996#issuecomment-435237812 When I move the router from host A to host B, all the vms on host A loose connectivity to the tier network and the internet. All the vms on host B then get connectivity to the tier network and the internet This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2919: vmware: updateVmwareDc API for updating vmware datacenter details
blueorangutan commented on issue #2919: vmware: updateVmwareDc API for updating vmware datacenter details URL: https://github.com/apache/cloudstack/pull/2919#issuecomment-435210816 Trillian test result (tid-3138) Environment: vmware-65 (x2), Advanced Networking with Mgmt server 7 Total time taken: 36911 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2919-t3138-vmware-65.zip Intermittent failure detected: /marvin/tests/smoke/test_multipleips_per_nic.py Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py Smoke tests completed. 66 look OK, 3 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_nic_secondaryip_add_remove | `Error` | 98.35 | test_multipleips_per_nic.py ContextSuite context=Test03SecuredVmMigration>:teardown | `Error` | 0.00 | test_vm_life_cycle.py test_04_rvpc_network_garbage_collector_nics | `Failure` | 576.09 | test_vpc_redundant.py This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] bdonnahue opened a new issue #2996: GRE Isolation Broken in VPC Tier
bdonnahue opened a new issue #2996: GRE Isolation Broken in VPC Tier URL: https://github.com/apache/cloudstack/issues/2996 # ISSUE TYPE * Bug Report # COMPONENT NAME GRE Isolation / VPC Tier # CLOUDSTACK VERSION 4.11.2.0 # CONFIGURATION I have a VPC and a VPC Tier I have an advanced zone which uses GRE Isolation The zone hosts one pod and two clusters. Each cluster has its own XenServer hypervisor # OS / ENVIRONMENT N/A # SUMMARY I created wto VMs on two different hosts and attached them to the same vpc tier. The vms cannot communicate with eachother. # STEPS TO REPRODUCE Create the advanced zone with GRE Tunnel Isolation Create two clusters Attach a host to each of the clusters Create VMs on each host which are conected to same vpc tier Ping host A from host B # EXPECTED RESULTS DHCP lease assigned to both vms Both vms can ping internet and eachother # ACTUAL RESULTS No lease assigned to one of the VMs (the one not on the same machine as the router vm) VMs cannot ping across hosts This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2919: vmware: updateVmwareDc API for updating vmware datacenter details
blueorangutan commented on issue #2919: vmware: updateVmwareDc API for updating vmware datacenter details URL: https://github.com/apache/cloudstack/pull/2919#issuecomment-435152661 Trillian test result (tid-3139) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 22306 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2919-t3139-kvm-centos7.zip Intermittent failure detected: /marvin/tests/smoke/test_multipleips_per_nic.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py Smoke tests completed. 67 look OK, 2 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_nic_secondaryip_add_remove | `Error` | 29.73 | test_multipleips_per_nic.py test_04_rvpc_network_garbage_collector_nics | `Failure` | 459.94 | test_vpc_redundant.py test_05_rvpc_multi_tiers | `Failure` | 322.87 | test_vpc_redundant.py test_05_rvpc_multi_tiers | `Error` | 344.88 | test_vpc_redundant.py This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] nvazquez opened a new pull request #2995: Improvements on upload direct download certificates
nvazquez opened a new pull request #2995: Improvements on upload direct download certificates URL: https://github.com/apache/cloudstack/pull/2995 ## Description Report cases of failure, API method 'uploadTemplateDirectDownloadCertificate' always returns 'success:true' ## Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [ ] Bug fix (non-breaking change which fixes an issue) - [x] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) ## Screenshots (if appropriate): ## How Has This Been Tested? 2 KVM hosts - Upload valid certificate, verify certificate is imported on both hosts -> OK - Upload invalid certificate -> ERROR - Upload existing alias certificate -> ERROR This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[cloudstack-www] branch master updated (080ff81 -> 35ad18c)
This is an automated email from the ASF dual-hosted git repository. paul_a pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack-www.git. from 080ff81 build site add 2efe9c6 content: dummy commit to force website publishing add 9c258a0 Merge branch 'master' into asf-site add 574c596 Merge branch 'master' into asf-site add 63886d2 Merge remote-tracking branch 'apache/master' into asf-site add 4d922a1 Merge remote-tracking branch 'apache/master' into asf-site add 644cc15 Merge branch 'master' into asf-site add aea7db3 resolving a whitespace diff with the master branch add 7b1c726 Merge branch 'master' into asf-site add 4ddcf1f updating with lastest html for 4.10.0.0 add ad9b8ba Merge branch 'master' into asf-site add 219c687 Merge branch 'master' into asf-site add 33df99f Merge branch 'master' into asf-site add f2bd2c4 update website for 4.9.3.0 release add 99844fb Merge branch 'master' into asf-site add 481553c build/include changes from master add 7157d47 Merge branch 'master' into asf-site add 57bae57 regenerate/publish website add c2cdd2a Merge branch 'master' into asf-site add 191cd86 update website add 6ab9a76 Merge remote-tracking branch 'origin/master' into asf-site add 756b7c3 Merge remote-tracking branch 'origin/master' into asf-site add ca53594 Merge branch 'master' into asf-site add 839004f publish site add b2bcb1a Merge branch 'master' into asf-site add 4daa65b Merge branch 'master' into asf-site add 0684626 updated PR44 to include compiled content add 94807d6 Merge branch 'master' into asf-site add ef3f9e8 update downloads page for 4.11.1.0 add 61d9447 Merge pull request #45 from shapeblue/4.11.1 add 908fed0 Merge branch 'master' into asf-site add 5195e21 Restructure Docs dropdown to use consolidated Doc site and show archived documentation add 76f8163 Merge pull request #46 from shapeblue/asf-site new 35ad18c Merge pull request #50 from apache/asf-site The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: content/about.html| 11 +++ content/api.html | 11 +++ content/api_archives.html | 11 +++ content/archives.html | 12 content/bylaws.html | 11 +++ content/cloudstack-faq.html | 11 +++ content/contribute.html | 11 +++ content/developers.html | 11 +++ content/downloads.html| 27 +++ content/features.html | 11 +++ content/history.html | 11 +++ content/index.html| 13 - content/mailing-lists.html| 11 +++ content/security.html | 11 +++ content/software.html | 11 +++ content/survey.html | 11 +++ content/trademark-guidelines.html | 11 +++ content/users.html| 11 +++ content/videos.html | 11 +++ content/who.html | 11 +++ data/cloudstack.yml | 3 ++- source/layouts/layout.erb | 11 +++ 22 files changed, 159 insertions(+), 94 deletions(-)
[cloudstack-www] 01/01: Merge pull request #50 from apache/asf-site
This is an automated email from the ASF dual-hosted git repository. paul_a pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack-www.git commit 35ad18c849d6ce05355af3d85a29154d65083b36 Merge: 080ff81 76f8163 Author: Paul Angus AuthorDate: Thu Nov 1 17:28:14 2018 + Merge pull request #50 from apache/asf-site Merge Current ASF site back into master. (merging as this is what is already live - and has been for some time) content/about.html| 11 +++ content/api.html | 11 +++ content/api_archives.html | 11 +++ content/archives.html | 12 content/bylaws.html | 11 +++ content/cloudstack-faq.html | 11 +++ content/contribute.html | 11 +++ content/developers.html | 11 +++ content/downloads.html| 27 +++ content/features.html | 11 +++ content/history.html | 11 +++ content/index.html| 13 - content/mailing-lists.html| 11 +++ content/security.html | 11 +++ content/software.html | 11 +++ content/survey.html | 11 +++ content/trademark-guidelines.html | 11 +++ content/users.html| 11 +++ content/videos.html | 11 +++ content/who.html | 11 +++ data/cloudstack.yml | 3 ++- source/layouts/layout.erb | 11 +++ 22 files changed, 159 insertions(+), 94 deletions(-)
[GitHub] mike-tutkowski commented on a change in pull request #2983: KVM live storage migration intra cluster from NFS source and destination
mike-tutkowski commented on a change in pull request #2983: KVM live storage
migration intra cluster from NFS source and destination
URL: https://github.com/apache/cloudstack/pull/2983#discussion_r230099847
##
File path:
engine/storage/datamotion/src/main/java/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java
##
@@ -1991,8 +2198,49 @@ private void
verifyLiveMigrationMapForKVM(Map volumeDataS
throw new CloudRuntimeException("Destination storage pool with
ID " + dataStore.getId() + " was not located.");
}
+if (storageTypeConsistency == null) {
Review comment:
Ah, yes, my mistake. The code view had a section collapsed and I didn't see
the looping.
OK, I've gone through the contents of the PR and it LGTM. Thanks!
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] svenvogel opened a new issue #2994: add complete domain name to account (ui problem / enhancement)
svenvogel opened a new issue #2994: add complete domain name to account (ui problem / enhancement) URL: https://github.com/apache/cloudstack/issues/2994 # ISSUE TYPE * Bug Report * Improvement Request # COMPONENT NAME ~~~ UI ~~~ # CLOUDSTACK VERSION ~~~ 4.11->4.12 ~~~ # CONFIGURATION advanced network # OS / ENVIRONMENT CentOS7 # SUMMARY When we add a User to a Subdomain we dont see the complete path of the hierarchy. If we have much User Account its very complicated to find out where the user was added. We only see the Sub-Domain but for Login we need understandably the Complete Path -> "Dummy/Dummy Sub Domain" # STEPS TO REPRODUCE 1. Create a new User from LDAP or local Account and add them to a "Dummy/Dummy Sub Domain"  2. Create a another Domain with the same Name "ROOT/Dummy Sub Domain"  3. we can only see the subdomain name but not the complete path "Dummy/Dummy Sub Domain" and "ROOT/Dummy Sub Domain"  **Sorry Guys. I'd like to help to improve the GUI and maybe my input could be useful to you. To my mind the GUI is the prime and essential contact point for all users.** # EXPECTED RESULTS Normally we should see the complete path because we also need them for login and we can find the user in the correct domains. Its strange for a user and admin. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] marcaurele opened a new pull request #2993: Remove api rate limiting plugin
marcaurele opened a new pull request #2993: Remove api rate limiting plugin URL: https://github.com/apache/cloudstack/pull/2993 ## Description Remove the API rate limiting plugin. This will ease the removal of ehcache in CS completely, and this feature can be configured on a HTTP frontend like Nginx to perform the same job. [Discussion](https://lists.apache.org/thread.html/5699105e2153408fc35556409ef63499fc2c973e2d5c784130b5f617@%3Cdev.cloudstack.apache.org%3E) in the dev mailing list. Link to initial discussion about ehcache: #2913. The PR can be closed if people still want this feature in the code. ## Types of changes - [x] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[cloudstack] branch master updated: Fix set affinity for user overlay problem (Fixes #2986) (#2987)
This is an automated email from the ASF dual-hosted git repository.
rafael pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git
The following commit(s) were added to refs/heads/master by this push:
new e175e93 Fix set affinity for user overlay problem (Fixes #2986)
(#2987)
e175e93 is described below
commit e175e93281254d7cbe5b2990084e567d0dd7f3ad
Author: Rafael Weingärtner
AuthorDate: Thu Nov 1 10:30:53 2018 -0300
Fix set affinity for user overlay problem (Fixes #2986) (#2987)
This PR fixes #2986
---
ui/scripts/ui-custom/affinity.js | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/ui/scripts/ui-custom/affinity.js b/ui/scripts/ui-custom/affinity.js
index e4a87dd..d074093 100644
--- a/ui/scripts/ui-custom/affinity.js
+++ b/ui/scripts/ui-custom/affinity.js
@@ -136,8 +136,8 @@
});
}
}]
-}).parent('.ui-dialog').overlay();
-
+});
+
cloudStack.applyDefaultZindexAndOverlayOnJqueryDialogAndRemoveCloseButton($dataList);
// Add tier select dialog
if (tierSelect) {
var $toolbar = $dataList.find('.toolbar');
[GitHub] rafaelweingartner commented on issue #2987: Fix set affinity for user overlay problem (Fixes #2986)
rafaelweingartner commented on issue #2987: Fix set affinity for user overlay problem (Fixes #2986) URL: https://github.com/apache/cloudstack/pull/2987#issuecomment-435041441 I am considering the LGTM given by @svenvogel on #2986. Therefore, I will merge this PR. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rafaelweingartner closed pull request #2987: Fix set affinity for user overlay problem (Fixes #2986)
rafaelweingartner closed pull request #2987: Fix set affinity for user overlay
problem (Fixes #2986)
URL: https://github.com/apache/cloudstack/pull/2987
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/ui/scripts/ui-custom/affinity.js b/ui/scripts/ui-custom/affinity.js
index e4a87dddfcc..d0740930430 100644
--- a/ui/scripts/ui-custom/affinity.js
+++ b/ui/scripts/ui-custom/affinity.js
@@ -136,8 +136,8 @@
});
}
}]
-}).parent('.ui-dialog').overlay();
-
+});
+
cloudStack.applyDefaultZindexAndOverlayOnJqueryDialogAndRemoveCloseButton($dataList);
// Add tier select dialog
if (tierSelect) {
var $toolbar = $dataList.find('.toolbar');
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] rafaelweingartner closed issue #2986: set affinity for user (ui problem)
rafaelweingartner closed issue #2986: set affinity for user (ui problem) URL: https://github.com/apache/cloudstack/issues/2986 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2992: PoC for log library surface reduction (2991)
blueorangutan commented on issue #2992: PoC for log library surface reduction (2991) URL: https://github.com/apache/cloudstack/pull/2992#issuecomment-435032223 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2403 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] DaanHoogland commented on a change in pull request #2992: PoC for log library surface reduction (2991)
DaanHoogland commented on a change in pull request #2992: PoC for log library
surface reduction (2991)
URL: https://github.com/apache/cloudstack/pull/2992#discussion_r230030279
##
File path: utils/src/main/java/org/apache/cloudstack/utils/log/Logger.java
##
@@ -0,0 +1,41 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.cloudstack.utils.log;
+
+/**
+ * wrapper class for the logging functionality of the log library in use
+ */
+public class Logger {
+private org.apache.log4j.Logger logger;
+public Logger(org.apache.log4j.Logger logger) {
+this.logger = logger;
+}
+
+public void warn(String s, Exception e) {
+logger.warn(s,e);
+}
+
+public void info(String s) {
+logger.info(s);
+}
+
+public void error(String s) {
Review comment:
I will as we progress change the interface to what we really use. I am also
still considering to use an actual java-interface. Unfortunately java requires
an explicit 'implements', otherwise the proxy mechs would be some easier.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] marcaurele commented on issue #2992: PoC for log library surface reduction (2991)
marcaurele commented on issue #2992: PoC for log library surface reduction (2991) URL: https://github.com/apache/cloudstack/pull/2992#issuecomment-435027136 Good change to move all the logs under a single class to ease any future changes or choice of library. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] marcaurele commented on a change in pull request #2992: PoC for log library surface reduction (2991)
marcaurele commented on a change in pull request #2992: PoC for log library
surface reduction (2991)
URL: https://github.com/apache/cloudstack/pull/2992#discussion_r230027046
##
File path: utils/src/main/java/org/apache/cloudstack/utils/log/Logger.java
##
@@ -0,0 +1,41 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.cloudstack.utils.log;
+
+/**
+ * wrapper class for the logging functionality of the log library in use
+ */
+public class Logger {
+private org.apache.log4j.Logger logger;
+public Logger(org.apache.log4j.Logger logger) {
+this.logger = logger;
+}
+
+public void warn(String s, Exception e) {
+logger.warn(s,e);
+}
+
+public void info(String s) {
+logger.info(s);
+}
+
+public void error(String s) {
Review comment:
Can you add a`public void error (String msg, Throwable e)` and change the
`public void warn(String s, Exception e)` to `public void warn(String s,
Throwable e)`
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] blueorangutan commented on issue #2919: vmware: updateVmwareDc API for updating vmware datacenter details
blueorangutan commented on issue #2919: vmware: updateVmwareDc API for updating vmware datacenter details URL: https://github.com/apache/cloudstack/pull/2919#issuecomment-435026495 @borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] borisstoyanov commented on issue #2919: vmware: updateVmwareDc API for updating vmware datacenter details
borisstoyanov commented on issue #2919: vmware: updateVmwareDc API for updating vmware datacenter details URL: https://github.com/apache/cloudstack/pull/2919#issuecomment-435026389 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2992: PoC for log library surface reduction (2991)
blueorangutan commented on issue #2992: PoC for log library surface reduction (2991) URL: https://github.com/apache/cloudstack/pull/2992#issuecomment-435025788 @DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] DaanHoogland commented on issue #2992: PoC for log library surface reduction (2991)
DaanHoogland commented on issue #2992: PoC for log library surface reduction (2991) URL: https://github.com/apache/cloudstack/pull/2992#issuecomment-435025739 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2896: add exitcode / distribution detection and remove export CGROUP_DAEMON for RHEL7/CentOS7
blueorangutan commented on issue #2896: add exitcode / distribution detection and remove export CGROUP_DAEMON for RHEL7/CentOS7 URL: https://github.com/apache/cloudstack/pull/2896#issuecomment-435022024 Trillian test result (tid-3137) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 21426 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2896-t3137-kvm-centos7.zip Intermittent failure detected: /marvin/tests/smoke/test_multipleips_per_nic.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py Smoke tests completed. 66 look OK, 3 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_nic_secondaryip_add_remove | `Error` | 22.04 | test_multipleips_per_nic.py test_04_rvpc_network_garbage_collector_nics | `Failure` | 451.57 | test_vpc_redundant.py test_01_redundant_vpc_site2site_vpn | `Failure` | 206.27 | test_vpc_vpn.py This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2919: vmware: updateVmwareDc API for updating vmware datacenter details
blueorangutan commented on issue #2919: vmware: updateVmwareDc API for updating vmware datacenter details URL: https://github.com/apache/cloudstack/pull/2919#issuecomment-435020135 Packaging result: ✔centos6 ✔centos7 ✖debian. JID-2402 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2919: vmware: updateVmwareDc API for updating vmware datacenter details
blueorangutan commented on issue #2919: vmware: updateVmwareDc API for updating vmware datacenter details URL: https://github.com/apache/cloudstack/pull/2919#issuecomment-435019405 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-65) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2919: vmware: updateVmwareDc API for updating vmware datacenter details
rhtyd commented on issue #2919: vmware: updateVmwareDc API for updating vmware datacenter details URL: https://github.com/apache/cloudstack/pull/2919#issuecomment-435019343 @blueorangutan test centos7 vmware-65 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2919: vmware: updateVmwareDc API for updating vmware datacenter details
blueorangutan commented on issue #2919: vmware: updateVmwareDc API for updating vmware datacenter details URL: https://github.com/apache/cloudstack/pull/2919#issuecomment-435018103 Packaging result: ✔centos6 ✔centos7 ✖debian. JID-2401 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] DaanHoogland opened a new pull request #2992: PoC for log library surface reduction (2991)
DaanHoogland opened a new pull request #2992: PoC for log library surface reduction (2991) URL: https://github.com/apache/cloudstack/pull/2992 ## Description part of #1991, this is the initial step to unifying the log libraries and put the surface in a single location. Note that even for this one functionality about half the files in the entire project will be touched in the end. This one and the StringUtils one are probably the biggest. This and the gson one will be the more complicated than StringUtils. The DAO framework will have even more impact but the may be out of scope for #2991 ## Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] Enhancement (improves an existing feature and functionality) - [x] Cleanup (Code refactoring and cleanup, that may add test cases) ## Screenshots (if appropriate): ## How Has This Been Tested? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2919: vmware: updateVmwareDc API for updating vmware datacenter details
blueorangutan commented on issue #2919: vmware: updateVmwareDc API for updating vmware datacenter details URL: https://github.com/apache/cloudstack/pull/2919#issuecomment-435011594 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2919: vmware: updateVmwareDc API for updating vmware datacenter details
rhtyd commented on issue #2919: vmware: updateVmwareDc API for updating vmware datacenter details URL: https://github.com/apache/cloudstack/pull/2919#issuecomment-435011414 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] DaanHoogland opened a new issue #2991: library surface reduction
DaanHoogland opened a new issue #2991: library surface reduction URL: https://github.com/apache/cloudstack/issues/2991 library interface surfaces should be reduced to improve portability and upgradability. examples of lockins that cloudstack suffers from are gson, stringutils and even the completely Apache internal log4j1.2 to log4j2 upgrade is a problem because of this. jira issue CLOUDSTACK-10089 asks for a log4j update. other issues have been encountered in teh past (will add references if i encounter them) # ISSUE TYPE * Improvement Request # COMPONENT NAME ~~~ cross cutting concern ~~~ # CLOUDSTACK VERSION ~~~ all ~~~ # CONFIGURATION # OS / ENVIRONMENT # SUMMARY I think a number of PR need to be created for the mentioned utilities and maybe others to smoothly get to a maintainable situation. Each of them must have all functionality used in CloudStack proxied in them. # STEPS TO REPRODUCE ~~~ when upgrading or migrating from a library to a library of similar funvctionality, changes should only have to be made in one area of the cloudstack code base. This is the ideal situation and may never be true for 3rd party plugins for instance. Big improvements can be made however on the mentioned libraries * StringUtils * Gson (json utilities) * logging ~~~ # EXPECTED RESULTS ~~~ one class or package at most has to be changed when upgrading or migrating ~~~ # ACTUAL RESULTS ~~~ a plethora of hundreds of files need to be changed for each upgrade, risking numerous regressions due to oversights or misinterpretations of coding styles. ~~~ This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] svenvogel commented on a change in pull request #2980: [4.11] Fix set initial reservation on public IP ranges
svenvogel commented on a change in pull request #2980: [4.11] Fix set initial
reservation on public IP ranges
URL: https://github.com/apache/cloudstack/pull/2980#discussion_r229993697
##
File path: server/src/com/cloud/configuration/ConfigurationManagerImpl.java
##
@@ -3569,10 +3569,10 @@ public VlanVO doInTransaction(final TransactionStatus
status) {
}
// increment resource count for dedicated public ip's
_resourceLimitMgr.incrementResourceCount(vlanOwner.getId(),
ResourceType.public_ip, new Long(ips.size()));
-} else if (domain != null) {
+} else if (domain != null && !forSystemVms) {
// This VLAN is domain-wide, so create a DomainVlanMapVO
entry
-//final DomainVlanMapVO domainVlanMapVO = new
DomainVlanMapVO(domain.getId(), vlan.getId());
-//_domainVlanMapDao.persist(domainVlanMapVO);
+final DomainVlanMapVO domainVlanMapVO = new
DomainVlanMapVO(domain.getId(), vlan.getId());
Review comment:
@nvazquez is there any problem to merge it?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] svenvogel commented on issue #2980: [4.11] Fix set initial reservation on public IP ranges
svenvogel commented on issue #2980: [4.11] Fix set initial reservation on public IP ranges URL: https://github.com/apache/cloudstack/pull/2980#issuecomment-434993954 @nvazquez will it merged? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2919: vmware: updateVmwareDc API for updating vmware datacenter details
blueorangutan commented on issue #2919: vmware: updateVmwareDc API for updating vmware datacenter details URL: https://github.com/apache/cloudstack/pull/2919#issuecomment-434993310 Packaging result: ✖centos6 ✔centos7 ✔debian. JID-2400 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2919: vmware: updateVmwareDc API for updating vmware datacenter details
blueorangutan commented on issue #2919: vmware: updateVmwareDc API for updating vmware datacenter details URL: https://github.com/apache/cloudstack/pull/2919#issuecomment-434986963 @borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] borisstoyanov commented on issue #2919: vmware: updateVmwareDc API for updating vmware datacenter details
borisstoyanov commented on issue #2919: vmware: updateVmwareDc API for updating vmware datacenter details URL: https://github.com/apache/cloudstack/pull/2919#issuecomment-434986784 thanks @rhtyd @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
