[GitHub] rhtyd commented on issue #3030: correct permissions in spec file and fix class path specified variable
rhtyd commented on issue #3030: correct permissions in spec file and fix class path specified variable URL: https://github.com/apache/cloudstack/pull/3030#issuecomment-438910590 Nevermind my comment for centos6, it does not have systemd so I guess does not apply. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd edited a comment on issue #3030: correct permissions in spec file and fix class path specified variable
rhtyd edited a comment on issue #3030: correct permissions in spec file and fix class path specified variable URL: https://github.com/apache/cloudstack/pull/3030#issuecomment-438910445 LGTM, @svenvogel if possible could you rebase and edit the branch to 4.11. It will be useful to get this for 4.11 as well. Also, do you think we should also fix for el6/centos6 spec? Thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #3030: correct permissions in spec file and fix class path specified variable
rhtyd commented on issue #3030: correct permissions in spec file and fix class path specified variable URL: https://github.com/apache/cloudstack/pull/3030#issuecomment-438910445 LGTM, @svenvogel if possible could you rebase and edit the branch to 4.11. It will be useful to get this for 4.11 as well. Thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #3031: VMware basic zone VR fails to start and get private IP
rhtyd commented on issue #3031: VMware basic zone VR fails to start and get private IP URL: https://github.com/apache/cloudstack/issues/3031#issuecomment-438909586 /cc @mike-tutkowski @PaulAngus - not a regression in 4.11 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd opened a new issue #3031: VMware basic zone VR fails to start and get private IP
rhtyd opened a new issue #3031: VMware basic zone VR fails to start and get private IP URL: https://github.com/apache/cloudstack/issues/3031 VMware basic zone does not support host-level firewall (SG), but there could be a use-case to have a basic zone setup with no isolation. Currently, the VR for the default basic zone guest network VR fails to start (gets stuck in Starting state for a long time) due to incorrect `eth1` IP/netmask. Screenshot from 4.9 VR:  # ISSUE TYPE * Bug Report # COMPONENT NAME ~~~ VR, Basic Zone, VMware ~~~ # CLOUDSTACK VERSION ~~~ Found in 4.9, 4.11, master ~~~ # CONFIGURATION Basic zone with VMware 5.5u3, 6.5 # SUMMARY # STEPS TO REPRODUCE ~~~ - Deploy basic zone in VMware - Deploy a guest VM - Guest network VR will be stuck - The /var/cache/cloud/cmdline will have 0.0.0.0 as eth1 ip/netmask ~~~ # EXPECTED RESULTS ~~~ While SG does not work for VMware+basic zone, VR should start and get a private IP (eth1) ~~~ # ACTUAL RESULTS ~~~ VR stuck in starting state, guest VM eventually fails to start. VR's eth1 does not get a valid IP. ~~~ This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] svenvogel opened a new pull request #3030: correct permissions in spec file and fix class path specified variable
svenvogel opened a new pull request #3030: correct permissions in spec file and
fix class path specified variable
URL: https://github.com/apache/cloudstack/pull/3030
## Description
There are only two small, small, small really small fixes.
Install CentOS 7 e.g. Build 1804 and Java build 1.8.0_181
if you inspect systemd in debug mode you will see some errors
1.
permission of the cloudstack-managment.service are not corretly set
2.
invalid classpath specified. it seems the string which is used will be
divided... we now we use ${..} like the lines above ... :confused:
## Types of changes
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [X] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
## Screenshots (if appropriate):
## How Has This Been Tested?
We tested it on our test environment! We create own build with our test
pipeline.
CentOS 7 Build 1804, Cloudstack 4.11, Java Build 1.8.0_181, systemd Build
219-57.el7_5.3
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] blueorangutan commented on issue #3028: Adding zone disablement during deletion of the range plus one more tr…
blueorangutan commented on issue #3028: Adding zone disablement during deletion of the range plus one more tr… URL: https://github.com/apache/cloudstack/pull/3028#issuecomment-438849118 Trillian test result (tid-3180) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 20279 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3028-t3180-kvm-centos7.zip Intermittent failure detected: /marvin/tests/smoke/test_multipleips_per_nic.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py Smoke tests completed. 68 look OK, 2 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_nic_secondaryip_add_remove | `Error` | 23.07 | test_multipleips_per_nic.py test_04_rvpc_network_garbage_collector_nics | `Failure` | 441.25 | test_vpc_redundant.py This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] bdonnahue commented on issue #2583: CPU cores per socket setting not functional
bdonnahue commented on issue #2583: CPU cores per socket setting not functional URL: https://github.com/apache/cloudstack/issues/2583#issuecomment-438808992 @rhtyd ok. I will reach out again in a few weeks to see how things are going. Thanks for the help on this! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] bdonnahue commented on issue #2996: [Bug Report] - GRE Isolation Broken in VPC Tier
bdonnahue commented on issue #2996: [Bug Report] - GRE Isolation Broken in VPC Tier URL: https://github.com/apache/cloudstack/issues/2996#issuecomment-438807099 @DaanHoogland will to. I was able to track down who I think is the author who i believe is @frank-zhang with commit https://github.com/apache/cloudstack/commit/276e37115b58fde14602aa7d017cc1aded276ace I will also see if I can reach out to him This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] bdonnahue edited a comment on issue #2996: [Bug Report] - GRE Isolation Broken in VPC Tier
bdonnahue edited a comment on issue #2996: [Bug Report] - GRE Isolation Broken in VPC Tier URL: https://github.com/apache/cloudstack/issues/2996#issuecomment-438807099 @DaanHoogland will do. I was able to track down who I think is the author who i believe is @frank-zhang with commit https://github.com/apache/cloudstack/commit/276e37115b58fde14602aa7d017cc1aded276ace This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] svenvogel opened a new issue #3029: project - infrastructure - Select View (ui problem)
svenvogel opened a new issue #3029: project - infrastructure - Select View (ui problem) URL: https://github.com/apache/cloudstack/issues/3029 # ISSUE TYPE * Bug Report # COMPONENT NAME ~~~ UI ~~~ # CLOUDSTACK VERSION ~~~ 4.11 ~~~ # CONFIGURATION advanced networking # OS / ENVIRONMENT CentOS7 # SUMMARY If you are a "admin" user (Role Type: admin) select a created project goto infrastructur -> virtual routers -> select view -> group by account then you get an "account and project id can't be specified together" # STEPS TO REPRODUCE 1. create a dummy / example project and select it  2. select "Infrastructure"  3. go to "Virtual Router"  4. you will see some router like the picture below  5. "select view" -> "group by account"  6. you get after some time (bubble of the ring) the following error or message "Account and projectId can't be specified together"  7. after the window popup you can click on close and see the account view and the message will not go away...  # EXPECTED RESULTS ~~~ Normally there should not come this error or message i think. it should be only group the objects! ~~~ This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] GabrielBrascher commented on a change in pull request #3026: Enhance bypass vlan overlap check
GabrielBrascher commented on a change in pull request #3026: Enhance bypass
vlan overlap check
URL: https://github.com/apache/cloudstack/pull/3026#discussion_r233532428
##
File path:
engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java
##
@@ -2200,7 +2200,7 @@ public Network createGuestNetwork(final long
networkOfferingId, final String nam
}
if (! UuidUtils.validateUUID(vlanId)){
// For Isolated and L2 networks, don't allow to create network
with vlan that already exists in the zone
-if (ntwkOff.getGuestType() == GuestType.Isolated ||
ntwkOff.getGuestType() == GuestType.L2) {
+if (ntwkOff.getGuestType() == GuestType.Isolated ||
!(bypassVlanOverlapCheck && ntwkOff.getGuestType() == GuestType.L2)) {
Review comment:
@gmueller-ewerk this conditional is growing. Can you please extract it to a
method? With such a method, it would be possible to have a Javadoc and a couple
of JUnit test methods asserting the expected behavior.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] blueorangutan commented on issue #3028: Adding zone disablement during deletion of the range plus one more tr…
blueorangutan commented on issue #3028: Adding zone disablement during deletion of the range plus one more tr… URL: https://github.com/apache/cloudstack/pull/3028#issuecomment-438733518 @borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] borisstoyanov commented on issue #3028: Adding zone disablement during deletion of the range plus one more tr…
borisstoyanov commented on issue #3028: Adding zone disablement during deletion of the range plus one more tr… URL: https://github.com/apache/cloudstack/pull/3028#issuecomment-438733401 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #3028: Adding zone disablement during deletion of the range plus one more tr…
blueorangutan commented on issue #3028: Adding zone disablement during deletion of the range plus one more tr… URL: https://github.com/apache/cloudstack/pull/3028#issuecomment-438727129 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2441 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] borisstoyanov commented on issue #3028: Adding zone disablement during deletion of the range plus one more tr…
borisstoyanov commented on issue #3028: Adding zone disablement during deletion of the range plus one more tr… URL: https://github.com/apache/cloudstack/pull/3028#issuecomment-438719465 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] borisstoyanov removed a comment on issue #3028: Adding zone disablement during deletion of the range plus one more tr…
borisstoyanov removed a comment on issue #3028: Adding zone disablement during deletion of the range plus one more tr… URL: https://github.com/apache/cloudstack/pull/3028#issuecomment-438719265 @blueoranguran package This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] borisstoyanov commented on issue #3028: Adding zone disablement during deletion of the range plus one more tr…
borisstoyanov commented on issue #3028: Adding zone disablement during deletion of the range plus one more tr… URL: https://github.com/apache/cloudstack/pull/3028#issuecomment-438719265 @blueoranguran package This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] borisstoyanov opened a new pull request #3028: Adding zone disablement during deletion of the range plus one more tr…
borisstoyanov opened a new pull request #3028: Adding zone disablement during deletion of the range plus one more tr… URL: https://github.com/apache/cloudstack/pull/3028 …nce it's failing other tests ## Description Disabling the execution of tests that SystemVMs acquire mocked public IPs, since it's braking other tests along the execution. ## Types of changes - [X] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [X] Bug fix (non-breaking change which fixes an issue) - [ ] Enhancement (improves an existing feature and functionality) - [X] Cleanup (Code refactoring and cleanup, that may add test cases) ## Screenshots (if appropriate): NA ## How Has This Been Tested? The tests were executed and the marked one were skipped ping @PaulAngus @blueoranguran package This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] DaanHoogland commented on issue #2992: PoC for log library surface reduction (2991)
DaanHoogland commented on issue #2992: PoC for log library surface reduction (2991) URL: https://github.com/apache/cloudstack/pull/2992#issuecomment-438705975 ok, you will fail, but I will be patient for another day. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rafaelweingartner commented on issue #2992: PoC for log library surface reduction (2991)
rafaelweingartner commented on issue #2992: PoC for log library surface reduction (2991) URL: https://github.com/apache/cloudstack/pull/2992#issuecomment-438705466 I understand that is not a feature, but I do not agree that this will help. I will try to write something until tomorrow to explain why. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] DaanHoogland commented on issue #2992: PoC for log library surface reduction (2991)
DaanHoogland commented on issue #2992: PoC for log library surface reduction (2991) URL: https://github.com/apache/cloudstack/pull/2992#issuecomment-438702885 This is not a feature, @rafaelweingartner . It is a way to make the system a bit more maintainable and deal with technical debt. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] DagSonsteboSB opened a new issue #3027: VMware hosted VM with ISO attached live migration failure
DagSonsteboSB opened a new issue #3027: VMware hosted VM with ISO attached live migration failure URL: https://github.com/apache/cloudstack/issues/3027 # ISSUE TYPE * Bug Report # COMPONENT NAME CloudStack management # CLOUDSTACK VERSION 4.11.1 4.11.2-RC5 (hence possibly 4.11.2) # CONFIGURATION * Advanced zone * VMware vSphere 5.5u3 * CloudStack management versions as above * VM with ISO attached # OS / ENVIRONMENT N/A # SUMMARY * Migration of VM with ISO attached fails ungracefully. * Not clear if this is a limitation of VMware # STEPS TO REPRODUCE * Create VM, attach ISO * Attempt to migrate VM from one ESXi host to another. * Observe GUI error: MigrationCommand failed due to Exception: java.lang.RuntimeException Message: Currently connected device 'CD/DVD drive 1' uses backing '[] /usr/lib/vmware/isoimages/linux.iso', which is not accessible. * Log error: 2018-11-14 13:54:37,747 WARN [c.c.h.v.r.VmwareResource] (DirectAgent-69:ctx-ddc4714b 10.2.3.180, job-33/job-34, cmd: MigrateCommand) (logid:96e22c89) MigrationCommand failed due to Exception: java.lang.RuntimeException Message: Currently connected device 'CD/DVD drive 1' uses backing '[] /usr/lib/vmware/isoimages/linux.iso', which is not accessible. java.lang.RuntimeException: Currently connected device 'CD/DVD drive 1' uses backing '[] /usr/lib/vmware/isoimages/linux.iso', which is not accessible. at com.cloud.hypervisor.vmware.util.VmwareClient.waitForTask(VmwareClient.java:358) at com.cloud.hypervisor.vmware.mo.VirtualMachineMO.migrate(VirtualMachineMO.java:415) at com.cloud.hypervisor.vmware.resource.VmwareResource.execute(VmwareResource.java:3814) at com.cloud.hypervisor.vmware.resource.VmwareResource.executeRequest(VmwareResource.java:444) at com.cloud.agent.manager.DirectAgentAttache$Task.runInContext(DirectAgentAttache.java:315) at org.apache.cloudstack.managed.context.ManagedContextRunnable$1.run(ManagedContextRunnable.java:49) at org.apache.cloudstack.managed.context.impl.DefaultManagedContext$1.call(DefaultManagedContext.java:56) at org.apache.cloudstack.managed.context.impl.DefaultManagedContext.callWithContext(DefaultManagedContext.java:103) at org.apache.cloudstack.managed.context.impl.DefaultManagedContext.runWithContext(DefaultManagedContext.java:53) at org.apache.cloudstack.managed.context.ManagedContextRunnable.run(ManagedContextRunnable.java:46) at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) at java.util.concurrent.FutureTask.run(FutureTask.java:266) at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:180) at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:293) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) at java.lang.Thread.run(Thread.java:748) 2018-11-14 13:54:37,748 DEBUG [c.c.a.m.DirectAgentAttache] (DirectAgent-69:ctx-ddc4714b) (logid:96e22c89) Seq 2-6622824727025025088: Response Received: * VC error: Currently connected device 'CD/DVD drive 1' uses backing '[] /usr/lib/vmware/isoimages/linux.iso', which is not accessible. # EXPECTED RESULTS * Graceful error or successful migration. # ACTUAL RESULTS * Errors as above. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] GabrielBrascher commented on a change in pull request #2997: Allow KVM VM live migration with ROOT volume on file storage type
GabrielBrascher commented on a change in pull request #2997: Allow KVM VM live
migration with ROOT volume on file storage type
URL: https://github.com/apache/cloudstack/pull/2997#discussion_r233310484
##
File path:
engine/storage/datamotion/src/main/java/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java
##
@@ -1803,6 +1823,42 @@ public void copyAsync(Map
volumeDataStoreMap, VirtualMach
}
}
+/**
+ * Returns true. This method was implemented considering the classes that
extend this {@link StorageSystemDataMotionStrategy} and cannot migrate volumes
from certain types of source storage pools and/or to a different kind of
destiny storage pool.
+ */
+protected boolean shouldMigrateVolume(StoragePoolVO sourceStoragePool,
Host destHost, StoragePoolVO destStoragePool) {
+return true;
Review comment:
Always returns true to keep the original execution flow.
@nvazquez note that this implementation might be useful for you. I added
destHost and destStoragePool thinking on a useful verification for you. One can
use this method to check if the source and target storage pool are not the
same, for instance when migrating among shared pools. However, I can remove
these variables (not used for now), if you think it is better to not use this
way.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[cloudstack] 01/01: Merge remote-tracking branch 'origin/4.11'
This is an automated email from the ASF dual-hosted git repository. rohit pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git commit 97680e7a33bd45afe2a10069872e87b3f74c80e9 Merge: e45bed7 4fabbdb Author: Rohit Yadav AuthorDate: Wed Nov 14 16:53:56 2018 +0530 Merge remote-tracking branch 'origin/4.11' test/integration/smoke/test_migration.py | 131 --- 1 file changed, 69 insertions(+), 62 deletions(-)
[cloudstack] branch master updated (e45bed7 -> 97680e7)
This is an automated email from the ASF dual-hosted git repository. rohit pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git. from e45bed7 server: remove unused StrategyPriority.PLUGIN. (#3014) add 4fabbdb test: Skip network migration tests for not supported hypervisors (#3021) new 97680e7 Merge remote-tracking branch 'origin/4.11' The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: test/integration/smoke/test_migration.py | 131 --- 1 file changed, 69 insertions(+), 62 deletions(-)
[GitHub] nvazquez commented on issue #2928: Migrating VM from ISO failures
nvazquez commented on issue #2928: Migrating VM from ISO failures URL: https://github.com/apache/cloudstack/pull/2928#issuecomment-438627319 Sorry @wido somehow I didn't see your comment before. It happened on 2 cases: direct downloaded and not-direct downloaded ISOs. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] DaanHoogland commented on issue #2992: PoC for log library surface reduction (2991)
DaanHoogland commented on issue #2992: PoC for log library surface reduction (2991) URL: https://github.com/apache/cloudstack/pull/2992#issuecomment-438613228 ok, apart from @rhtyd 's request for the indentation correction I will merge this as is and spend part of my live on following up on this ;) I will be making small iteration of at most per project PRs, adapting the log wrapper to what it needs. next will be the utility project itself. thanks all. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rafaelweingartner commented on a change in pull request #2997: Allow KVM VM live migration with ROOT volume on file storage type
rafaelweingartner commented on a change in pull request #2997: Allow KVM VM
live migration with ROOT volume on file storage type
URL: https://github.com/apache/cloudstack/pull/2997#discussion_r233384505
##
File path:
engine/storage/datamotion/src/main/java/org/apache/cloudstack/storage/motion/KvmNonManagedStorageDataMotionStrategy.java
##
@@ -0,0 +1,142 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+package org.apache.cloudstack.storage.motion;
+
+import java.util.Map;
+import java.util.Set;
+
+import javax.inject.Inject;
+
+import org.apache.cloudstack.engine.subsystem.api.storage.DataStore;
+import org.apache.cloudstack.engine.subsystem.api.storage.StrategyPriority;
+import org.apache.cloudstack.engine.subsystem.api.storage.TemplateDataFactory;
+import org.apache.cloudstack.engine.subsystem.api.storage.TemplateInfo;
+import org.apache.cloudstack.engine.subsystem.api.storage.VolumeInfo;
+import org.apache.cloudstack.storage.datastore.db.StoragePoolVO;
+import org.apache.commons.lang.StringUtils;
+import org.springframework.stereotype.Component;
+
+import com.cloud.agent.api.Answer;
+import com.cloud.agent.api.MigrateCommand;
+import com.cloud.agent.api.MigrateCommand.MigrateDiskInfo;
+import com.cloud.agent.api.storage.CreateAnswer;
+import com.cloud.agent.api.storage.CreateCommand;
+import com.cloud.agent.api.to.VirtualMachineTO;
+import com.cloud.host.Host;
+import com.cloud.hypervisor.Hypervisor.HypervisorType;
+import com.cloud.storage.DataStoreRole;
+import com.cloud.storage.DiskOfferingVO;
+import com.cloud.storage.Storage.StoragePoolType;
+import com.cloud.storage.VolumeVO;
+import com.cloud.utils.exception.CloudRuntimeException;
+import com.cloud.vm.DiskProfile;
+
+/**
+ * Extends {@link StorageSystemDataMotionStrategy}, allowing KVM hosts to
migrate VMs with the ROOT volume on a non managed local storage pool.
+ * As {@link StorageSystemDataMotionStrategy} is considering KVM, this
implementation also migrates only from/to KVM hosts.
+ */
+@Component
+public class KvmNonManagedStorageDataMotionStrategy extends
StorageSystemDataMotionStrategy {
+
+@Inject
+private TemplateDataFactory tmplFactory;
+
+/**
+ * Uses the canHandle from the Super class {@link
StorageSystemDataMotionStrategy}. If the storage pool is of file and the
internalCanHandle from {@link StorageSystemDataMotionStrategy} CANT_HANDLE,
returns the HIGHEST strategy priority. otherwise returns CANT_HANDLE.
+ * Note that the super implementation (overrided) is called by {@link
#canHandle(Map, Host, Host)} which ensures that {@link #internalCanHandle(Map)}
will be executed only if the source host is KVM.
+ */
+@Override
+protected StrategyPriority internalCanHandle(Map
volumeMap) {
+if (super.internalCanHandle(volumeMap) ==
StrategyPriority.CANT_HANDLE) {
+Set volumeInfoSet = volumeMap.keySet();
+
+for (VolumeInfo volumeInfo : volumeInfoSet) {
+StoragePoolVO storagePoolVO =
_storagePoolDao.findById(volumeInfo.getPoolId());
+if (storagePoolVO.getPoolType() != StoragePoolType.Filesystem)
{
Review comment:
Awesome. Thanks!
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[cloudstack] branch master updated: server: remove unused StrategyPriority.PLUGIN. (#3014)
This is an automated email from the ASF dual-hosted git repository.
rohit pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git
The following commit(s) were added to refs/heads/master by this push:
new e45bed7 server: remove unused StrategyPriority.PLUGIN. (#3014)
e45bed7 is described below
commit e45bed74a57f71e22c48bfecbfa07dd0ef9a553c
Author: Gabriel Beims Bräscher
AuthorDate: Wed Nov 14 07:37:37 2018 -0200
server: remove unused StrategyPriority.PLUGIN. (#3014)
Remove unused StrategyPriority.PLUGIN enum. The PLUGIN Strategy priority is
not used, except by three JUnit test methods.
---
.../engine/subsystem/api/storage/StrategyPriority.java | 2 +-
.../subsystem/api/storage/StrategyPriorityTest.java| 18 --
2 files changed, 1 insertion(+), 19 deletions(-)
diff --git
a/engine/api/src/main/java/org/apache/cloudstack/engine/subsystem/api/storage/StrategyPriority.java
b/engine/api/src/main/java/org/apache/cloudstack/engine/subsystem/api/storage/StrategyPriority.java
index 7c0015b..4bfc748 100644
---
a/engine/api/src/main/java/org/apache/cloudstack/engine/subsystem/api/storage/StrategyPriority.java
+++
b/engine/api/src/main/java/org/apache/cloudstack/engine/subsystem/api/storage/StrategyPriority.java
@@ -17,5 +17,5 @@
package org.apache.cloudstack.engine.subsystem.api.storage;
public enum StrategyPriority {
-CANT_HANDLE, DEFAULT, HYPERVISOR, PLUGIN, HIGHEST
+CANT_HANDLE, DEFAULT, HYPERVISOR, HIGHEST
}
diff --git
a/engine/storage/src/test/java/org/apache/cloudstack/engine/subsystem/api/storage/StrategyPriorityTest.java
b/engine/storage/src/test/java/org/apache/cloudstack/engine/subsystem/api/storage/StrategyPriorityTest.java
index af44b4a..bddd5a2 100644
---
a/engine/storage/src/test/java/org/apache/cloudstack/engine/subsystem/api/storage/StrategyPriorityTest.java
+++
b/engine/storage/src/test/java/org/apache/cloudstack/engine/subsystem/api/storage/StrategyPriorityTest.java
@@ -40,13 +40,11 @@ public class StrategyPriorityTest {
SnapshotStrategy cantHandleStrategy = mock(SnapshotStrategy.class);
SnapshotStrategy defaultStrategy = mock(SnapshotStrategy.class);
SnapshotStrategy hyperStrategy = mock(SnapshotStrategy.class);
-SnapshotStrategy pluginStrategy = mock(SnapshotStrategy.class);
SnapshotStrategy highestStrategy = mock(SnapshotStrategy.class);
doReturn(StrategyPriority.CANT_HANDLE).when(cantHandleStrategy).canHandle(any(Snapshot.class),
any(SnapshotOperation.class));
doReturn(StrategyPriority.DEFAULT).when(defaultStrategy).canHandle(any(Snapshot.class),
any(SnapshotOperation.class));
doReturn(StrategyPriority.HYPERVISOR).when(hyperStrategy).canHandle(any(Snapshot.class),
any(SnapshotOperation.class));
-
doReturn(StrategyPriority.PLUGIN).when(pluginStrategy).canHandle(any(Snapshot.class),
any(SnapshotOperation.class));
doReturn(StrategyPriority.HIGHEST).when(highestStrategy).canHandle(any(Snapshot.class),
any(SnapshotOperation.class));
List strategies = new ArrayList(5);
@@ -67,10 +65,6 @@ public class StrategyPriorityTest {
strategy = factory.getSnapshotStrategy(mock(Snapshot.class),
SnapshotOperation.TAKE);
assertEquals("Hypervisor strategy was not picked.", hyperStrategy,
strategy);
-strategies.add(pluginStrategy);
-strategy = factory.getSnapshotStrategy(mock(Snapshot.class),
SnapshotOperation.TAKE);
-assertEquals("Plugin strategy was not picked.", pluginStrategy,
strategy);
-
strategies.add(highestStrategy);
strategy = factory.getSnapshotStrategy(mock(Snapshot.class),
SnapshotOperation.TAKE);
assertEquals("Highest strategy was not picked.", highestStrategy,
strategy);
@@ -81,13 +75,11 @@ public class StrategyPriorityTest {
DataMotionStrategy cantHandleStrategy = mock(DataMotionStrategy.class);
DataMotionStrategy defaultStrategy = mock(DataMotionStrategy.class);
DataMotionStrategy hyperStrategy = mock(DataMotionStrategy.class);
-DataMotionStrategy pluginStrategy = mock(DataMotionStrategy.class);
DataMotionStrategy highestStrategy = mock(DataMotionStrategy.class);
doReturn(StrategyPriority.CANT_HANDLE).when(cantHandleStrategy).canHandle(any(DataObject.class),
any(DataObject.class));
doReturn(StrategyPriority.DEFAULT).when(defaultStrategy).canHandle(any(DataObject.class),
any(DataObject.class));
doReturn(StrategyPriority.HYPERVISOR).when(hyperStrategy).canHandle(any(DataObject.class),
any(DataObject.class));
-
doReturn(StrategyPriority.PLUGIN).when(pluginStrategy).canHandle(any(DataObject.class),
any(DataObject.class));
doReturn(StrategyPriority.HIGHEST).when(highestStrategy).canHandle(any(DataObject.class),
any(DataObject.class));
List strategies = new
ArrayList(5);
@@ -108,10 +100,6 @@ public
[GitHub] rhtyd closed pull request #3014: Remove unused StrategyPriority.PLUGIN
rhtyd closed pull request #3014: Remove unused StrategyPriority.PLUGIN
URL: https://github.com/apache/cloudstack/pull/3014
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/engine/api/src/main/java/org/apache/cloudstack/engine/subsystem/api/storage/StrategyPriority.java
b/engine/api/src/main/java/org/apache/cloudstack/engine/subsystem/api/storage/StrategyPriority.java
index 7c0015bb513..4bfc7485029 100644
---
a/engine/api/src/main/java/org/apache/cloudstack/engine/subsystem/api/storage/StrategyPriority.java
+++
b/engine/api/src/main/java/org/apache/cloudstack/engine/subsystem/api/storage/StrategyPriority.java
@@ -17,5 +17,5 @@
package org.apache.cloudstack.engine.subsystem.api.storage;
public enum StrategyPriority {
-CANT_HANDLE, DEFAULT, HYPERVISOR, PLUGIN, HIGHEST
+CANT_HANDLE, DEFAULT, HYPERVISOR, HIGHEST
}
diff --git
a/engine/storage/src/test/java/org/apache/cloudstack/engine/subsystem/api/storage/StrategyPriorityTest.java
b/engine/storage/src/test/java/org/apache/cloudstack/engine/subsystem/api/storage/StrategyPriorityTest.java
index af44b4a05f1..bddd5a21880 100644
---
a/engine/storage/src/test/java/org/apache/cloudstack/engine/subsystem/api/storage/StrategyPriorityTest.java
+++
b/engine/storage/src/test/java/org/apache/cloudstack/engine/subsystem/api/storage/StrategyPriorityTest.java
@@ -40,13 +40,11 @@ public void testSortSnapshotStrategies() {
SnapshotStrategy cantHandleStrategy = mock(SnapshotStrategy.class);
SnapshotStrategy defaultStrategy = mock(SnapshotStrategy.class);
SnapshotStrategy hyperStrategy = mock(SnapshotStrategy.class);
-SnapshotStrategy pluginStrategy = mock(SnapshotStrategy.class);
SnapshotStrategy highestStrategy = mock(SnapshotStrategy.class);
doReturn(StrategyPriority.CANT_HANDLE).when(cantHandleStrategy).canHandle(any(Snapshot.class),
any(SnapshotOperation.class));
doReturn(StrategyPriority.DEFAULT).when(defaultStrategy).canHandle(any(Snapshot.class),
any(SnapshotOperation.class));
doReturn(StrategyPriority.HYPERVISOR).when(hyperStrategy).canHandle(any(Snapshot.class),
any(SnapshotOperation.class));
-
doReturn(StrategyPriority.PLUGIN).when(pluginStrategy).canHandle(any(Snapshot.class),
any(SnapshotOperation.class));
doReturn(StrategyPriority.HIGHEST).when(highestStrategy).canHandle(any(Snapshot.class),
any(SnapshotOperation.class));
List strategies = new ArrayList(5);
@@ -67,10 +65,6 @@ public void testSortSnapshotStrategies() {
strategy = factory.getSnapshotStrategy(mock(Snapshot.class),
SnapshotOperation.TAKE);
assertEquals("Hypervisor strategy was not picked.", hyperStrategy,
strategy);
-strategies.add(pluginStrategy);
-strategy = factory.getSnapshotStrategy(mock(Snapshot.class),
SnapshotOperation.TAKE);
-assertEquals("Plugin strategy was not picked.", pluginStrategy,
strategy);
-
strategies.add(highestStrategy);
strategy = factory.getSnapshotStrategy(mock(Snapshot.class),
SnapshotOperation.TAKE);
assertEquals("Highest strategy was not picked.", highestStrategy,
strategy);
@@ -81,13 +75,11 @@ public void testSortDataMotionStrategies() {
DataMotionStrategy cantHandleStrategy = mock(DataMotionStrategy.class);
DataMotionStrategy defaultStrategy = mock(DataMotionStrategy.class);
DataMotionStrategy hyperStrategy = mock(DataMotionStrategy.class);
-DataMotionStrategy pluginStrategy = mock(DataMotionStrategy.class);
DataMotionStrategy highestStrategy = mock(DataMotionStrategy.class);
doReturn(StrategyPriority.CANT_HANDLE).when(cantHandleStrategy).canHandle(any(DataObject.class),
any(DataObject.class));
doReturn(StrategyPriority.DEFAULT).when(defaultStrategy).canHandle(any(DataObject.class),
any(DataObject.class));
doReturn(StrategyPriority.HYPERVISOR).when(hyperStrategy).canHandle(any(DataObject.class),
any(DataObject.class));
-
doReturn(StrategyPriority.PLUGIN).when(pluginStrategy).canHandle(any(DataObject.class),
any(DataObject.class));
doReturn(StrategyPriority.HIGHEST).when(highestStrategy).canHandle(any(DataObject.class),
any(DataObject.class));
List strategies = new
ArrayList(5);
@@ -108,10 +100,6 @@ public void testSortDataMotionStrategies() {
strategy = factory.getDataMotionStrategy(mock(DataObject.class),
mock(DataObject.class));
assertEquals("Hypervisor strategy was not picked.", hyperStrategy,
strategy);
-strategies.add(pluginStrategy);
-strategy = factory.getDataMotionStrategy(mock(DataObject.class),
mock(DataObject.class));
-assertEquals("Plugin strategy was not picked.",
[cloudstack] branch 4.11 updated: test: Skip network migration tests for not supported hypervisors (#3021)
This is an automated email from the ASF dual-hosted git repository.
rohit pushed a commit to branch 4.11
in repository https://gitbox.apache.org/repos/asf/cloudstack.git
The following commit(s) were added to refs/heads/4.11 by this push:
new 4fabbdb test: Skip network migration tests for not supported
hypervisors (#3021)
4fabbdb is described below
commit 4fabbdb1ae5646fa7c88a4e1060a03656509836e
Author: Nicolas Vazquez
AuthorDate: Wed Nov 14 06:34:08 2018 -0300
test: Skip network migration tests for not supported hypervisors (#3021)
Skip network migration tests for not supported hypervisors instead of
failing.
---
test/integration/smoke/test_migration.py | 131 ---
1 file changed, 69 insertions(+), 62 deletions(-)
diff --git a/test/integration/smoke/test_migration.py
b/test/integration/smoke/test_migration.py
index f0cd574..ab5532a 100644
--- a/test/integration/smoke/test_migration.py
+++ b/test/integration/smoke/test_migration.py
@@ -39,6 +39,7 @@ from marvin.lib.utils import (get_hypervisor_type,
# Import System Modules
from nose.plugins.attrib import attr
+from marvin.lib.decoratorGenerators import skipTestIf
class Services:
@@ -76,83 +77,87 @@ class TestNetworkMigration(cloudstackTestCase):
cls.test_data = cls.testClient.getParsedTestDataConfig()
cls.services = Services().services
+cls.hypervisorNotSupported = False
hypervisor = get_hypervisor_type(cls.api_client)
if hypervisor.lower() not in ["vmware", "kvm"]:
-raise unittest.SkipTest("This feature is supported "
-"only on Vmware and KVM")
-
-# Get Domain, Zone, Template
-cls.domain = get_domain(cls.api_client)
-cls.zone = get_zone(
-cls.api_client,
-cls.testClient.getZoneForTests())
-cls.template = get_template(
-cls.api_client,
-cls.zone.id,
-cls.test_data["ostype"]
-)
-cls.services["virtual_machine"]["template"] = cls.template.id
-if cls.zone.localstorageenabled:
-cls.storagetype = 'local'
-cls.test_data["service_offerings"][
-"tiny"]["storagetype"] = 'local'
-else:
-cls.storagetype = 'shared'
-cls.test_data["service_offerings"][
-"tiny"]["storagetype"] = 'shared'
-
-cls.service_offering = ServiceOffering.create(
-cls.api_client,
-cls.test_data["service_offerings"]["tiny"]
-)
+cls.hypervisorNotSupported = True
-# Create Network offering without userdata
-cls.network_offering_nouserdata = NetworkOffering.create(
-cls.api_client,
-cls.test_data["network_offering"]
-)
-# Enable Network offering
-cls.network_offering_nouserdata.update(cls.api_client,
- state='Enabled')
-
-# Create Network Offering with all the serices
-cls.network_offering_all = NetworkOffering.create(
-cls.api_client,
-cls.test_data["isolated_network_offering"]
-)
-# Enable Network offering
-cls.network_offering_all.update(cls.api_client, state='Enabled')
+cls._cleanup = []
+if not cls.hypervisorNotSupported:
+# Get Domain, Zone, Template
+cls.domain = get_domain(cls.api_client)
+cls.zone = get_zone(
+cls.api_client,
+cls.testClient.getZoneForTests())
+cls.template = get_template(
+cls.api_client,
+cls.zone.id,
+cls.test_data["ostype"]
+)
+cls.services["virtual_machine"]["template"] = cls.template.id
+if cls.zone.localstorageenabled:
+cls.storagetype = 'local'
+cls.test_data["service_offerings"][
+"tiny"]["storagetype"] = 'local'
+else:
+cls.storagetype = 'shared'
+cls.test_data["service_offerings"][
+"tiny"]["storagetype"] = 'shared'
+
+cls.service_offering = ServiceOffering.create(
+cls.api_client,
+cls.test_data["service_offerings"]["tiny"]
+)
-cls.native_vpc_network_offering = NetworkOffering.create(
+# Create Network offering without userdata
+cls.network_offering_nouserdata = NetworkOffering.create(
+cls.api_client,
+cls.test_data["network_offering"]
+)
+# Enable Network offering
+cls.network_offering_nouserdata.update(cls.api_client,
+ state='Enabled')
+
+# Create Network Offering with all the serices
+
[GitHub] rhtyd closed pull request #3021: Skip network migration tests for not supported hypervisors instead of failing
rhtyd closed pull request #3021: Skip network migration tests for not supported
hypervisors instead of failing
URL: https://github.com/apache/cloudstack/pull/3021
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/test/integration/smoke/test_migration.py
b/test/integration/smoke/test_migration.py
index f0cd5745d6d..ab5532a16cd 100644
--- a/test/integration/smoke/test_migration.py
+++ b/test/integration/smoke/test_migration.py
@@ -39,6 +39,7 @@
# Import System Modules
from nose.plugins.attrib import attr
+from marvin.lib.decoratorGenerators import skipTestIf
class Services:
@@ -76,83 +77,87 @@ def setUpClass(cls):
cls.test_data = cls.testClient.getParsedTestDataConfig()
cls.services = Services().services
+cls.hypervisorNotSupported = False
hypervisor = get_hypervisor_type(cls.api_client)
if hypervisor.lower() not in ["vmware", "kvm"]:
-raise unittest.SkipTest("This feature is supported "
-"only on Vmware and KVM")
-
-# Get Domain, Zone, Template
-cls.domain = get_domain(cls.api_client)
-cls.zone = get_zone(
-cls.api_client,
-cls.testClient.getZoneForTests())
-cls.template = get_template(
-cls.api_client,
-cls.zone.id,
-cls.test_data["ostype"]
-)
-cls.services["virtual_machine"]["template"] = cls.template.id
-if cls.zone.localstorageenabled:
-cls.storagetype = 'local'
-cls.test_data["service_offerings"][
-"tiny"]["storagetype"] = 'local'
-else:
-cls.storagetype = 'shared'
-cls.test_data["service_offerings"][
-"tiny"]["storagetype"] = 'shared'
-
-cls.service_offering = ServiceOffering.create(
-cls.api_client,
-cls.test_data["service_offerings"]["tiny"]
-)
+cls.hypervisorNotSupported = True
-# Create Network offering without userdata
-cls.network_offering_nouserdata = NetworkOffering.create(
-cls.api_client,
-cls.test_data["network_offering"]
-)
-# Enable Network offering
-cls.network_offering_nouserdata.update(cls.api_client,
- state='Enabled')
-
-# Create Network Offering with all the serices
-cls.network_offering_all = NetworkOffering.create(
-cls.api_client,
-cls.test_data["isolated_network_offering"]
-)
-# Enable Network offering
-cls.network_offering_all.update(cls.api_client, state='Enabled')
+cls._cleanup = []
+if not cls.hypervisorNotSupported:
+# Get Domain, Zone, Template
+cls.domain = get_domain(cls.api_client)
+cls.zone = get_zone(
+cls.api_client,
+cls.testClient.getZoneForTests())
+cls.template = get_template(
+cls.api_client,
+cls.zone.id,
+cls.test_data["ostype"]
+)
+cls.services["virtual_machine"]["template"] = cls.template.id
+if cls.zone.localstorageenabled:
+cls.storagetype = 'local'
+cls.test_data["service_offerings"][
+"tiny"]["storagetype"] = 'local'
+else:
+cls.storagetype = 'shared'
+cls.test_data["service_offerings"][
+"tiny"]["storagetype"] = 'shared'
+
+cls.service_offering = ServiceOffering.create(
+cls.api_client,
+cls.test_data["service_offerings"]["tiny"]
+)
-cls.native_vpc_network_offering = NetworkOffering.create(
+# Create Network offering without userdata
+cls.network_offering_nouserdata = NetworkOffering.create(
+cls.api_client,
+cls.test_data["network_offering"]
+)
+# Enable Network offering
+cls.network_offering_nouserdata.update(cls.api_client,
+ state='Enabled')
+
+# Create Network Offering with all the serices
+cls.network_offering_all = NetworkOffering.create(
cls.api_client,
-cls.test_data["nw_offering_isolated_vpc"],
-conservemode=False)
-cls.native_vpc_network_offering.update(cls.api_client,
- state='Enabled')
-
-cls._cleanup = [
-cls.service_offering,
-
[GitHub] blueorangutan commented on issue #3021: Skip network migration tests for not supported hypervisors instead of failing
blueorangutan commented on issue #3021: Skip network migration tests for not supported hypervisors instead of failing URL: https://github.com/apache/cloudstack/pull/3021#issuecomment-438594677 Trillian test result (tid-3179) Environment: xenserver-65sp1 (x2), Advanced Networking with Mgmt server 7 Total time taken: 21152 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3021-t3179-xenserver-65sp1.zip Smoke tests completed. 68 look OK, 0 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] DaanHoogland commented on issue #3014: Remove unused StrategyPriority.PLUGIN
DaanHoogland commented on issue #3014: Remove unused StrategyPriority.PLUGIN URL: https://github.com/apache/cloudstack/pull/3014#issuecomment-438594370 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] gmueller-ewerk opened a new pull request #3026: Enhance bypass vlan overlap check
gmueller-ewerk opened a new pull request #3026: Enhance bypass vlan overlap check URL: https://github.com/apache/cloudstack/pull/3026 ## Description This PR adds the possibility to select a checkbox for the parameter _bypassvlanoverlapcheck_ to the ajax request [createNetwork](http://cloudstack.apache.org/api/apidocs-4.11/apis/createNetwork.html). The checkbox was added for _Guest Network_ as well as for the _L2 Guest Network_. For _L2 Guest Network_ a backend check for the existence of the flag _bypassvlanoverlapcheck_ was added. ## Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [ ] Bug fix (non-breaking change which fixes an issue) - [x ] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) ## Screenshots New checkbox _L2 Guest Network_ https://user-images.githubusercontent.com/30073818/48471348-03683e80-e7f4-11e8-8c34-56e2ccee8d0f.png;> New checkbox for _Guest Network_ https://user-images.githubusercontent.com/30073818/48471418-28f54800-e7f4-11e8-8615-4f463732626c.png;> ## How Has This Been Tested? Tested locally to verify the parameter _bypassVlanOverlapCheck_ was pushed to the ajax request [createNetwork](http://cloudstack.apache.org/api/apidocs-4.11/apis/createNetwork.html). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
