[GitHub] blueorangutan commented on issue #2848: Vmware offline migration
blueorangutan commented on issue #2848: Vmware offline migration URL: https://github.com/apache/cloudstack/pull/2848#issuecomment-439591656 @dhlaluku a Trillian-Jenkins test job (centos7 mgmt + vmware-65) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dhlaluku commented on issue #2848: Vmware offline migration
dhlaluku commented on issue #2848: Vmware offline migration URL: https://github.com/apache/cloudstack/pull/2848#issuecomment-439591627 @blueorangutan test centos7 vmware-65 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] bwsw opened a new pull request #3036: Implemented capabilities for snapshots and vm snapshots.
bwsw opened a new pull request #3036: Implemented capabilities for snapshots and vm snapshots. URL: https://github.com/apache/cloudstack/pull/3036 ## Description Implemented additional capabilities: ``` disksnapshotsmaxdaily = 6 disksnapshotsmaxhourly = 1 disksnapshotsmaxmonthly = 24 disksnapshotsmaxweekly = 12 vmsnapshotexpireinterval = 3600 vmsnapshotsmax = 1 ``` Ticket: #3035 ## Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [ ] Bug fix (non-breaking change which fixes an issue) - [x] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) ## How Has This Been Tested? As the feature requires MS to restart, tested manually. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dhlaluku commented on issue #2848: Vmware offline migration
dhlaluku commented on issue #2848: Vmware offline migration URL: https://github.com/apache/cloudstack/pull/2848#issuecomment-439526508 @blueorangutan centos7 vmware-65 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2848: Vmware offline migration
blueorangutan commented on issue #2848: Vmware offline migration URL: https://github.com/apache/cloudstack/pull/2848#issuecomment-439525637 Trillian test result (tid-3183) Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7 Total time taken: 33465 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2848-t3183-xenserver-71.zip Intermittent failure detected: /marvin/tests/smoke/test_multipleips_per_nic.py Intermittent failure detected: /marvin/tests/smoke/test_public_ip_range.py Intermittent failure detected: /marvin/tests/smoke/test_scale_vm.py Intermittent failure detected: /marvin/tests/smoke/test_templates.py Intermittent failure detected: /marvin/tests/smoke/test_usage.py Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py Intermittent failure detected: /marvin/tests/smoke/test_volumes.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py Intermittent failure detected: /marvin/tests/smoke/test_host_maintenance.py Smoke tests completed. 63 look OK, 7 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_nic_secondaryip_add_remove | `Error` | 56.78 | test_multipleips_per_nic.py test_01_scale_vm | `Error` | 16.39 | test_scale_vm.py test_04_extract_template | `Failure` | 128.40 | test_templates.py ContextSuite context=TestISOUsage>:setup | `Error` | 0.00 | test_usage.py test_11_migrate_vm | `Error` | 31.99 | test_vm_life_cycle.py test_06_download_detached_volume | `Failure` | 140.68 | test_volumes.py test_04_rvpc_network_garbage_collector_nics | `Failure` | 527.64 | test_vpc_redundant.py This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] kiwiflyer commented on issue #2611: Ceph RBD primary storage fails connection and renders node unusable
kiwiflyer commented on issue #2611: Ceph RBD primary storage fails connection and renders node unusable URL: https://github.com/apache/cloudstack/issues/2611#issuecomment-439517015  This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2848: Vmware offline migration
blueorangutan commented on issue #2848: Vmware offline migration URL: https://github.com/apache/cloudstack/pull/2848#issuecomment-439516719 Trillian test result (tid-3185) Environment: vmware-65 (x2), Advanced Networking with Mgmt server 7 Total time taken: 31331 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2848-t3185-vmware-65.zip Intermittent failure detected: /marvin/tests/smoke/test_multipleips_per_nic.py Intermittent failure detected: /marvin/tests/smoke/test_snapshots.py Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py Smoke tests completed. 66 look OK, 4 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_nic_secondaryip_add_remove | `Error` | 70.79 | test_multipleips_per_nic.py test_02_list_snapshots_with_removed_data_store | `Error` | 39.51 | test_snapshots.py test_11_migrate_vm | `Error` | 24.12 | test_vm_life_cycle.py test_04_rvpc_network_garbage_collector_nics | `Failure` | 559.01 | test_vpc_redundant.py This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] kiwiflyer commented on issue #2611: Ceph RBD primary storage fails connection and renders node unusable
kiwiflyer commented on issue #2611: Ceph RBD primary storage fails connection and renders node unusable URL: https://github.com/apache/cloudstack/issues/2611#issuecomment-439511872 So working with a user, it does appear that the original issue outlined by @giorgiomassar8 is different from the one we found. The user in question is running Ubuntu 16.04 and no authentication is being passed to libvirt.  This particular installation is a 4.9.3 -> 4.11.1 upgrade. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] giorgiomassar8 opened a new issue #2611: Ceph RBD primary storage fails connection and renders node unusable
giorgiomassar8 opened a new issue #2611: Ceph RBD primary storage fails connection and renders node unusable URL: https://github.com/apache/cloudstack/issues/2611 # ISSUE TYPE * Bug Report # COMPONENT NAME Cloudstack agent # CLOUDSTACK VERSION 4.11 # CONFIGURATION KVM cluster with CEPH backed RDB primary storage # OS / ENVIRONMENT Ubuntu 16.04 / 14.04 # SUMMARY On a perfectly working 4.10 node with KVM hypervisor and Ceph RBD primary storage, after upgrading to 4.11, cloudstack agent is unable to connect the BRD pool in libvirt, giving just a generic "operation not supported" error in its logs: 2018-04-06 16:27:37,650 INFO [kvm.storage.LibvirtStorageAdaptor] (agentRequest-Handler-2:null) (logid:91b4e1df) Attempting to create storage pool be80af6a-7201-3410-8da4-9b3b58c4954f (RBD) in libvirt 2018-04-06 16:27:37,652 WARN [kvm.storage.LibvirtStorageAdaptor] (agentRequest-Handler-2:null) (logid:91b4e1df) Storage pool be80af6a-7201-3410-8da4-9b3b58c4954f was not found running in libvirt. Need to create it. 2018-04-06 16:27:37,653 INFO [kvm.storage.LibvirtStorageAdaptor] (agentRequest-Handler-2:null) (logid:91b4e1df) Didn't find an existing storage pool be80af6a-7201-3410-8da4-9b3b58c4954f by UUID, checking for pools with duplicate paths 2018-04-06 16:27:37,664 ERROR [kvm.storage.LibvirtStorageAdaptor] (agentRequest-Handler-2:null) (logid:91b4e1df) Failed to create RBD storage pool: org.libvirt.LibvirtException: failed to connect to the RADOS monitor on: storagepool1:6789,: Operation not supported 2018-04-06 16:27:42,762 INFO [cloud.agent.Agent] (Agent-Handler-4:null) (logid Lost connection to the server. Dealing with the remaining commands... Exactly the same pool was previously working before upgrade: 2018-04-06 12:53:52,847 INFO [kvm.storage.LibvirtStorageAdaptor] (agentRequest-Handler-3:null) (logid:14dace5e) Attempting to create storage pool be80af6a-7201-3410-8da4-9b3b58c4954f (RBD) in libvirt 2018-04-06 12:53:52,850 INFO [kvm.storage.LibvirtStorageAdaptor] (agentRequest-Handler-3:null) (logid:14dace5e) Found existing defined storage pool be80af6a-7201-3410-8da4-9b3b58c4954f, using it. 2018-04-06 12:53:52,850 INFO [kvm.storage.LibvirtStorageAdaptor] (agentRequest-Handler-3:null) (logid:14dace5e) Trying to fetch storage pool be80af6a-7201-3410-8da4-9b3b58c4954f from libvirt 2018-04-06 12:53:53,171 INFO [cloud.agent.Agent] (agentRequest-Handler-2:null) (logid:14dace5e) Proccess agent ready command, agent id = 46 # STEPS TO REPRODUCE Take an existing and working cloudstack cluster with 4.10, with RDB primary storage and Ubuntu 14.04 based agents and upgrade them to version 4.11 of the agent. # EXPECTED RESULTS The cluster should be working fine, the agents should be connecting and the RDB pool should be correctly opened in libvirt. # ACTUAL RESULTS Cloudstack agents fails to boot with a generic "Failed to create RBD storage pool: org.libvirt.LibvirtException: failed to connect to the RADOS monitor on: storagepool1:6789,: Operation not supported" error and loops in a failed state, rendering the machine unusable. # WORKAROUND To workaround the issue I have tried to use the following XML config (dumped from another node where it is correctly running) and define the pool directly in libvirt, and it worked as expected: be80af6a-7201-3410-8da4-9b3b58c4954f be80af6a-7201-3410-8da4-9b3b58c4954f cephstor1 virsh pool-define test.xml Pool be80af6a-7201-3410-8da4-9b3b58c4954f defined from test.xml root@compute6:~# virsh pool-start be80af6a-7201-3410-8da4-9b3b58c4954f Pool be80af6a-7201-3410-8da4-9b3b58c4954f started root@compute6:~# virsh pool-info be80af6a-7201-3410-8da4-9b3b58c4954f Name: be80af6a-7201-3410-8da4-9b3b58c4954f UUID: be80af6a-7201-3410-8da4-9b3b58c4954f State: running Persistent: yes Autostart: no Capacity: 10.05 TiB Allocation: 2.22 TiB Available: 2.71 TiB And now the cloudstack agent correctly starts: 2018-04-09 10:29:19,989 INFO [kvm.storage.LibvirtStorageAdaptor] (agentRequest-Handler-2:null) (logid:f0021131) Attempting to create storage pool be80af6a-7201-3410-8da4-9b3b58c4954f (RBD) in libvirt 2018-04-09 10:29:19,990 INFO [kvm.storage.LibvirtStorageAdaptor] (agentRequest-Handler-2:null) (logid:f0021131) Found existing defined storage pool be80af6a-7201-3410-8da4-9b3b58c4954f, using it. 2018-04-09 10:29:19,991 INFO [kvm.storage.LibvirtStorageAdaptor] (agentRequest-Handler-2:null) (logid:f0021131) Trying to fetch storage pool be80af6a-7201-3410-8da4-9b3b58c4954f from libvirt 2018-04-09 10:29:20,372 INFO [cloud.agent.Agent] (agent
[GitHub] bwsw opened a new issue #3035: Add snapshots-related limits returned in capabilties
bwsw opened a new issue #3035: Add snapshots-related limits returned in capabilties URL: https://github.com/apache/cloudstack/issues/3035 # ISSUE TYPE * Feature Idea # COMPONENT NAME ~~~ API ~~~ # CLOUDSTACK VERSION ~~~ 4.12 ~~~ # CONFIGURATION # OS / ENVIRONMENT # SUMMARY Add VM snapshots and disk snapshots configured limitations in response for listCapabilties # STEPS TO REPRODUCE # EXPECTED RESULTS ~~~ New capabilities elements returned in API. ~~~ This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] bwsw commented on a change in pull request #3000: CLOUDSTACK-2998: Added two more device name patterns to valid bridge slaves (lo* and dummy*)
bwsw commented on a change in pull request #3000: CLOUDSTACK-2998: Added two
more device name patterns to valid bridge slaves (lo* and dummy*)
URL: https://github.com/apache/cloudstack/pull/3000#discussion_r234264619
##
File path:
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
##
@@ -1291,7 +1292,7 @@ private String matchPifFileInDirectory(final String
bridgeName) {
return "";
}
-String [] _ifNamePatterns = {
+static String [] ifNamePatterns = {
Review comment:
@DaanHoogland +1
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] DaanHoogland commented on issue #1148: Update JuniperSrxResource.java
DaanHoogland commented on issue #1148: Update JuniperSrxResource.java URL: https://github.com/apache/cloudstack/pull/1148#issuecomment-439442981 this fix was added to master by means of another commit, closing This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] DaanHoogland closed pull request #1148: Update JuniperSrxResource.java
DaanHoogland closed pull request #1148: Update JuniperSrxResource.java URL: https://github.com/apache/cloudstack/pull/1148 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] DaanHoogland commented on issue #1662: Fix bug juniper srx
DaanHoogland commented on issue #1662: Fix bug juniper srx URL: https://github.com/apache/cloudstack/pull/1662#issuecomment-439442481 code in here seems to be applied through other means on master, closing This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] DaanHoogland closed pull request #1662: Fix bug juniper srx
DaanHoogland closed pull request #1662: Fix bug juniper srx URL: https://github.com/apache/cloudstack/pull/1662 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dhlaluku commented on a change in pull request #2848: Vmware offline migration
dhlaluku commented on a change in pull request #2848: Vmware offline migration
URL: https://github.com/apache/cloudstack/pull/2848#discussion_r234222170
##
File path: core/src/main/java/com/cloud/agent/api/UnregisterVMCommand.java
##
@@ -22,14 +22,19 @@
public class UnregisterVMCommand extends Command {
String vmName;
boolean cleanupVmFiles = false;
+boolean executeInSequence = false;
Review comment:
removed redundant 'false'
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] DaanHoogland commented on issue #2992: PoC for log library surface reduction (2991)
DaanHoogland commented on issue #2992: PoC for log library surface reduction (2991) URL: https://github.com/apache/cloudstack/pull/2992#issuecomment-439386896 so basically you are re-doing my work from #2276 but without reducing the surface area. I do not like it much so far. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] izenk removed a comment on issue #3033: ERROR when edit Project
izenk removed a comment on issue #3033: ERROR when edit Project URL: https://github.com/apache/cloudstack/issues/3033#issuecomment-439385531 Error is reproducible if editing is doing under "Project View", if under "Default View" everything is ok. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] izenk removed a comment on issue #3033: ERROR when edit Project
izenk removed a comment on issue #3033: ERROR when edit Project URL: https://github.com/apache/cloudstack/issues/3033#issuecomment-439385112 Error is reproducible if editing is doing under "Project View", if under "Default View" everything is ok. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] izenk commented on issue #3033: ERROR when edit Project
izenk commented on issue #3033: ERROR when edit Project URL: https://github.com/apache/cloudstack/issues/3033#issuecomment-439385531 Error is reproducible if editing is doing under "Project View", if under "Default View" everything is ok. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] PaulAngus commented on issue #3028: Adding zone disablement during deletion of the range plus one more tr…
PaulAngus commented on issue #3028: Adding zone disablement during deletion of the range plus one more tr… URL: https://github.com/apache/cloudstack/pull/3028#issuecomment-439385476 Yes LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] izenk commented on issue #3033: ERROR when edit Project
izenk commented on issue #3033: ERROR when edit Project URL: https://github.com/apache/cloudstack/issues/3033#issuecomment-439385112 Error is reproducible if editing is doing under "Project View", if under "Default View" everything is ok. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rafaelweingartner edited a comment on issue #2992: PoC for log library surface reduction (2991)
rafaelweingartner edited a comment on issue #2992: PoC for log library surface reduction (2991) URL: https://github.com/apache/cloudstack/pull/2992#issuecomment-439380086 > If you unify the log framework usage as well, I am open to your solution. That is actually what I am doing. That is why it is taking some time (time that I have not had much lately). Also, as you noticed the simple script I created does not address some very specific case in our code base. Therefore, I need to visit them manually, and to evaluate if they are really needed, and if we can move on to the use of standard variables. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rafaelweingartner commented on issue #2992: PoC for log library surface reduction (2991)
rafaelweingartner commented on issue #2992: PoC for log library surface reduction (2991) URL: https://github.com/apache/cloudstack/pull/2992#issuecomment-439380086 > If you unify the log framework usage as well, I am open to your solution. That is actually what I am doing. That is why it is taking some time (time that I have not had much lately). Also, as you noticed the simple script I created does not address some very specific case in our code base. Therefore, I need to visit them manually, and to evaluate if they are really needed, and if we can move on to the use of standard variables. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2848: Vmware offline migration
blueorangutan commented on issue #2848: Vmware offline migration URL: https://github.com/apache/cloudstack/pull/2848#issuecomment-439379349 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2443 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] DaanHoogland edited a comment on issue #2992: PoC for log library surface reduction (2991)
DaanHoogland edited a comment on issue #2992: PoC for log library surface reduction (2991) URL: https://github.com/apache/cloudstack/pull/2992#issuecomment-439378952 > Anyways, to upgrade the log4j is not as a Dantesc task as you are portraiting. I am almost done, and I have almost had no time to work on it. I can finish, and then show you for us to discuss if you have an open mind. If you unify the log framework usage as well, I am open to your solution. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] DaanHoogland commented on issue #2992: PoC for log library surface reduction (2991)
DaanHoogland commented on issue #2992: PoC for log library surface reduction (2991) URL: https://github.com/apache/cloudstack/pull/2992#issuecomment-439378952 > Anyways, to upgrade the log4j is not as a Dantesc task as you are portraiting. I am almost done, and I have almost had no time to work on it. I can finish, and then show you for us to discuss if you have an open mind. If you unify the log framework usage as well, I am open to your solution. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dhlaluku commented on issue #2848: Vmware offline migration
dhlaluku commented on issue #2848: Vmware offline migration URL: https://github.com/apache/cloudstack/pull/2848#issuecomment-439374864 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2848: Vmware offline migration
blueorangutan commented on issue #2848: Vmware offline migration URL: https://github.com/apache/cloudstack/pull/2848#issuecomment-439375014 @dhlaluku a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #3030: correct permissions in spec file and fix class path specified variable
rhtyd commented on issue #3030: correct permissions in spec file and fix class path specified variable URL: https://github.com/apache/cloudstack/pull/3030#issuecomment-439364967 @svenvogel please rebase against 4.11, or if it's difficult you can try this: - note down the shas of the two commits - git checkout your-branch - git reset --hard origin/4.11 - git cherry-pick - git cherry-pick - git push your-branch -fv (and then edit the PR branch to 4.11!) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #3028: Adding zone disablement during deletion of the range plus one more tr…
rhtyd commented on issue #3028: Adding zone disablement during deletion of the range plus one more tr… URL: https://github.com/apache/cloudstack/pull/3028#issuecomment-439364518 @PaulAngus are you lgtm on this? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2848: Vmware offline migration
blueorangutan commented on issue #2848: Vmware offline migration URL: https://github.com/apache/cloudstack/pull/2848#issuecomment-439363496 @dhlaluku a Trillian-Jenkins matrix job (centos6 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dhlaluku commented on issue #2848: Vmware offline migration
dhlaluku commented on issue #2848: Vmware offline migration URL: https://github.com/apache/cloudstack/pull/2848#issuecomment-439363337 @blueorangutan test matrix This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2848: Vmware offline migration
blueorangutan commented on issue #2848: Vmware offline migration URL: https://github.com/apache/cloudstack/pull/2848#issuecomment-439362882 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2442 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rafaelweingartner commented on issue #2992: PoC for log library surface reduction (2991)
rafaelweingartner commented on issue #2992: PoC for log library surface reduction (2991) URL: https://github.com/apache/cloudstack/pull/2992#issuecomment-439359447 > Also, @rafaelweingartner, I will -1 a PR that 'just' upgrades a structurally changed dependency, if it fails to makes efforts to isolate the dependency as described. What do you mean with "isolate the dependency"? It is a dependency, we choose it (wisely), we evaluate it, and we move on. As I said, there are different ways to tackle the issues. One is for sure doing what you are proposing and creating a layer on top of everything. Other would be a better Class hierarchy and using properly object orientation. Anyways, to upgrade the log4j is not as a Dantesc task as you are portraiting. I am almost done, and I have almost had no time to work on it. I can finish, and then show you for us to discuss if you have an open mind. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2848: Vmware offline migration
blueorangutan commented on issue #2848: Vmware offline migration URL: https://github.com/apache/cloudstack/pull/2848#issuecomment-439358150 @dhlaluku a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dhlaluku commented on issue #2848: Vmware offline migration
dhlaluku commented on issue #2848: Vmware offline migration URL: https://github.com/apache/cloudstack/pull/2848#issuecomment-439358005 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] DaanHoogland commented on issue #2992: PoC for log library surface reduction (2991)
DaanHoogland commented on issue #2992: PoC for log library surface reduction (2991) URL: https://github.com/apache/cloudstack/pull/2992#issuecomment-439316964 Also, @rafaelweingartner, I will -1 a PR that 'just' upgrades a structurally changed dependency, if it fails to makes efforts to isolate the dependency as described. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] DaanHoogland commented on issue #2992: PoC for log library surface reduction (2991)
DaanHoogland commented on issue #2992: PoC for log library surface reduction (2991) URL: https://github.com/apache/cloudstack/pull/2992#issuecomment-439316167 tl;dr you are not giving any argument to not use this strategy, you are only saying why this PoC is just a PoC. What you are describing is very elaborate as well, @rafaelweingartner. The script you describe is error prone. Not all calls and declaration are formatted the same way and the expressions look a bit to simple. I have seen the attempt to use slf4j in the console proxy code and it needs to be addressed as well. It is in the wrong place and incomplete. you say "For instance, your proposal could be applied to JPA ... as well, will we do that (when we move towards Spring-data and a real JPA implementation)? I hope not…". I do hope so, and I think you should as well, but this will be very challenging in the DAO case. I think it would be great if we could. I think we should definitely do this for a lot of external libraries, not reinventing the wheel but abstracting out and isolating dependencies on external eccentricities of those libraries, like call syntax/sematics. As you can see in my description of the issue (#2991) I am not being religious. I exclude (not definitely but as example) the DAO framework, as indeed spring data may make it more convenient to go about it differently. But NOTE: this is a temptation, luring us into a tie into the specifics of a framework we decide to commit ourself into in such a way. As you can see in #987 and #2276 and, I am sure numerous upgrade attempts by others as well, what you describe is not as simple as you say without isolating the use of an external library. I will follow up on this PR given mandate. we need to reduce the internal exposure to external libraries, not reinventing the wheel but isolating there use in proxy libraries. Your solution to upgrading log4j is not unifying logging framework use but only upgrading log4j as a one off solution essentially perpetuating the problem. In short, this PoC in itself will not solve the problem. it needs follow up and I dedicate myself to that. I do not want a PR like #2276, with 1710 files changed if a dependency decides to change a signature or a exposed structure. This will disable merging forward and hinder regular maintenance. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
