[GitHub] blueorangutan commented on issue #3078: Add influxdb to statscollector

2019-01-08 Thread GitBox
blueorangutan commented on issue #3078: Add influxdb to statscollector URL: https://github.com/apache/cloudstack/pull/3078#issuecomment-452602362 @GabrielBrascher a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. -

[GitHub] GabrielBrascher commented on issue #3078: Add influxdb to statscollector

2019-01-08 Thread GitBox
GabrielBrascher commented on issue #3078: Add influxdb to statscollector URL: https://github.com/apache/cloudstack/pull/3078#issuecomment-452602330 @blueorangutan package This is an automated message from the Apache Git Servic

[GitHub] GabrielBrascher commented on a change in pull request #3078: Add influxdb to statscollector

2019-01-08 Thread GitBox
GabrielBrascher commented on a change in pull request #3078: Add influxdb to statscollector URL: https://github.com/apache/cloudstack/pull/3078#discussion_r246283874 ## File path: server/src/main/java/com/cloud/server/StatsCollector.java ## @@ -155,16 +164,51 @@ public Str

[GitHub] blueorangutan commented on issue #3078: Add influxdb to statscollector

2019-01-08 Thread GitBox
blueorangutan commented on issue #3078: Add influxdb to statscollector URL: https://github.com/apache/cloudstack/pull/3078#issuecomment-452398788 Trillian test result (tid-3299) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 25625 seconds Mar

[GitHub] dubauski commented on issue #3025: VPC Router Corruption when working with large number of networks containing instances with public IP addresses

2019-01-08 Thread GitBox
dubauski commented on issue #3025: VPC Router Corruption when working with large number of networks containing instances with public IP addresses URL: https://github.com/apache/cloudstack/issues/3025#issuecomment-452375811 Any updates? --

[GitHub] dhlaluku commented on a change in pull request #3078: Add influxdb to statscollector

2019-01-08 Thread GitBox
dhlaluku commented on a change in pull request #3078: Add influxdb to statscollector URL: https://github.com/apache/cloudstack/pull/3078#discussion_r246058147 ## File path: server/src/main/java/com/cloud/server/StatsCollector.java ## @@ -155,16 +164,51 @@ public String toS

[GitHub] wido commented on issue #2795: kvm: Properly report available memory to Management Server

2019-01-08 Thread GitBox
wido commented on issue #2795: kvm: Properly report available memory to Management Server URL: https://github.com/apache/cloudstack/pull/2795#issuecomment-452351867 I just force pushed. This seems to be a thing (Unit Test) which fails on Travis, but works on my local system. Could b

[GitHub] wido commented on issue #3078: Add influxdb to statscollector

2019-01-08 Thread GitBox
wido commented on issue #3078: Add influxdb to statscollector URL: https://github.com/apache/cloudstack/pull/3078#issuecomment-452317071 I tested this PR on a Management Server with about 500 Virtual Machines pointing to a InfluxDB host running on localhost: influx://localhost/cl

[GitHub] GabrielBrascher commented on a change in pull request #3078: Add influxdb to statscollector

2019-01-08 Thread GitBox
GabrielBrascher commented on a change in pull request #3078: Add influxdb to statscollector URL: https://github.com/apache/cloudstack/pull/3078#discussion_r246011524 ## File path: server/src/main/java/com/cloud/server/StatsCollector.java ## @@ -497,86 +572,35 @@ protected

[GitHub] GabrielBrascher commented on a change in pull request #3078: Add influxdb to statscollector

2019-01-08 Thread GitBox
GabrielBrascher commented on a change in pull request #3078: Add influxdb to statscollector URL: https://github.com/apache/cloudstack/pull/3078#discussion_r246011524 ## File path: server/src/main/java/com/cloud/server/StatsCollector.java ## @@ -497,86 +572,35 @@ protected

[GitHub] DaanHoogland commented on a change in pull request #3078: Add influxdb to statscollector

2019-01-08 Thread GitBox
DaanHoogland commented on a change in pull request #3078: Add influxdb to statscollector URL: https://github.com/apache/cloudstack/pull/3078#discussion_r246006700 ## File path: utils/src/main/java/org/apache/cloudstack/utils/graphite/GraphiteClient.java ## @@ -67,7 +67,7

[GitHub] blueorangutan commented on issue #2795: kvm: Properly report available memory to Management Server

2019-01-08 Thread GitBox
blueorangutan commented on issue #2795: kvm: Properly report available memory to Management Server URL: https://github.com/apache/cloudstack/pull/2795#issuecomment-452300721 Packaging result: ✖centos6 ✖centos7 ✖debian. JID-2518 --

[GitHub] rhtyd commented on issue #2795: kvm: Properly report available memory to Management Server

2019-01-08 Thread GitBox
rhtyd commented on issue #2795: kvm: Properly report available memory to Management Server URL: https://github.com/apache/cloudstack/pull/2795#issuecomment-452300163 @wido can you check and fix build failures, see job 1 of travis

[GitHub] blueorangutan commented on issue #2795: kvm: Properly report available memory to Management Server

2019-01-08 Thread GitBox
blueorangutan commented on issue #2795: kvm: Properly report available memory to Management Server URL: https://github.com/apache/cloudstack/pull/2795#issuecomment-452297763 @dhlaluku a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. ---

[GitHub] dhlaluku commented on issue #2795: kvm: Properly report available memory to Management Server

2019-01-08 Thread GitBox
dhlaluku commented on issue #2795: kvm: Properly report available memory to Management Server URL: https://github.com/apache/cloudstack/pull/2795#issuecomment-452297552 @blueorangutan package This is an automated message from

[GitHub] blueorangutan commented on issue #2795: kvm: Properly report available memory to Management Server

2019-01-08 Thread GitBox
blueorangutan commented on issue #2795: kvm: Properly report available memory to Management Server URL: https://github.com/apache/cloudstack/pull/2795#issuecomment-452291697 Packaging result: ✖centos6 ✖centos7 ✖debian. JID-2517 --

[GitHub] blueorangutan commented on issue #2795: kvm: Properly report available memory to Management Server

2019-01-08 Thread GitBox
blueorangutan commented on issue #2795: kvm: Properly report available memory to Management Server URL: https://github.com/apache/cloudstack/pull/2795#issuecomment-452288934 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. --

[GitHub] rhtyd commented on issue #2795: kvm: Properly report available memory to Management Server

2019-01-08 Thread GitBox
rhtyd commented on issue #2795: kvm: Properly report available memory to Management Server URL: https://github.com/apache/cloudstack/pull/2795#issuecomment-452288679 @wido let's test one last time @blueorangutan package Th

[GitHub] wido commented on issue #2795: kvm: Properly report available memory to Management Server

2019-01-08 Thread GitBox
wido commented on issue #2795: kvm: Properly report available memory to Management Server URL: https://github.com/apache/cloudstack/pull/2795#issuecomment-452284356 Jenkins is happy now. How are we with this PR? Can we merge it? All comments seem to be adressed -

[GitHub] GabrielBrascher commented on issue #3078: Add influxdb to statscollector

2019-01-08 Thread GitBox
GabrielBrascher commented on issue #3078: Add influxdb to statscollector URL: https://github.com/apache/cloudstack/pull/3078#issuecomment-452278953 I have been testing this for a while, it is all working fine. JUnit tests have passed. I would really appreciate some extra reviews @DaanHoo

[GitHub] wido commented on a change in pull request #3122: Add back ability to disable backup of snapshot to secondary

2019-01-08 Thread GitBox
wido commented on a change in pull request #3122: Add back ability to disable backup of snapshot to secondary URL: https://github.com/apache/cloudstack/pull/3122#discussion_r245956538 ## File path: server/src/com/cloud/storage/snapshot/SnapshotManagerImpl.java ## @@ -1123,

[GitHub] wido commented on a change in pull request #3122: Add back ability to disable backup of snapshot to secondary

2019-01-08 Thread GitBox
wido commented on a change in pull request #3122: Add back ability to disable backup of snapshot to secondary URL: https://github.com/apache/cloudstack/pull/3122#discussion_r245956480 ## File path: server/src/com/cloud/storage/snapshot/SnapshotManagerImpl.java ## @@ -1123,

[GitHub] blueorangutan commented on issue #3078: Add influxdb to statscollector

2019-01-08 Thread GitBox
blueorangutan commented on issue #3078: Add influxdb to statscollector URL: https://github.com/apache/cloudstack/pull/3078#issuecomment-452255105 @GabrielBrascher a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests ---

[GitHub] GabrielBrascher commented on issue #3078: Add influxdb to statscollector

2019-01-08 Thread GitBox
GabrielBrascher commented on issue #3078: Add influxdb to statscollector URL: https://github.com/apache/cloudstack/pull/3078#issuecomment-452254882 @blueorangutan test This is an automated message from the Apache Git Service.

[GitHub] blueorangutan commented on issue #3078: Add influxdb to statscollector

2019-01-08 Thread GitBox
blueorangutan commented on issue #3078: Add influxdb to statscollector URL: https://github.com/apache/cloudstack/pull/3078#issuecomment-452253764 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2516 This is an automated messa

[GitHub] wido commented on issue #3112: network: Offerings do not have to have Security Grouping enabled

2019-01-08 Thread GitBox
wido commented on issue #3112: network: Offerings do not have to have Security Grouping enabled URL: https://github.com/apache/cloudstack/pull/3112#issuecomment-452249764 @DaanHoogland I am wondering why this has to be enforced at the zone level? You can only set it to True/False, bu

[GitHub] blueorangutan commented on issue #3078: Add influxdb to statscollector

2019-01-08 Thread GitBox
blueorangutan commented on issue #3078: Add influxdb to statscollector URL: https://github.com/apache/cloudstack/pull/3078#issuecomment-452247244 @GabrielBrascher a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. -

[GitHub] GabrielBrascher commented on issue #3078: Add influxdb to statscollector

2019-01-08 Thread GitBox
GabrielBrascher commented on issue #3078: Add influxdb to statscollector URL: https://github.com/apache/cloudstack/pull/3078#issuecomment-452247117 @blueorangutan package This is an automated message from the Apache Git Se

[GitHub] GabrielBrascher closed pull request #3101: kvm: Set amount of queues for Virtio SCSI driver to vCPU of Instance

2019-01-08 Thread GitBox
GabrielBrascher closed pull request #3101: kvm: Set amount of queues for Virtio SCSI driver to vCPU of Instance URL: https://github.com/apache/cloudstack/pull/3101 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake

[GitHub] GabrielBrascher commented on issue #3101: kvm: Set amount of queues for Virtio SCSI driver to vCPU of Instance

2019-01-08 Thread GitBox
GabrielBrascher commented on issue #3101: kvm: Set amount of queues for Virtio SCSI driver to vCPU of Instance URL: https://github.com/apache/cloudstack/pull/3101#issuecomment-452234566 Merging this based on Trillian test results, manual tests, and that we have 4 LGTMs. Travis failures

[cloudstack] branch master updated: kvm: Set amount of queues for Virtio SCSI driver to vCPU of Instance (#3101)

2019-01-08 Thread gabriel
This is an automated email from the ASF dual-hosted git repository. gabriel pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/master by this push: new c565db2 kvm: Set amount of queues for Virt

[GitHub] GabrielBrascher commented on issue #3078: Add influxdb to statscollector

2019-01-08 Thread GitBox
GabrielBrascher commented on issue #3078: Add influxdb to statscollector URL: https://github.com/apache/cloudstack/pull/3078#issuecomment-45217 Updated PR pushing the following change. In order to avoid redudancy, removed the following tags: ``` private static final String H

[GitHub] wido commented on issue #3070: kvm: Refactory VXLAN script and add IPv6 support

2019-01-08 Thread GitBox
wido commented on issue #3070: kvm: Refactory VXLAN script and add IPv6 support URL: https://github.com/apache/cloudstack/pull/3070#issuecomment-452220442 @DaanHoogland Thanks! We do not have integration tests for this. That's why I asked for manual testing by users which all came back with