[GitHub] rafaelweingartner commented on a change in pull request #3170: NotImplemented as a local exception

[GitBox]

rafaelweingartner commented on a change in pull request #3170: NotImplemented 
as a local exception
URL: https://github.com/apache/cloudstack/pull/3170#discussion_r255248770
 
 

 ##
 File path: 
plugins/hypervisors/kvm/src/main/java/org/apache/cloudstack/utils/qemu/QemuImg.java
 ##
 @@ -72,7 +70,7 @@ public static PreallocationType getPreallocationType(final 
Storage.ProvisioningT
 case FAT:
 return PreallocationType.Full;
 default:
-throw new NotImplementedException();
+throw new NotImplementedProvisioningTypeException();
 
 Review comment:
   What if instead, you throw a cloud runtime with a message describing the 
problem/error here?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] falcon78921 commented on issue #3166: scripts/network/exdhcp: cleaned up code in dhcpd_edithosts.py

[GitBox]

falcon78921 commented on issue #3166: scripts/network/exdhcp: cleaned up code 
in dhcpd_edithosts.py
URL: https://github.com/apache/cloudstack/pull/3166#issuecomment-461948817
 
 
   @DaanHoogland Yeah, I used ``str.format()``, which is becoming a more 
widespread and recommended way to format strings in Python3 (replacing the 
``%`` operator). I saw that ``os.path`` is also used. ``pathlib`` is becoming a 
better alternative for file manipulations as well (replacing ``os.path``). If 
there's anything I'm missing, please let me know and I'll fix. :) 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] GabrielBrascher opened a new pull request #3171: Keep iotune section in the VM's XML after live migration

[GitBox]

GabrielBrascher opened a new pull request #3171: Keep iotune section in the 
VM's XML after live migration
URL: https://github.com/apache/cloudstack/pull/3171
 
 
   ## Description
   
   When live migrating a KVM VM among local storages, the VM loses the
   `` section on its XML, therefore, having no IO limitations.
   
   ```

   5000
   5000
   
   ```
   This commit removes the piece of code that deletes the  section in 
the XML.
   
   @rhtyd @mike-tutkowski @wido @DaanHoogland @nvazquez @kiwiflyer 
@rafaelweingartner do any of you guys know a reason for keeping the conditional 
that I removed? It looks like it can be removed without breaking anything.
   
   
   
   
   
   
   
   
   ## Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [x] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ## Screenshots (if appropriate):
   
   ## How Has This Been Tested?
   
   
   
   **Bug:**
   - Start a VM running on KVM, with local storage and service offering 
limiting the VM's IOPS;
   - verify that the VM's XML file contains ` ... `;
   - live migrate to another host (with local storage);
   - verify that the ` ... ` section **has been removed** in 
the VM's XML;
   
   **With the fix:**
   - Start a VM running on KVM, with local storage and service offering 
limiting the VM's IOPS;
   - verify that the VM's XML file contains ` ... `;
   - live migrate to another host (with local storage);
   - verify that the ` ... ` section **stayed** in the VM's XML
   
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[cloudstack] branch iotune-removed-from-xml-on-kvm-migration deleted (was 8439b0b)

[gabriel]

This is an automated email from the ASF dual-hosted git repository.

gabriel pushed a change to branch iotune-removed-from-xml-on-kvm-migration
in repository https://gitbox.apache.org/repos/asf/cloudstack.git.


 was 8439b0b  Keep iotune section in the VM's XML after live migration

This change permanently discards the following revisions:

 discard 8439b0b  Keep iotune section in the VM's XML after live migration

[GitHub] blueorangutan commented on issue #3170: NotImplemented as a local exception

[GitBox]

blueorangutan commented on issue #3170: NotImplemented as a local exception
URL: https://github.com/apache/cloudstack/pull/3170#issuecomment-461811277
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2602


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #3170: NotImplemented as a local exception

[GitBox]

blueorangutan commented on issue #3170: NotImplemented as a local exception
URL: https://github.com/apache/cloudstack/pull/3170#issuecomment-461805460
 
 
   @DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you 
posted as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] DaanHoogland commented on issue #3170: NotImplemented as a local exception

[GitBox]

DaanHoogland commented on issue #3170: NotImplemented as a local exception
URL: https://github.com/apache/cloudstack/pull/3170#issuecomment-461805232
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2992: PoC for log library surface reduction (2991)

[GitBox]

blueorangutan commented on issue #2992: PoC for log library surface reduction 
(2991)
URL: https://github.com/apache/cloudstack/pull/2992#issuecomment-461787575
 
 
   @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has 
been kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] DaanHoogland commented on issue #2992: PoC for log library surface reduction (2991)

[GitBox]

DaanHoogland commented on issue #2992: PoC for log library surface reduction 
(2991)
URL: https://github.com/apache/cloudstack/pull/2992#issuecomment-461787365
 
 
   @blueorangutan test


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2992: PoC for log library surface reduction (2991)

[GitBox]

blueorangutan commented on issue #2992: PoC for log library surface reduction 
(2991)
URL: https://github.com/apache/cloudstack/pull/2992#issuecomment-461786694
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2601


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] DaanHoogland opened a new pull request #3170: NotImplemented as a local exception

[GitBox]

DaanHoogland opened a new pull request #3170: NotImplemented as a local 
exception
URL: https://github.com/apache/cloudstack/pull/3170
 
 
   ## Description
   
   
   NotImplementedException from sun.reflect.generics.reflectiveObjects is not 
standard/guarateed by the jvm so a custom implementation is in order.
   
   ## Types of changes
   
   - [x] Bug fix (non-breaking change which fixes an issue)
   - [x] Cleanup (Code refactoring and cleanup, that may add test cases)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2992: PoC for log library surface reduction (2991)

[GitBox]

blueorangutan commented on issue #2992: PoC for log library surface reduction 
(2991)
URL: https://github.com/apache/cloudstack/pull/2992#issuecomment-461781842
 
 
   @DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you 
posted as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] DaanHoogland commented on issue #2992: PoC for log library surface reduction (2991)

[GitBox]

DaanHoogland commented on issue #2992: PoC for log library surface reduction 
(2991)
URL: https://github.com/apache/cloudstack/pull/2992#issuecomment-461781633
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Jenkins build is back to normal : cloudstack-apidocs-master #3070

[Apache Jenkins Server]

See